Checkmk git commits December 2020

checkmk-commits@lists.checkmk.com

1 participants
650 discussions

[tribe29/checkmk] 5df3b5: CMK-6197: ups_battery_state: New check for UPS Eat...

by Andreas Umbreit

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 5df3b585ae3f81433188951bde0344852fd54906 https://github.com/tribe29/checkmk/commit/5df3b585ae3f81433188951bde0344852… Author: Andreas Umbreit <andreas.umbreit(a)tribe29.com> Date: 2020-12-02 (Wed, 02 Dec 2020) Changed paths: A .werks/11718 A checkman/ups_battery_state M checkman/ups_capacity R checks/ups_capacity R cmk/base/check_legacy_includes/ups_capacity.py A cmk/base/plugins/agent_based/ups_battery_state.py A cmk/base/plugins/agent_based/ups_capacity.py A cmk/base/plugins/agent_based/ups_eaton_mg.py A cmk/base/plugins/agent_based/utils/ups.py M cmk/gui/plugins/metrics/environment.py M cmk/gui/plugins/metrics/translation.py R tests/unit/checks/generictests/datasets/ups_capacity_invalid_time_left.py M tests/unit/checks/test_generic_legacy_conversion.py A tests/unit/cmk/base/plugins/agent_based/utils/test_ups.py Log Message: ----------- CMK-6197: ups_battery_state: New check for UPS Eaton battery state - New utils.ups module, with generic check functions for battery capacity and battery state - Migrated ups_capacity.include to the new utils.ups module - Migrated check ups_capacity to use the generic check function from utils.ups - Added proper metric_info for ups_capacity metrics - New check ups_battery_state, that uses the generic check_ups_battery_state function from utils.ups - New check_sections for UPS Eaton devices, that read out information about battery capacity and states from "Merlin Gerin" labeled OIDs - Add Werk #11718 Change-Id: I9221067943aac0f2644f3a77d9042cc645a1d09e

3 years, 7 months

[tribe29/checkmk] 37bbe8: CMK-6197: ups_battery_state: New check for UPS Eat...

by Andreas Umbreit

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 37bbe85cd5fbd456b7811c9c3558b9e892312cfa https://github.com/tribe29/checkmk/commit/37bbe85cd5fbd456b7811c9c3558b9e89… Author: Andreas Umbreit <andreas.umbreit(a)tribe29.com> Date: 2020-12-02 (Wed, 02 Dec 2020) Changed paths: A .werks/11718 A checkman/ups_battery_state M checkman/ups_capacity R checks/ups_capacity R cmk/base/check_legacy_includes/ups_capacity.py A cmk/base/plugins/agent_based/ups_battery_state.py A cmk/base/plugins/agent_based/ups_capacity.py A cmk/base/plugins/agent_based/ups_eaton_mg.py A cmk/base/plugins/agent_based/utils/ups.py M cmk/gui/plugins/metrics/environment.py M cmk/gui/plugins/metrics/translation.py R tests/unit/checks/generictests/datasets/ups_capacity_invalid_time_left.py M tests/unit/checks/test_generic_legacy_conversion.py A tests/unit/cmk/base/plugins/agent_based/utils/test_ups.py Log Message: ----------- CMK-6197: ups_battery_state: New check for UPS Eaton battery state - New utils.ups module, with generic check functions for battery capacity and battery state - Migrated ups_capacity.include to the new utils.ups module - Migrated check ups_capacity to use the generic check function from utils.ups - Added proper metric_info for ups_capacity metrics - New check ups_battery_state, that uses the generic check_ups_battery_state function from utils.ups - New check_sections for UPS Eaton devices, that read out information about battery capacity and states from "Merlin Gerin" labeled OIDs - Add Werk #11718 Change-Id: I0abaf6b410b084048b52ea87f6f2b4fe5155da79

3 years, 7 months

[tribe29/checkmk] c91675: Refactoring: Extract a function to split a composi...

by Sven Panne

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: c9167532ff31624dd76422a890e22bd869a8c8e8 https://github.com/tribe29/checkmk/commit/c9167532ff31624dd76422a890e22bd86… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2020-12-02 (Wed, 02 Dec 2020) Changed paths: M livestatus/src/StringUtils.cc M livestatus/src/StringUtils.h M livestatus/src/TableServices.cc Log Message: ----------- Refactoring: Extract a function to split a composite key into 2 parts. Added a 3-part version, too, we will need it soon. Change-Id: Idcf4c73112afc5bbc25d343c775b29ed283d1730

3 years, 7 months

[tribe29/checkmk] 8dcae7: Fix unit tests

by Jörg Herbel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 8dcae797022b8b8782465e2f7d319b1d3b4ccfa2 https://github.com/tribe29/checkmk/commit/8dcae797022b8b8782465e2f7d319b1d3… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-12-02 (Wed, 02 Dec 2020) Changed paths: M tests/unit/checks/test_generic_legacy_conversion.py Log Message: ----------- Fix unit tests They broke because of the migration of the last remaining if-checks. Change-Id: I60515a289f801c92bf8826cf1f635df72980d46f

3 years, 7 months

[tribe29/checkmk] e6f5fd: Fix unit tests

by Jörg Herbel

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: e6f5fd28995df70e2314029b1f9be1b466270f8d https://github.com/tribe29/checkmk/commit/e6f5fd28995df70e2314029b1f9be1b46… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-12-02 (Wed, 02 Dec 2020) Changed paths: M tests/unit/checks/test_generic_legacy_conversion.py Log Message: ----------- Fix unit tests They broke because of the migration of the last remaining if-checks. Change-Id: I60515a289f801c92bf8826cf1f635df72980d46f

3 years, 7 months

[tribe29/checkmk] 444f38: Migrate cadvisor_if to new check API

by Jörg Herbel

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 444f384bc7da4a1b60e6b18f71c05d5b17bc9927 https://github.com/tribe29/checkmk/commit/444f384bc7da4a1b60e6b18f71c05d5b1… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-12-02 (Wed, 02 Dec 2020) Changed paths: R checks/cadvisor_if A cmk/base/plugins/agent_based/cadvisor_if.py M tests/unit/checks/test_generic_legacy_conversion.py A tests/unit/cmk/base/plugins/agent_based/test_cadvisor_if.py Log Message: ----------- Migrate cadvisor_if to new check API CMK-6570 Change-Id: I92e6587eb390c121fc5f11de68855e14bcf405d9 Commit: 25b92bb8ef3a164ceaddf213ab3f3a6ece137234 https://github.com/tribe29/checkmk/commit/25b92bb8ef3a164ceaddf213ab3f3a6ec… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-12-02 (Wed, 02 Dec 2020) Changed paths: M cmk/gui/plugins/wato/check_parameters/interfaces.py Log Message: ----------- Move transform function of if check parameters closer to corresponding valuespec CMK-6472 FEED-5356 Change-Id: I99c2717e91a33fd20c5b87f9444a280da63fc9c4 Commit: 2815e2c36edf7dd04f5d7dc67a714591eb567504 https://github.com/tribe29/checkmk/commit/2815e2c36edf7dd04f5d7dc67a714591e… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-12-02 (Wed, 02 Dec 2020) Changed paths: M cmk/base/plugins/agent_based/utils/interfaces.py M cmk/gui/plugins/wato/check_parameters/interfaces.py M tests/unit/cmk/base/plugins/agent_based/utils/test_interfaces.py M tests/unit/cmk/gui/plugins/wato/check_parameters/test_if_parameters.py Log Message: ----------- Remove transform of if check parameters from if-utils This is now handled during cmk-update-config. Also add some corresponding unit tests and fix a small bug in the transform (which luckily had no visible effects). CMK-6472 FEED-5356 Change-Id: I9caceba6618ad12adeb73fb2561ca98b2bcd493c Compare: https://github.com/tribe29/checkmk/compare/8b075ceb0898...2815e2c36edf

3 years, 7 months

[tribe29/checkmk] de9eb0: Refactoring: Renamed Table::findObject() and its p...

by Sven Panne

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: de9eb0c8a069e1266e6ccca9b9ea8d684aea8f6e https://github.com/tribe29/checkmk/commit/de9eb0c8a069e1266e6ccca9b9ea8d684… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2020-12-02 (Wed, 02 Dec 2020) Changed paths: M livestatus/src/Query.cc M livestatus/src/Table.cc M livestatus/src/Table.h M livestatus/src/TableContactGroups.cc M livestatus/src/TableContactGroups.h M livestatus/src/TableContacts.cc M livestatus/src/TableContacts.h M livestatus/src/TableHostGroups.cc M livestatus/src/TableHostGroups.h M livestatus/src/TableHosts.cc M livestatus/src/TableHosts.h M livestatus/src/TableServiceGroups.cc M livestatus/src/TableServiceGroups.h M livestatus/src/TableServices.cc M livestatus/src/TableServices.h Log Message: ----------- Refactoring: Renamed Table::findObject() and its parameter. Change-Id: I9fb935643afd937ba7a6146bf881436fb23a41d8

3 years, 7 months

[tribe29/checkmk] 64e2e2: Add some diagnostic output to track down integrati...

by Jörg Herbel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 64e2e2a6f49ccbde396f97743acf101da33cb46b https://github.com/tribe29/checkmk/commit/64e2e2a6f49ccbde396f97743acf101da… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-12-02 (Wed, 02 Dec 2020) Changed paths: M tests/testlib/site.py Log Message: ----------- Add some diagnostic output to track down integration test problems Change-Id: Id1777c75d9008e5afef0041db853b30f6aebb4ba Commit: 3798b0f9625fd53df787b5b3efd3134d92d424c1 https://github.com/tribe29/checkmk/commit/3798b0f9625fd53df787b5b3efd3134d9… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-12-02 (Wed, 02 Dec 2020) Changed paths: M tests/testlib/web_session.py Log Message: ----------- Add some diagnostic output to track down integration test problems #2 Change-Id: Ib1e9d89976c74de99683206aa2a714b2776eed08 Commit: 23dc3808251c330205f5da8659de28c38ee049ba https://github.com/tribe29/checkmk/commit/23dc3808251c330205f5da8659de28c38… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-12-02 (Wed, 02 Dec 2020) Changed paths: M tests/testlib/web_session.py Log Message: ----------- Add diagnostic output to track down integration test problems #3 Change-Id: I922a451d95ab6117517bcf9af1dbb93627d2cbb4 Commit: b33af17611c00931e79157ff9c0a0c5f1c7e251c https://github.com/tribe29/checkmk/commit/b33af17611c00931e79157ff9c0a0c5f1… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-12-02 (Wed, 02 Dec 2020) Changed paths: A .werks/11617 M cmk/gui/watolib/activate_changes.py Log Message: ----------- 11617 FIX Activate changes: Improve error handling when trying to activate changes of offline sites When triggering the activate changes API calls in "dirty" mode (activate all changes on all dirty sites), the offline sites were automatically excluded. In this situation the activation was performed with an empty list of sites. Resulting in an empty result set. Leaving the user with the question why his changes were not activated. To be more consistent, the situation is now detected and an error is raised, explaining the situation to the user: <pre>There are changes to activate, but no site can be activated (The sites A, B, C have changes, but may be offline or not logged in).</pre> The caller needs wait and retry the operation at a later time once the sites in question are reachable again. Change-Id: I8321db4c28a7694b1f4cf7141212ff85244a03d5 Commit: e1adb3c92fcb437f2f2cd7fc03611f2b7a67be60 https://github.com/tribe29/checkmk/commit/e1adb3c92fcb437f2f2cd7fc03611f2b7… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-12-02 (Wed, 02 Dec 2020) Changed paths: A .werks/11616 M cmk/gui/plugins/views/utils.py Log Message: ----------- 11616 FIX Fix links to hosts / services from service dashlets Since Checkmk 2.0.0b1 the links from view dashlets to hosts and service views were not set correctly. The display_option request parameter was accidentally set and resulted in "broken pages" when following the links. Change-Id: I996e1ca429d9e5d021a9a531189eb78af124a61b Commit: f7bcb02491a8f81787d5c3595918d940903488cf https://github.com/tribe29/checkmk/commit/f7bcb02491a8f81787d5c3595918d9409… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-12-02 (Wed, 02 Dec 2020) Changed paths: M checks/netapp_api_fcp Log Message: ----------- Remove legacy if-include from legacy check netapp_api_fcp CMK-6570 Change-Id: I75b5630f35aa870ca96b99f42e54eadf049a52ea Commit: b03b5477348d60acafaf53b3ae7d7751ebc89d36 https://github.com/tribe29/checkmk/commit/b03b5477348d60acafaf53b3ae7d7751e… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-12-02 (Wed, 02 Dec 2020) Changed paths: R checks/cadvisor_if A cmk/base/plugins/agent_based/cadvisor_if.py M tests/unit/checks/test_generic_legacy_conversion.py A tests/unit/cmk/base/plugins/agent_based/test_cadvisor_if.py Log Message: ----------- Migrate cadvisor_if to new check API CMK-6570 Change-Id: I92e6587eb390c121fc5f11de68855e14bcf405d9 Commit: 6475cad19ac1f0e243be589d660566df8b3f9a4a https://github.com/tribe29/checkmk/commit/6475cad19ac1f0e243be589d660566df8… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-12-02 (Wed, 02 Dec 2020) Changed paths: M cmk/gui/plugins/wato/check_parameters/interfaces.py Log Message: ----------- Move transform function of if check parameters closer to corresponding valuespec CMK-6472 FEED-5356 Change-Id: I99c2717e91a33fd20c5b87f9444a280da63fc9c4 Commit: 7909bfabfe093609386b6ed2edca08289d7c0680 https://github.com/tribe29/checkmk/commit/7909bfabfe093609386b6ed2edca08289… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-12-02 (Wed, 02 Dec 2020) Changed paths: M cmk/base/plugins/agent_based/utils/interfaces.py M cmk/gui/plugins/wato/check_parameters/interfaces.py M tests/unit/cmk/base/plugins/agent_based/utils/test_interfaces.py M tests/unit/cmk/gui/plugins/wato/check_parameters/test_if_parameters.py Log Message: ----------- Remove transform of if check parameters from if-utils This is now handled during cmk-update-config. Also add some corresponding unit tests and fix a small bug in the transform (which luckily had no visible effects). CMK-6472 FEED-5356 Change-Id: I9caceba6618ad12adeb73fb2561ca98b2bcd493c Compare: https://github.com/tribe29/checkmk/compare/b3b79a040010...7909bfabfe09

3 years, 7 months

[tribe29/checkmk] f842d1: 11617 FIX Activate changes: Improve error handling...

by Jörg Herbel

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: f842d1aa294dd2343cd136c3c9b6961bdfcf1ca2 https://github.com/tribe29/checkmk/commit/f842d1aa294dd2343cd136c3c9b6961bd… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-12-02 (Wed, 02 Dec 2020) Changed paths: A .werks/11617 M cmk/gui/watolib/activate_changes.py Log Message: ----------- 11617 FIX Activate changes: Improve error handling when trying to activate changes of offline sites When triggering the activate changes API calls in "dirty" mode (activate all changes on all dirty sites), the offline sites were automatically excluded. In this situation the activation was performed with an empty list of sites. Resulting in an empty result set. Leaving the user with the question why his changes were not activated. To be more consistent, the situation is now detected and an error is raised, explaining the situation to the user: <pre>There are changes to activate, but no site can be activated (The sites A, B, C have changes, but may be offline or not logged in).</pre> The caller needs wait and retry the operation at a later time once the sites in question are reachable again. Change-Id: I8321db4c28a7694b1f4cf7141212ff85244a03d5 Commit: 8b075ceb0898d18d62c89ee5110b926f56ecf8dd https://github.com/tribe29/checkmk/commit/8b075ceb0898d18d62c89ee5110b926f5… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-12-02 (Wed, 02 Dec 2020) Changed paths: M checks/netapp_api_fcp Log Message: ----------- Remove legacy if-include from legacy check netapp_api_fcp CMK-6570 Change-Id: I75b5630f35aa870ca96b99f42e54eadf049a52ea Compare: https://github.com/tribe29/checkmk/compare/b43686189e73...8b075ceb0898

3 years, 7 months

[tribe29/checkmk] ad9625: 11616 FIX Fix accidental publishing of cloned user...

by Lars

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: ad9625315e7065df0ff63aa0b4d29a0ddfa82c45 https://github.com/tribe29/checkmk/commit/ad9625315e7065df0ff63aa0b4d29a0dd… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-12-02 (Wed, 02 Dec 2020) Changed paths: A .werks/11616 M cmk/gui/pagetypes.py Log Message: ----------- 11616 FIX Fix accidental publishing of cloned user elements (e.g. bookmark lists) When a user clones e.g. a public shared bookmark list of another user, the "public" flag was inherited during that clone operation and the cloned bookmark list was shared to other users despite the fact that the user was not permitted to share things to other users. This change adds an information about the visibility to other users to the edit page of these elements: "The view is only visible to you. You can not share it, because you don't have the permission to share it." The permission of the owner to share elements is now explicitly checked when trying accessing the elements as another user. Besides the bookmark list other elements like custom snapins, custom graphs, forecast graphs, SLAs, graph collections and graph tunings were also affected. Change-Id: Ib73fd6ec0b0baccc3365668532161eb04575d006

3 years, 7 months

← Newer
1
...
56
57
58
59
60
61
62
...
65
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits December 2020