Checkmk git commits December 2020

checkmk-commits@lists.checkmk.com

1 participants
650 discussions

[tribe29/checkmk] 34d72a: Setup search: various small improvements

by Jörg Herbel

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 34d72a0df7fa34cab81f4c793d97d9a64cfde2b9 https://github.com/tribe29/checkmk/commit/34d72a0df7fa34cab81f4c793d97d9a64… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-12-10 (Thu, 10 Dec 2020) Changed paths: M cmk/gui/plugins/sidebar/wato.py M cmk/gui/wato/mkeventd.py M cmk/gui/watolib/hosts_and_folders.py M cmk/gui/watolib/rulespecs.py M cmk/gui/watolib/search.py Log Message: ----------- Setup search: various small improvements Change-Id: I4e89943d3ad4578cbae569be6b0f7072a302545a

3 years, 10 months

[tribe29/checkmk] dd4082: Update werk text

by Timotheus Bachinger

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: dd408266355ae8381603e970a1b203bd307dca67 https://github.com/tribe29/checkmk/commit/dd408266355ae8381603e970a1b203bd3… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2020-12-10 (Thu, 10 Dec 2020) Changed paths: M .werks/11346 Log Message: ----------- Update werk text Change-Id: I3addaba98a074f1b17f09ccf002449469c5e222e

3 years, 10 months

[tribe29/checkmk] a95325: [CMK-6120]- remove obsolete globals related to tes...

by Sergey Kipnis

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: a95325ea4cb30e5142bd2c690784665848ca2b94 https://github.com/tribe29/checkmk/commit/a95325ea4cb30e5142bd2c69078466584… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2020-12-10 (Thu, 10 Dec 2020) Changed paths: R agents/wnx/build_release_classic.cmd M agents/wnx/readme.md M agents/wnx/src/engine/cfg.cpp M agents/wnx/src/engine/stdafx_defines.h M agents/wnx/src/main/check_mk_service.cpp M agents/wnx/src/player/pch.h M agents/wnx/src/player/plugin_player.cpp M agents/wnx/x.cmd Log Message: ----------- [CMK-6120]- remove obsolete globals related to testing/validation Also removed old build script, corrected readme, fixed code(no more globals) Change-Id: Ieb3ef52658184ba18f96cfe5bebb326a42167c36

3 years, 10 months

[tribe29/checkmk] 2bdbcc: Move activation_sites to config module

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 2bdbcc5d0b77dff24fdbd1b28d20afacdc01ab6a https://github.com/tribe29/checkmk/commit/2bdbcc5d0b77dff24fdbd1b28d20afacd… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-12-10 (Thu, 10 Dec 2020) Changed paths: M cmk/gui/config.py M cmk/gui/wato/pages/activate_changes.py M cmk/gui/wato/pages/analyze_configuration.py M cmk/gui/watolib/activate_changes.py M cmk/gui/watolib/changes.py Log Message: ----------- Move activation_sites to config module This is just another view on the collection of sites. Moving it next to the other site collection related functions seems to be a good idea. CMK-6497 Change-Id: I8eded1c697d6a4452d167986b13aa1fbbe648882 Commit: 8f073397a76a198d9f480a0bff279ab68b9d4b7e https://github.com/tribe29/checkmk/commit/8f073397a76a198d9f480a0bff279ab68… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-12-10 (Thu, 10 Dec 2020) Changed paths: M cmk/gui/config.py M cmk/gui/plugins/sidebar/performance.py M cmk/gui/sidebar.py M cmk/gui/wato/pages/diagnostics.py M cmk/gui/wato/pages/users.py Log Message: ----------- Cleanup config.site_choices API * Instead of a filter function the function gets SiteConfigurations collection and computes the choices for that collection. There is no filtering done anymore. * The CMC statistics and performance snapin now respect the user authorized sites instead of showing all sites. * Rename get_wato_site_choices to get_activation_site_choices for consistency CMK-6497 Change-Id: I3264871379b69f8a2ea4a818e6e63d25c2e73154 Commit: 346732abafdfeffeed2e92b26f885a9aa6bd4fa2 https://github.com/tribe29/checkmk/commit/346732abafdfeffeed2e92b26f885a9aa… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-12-10 (Thu, 10 Dec 2020) Changed paths: M cmk/gui/plugins/wato/builtin_attributes.py M cmk/gui/plugins/wato/utils/simple_modes.py M cmk/gui/valuespec.py Log Message: ----------- Cleanup site choices * Introduce MonitoringSiteChoice to be used in the monitoring world * Change SiteChoice name to SetupSiteChoice to clarify that this is a selection of sites relevant for the setup world. CMK-6497 Change-Id: I937d332238c9d23ece8591995fee4c39568620ab Commit: 6444d77351e77cc8661e467cd4bacbcf049eef78 https://github.com/tribe29/checkmk/commit/6444d77351e77cc8661e467cd4bacbcf0… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-12-10 (Thu, 10 Dec 2020) Changed paths: A .werks/11762 M cmk/gui/plugins/wato/utils/__init__.py M cmk/gui/valuespec.py Log Message: ----------- 11762 FIX Site attribute of hosts / folders is now limited to distributed setup sites In the host and folder attribute configuration, previous Checkmk versions allowed the user to select all configured remote sites. This included status only sites and remote sites Checkmk is replicating the configuration to. The setup is not able to replicate configurations to status only sites. For this reason it does not make sense to configure status only sites on hosts or folders. This change now excludes the status only sites from these attributes. Change-Id: I7154b0d1a45b8a8fbaa0dbf7cffd0b5b01122039 Compare: https://github.com/tribe29/checkmk/compare/d5059b3c0000...6444d77351e7

3 years, 10 months

[tribe29/checkmk] 2540d9: Move activation_sites to config module

by Lars

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 2540d9e8483e007076edc895bb5369f40b9e65ca https://github.com/tribe29/checkmk/commit/2540d9e8483e007076edc895bb5369f40… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-12-10 (Thu, 10 Dec 2020) Changed paths: M cmk/gui/config.py M cmk/gui/wato/pages/activate_changes.py M cmk/gui/wato/pages/analyze_configuration.py M cmk/gui/watolib/activate_changes.py M cmk/gui/watolib/changes.py Log Message: ----------- Move activation_sites to config module This is just another view on the collection of sites. Moving it next to the other site collection related functions seems to be a good idea. CMK-6497 Change-Id: I8eded1c697d6a4452d167986b13aa1fbbe648882 Commit: 3d6dd6874b0b338ee591fadb7eedd5c20f3e53ea https://github.com/tribe29/checkmk/commit/3d6dd6874b0b338ee591fadb7eedd5c20… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-12-10 (Thu, 10 Dec 2020) Changed paths: M cmk/gui/config.py M cmk/gui/plugins/sidebar/performance.py M cmk/gui/sidebar.py M cmk/gui/wato/pages/diagnostics.py M cmk/gui/wato/pages/users.py Log Message: ----------- Cleanup config.site_choices API * Instead of a filter function the function gets SiteConfigurations collection and computes the choices for that collection. There is no filtering done anymore. * The CMC statistics and performance snapin now respect the user authorized sites instead of showing all sites. * Rename get_wato_site_choices to get_activation_site_choices for consistency CMK-6497 Change-Id: I3264871379b69f8a2ea4a818e6e63d25c2e73154 Commit: bb7b1cdd6ce48322a0b714d972024e5223ad916d https://github.com/tribe29/checkmk/commit/bb7b1cdd6ce48322a0b714d972024e522… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-12-10 (Thu, 10 Dec 2020) Changed paths: M cmk/gui/plugins/wato/builtin_attributes.py M cmk/gui/plugins/wato/utils/simple_modes.py M cmk/gui/valuespec.py Log Message: ----------- Cleanup site choices * Introduce MonitoringSiteChoice to be used in the monitoring world * Change SiteChoice name to SetupSiteChoice to clarify that this is a selection of sites relevant for the setup world. CMK-6497 Change-Id: I937d332238c9d23ece8591995fee4c39568620ab Commit: 0a50ed2d5441033204c3eaed56afdefb7caf7e91 https://github.com/tribe29/checkmk/commit/0a50ed2d5441033204c3eaed56afdefb7… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-12-10 (Thu, 10 Dec 2020) Changed paths: A .werks/11762 M cmk/gui/plugins/wato/utils/__init__.py M cmk/gui/valuespec.py Log Message: ----------- 11762 FIX Site attribute of hosts / folders is now limited to distributed setup sites In the host and folder attribute configuration, previous Checkmk versions allowed the user to select all configured remote sites. This included status only sites and remote sites Checkmk is replicating the configuration to. The setup is not able to replicate configurations to status only sites. For this reason it does not make sense to configure status only sites on hosts or folders. This change now excludes the status only sites from these attributes. Change-Id: I7154b0d1a45b8a8fbaa0dbf7cffd0b5b01122039 Commit: dabb632f03f24ecc82241726d9bd5eee2bf2f082 https://github.com/tribe29/checkmk/commit/dabb632f03f24ecc82241726d9bd5eee2… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-12-10 (Thu, 10 Dec 2020) Changed paths: A omd/packages/python3-modules/patches/0002-jira-2.0.0-disable-setup.py-download.dif A omd/packages/python3-modules/patches/0003-swagger_ui-disable-setup.py-download.dif M omd/packages/python3-modules/python3-modules.make Log Message: ----------- python3-modules: Prevent module downloading * Some packages were not in the correct order * jira and swagger_ui_bundle have development tools in their setup_requires. This is not very clever, because it makes setup.py install these files even if one only wants to execute "python setup.py install". Since these tools are not needed and we really don't want them to be installed with Checkmk, it is better to remove these setup_requires declarations. Change-Id: Iaa1b475a6110042465dfe05842fecbe5d4333059 Compare: https://github.com/tribe29/checkmk/compare/9a47b7ab094d...dabb632f03f2

3 years, 10 months

[tribe29/checkmk] 9a47b7: Fix known ntop hosts page

by Timotheus Bachinger

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 9a47b7ab094d4a588d7ddf6afdde46b5995bf58c https://github.com/tribe29/checkmk/commit/9a47b7ab094d4a588d7ddf6afdde46b59… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2020-12-10 (Thu, 10 Dec 2020) Changed paths: M cmk/gui/views.py Log Message: ----------- Fix known ntop hosts page * use the ip address for the mapping between ntop and checkmk * fix access on empty array CMK-6686 Change-Id: Id0feafb67c507eb85cce9fb22da0c7baa384259c

3 years, 10 months

[tribe29/checkmk] d5059b: expressions: fix of tree_to_expr function where an...

by anthonyh209

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: d5059b3c00007534ba97087aa2c2dab142a990bd https://github.com/tribe29/checkmk/commit/d5059b3c00007534ba97087aa2c2dab14… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2020-12-10 (Thu, 10 Dec 2020) Changed paths: M cmk/gui/plugins/openapi/livestatus_helpers/expressions.py Log Message: ----------- expressions: fix of tree_to_expr function where and & or operators had non covering cases Change-Id: I6cede235f9fb583f77c13fed145ee1359e35830f

3 years, 10 months

[tribe29/checkmk] 33bd52: Fix known ntop hosts page

by Timotheus Bachinger

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 33bd52b7544301d8a67835d627f78d9bd164a3e6 https://github.com/tribe29/checkmk/commit/33bd52b7544301d8a67835d627f78d9bd… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2020-12-10 (Thu, 10 Dec 2020) Changed paths: M cmk/gui/views.py Log Message: ----------- Fix known ntop hosts page * use the ip address for the mapping between ntop and checkmk * fix access on empty array CMK-6686 Change-Id: Id0feafb67c507eb85cce9fb22da0c7baa384259c

3 years, 10 months

[tribe29/checkmk] 738a70: 11736 FIX Rename hosts: folders names for changed ...

by tklecker

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: 738a70c57c17c27bd27b93b5f3c08708308404ae https://github.com/tribe29/checkmk/commit/738a70c57c17c27bd27b93b5f3c087083… Author: Timo Klecker <klecker(a)decoit.de> Date: 2020-12-10 (Thu, 10 Dec 2020) Changed paths: A .werks/11736 M cmk/gui/wato/pages/host_rename.py Log Message: ----------- 11736 FIX Rename hosts: folders names for changed rules in audit log When renaming hosts, Checkmk adjusts the conditions of rules which include the renamed host. Such changes are recorded in the audit log, including the name of the folders which contain the adjusted rules. Up to now, these folder names were not displayed correctly. The audit log showed something like "Renamed host in 3 rulesets of folder <bound method CREFolder.title of Folder('', u'Main directory')>". With this werk, this becomes "Renamed host in 3 rulesets of folder Main directory". Note that this bug only affects version 1.6 and is already fixed in version 2.0. This merges PR #286, https://github.com/tribe29/checkmk/pull/286. Change-Id: I9c3227640561578657b805b0a7163406dd0abaf2

3 years, 10 months

[tribe29/checkmk] 00b1ba: Revert "Revert "Pass `snmp_fetch_interval` to fetc...

by Mathias Laurin

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 00b1bad4c42853853deb7bb371a7160949d5c7b0 https://github.com/tribe29/checkmk/commit/00b1bad4c42853853deb7bb371a716094… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-12-10 (Thu, 10 Dec 2020) Changed paths: M cmk/base/checkers/snmp.py M cmk/fetchers/snmp.py M tests/unit/cmk/fetchers/test_fetchers.py Log Message: ----------- Revert "Revert "Pass `snmp_fetch_interval` to fetcher"" Currently, we use the second field from the value of the PersistedSections to decide whether the cache should be invalidated or not. This field contains the unix time computed from the first field (the unix time when the data was cached) and the fetch interval at the time the value was cached. However, the computation is not updated when the user modifies the fetch interval. There is therefore no guarantee that the value from the DB is correct at any time after caching. Instead of using the value in the DB, we must always use the currently configured interval and we therefore: 1. pass the configured values to the fecther (this patch) and 2. compute the invalidation date from the first field and the current interval. Actually, the second field should *never* be used. CMK-6516 This reverts commit e0940cecea445c2478bb1af6fcaa562779265099. Change-Id: I91727e42e38880debb0e00f3368ef24296e26ecf Commit: 5166da0fcec9a4637bf5d88c3db2498fa8837138 https://github.com/tribe29/checkmk/commit/5166da0fcec9a4637bf5d88c3db2498fa… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-12-10 (Thu, 10 Dec 2020) Changed paths: M cmk/base/checkers/snmp.py M cmk/base/config.py M cmk/fetchers/snmp.py M tests/unit/cmk/base/test_config.py Log Message: ----------- Set fetch interval unit to seconds Timestamps in Python are typically given in seconds. Having a time delta in minutes is thus unexpected. Moreover, it is error prone as *every* user of this timestamp must multiply the value by 60. This patch lets the accessor from `config` return the value in seconds. CMK-6516 Change-Id: I1d6bf6da8192f186179311f9fb3101f26f9d5d0d Commit: 87ba8fb6bfe1c548c3aa75222d04cb47978946ec https://github.com/tribe29/checkmk/commit/87ba8fb6bfe1c548c3aa75222d04cb479… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-12-10 (Thu, 10 Dec 2020) Changed paths: M cmk/fetchers/cache.py Log Message: ----------- Remove DB on store (was load) Semantically, one may expect that the DB is modified on disk upon store but *not* upon load. Modifying the DB on load *is* confusing. CMK-6516 Change-Id: I50e621bb9b6f63a9ed514c7663f8ec2802bdf082 Commit: a78b48e2c7f21f8f03e7b4b968c38f3a89c268fc https://github.com/tribe29/checkmk/commit/a78b48e2c7f21f8f03e7b4b968c38f3a8… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-12-10 (Thu, 10 Dec 2020) Changed paths: M cmk/base/checkers/agent.py M cmk/base/checkers/snmp.py M cmk/fetchers/cache.py M cmk/fetchers/snmp.py M tests/unit/cmk/base/checkers/test_agent.py M tests/unit/cmk/base/checkers/test_snmp.py M tests/unit/cmk/fetchers/test_cache.py Log Message: ----------- Move PersistedSection filtering to PersistedSections Now we have the following methods * SectionStore.load() loads the DB and returns its content. * SectionStore.store() updates the DB with new content or removes it if it is empty. * PersistedSections.filter() filters the persisted sections in place. Moving the filtering from the SectionStore to the PersistedSections reduces feature envy and lets the SectionStore class manage the DB but ignore its content. Note that the filtering criterion is not correct but this patch does not change the behavior of the code but only its API. We also add a few comments that explain the current code duplication and provide a solution to get rid of it. CMK-6516 Change-Id: Ic43bd104c08ea047cb42edb59db92c7bced4a454 Compare: https://github.com/tribe29/checkmk/compare/1277f6c1d49b...a78b48e2c7f2

3 years, 10 months

← Newer
1
...
33
34
35
36
37
38
39
...
65
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits December 2020