Checkmk git commits November 2020

checkmk-commits@lists.checkmk.com

1 participants
580 discussions

[tribe29/checkmk] 1b4e2c: Make error handling more consistent. Tiny cleanups...

by Sven Panne

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 1b4e2cac2ad8bf796d50d10df391280d93f314e2 https://github.com/tribe29/checkmk/commit/1b4e2cac2ad8bf796d50d10df391280d9… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2020-11-05 (Thu, 05 Nov 2020) Changed paths: M livestatus/src/Logger.h Log Message: ----------- Make error handling more consistent. Tiny cleanups on the way. Change-Id: I21abdb0660c767de591bdbe12caf9f00a146037c

3 years, 8 months

[tribe29/checkmk] a0502f: Introduce new mechanism for confirm dialogs

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: a0502f0d2d6cdcd1cab0df08cd69b9f6ca320ce1 https://github.com/tribe29/checkmk/commit/a0502f0d2d6cdcd1cab0df08cd69b9f6c… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-05 (Thu, 05 Nov 2020) Changed paths: M cmk/gui/htmllib.py M cmk/gui/wato/pages/host_rename.py M web/htdocs/js/modules/dashboard.js M web/htdocs/js/modules/forms.js M web/htdocs/js/modules/page_menu.js Log Message: ----------- Introduce new mechanism for confirm dialogs Form resubmission issues in WATO have been fixed for regular forms recently. This problem is currently unsolved for forms involving confirm dialogs. This commit introduces a solution for that issue by replacing the existing confirm dialog logic with a Javascript based confirm dialog. This has the advantage that the confirm message is raised before the form is submitted to the server. It really reduces the complexity of the confirm dialog logic and will make it possible to simplify our Python code. Some drawbacks have already identified: Previously the confirm dialogs were rendered by the Python code. This made it possible to a) perform some logic on the Python side to get more information for the confirm message. b) perform some of our server side validations before displaying the confirm dialog. After a quick look at some call sites it looks like we can live with it. Let's go with this solution and solve possible problems if we stumble upon it. CMK-6214 Change-Id: Idb99369a1cdb3f857e12ceba5e7285a7705620f9 Commit: b5973d3839f0b4da588d296d13e855b80393a231 https://github.com/tribe29/checkmk/commit/b5973d3839f0b4da588d296d13e855b80… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-05 (Thu, 05 Nov 2020) Changed paths: M cmk/gui/htmllib.py M cmk/gui/wato/pages/sites.py M web/htdocs/js/modules/forms.js Log Message: ----------- Add option to use new confirm dialog for action icons CMK-6214 Change-Id: I1b95b8b3b4e44e7928d9565e9796df10b3333e7d Commit: f61e250b04e898d00229020eb2fb6b109b032369 https://github.com/tribe29/checkmk/commit/f61e250b04e898d00229020eb2fb6b109… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-05 (Thu, 05 Nov 2020) Changed paths: M cmk/gui/wato/mkeventd.py M cmk/gui/wato/pages/global_settings.py M cmk/gui/wato/pages/sites.py Log Message: ----------- Remove dead code from global settings list dialog The only settings that are set directly on the list dialog are the ON/OFF toggles. And these did not have a confirm dialog before. For this reason we can completely remove the confirm logic from these modes. Change-Id: I2a2c42deb956d15bcafff33dd4dd19bc67a29c13 Commit: e2a6060593b2902f64190b8c34530bf7a6fbcf4f https://github.com/tribe29/checkmk/commit/e2a6060593b2902f64190b8c34530bf7a… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-05 (Thu, 05 Nov 2020) Changed paths: M cmk/gui/htmllib.py M cmk/gui/page_menu.py M cmk/gui/wato/pages/global_settings.py M web/htdocs/js/modules/page_menu.js Log Message: ----------- Add confirmed form submit helper for page menu submit links In case we have forms with multiple different actions, where some of the actions need a confirmation and some not, we need to have an individual handling for each button. This helper function supports this case by providing an individuall helper function for all page menu entries of this kind. CMK-6214 Change-Id: I7ea68ac51700cd4e8e2ff71adbbe734a38b296c3 Compare: https://github.com/tribe29/checkmk/compare/4553e3bd164e...e2a6060593b2

3 years, 8 months

[tribe29/checkmk] db2563: 11540 Nutanix Prism Agent/prism_alerts check: add ...

by rb

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: db25632a9ea087cc19cf9c4c102b78682d692401 https://github.com/tribe29/checkmk/commit/db25632a9ea087cc19cf9c4c102b78682… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2020-11-05 (Thu, 05 Nov 2020) Changed paths: A .werks/11540 M checks/prism_alerts A cmk/gui/plugins/wato/check_parameters/prism_alerts.py M cmk/special_agents/agent_prism.py Log Message: ----------- 11540 Nutanix Prism Agent/prism_alerts check: add capability to filter for Prism Central Change-Id: I632c82551aaa5ee8fe5a6bc5a9c821a54af7547b Commit: 4553e3bd164e9554826da53dd5e2ce6a4e40c818 https://github.com/tribe29/checkmk/commit/4553e3bd164e9554826da53dd5e2ce6a4… Author: Ronny Bruska <ronny.bruska(a)tribe29.com> Date: 2020-11-05 (Thu, 05 Nov 2020) Changed paths: M cmk/gui/mobile.py M cmk/gui/plugins/dashboard/builtin.py M cmk/gui/plugins/views/builtin.py M cmk/gui/plugins/views/dashboard.py M cmk/gui/plugins/views/graphs.py M cmk/gui/plugins/views/inventory.py M cmk/gui/plugins/views/mkeventd.py M cmk/gui/plugins/views/mobile.py M cmk/gui/plugins/views/node_visualization.py M cmk/gui/views.py M cmk/gui/visuals.py Log Message: ----------- Sort and rename some general properties of dashboards * also remove linktitle CMK-6018 Change-Id: I55691179bf2b9b32ad971c05f213a522cc3bf2b0 Compare: https://github.com/tribe29/checkmk/compare/db540690f7bf...4553e3bd164e

3 years, 8 months

[tribe29/checkmk] db5406: Disable combined graph recipes in custom graph editor

by Óscar Nájera

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: db540690f7bf68aa9721ef0480f1c80b2f0e8f03 https://github.com/tribe29/checkmk/commit/db540690f7bf68aa9721ef0480f1c80b2… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2020-11-05 (Thu, 05 Nov 2020) Changed paths: M tests/unit/cmk/gui/test_pages.py Log Message: ----------- Disable combined graph recipes in custom graph editor Postpone the release of these feature until the custom graph editor receives an update to deal with the new high amount of metrics available to be edited at once. CMK-6126 Change-Id: Id0b2b90a558cfc2f168b0b16c94e2ff122b9da36

3 years, 8 months

[tribe29/checkmk] 062280: Make check for time-specific parameters more robust

by Jörg Herbel

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: 062280306e327bc0f69a643ee346ba69cbe8aa9b https://github.com/tribe29/checkmk/commit/062280306e327bc0f69a643ee346ba69c… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-11-05 (Thu, 05 Nov 2020) Changed paths: M cmk_base/config.py M tests/unit/cmk_base/test_config.py Log Message: ----------- Make check for time-specific parameters more robust When checking if check parameters are time-specific, we currently rely on them being either None, a dictionary or at least iterable. However, this assumption is not justified, since they can also be for example just an integer (see _parameter_valuespec_multipath). Change-Id: I9a5f9488638d337ac207926056163983be21a9b3

3 years, 8 months

[tribe29/checkmk] a4a5c6: Set filter values on single info context

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: a4a5c6ac45c2b9167953cd65973db6f0bdc8a5c7 https://github.com/tribe29/checkmk/commit/a4a5c6ac45c2b9167953cd65973db6f0b… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2020-11-05 (Thu, 05 Nov 2020) Changed paths: M cmk/gui/plugins/visuals/utils.py M cmk/gui/visuals.py Log Message: ----------- Set filter values on single info context When single_info context is set, the value context is {var: "value"}, when the context is free then the nested structure shows up {var: {var_1: "value", var_2: "value_2", ...}}. Here I directly set the html var to the first filter variable when it is received. And move the set_value function to its call site at VisualFilter. CMK-6013 Change-Id: I79b60d7fce97cda6c7a1a34890a06c973abff833 Commit: 1354f25feded5df771822a02540cdee9abce9389 https://github.com/tribe29/checkmk/commit/1354f25feded5df771822a02540cdee9a… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2020-11-05 (Thu, 05 Nov 2020) Changed paths: M agents/special/agent_prism M checks/prism_alerts M cmk/special_agents/agent_prism.py A cmk/special_agents/utils/agent_common.py A cmk/special_agents/utils/argument_parsing.py A cmk/special_agents/utils/request_helper.py M tests/unit/checks/generictests/datasets/prism_alerts.py Log Message: ----------- agent_prism / prism_alerts: modernize * remove legacy stuff * switch to argparse * switch to generic runtime behavior * extract network related stuff * agent_prism: add logging and cleanup * switch to JSON based agent output, adapt check Change-Id: I7fa07beffabdbbf94c93058d0f05c2d7ac3b2fd3 Commit: be6ffd72eed34bf21ad2cb9d32fb11bf50da2a46 https://github.com/tribe29/checkmk/commit/be6ffd72eed34bf21ad2cb9d32fb11bf5… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-11-05 (Thu, 05 Nov 2020) Changed paths: M cmk/base/api/agent_based/type_defs.py M cmk/base/plugins/agent_based/agent_based_api/v1/__init__.py M cmk/snmplib/type_defs.py M tests/unit/cmk/base/api/agent_based/register/test_section_plugins.py M tests/unit/cmk/base/api/agent_based/register/test_section_plugins_legacy_snmp_tree.py A tests/unit/cmk/base/api/agent_based/test_ab_type_defs.py M tests/unit/cmk/lib/test_snmplib_snmp_table.py M tests/unit/cmk/lib/test_snmplib_type_defs.py Log Message: ----------- move OIDEnd to API namespace Change-Id: I7a51bdf6030e0a807c39955e0c44aae2cf46981d Compare: https://github.com/tribe29/checkmk/compare/e7aeebd0b49c...be6ffd72eed3

3 years, 8 months

[tribe29/checkmk] e7aeeb: Make check for time-specific parameters more robust

by Jörg Herbel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: e7aeebd0b49c751fdfe115e5897e6e8c3e0aeba1 https://github.com/tribe29/checkmk/commit/e7aeebd0b49c751fdfe115e5897e6e8c3… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-11-05 (Thu, 05 Nov 2020) Changed paths: M cmk/base/config.py M tests/unit/cmk/base/test_config.py Log Message: ----------- Make check for time-specific parameters more robust When checking if check parameters are time-specific, we currently rely on them being either None, a dictionary or at least iterable. However, this assumption is not justified, since they can also be for example just an integer (see _parameter_valuespec_multipath). Change-Id: I9a5f9488638d337ac207926056163983be21a9b3

3 years, 8 months

[tribe29/checkmk] a73329: 10608 FIX Several GUI styling fixes

by Kenneth

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: a73329b95b16877af4d4e9a1f46836515a6b2664 https://github.com/tribe29/checkmk/commit/a73329b95b16877af4d4e9a1f46836515… Author: Kenneth Okoh <kenneth.okoh(a)tribe29.com> Date: 2020-11-05 (Thu, 05 Nov 2020) Changed paths: A .werks/10608 M cmk/gui/valuespec.py M web/htdocs/themes/facelift/scss/_main.scss Log Message: ----------- 10608 FIX Several GUI styling fixes The delete buttons in global settings are now visible due to a higher contrast. Change-Id: I0c545eb24de6b867dc1d98254bf0d360acffa4e4

3 years, 8 months

[tribe29/checkmk] b5699a: 11437 BI REST API: Added interfaces delete_rule an...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: b5699a94d299f887b91c7eb4880bae74720875bd https://github.com/tribe29/checkmk/commit/b5699a94d299f887b91c7eb4880bae747… Author: Andreas Boesl <andreas.boesl(a)tribe29.com> Date: 2020-11-05 (Thu, 05 Nov 2020) Changed paths: A .werks/11437 M cmk/gui/plugins/openapi/endpoints/bi.py M cmk/gui/plugins/openapi/restful_objects/type_defs.py M cmk/utils/bi/bi_packs.py M web/htdocs/openapi/checkmk.yaml Log Message: ----------- 11437 BI REST API: Added interfaces delete_rule and delete_aggregation Change-Id: I0bd328b5dde5b1a8bea26e3c991370bbea4164bf Commit: 4d8c12c64de713bc3e2694448357daf6a48e663a https://github.com/tribe29/checkmk/commit/4d8c12c64de713bc3e2694448357daf6a… Author: Andreas Boesl <andreas.boesl(a)tribe29.com> Date: 2020-11-05 (Thu, 05 Nov 2020) Changed paths: A .werks/11438 M cmk/gui/plugins/wato/bi_config.py M cmk/utils/bi/bi_packs.py Log Message: ----------- BI aggregations: REST API: only delete a rule if it is not referenced by aggregations/rules Change-Id: I3a49e5a02b944bd97b165b9c1d49cdd2a6425b4a Compare: https://github.com/tribe29/checkmk/compare/467ab5a0e5bf...4d8c12c64de7

3 years, 8 months

[tribe29/checkmk] d41a69: Check-API: factor out basic frontent label

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: d41a69f53e52e6cca6c935db0b463f61894d7902 https://github.com/tribe29/checkmk/commit/d41a69f53e52e6cca6c935db0b463f618… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-11-05 (Thu, 05 Nov 2020) Changed paths: M cmk/base/api/agent_based/checking_classes.py M cmk/base/api/agent_based/type_defs.py Log Message: ----------- Check-API: factor out basic frontent label Change-Id: Iaf9bc6acc372a3639cf6000a84b9f18124dedaf4 Commit: f671f87a24906df2b237517d586b5675b0c88d46 https://github.com/tribe29/checkmk/commit/f671f87a24906df2b237517d586b5675b… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-11-05 (Thu, 05 Nov 2020) Changed paths: M cmk/base/discovered_labels.py Log Message: ----------- discovered_labels: tighten type annotation Change-Id: I06c4149920519139483307afab9b00282e01180e Commit: 403d97cfea014943d4c4ecafe6bdeddfd645950b https://github.com/tribe29/checkmk/commit/403d97cfea014943d4c4ecafe6bdeddfd… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-11-05 (Thu, 05 Nov 2020) Changed paths: M cmk/base/api/agent_based/register/section_plugins.py M cmk/base/api/agent_based/type_defs.py M cmk/base/discovery.py M cmk/base/plugins/agent_based/agent_based_api/v1/__init__.py M cmk/base/plugins/agent_based/docker_container_status.py M tests/unit/cmk/base/plugins/agent_based/test_checkmk.py M tests/unit/cmk/base/plugins/agent_based/utils/test_ps_discovery_specs.py Log Message: ----------- HostLabel: decouple API from implementation We use a dedicated HostLabel class for the check API, in the same way we do for ServiceLabels. Change-Id: I28ccf5d1ac0f5624d129a786a3d71c11a2e30d95 Commit: 467ab5a0e5bf3d163eb0192191544e9e4a893141 https://github.com/tribe29/checkmk/commit/467ab5a0e5bf3d163eb0192191544e9e4… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-11-05 (Thu, 05 Nov 2020) Changed paths: M cmk/base/api/agent_based/register/section_plugins.py Log Message: ----------- refactor: prepare for more validation Change-Id: I096ae940e43f059cbf5b7ce1ba4860e7fad41daa Compare: https://github.com/tribe29/checkmk/compare/1943b6fde85a...467ab5a0e5bf

3 years, 8 months

← Newer
1
...
48
49
50
51
52
53
54
...
58
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits November 2020