Checkmk git commits October 2020

checkmk-commits@lists.checkmk.com

1 participants
676 discussions

[tribe29/checkmk] 7c6b75: Fix Youtube URL

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 7c6b754306dc1c064d281bd8d231fe75ab9c2939 https://github.com/tribe29/checkmk/commit/7c6b754306dc1c064d281bd8d231fe75a… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M cmk/gui/main_menu.py Log Message: ----------- Fix Youtube URL Change-Id: Id41cf9218ba484a5418d662b866287d0a389a4e8

3 years, 11 months

[tribe29/checkmk] 4d588f: Don't f12 flycheck files

by Timotheus Bachinger

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 4d588fec0677542d5e8037524b6b4570a317b79d https://github.com/tribe29/checkmk/commit/4d588fec0677542d5e8037524b6b4570a… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M cmk/.f12 M cmk/base/.f12 M cmk/fetchers/.f12 M cmk/gui/plugins/openapi/.f12 Log Message: ----------- Don't f12 flycheck files Change-Id: I27291c3801a9355cb5b3a19e7d7a506c8a6494df Commit: f548885112ec6b270f7705460578c10c7124fe11 https://github.com/tribe29/checkmk/commit/f548885112ec6b270f7705460578c10c7… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M cmk/gui/plugins/dashboard/single_metric.py Log Message: ----------- Clean single metric Dashlet data query parameters Only include rrd consolidation when requesting historic values Change-Id: Id8f61eb668493d7475610ad1df765d7b77f20537 Commit: da06aa51e682ba05d7306b6be68dd0a231ae37cd https://github.com/tribe29/checkmk/commit/da06aa51e682ba05d7306b6be68dd0a23… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M web/htdocs/js/modules/figures/cmk_barplot.js M web/htdocs/js/modules/figures/cmk_figures.js M web/htdocs/js/modules/figures/cmk_table.js M web/htdocs/js/modules/figures/cmk_timeseries.js Log Message: ----------- JS figure use argumentless update_gui Change-Id: I09d7c9d7d03af5a3a6d0adc392d76a8b284fdacd Commit: 470f111073afd4b946d10aeebd1b3d5015e6ee65 https://github.com/tribe29/checkmk/commit/470f111073afd4b946d10aeebd1b3d501… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M cmk/gui/plugins/dashboard/single_metric.py Log Message: ----------- Fix single metric resize update Change-Id: I01bb3f6580b63925fe35bd1cb62cf34504dd56aa Commit: c54de9ffc359de72b2e6aa558c1182a47f18775b https://github.com/tribe29/checkmk/commit/c54de9ffc359de72b2e6aa558c1182a47… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M cmk/gui/dashboard.py M cmk/gui/figures.py M cmk/gui/plugins/dashboard/average_scatterplot_dashlet.py M cmk/gui/plugins/dashboard/bar_chart_dashlet.py M cmk/gui/plugins/dashboard/single_metric.py M cmk/gui/plugins/dashboard/utils.py M cmk/gui/valuespec.py M web/htdocs/js/modules/figures/cmk_figures.js M web/htdocs/js/modules/figures/cmk_timeseries.js Log Message: ----------- Include dashlet's general settings and properties in ajax request To properly render a Dashlet entirely on the JS side it is necessary to also have the general setting configuration from the dashlet's container. - For such valuespec also to be parsable the general_settings valuespec is isolated into the dashboard.utils. - There is a Developer control that jumps when general settings and properties have a colliding key. This avoids confusion to user and avoids problems because, general settings and local properties were merged when saved on disk. - The title property was a collision on the single metric dashlet. Remove it from properties - Process the container of title entirely on JS for the single metric dashlet. CMK-5869 Change-Id: I0d615f1d8c3cfecb0448b9a100fbeb01ab620b17 Commit: 49a220af15e7e598c6492e4bd3e5d86d81dab861 https://github.com/tribe29/checkmk/commit/49a220af15e7e598c6492e4bd3e5d86d8… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M cmk/gui/plugins/sidebar/search.py Log Message: ----------- Fix: close anker element in search results This fixes several issues: * the result topics do not contain senseless links anymore * styling of the displayed results is now streamlined Change-Id: I7a7eda4b0d458ff83489e8e8b2d9ff44b007d81d Compare: https://github.com/tribe29/checkmk/compare/5fb33aaa7125...49a220af15e7

3 years, 11 months

[tribe29/checkmk] 91b274: smart: fix broken normalized values handling

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 91b274723067b7f2e1bc7c1df58b06938a39b2ce https://github.com/tribe29/checkmk/commit/91b274723067b7f2e1bc7c1df58b06938… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M checks/smart Log Message: ----------- smart: fix broken normalized values handling Change-Id: I5994dbd4d83d676ff7290c7e24add9f55b08d279 Commit: 1c2a57799df0aa0b6220900083d96b8c22760458 https://github.com/tribe29/checkmk/commit/1c2a57799df0aa0b6220900083d96b8c2… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M checks/smart Log Message: ----------- smart: unify rendering Change-Id: Ic415897df98deb2a39178e0cfa9775401dfd87d5 Commit: 5136db66830d1f74fe9f3eae2fcda09838bc4d5a https://github.com/tribe29/checkmk/commit/5136db66830d1f74fe9f3eae2fcda0983… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M checks/smart M tests/unit/checks/generictests/datasets/smart.py Log Message: ----------- smart: shorten service output CMK-5736 also remove a couple of redundant tests. Change-Id: I9cdbeb6b8d7039be75b623a30d69012073166a40 Commit: 5fb33aaa7125682b14b3d57fd11a6e738675fa61 https://github.com/tribe29/checkmk/commit/5fb33aaa7125682b14b3d57fd11a6e738… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M checks/apache_status M tests/unit/checks/generictests/datasets/apache_status.py M tests/unit/checks/generictests/datasets/apache_status_legacy.py Log Message: ----------- apache_status: shorten service output I * Move scoreboard details to long ouput. * Improve labels of regular output CMK-5736 Change-Id: I97e7406931dba66634e587ba3176b087fc499d5b Compare: https://github.com/tribe29/checkmk/compare/a954c2fd41b2...5fb33aaa7125

3 years, 11 months

[tribe29/checkmk] a954c2: Renamed non_inline_snmp_hosts

by Lukas Lengler

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: a954c2fd41b230e4335026f3a0e4e69e258a343f https://github.com/tribe29/checkmk/commit/a954c2fd41b230e4335026f3a0e4e69e2… Author: Lukas Lengler <lukas.lengler(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M cmk/base/config.py M cmk/base/default_config/base.py M cmk/gui/plugins/wato/check_mk_configuration.py M cmk/gui/watolib/rulesets.py M cmk/update_config.py M tests/unit/cmk/gui/watolib/test_rulespecs.py Log Message: ----------- Renamed non_inline_snmp_hosts Since the new PySNMP Backend we have three configurable SNMP Backends the rules now save other values. These variables are now renamed and in cmk/update_config.py we made sure old configs are still compatible. - non_inline_snmp_hosts --> snmp_backend_host_rules Change-Id: Icf43c569a99e1a6fd5069931d82ea7eaf14c4a00

3 years, 11 months

[tribe29/checkmk] 244e9d: Improve GUI unit test performance

by Jörg Herbel

Branch: refs/heads/test_weblate2 Home: https://github.com/tribe29/checkmk Commit: 244e9dde9f2016a32d26e0bda73d0d33dd75eb82 https://github.com/tribe29/checkmk/commit/244e9dde9f2016a32d26e0bda73d0d33d… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M tests/unit/cmk/gui/conftest.py Log Message: ----------- Improve GUI unit test performance Change-Id: I5d0c884a6c40628d177a102a28adae135513db76 Commit: 6e1494e87049e366e41c7f4920019b1118286c15 https://github.com/tribe29/checkmk/commit/6e1494e87049e366e41c7f4920019b111… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M tests/unit/cmk/gui/conftest.py Log Message: ----------- Removed unused import Change-Id: Ie0a6d06af28da385c78c0496cc9ae09fbf6f102f Commit: 2fa9067fd180ef876fd5b36c6505e4258c1b910b https://github.com/tribe29/checkmk/commit/2fa9067fd180ef876fd5b36c6505e4258… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: A .werks/11338 M cmk/gui/plugins/wato/check_parameters/fortigate_node_sessions.py Log Message: ----------- 11338 FIX fortigate: renaming of WATO regel to avoid duplicate naming In the previous, there were two WATO rules which had the name "Fortigate Active Sessions" where one concerned the Cluster environment. This change renames the Cluster rule to allow a proper differentitation. Change-Id: I1b2815292daf6f089025027deb20aa04f69a4ea0 Commit: 960ccc4ff83469414f2fd4c820f4b92d154ff9ab https://github.com/tribe29/checkmk/commit/960ccc4ff83469414f2fd4c820f4b92d1… Author: Ronny Bruska <ronny.bruska(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M cmk/gui/userdb.py M cmk/gui/wato/user_profile.py Log Message: ----------- Adjusted updating of user atrribute ui_theme and ui_sidebar_position Change-Id: If8b280ffdbb1607740560ba64d6dc8bae6d47ddf Commit: 1ba8d43c76c762da24c41a17520603e5e09d228c https://github.com/tribe29/checkmk/commit/1ba8d43c76c762da24c41a17520603e5e… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M livestatus/src/FileColumn.cc Log Message: ----------- Fixed logging level of "FOO is not a regular file" messages. They only make some sense when you see the actual Livestatus query, and those are logged at "debug" only. CMK-5893 Change-Id: I1a53ae8d7ed311500b2c7d7d862c43a5fac21979 Commit: 228b076c321b68132a06d72e2c21b8cc12d4f89f https://github.com/tribe29/checkmk/commit/228b076c321b68132a06d72e2c21b8cc1… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M checks/kernel M checks/lparstat_aix M checks/statgrab_cpu M checks/ucd_cpu_util M cmk/base/check_legacy_includes/cpu_util.py M cmk/base/plugins/agent_based/utils/cpu_util.py Log Message: ----------- cpu_util: migrate CpuInfo -> CPUInfo Change-Id: Ib97db00b23746af158c4986e0e8fec1ee6835000 Commit: 772cd9244b46532af36d3dfc41cabb83e8732777 https://github.com/tribe29/checkmk/commit/772cd9244b46532af36d3dfc41cabb83e… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: A .werks/11325 A checkman/mssql_jobs A checks/mssql_jobs A tests/unit/checks/generictests/datasets/mssql_jobs_regression.py M tests/unit/checks/test_generic_legacy_conversion.py Log Message: ----------- 11325 mssql_jobs: new plugin to monitor scheduled jobs on MSSQL Server CMK-5682 Change-Id: I4cf30974ce199f2e539324741a9d0cfe97a3faf0 Commit: dbbabfb99bbfd27959f8c3764c2b9af918a682a7 https://github.com/tribe29/checkmk/commit/dbbabfb99bbfd27959f8c3764c2b9af91… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M cmk/gui/plugins/views/utils.py Log Message: ----------- Fix possible crash in staleness calculation CMK-5894 Change-Id: I2561f7c91382278491713288dfcaca31af2aae36 Commit: 469ffb0488b78a7e5a4342424973eb68a76e3c50 https://github.com/tribe29/checkmk/commit/469ffb0488b78a7e5a4342424973eb68a… Author: Ronny Bruska <ronny.bruska(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M cmk/gui/wato/user_profile.py M web/htdocs/themes/facelift/scss/_mega_menu.scss Log Message: ----------- Adjust styling of toggle options Change-Id: I31bfd44e05cbc75812d86fd07494a7268f68c915 Commit: c78d04a9ae7572a417e167185ded741c19f602ee https://github.com/tribe29/checkmk/commit/c78d04a9ae7572a417e167185ded741c1… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M tests/unit/cmk/gui/conftest.py Log Message: ----------- Improve GUI unit test performance Instead of building the same app over and over for each unit test, we now use the once built WSGI app for all unit tests that need the wsgi_app. Previous time needed: 230 sec. Now: 70 sec :-) Change-Id: I16d80d90c7a42ce682cf2b6c319673f40fddedc9 Commit: d7144faf94cbf7ae615ef5d029888f6f888e748a https://github.com/tribe29/checkmk/commit/d7144faf94cbf7ae615ef5d029888f6f8… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M cmk/gui/plugins/visuals/wato.py M tests/unit/cmk/gui/plugins/visuals/test_filters.py Log Message: ----------- Improve GUI tests by mocking livestatus Some unit tests accidentally tried to execute livestatus queries: * Report rendering tests render views, which tried to get data from livestatus * Rendering and processing filters in tests We now use the generic livestatus mock to get get real data to show. Only the WATO folder filter needed to be mocked, because it issues a query with Stats header that is not understood by the livestatus mock at the moment. Bringing down these tests from 10 sec to 0.x sec. Change-Id: Icd7970e08cd269e86622c8bf5dfd7ff8b0dd6459 Commit: 7baee85ce699c82b01d6bffce4281200db2ab64b https://github.com/tribe29/checkmk/commit/7baee85ce699c82b01d6bffce4281200d… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M tests/unit/conftest.py M tests/unit/livestatus/test_livestatus_unit.py Log Message: ----------- Add generic fixture to prevent accidental livestatus connects Some unit tests were creating livestatus connections by accident which resulted in long running tests that wait for a connect timeout. This new fixture is executed by every test and will raise an exception in case a test tried to connect to livestatus. Change-Id: I25c750a66e7ff8cf22b16ccbd20de411ef68f11f Commit: 4b0b8c26eb692f15e8437dbc443bb27457500e0d https://github.com/tribe29/checkmk/commit/4b0b8c26eb692f15e8437dbc443bb2745… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M tests/unit/inventory/test_generic_legacy_conversion_inv.py Log Message: ----------- Fix false positive Change-Id: Iec17c712c960a879c964bde11796a1fbbec9a295 Commit: 2c2c1f3debc58fb7e36a2f17fd2d32382b4ecc02 https://github.com/tribe29/checkmk/commit/2c2c1f3debc58fb7e36a2f17fd2d32382… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M checks/smart Log Message: ----------- smart: refactor Change-Id: I4b614d1d90d6c6954a45c6fbe56339f2e0d7063e Commit: 22febcda97c08a3019c44f2091ff72851d5cc73b https://github.com/tribe29/checkmk/commit/22febcda97c08a3019c44f2091ff72851… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M cmk/gui/htmllib.py M web/htdocs/js/modules/search.js M web/htdocs/themes/facelift/scss/_more.scss Log Message: ----------- Fix: More/less button with new search * As the more/less button has no function during the search, it will not be shown during searching * We need to clear the result list after switching to the menu entries in order to perform a proper resizing CMK-5886 Change-Id: I5d7d78b23ff4be688118a32beaf1805114509037 Commit: 7906bb4709f56f1311d6a364cc4c526113eacbe8 https://github.com/tribe29/checkmk/commit/7906bb4709f56f1311d6a364cc4c52611… Author: Lukas Lengler <lukas.lengler(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M cmk/base/config.py M cmk/base/default_config/base.py M cmk/gui/plugins/wato/check_mk_configuration.py M cmk/update_config.py M tests/unit/cmk/gui/watolib/test_watolib.py Log Message: ----------- Renamed use_inline_snmp Since the new PySNMP Backend we have three configurable SNMP Backends the rules now save other values. These variables are now renamed and in cmk/update_config.py we made sure old configs are still compatible. - use_inline_snmp --> snmp_backend_default Change-Id: I3fa9785a13647396486ccd4ff42e2b00aafde8f1 Commit: 42be2916d5722760fd3caebefd8eeea06ee3c5d8 https://github.com/tribe29/checkmk/commit/42be2916d5722760fd3caebefd8eeea06… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: A .werks/11325 A .werks/11338 A checkman/mssql_jobs M checks/kernel M checks/lparstat_aix A checks/mssql_jobs M checks/smart M checks/statgrab_cpu M checks/ucd_cpu_util M cmk/base/check_legacy_includes/cpu_util.py M cmk/base/config.py M cmk/base/default_config/base.py M cmk/base/plugins/agent_based/utils/cpu_util.py M cmk/gui/htmllib.py M cmk/gui/plugins/views/utils.py M cmk/gui/plugins/visuals/wato.py M cmk/gui/plugins/wato/check_mk_configuration.py M cmk/gui/plugins/wato/check_parameters/fortigate_node_sessions.py M cmk/gui/userdb.py M cmk/gui/wato/user_profile.py M cmk/update_config.py M livestatus/src/FileColumn.cc A tests/unit/checks/generictests/datasets/mssql_jobs_regression.py M tests/unit/checks/test_generic_legacy_conversion.py M tests/unit/cmk/gui/conftest.py M tests/unit/cmk/gui/plugins/visuals/test_filters.py M tests/unit/cmk/gui/watolib/test_watolib.py M tests/unit/conftest.py M tests/unit/inventory/test_generic_legacy_conversion_inv.py M tests/unit/livestatus/test_livestatus_unit.py M web/htdocs/js/modules/search.js M web/htdocs/themes/facelift/scss/_mega_menu.scss M web/htdocs/themes/facelift/scss/_more.scss Log Message: ----------- Merge branch 'master' into test_weblate2 Change-Id: I83f11516e6f75af7b0c4e361a145e2bfee807f4b Compare: https://github.com/tribe29/checkmk/compare/9183fd4eff98...42be2916d572

3 years, 11 months

[tribe29/checkmk] d539a6: 11373 FIX Made titles of options in host/folder pe...

by Marcel Arentz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: d539a64965bf9ad05fdfd2fa2354a6c81e9b2eac https://github.com/tribe29/checkmk/commit/d539a64965bf9ad05fdfd2fa2354a6c81… Author: Marcel Arentz <marcel.arentz(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: A .werks/11373 M cmk/gui/watolib/groups.py Log Message: ----------- 11373 FIX Made titles of options in host/folder permissions less uncertain There have always been additional option when assigning contact groups to WATO folders or hosts. The effect of this options meanwhile has not always been absolute transparent depending if the user is in folder or in host properties. Especially the outcome of option "Always add host contact groups also to its services" has not been clear. The titles do now explain better, what a particular option really does. This is just a clarification of the current, actual behaviour and no change of the behaviour itself. Therefore there is no need for manual interaction. Change-Id: I99d4ad9395f694058b7a148e627b58d9a157020e

3 years, 11 months

[tribe29/checkmk] 7906bb: Renamed use_inline_snmp

by Lukas Lengler

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 7906bb4709f56f1311d6a364cc4c526113eacbe8 https://github.com/tribe29/checkmk/commit/7906bb4709f56f1311d6a364cc4c52611… Author: Lukas Lengler <lukas.lengler(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M cmk/base/config.py M cmk/base/default_config/base.py M cmk/gui/plugins/wato/check_mk_configuration.py M cmk/update_config.py M tests/unit/cmk/gui/watolib/test_watolib.py Log Message: ----------- Renamed use_inline_snmp Since the new PySNMP Backend we have three configurable SNMP Backends the rules now save other values. These variables are now renamed and in cmk/update_config.py we made sure old configs are still compatible. - use_inline_snmp --> snmp_backend_default Change-Id: I3fa9785a13647396486ccd4ff42e2b00aafde8f1

3 years, 11 months

[tribe29/checkmk] 22febc: Fix: More/less button with new search

by Timotheus Bachinger

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 22febcda97c08a3019c44f2091ff72851d5cc73b https://github.com/tribe29/checkmk/commit/22febcda97c08a3019c44f2091ff72851… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M cmk/gui/htmllib.py M web/htdocs/js/modules/search.js M web/htdocs/themes/facelift/scss/_more.scss Log Message: ----------- Fix: More/less button with new search * As the more/less button has no function during the search, it will not be shown during searching * We need to clear the result list after switching to the menu entries in order to perform a proper resizing CMK-5886 Change-Id: I5d7d78b23ff4be688118a32beaf1805114509037

3 years, 11 months

[tribe29/checkmk] 2c2c1f: smart: refactor

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 2c2c1f3debc58fb7e36a2f17fd2d32382b4ecc02 https://github.com/tribe29/checkmk/commit/2c2c1f3debc58fb7e36a2f17fd2d32382… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M checks/smart Log Message: ----------- smart: refactor Change-Id: I4b614d1d90d6c6954a45c6fbe56339f2e0d7063e

3 years, 11 months

[tribe29/checkmk] c78d04: Improve GUI unit test performance

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: c78d04a9ae7572a417e167185ded741c19f602ee https://github.com/tribe29/checkmk/commit/c78d04a9ae7572a417e167185ded741c1… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M tests/unit/cmk/gui/conftest.py Log Message: ----------- Improve GUI unit test performance Instead of building the same app over and over for each unit test, we now use the once built WSGI app for all unit tests that need the wsgi_app. Previous time needed: 230 sec. Now: 70 sec :-) Change-Id: I16d80d90c7a42ce682cf2b6c319673f40fddedc9 Commit: d7144faf94cbf7ae615ef5d029888f6f888e748a https://github.com/tribe29/checkmk/commit/d7144faf94cbf7ae615ef5d029888f6f8… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M cmk/gui/plugins/visuals/wato.py M tests/unit/cmk/gui/plugins/visuals/test_filters.py Log Message: ----------- Improve GUI tests by mocking livestatus Some unit tests accidentally tried to execute livestatus queries: * Report rendering tests render views, which tried to get data from livestatus * Rendering and processing filters in tests We now use the generic livestatus mock to get get real data to show. Only the WATO folder filter needed to be mocked, because it issues a query with Stats header that is not understood by the livestatus mock at the moment. Bringing down these tests from 10 sec to 0.x sec. Change-Id: Icd7970e08cd269e86622c8bf5dfd7ff8b0dd6459 Commit: 7baee85ce699c82b01d6bffce4281200db2ab64b https://github.com/tribe29/checkmk/commit/7baee85ce699c82b01d6bffce4281200d… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M tests/unit/conftest.py M tests/unit/livestatus/test_livestatus_unit.py Log Message: ----------- Add generic fixture to prevent accidental livestatus connects Some unit tests were creating livestatus connections by accident which resulted in long running tests that wait for a connect timeout. This new fixture is executed by every test and will raise an exception in case a test tried to connect to livestatus. Change-Id: I25c750a66e7ff8cf22b16ccbd20de411ef68f11f Commit: 4b0b8c26eb692f15e8437dbc443bb27457500e0d https://github.com/tribe29/checkmk/commit/4b0b8c26eb692f15e8437dbc443bb2745… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M tests/unit/inventory/test_generic_legacy_conversion_inv.py Log Message: ----------- Fix false positive Change-Id: Iec17c712c960a879c964bde11796a1fbbec9a295 Compare: https://github.com/tribe29/checkmk/compare/469ffb0488b7...4b0b8c26eb69

3 years, 11 months

← Newer
1
...
28
29
30
31
32
33
34
...
68
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits October 2020