Checkmk git commits July 2019

checkmk-commits@lists.checkmk.com

1 participants
654 discussions

[tribe29/checkmk] 7b0488: 7987 FIX Fix xinetd.conf conflict on "omd mv/cp"

by Lars

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: 7b048859c114b203383031debac67d375665fcde https://github.com/tribe29/checkmk/commit/7b048859c114b203383031debac67d375… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: A .werks/7987 M omd/packages/mk-livestatus/LIVESTATUS_TCP_TLS M omd/packages/mk-livestatus/skel/etc/mk-livestatus/xinetd.conf M omd/packages/omd/omdlib/main.py Log Message: ----------- 7987 FIX Fix xinetd.conf conflict on "omd mv/cp" When performing an omd cp or omd mv to copy or rename a site, this resulted in a conflict with the xinetd.conf configuration file of Livestatus, when it was enabled to listen via TCP. This issue affected all previous 1.6 releases. CMK-2413 Change-Id: Ia523d439e0065ab53e8cc41790fa6e6132c54145

5 years, 1 month

[tribe29/checkmk] ee59b3: DCD connection config: Improve titles and texts

by Tom Bärwinkel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: ee59b3e3a2308ae2fd038f5b22b464f83bef2d61 https://github.com/tribe29/checkmk/commit/ee59b3e3a2308ae2fd038f5b22b464f83… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M cmk/gui/plugins/wato/utils/simple_modes.py Log Message: ----------- DCD connection config: Improve titles and texts Change-Id: I5d2bdd6f3ba1d7a1326c6f1266847d16db1d2280 Commit: 5c39daf1396a3260f42aa0cf3e89a054713cabb5 https://github.com/tribe29/checkmk/commit/5c39daf1396a3260f42aa0cf3e89a0547… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: A .werks/7987 M omd/packages/mk-livestatus/LIVESTATUS_TCP_TLS M omd/packages/mk-livestatus/skel/etc/mk-livestatus/xinetd.conf M omd/packages/omd/omdlib/main.py Log Message: ----------- 7987 FIX Fix xinetd.conf conflict on "omd mv/cp" When performing an omd cp or omd mv to copy or rename a site, this resulted in a conflict with the xinetd.conf configuration file of Livestatus, when it was enabled to listen via TCP. This issue affected all previous 1.6 releases. CMK-2413 Change-Id: Ia523d439e0065ab53e8cc41790fa6e6132c54145 Commit: 326534cea6f9df83f5993228fe9e026d7656a342 https://github.com/tribe29/checkmk/commit/326534cea6f9df83f5993228fe9e026d7… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M cmk_base/notify.py Log Message: ----------- Refactoring of notify_bulk The bulk_context now contains the context of the individual notifications instead of the final output. This will be useful When writing history log entries later on. CMK-2079 Change-Id: Ia0ee3c583d33676f549c374280ed64edba03dd2f Commit: 872ee857b3883ef4b7328c185b83b21f9e87b9a9 https://github.com/tribe29/checkmk/commit/872ee857b3883ef4b7328c185b83b21f9… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: A .werks/8783 M cmk_base/notify.py Log Message: ----------- 8783 FIX bulk notifications did not produce failed notifications If a notification script returned a non-zero exit code and was configured for bulk notifications no failed notifications were shown in the GUI. With this fix one failed notification will be produced for every notification present in the failed bulk. Furthermore the view "Host and Service notifications" now shows a "Final notification result" for every notification in a bulk. CMK-2079 Change-Id: Ife79e17e6fb734cad8de11555c06d23ced8fb71f Compare: https://github.com/tribe29/checkmk/compare/25f99a4dc67b...872ee857b388

5 years, 1 month

[tribe29/checkmk] 565f30: DCD connection config: Improve titles and texts

by Lars

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: 565f30c7fc96c51abc4f78fbdc1e551ad784f492 https://github.com/tribe29/checkmk/commit/565f30c7fc96c51abc4f78fbdc1e551ad… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M cmk/gui/plugins/wato/utils/simple_modes.py Log Message: ----------- DCD connection config: Improve titles and texts Change-Id: I5d2bdd6f3ba1d7a1326c6f1266847d16db1d2280

5 years, 1 month

[tribe29/checkmk] b91a09: [CMK-2362] - mrpe integration tests

by Sergey Kipnis

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: b91a0908f5669a6e792a10c18cc29c605f979a8f https://github.com/tribe29/checkmk/commit/b91a0908f5669a6e792a10c18cc29c605… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M agents/wnx/install/resources/check_mk.user.yml R agents/wnx/integration/_test_section_mrpe.py R agents/wnx/integration/_test_section_plugin_group.py M agents/wnx/integration/local.py M agents/wnx/integration/test_section_check_mk.py M agents/wnx/integration/test_section_df.py A agents/wnx/integration/test_section_mrpe.py M agents/wnx/src/engine/providers/mrpe.cpp A agents/wnx/test_files/integration/check_crit.bat M agents/wnx/watest/pch.h M agents/wnx/watest/test-mrpe.cpp Log Message: ----------- [CMK-2362] - mrpe integration tests - path quoting is supported - relative paths are supported in yml config - logging of invalid file added - a bit cleaned includes - extended unit testing for include Change-Id: Ie40bd555d9edaada32da856eaba448f2237bed1a

5 years, 1 month

[tribe29/checkmk] 539d21: agent_vsphere: start reordering functions

by Moritz

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: 539d217bc81f032037b4bc26e5e6c193b7061fb1 https://github.com/tribe29/checkmk/commit/539d217bc81f032037b4bc26e5e6c193b… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M agents/special/agent_vsphere Log Message: ----------- agent_vsphere: start reordering functions Change-Id: I4d47470a9855c01f6a058f4c0ce492843c140034 Commit: 2c410bb88ee1eb41674c1db2e245db0ff387857a https://github.com/tribe29/checkmk/commit/2c410bb88ee1eb41674c1db2e245db0ff… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M agents/special/agent_vsphere Log Message: ----------- agent_vsphere: factor out determination of available counters Change-Id: I1d79f72cdefde66f3c698df11d2843a73723095e Commit: c9333b4c8deea3f42b4c4ffbd22616b496d597fe https://github.com/tribe29/checkmk/commit/c9333b4c8deea3f42b4c4ffbd22616b49… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M agents/special/agent_vsphere Log Message: ----------- agent_vsphere: make counter ids an argument to fetch_counters_syntax Change-Id: I2da478f02410f6d3842d295cd0b7ed0ed9168a0c Commit: b8c6aa684e44953b34fb9114cb31d759e21c6294 https://github.com/tribe29/checkmk/commit/b8c6aa684e44953b34fb9114cb31d759e… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: A .werks/7956 M agents/special/agent_vsphere Log Message: ----------- 7956 agent_vsphere: Collect performance counters from vCenter Previously some counters could only be fetched from the ESX host directly. We now provide the counters when connecting to the vCenter as well. If the special agent is executed against the vCenter and creating services on the ESX hosts via the piggyback mechanism, this may add the "Disk IO", "Datastore IO" and "Interface" services to the affected hosts. This feature is a result of the fact that we no longer request the syntax for desired counters, but for all available ones. This solves CMK-2256. Change-Id: I335bcff1700e7bca46ade5593473cc89d3f3b704 Commit: 7cd9a4923199b4d22d81dcdae610ed9d91b1e18d https://github.com/tribe29/checkmk/commit/7cd9a4923199b4d22d81dcdae610ed9d9… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M agents/special/agent_vsphere Log Message: ----------- agent_vsphere: fetch_counters: factored out Change-Id: I8fad63a95e5920390d73ec16bb6cb511744f00be Commit: 420b0ebb328b820ee26041bb69c725182e82e433 https://github.com/tribe29/checkmk/commit/420b0ebb328b820ee26041bb69c725182… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M agents/special/agent_vsphere Log Message: ----------- agent_vsphere: fetch_counters: remove syntax argument Change-Id: I3bcaa7e75a27ec00c00c8f54b9095d402ac91fa9 Commit: 1bdc5e461dbfe3992e8e8347134452a167cd1388 https://github.com/tribe29/checkmk/commit/1bdc5e461dbfe3992e8e8347134452a16… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M agents/special/agent_vsphere Log Message: ----------- agent_vsphere: fetch_counters: make selected counters an argument Change-Id: I5a36b84b15ae58ca9cd4166a3f746645950b8ca5 Commit: d21d870b578c02edb734fc3f18e345aa5b2fd7db https://github.com/tribe29/checkmk/commit/d21d870b578c02edb734fc3f18e345aa5… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M agents/special/agent_vsphere Log Message: ----------- agent_vsphere: only request the required counter ids Change-Id: I4d8247c81900640a5c77818bfbf4833a2a9403f8 Commit: 28a385daa311e733cf1e25eba44767e692164cae https://github.com/tribe29/checkmk/commit/28a385daa311e733cf1e25eba44767e69… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M agents/special/agent_vsphere Log Message: ----------- agent_vsphere: remove one TODO Change-Id: I23f76104c66818e6f4c31b11f26bec97c1fb4dd3 Compare: https://github.com/tribe29/checkmk/compare/85172fd3fd05...28a385daa311

5 years, 1 month

[tribe29/checkmk] 25f99a: Fix BareExcept

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 25f99a4dc67baef10f68bdd3febeec820bdfed4f https://github.com/tribe29/checkmk/commit/25f99a4dc67baef10f68bdd3febeec820… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M cmk/gui/wato/pages/rulesets.py Log Message: ----------- Fix BareExcept Change-Id: Ifbf02f2d8309adf6fd7d4d408f368231f2d794b7

5 years, 1 month

[tribe29/checkmk] 5bd717: Using pipenv actually requires python3.7-dev, not ...

by Sven Panne

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 5bd7171e3d83c6ad009c7f9909c08890b99ef177 https://github.com/tribe29/checkmk/commit/5bd7171e3d83c6ad009c7f9909c08890b… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M Makefile Log Message: ----------- Using pipenv actually requires python3.7-dev, not python3.7. Change-Id: I430c80aa60134af28c3427bbf7705efad8eaaec9

5 years, 1 month

[tribe29/checkmk] 85172f: 7986 Service labels can be used as rule conditions

by Lars

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: 85172fd3fd05968579ae7d66d7bf2ffef2a3b8ec https://github.com/tribe29/checkmk/commit/85172fd3fd05968579ae7d66d7bf2ffef… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: A .werks/7986 Log Message: ----------- 7986 Service labels can be used as rule conditions The service labels, that are introduced with Checkmk 1.6 can now be used as conditions in service rulesets (Host & Service Parameters). These conditions can be configured like the host labels. The labels can not be used in the rulesets "Service labels", because that could result in a hen egg problem. Change-Id: If233dd91b5bdbc20484fcb62df0c2c068b75eff2

5 years, 1 month

[tribe29/checkmk] 8707a4: Fix AutochecksManager.discovered_labels_of

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 8707a4355c25a41821c53a9f2f028c680c836f22 https://github.com/tribe29/checkmk/commit/8707a4355c25a41821c53a9f2f028c680… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M cmk_base/autochecks.py M tests/testlib/base.py M tests/unit/cmk_base/test_autochecks.py Log Message: ----------- Fix AutochecksManager.discovered_labels_of Skip computing unused effective check parameters for autochecks in discovered_labels_of(). discovered_labels_of called _read_autochecks which was computing the effective check parameter of all autochecks. To do this it is necessary to process service rulesets which all could use service label conditions. This ended up in an endless recursion. To fix this _read_autochecks_of has now been split into two steps. The raw autochecks produced by the first step are enough for discovered_labels_of. CMK-2402 Change-Id: I283caadac9b9642c140ebba5b7a9990b31c82a6d Commit: 8f8dc87c564a5f8c9fe9b23dff948e38ae1b27fd https://github.com/tribe29/checkmk/commit/8f8dc87c564a5f8c9fe9b23dff948e38a… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M cmk/utils/rulesets/ruleset_matcher.py M cmk_base/config.py M tests/unit/cmk/utils/rulesets/test_ruleset_matcher.py M tests/unit/cmk_base/test_config.py Log Message: ----------- Service labels can now be used as service rule conditions The matching logic is equal to the host label matching. CMK-2402 Change-Id: Idb4d88e29a65e9b41d3b7cad10a176aeafe7c209 Commit: f70e566715af195d1dcbf017c201827428724ec9 https://github.com/tribe29/checkmk/commit/f70e566715af195d1dcbf017c20182742… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M cmk/gui/wato/pages/rulesets.py M cmk/gui/watolib/rulesets.py M cmk/utils/labels.py Log Message: ----------- Add service label matching to WATO GUI The service labels can now be configured as conditions, just like the host labels. The rule matching analysis, which is implemented in watolib.rulesets.Rule._get_mismatch_reasons_of_match_object is not working yet will be fixed in one of the next commits. CMK-2402 Change-Id: If283ed2a96ebe767946f6ae22d877cd0f50a5c64 Commit: b0110b551f52b620426de083e261ad4beec95885 https://github.com/tribe29/checkmk/commit/b0110b551f52b620426de083e261ad4be… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M cmk/gui/watolib/rulesets.py M cmk/utils/rulesets/ruleset_matcher.py M cmk_base/config.py M tests/unit/cmk_base/test_config.py Log Message: ----------- Remove unused host attributes from RuleMatchObject The host attributes (folder, labels, tags) are not used during matching phase of the rule processing. They are already resolved by the ruleset optimizer to a list of matching host names. For this reason the match object only needs the host_name attribute for matching the host conditions. CMK-2402 Change-Id: Ib73a33fffeae894c8348f40a7934adc5d5517bbd Commit: 304aa718a8b0e496267870be7ba5381b819a4cd1 https://github.com/tribe29/checkmk/commit/304aa718a8b0e496267870be7ba5381b8… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M cmk_base/autochecks.py Log Message: ----------- Cache labels of read autochecks for later use CMK-2402 Change-Id: I06db8ff641ce026667eebc95b21a4e50d9b7356a Commit: 15f4737b4aded62f05d433f549e0ba42ba2df299 https://github.com/tribe29/checkmk/commit/15f4737b4aded62f05d433f549e0ba42b… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M cmk/gui/watolib/rulesets.py M cmk/utils/labels.py A cmk_base/export.py Log Message: ----------- Make ruleset match analysis in WATO work - step 1 This is not possible without loading the whole Checkmk base configuration to get the rulesets, labels and so on. Using an automation, as we normally do would be a performance overkill. The component cmk_base now has one module cmk_base.export which exposes some functionality for other components, like the GUI. This is the same approach as we use in cmk.ec.export. We need some more steps to make the analysis really work, like transporting the service description through several pages of WATO instead of just the item. CMK-2402 Change-Id: Iee59a6a3896f4080e227e365b0feaf00ac1da8a2 Commit: cb6090a8463d82291abfd6a8ad17f29b01921849 https://github.com/tribe29/checkmk/commit/cb6090a8463d82291abfd6a8ad17f29b0… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M cmk/gui/wato/pages/object_parameters.py M cmk/gui/wato/pages/rulesets.py M cmk/gui/wato/pages/services.py M cmk/gui/watolib/rulesets.py M cmk_base/config.py M cmk_base/export.py Log Message: ----------- Make ruleset match analysis in WATO work - step 2 Care about special case of matching on checkgroup parameter rulesets. These rulesets do not use the whole service_description as condition, but only the check item name. This was working transparently until we need the real service description to gather the labels of a services for matching on rules that use service labels as conditions. To make this work we now use a specific helper function cmk_base.config.ruleset_match_object_for_checkgroup_parameters() to get a ruleset match object that uses the item as service_description and the real service_description to get service attributes like the service labels. CMK-2402 Change-Id: I4ab5dea31ffb9b25783d929d9de281aaa6a751e0 Commit: a78fd5ad24454daaf570bcfd91863048e32fea0a https://github.com/tribe29/checkmk/commit/a78fd5ad24454daaf570bcfd91863048e… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M cmk/gui/wato/pages/object_parameters.py M cmk/gui/wato/pages/pattern_editor.py M cmk/gui/wato/pages/rulesets.py M cmk/gui/wato/pages/services.py M cmk/gui/watolib/rulesets.py M cmk_base/config.py M cmk_base/export.py Log Message: ----------- Make ruleset match analysis in WATO work - step 3 Transport the real service description together with the check item through several WATO pages to make both available to the rule analysis logic of WATO. With this step the rule analysis is now working again. CMK-2402 Change-Id: Ie001f93c02a121f96b481144566eb7b6d4de3cb1 Commit: 53f483da2604f0fd20eecb88710b69157add571e https://github.com/tribe29/checkmk/commit/53f483da2604f0fd20eecb88710b69157… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M cmk/gui/wato/pages/pattern_editor.py M cmk/gui/watolib/rulesets.py Log Message: ----------- Remove odd logwatch pattern test: Logfile matching, but no host name given Change-Id: I9aeaa558ea2f95aefcaa6971780fefff632bb898 Commit: 11cfcd2907df223c1c27983919b163c0e9bfcf4a https://github.com/tribe29/checkmk/commit/11cfcd2907df223c1c27983919b163c0e… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: A .werks/7965 M cmk/gui/wato/pages/tags.py Log Message: ----------- 7965 FIX Fix updating hosts after editing tags When adding new tag groups or aux tags to existing tag choices, these tags were not immediately applied to the host configuration. The tags were applied to the hosts only after editing the host configuration. Change-Id: I2caa6f1d3772c6dd36d014f671f5c54b3e73ad2a Commit: 63e63a03017a22b9d1ea5b69fbfb55f6f4d9d5c4 https://github.com/tribe29/checkmk/commit/63e63a03017a22b9d1ea5b69fbfb55f6f… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M cmk/gui/wato/pages/tags.py M cmk/utils/tags.py M tests/unit/cmk/utils/test_utils_tags.py Log Message: ----------- Cleanup: Module import violation and naming of tag group ID * Remove cmk.gui import from cmk.utils.tags module. Importing a module of the cmk.gui component is not allowed from cmk.utils. * Improved naming of the tag group ID input field title Change-Id: I7fd24fb6359a16e7f538ee22fcae3fe7f49d7a29 Commit: a95692a6f0a771a195c6582aaa39fbfba0ef4043 https://github.com/tribe29/checkmk/commit/a95692a6f0a771a195c6582aaa39fbfba… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: A .werks/7986 Log Message: ----------- 7986 Service labels can be used as rule conditions The service labels, that are introduced with Checkmk 1.6 can now be used as conditions in service rulesets (Host & Service Parameters). These conditions can be configured like the host labels. The labels can not be used in the rulesets "Service labels", because that could result in a hen egg problem. Change-Id: If233dd91b5bdbc20484fcb62df0c2c068b75eff2 Compare: https://github.com/tribe29/checkmk/compare/bf02a00bbcec...a95692a6f0a7

5 years, 1 month

[tribe29/checkmk] bf02a0: One more try to fix wrong changes list in CI

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: bf02a00bbcece77ef10e7b0c773071f6e20fc2a0 https://github.com/tribe29/checkmk/commit/bf02a00bbcece77ef10e7b0c773071f6e… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M buildscripts/scripts/test-gerrit.jenkins Log Message: ----------- One more try to fix wrong changes list in CI Change-Id: I40800039b333a56162813f8ca108fa3904c978cf

5 years, 1 month

← Newer
1
...
10
11
12
13
14
15
16
...
66
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits July 2019