Checkmk git commits February 2019

checkmk-commits@lists.checkmk.com

18 participants
457 discussions

by Mathias Kettner

Module: check_mk Branch: master Commit: 62ffa3ca6b375aa3666bc8229508d99726fa8d1e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=62ffa3ca6b375a… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Feb 21 13:54:01 2019 +0100 Fixed screenshotmode für facelift theme --- web/htdocs/themes/facelift/scss/_main.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/web/htdocs/themes/facelift/scss/_main.scss b/web/htdocs/themes/facelift/scss/_main.scss index d7133d4..b199bd8 100644 --- a/web/htdocs/themes/facelift/scss/_main.scss +++ b/web/htdocs/themes/facelift/scss/_main.scss @@ -16,6 +16,10 @@ body.main { font-weight: $theme-font-weight-global; color: $theme-color-text; } +body.main.screenshotmode table.nform { + background-color: #ffffff; +} + .link, .title { display: inline-block; padding: 4px 2px;

5 years, 7 months

7180 FIX MKP manager: Changes to extension packages now mark the agent bakery to bake the agents

by Lars Michelsen

Module: check_mk Branch: master Commit: 40458f371ad92e3bf35e774205d423b1936d19a9 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=40458f371ad92e… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Feb 21 13:56:51 2019 +0100 7180 FIX MKP manager: Changes to extension packages now mark the agent bakery to bake the agents Changes to MKP packages in the extension packages module of WATO now tell the agent bakery that software changes have been made and the agents should be baked again. Change-Id: Id7ce4c3560e7699c049722c3b6ce0d06a123754d --- .werks/7180 | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.werks/7180 b/.werks/7180 new file mode 100644 index 0000000..f10106e --- /dev/null +++ b/.werks/7180 @@ -0,0 +1,13 @@ +Title: MKP manager: Changes to extension packages now mark the agent bakery to bake the agents +Level: 1 +Component: wato +Class: fix +Compatible: compat +Edition: cee +State: unknown +Version: 1.6.0i1 +Date: 1550677922 + +Changes to MKP packages in the extension packages module of WATO now tell the +agent bakery that software changes have been made and the agents should be +baked again.

5 years, 7 months

omd umount: Test for mount before trying to unmount

by Lars Michelsen

Module: check_mk Branch: master Commit: a4097b915eab638132b17fe2f5559c5e5f224bfd URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a4097b915eab63… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Feb 21 13:24:37 2019 +0100 omd umount: Test for mount before trying to unmount Change-Id: I64f95f38462e5fdffc7d69b902a0ed77a993f56c --- omd/packages/omd/omdlib/main.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/omd/packages/omd/omdlib/main.py b/omd/packages/omd/omdlib/main.py index 585362b..fd387b9 100644 --- a/omd/packages/omd/omdlib/main.py +++ b/omd/packages/omd/omdlib/main.py @@ -1699,6 +1699,11 @@ def unmount_tmpfs(site, output=True, kill=False): sys.stdout.write("Unmounting temporary filesystem...") for _t in range(0, 10): + if not tmpfs_mounted(site.name): + if output: + ok() + return True + if subprocess.call(["umount", site.tmp_dir]) == 0: if output: ok()

5 years, 7 months

Add test debug code

by Lars Michelsen

Module: check_mk Branch: master Commit: 314582bc3c1acba44da5d64ff9a115e7ab992bea URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=314582bc3c1acb… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Feb 21 13:50:35 2019 +0100 Add test debug code Change-Id: I552b857b1e6f4d0d6e64f6e70ff9a3df8c04b3c5 --- tests/integration/bin/test_mkbackup.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tests/integration/bin/test_mkbackup.py b/tests/integration/bin/test_mkbackup.py index a3f0dfa..c264cb6 100644 --- a/tests/integration/bin/test_mkbackup.py +++ b/tests/integration/bin/test_mkbackup.py @@ -4,6 +4,7 @@ import subprocess import re import os import tarfile +import time import fnmatch import fasteners import pytest # type: ignore @@ -129,12 +130,19 @@ def _execute_backup(site, job_id="testjob"): def _execute_restore(site, backup_id, env=None): with BackupLock(): + os.system("ps -ef") + os.system("mount") + os.system("ps -U %s" % site.id) p = site.execute(["mkbackup", "restore", "test-target", backup_id], stdout=subprocess.PIPE, stderr=subprocess.PIPE, env=env) stdout, stderr = p.communicate() - assert "Restore completed" in stdout, "Invalid output: %r" % stdout + try: + assert "Restore completed" in stdout, "Invalid output: %r" % stdout + except AssertionError: + time.sleep(1000) + raise assert stderr == "" assert p.wait() == 0

5 years, 7 months

YAPF'd forgotten file.

by Sven Panne

Module: check_mk Branch: master Commit: bdfdbb821b8c79ed040099400e191761bce13271 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=bdfdbb821b8c79… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Thu Feb 21 13:45:15 2019 +0100 YAPF'd forgotten file. Change-Id: Ib318710cdb735278f4fbbf72a0ac0831153ece6d --- tests/crawl-stats | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/crawl-stats b/tests/crawl-stats index dcb7824..d498008 100755 --- a/tests/crawl-stats +++ b/tests/crawl-stats @@ -2,6 +2,7 @@ stats = eval(file("var/crawl.stats").read()) + def print_url(title, entry): print print "%s:" % title

5 years, 7 months

Find (sane) Python files in tests/ directory, too.

by Sven Panne

Module: check_mk Branch: master Commit: fd12532485cc1381efc2155edb97f20190ce0c58 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=fd12532485cc13… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Thu Feb 21 13:23:52 2019 +0100 Find (sane) Python files in tests/ directory, too. Change-Id: Ife68f7eeebdf769e3adf2a4f95899f6690691401 --- tests/find-python-files | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tests/find-python-files b/tests/find-python-files index 23d65c9..31ca57a 100755 --- a/tests/find-python-files +++ b/tests/find-python-files @@ -23,10 +23,7 @@ SEARCH+=" omd/packages/cma" SEARCH+=" omd/packages/maintenance" SEARCH+=" omd/packages/omd" SEARCH+=" scripts" -# Tests contain some very large data structures (e.g. -# tests/unit/checks/test_docker_parse_node_images.py). Skip them for the -# moment because they make YAPF run more than 60 minutes instead of 8 minutes -#SEARCH+=" tests" +SEARCH+=" tests" SEARCH+=" web/app" SEARCH+=" werk" @@ -34,7 +31,12 @@ SEARCH+=" werk" REAL_SEARCH=$(realpath $SEARCH) # while read F is used to deal with files containing whitespaces -find $REAL_SEARCH -name .venv -prune -o -type f -print | sort | while read F; do +find $REAL_SEARCH \ + -name .mypy_cache -prune -o \ + -name .venv -prune -o \ + -name test_docker_parse_node_images.py -prune -o \ + -name typeshed -prune -o \ + -type f -print | sort | while read F; do if [[ "$F" == *.py ]] || head -n 1 "$F" | grep -q '^#!.*python$' >/dev/null 2>&1; then echo "$F" fi

5 years, 7 months

Don't YAPF files which take ages to format.

by Sven Panne

Module: check_mk Branch: master Commit: 9bd5b4d56efcc0ef727f2e9457c6c436cd717624 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=9bd5b4d56efcc0… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Thu Feb 21 13:40:36 2019 +0100 Don't YAPF files which take ages to format. Change-Id: Ib6b24fbf3df063569afb239a14ab7b48c59b5818 --- tests/unit/checks/generictests/datasets/acme_sbc_snmp.py | 1 + .../unit/checks/generictests/datasets/aix_hacmp_resources_regression.py | 1 + tests/unit/checks/generictests/datasets/alcatel_cpu.py | 1 + tests/unit/checks/generictests/datasets/alcatel_cpu_aos7.py | 1 + tests/unit/checks/generictests/datasets/alcatel_power_regression.py | 1 + tests/unit/checks/generictests/datasets/alcatel_temp.py | 1 + .../generictests/datasets/alcatel_temp_aos7_all_boards_connected.py | 1 + .../generictests/datasets/alcatel_temp_aos7_most_recent_temperature.py | 1 + .../datasets/alcatel_temp_aos7_single_board_connected_crit.py | 1 + .../datasets/alcatel_temp_aos7_single_board_connected_warn.py | 1 + tests/unit/checks/generictests/datasets/apc_symmetra_regression.py | 1 + tests/unit/checks/generictests/datasets/azure_databases.py | 1 + tests/unit/checks/generictests/datasets/azure_sites.py | 1 + tests/unit/checks/generictests/datasets/azure_storageaccounts.py | 1 + tests/unit/checks/generictests/datasets/azure_virtualmachines_1.py | 1 + .../checks/generictests/datasets/azure_virtualmachines_1_on_grouphost.py | 1 + tests/unit/checks/generictests/datasets/azure_virtualmachines_1_on_vm.py | 1 + tests/unit/checks/generictests/datasets/azure_virtualnetworkgateways.py | 1 + tests/unit/checks/generictests/datasets/brocade.py | 1 + tests/unit/checks/generictests/datasets/brocade_fcport_info.py | 1 + tests/unit/checks/generictests/datasets/brocade_fcport_parsed.py | 1 + tests/unit/checks/generictests/datasets/brocade_optical_1_regression.py | 1 + tests/unit/checks/generictests/datasets/brocade_optical_2_regression.py | 1 + tests/unit/checks/generictests/datasets/cisco_mem.py | 1 + tests/unit/checks/generictests/datasets/cisco_secure_1_regression.py | 1 + tests/unit/checks/generictests/datasets/cisco_secure_2_regression.py | 1 + tests/unit/checks/generictests/datasets/cups_queues.py | 1 + tests/unit/checks/generictests/datasets/cups_queues_am.py | 1 + tests/unit/checks/generictests/datasets/cups_queues_pm.py | 1 + tests/unit/checks/generictests/datasets/db2_connections.py | 1 + tests/unit/checks/generictests/datasets/df_lnx_regression.py | 1 + tests/unit/checks/generictests/datasets/df_win_regression.py | 1 + .../unit/checks/generictests/datasets/docker_node_disk_usage_raw_text.py | 1 + .../checks/generictests/datasets/docker_node_disk_usage_regression.py | 1 + tests/unit/checks/generictests/datasets/docker_node_info_2.py | 1 + .../checks/generictests/datasets/docker_node_info_centos6_regression.py | 1 + tests/unit/checks/generictests/datasets/docker_node_info_raw_text.py | 1 + tests/unit/checks/generictests/datasets/docker_node_info_regression.py | 1 + .../datasets/dotnet_clrmemory_hp_proliant_win_5_regression.py | 1 + .../datasets/dotnet_clrmemory_server_windows_14_regression.py | 1 + .../datasets/dotnet_clrmemory_server_windows_dotnet_regression.py | 1 + .../datasets/dotnet_clrmemory_server_windows_interfaces_regression.py | 1 + .../dotnet_clrmemory_server_windows_kaspersky_error_regression.py | 1 + .../unit/checks/generictests/datasets/emcvnx_storage_pools_regression.py | 1 + .../checks/generictests/datasets/esx_vsphere_hostsystem_55_regression.py | 1 + .../generictests/datasets/esx_vsphere_hostsystem_esx51_regression.py | 1 + .../checks/generictests/datasets/esx_vsphere_hostsystem_regression.py | 1 + tests/unit/checks/generictests/datasets/esx_vsphere_objects_1_feature.py | 1 + .../checks/generictests/datasets/esx_vsphere_objects_1_regression.py | 1 + tests/unit/checks/generictests/datasets/esx_vsphere_sensors_1.py | 1 + tests/unit/checks/generictests/datasets/esx_vsphere_sensors_2.py | 1 + tests/unit/checks/generictests/datasets/esx_vsphere_vm_snapshots.py | 1 + tests/unit/checks/generictests/datasets/fileinfo_new_empty.py | 1 + tests/unit/checks/generictests/datasets/fileinfo_new_output.py | 1 + tests/unit/checks/generictests/datasets/fileinfo_old_empty_regression.py | 1 + .../unit/checks/generictests/datasets/fileinfo_old_output_regression.py | 1 + tests/unit/checks/generictests/datasets/filestats_1.py | 1 + tests/unit/checks/generictests/datasets/filestats_broken_sections.py | 1 + tests/unit/checks/generictests/datasets/genua_carp_1.py | 1 + tests/unit/checks/generictests/datasets/hp_msa_fan_regression.py | 1 + tests/unit/checks/generictests/datasets/hp_msa_volume_regression.py | 1 + tests/unit/checks/generictests/datasets/hp_proliant_psu_regression.py | 1 + tests/unit/checks/generictests/datasets/ipmi_sensors.py | 1 + tests/unit/checks/generictests/datasets/jolokia_generic.py | 1 + tests/unit/checks/generictests/datasets/jolokia_info_regression.py | 1 + .../unit/checks/generictests/datasets/juniper_bgp_state_1_regression.py | 1 + .../unit/checks/generictests/datasets/juniper_bgp_state_ip_addresses.py | 1 + tests/unit/checks/generictests/datasets/k8s_conditions_regression.py | 1 + tests/unit/checks/generictests/datasets/k8s_resources_regression.py | 1 + tests/unit/checks/generictests/datasets/k8s_roles_regression.py | 1 + tests/unit/checks/generictests/datasets/k8s_stats.py | 1 + tests/unit/checks/generictests/datasets/lnx_thermal.py | 1 + tests/unit/checks/generictests/datasets/lparstat_aix_1_regression.py | 1 + tests/unit/checks/generictests/datasets/lparstat_aix_2_regression.py | 1 + tests/unit/checks/generictests/datasets/lparstat_aix_regression.py | 1 + tests/unit/checks/generictests/datasets/mem_win_regression.py | 1 + .../datasets/msexch_activesync_server_windows_exchange_1_regression.py | 1 + .../msexch_autodiscovery_server_windows_kaspersky_error_2_regression.py | 1 + .../datasets/msexch_availability_server_windows_exchange_1_regression.py | 1 + tests/unit/checks/generictests/datasets/msexch_database_de_regression.py | 1 + .../datasets/msexch_isclienttype_server_windows_exchange_1_regression.py | 1 + .../datasets/msexch_isstore_server_windows_exchange_1_regression.py | 1 + .../datasets/msexch_isstore_server_windows_msexch_2_regression.py | 1 + .../datasets/msexch_owa_server_windows_exchange_1_regression.py | 1 + ...msexch_rpcclientaccess_server_windows_kaspersky_error_2_regression.py | 1 + tests/unit/checks/generictests/datasets/mysql_slave_regression.py | 1 + tests/unit/checks/generictests/datasets/netapp_api_aggr_regression.py | 1 + tests/unit/checks/generictests/datasets/netapp_api_connection.py | 1 + tests/unit/checks/generictests/datasets/netapp_api_luns_regression.py | 1 + .../checks/generictests/datasets/netapp_api_qtree_quota_regression.py | 1 + .../unit/checks/generictests/datasets/netapp_api_snapvault_regression.py | 1 + tests/unit/checks/generictests/datasets/nfsmounts_1.py | 1 + tests/unit/checks/generictests/datasets/poseidon_inputs_1.py | 1 + tests/unit/checks/generictests/datasets/poseidon_temp_1.py | 1 + tests/unit/checks/generictests/datasets/prism_alerts.py | 1 + .../generictests/datasets/quantum_libsmall_status_12_regression.py | 1 + .../generictests/datasets/quantum_libsmall_status_15_regression.py | 1 + tests/unit/checks/generictests/datasets/raritan_pdu_ocprot_regression.py | 1 + .../checks/generictests/datasets/raritan_pdu_outletcount_regression.py | 1 + tests/unit/checks/generictests/datasets/raritan_pdu_plugs_regression.py | 1 + tests/unit/checks/generictests/datasets/skype_skype_1_regression.py | 1 + tests/unit/checks/generictests/datasets/skype_skype_2_regression.py | 1 + .../checks/generictests/datasets/systemd_units_services_1_regression.py | 1 + .../generictests/datasets/systemd_units_services_2_failed_regression.py | 1 + .../unit/checks/generictests/datasets/ucs_bladecenter_psu_regression.py | 1 + tests/unit/checks/generictests/datasets/ucs_bladecenter_topsystem.py | 1 + tests/unit/checks/generictests/datasets/uptime_1.py | 1 + tests/unit/checks/generictests/datasets/varnish_new_format_regression.py | 1 + tests/unit/checks/generictests/datasets/varnish_old_format_regression.py | 1 + tests/unit/checks/generictests/datasets/veritas_vcs_1.py | 1 + tests/unit/checks/generictests/datasets/vms_cpu_regression.py | 1 + tests/unit/checks/generictests/datasets/windows_multipath_1.py | 1 + tests/unit/checks/generictests/datasets/winperf_if_regression.py | 1 + tests/unit/checks/generictests/datasets/winperf_if_teaming_regression.py | 1 + .../generictests/datasets/wmi_cpuload_hp_proliant_win_5_regression.py | 1 + .../datasets/wmi_cpuload_server_windows_cpuload_regression.py | 1 + .../checks/generictests/datasets/wmi_include_empty_info_regression.py | 1 + .../datasets/wmi_webservices_server_windows_exchange_1_regression.py | 1 + tests/unit/checks/generictests/datasets/zfsget.py | 1 + tests/unit/checks/test_docker_parse_node_images.py | 1 + tests/unit/checks/test_ps.py | 1 + tests/unit/cmk/gui/test_views.py | 1 + tests/unit/cmk/gui/test_visuals.py | 1 + tests/unit/cmk/gui/watolib/test_rulespecs.py | 1 + 124 files changed, 124 insertions(+) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=9bd5b4d56e…

5 years, 7 months

YAPF'd test/unit/.

by Sven Panne

Module: check_mk Branch: master Commit: 1cadff92be6031dfe8f43e7ccc5828bf8d1f11f5 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1cadff92be6031… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Thu Feb 21 12:07:54 2019 +0100 YAPF'd test/unit/. Change-Id: Iccfc09317febacd02e48928ea5b497360bbb3562 --- tests/unit/agents/plugins/test_mk_filestats.py | 42 +- tests/unit/agents/plugins/test_mk_logwatch.py | 6 +- .../unit/agents/plugins/test_mk_logwatch_bakery.py | 2 +- tests/unit/checks/generictests/__init__.py | 1 - tests/unit/checks/generictests/conftest.py | 6 +- .../checks/generictests/datasets/acme_sbc_snmp.py | 21 +- .../checks/generictests/datasets/alcatel_cpu.py | 9 +- .../datasets/alcatel_power_regression.py | 37 +- .../alcatel_temp_aos7_all_boards_connected.py | 147 +- .../alcatel_temp_aos7_most_recent_temperature.py | 47 +- ...lcatel_temp_aos7_single_board_connected_crit.py | 32 +- ...lcatel_temp_aos7_single_board_connected_warn.py | 32 +- .../datasets/apc_symmetra_regression.py | 68 +- .../checks/generictests/datasets/azure_sites.py | 198 +- .../datasets/azure_virtualnetworkgateways.py | 29 +- tests/unit/checks/generictests/datasets/brocade.py | 63 +- .../generictests/datasets/brocade_fcport_info.py | 1933 +- .../datasets/brocade_optical_1_regression.py | 102 +- .../datasets/brocade_optical_2_regression.py | 499 +- .../generictests/datasets/db2_connections.py | 13 +- .../datasets/docker_node_disk_usage_raw_text.py | 77 +- .../datasets/docker_node_disk_usage_regression.py | 107 +- .../generictests/datasets/docker_node_info_2.py | 115 +- .../datasets/docker_node_info_raw_text.py | 84 +- .../datasets/docker_node_info_regression.py | 37 +- ...otnet_clrmemory_hp_proliant_win_5_regression.py | 798 +- ...otnet_clrmemory_server_windows_14_regression.py | 218 +- ...t_clrmemory_server_windows_dotnet_regression.py | 1047 +- ...rmemory_server_windows_interfaces_regression.py | 607 +- ...ry_server_windows_kaspersky_error_regression.py | 290 +- .../datasets/emcvnx_storage_pools_regression.py | 69 +- .../datasets/esx_vsphere_objects_1_feature.py | 54 +- .../datasets/esx_vsphere_objects_1_regression.py | 370 +- .../generictests/datasets/fileinfo_new_empty.py | 5 - .../generictests/datasets/fileinfo_new_output.py | 41 +- .../datasets/fileinfo_old_empty_regression.py | 6 - .../checks/generictests/datasets/filestats_1.py | 101 +- .../datasets/hp_proliant_psu_regression.py | 43 +- .../checks/generictests/datasets/ipmi_sensors.py | 24 +- .../datasets/jolokia_info_regression.py | 56 +- .../datasets/juniper_bgp_state_1_regression.py | 16 +- .../datasets/juniper_bgp_state_ip_addresses.py | 8 +- .../datasets/k8s_conditions_regression.py | 35 +- .../unit/checks/generictests/datasets/k8s_stats.py | 155 +- .../checks/generictests/datasets/lnx_thermal.py | 12 +- .../datasets/lparstat_aix_2_regression.py | 105 +- .../datasets/lparstat_aix_regression.py | 4 +- .../generictests/datasets/mem_win_regression.py | 15 +- ..._server_windows_kaspersky_error_2_regression.py | 51 +- ...ability_server_windows_exchange_1_regression.py | 166 +- .../datasets/msexch_database_de_regression.py | 506 +- ...xch_owa_server_windows_exchange_1_regression.py | 313 +- .../datasets/mysql_slave_regression.py | 71 +- .../datasets/netapp_api_luns_regression.py | 152 +- .../datasets/netapp_api_qtree_quota_regression.py | 420 +- .../datasets/netapp_api_snapvault_regression.py | 83 +- .../checks/generictests/datasets/nfsmounts_1.py | 13 +- .../generictests/datasets/poseidon_inputs_1.py | 59 +- .../checks/generictests/datasets/prism_alerts.py | 29 +- .../quantum_libsmall_status_12_regression.py | 31 +- .../quantum_libsmall_status_15_regression.py | 32 +- .../datasets/raritan_pdu_ocprot_regression.py | 87 +- .../datasets/raritan_pdu_outletcount_regression.py | 11 +- .../datasets/raritan_pdu_plugs_regression.py | 17 +- .../datasets/skype_skype_1_regression.py | 27160 +++++-------------- .../datasets/skype_skype_2_regression.py | 7594 +----- .../unit/checks/generictests/datasets/uptime_1.py | 7 +- .../datasets/varnish_old_format_regression.py | 514 +- .../generictests/datasets/windows_multipath_1.py | 15 +- .../generictests/datasets/winperf_if_regression.py | 54 +- .../datasets/winperf_if_teaming_regression.py | 282 +- ...mi_cpuload_server_windows_cpuload_regression.py | 77 +- .../datasets/wmi_include_empty_info_regression.py | 5 - tests/unit/checks/generictests/datasets/zfsget.py | 454 +- tests/unit/checks/test_agent_3par.py | 7 +- tests/unit/checks/test_check_http.py | 64 +- tests/unit/checks/test_df_check.py | 429 +- .../checks/test_docker_parse_network_inspect.py | 216 +- tests/unit/checks/test_docker_parse_node_images.py | 7527 +++-- tests/unit/checks/test_docker_parse_node_info.py | 667 +- .../test_docker_parse_subsection_image_inspect.py | 1139 +- tests/unit/checks/test_docker_parse_system_df.py | 185 +- tests/unit/checks/test_generic_datasets.py | 8 +- tests/unit/checks/test_if_check.py | 53 +- tests/unit/checks/test_lnx_if.py | 2 +- tests/unit/checks/test_lnx_thermal.py | 3 + tests/unit/checks/test_mbg_lantime_ng_refclock.py | 63 +- tests/unit/checks/test_mkbackup_check.py | 190 +- tests/unit/checks/test_multipath.py | 32 +- .../checks/test_nfsmounts_and_cifsmounts_check.py | 113 +- tests/unit/checks/test_ps.py | 10 +- tests/unit/checks/test_ra32e_power_check.py | 6 +- tests/unit/checks/test_ra32e_sensors_check.py | 158 +- tests/unit/checks/test_ra32e_switch_check.py | 38 +- tests/unit/checks/test_uptime_check.py | 12 +- tests/unit/checks/test_veritas_vcs_check.py | 244 +- tests/unit/cmk/ec/test_perfcounters.py | 15 +- tests/unit/cmk/ec/test_rule_matching.py | 298 +- tests/unit/cmk/gui/test_background_job.py | 3 +- tests/unit/cmk/gui/test_htmllib_Encoder.py | 25 +- tests/unit/cmk/gui/test_htmllib_Escaper.py | 1 + tests/unit/cmk/gui/test_htmllib_HTML.py | 12 +- tests/unit/cmk/gui/test_htmllib_HTMLGenerator.py | 9 +- tests/unit/cmk/gui/test_htmllib_OutputFunnel.py | 1 - .../cmk/gui/test_htmllib_TransactionManager.py | 2 + tests/unit/cmk/gui/test_http.py | 19 +- tests/unit/cmk/gui/test_index.py | 1 + tests/unit/cmk/gui/test_key_mgmt.py | 3 +- tests/unit/cmk/gui/test_metrics.py | 9 +- tests/unit/cmk/gui/test_sidebar.py | 32 +- tests/unit/cmk/gui/test_table.py | 9 +- .../unit/cmk/gui/test_userdb_htpasswd_connector.py | 23 +- tests/unit/cmk/gui/test_views.py | 1 + tests/unit/cmk/notifications/test_slack.py | 9 +- tests/unit/cmk/notifications/test_victorops.py | 48 +- tests/unit/cmk/test_base.py | 1 + tests/unit/cmk/utils/test_daemon.py | 1 + tests/unit/cmk/utils/test_log.py | 2 +- tests/unit/cmk/utils/test_store.py | 11 +- tests/unit/cmk_base/conftest.py | 2 +- tests/unit/cmk_base/test_caching.py | 5 +- tests/unit/cmk_base/test_checking.py | 165 +- tests/unit/cmk_base/test_checks.py | 28 +- tests/unit/cmk_base/test_config.py | 3 +- tests/unit/cmk_base/test_core_config.py | 1 + tests/unit/cmk_base/test_rulesets.py | 86 +- tests/unit/conftest.py | 1 + tests/unit/inventory/test_inv_docker_node_info.py | 70 +- tests/unit/plugins/test_mk_jolokia.py | 6 +- 129 files changed, 17526 insertions(+), 40531 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=1cadff92be…

5 years, 7 months

test_no_exeption: Always close stdin for consistent test behaviour

by Lars Michelsen

Module: check_mk Branch: master Commit: 3cc472799e1f573185ddf7a24051ab16d609bf71 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3cc472799e1f57… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Feb 21 11:43:22 2019 +0100 test_no_exeption: Always close stdin for consistent test behaviour Change-Id: Ib6b5b4822021009f9d88a86685acbc244c689bfc --- tests/integration/agents/special/test_executables.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/integration/agents/special/test_executables.py b/tests/integration/agents/special/test_executables.py index dfd57fd..fc956d0 100644 --- a/tests/integration/agents/special/test_executables.py +++ b/tests/integration/agents/special/test_executables.py @@ -26,6 +26,7 @@ import subprocess +import os from pathlib2 import Path @@ -37,8 +38,9 @@ def test_no_exeption(site): errors or a wrong PYTHONPATH. """ special_agent_dir = Path(site.root) / 'share' / 'check_mk' / 'agents' / 'special' - for special_agent_path in special_agent_dir.glob('agent_*'): + for special_agent_path in special_agent_dir.glob('agent_*'): # pylint: disable=no-member command = [str(special_agent_path)] - p = site.execute(command, stdout=subprocess.PIPE, stderr=subprocess.PIPE) - stdout, stderr = p.communicate() + p = site.execute( + command, stdout=subprocess.PIPE, stderr=subprocess.PIPE, stdin=open(os.devnull)) + stderr = p.communicate()[1] assert "Traceback (most recent call last):" not in stderr

5 years, 7 months

YAPF'd test/ directory, excluding test/unit/.

by Sven Panne

Module: check_mk Branch: master Commit: f23c1a869e6781e8e06d4877ea3fc1db94d3469e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f23c1a869e6781… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Thu Feb 21 11:17:49 2019 +0100 YAPF'd test/ directory, excluding test/unit/. Change-Id: I0a0b29ec66e39708d537d495dbea12fdb8018ce2 --- tests/git/conftest.py | 1 + tests/git/test_find_debug_code_web.py | 3 +- tests/git/test_find_debug_print.py | 10 +- tests/integration/cmk/ec/test_mkeventd_status.py | 52 ++-- tests/integration/cmk/gui/test_backup.py | 1 + tests/integration/cmk/gui/test_login.py | 1 + tests/integration/cmk/test_omd_version.py | 1 + tests/integration/cmk/utils/test_site_werks.py | 10 +- tests/integration/cmk_base/test_check_variables.py | 54 ++-- tests/integration/cmk_base/test_mgmt_board.py | 340 ++++++++++++--------- tests/integration/cmk_base/test_modes.py | 181 ++++++----- tests/integration/core/test_active_checks.py | 85 +++--- tests/integration/notifications/test_simple_rbn.py | 12 +- .../test_unreachable_notifications.py | 132 +++++--- tests/integration/omd/test_basic_commands.py | 1 + tests/integration/omd/test_hooks.py | 1 + tests/integration/omd/test_monitoring_plugins.py | 1 + tests/integration/omd/test_omd.py | 3 +- tests/integration/omd/test_perl.py | 1 - tests/integration/omd/test_setuid_binaries.py | 1 + tests/packaging/conftest.py | 1 + tests/pylint/conftest.py | 1 + tests/testlib/pylint_checker_localization.py | 27 +- tests/testlib/pylint_cmk.py | 22 +- 24 files changed, 553 insertions(+), 389 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=f23c1a869e…

5 years, 7 months

← Newer
1
...
12
13
14
15
16
17
18
...
46
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits February 2019