Checkmk git commits November 2019

checkmk-commits@lists.checkmk.com

1 participants
494 discussions

[tribe29/checkmk] 20071a: Always output profiling information

by Lars

Branch: refs/heads/1.5.0 Home: https://github.com/tribe29/checkmk Commit: 20071ae5869832c2fcbc2f62c7eb1a6af9c9d29b https://github.com/tribe29/checkmk/commit/20071ae5869832c2fcbc2f62c7eb1a6af… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2019-11-04 (Mon, 04 Nov 2019) Changed paths: M bin/check_mk Log Message: ----------- Always output profiling information Change-Id: I548265afb0d9550c536473f4f73de9cb3d44646a Commit: 1a08d6208c71b418d65a29856e13f86dff2d3eb2 https://github.com/tribe29/checkmk/commit/1a08d6208c71b418d65a29856e13f86df… Author: Andreas Boesl <andreas.boesl(a)tribe29.com> Date: 2019-11-04 (Mon, 04 Nov 2019) Changed paths: A .werks/7283 M web/htdocs/background_job.py Log Message: ----------- 7283 FIX background jobs: fixed parsing of broken background job status files Change-Id: I4e0a8e437d92ef2dc3c647bdfffb53481a59220c Compare: https://github.com/tribe29/checkmk/compare/151aa4ea841b...1a08d6208c71

4 years, 7 months

[tribe29/checkmk] 57449a: 10379 FIX Hostname search: Host bulk actions affec...

by Tom Bärwinkel

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: 57449a2248c268708fbf936aa762dee169211310 https://github.com/tribe29/checkmk/commit/57449a2248c268708fbf936aa762dee16… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-04 (Mon, 04 Nov 2019) Changed paths: A .werks/10379 M cmk/gui/wato/pages/search.py Log Message: ----------- 10379 FIX Hostname search: Host bulk actions affected all hosts (1.6.0p4 regression) When using the WATO host search to filter hosts by a host name pattern, the resulting page showed the correctly matched hosts. When performing a bulk operation on this page, this affected all hosts instead of the filtered hosts. This regression was introduced by #10259 with 1.6.0p5. Change-Id: Ief4e675a1bf10a456da1d67467e1b72b41d469ee Commit: 4bbc0f06c721ef8d7e83325b3b0019624033d7ce https://github.com/tribe29/checkmk/commit/4bbc0f06c721ef8d7e83325b3b0019624… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2019-11-04 (Mon, 04 Nov 2019) Changed paths: M bin/check_mk Log Message: ----------- Always output profiling information Change-Id: I548265afb0d9550c536473f4f73de9cb3d44646a Compare: https://github.com/tribe29/checkmk/compare/b9811f7280d7...4bbc0f06c721

4 years, 7 months

[tribe29/checkmk] 6974b4: 10379 FIX Hostname search: Host bulk actions affec...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 6974b4eb6be64704d456e431c6ee660dcefce856 https://github.com/tribe29/checkmk/commit/6974b4eb6be64704d456e431c6ee660dc… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-04 (Mon, 04 Nov 2019) Changed paths: A .werks/10379 M cmk/gui/wato/pages/search.py Log Message: ----------- 10379 FIX Hostname search: Host bulk actions affected all hosts (1.6.0p4 regression) When using the WATO host search to filter hosts by a host name pattern, the resulting page showed the correctly matched hosts. When performing a bulk operation on this page, this affected all hosts instead of the filtered hosts. This regression was introduced by #10259 with 1.6.0p5. Change-Id: Ief4e675a1bf10a456da1d67467e1b72b41d469ee Commit: 0eabcabc52f2d93e52c02169abf41f6aa582eeb9 https://github.com/tribe29/checkmk/commit/0eabcabc52f2d93e52c02169abf41f6aa… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2019-11-04 (Mon, 04 Nov 2019) Changed paths: M bin/check_mk Log Message: ----------- Always output profiling information Change-Id: I548265afb0d9550c536473f4f73de9cb3d44646a Commit: 96f68aa69ba76db3cb902363b3defa453f6784be https://github.com/tribe29/checkmk/commit/96f68aa69ba76db3cb902363b3defa453… Author: Andreas Boesl <andreas.boesl(a)tribe29.com> Date: 2019-11-04 (Mon, 04 Nov 2019) Changed paths: A .werks/7284 M cmk/gui/plugins/wato/builtin_attributes.py M cmk/gui/watolib/host_attributes.py M cmk/gui/watolib/hosts_and_folders.py M cmk_base/config.py M cmk_base/default_config/base.py Log Message: ----------- introduced explicit_host_attributes Change-Id: I0d43dc7ba4d4936a7eacfc3a0b15d85a6df6c579 Compare: https://github.com/tribe29/checkmk/compare/c51963ab30ca...96f68aa69ba7

4 years, 7 months

[tribe29/checkmk] b9811f: 10342 FIX HW/SW Inventory: Do not overwrite invent...

by Simon

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: b9811f7280d74c7afe94ac6f5ad148326ab8cbdc https://github.com/tribe29/checkmk/commit/b9811f7280d74c7afe94ac6f5ad148326… Author: Simon Jess <simon.jess(a)tribe29.com> Date: 2019-11-04 (Mon, 04 Nov 2019) Changed paths: A .werks/10342 M cmk_base/inventory.py Log Message: ----------- 10342 FIX HW/SW Inventory: Do not overwrite inventory tree if ALL data sources of a host fail Change-Id: Ie4e02bba03e311163a474796f9b2758c48bdc6f8

4 years, 7 months

[tribe29/checkmk] cfff1e: 10342 FIX HW/SW Inventory: Do not overwrite invent...

by Sergey Kipnis

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: cfff1e07fe4de9ec2bd62d89a0c75f188c6b4f46 https://github.com/tribe29/checkmk/commit/cfff1e07fe4de9ec2bd62d89a0c75f188… Author: Simon Jess <simon.jess(a)tribe29.com> Date: 2019-11-04 (Mon, 04 Nov 2019) Changed paths: A .werks/10342 M cmk_base/inventory.py Log Message: ----------- 10342 FIX HW/SW Inventory: Do not overwrite inventory tree if ALL data sources of a host fail Change-Id: Ie4e02bba03e311163a474796f9b2758c48bdc6f8 Commit: c51963ab30ca8e1acceb0bf20e2092d56d1abca7 https://github.com/tribe29/checkmk/commit/c51963ab30ca8e1acceb0bf20e2092d56… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2019-11-04 (Mon, 04 Nov 2019) Changed paths: M agents/wnx/install/resources/check_mk.user.yml Log Message: ----------- [CMK-2951] - winps - YML supports use_wmi=No - creation of the ps section in YML - tests Change-Id: I36c1b5fbbdeff32966acd0bc6841e35650f8c676 Compare: https://github.com/tribe29/checkmk/compare/8a4394a4bbe8...c51963ab30ca

4 years, 7 months

[tribe29/checkmk] 413bbf: Reserved 30 Werk IDS

by Óscar Nájera

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 413bbf4d894a82ce7d8f0db3463b432f42c968f9 https://github.com/tribe29/checkmk/commit/413bbf4d894a82ce7d8f0db3463b432f4… Author: Andreas Boesl <andreas.boesl(a)tribe29.com> Date: 2019-11-04 (Mon, 04 Nov 2019) Changed paths: M .werks/first_free Log Message: ----------- Reserved 30 Werk IDS Change-Id: I5e4aa8305e18ab3c3119a91f535d14b1bc02411e Commit: b2884dd6ccf5b6c65f4f165cad392f69db43b0ba https://github.com/tribe29/checkmk/commit/b2884dd6ccf5b6c65f4f165cad392f69d… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2019-11-04 (Mon, 04 Nov 2019) Changed paths: A .werks/10422 A checkman/cisco_cpu_memory A checks/cisco_cpu_memory M checks/cisco_mem.include M cmk/gui/plugins/metrics/check_mk.py A cmk/gui/plugins/wato/check_parameters/cisco_cpu_memory.py A tests/unit/checks/generictests/datasets/cisco_cpu_memory.py M tests/unit/checks/generictests/datasets/cisco_mem.py M tests/unit/checks/generictests/datasets/cisco_mem_asa64_5c2e2c9a3a465_regression.py Log Message: ----------- 10422 cisco_cpu_memory: Check for monitoring CPU Memory of Cisco devices This check monitors the CPU Memory level of Cisco devices. A Wato rule can be configured depending on free or occupied memory. The details displayed on the service depend on this WATO rule with the default being free memory. The performance graph will always be based on occupied memory. Change-Id: I3c35c4a40082aaa33f085bca63d258b4a9a13c36 Commit: 8a4394a4bbe8da412e32b2527614384cca0b803f https://github.com/tribe29/checkmk/commit/8a4394a4bbe8da412e32b2527614384cc… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2019-11-04 (Mon, 04 Nov 2019) Changed paths: A .werks/10402 M cmk/utils/prediction.py M tests/unit/cmk/utils/test_prediction_commons.py Log Message: ----------- 10402 FIX Deal with RRD sources which are not updated anymore in multiline graphs The metrics "Guest operating systems" and "CPU time stolen by other operating systems" that appear on the CPU utilization service Check for unix systems are only relevant on virtualized environments. On other cases they are always zero, and thus completely skipped in the graphs, but still tracked by the monitoring core. Checkmk 1.6 stopped delivering this metrics for systems where they are irrelevant. This saves disk space, and disk I/O improving scalability. If you update from Checkmk 1.5, the unused RRDs will remain in disk but won't be updated anymore. If you use the RRD single format you wont experience any problem, but if you are on RRD format for one RRD per metric, the RRDs will go out of sync. At the time of drawing the graphs, this lack of syncronicity will disrupt the resolution of the data, and crash the graphs, if two metrics have a different resolution. With this werk, data is resampled after being retrieved from the core if the metrics on the same graph have different resolutions. Change-Id: I2b563487dbe0915fb4b213285f0a25a1ebff2ea1 Compare: https://github.com/tribe29/checkmk/compare/71c9209b0a6a...8a4394a4bbe8

4 years, 7 months

[tribe29/checkmk] 47533e: agent_aws: Collect live data if config has changed

by Simon

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: 47533e3334ff3164af4d61f7b003d539237ddb9c https://github.com/tribe29/checkmk/commit/47533e3334ff3164af4d61f7b003d5392… Author: Simon Jess <simon.jess(a)tribe29.com> Date: 2019-11-04 (Mon, 04 Nov 2019) Changed paths: A .werks/10360 M cmk/special_agents/agent_aws.py M cmk/special_agents/utils.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_cloudwatch.py A tests/unit/cmk/special_agents/agent_aws/test_agent_aws_config.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_costs_and_usage.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_ebs.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_ec2.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_elb.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_elbv2.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_rds.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_s3.py Log Message: ----------- agent_aws: Collect live data if config has changed Change-Id: I02d521aa9b6d640f50b93d7cb86ceba7874709aa

4 years, 7 months

[tribe29/checkmk] 1a6667: 10402 FIX Deal with RRD sources which are not upda...

by Óscar Nájera

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: 1a6667655b9120f6aa01977ef84c235dcbc90d53 https://github.com/tribe29/checkmk/commit/1a6667655b9120f6aa01977ef84c235dc… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2019-11-04 (Mon, 04 Nov 2019) Changed paths: A .werks/10402 M cmk/utils/prediction.py M tests/unit/cmk/utils/test_prediction_commons.py Log Message: ----------- 10402 FIX Deal with RRD sources which are not updated anymore in multiline graphs The metrics "Guest operating systems" and "CPU time stolen by other operating systems" that appear on the CPU utilization service Check for unix systems are only relevant on virtualized environments. On other cases they are always zero, and thus completely skipped in the graphs, but still tracked by the monitoring core. Checkmk 1.6 stopped delivering this metrics for systems where they are irrelevant. This saves disk space, and disk I/O improving scalability. If you update from Checkmk 1.5, the unused RRDs will remain in disk but won't be updated anymore. If you use the RRD single format you wont experience any problem, but if you are on RRD format for one RRD per metric, the RRDs will go out of sync. At the time of drawing the graphs, this lack of syncronicity will disrupt the resolution of the data, and crash the graphs, if two metrics have a different resolution. With this werk, data is resampled after being retrieved from the core if the metrics on the same graph have different resolutions. Change-Id: I2b563487dbe0915fb4b213285f0a25a1ebff2ea1

4 years, 7 months

[tribe29/checkmk] 11fafc: Added unit test: write and read host attributes

by Simon

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 11fafc733cb81bff1de6cb58311cef3ccf02a5c3 https://github.com/tribe29/checkmk/commit/11fafc733cb81bff1de6cb58311cef3cc… Author: Andreas Boesl <andreas.boesl(a)tribe29.com> Date: 2019-11-04 (Mon, 04 Nov 2019) Changed paths: M tests/testlib/utils.py M tests/unit/cmk/gui/conftest.py M tests/unit/cmk/gui/watolib/test_hosts_and_folders.py Log Message: ----------- Added unit test: write and read host attributes Change-Id: I7df76819db7f7f3bac8d99e92a1f9d8f167f32a3 Commit: 71c9209b0a6a6737dcbce3ac1120d5be204598f5 https://github.com/tribe29/checkmk/commit/71c9209b0a6a6737dcbce3ac1120d5be2… Author: Simon Jess <simon.jess(a)tribe29.com> Date: 2019-11-04 (Mon, 04 Nov 2019) Changed paths: A .werks/10360 M cmk/special_agents/agent_aws.py M cmk/special_agents/utils.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_cloudwatch.py A tests/unit/cmk/special_agents/agent_aws/test_agent_aws_config.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_costs_and_usage.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_ebs.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_ec2.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_elb.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_elbv2.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_glacier.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_rds.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_s3.py Log Message: ----------- agent_aws: Collect live data if config has changed Change-Id: Ia840cb9376173dc4a395e0a1353e04e98c244801 Compare: https://github.com/tribe29/checkmk/compare/dd035ae8a94c...71c9209b0a6a

4 years, 7 months

[tribe29/checkmk] 7c1342: Faster IP lookup cache writing

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 7c13428c61704cf4eca4c956ec482a1af4b92824 https://github.com/tribe29/checkmk/commit/7c13428c61704cf4eca4c956ec482a1af… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-04 (Mon, 04 Nov 2019) Changed paths: M cmk_base/ip_lookup.py Log Message: ----------- Faster IP lookup cache writing Storing the file in pretty printed mode takes a lot more time when working with larger cache files. We should really think about changing the default to pretty=False. Change-Id: Ic8a63a2259927f2231888aaf9051d65f2478f9b9 Commit: ee5b44d02075159840cf73db52b7c754d6ac5d06 https://github.com/tribe29/checkmk/commit/ee5b44d02075159840cf73db52b7c754d… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-04 (Mon, 04 Nov 2019) Changed paths: M cmk_base/ip_lookup.py M tests/unit/cmk_base/test_ip_lookup.py Log Message: ----------- Some more IP cache cleanups * Better name for cache object factory * Extract cache clearing logic * Minor fix: Also clean up the in-memory cache * Add test for clearing logic * Extract host/family enumeration * Add test for host/family enumeration Change-Id: I02232a0467d20d65dc9db1ddca334775a26a0522 Commit: e2259508bb71cfb1391b2509f0dd781fc1bd6cea https://github.com/tribe29/checkmk/commit/e2259508bb71cfb1391b2509f0dd781fc… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-04 (Mon, 04 Nov 2019) Changed paths: M cmk_base/ip_lookup.py Log Message: ----------- Simplify host / family lookup computation Change-Id: I86debb91216d97f466a5cd165cc99e80c3f8e240 Commit: b4928b21b7508bd2139e9052228bd6ac496adbd7 https://github.com/tribe29/checkmk/commit/b4928b21b7508bd2139e9052228bd6ac4… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-04 (Mon, 04 Nov 2019) Changed paths: M cmk_base/caching.py M cmk_base/ip_lookup.py M tests/unit/cmk_base/test_ip_lookup.py M tests/unit/conftest.py Log Message: ----------- Improve "Update DNS cache" performance * The IPLookupCache is now managed by a special form of the DictCache which also cares about writing the persisted cache. This is not ideal, but seemed to be the least invasive way. * The cache updates the DNS cache for each individual lookup by default as it did it before. * But this object can now be set to "do not persist" mode to just capture the updates in memory during subsequent lookups like it's done in ip_lookup.update_dns_cache(). * After the lookups are done, the save() method can be called once to perform a single bulk operation The operation is now a 100 times faster (tested with ~2000 hosts and a fast responding DNS server. Made some cleanups on the way and added several tests for the affected functions. Change-Id: Ib927cff7556ae07348e457973a1e0c6fa355a2ef Commit: de7e062cc2f4602e84deecfda39a75ab572b01d3 https://github.com/tribe29/checkmk/commit/de7e062cc2f4602e84deecfda39a75ab5… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-04 (Mon, 04 Nov 2019) Changed paths: A .werks/10378 Log Message: ----------- 10378 FIX Improve "Update DNS cache" / cmk --update-dns-cache performance The operation was performing a lot of needless operations. The update of several thousands of hosts DNS entries took way too long. The exact time needed depends mostly on the number of hosts, cache size, DNS lookup performance and so on. But even with good responding servers the operation took too long, because the cache was updated in a very inefficient way when calling the "Update DNS cache" action in WATO or "cmk --update-dns-cache" from the command line. The operation is now more than a 100 times faster (tested with ~2000 hosts and a fast responding DNS server). Change-Id: Ie9a2cb589c7861934311043d1e8161a6de4d519e Commit: dd035ae8a94c33648581da3c2a7bf8ef8b981d88 https://github.com/tribe29/checkmk/commit/dd035ae8a94c33648581da3c2a7bf8ef8… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-04 (Mon, 04 Nov 2019) Changed paths: M cmk/utils/store.py M tests/unit/cmk/utils/test_store.py Log Message: ----------- save_data_to_file: Only pretty print when enabled The pretty formatting costs a lot of time, especially with larger data structures. Most of the treated files are rarely evaluated manually, so the formatting is unnecessary overhead and should only be activated on demand. Change-Id: I5d8cc55f2a3cec45f6450c900a5e4ebccfd11fed Compare: https://github.com/tribe29/checkmk/compare/2e55fa67c4d3...dd035ae8a94c

4 years, 7 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits November 2019