Checkmk git commits July 2018

checkmk-commits@lists.checkmk.com

10 participants
467 discussions

Fixed and enabled bad-classmethod-argument warnings.

by Sven Panne

Module: check_mk Branch: master Commit: 82b7d735d26033688756047ffd301164ebcf9676 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=82b7d735d26033… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Wed Jul 4 14:50:09 2018 +0200 Fixed and enabled bad-classmethod-argument warnings. Change-Id: I32c8638fe33bbbc9193a831896e84d924d025965 --- bin/mkbench | 2 +- omd/packages/omd/omd | 10 ++++------ tests/pylint/pylintrc | 1 - web/htdocs/backup.py | 2 +- web/htdocs/metrics.py | 2 +- web/htdocs/userdb.py | 8 ++++---- web/htdocs/watolib.py | 6 +++--- web/plugins/userdb/htpasswd.py | 6 +++--- web/plugins/userdb/ldap.py | 20 ++++++++++---------- 9 files changed, 27 insertions(+), 30 deletions(-) diff --git a/bin/mkbench b/bin/mkbench index 1ddf82a..3e3463a 100755 --- a/bin/mkbench +++ b/bin/mkbench @@ -990,7 +990,7 @@ DiskIO = namedtuple("DiskIO", ["read_bytes", "write_bytes"]) class Measurement(object): @classmethod - def summary(self, measurements): + def summary(cls, measurements): average_keys = [ "cpu_load", "disk_io", diff --git a/omd/packages/omd/omd b/omd/packages/omd/omd index d5ea454..e98b329 100644 --- a/omd/packages/omd/omd +++ b/omd/packages/omd/omd @@ -3950,18 +3950,16 @@ class PackageManager(object): __metaclass__ = abc.ABCMeta @classmethod - def factory(self): + def factory(cls): if os.path.exists("/etc/cma"): - return + return None distro_code = g_info["DISTRO_CODE"] if distro_code.startswith("el") \ or distro_code.startswith("sles"): - cls = PackageManagerRPM + return PackageManagerRPM() else: - cls = PackageManagerDEB - - return cls() + return PackageManagerDEB() @abc.abstractmethod diff --git a/tests/pylint/pylintrc b/tests/pylint/pylintrc index 348ab9d..2157d64 100644 --- a/tests/pylint/pylintrc +++ b/tests/pylint/pylintrc @@ -15,7 +15,6 @@ disable= abstract-method, arguments-differ, attribute-defined-outside-init, - bad-classmethod-argument, bad-continuation, bad-indentation, bad-whitespace, diff --git a/web/htdocs/backup.py b/web/htdocs/backup.py index f8adad4..2018eef 100644 --- a/web/htdocs/backup.py +++ b/web/htdocs/backup.py @@ -206,7 +206,7 @@ class BackupEntityCollection(object): # Abstract class for backup jobs (Job) and restore job (RestoreJob) class MKBackupJob(object): @classmethod - def state_name(self, state): + def state_name(cls, state): return { "started" : _("Started"), "running" : _("Currently running"), diff --git a/web/htdocs/metrics.py b/web/htdocs/metrics.py index 3eb2c43..bda797a 100644 --- a/web/htdocs/metrics.py +++ b/web/htdocs/metrics.py @@ -283,7 +283,7 @@ class GraphDestinations(object): notification = "notification" @classmethod - def choices(self): + def choices(cls): return [ (GraphDestinations.dashlet, _("Dashlet")), (GraphDestinations.view, _("View")), diff --git a/web/htdocs/userdb.py b/web/htdocs/userdb.py index a22ed97..8d4346f 100644 --- a/web/htdocs/userdb.py +++ b/web/htdocs/userdb.py @@ -1121,17 +1121,17 @@ class UserConnector(object): self._config = config @classmethod - def type(self): + def type(cls): return None # The string representing this connector to humans @classmethod - def title(self): + def title(cls): return None @classmethod - def short_title(self): + def short_title(cls): return _('htpasswd') # @@ -1139,7 +1139,7 @@ class UserConnector(object): # @classmethod - def migrate_config(self): + def migrate_config(cls): pass # Optional: Hook function can be registered here to be executed diff --git a/web/htdocs/watolib.py b/web/htdocs/watolib.py index a629ef9..22e7ad6 100644 --- a/web/htdocs/watolib.py +++ b/web/htdocs/watolib.py @@ -315,7 +315,7 @@ class ConfigDomain(object): @classmethod - def enabled(self): + def enabled(cls): return True @@ -438,7 +438,7 @@ class ConfigDomainEventConsole(ConfigDomain): @classmethod - def enabled(self): + def enabled(cls): return config.mkeventd_enabled @@ -9651,7 +9651,7 @@ class ACTestCategories(object): @classmethod - def title(self, ident): + def title(cls, ident): return { "usability" : _("Usability"), "performance" : _("Performance"), diff --git a/web/plugins/userdb/htpasswd.py b/web/plugins/userdb/htpasswd.py index 71ebfea..ab2f0e4 100644 --- a/web/plugins/userdb/htpasswd.py +++ b/web/plugins/userdb/htpasswd.py @@ -40,17 +40,17 @@ class HtpasswdUserConnector(UserConnector): @classmethod - def type(self): + def type(cls): return 'htpasswd' @classmethod - def title(self): + def title(cls): return _('Apache Local Password File (htpasswd)') @classmethod - def short_title(self): + def short_title(cls): return _('htpasswd') diff --git a/web/plugins/userdb/ldap.py b/web/plugins/userdb/ldap.py index cb03e87..f063f50 100644 --- a/web/plugins/userdb/ldap.py +++ b/web/plugins/userdb/ldap.py @@ -185,23 +185,23 @@ class LDAPUserConnector(UserConnector): @classmethod - def type(self): + def type(cls): return 'ldap' @classmethod - def title(self): + def title(cls): return _('LDAP (Active Directory, OpenLDAP)') @classmethod - def short_title(self): + def short_title(cls): return _('LDAP') @classmethod - def get_connection_suffixes(self): - return self.connection_suffixes + def get_connection_suffixes(cls): + return cls.connection_suffixes def id(self): @@ -865,17 +865,17 @@ class LDAPUserConnector(UserConnector): # This function migrates the former configuration to the new one. # TODO This code can be removed the day we decide not to migrate old configs anymore. @classmethod - def migrate_config(self): + def migrate_config(cls): if config.user_connections: return # Don't try to migrate anything when there is at least one connection configured - if self.needs_config_migration(): - self.do_migrate_config() + if cls.needs_config_migration(): + cls.do_migrate_config() # Don't migrate anything when no ldap connection has been configured @classmethod - def needs_config_migration(self): + def needs_config_migration(cls): ldap_connection = getattr(config, 'ldap_connection', {}) default_ldap_connection_config = { 'type' : 'ad', @@ -885,7 +885,7 @@ class LDAPUserConnector(UserConnector): @classmethod - def do_migrate_config(self): + def do_migrate_config(cls): # Create a default connection out of the old config format connection = { 'id' : 'default',

6 years, 2 months

Simplification: No need to redefine defaults.

by Sven Panne

Module: check_mk Branch: master Commit: 9eee0248dd3735039ceea0a5c91d78b09dd23cbe URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=9eee0248dd3735… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Wed Jul 4 13:38:24 2018 +0200 Simplification: No need to redefine defaults. Change-Id: Id97e75d76fb27766a6a9dd3f1a799a8ae2caa8d8 --- tests/pylint/pylintrc | 8 -------- 1 file changed, 8 deletions(-) diff --git a/tests/pylint/pylintrc b/tests/pylint/pylintrc index 0e5e51f..348ab9d 100644 --- a/tests/pylint/pylintrc +++ b/tests/pylint/pylintrc @@ -111,15 +111,7 @@ msg-template={path}:{line}: [{msg_id}({symbol}), {obj}] {msg} [FORMAT] max-line-length=100 -single-line-if-stmt=no -indent-string=' ' [VARIABLES] -# Ignore these unused variables (e.g. _no_item,_no_params) -dummy-variables-rgx=^_.* # Needed by web code because of super globals. TODO Clean this up some day additional-builtins=html,_,_u,current_language,HTML - -[MISCELLANEOUS] -# List of note tags to take in consideration, separated by a comma. -notes=FIXME,TODO

6 years, 2 months

Fixed and enabled keyword-arg-before-vararg warnings.

by Sven Panne

Module: check_mk Branch: master Commit: eca1b2156ebd9b021d9808e85e8723e57c9faeeb URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=eca1b2156ebd9b… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Wed Jul 4 11:02:51 2018 +0200 Fixed and enabled keyword-arg-before-vararg warnings. Note that there was actually no way to pass "enabled" as a keyword argument and pass extra positional arguments as well. So Profile.__init__'s signature didn't make sense, but the fix was easy: Just remove positional arguments. The same holds for ImageUpload.__init__. CMKWebLogger.exception is a different story: Its signature differs from the one of the superclass method, which is ugly and a design no-no. Rather than fixing all the call sites, we introduce some local Kung Fu... Change-Id: Ic9a09d40491ef224073056ca8192d2c10cdb8669 --- cmk/profile.py | 5 ++--- tests/pylint/pylintrc | 1 - web/htdocs/log.py | 14 +++++++++++--- web/htdocs/valuespec.py | 4 ++-- 4 files changed, 15 insertions(+), 9 deletions(-) diff --git a/cmk/profile.py b/cmk/profile.py index 39e9918..062a03b 100644 --- a/cmk/profile.py +++ b/cmk/profile.py @@ -36,10 +36,9 @@ import cmk.log class Profile(object): - def __init__(self, enabled=True, profile_file=None, *args, **kwargs): + def __init__(self, enabled=True, profile_file=None, **kwargs): self._enabled = enabled self._profile_file = profile_file - self._args = args self._kwargs = kwargs self._profile = None @@ -47,7 +46,7 @@ class Profile(object): def __enter__(self): if self._enabled: cmk.log.logger.info("Recording profile") - self._profile = cProfile.Profile(*self._args, **self._kwargs) + self._profile = cProfile.Profile(**self._kwargs) self._profile.enable() return self diff --git a/tests/pylint/pylintrc b/tests/pylint/pylintrc index 7359868..0e5e51f 100644 --- a/tests/pylint/pylintrc +++ b/tests/pylint/pylintrc @@ -39,7 +39,6 @@ disable= global-variable-undefined, inconsistent-return-statements, invalid-name, - keyword-arg-before-vararg, len-as-condition, line-too-long, logging-not-lazy, diff --git a/web/htdocs/log.py b/web/htdocs/log.py index 18a5ac9..ce21647 100644 --- a/web/htdocs/log.py +++ b/web/htdocs/log.py @@ -31,13 +31,21 @@ import cmk.log import cmk.paths class CMKWebLogger(_logging.getLoggerClass()): - def exception(self, msg=None, *args, **kwargs): + def exception(self, *args, **kwargs): """Logs an optional message together with the traceback of the last exception to the current logger (-> web.log)""" - if msg is None: + # FIXME: Ugly Kung Fu to make the msg positional argument optional. This + # is a consequence of the cruel hack to change exceptions's signature, + # something which we shouldn't do: Either fix all the call sites or + # introduce another method. + if args: + msg = args[0] + args = args[1:] + else: msg = _('Internal error') + msg = kwargs.pop('msg', msg) - super(CMKWebLogger, self).exception("%s %s" % (html.request_uri(), msg)) + super(CMKWebLogger, self).exception("%s %s" % (html.request_uri(), msg), *args, **kwargs) _logging.setLoggerClass(CMKWebLogger) diff --git a/web/htdocs/valuespec.py b/web/htdocs/valuespec.py index c24d6e3..715320f 100644 --- a/web/htdocs/valuespec.py +++ b/web/htdocs/valuespec.py @@ -4026,10 +4026,10 @@ class FileUpload(ValueSpec): class ImageUpload(FileUpload): - def __init__(self, max_size=None, show_current_image=False, *args, **kwargs): + def __init__(self, max_size=None, show_current_image=False, **kwargs): self._max_size = max_size self._show_current_image = show_current_image - FileUpload.__init__(self, *args, **kwargs) + FileUpload.__init__(self, **kwargs) def render_input(self, varprefix, value):

6 years, 2 months

Fixed and enabled anomalous-unicode-escape-in-string warnings.

by Sven Panne

Module: check_mk Branch: master Commit: dfa82bf2361bce571364b22b24f4ea0455262bc7 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=dfa82bf2361bce… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Wed Jul 4 10:14:04 2018 +0200 Fixed and enabled anomalous-unicode-escape-in-string warnings. Change-Id: Ide21bfcb022755e5ba9fa2790d8660ef42165b23 --- tests/pylint/pylintrc | 1 - web/plugins/wato/check_parameters.py | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/pylint/pylintrc b/tests/pylint/pylintrc index f011c03..7359868 100644 --- a/tests/pylint/pylintrc +++ b/tests/pylint/pylintrc @@ -13,7 +13,6 @@ persistent=yes [MESSAGES CONTROL] disable= abstract-method, - anomalous-unicode-escape-in-string, arguments-differ, attribute-defined-outside-init, bad-classmethod-argument, diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py index 743b41f..a470c6c 100644 --- a/web/plugins/wato/check_parameters.py +++ b/web/plugins/wato/check_parameters.py @@ -1494,7 +1494,7 @@ register_rule(group + '/' + subgroup_inventory, 'name will be hardcoded into the check. In that case if you put %u into the service description, that will be replaced ' 'by the actual user name during inventory. You need that if your rule might match for more than one user - your would ' 'create duplicate services with the same description otherwise.</p><p>Windows users are specified by the namespace followed by ' - 'the actual user name. For example "\\\\NT AUTHORITY\NETWORK SERVICE" or "\\\\CHKMKTEST\\Administrator".</p>'), + 'the actual user name. For example "\\\\NT AUTHORITY\\NETWORK SERVICE" or "\\\\CHKMKTEST\\Administrator".</p>'), )), ('icon', UserIconOrAction( title = _("Add custom icon or action"),

6 years, 2 months

Fixed and enabled anomalous-backslash-in-string warnings.

by Sven Panne

Module: check_mk Branch: master Commit: 0265d8ec41707e9abd3eb266865129662875995f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=0265d8ec41707e… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Wed Jul 4 09:30:49 2018 +0200 Fixed and enabled anomalous-backslash-in-string warnings. Change-Id: I1a08a576fb37c43ff290003c2c702344b6d2a09c --- tests/pylint/pylintrc | 1 - web/htdocs/htmllib.py | 8 ++++++-- web/htdocs/views.py | 2 +- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/tests/pylint/pylintrc b/tests/pylint/pylintrc index 41f0516..f011c03 100644 --- a/tests/pylint/pylintrc +++ b/tests/pylint/pylintrc @@ -14,7 +14,6 @@ persistent=yes disable= abstract-method, anomalous-unicode-escape-in-string, - anomalous-backslash-in-string, arguments-differ, attribute-defined-outside-init, bad-classmethod-argument, diff --git a/web/htdocs/htmllib.py b/web/htdocs/htmllib.py index b1e595c..f6d7430 100644 --- a/web/htdocs/htmllib.py +++ b/web/htdocs/htmllib.py @@ -1183,8 +1183,12 @@ class RequestHandler(object): self.listvars = {} # for variables with more than one occurrance self.uploads = {} - # TODO: Fix this regex. +-\ selects all from + to \, not +, - and \! - varname_regex = re.compile('^[\w\d_.%+-\\\*]+$') + # TODO: Previously the regex below matched any alphanumeric character plus any character + # from set(r'%*+,-./:;<=>?@[\_'), but this was very probably unintended. Now we only allow + # alphanumeric characters plus any character from set('%*+-._'), which is probably still a + # bit too broad. We should really figure out what we need and make sure that we only use + # that restricted set. + varname_regex = re.compile(r'^[\w.%*+-]+$') for field in fields.list: varname = field.name diff --git a/web/htdocs/views.py b/web/htdocs/views.py index 58eb554..bc4dfe8 100644 --- a/web/htdocs/views.py +++ b/web/htdocs/views.py @@ -3227,7 +3227,7 @@ def format_plugin_output(output, row = None): if shall_escape: # (?:<A HREF="), (?: target="_blank">)? and endswith(" </A>") is a special # handling for the HTML code produced by check_http when "clickable URL" option is active. - output = re.sub("(?:<A HREF=")?(http[s]?://[^\"'>\t\s\n,]+)(?: target="_blank">)?", + output = re.sub("(?:<A HREF=")?(http[s]?://[^\"'>\\s,]+)(?: target="_blank">)?", lambda p: '<a href="%s"><img class=pluginurl align=absmiddle title="%s" src="images/pluginurl.png"></a>' % (p.group(1).replace('"', ''), p.group(1).replace('"', '')), output)

6 years, 2 months

Added some TODOs

by Simon Betz

Module: check_mk Branch: master Commit: ce9634b7d03f87d538b1e48f4a1ca853bc7095ab URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ce9634b7d03f87… Author: Simon Betz <si(a)mathias-kettner.de> Date: Wed Jul 4 09:14:13 2018 +0200 Added some TODOs Change-Id: I88f6817b053c564633a39a00f5fd7ac86e034048 --- checks/aix_diskiod | 19 +++++++++++++++++++ checks/diskstat.include | 4 ++-- checks/hpux_lunstats | 19 +++++++++++++++++++ 3 files changed, 40 insertions(+), 2 deletions(-) diff --git a/checks/aix_diskiod b/checks/aix_diskiod index d43af17..78e21c0 100644 --- a/checks/aix_diskiod +++ b/checks/aix_diskiod @@ -45,6 +45,25 @@ # 6. Kb_wrtn -> Kilobytes written since system boot def aix_diskiod_convert(info): + #TODO use 'check_diskstat_dict' which needs the following format + # disks = { "sda" : { + # 'node' : None, + # 'average_read_request_size' : 0.0, + # 'average_read_wait' : 0.0, + # 'average_request_size' : 40569.90476190476, + # 'average_wait' : 0.761904761904762, + # 'average_write_request_size' : 40569.90476190476, + # 'average_write_wait' : 0.0007619047619047619, + # 'read_ios' : 0.0, + # 'read_throughput' : 0.0, + # 'latency' : 0.00038095238095238096, + # 'utilization' : 0.0006153846153846154, + # 'write_ios' : 1.6153846153846154, + # 'write_throughput' : 65536.0, + # 'queue_length' : 0.0, + # 'read_ql' : 0.0, + # 'write_ql' : 0.0, + # }} converted = [] for node_info, device, tm_act, kbps, tps, kb_read, kb_written in info: converted.append((node_info, device, int(kb_read) * 1024, int(kb_written) * 1024)) diff --git a/checks/diskstat.include b/checks/diskstat.include index 53c9aa8..779f245 100644 --- a/checks/diskstat.include +++ b/checks/diskstat.include @@ -221,7 +221,7 @@ def check_diskstat_line(this_time, item, params, line, mode='sectors'): def check_diskstat_generic(item, params, this_time, info, mode='sectors'): # legacy version if item is "read" or "write" if item in [ 'read', 'write' ]: - return check_diskstat_old(item, params, this_time, info) + return _check_diskstat_old(item, params, this_time, info) # Sum up either all physical disks (if item is "SUMMARY") or # all entries matching the item in question. It is not a bug if @@ -251,7 +251,7 @@ def check_diskstat_generic(item, params, this_time, info, mode='sectors'): # This is the legacy version of diskstat as used in <= 1.1.10. # We keep it here for a while in order to be compatible with # old installations. -def check_diskstat_old(item, params, this_time, info): +def _check_diskstat_old(item, params, this_time, info): # sum up over all devices if item == 'read': index = 2 # sectors read diff --git a/checks/hpux_lunstats b/checks/hpux_lunstats index 36b4c4c..a76addc 100644 --- a/checks/hpux_lunstats +++ b/checks/hpux_lunstats @@ -51,6 +51,25 @@ check_includes['hpux_lunstats'] = [ "diskstat.include" ] # Convert info to output needed for generic diskstat check def hpux_lunstats_convert(info): + #TODO use 'check_diskstat_dict' which needs the following format + # disks = { "sda" : { + # 'node' : None, + # 'average_read_request_size' : 0.0, + # 'average_read_wait' : 0.0, + # 'average_request_size' : 40569.90476190476, + # 'average_wait' : 0.761904761904762, + # 'average_write_request_size' : 40569.90476190476, + # 'average_write_wait' : 0.0007619047619047619, + # 'read_ios' : 0.0, + # 'read_throughput' : 0.0, + # 'latency' : 0.00038095238095238096, + # 'utilization' : 0.0006153846153846154, + # 'write_ios' : 1.6153846153846154, + # 'write_throughput' : 65536.0, + # 'queue_length' : 0.0, + # 'read_ql' : 0.0, + # 'write_ql' : 0.0, + # }} luns = [] for line in info: if len(line) == 2:

6 years, 2 months

Fixed all straightforward anomalous-backslash-in-string warnings.

by Sven Panne

Module: check_mk Branch: master Commit: d6f94be81564897ce748735b86c800367326513a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d6f94be8156489… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Tue Jul 3 15:18:17 2018 +0200 Fixed all straightforward anomalous-backslash-in-string warnings. The more tricky ones will come later, they might actually contain bugs. Note: With Python 3.6 these constructs already produce deprecation warnings, and they are expected to turn into full syntax errors sooner or later. Change-Id: I9fde90fd06eb0a691a4cf50c619234bf465cc916 --- active_checks/check_mail_loop | 2 +- active_checks/check_sql | 2 +- agents/plugins/isc_dhcpd | 2 +- agents/plugins/mtr | 2 +- agents/special/agent_allnet_ip_sensoric | 2 +- agents/special/agent_ibmsvc | 2 +- bin/mkbackup | 2 +- checks/allnet_ip_sensoric | 2 +- checks/bintec_brrp_status | 2 +- checks/check_sql | 2 +- checks/cpu_util.include | 2 +- checks/dell_chassis_powersupplies | 4 ++-- checks/f5_bigip_pool | 2 +- checks/fileinfo | 2 +- checks/fortigate_signatures | 2 +- checks/juniper_bgp_state | 2 +- checks/netscaler_health | 2 +- checks/omd_apache | 28 ++++++++++++++-------------- checks/rstcli | 2 +- checks/wmi.include | 2 +- cmk_base/localize.py | 22 +++++++++++----------- cmk_base/notify.py | 2 +- inventory/win_exefiles | 6 +++--- inventory/win_reg_uninstall | 2 +- notifications/asciimail | 2 +- notifications/mail | 2 +- notifications/pushover | 2 +- omd/packages/omd/omd | 2 +- tests/pylint/pylintrc | 2 +- web/htdocs/guitester.py | 2 +- web/htdocs/main.py | 2 +- web/htdocs/metrics.py | 4 ++-- web/htdocs/utils.py | 2 +- web/htdocs/valuespec.py | 8 ++++---- web/htdocs/wato.py | 2 +- web/htdocs/watolib.py | 2 +- web/htdocs/werks.py | 2 +- web/plugins/sidebar/shipped.py | 2 +- web/plugins/views/inventory.py | 2 +- web/plugins/wato/check_parameters.py | 6 +++--- web/plugins/wato/mkeventd.py | 4 ++-- 41 files changed, 74 insertions(+), 74 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=d6f94be815…

6 years, 2 months

6324 FIX Notifications: Fixed height of graph area with a larger legend

by Lars Michelsen

Module: check_mk Branch: master Commit: f4edc31d22403a75701c9f845b03bfa186b8a520 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f4edc31d22403a… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 3 20:15:14 2018 +0200 6324 FIX Notifications: Fixed height of graph area with a larger legend Graphs with a lot of metrics need more space for their legend. This larger legend did not increase the size of the graph images. They reduced the size of the graph are and finally destroyed the graph layout. The image height is now increased with a larger number of metrics. Change-Id: I44b06be464283e7a25a2c48ff2eac6a5e04764d5 --- .werks/6324 | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/.werks/6324 b/.werks/6324 new file mode 100644 index 0000000..3342827 --- /dev/null +++ b/.werks/6324 @@ -0,0 +1,15 @@ +Title: Notifications: Fixed height of graph area with a larger legend +Level: 1 +Component: metrics +Class: fix +Compatible: compat +Edition: cee +State: unknown +Version: 1.6.0i1 +Date: 1530641604 + +Graphs with a lot of metrics need more space for their legend. This larger +legend did not increase the size of the graph images. They reduced the size +of the graph are and finally destroyed the graph layout. + +The image height is now increased with a larger number of metrics.

6 years, 2 months

6323 FIX Fixed graph PNG export of other than first graphs

by Lars Michelsen

Module: check_mk Branch: master Commit: deaaa414e909904163d1a834793c8aecd6c2b172 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=deaaa414e90990… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 3 20:03:35 2018 +0200 6323 FIX Fixed graph PNG export of other than first graphs When using the PNG export of a graph (e.g. from the context menu of a graph), only the export of the first graph of a host/service was working. Other graphs produced an error message. Change-Id: I46a8af9401c2f49f7f9e32f09ceaf8e9b0c99614 --- .werks/6323 | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.werks/6323 b/.werks/6323 new file mode 100644 index 0000000..4eb7fec --- /dev/null +++ b/.werks/6323 @@ -0,0 +1,13 @@ +Title: Fixed graph PNG export of other than first graphs +Level: 1 +Component: metrics +Class: fix +Compatible: compat +Edition: cee +State: unknown +Version: 1.6.0i1 +Date: 1530640853 + +When using the PNG export of a graph (e.g. from the context menu of a graph), +only the export of the first graph of a host/service was working. Other graphs +produced an error message.

6 years, 2 months

Updated werk

by Simon Betz

Module: check_mk Branch: master Commit: 63eb0f66ebf6ab72597ea1d1654eb8dfa7ba44bd URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=63eb0f66ebf6ab… Author: Simon Betz <si(a)mathias-kettner.de> Date: Tue Jul 3 17:13:31 2018 +0200 Updated werk Change-Id: Ib2fcc771c7a4e02cf161407ff1047470a427e631 --- .werks/6299 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.werks/6299 b/.werks/6299 index 6f7622e..38f877a 100644 --- a/.werks/6299 +++ b/.werks/6299 @@ -1,4 +1,4 @@ -Title: mk_logwatch: If no MK_CONFDIR/logwatch.cfg exists all configuration files below MK_CONFDIR/logwatch.d were ignored. Fixed that! +Title: mk_logwatch: logwatch.d files were only loaded if logwatch.cfg was in place Level: 1 Component: checks Compatible: compat @@ -7,4 +7,4 @@ Version: 1.6.0i1 Date: 1530535554 Class: fix - +If no MK_CONFDIR/logwatch.cfg exists all configuration files below MK_CONFDIR/logwatch.d were ignored.

6 years, 2 months

← Newer
1
...
39
40
41
42
43
44
45
46
47
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits July 2018