Checkmk git commits July 2018

checkmk-commits@lists.checkmk.com

10 participants
467 discussions

Simplified inheritance hierarchy. Improved comments.

by Sven Panne

Module: check_mk Branch: master Commit: 34ffec1e5ed766c818b5192cf4861858e6ce39a4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=34ffec1e5ed766… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Tue Jul 17 13:29:55 2018 +0200 Simplified inheritance hierarchy. Improved comments. Change-Id: Ia96cee0cffe864ae145f3ac61f1c893793aab87d --- cmk/gui/gui_background_job.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/cmk/gui/gui_background_job.py b/cmk/gui/gui_background_job.py index 0069151..0d5e435 100644 --- a/cmk/gui/gui_background_job.py +++ b/cmk/gui/gui_background_job.py @@ -169,10 +169,7 @@ class GUIBackgroundJobSnapshottedFunctions(background_job.BackgroundJob): return super(GUIBackgroundJobSnapshottedFunctions, self).get_title() -# TODO: The superclasses are nonsense: GUIBackgroundJobSnapshottedFunctions -# already derives from background_jobs.BackgroundJob. What is the right way to -# fix this? -class GUIBackgroundJob(GUIBackgroundJobSnapshottedFunctions, background_job.BackgroundJob): +class GUIBackgroundJob(GUIBackgroundJobSnapshottedFunctions): _background_process_class = GUIBackgroundProcess def __init__(self, job_id, **kwargs): @@ -213,10 +210,13 @@ class GUIBackgroundJob(GUIBackgroundJobSnapshottedFunctions, background_job.Back -# Provides the frozen state of a background job -# Quite helpful when generating GUI pages with several phases - -# TODO: What on earth is this class supposed to do? +# GUI pages are built in several phases, and each face can take a non-trivial +# amount of time. Nevertheless, it is crucial to render a consistent state of +# the background job in question. The class below provides such a status +# snapshot for the job given to the constructor. +# +# TODO: BackgroundJob should provide an explicit status object, which we can use +# here without any metaprogramming Kung Fu and arcane inheritance hierarchies. class GUIBackgroundStatusSnapshot(object): def __init__(self, background_job): super(GUIBackgroundStatusSnapshot, self).__init__()

6 years, 2 months

Enabled c-extension-no-member warnings.

by Sven Panne

Module: check_mk Branch: master Commit: 19d88857f12b20c60a9b66aa68f46dda0f287032 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=19d88857f12b20… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Tue Jul 17 13:37:23 2018 +0200 Enabled c-extension-no-member warnings. Change-Id: Ib8b2e81ab324c766f016897d60e83913f0923340 --- tests/pylint/pylintrc | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/pylint/pylintrc b/tests/pylint/pylintrc index 03bd819..a3c9ef7 100644 --- a/tests/pylint/pylintrc +++ b/tests/pylint/pylintrc @@ -19,7 +19,6 @@ disable= bad-whitespace, bare-except, broad-except, - c-extension-no-member, cell-var-from-loop, consider-iterating-dictionary, consider-using-enumerate,

6 years, 2 months

livestatus_status: Avoid changing imput parameters

by Moritz Kiemer

Module: check_mk Branch: master Commit: ab0789b4b2e2e92accef170404b4eb3e45a6d44b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ab0789b4b2e2e9… Author: Moritz Kiemer <mo(a)mathias-kettner.de> Date: Mon Jul 16 14:49:56 2018 +0200 livestatus_status: Avoid changing imput parameters Change-Id: Icfe044725ef60a1d0fde68054045a7d8d5910734 --- checks/livestatus_status | 26 +++++++++++++++----------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/checks/livestatus_status b/checks/livestatus_status index 6d7d6a3..40d028c 100644 --- a/checks/livestatus_status +++ b/checks/livestatus_status @@ -120,16 +120,6 @@ def check_livestatus_status(item, params, parsed): yield 0, "Core version: %s" % status["program_version"] yield 0, "Livestatus version: %s" % status["livestatus_version"] - if status["program_version"].startswith("Check_MK 1.2.6"): - # In CMC <= 1.2.6 event handlers cannot be enabled. So never warn. - params["enable_event_handlers"] = 0 - elif status.get("has_event_handlers", '1') == '0': - # After update from < 1.2.7 the check would warn about disabled alert - # handlers since they are disabled in this case. But the user has no alert - # handlers defined, so this is nothing to warn about. Start warn when the - # user defines his first alert handlers. - params["enable_event_handlers"] = 0 - settings = [ ("execute_host_checks", "Active host checks are disabled"), ("execute_service_checks", "Active service checks are disabled"), @@ -137,7 +127,7 @@ def check_livestatus_status(item, params, parsed): ("accept_passive_service_checks", "Passive service checks are disabled"), ("check_host_freshness", "Host freshness checking is disabled"), ("check_service_freshness", "Service freshness checking is disabled"), - ("enable_event_handlers", "Alert handlers are disabled"), + # ("enable_event_handlers", "Alert handlers are disabled"), # special case below ("enable_flap_detection", "Flap detection is disabled"), ("enable_notifications", "Notifications are disabled"), ("process_performance_data", "Performance data is disabled"), @@ -148,6 +138,20 @@ def check_livestatus_status(item, params, parsed): if status[settingname] != '1' and params[settingname] != 0: yield params[settingname], title + # special considerations for enable_event_handlers + if status["program_version"].startswith("Check_MK 1.2.6"): + # In CMC <= 1.2.6 event handlers cannot be enabled. So never warn. + return + if status.get("has_event_handlers", '1') == '0': + # After update from < 1.2.7 the check would warn about disabled alert + # handlers since they are disabled in this case. But the user has no alert + # handlers defined, so this is nothing to warn about. Start warn when the + # user defines his first alert handlers. + return + else: + if status["enable_event_handlers"] != '1' and params["enable_event_handlers"] != 0: + yield params["enable_event_handlers"], "Alert handlers are disabled" + check_info['livestatus_status'] = { "parse_function" : parse_livestatus_status,

6 years, 2 months

heartbeat_crm: don't change info variable

by Moritz Kiemer

Module: check_mk Branch: master Commit: c81970b7dbe6c76cbb4e755dbae1bffe0442e7c0 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c81970b7dbe6c7… Author: Moritz Kiemer <mo(a)mathias-kettner.de> Date: Wed Jul 11 14:29:27 2018 +0200 heartbeat_crm: don't change info variable Change-Id: Ib852ef607f05e9c096cb52d7c66ff49a238408b2 --- checks/heartbeat_crm | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/checks/heartbeat_crm b/checks/heartbeat_crm index 552c83c..abcdacd 100644 --- a/checks/heartbeat_crm +++ b/checks/heartbeat_crm @@ -237,23 +237,23 @@ def heartbeat_crm_parse_resources(info): resources[parts[2]] = [] resource = parts[2] mode = 'masterslaveset' - elif line[0] == '_': - # Cleanup inconsistent agent output in clone set lines + elif line.startswith('_'): + # consider inconsistent agent output in clone set lines + fixed_parts = parts[1:] if parts[0] != "_": - parts.insert(1, parts[0][1:]) - parts[0] = "_" + fixed_parts.insert(0, parts[0].lstrip('_')) # Resource group or set member if mode == 'resourcegroup': - resources[resource].append(parts[1:]) + resources[resource].append(fixed_parts) elif mode == 'cloneset': - if parts[1] == 'Started:': - resources[resource].append([ resource, 'Clone', 'Started', parts[3:-1] ]) + if fixed_parts[0] == 'Started:': + resources[resource].append([ resource, 'Clone', 'Started', fixed_parts[2:-1] ]) elif mode == 'masterslaveset': - if parts[1] == 'Masters:': - resources[resource].append([ resource, 'Master', 'Started', parts[3] ]) - if parts[1] == 'Slaves:': - resources[resource].append([ resource, 'Slave', 'Started', parts[3] ]) + if fixed_parts[0] == 'Masters:': + resources[resource].append([ resource, 'Master', 'Started', fixed_parts[2] ]) + if fixed_parts[0] == 'Slaves:': + resources[resource].append([ resource, 'Slave', 'Started', fixed_parts[2] ]) else: # Single resource resources[parts[0]] = [ parts ]

6 years, 2 months

Fix pylint warning for werk 6121

by Tom Baerwinkel

Module: check_mk Branch: master Commit: 5dd0a69c94de7813723c86bd3486ab4cd88e0d6e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5dd0a69c94de78… Author: Tom Baerwinkel <tb(a)mathias-kettner.de> Date: Tue Jul 17 17:13:03 2018 +0200 Fix pylint warning for werk 6121 Change-Id: I628e5d9d1885b7913eae76a74719387039ed29cd --- checks/security_master | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/checks/security_master b/checks/security_master index f9a4bdf..d96ca34 100644 --- a/checks/security_master +++ b/checks/security_master @@ -87,7 +87,7 @@ def parse_security_master(info): parsed[value] = {} for oid, sensor in info[0]: - if not ".5.0" in str(oid): + if ".5.0" not in str(oid): continue sensor_num = saveint(oid.split(".")[0])

6 years, 2 months

6121 security_master, security_master.humidity, security_master.temp: new checks to monitor sensors of security master devices

by Tom Baerwinkel

Module: check_mk Branch: master Commit: 659ce182d5b5af22b53558a948a5528f893aa7c3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=659ce182d5b5af… Author: Tom Baerwinkel <tb(a)mathias-kettner.de> Date: Tue Jul 17 13:54:10 2018 +0200 6121 security_master, security_master.humidity, security_master.temp: new checks to monitor sensors of security master devices Change-Id: I19189a53fcd9b88990c7f119755cc8236664ee4d --- .werks/6121 | 10 ++ checkman/security_master | 14 +++ checkman/security_master.humidity | 16 +++ checkman/security_master.temp | 16 +++ checks/security_master | 245 ++++++++++++++++++++++++++++++++++++++ cmk/man_pages.py | 1 + 6 files changed, 302 insertions(+) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=659ce182d5…

6 years, 2 months

6311 FIX diskstat: Ignore partitions which do not provide all necessary information

by Simon Betz

Module: check_mk Branch: master Commit: aaa8d18b0bbf0975c440315194ef5423dc8c3eb6 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=aaa8d18b0bbf09… Author: Simon Betz <si(a)mathias-kettner.de> Date: Mon Jul 16 15:14:21 2018 +0200 6311 FIX diskstat: Ignore partitions which do not provide all necessary information Change-Id: Ifc6adf02e8a63eefbe0836f607206ff7bb671288 --- .werks/6311 | 10 ++++++++++ checks/diskstat | 14 +++++++------- 2 files changed, 17 insertions(+), 7 deletions(-) diff --git a/.werks/6311 b/.werks/6311 new file mode 100644 index 0000000..4b440d1 --- /dev/null +++ b/.werks/6311 @@ -0,0 +1,10 @@ +Title: diskstat: Ignore partitions which do not provide all necessary information +Level: 1 +Component: checks +Compatible: compat +Edition: cre +Version: 1.6.0i1 +Date: 1531746694 +Class: fix + + diff --git a/checks/diskstat b/checks/diskstat index 95c70a6..8edb824 100644 --- a/checks/diskstat +++ b/checks/diskstat @@ -113,16 +113,16 @@ def parse_diskstat(info): real_partitions = {device_name for device_name in device_names if diskstat_diskless_pattern.match(device_name) and re.sub('[0-9]+$', '', device_name)} - disks = {} - for node_name, major, minor, device, \ - read_ios, read_merges, read_sectors, read_ticks, \ - write_ios, write_merges, write_sectors, write_ticks, \ - ios_in_prog, total_ticks, rq_ticks in proc_diskstat: - - if device in real_partitions: + for line in proc_diskstat: + if line[3] in real_partitions: continue + node_name, major, minor, device, \ + read_ios, read_merges, read_sectors, read_ticks, \ + write_ios, write_merges, write_sectors, write_ticks, \ + ios_in_prog, total_ticks, rq_ticks = line + if (node_name, int(major), int(minor)) in name_info: device = name_info[(node_name, int(major), int(minor))]

6 years, 2 months

6312 FIX filesystem: Fixed blemish in discovery dialog: Invalid check parameter: Undefined key 'patterns' in the dictionary

by Simon Betz

Module: check_mk Branch: master Commit: 66796ed2d9cd4af773979e219787964ed9db29a1 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=66796ed2d9cd4a… Author: Simon Betz <si(a)mathias-kettner.de> Date: Tue Jul 17 12:36:23 2018 +0200 6312 FIX filesystem: Fixed blemish in discovery dialog: Invalid check parameter: Undefined key 'patterns' in the dictionary Change-Id: If2f52d4a4ac379c71fb2006c8c8c00c6c5501515 --- .werks/6312 | 10 ++++++++++ cmk/gui/plugins/wato/check_parameters.py | 1 + 2 files changed, 11 insertions(+) diff --git a/.werks/6312 b/.werks/6312 new file mode 100644 index 0000000..ef4b0e6 --- /dev/null +++ b/.werks/6312 @@ -0,0 +1,10 @@ +Title: filesystem: Fixed blemish in discovery dialog: Invalid check parameter: Undefined key 'patterns' in the dictionary +Level: 1 +Component: checks +Compatible: compat +Edition: cre +Version: 1.6.0i1 +Date: 1531823716 +Class: fix + + diff --git a/cmk/gui/plugins/wato/check_parameters.py b/cmk/gui/plugins/wato/check_parameters.py index eedb643..b8d8a9f 100644 --- a/cmk/gui/plugins/wato/check_parameters.py +++ b/cmk/gui/plugins/wato/check_parameters.py @@ -7992,6 +7992,7 @@ register_check_parameters( Dictionary( elements = filesystem_elements, hidden_keys = ["flex_levels"], + ignored_keys = ["patterns"], ), TextAscii( title = _("Mount point"),

6 years, 2 months

Be more robust during parsing

by Simon Betz

Module: check_mk Branch: master Commit: 58a076383db975342c9b89d8ec8d5899ebef662e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=58a076383db975… Author: Simon Betz <si(a)mathias-kettner.de> Date: Tue Jul 17 13:06:31 2018 +0200 Be more robust during parsing Change-Id: I12b47a6801c90d8239f6be85d9ad5b3c3771c032 --- checks/f5_bigip_vserver | 40 +++++++++++++++++++++++----------------- 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/checks/f5_bigip_vserver b/checks/f5_bigip_vserver index fa5e31b..8c711aa 100644 --- a/checks/f5_bigip_vserver +++ b/checks/f5_bigip_vserver @@ -37,23 +37,29 @@ def parse_f5_bigip_vserver(info): vservers = {} for line in info: - name = line[0] - vservers.setdefault(name, {}) - vservers[name].setdefault("status" , []).append(int(line[1])) - vservers[name].setdefault("enabled" , []).append(int(line[2])) - vservers[name].setdefault("detail" , []).append(line[3]) - vservers[name].setdefault("ip" , []).append(ip_from_string(line[4])) - vservers[name].setdefault("connections_duration_min" , []).append(int(line[5])) - vservers[name].setdefault("connections_duration_max" , []).append(int(line[6])) - vservers[name].setdefault("connections_duration_mean", []).append(int(line[7])) - vservers[name].setdefault("if_in_pkts" , []).append(int(line[8])) - vservers[name].setdefault("if_out_pkts" , []).append(int(line[9])) - vservers[name].setdefault("if_in_octets" , []).append(int(line[10])) - vservers[name].setdefault("if_out_octets" , []).append(int(line[11])) - vservers[name].setdefault("connections_rate" , []).append(int(line[12])) - vservers[name].setdefault("connections" , []).append(int(line[13])) - vservers[name].setdefault("packet_velocity_asic" , []).append(int(line[14])) - + instance = vservers.setdefault(line[0], { + "ip" : ip_from_string(line[4]), + "detail": line[3], + }) + for key, index in [ + ("status", 1), + ("enabled", 2), + ("connections_duration_min", 5), + ("connections_duration_max", 6), + ("connections_duration_mean", 7), + ("if_in_pkts", 8), + ("if_out_pkts", 9), + ("if_in_octets", 10), + ("if_out_octets", 11), + ("connections_rate", 12), + ("connections", 13), + ("packet_velocity_asic", 14), + ]: + try: + value = int(line[index]) + except (IndexError, ValueError): + continue + instance.setdefault(key, []).append(value) return vservers

6 years, 2 months

Fixed and enabled unnecessary-semicolon warnings.

by Sven Panne

Module: check_mk Branch: master Commit: 5c569716aefd2c246c1c8eda8eaed0dda8e01e8d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5c569716aefd2c… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Tue Jul 17 10:46:41 2018 +0200 Fixed and enabled unnecessary-semicolon warnings. Change-Id: Ic42485ceb4594a87c0ca44028575ac34b91aa9d9 --- checks/winperf | 2 +- cmk/ec/main.py | 2 +- cmk/gui/plugins/sidebar/speedometer.py | 2 +- cmk/gui/plugins/views/perfometers/check_mk.py | 14 +++++++------- cmk/gui/plugins/views/webservice.py | 4 ++-- cmk/gui/prediction.py | 2 +- cmk/gui/views.py | 2 +- cmk/gui/wato/__init__.py | 2 +- cmk_base/core_nagios.py | 2 +- tests/pylint/pylintrc | 1 - 10 files changed, 16 insertions(+), 17 deletions(-) diff --git a/checks/winperf b/checks/winperf index 33403f2..a6357bc 100644 --- a/checks/winperf +++ b/checks/winperf @@ -56,7 +56,7 @@ def check_win_cpuusage(item, params, info): for cpu in range(0, num_cpus): ticks = int(line[2 + cpu]) ticks_per_sec = get_rate("cpuusage.%d" % cpu, this_time, ticks) - secs_per_sec = ticks_per_sec / 10000000.0; + secs_per_sec = ticks_per_sec / 10000000.0 used_perc = 100 * (1 - secs_per_sec) overall_perc += used_perc diff --git a/cmk/ec/main.py b/cmk/ec/main.py index 78b50cc..a69e16a 100644 --- a/cmk/ec/main.py +++ b/cmk/ec/main.py @@ -546,7 +546,7 @@ class HostConfig(object): def lerp(a, b, t): """Linear interpolation between a and b with weight t""" - return (1 - t) * a + t * b; + return (1 - t) * a + t * b class Perfcounters(object): diff --git a/cmk/gui/plugins/sidebar/speedometer.py b/cmk/gui/plugins/sidebar/speedometer.py index aba3d7e..d7846fe 100644 --- a/cmk/gui/plugins/sidebar/speedometer.py +++ b/cmk/gui/plugins/sidebar/speedometer.py @@ -226,7 +226,7 @@ canvas#speedometer { "GET services\n" "Stats: suminv check_interval\n")[0] / 60.0 - percentage = 100.0 * current_rate / scheduled_rate; + percentage = 100.0 * current_rate / scheduled_rate title = _("Scheduled service check rate: %.1f/s, current rate: %.1f/s, that is " "%.0f%% of the scheduled rate") % \ (scheduled_rate, current_rate, percentage) diff --git a/cmk/gui/plugins/views/perfometers/check_mk.py b/cmk/gui/plugins/views/perfometers/check_mk.py index b56f2f2..f90d2fc 100644 --- a/cmk/gui/plugins/views/perfometers/check_mk.py +++ b/cmk/gui/plugins/views/perfometers/check_mk.py @@ -463,7 +463,7 @@ def perfometer_check_oracle_dataguard_stats(row, check_command, perf_data): days = 0 hours = 0 minutes = 0 - color = "#008f48"; + color = "#008f48" return "%02dd %02dh %02dm" % (days, hours, minutes), perfometer_logarithmic(perfdata1, 2592000, 2, color) @@ -471,13 +471,13 @@ perfometers["check_mk-oracle_dataguard_stats"] = perfometer_check_oracle_da def perfometer_oracle_sessions(row, check_command, perf_data): if check_command != "check_mk-oracle_sessions": - color = "#008f48"; - unit = ""; + color = "#008f48" + unit = "" else: - color = "#4800ff"; - unit = "/h"; - value = int(perf_data[0][1]); - return "%d%s" % (value, unit), perfometer_logarithmic(value, 50, 2, color); + color = "#4800ff" + unit = "/h" + value = int(perf_data[0][1]) + return "%d%s" % (value, unit), perfometer_logarithmic(value, 50, 2, color) perfometers["check_mk-oracle_sessions"] = perfometer_oracle_sessions perfometers["check_mk-oracle_logswitches"] = perfometer_oracle_sessions diff --git a/cmk/gui/plugins/views/webservice.py b/cmk/gui/plugins/views/webservice.py index 12130f0..95a472b 100644 --- a/cmk/gui/plugins/views/webservice.py +++ b/cmk/gui/plugins/views/webservice.py @@ -120,9 +120,9 @@ multisite_layouts["json"] = { } def render_jsonp(rows, view, group_cells, cells, num_columns, show_checkboxes): - html.write("%s(\n" % html.var('jsonp', 'myfunction')); + html.write("%s(\n" % html.var('jsonp', 'myfunction')) render_json(rows, view, group_cells, cells, num_columns, show_checkboxes) - html.write_text(");\n"); + html.write_text(");\n") multisite_layouts["jsonp"] = { "title" : _("JSONP data output"), diff --git a/cmk/gui/prediction.py b/cmk/gui/prediction.py index 7e0d20d..e4ac5a6 100644 --- a/cmk/gui/prediction.py +++ b/cmk/gui/prediction.py @@ -137,7 +137,7 @@ def page_graph(): vscala_high = vertical_range[1] vert_scala = compute_vertical_scala(vscala_low, vscala_high) time_scala = [ [timegroup["range"][0] + i*3600, "%02d:00" % i] for i in range(0, 25, 2) ] - render_coordinates(vert_scala, time_scala); + render_coordinates(vert_scala, time_scala) if "levels_lower" in timegroup: render_dual_area(swapped["average"], swapped["lower_warn"], "#ffffff", 0.5) diff --git a/cmk/gui/views.py b/cmk/gui/views.py index d2d4edf..faf359f 100644 --- a/cmk/gui/views.py +++ b/cmk/gui/views.py @@ -2129,7 +2129,7 @@ def do_reschedule(): # a few ms later. We introduce a small wait time in order # to increase the chance for the passive services already # updated also when we return. - time.sleep(0.7); + time.sleep(0.7) html.write("['OK', %d, %d, %r]\n" % (row[0], row[1], row[2].encode("utf-8"))) except Exception, e: diff --git a/cmk/gui/wato/__init__.py b/cmk/gui/wato/__init__.py index c8f051e..f2cb0bb 100644 --- a/cmk/gui/wato/__init__.py +++ b/cmk/gui/wato/__init__.py @@ -6224,7 +6224,7 @@ def interactive_progress(items, title, stats, finishvars, timewait, fail_stats = [] if not termvars: - termvars = finishvars; + termvars = finishvars html.open_center() html.open_table(class_="progress") diff --git a/cmk_base/core_nagios.py b/cmk_base/core_nagios.py index 6850f89..6a45bee 100644 --- a/cmk_base/core_nagios.py +++ b/cmk_base/core_nagios.py @@ -793,7 +793,7 @@ def _create_nagios_config_contacts(outfile, hostnames): " host_notification_commands\tcheck-mk-notify\n" " service_notification_commands\tcheck-mk-notify\n" " contactgroups\t\t\tcheck-mk-notify\n" - "}\n\n"); + "}\n\n") # Quote string for use in a nagios command execution. diff --git a/tests/pylint/pylintrc b/tests/pylint/pylintrc index 497e046..86f4bd0 100644 --- a/tests/pylint/pylintrc +++ b/tests/pylint/pylintrc @@ -62,7 +62,6 @@ disable= too-many-statements, ungrouped-imports, unidiomatic-typecheck, - unnecessary-semicolon, unneeded-not, unsubscriptable-object, unsupported-membership-test,

6 years, 2 months

← Newer
1
...
18
19
20
21
22
23
24
...
47
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits July 2018