Checkmk git commits March 2018

checkmk-commits@lists.checkmk.com

10 participants
326 discussions

Win-agent: sort eventlogs case insensitive

by Jukka Aro

Module: check_mk Branch: master Commit: c51e0e29f6058e38b5f523bce326c0ecd72f5d51 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c51e0e29f6058e… Author: Jukka Aro <ja(a)mathias-kettner.de> Date: Thu Mar 8 09:51:08 2018 +0100 Win-agent: sort eventlogs case insensitive --- agents/windows/build_version | 2 +- agents/windows/sections/SectionEventlog.cc | 8 +++--- agents/windows/stringutil.cc | 13 ++++++++++ agents/windows/stringutil.h | 5 +++- agents/windows/test/stringutilTest.cc | 40 ++++++++++++++++++++++++++---- 5 files changed, 58 insertions(+), 10 deletions(-) diff --git a/agents/windows/build_version b/agents/windows/build_version index ac68758..a4c2c8d 100644 --- a/agents/windows/build_version +++ b/agents/windows/build_version @@ -1 +1 @@ -3162 +3164 diff --git a/agents/windows/sections/SectionEventlog.cc b/agents/windows/sections/SectionEventlog.cc index e96613e..c1f88c5 100644 --- a/agents/windows/sections/SectionEventlog.cc +++ b/agents/windows/sections/SectionEventlog.cc @@ -102,9 +102,11 @@ eventlog::States loadEventlogOffsets(const std::vector<std::string> &statefiles, } } - std::sort( - states.begin(), states.end(), - [](const auto &s1, const auto &s2) { return s1.name < s2.name; }); + std::sort(states.begin(), states.end(), + [](const auto &s1, const auto &s2) { + return ci_compare(s1.name, s2.name); + }); + if (!states.empty()) { return states; } diff --git a/agents/windows/stringutil.cc b/agents/windows/stringutil.cc index 096178e..534a97d 100644 --- a/agents/windows/stringutil.cc +++ b/agents/windows/stringutil.cc @@ -71,6 +71,19 @@ bool ci_equal(const std::string &lhs, const std::string &rhs) { ci_compare_pred); } +bool ci_compare(const std::string &lhs, const std::string &rhs) { + for (auto ri = lhs.cbegin(), li = rhs.cbegin(); + ri != lhs.cend() && li != rhs.cend(); ++ri, ++li) { + auto l1 = std::tolower(*ri), l2 = std::tolower(*li); + if (l1 != l2) { + return l1 < l2; + } + } + + // If equal until here, lhs < rhs iff lhs shorter than rhs. + return lhs.size() < rhs.size(); +} + // clang-format off template <> char sol<char>() { return '^'; } template <> wchar_t sol<wchar_t>() { return L'^'; } diff --git a/agents/windows/stringutil.h b/agents/windows/stringutil.h index 2286262..011f21e 100644 --- a/agents/windows/stringutil.h +++ b/agents/windows/stringutil.h @@ -135,9 +135,12 @@ inline std::ostream &operator<<(std::ostream &os, const Utf8 &u) { return os << to_utf8(u._value); } -// case insensitive compare +// case insensitive equality check bool ci_equal(const std::string &lhs, const std::string &rhs); +// case insensitive compare function (e. g. for std::sort) +bool ci_compare(const std::string &lhs, const std::string &rhs); + // clang-format off // Start-of-line char: '^' or L'^' template <class CharT> inline CharT sol(); diff --git a/agents/windows/test/stringutilTest.cc b/agents/windows/test/stringutilTest.cc index 240c78c..80b0db7 100644 --- a/agents/windows/test/stringutilTest.cc +++ b/agents/windows/test/stringutilTest.cc @@ -193,31 +193,61 @@ TEST(wa_stringutilTest, isPathRelative_relative_with_whitespace_quotes_unix) { TEST(wa_stringutilTest, ci_equal__equal_cases_equal) { const std::string s1{"asdfgh"}; const std::string s2{s1}; - ASSERT_TRUE(ci_equal(s1, s2)); + ASSERT_TRUE(ci_equal(s1, s2)) << "Expected " << s1 << " == " << s2; } TEST(wa_stringutilTest, ci_equal__equal_cases_unequal) { const std::string s1{"asdfgh§$"}; const std::string s2{"aSdFgH§$"}; - ASSERT_TRUE(ci_equal(s1, s2)); + ASSERT_TRUE(ci_equal(s1, s2)) << "Expected " << s1 << " == " << s2; } TEST(wa_stringutilTest, ci_equal__unequal_first_shorter) { const std::string s1{"asdfgh"}; const std::string s2{"aSdFgH§$"}; - ASSERT_FALSE(ci_equal(s1, s2)); + ASSERT_FALSE(ci_equal(s1, s2)) << "Expected " << s1 << " != " << s2; } TEST(wa_stringutilTest, ci_equal__unequal_first_longer) { const std::string s1{"asdfgh§$"}; const std::string s2{"aSdFgH"}; - ASSERT_FALSE(ci_equal(s1, s2)); + ASSERT_FALSE(ci_equal(s1, s2)) << "Expected " << s1 << " != " << s2; } TEST(wa_stringutilTest, ci_equal__unequal) { const std::string s1{"asdfg$"}; const std::string s2{"aSdFgH"}; - ASSERT_FALSE(ci_equal(s1, s2)); + ASSERT_FALSE(ci_equal(s1, s2)) << "Expected " << s1 << " != " << s2; +} + +TEST(wa_stringutilTest, ci_compare__equal) { + const std::string s1{"asdfgh"}; + const std::string s2{"aSdFgH"}; + ASSERT_FALSE(ci_compare(s1, s2)) << "Expected " << s1 << " == " << s2; +} + +TEST(wa_stringutilTest, ci_compare__true) { + const std::string s1{"asdfgg"}; + const std::string s2{"aSdFgH"}; + ASSERT_TRUE(ci_compare(s1, s2)) << "Expected " << s1 << " < " << s2; +} + +TEST(wa_stringutilTest, ci_compare__false) { + const std::string s1{"asdfgH"}; + const std::string s2{"aSdFgg"}; + ASSERT_FALSE(ci_compare(s1, s2)) << "Expected " << s1 << " > " << s2; +} + +TEST(wa_stringutilTest, ci_compare__first_shorter) { + const std::string s1{"asdfg"}; + const std::string s2{"aSdFgg"}; + ASSERT_TRUE(ci_compare(s1, s2)) << "Expected " << s1 << " < " << s2; +} + +TEST(wa_stringutilTest, ci_compare__second_shorter) { + const std::string s1{"aSdfgh"}; + const std::string s2{"asdFg"}; + ASSERT_FALSE(ci_compare(s1, s2)) << "Expected " << s1 << " > " << s2; } // Tests for char version of globmatch:

6 years, 4 months

test_automation_set_autochecks: Cleanup created file after test

by Lars Michelsen

Module: check_mk Branch: master Commit: 533703264e3ee9e47f0812fd3e71d6c7c16612e0 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=533703264e3ee9… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Mar 7 18:43:48 2018 +0100 test_automation_set_autochecks: Cleanup created file after test Change-Id: I38269f4155ee7cccc85050608fa0fee6fd769b2a --- tests/cmk_base/test_automations.py | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/tests/cmk_base/test_automations.py b/tests/cmk_base/test_automations.py index cc3b6f8..2c196b5 100644 --- a/tests/cmk_base/test_automations.py +++ b/tests/cmk_base/test_automations.py @@ -283,17 +283,23 @@ def test_automation_set_autochecks(test_cfg, site): ("uptime", None) : None, } - data = _execute_automation(site, "set-autochecks", - args=["blablahost"], stdin=repr(new_items)) - assert data == None + try: + data = _execute_automation(site, "set-autochecks", + args=["blablahost"], stdin=repr(new_items)) + assert data == None - data = _execute_automation(site, "get-autochecks", - args=["blablahost"]) + data = _execute_automation(site, "get-autochecks", + args=["blablahost"]) - assert sorted(data) == sorted([ - ('df', u'xxx', 'bla', "'bla'"), - ('uptime', None, None, 'None') - ]) + assert sorted(data) == sorted([ + ('df', u'xxx', 'bla', "'bla'"), + ('uptime', None, None, 'None') + ]) + + assert site.file_exists("var/check_mk/autochecks/blablahost.mk") + finally: + if site.file_exists("var/check_mk/autochecks/blablahost.mk"): + site.delete_file("var/check_mk/autochecks/blablahost.mk") def test_automation_update_dns_cache(test_cfg, site, web):

6 years, 4 months

5707 Windows: allow eventlog monitoring from multiple hosts

by Jukka Aro

Module: check_mk Branch: master Commit: 39d892821190213c005e3c2ca316fb3557e4f351 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=39d89282119021… Author: Jukka Aro <ja(a)mathias-kettner.de> Date: Fri Mar 2 12:18:02 2018 +0100 5707 Windows: allow eventlog monitoring from multiple hosts Until now, Windows eventlogs could be monitored only from one host (Check_MK site). Attempting to contact one single Windows agent from multiple hosts lead to lost eventlog entries as all hosts shared one common state file for storing the offsets of so far read eventlog entries. Now the offsets are store in host-IP-specific state files, allowing hosts with different IP addresses to monitor one single Windows system without loosing eventlog entries. Note: multiple Check_MK sites running under the one and same IP address will still suffer from lost eventlog entries as the offsets are stored per IP address. --- .werks/5707 | 21 ++++++ agents/windows/Makefile.am | 1 + agents/windows/Section.cc | 11 +-- agents/windows/Section.h | 11 ++- agents/windows/build_version | 2 +- agents/windows/check_mk_agent.cc | 29 ++++---- agents/windows/it/remote.py | 4 +- agents/windows/it/test_section_eventlog.py | 79 ++++++++++++--------- agents/windows/sections/SectionCheckMK.cc | 2 +- agents/windows/sections/SectionCheckMK.h | 2 +- agents/windows/sections/SectionDF.cc | 2 +- agents/windows/sections/SectionDF.h | 2 +- agents/windows/sections/SectionEventlog.cc | 80 ++++++++++++++++------ agents/windows/sections/SectionEventlog.h | 6 +- agents/windows/sections/SectionFileinfo.cc | 2 +- agents/windows/sections/SectionFileinfo.h | 2 +- agents/windows/sections/SectionGroup.cc | 6 +- agents/windows/sections/SectionGroup.h | 2 +- agents/windows/sections/SectionLogwatch.cc | 2 +- agents/windows/sections/SectionLogwatch.h | 2 +- agents/windows/sections/SectionMRPE.cc | 2 +- agents/windows/sections/SectionMRPE.h | 2 +- agents/windows/sections/SectionMem.cc | 2 +- agents/windows/sections/SectionMem.h | 2 +- agents/windows/sections/SectionOHM.cc | 4 +- agents/windows/sections/SectionOHM.h | 2 +- agents/windows/sections/SectionPS.cc | 2 +- agents/windows/sections/SectionPS.h | 2 +- agents/windows/sections/SectionPerfcounter.cc | 2 +- agents/windows/sections/SectionPerfcounter.h | 2 +- agents/windows/sections/SectionPluginGroup.cc | 2 +- agents/windows/sections/SectionPluginGroup.h | 2 +- agents/windows/sections/SectionServices.cc | 2 +- agents/windows/sections/SectionServices.h | 2 +- agents/windows/sections/SectionSkype.cc | 4 +- agents/windows/sections/SectionSkype.h | 2 +- agents/windows/sections/SectionSpool.cc | 2 +- agents/windows/sections/SectionSpool.h | 2 +- agents/windows/sections/SectionSystemtime.cc | 2 +- agents/windows/sections/SectionSystemtime.h | 2 +- agents/windows/sections/SectionUptime.cc | 2 +- agents/windows/sections/SectionUptime.h | 2 +- agents/windows/sections/SectionWMI.cc | 2 +- agents/windows/sections/SectionWMI.h | 2 +- agents/windows/sections/SectionWinperf.cc | 2 +- agents/windows/sections/SectionWinperf.h | 2 +- agents/windows/test/MockEnvironment.cc | 6 ++ agents/windows/test/MockEnvironment.h | 34 +++++++++ .../windows/test/sections/SectionEventlogTest.cc | 69 ++++++++++++++++--- 49 files changed, 304 insertions(+), 129 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=39d8928211…

6 years, 4 months

5771 FIX Created wrong SNMP cache folder 'var/check_mk/HOST'

by Simon Betz

Module: check_mk Branch: master Commit: 895c494946e17437ef9d4d9452f7df57c570538f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=895c494946e174… Author: Simon Betz <si(a)mathias-kettner.de> Date: Wed Mar 7 13:32:02 2018 +0100 5771 FIX Created wrong SNMP cache folder 'var/check_mk/HOST' The right folder for SNMP cache data is 'var/check_mk/snmp_cache/HOST'. Fixed that! Change-Id: If6cfcf141dad177726a6c90246418bcc9575ef96 --- .werks/5771 | 11 +++++++++++ cmk_base/snmp.py | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.werks/5771 b/.werks/5771 new file mode 100644 index 0000000..b3d014c --- /dev/null +++ b/.werks/5771 @@ -0,0 +1,11 @@ +Title: Created wrong SNMP cache folder 'var/check_mk/HOST' +Level: 1 +Component: inv +Compatible: compat +Edition: cre +Version: 1.5.0i4 +Date: 1520425659 +Class: fix + +The right folder for SNMP cache data is 'var/check_mk/snmp_cache/HOST'. +This was introduced with Check_MK version 1.5.0i2. Fixed that! diff --git a/cmk_base/snmp.py b/cmk_base/snmp.py index 5969d77..e8cab12 100644 --- a/cmk_base/snmp.py +++ b/cmk_base/snmp.py @@ -595,7 +595,7 @@ def _save_snmpwalk_cache(hostname, fetchoid, rowinfo): def _snmpwalk_cache_path(hostname, fetchoid): - return os.path.join(cmk.paths.var_dir, hostname, fetchoid) + return os.path.join(cmk.paths.var_dir, "snmp_cache", hostname, fetchoid) def _get_stored_snmpwalk(hostname, oid):

6 years, 4 months

Win-agent: prevent race condition of parallel builds

by Jukka Aro

Module: check_mk Branch: master Commit: 487b62dafaa6258f9daae3d2300ca39e742e75a8 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=487b62dafaa625… Author: Jukka Aro <ja(a)mathias-kettner.de> Date: Wed Mar 7 15:00:16 2018 +0100 Win-agent: prevent race condition of parallel builds 32 and 64 bit builds access the file build_version in parallel, resulting in a race condition where build_version may get corrupted and break the build target check_mk_agent.res. --- agents/windows/Makefile.am | 23 ++++++++++++++--------- agents/windows/build_version | 2 +- 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/agents/windows/Makefile.am b/agents/windows/Makefile.am index 8b28bb3..23058fd 100644 --- a/agents/windows/Makefile.am +++ b/agents/windows/Makefile.am @@ -20,18 +20,23 @@ pytest = /usr/bin/env pytest pytest_options = --maxfail=10 pytest_jenkins = $(pytest_options) --junitxml=$(bindir)/junit.xml +# Prevent race condition between parallel 32 and 64 bit builds by protecting +# access to build_version through a lock file. build_version: $(check_mk_agent_SOURCES:.cc=.o) - echo "BUILD VERSION ls 1: $$(ls -al $(VPATH))" - echo "BUILD VERSION 1: $$(cat $(VPATH)/build_version)" - echo $$(( $$(cat $(VPATH)/build_version) + 1 )) > $(VPATH)/build_version - echo "BUILD VERSION 2: $$(cat $(VPATH)/build_version)" - echo "BUILD VERSION ls 2: $$(ls -al $(VPATH))" + ( \ + flock -e 200 ; \ + echo $$(( $$(cat $(VPATH)/build_version) + 1 )) > $(VPATH)/build_version \ + ) 200>/var/lock/build_version.lock +# Prevent race condition between parallel 32 and 64 bit builds by protecting +# access to build_version through a lock file. check_mk_agent.rc: $(VPATH)/check_mk_agent.rc.in build_version - echo "BUILD VERSION 3: $$(cat $(VPATH)/build_version)" - sed -e "s/%VERSION%/$(VERSION)/g" \ - -e "s/%YEAR%/$$(date +%Y)/g" \ - -e "s/%BUILD_VERSION%/$$(cat $(VPATH)/build_version)/g" $< > $@ + ( \ + flock -e 200 ; \ + sed -e "s/%VERSION%/$(VERSION)/g" \ + -e "s/%YEAR%/$$(date +%Y)/g" \ + -e "s/%BUILD_VERSION%/$$(cat $(VPATH)/build_version)/g" $< > $@ \ + ) 200>/var/lock/build_version.lock check_mk_agent.res: check_mk_agent.rc $(VPATH)/check_mk_agent.ico cp $(VPATH)/check_mk_agent.ico check_mk_agent.ico diff --git a/agents/windows/build_version b/agents/windows/build_version index 79b5ee9..7800e88 100644 --- a/agents/windows/build_version +++ b/agents/windows/build_version @@ -1 +1 @@ -3158 +3160

6 years, 4 months

Win-agent: use std::regex_match for globmatch

by Jukka Aro

Module: check_mk Branch: master Commit: feed0db30dd55a5e53be8266a013d5e2e9e66662 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=feed0db30dd55a… Author: Jukka Aro <ja(a)mathias-kettner.de> Date: Wed Mar 7 13:54:52 2018 +0100 Win-agent: use std::regex_match for globmatch * Convert glob wildcards '?' and '*' to their regex counterparts '.' and '.*'. * Escape regex special characters present in glob pattern. * Use std::regex_match. * Note: glob character classes [...] are not supported (this was the case also before. --- agents/windows/Configuration.cc | 7 +- agents/windows/build_version | 2 +- agents/windows/sections/SectionFileinfo.cc | 2 +- agents/windows/sections/SectionLogwatch.cc | 5 +- agents/windows/sections/SectionPluginGroup.cc | 8 +- agents/windows/stringutil.cc | 100 +++--------- agents/windows/stringutil.h | 92 ++++++++++- agents/windows/test/stringutilTest.cc | 212 ++++++++++++++++++++++++++ 8 files changed, 334 insertions(+), 94 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=feed0db30d…

6 years, 4 months

5770 FIX HW/SW/-Inventory service: Displayed wrong amount of entries by using wrong data source

by Simon Betz

Module: check_mk Branch: master Commit: 1dc69d1bada573f9e32e1de465ad22a8cf01b6ad URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1dc69d1bada573… Author: Simon Betz <si(a)mathias-kettner.de> Date: Wed Mar 7 13:23:42 2018 +0100 5770 FIX HW/SW/-Inventory service: Displayed wrong amount of entries by using wrong data source Change-Id: I58e6b8945e73f62640ec0419555e5d51db8f07fd --- .werks/5770 | 10 ++++++++++ cmk_base/data_sources/abstract.py | 5 ++++- cmk_base/inventory.py | 1 + 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/.werks/5770 b/.werks/5770 new file mode 100644 index 0000000..4a2630c --- /dev/null +++ b/.werks/5770 @@ -0,0 +1,10 @@ +Title: HW/SW/-Inventory service: Displayed wrong amount of entries by using wrong data source +Level: 1 +Component: inv +Compatible: compat +Edition: cre +Version: 1.5.0i4 +Date: 1520425022 +Class: fix + + diff --git a/cmk_base/data_sources/abstract.py b/cmk_base/data_sources/abstract.py index 605b979..fc1777d 100644 --- a/cmk_base/data_sources/abstract.py +++ b/cmk_base/data_sources/abstract.py @@ -55,7 +55,10 @@ class DataSource(object): # a single DataSources() object during processing first. Then we # can change these class attributes to object attributes. # - # Set by the user via command line to prevent using cached information at all + # Set by the user via command line to prevent using cached information at all. + # Is also set by inventory for SNMP checks to handle the special situation that + # the inventory is not allowed to use the regular checking based SNMP data source + # cache. _no_cache = False # Set by the code in different situations where we recommend, but not enforce, # to use the cache. The user can always use "--cache" to override this. diff --git a/cmk_base/inventory.py b/cmk_base/inventory.py index b3e1e01..70eedf9 100644 --- a/cmk_base/inventory.py +++ b/cmk_base/inventory.py @@ -215,6 +215,7 @@ def _do_inv_for_realhost(hostname, ipaddress, inventory_tree, status_data_tree): if isinstance(source, data_sources.SNMPDataSource): source.set_on_error("raise") source.set_do_snmp_scan(True) + source.disable_data_source_cache() source.set_use_snmpwalk_cache(False) source.set_ignore_check_interval(True) source.set_check_plugin_name_filter(_gather_snmp_check_plugin_names_inventory)

6 years, 4 months

5893 FIX Fixed some report table layout problems

by Lars Michelsen

Module: check_mk Branch: master Commit: 977f87362bf9f1e98e3627b24b11a95fa7c4dda9 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=977f87362bf9f1… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Mar 7 11:54:42 2018 +0100 5893 FIX Fixed some report table layout problems The following problems have been fixed: <ul> <li>Single dataset tables: (host/service details) had no top border</li> <li>Single dataset tables: Disable row shading now also works for left headers</li> <li>Graph columns were adding emtpy space after the graph column</li> </ul> Change-Id: Ib382b07d6e14bae7d9fe220d411fbcb6e9369c6c --- .werks/5893 | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/.werks/5893 b/.werks/5893 new file mode 100644 index 0000000..c271aa8 --- /dev/null +++ b/.werks/5893 @@ -0,0 +1,17 @@ +Title: Fixed some report table layout problems +Level: 1 +Component: reporting +Class: fix +Compatible: compat +Edition: cee +State: unknown +Version: 1.5.0i4 +Date: 1520416971 + +The following problems have been fixed: + +<ul> +<li>Single dataset tables: (host/service details) had no top border</li> +<li>Single dataset tables: Disable row shading now also works for left headers</li> +<li>Graph columns were adding emtpy space after the graph column</li> +</ul>

6 years, 4 months

5892 FIX Tables: Fixed backgrounds not filling whole table cells

by Lars Michelsen

Module: check_mk Branch: master Commit: e7c4beb5ba37e523fb4426db2c2610e460153fda URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e7c4beb5ba37e5… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Mar 7 10:49:00 2018 +0100 5892 FIX Tables: Fixed backgrounds not filling whole table cells This also fixes some unintended spacing between cell contents. Change-Id: Ided3da36d6e85b4dbaec60f1ed49b5b00dbff331 --- .werks/5892 | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.werks/5892 b/.werks/5892 new file mode 100644 index 0000000..801bf4f --- /dev/null +++ b/.werks/5892 @@ -0,0 +1,11 @@ +Title: Tables: Fixed backgrounds not filling whole table cells +Level: 1 +Component: reporting +Class: fix +Compatible: compat +Edition: cee +State: unknown +Version: 1.5.0i4 +Date: 1520416084 + +This also fixes some unintended spacing between cell contents.

6 years, 4 months

5891 FIX Fixed column layout of host/service report tables (smaller titles )

by Lars Michelsen

Module: check_mk Branch: master Commit: 8947f63aab734bb811b312534cc38d8d3e0f5b67 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8947f63aab734b… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Mar 7 10:13:29 2018 +0100 5891 FIX Fixed column layout of host/service report tables (smaller titles) The title and content columns of the single host/service reports were using the same width which looked bad, especially for pages that contain graphs. Change-Id: I8aaf450e55a992ea7b0928d4ec1f869ceafaaeee --- .werks/5891 | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.werks/5891 b/.werks/5891 new file mode 100644 index 0000000..b157022 --- /dev/null +++ b/.werks/5891 @@ -0,0 +1,12 @@ +Title: Fixed column layout of host/service report tables (smaller titles) +Level: 1 +Component: reporting +Compatible: compat +Edition: cee +Version: 1.5.0i4 +Date: 1520413929 +Class: fix + +The title and content columns of the single host/service reports were +using the same width which looked bad, especially for pages that contain +graphs.

6 years, 4 months

← Newer
1
...
20
21
22
23
24
25
26
...
33
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits March 2018