Module: check_mk
Branch: master
Commit: 5e98c1a01cfde3bb4c903a3faba7d1546938887c
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5e98c1a01cfde3…
Author: Lars Michelsen <lm(a)mathias-kettner.de>
Date: Wed Nov 7 09:18:33 2018 +0100
6850 FIX Fixed broken ruleset search reset function
The reset functionality of the ruleset search was not working at all. It always
resulted in an exception like: "AttributeError: 'ModeRuleSearch' object has no attribute 'search_options'"
Change-Id: Ifb0fe965bd1003d5a411d77762b79026bcb6b97c
---
.werks/6850 | 12 ++++++++++++
cmk/gui/wato/pages/rulesets.py | 3 ++-
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/.werks/6850 b/.werks/6850
new file mode 100644
index 0000000..a1373f5
--- /dev/null
+++ b/.werks/6850
@@ -0,0 +1,12 @@
+Title: Fixed broken ruleset search reset function
+Level: 1
+Component: wato
+Class: fix
+Compatible: compat
+Edition: cre
+State: unknown
+Version: 1.6.0i1
+Date: 1541518998
+
+The reset functionality of the ruleset search was not working at all. It always
+resulted in an exception like: "AttributeError: 'ModeRuleSearch' object has no attribute 'search_options'"
diff --git a/cmk/gui/wato/pages/rulesets.py b/cmk/gui/wato/pages/rulesets.py
index d4f0336..0ec2143 100644
--- a/cmk/gui/wato/pages/rulesets.py
+++ b/cmk/gui/wato/pages/rulesets.py
@@ -1057,7 +1057,8 @@ class ModeRuleSearch(WatoMode):
def _from_vars(self):
if html.var("_reset_search"):
html.del_all_vars("search_")
- return {}
+ self.search_options = {}
+ return
value = self._valuespec().from_html_vars("search")
self._valuespec().validate_value(value, "search")
Module: check_mk
Branch: master
Commit: ebbd2aa8d86d3c25ce6428561f60a6d1d6e1c2c4
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ebbd2aa8d86d3c…
Author: Andreas Boesl <ab(a)mathias-kettner.de>
Date: Tue Oct 30 15:33:11 2018 +0100
6673 FIX Checks from mkps did not always replace existing checks
Check_MK precompiles check plugins, so that they can be faster reused later on.
The mechanism which detects if a plugin needs to be precompiled again, missed the fact
that files extracted from mkps may have an older timestamp than the precompiled one.
This also applies to old check files which are moved into the local checks dir.
Change-Id: I86cba177aca54f5273201300a3e1e5b21dcc35af
---
.werks/6673 | 14 ++++++++++++++
cmk_base/config.py | 3 ++-
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/.werks/6673 b/.werks/6673
new file mode 100644
index 0000000..74e6358
--- /dev/null
+++ b/.werks/6673
@@ -0,0 +1,14 @@
+Title: Checks from mkps did not always replace existing checks
+Level: 1
+Component: checks
+Compatible: compat
+Edition: cre
+Version: 1.6.0i1
+Date: 1540909691
+Class: fix
+
+Check_MK precompiles check plugins, so that they can be faster reused later on.
+The mechanism which detects if a plugin needs to be precompiled again, missed the fact
+that files extracted from mkps may have an older timestamp than the precompiled one.
+This also applies to old check files which are moved into the local checks dir.
+
diff --git a/cmk_base/config.py b/cmk_base/config.py
index fdb3d88..7f289be 100644
--- a/cmk_base/config.py
+++ b/cmk_base/config.py
@@ -2492,7 +2492,8 @@ def _is_plugin_precompiled(path, precompiled_path):
except struct.error:
return False
- if long(os.stat(path).st_mtime) > origin_file_mtime:
+
+ if long(os.stat(path).st_mtime) != origin_file_mtime:
return False
return True