Checkmk git commits January 2018

checkmk-commits@lists.checkmk.com

10 participants
255 discussions

5449 Credentials of SNMP management boards are now configurable via WATO host rule

by Simon Betz

Module: check_mk Branch: master Commit: 107c316f76368e05ff3c6925d257c2dc43e55eb2 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=107c316f76368e… Author: Simon Betz <si(a)mathias-kettner.de> Date: Thu Nov 30 15:52:57 2017 +0100 5449 Credentials of SNMP management boards are now configurable via WATO host rule Change-Id: I8e214c90385e3804461a5286c347f87abace05a2 --- .werks/5449 | 13 +++++++++ cmk_base/config.py | 47 +++++++++++++++++++++++------- cmk_base/default_config/base.py | 1 + web/plugins/wato/builtin_attributes.py | 16 +++++----- web/plugins/wato/check_mk_configuration.py | 11 +++++++ 5 files changed, 71 insertions(+), 17 deletions(-) diff --git a/.werks/5449 b/.werks/5449 new file mode 100644 index 0000000..313293e --- /dev/null +++ b/.werks/5449 @@ -0,0 +1,13 @@ +Title: Credentials of SNMP management boards are now configurable via WATO host rule +Level: 1 +Component: wato +Compatible: compat +Edition: cre +Version: 1.5.0i2 +Date: 1512053208 +Class: feature + +Previously SNMP management board credentials could only be +stated wihtin the host object itself. Now this can be done +with the host rule {Management board config} below +{Host & Service parameters}, {Access to Agents}, {SNMP}. diff --git a/cmk_base/config.py b/cmk_base/config.py index 8e417d9..7e4138b 100644 --- a/cmk_base/config.py +++ b/cmk_base/config.py @@ -652,25 +652,49 @@ def is_ipv4_host(hostname): # Either explicit IPv4 or implicit (when host is not an IPv6 host) return "ip-v4" in tags_of_host(hostname) or "ip-v6" not in tags_of_host(hostname) - # # Management board # def has_management_board(hostname): - return "management_protocol" in host_attributes.get(hostname, {}) + return _management_board_settings_of(hostname)["protocol"] is not None def management_address(hostname): - if 'management_address' in host_attributes.get(hostname, {}): - return host_attributes[hostname]['management_address'] - else: - return ipaddresses.get(hostname) + return _management_board_settings_of(hostname)["address"] def management_protocol(hostname): - return host_attributes[hostname]['management_protocol'] + return _management_board_settings_of(hostname)["protocol"] + + +def _management_board_settings_of(hostname): + rule_settings = rulesets.host_extra_conf(hostname, management_board_config) + attributes_of_host = host_attributes.get(hostname, {}) + management_board = { + "address": None, + "protocol": None, + "credentials": None, + } + if "management_protocol" not in attributes_of_host and not rule_settings: + return management_board + if rule_settings: + protocol, credentials = rule_settings[0] + management_board["protocol"] = protocol + management_board["credentials"] = credentials + + if attributes_of_host.get("management_address"): + management_board["address"] = attributes_of_host["management_address"] + else: + management_board["address"] = ipaddresses.get(hostname) + + if attributes_of_host.get("management_protocol"): + management_board["protocol"] = attributes_of_host["management_protocol"] + if attributes_of_host.get("management_snmp_community"): + management_board["credentials"] = attributes_of_host["management_snmp_community"] + + return management_board # # Agent communication @@ -731,9 +755,12 @@ def snmp_credentials_of(hostname): # board and the host itself queried through snmp. # The alternative is a lengthy and errorprone refactoring of the whole check- # call hierarchy to get the credentials passed around. - if has_management_board(hostname)\ - and management_protocol(hostname) == "snmp": - return host_attributes.get(hostname, {}).get("management_snmp_community", "public") + management_board = _management_board_settings_of(hostname) + if management_board["protocol"] == "snmp": + if management_board["credentials"]: + return management_board["credentials"] + else: + return "public" try: return explicit_snmp_communities[hostname] diff --git a/cmk_base/default_config/base.py b/cmk_base/default_config/base.py index a4db784..af766b7 100644 --- a/cmk_base/default_config/base.py +++ b/cmk_base/default_config/base.py @@ -75,6 +75,7 @@ record_inline_snmp_stats = False snmp_default_community = 'public' snmp_communities = [] explicit_snmp_communities = {} # override the rule based configuration +management_board_config = [] snmp_timing = [] snmp_character_encodings = [] diff --git a/web/plugins/wato/builtin_attributes.py b/web/plugins/wato/builtin_attributes.py index 93bd567..118e2df 100644 --- a/web/plugins/wato/builtin_attributes.py +++ b/web/plugins/wato/builtin_attributes.py @@ -178,6 +178,7 @@ class SNMPCredentials(Alternative): kwargs["orientation"] = "vertical" Alternative.__init__(self, **kwargs) + declare_host_attribute( ValueSpecAttribute( "snmp_community", @@ -196,6 +197,7 @@ declare_host_attribute( depends_on_tags = ['snmp'], ) + # Attribute for configuring parents class ParentsAttribute(ValueSpecAttribute): def __init__(self): @@ -477,12 +479,6 @@ class ManagementTypeAttribute(Attribute): def from_html_vars(self, varprefix): return html.var(varprefix + "protocol") -declare_host_attribute(ManagementTypeAttribute("management_protocol"), - show_in_table = False, - show_in_folder = False, - topic = _("Management Board") - ) - declare_host_attribute(ValueSpecAttribute("management_address", HostAddress( title = _("Address"), @@ -496,12 +492,18 @@ declare_host_attribute(ValueSpecAttribute("management_address", topic = _("Management Board") ) +declare_host_attribute(ManagementTypeAttribute("management_protocol"), + show_in_table = False, + show_in_folder = False, + topic = _("Management Board") + ) + declare_host_attribute(ValueSpecAttribute("management_snmp_community", SNMPCredentials( default_value = None, )), show_in_table = False, - show_in_folder = False, + show_in_folder = True, topic = _("Management Board") ) diff --git a/web/plugins/wato/check_mk_configuration.py b/web/plugins/wato/check_mk_configuration.py index 551eba5..2c849e2 100644 --- a/web/plugins/wato/check_mk_configuration.py +++ b/web/plugins/wato/check_mk_configuration.py @@ -2328,6 +2328,17 @@ register_rule(group, ) register_rule(group, + "management_board_config", + CascadingDropdown( + title=_("Management board config"), + choices=[ + (None, _("No protocol specified"), FixedValue(None, totext="")), + ("snmp", _("SNMP"), SNMPCredentials()), + ], + ), +) + +register_rule(group, "snmp_character_encodings", DropdownChoice( title = _("Output text encoding settings for SNMP devices"),

6 years, 8 months

updated werk

by Simon Betz

Module: check_mk Branch: master Commit: bd620d190df7acfe05226ff3f862b12afebc12c6 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=bd620d190df7ac… Author: Simon Betz <si(a)mathias-kettner.de> Date: Mon Jan 8 12:40:30 2018 +0100 updated werk Change-Id: I9fe69ae1d7a5311bfaf206aa9fff00fdc71e42c1 --- .werks/5294 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.werks/5294 b/.werks/5294 index 96ee1ba..5f56c2d 100644 --- a/.werks/5294 +++ b/.werks/5294 @@ -3,7 +3,7 @@ Level: 1 Component: checks Compatible: compat Edition: cre -Version: 1.5.0i1 +Version: 1.5.0i3 Date: 1505834039 Class: feature

6 years, 8 months

Windows agent: refactor eventlog state read/write

by Jukka Aro

Module: check_mk Branch: master Commit: def7c89749875f5cee0a0576787634e260875890 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=def7c89749875f… Author: Jukka Aro <ja(a)mathias-kettner.de> Date: Fri Dec 22 16:40:38 2017 +0100 Windows agent: refactor eventlog state read/write * Tokenize statefile lines with std::regex and std::regex_token_iterator. * Handle state parse errors correctly. * Use file streams for statefile I/O instead of file pointers. * Unit test the parsing functionality. Change-Id: Iec5c944e34174f925e3af99846651f3335e0c93f --- agents/windows/Makefile.am | 13 ++++- agents/windows/build_version | 2 +- agents/windows/sections/SectionEventlog.cc | 61 ++++++++++---------- agents/windows/sections/SectionEventlog.h | 3 +- agents/windows/stringutil.h | 11 ++++ .../windows/test/sections/SectionEventlogTest.cc | 65 ++++++++++++++++++++++ agents/windows/test/stringutilTest.cc | 41 ++++++++++++++ agents/windows/types.h | 6 ++ 8 files changed, 170 insertions(+), 32 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=def7c89749…

6 years, 8 months

5482 Add option to specify a timeperiod for notification bulking

by Tom Baerwinkel

Module: check_mk Branch: master Commit: c54c27ad11eb91026bf240926788ce2f993f96e9 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c54c27ad11eb91… Author: Tom Baerwinkel <tb(a)mathias-kettner.de> Date: Tue Dec 12 17:10:44 2017 +0100 5482 Add option to specify a timeperiod for notification bulking The option "Bulking period" can be used in notification rules to specify a time period for which notifications should always be bulked. After the timeperiod has ended the notifications of the bulk will be sent. This option is useful if e.g. after the working hours no notifications should be sent. Change-Id: Ibe4dec64649d2a08f62fa8d7234c02cdd842d8db --- .werks/5482 | 14 ++++ cmk_base/checking.py | 8 +- cmk_base/core.py | 18 ++-- cmk_base/notify.py | 202 +++++++++++++++++++++++++++++++++------------ web/htdocs/valuespec.py | 10 +-- web/htdocs/wato.py | 212 ++++++++++++++++++++++++++---------------------- 6 files changed, 297 insertions(+), 167 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=c54c27ad11…

6 years, 8 months

5552 FIX reporting: Fixed unreasonable high timeout for availability elements

by Marcel Arentz

Module: check_mk Branch: master Commit: 6d21bd4e335b46aa40c04f7654c9396220f1d4b6 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=6d21bd4e335b46… Author: Marcel Arentz <ma(a)mathias-kettner.de> Date: Thu Jan 4 12:43:57 2018 +0100 5552 FIX reporting: Fixed unreasonable high timeout for availability elements The option "Query Time Limit" is not available for the availability element in reports and is instead hardcoded. The value has originally been set to 5*60*3600 (300 hrs) but should have been to 5 minutes. This bug has always been in this element and is fixed as of now. Change-Id: Ib208f6f3d2910cc737497a90844b33781609c2b9 --- .werks/5552 | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.werks/5552 b/.werks/5552 new file mode 100644 index 0000000..4404ccb --- /dev/null +++ b/.werks/5552 @@ -0,0 +1,13 @@ +Title: reporting: Fixed unreasonable high timeout for availability elements +Level: 1 +Component: reporting +Compatible: compat +Edition: cee +Version: 1.5.0i3 +Date: 1515065877 +Class: fix + +The option "Query Time Limit" is not available for the availability element +in reports and is instead hardcoded. The value has originally been set to +5*60*3600 (300 hrs) but should have been to 5 minutes. This bug has always +been in this element and is fixed as of now.

6 years, 8 months

5594 FIX Custom graphs: Fixed rendering titles of "sidebar hidden" custom graphs on graph list page

by Lars Michelsen

Module: check_mk Branch: master Commit: 5d09c16ecb33f0a9d439115317a0fd28b2fcf1d0 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5d09c16ecb33f0… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jan 8 11:25:36 2018 +0100 5594 FIX Custom graphs: Fixed rendering titles of "sidebar hidden" custom graphs on graph list page The title of the custom graphs was not shown on the graph list page for graphs that are configured to be hidden from the sidebar. Change-Id: Icdbef0adb66d5c775f6460fac406311b234ca175 --- .werks/5594 | 12 ++++++++++++ web/htdocs/pagetypes.py | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/.werks/5594 b/.werks/5594 new file mode 100644 index 0000000..cd5a1ca --- /dev/null +++ b/.werks/5594 @@ -0,0 +1,12 @@ +Title: Custom graphs: Fixed rendering titles of "sidebar hidden" custom graphs on graph list page +Level: 1 +Component: multisite +Class: fix +Compatible: compat +Edition: cee +State: unknown +Version: 1.5.0i3 +Date: 1515407044 + +The title of the custom graphs was not shown on the graph list page for graphs that are configured +to be hidden from the sidebar. diff --git a/web/htdocs/pagetypes.py b/web/htdocs/pagetypes.py index 3153a19..b706c53 100644 --- a/web/htdocs/pagetypes.py +++ b/web/htdocs/pagetypes.py @@ -393,7 +393,7 @@ class PageRenderer(Base): if not self.is_hidden(): return html.render_a(self.title(), href=self.page_url()) else: - return "" + return self.title() #.

6 years, 8 months

WatoMode: Constructor override is not needed anymore to use the _from_vars () method

by Lars Michelsen

Module: check_mk Branch: master Commit: a02e13dbbd396b81dd92dfa8d848e041f44d9822 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a02e13dbbd396b… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Dec 20 15:06:42 2017 +0100 WatoMode: Constructor override is not needed anymore to use the _from_vars() method Change-Id: I7f9197f844e08e2fdb44cf3d1350043dcab5de35 --- web/htdocs/wato.py | 90 +++++++++--------------------------------------------- 1 file changed, 14 insertions(+), 76 deletions(-) diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index 7fed6de..657d6ba 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -368,6 +368,13 @@ def ensure_mode_permissions(modeperms): class WatoMode(object): def __init__(self): super(WatoMode, self).__init__() + self._from_vars() + + + def _from_vars(self): + """Override this method to set mode specific attributes based on the + given HTTP variables.""" + pass @classmethod @@ -2138,10 +2145,6 @@ class ModeObjectParameters(WatoMode): _PARAMETERS_UNKNOWN = [] _PARAMETERS_OMIT = [] - def __init__(self): - super(ModeObjectParameters, self).__init__() - self._from_vars() - def _from_vars(self): self._hostname = html.var("host") # may be empty in new/clone mode @@ -2481,11 +2484,6 @@ class ModeDiagHost(WatoMode): ] - def __init__(self): - super(ModeDiagHost, self).__init__() - self._from_vars() - - def _from_vars(self): self._hostname = html.var("host") if not self._hostname: @@ -2801,11 +2799,6 @@ class ModeDiscovery(WatoMode): SERVICE_REMOVED = "removed" - def __init__(self): - super(ModeDiscovery, self).__init__() - self._from_vars() - - def _from_vars(self): self._host_name = html.var("host") self._host = watolib.Folder.current().host(self._host_name) @@ -3470,11 +3463,6 @@ class ModeFirstDiscovery(ModeDiscovery): class ModeAjaxExecuteCheck(WatoWebApiMode): - def __init__(self): - super(ModeAjaxExecuteCheck, self).__init__() - self._from_vars() - - def _from_vars(self): # TODO: Validate the site self._site = html.var("site") @@ -4385,11 +4373,6 @@ class ModeBulkEdit(WatoMode): class ModeBulkCleanup(WatoMode): - def __init__(self): - super(ModeBulkCleanup, self).__init__() - self._from_vars() - - def _from_vars(self): self._folder = watolib.Folder.current() @@ -6243,10 +6226,6 @@ class ModeLDAPConfig(LDAPMode): class ModeEditLDAPConnection(LDAPMode): - def __init__(self): - super(ModeEditLDAPConnection, self).__init__() - self._from_vars() - def _from_vars(self): self._connection_id = html.var("id") self._connection_cfg = {} @@ -6887,16 +6866,15 @@ class ModeEditLDAPConnection(LDAPMode): class ModeGlobalSettings(WatoMode): def __init__(self): - super(ModeGlobalSettings, self).__init__() self._search = None self._show_only_modified = False + super(ModeGlobalSettings, self).__init__() + self._default_values = watolib.ConfigDomain.get_all_default_globals() self._global_settings = {} self._current_settings = {} - self._from_vars() - def _from_vars(self): self._search = get_search_expression() @@ -7112,7 +7090,6 @@ class ModeEditGlobals(ModeGlobalSettings): class ModeEditGlobalSetting(WatoMode): def __init__(self): super(ModeEditGlobalSetting, self).__init__() - self._from_vars() self._back_mode = "globalvars" @@ -7376,15 +7353,14 @@ class ModeEditGroup(WatoMode): type_name = None def __init__(self): - super(ModeEditGroup, self).__init__() - self.name = None self._new = False self._groups = {} self.group = {} self._load_groups() - self._from_vars() + + super(ModeEditGroup, self).__init__() def _load_groups(self): @@ -9386,11 +9362,6 @@ class ModeTimeperiodImportICal(WatoMode): class ModeEditTimeperiod(WatoMode): - def __init__(self): - super(ModeEditTimeperiod, self).__init__() - self._from_vars() - - def _from_vars(self): self._timeperiods = watolib.load_timeperiods() self._name = html.var("edit") # missing -> new group @@ -11516,7 +11487,6 @@ class ModeEditRole(RoleManagement, WatoMode): # Make sure that all dynamic permissions are available (e.g. those for custom # views) config.load_dynamic_permissions() - self._from_vars() def _from_vars(self): @@ -12651,7 +12621,6 @@ class ModeRulesets(WatoMode): def __init__(self): super(ModeRulesets, self).__init__() - self._from_vars() self._set_title_and_help() @@ -12866,11 +12835,6 @@ def rule_search_button(search_options=None, mode="rulesets"): class ModeEditRuleset(WatoMode): - def __init__(self): - super(ModeEditRuleset, self).__init__() - self._from_vars() - - def _from_vars(self): self._name = html.var("varname") self._back_mode = html.var("back_mode", html.var("ruleset_back_mode", "rulesets")) @@ -13476,9 +13440,8 @@ class ModeEditRuleset(WatoMode): class ModeRuleSearch(WatoMode): def __init__(self): - super(ModeRuleSearch, self).__init__() self.back_mode = html.var("back_mode", "rulesets") - self.search_options = self._from_vars() + super(ModeRuleSearch, self).__init__() def title(self): @@ -13519,7 +13482,7 @@ class ModeRuleSearch(WatoMode): if not value: html.del_all_vars("search_") - return value + self.search_options = value def _valuespec(self): @@ -13561,7 +13524,7 @@ class ModeRuleSearch(WatoMode): ("ruleset_group", DropdownChoice( title = _("Group"), - choices = watolib.g_rulespecs.get_group_choices(self.back_mode), + choices = lambda: watolib.g_rulespecs.get_group_choices(self.back_mode), )), ("ruleset_name", RegExpUnicode( title = _("Name"), @@ -13660,11 +13623,6 @@ class ModeRuleSearch(WatoMode): class ModeEditRule(WatoMode): _new = False - def __init__(self): - super(ModeEditRule, self).__init__() - self._from_vars() - - def _from_vars(self): self._name = html.var("varname") @@ -15064,11 +15022,6 @@ def create_sample_config(): # '----------------------------------------------------------------------' class ModePatternEditor(WatoMode): - def __init__(self): - super(ModePatternEditor, self).__init__() - self._from_vars() - - def _from_vars(self): self._hostname = html.var('host', '') # TODO: validate all fields @@ -15317,11 +15270,6 @@ class CustomAttrMode(WatoMode): class ModeEditCustomAttr(CustomAttrMode): - def __init__(self): - super(ModeEditCustomAttr, self).__init__() - self._from_vars() - - def _from_vars(self): self._name = html.var("edit") # missing -> new custom attr self._new = self._name == None @@ -15635,10 +15583,6 @@ def declare_custom_host_attrs(): # '----------------------------------------------------------------------' class ModeCheckPlugins(WatoMode): - def __init__(self): - super(ModeCheckPlugins, self).__init__() - self._from_vars() - def _from_vars(self): self._search = get_search_expression() self._topic = html.var("topic") @@ -15890,11 +15834,6 @@ class ModeCheckPlugins(WatoMode): class ModeCheckManPage(WatoMode): - def __init__(self): - super(ModeCheckManPage, self).__init__() - self._from_vars() - - def _from_vars(self): self._check_type = html.var("check_type") @@ -16591,7 +16530,6 @@ class ModeAnalyzeConfig(WatoMode): def __init__(self): super(ModeAnalyzeConfig, self).__init__() self._acks = self._load_acknowledgements() - self._from_vars() def _from_vars(self):

6 years, 8 months

5590 FIX Fixed possible deadlock in shutdown/restart procedure

by Lars Michelsen

Module: check_mk Branch: master Commit: be74ef90838ca92a010615470ce5d80b1b631766 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=be74ef90838ca9… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jan 2 15:31:24 2018 +0100 5590 FIX Fixed possible deadlock in shutdown/restart procedure During the shutdown/restart procedure of the livestatus proxy daemon a deadlock could occur. It seems this could rarely happen when the system running the process is under high load together with a large number of sites (>100) configured. When this situation occures, you can see several left over liveproxyd processes (master + several site processes) which can only be terminated with SIGKILL. When looking at the processes with strace, you can see hanging futex() calls. Workaround: In such a situation it is safe to simply kill all those processes using SIGKILL and start a clean liveproxyd processes after that. Change-Id: I56dd9bb0d0f01bbe7a394a74bc9d0d047f95265f --- .werks/5590 | 22 ++++++++++++++++++++++ tests/livestatus/test_liveproxyd.py | 6 ++++-- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/.werks/5590 b/.werks/5590 new file mode 100644 index 0000000..ee69425 --- /dev/null +++ b/.werks/5590 @@ -0,0 +1,22 @@ +Title: Fixed possible deadlock in shutdown/restart procedure +Level: 1 +Component: liveproxy +Compatible: compat +Edition: cee +Version: 1.5.0i3 +Date: 1514903032 +Class: fix + +During the shutdown/restart procedure of the livestatus proxy +daemon a deadlock could occur. It seems this could rarely happen +when the system running the process is under high load together +with a large number of sites (>100) configured. + +When this situation occures, you can see several left over +liveproxyd processes (master + several site processes) which +can only be terminated with SIGKILL. When looking at the processes +with strace, you can see hanging futex() calls. + +Workaround: In such a situation it is safe to simply kill all those +processes using SIGKILL and start a clean liveproxyd processes after +that. diff --git a/tests/livestatus/test_liveproxyd.py b/tests/livestatus/test_liveproxyd.py index b451b2b..ea0662e 100644 --- a/tests/livestatus/test_liveproxyd.py +++ b/tests/livestatus/test_liveproxyd.py @@ -6,8 +6,6 @@ import pytest import signal from testlib import web -pytestmark = pytest.mark.skipif(True, reason="liveproxyd remains in an unkillable state with tons of child processes") - @pytest.fixture(scope="module") def default_cfg(web): print "Applying default config" @@ -182,6 +180,9 @@ def test_large_number_of_sites(default_cfg, site): site.write_file("etc/check_mk/conf.d/liveproxyd-test.mk", "cmc_livestatus_threads = %d\n" % (num_channels*num_sites + 20)) + site.write_file("etc/check_mk/multisite.d/sites.mk", + "sites.update(%r)\n" % livestatus_api_sites) + site.execute(["cmk", "-O"]) # Disable limits of livestatus xinetd service @@ -218,3 +219,4 @@ def test_large_number_of_sites(default_cfg, site): finally: _use_liveproxyd_for_local_site(site, proto="unix") site.delete_file("etc/check_mk/conf.d/liveproxyd-test.mk") + site.delete_file("etc/check_mk/multisite.d/sites.mk")

6 years, 8 months

5592 FIX Fixed broken graph panning (at least in Firefox)

by Lars Michelsen

Module: check_mk Branch: master Commit: 371816eb4e04488b7412c31ed9b892573749f54f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=371816eb4e0448… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jan 2 16:44:37 2017 +0100 5592 FIX Fixed broken graph panning (at least in Firefox) The graph panning (moving vertical and time axes with drag/drop) was not working as expected in all situtations. At least when using the current Firefox it did not work. Change-Id: I75b928aab5ec5320f26c8f9587cc413218d59f45 --- .werks/5592 | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.werks/5592 b/.werks/5592 new file mode 100644 index 0000000..c650551 --- /dev/null +++ b/.werks/5592 @@ -0,0 +1,12 @@ +Title: Fixed broken graph panning (at least in Firefox) +Level: 1 +Component: metrics +Compatible: compat +Edition: cee +Version: 1.5.0i3 +Date: 1483371877 +Class: fix + +The graph panning (moving vertical and time axes with drag/drop) +was not working as expected in all situtations. At least when using +the current Firefox it did not work.

6 years, 8 months

5591 Only load graphs that are currently visible

by Lars Michelsen

Module: check_mk Branch: master Commit: 54717951f5d82e064ec4cef711056c978799359d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=54717951f5d82e… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jan 2 16:34:10 2017 +0100 5591 Only load graphs that are currently visible With this change the graphs shown by the GUI are only rendered when they are (partially) visible to the user. The initial loading of the graphs out of the viewport is now being delayed until they become visible to the user. This is a performance improvement for views showing a lot of graphs. Change-Id: I087d777ccc99e28f131f4d7c90bd22a690b122c8 --- .werks/5591 | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/.werks/5591 b/.werks/5591 new file mode 100644 index 0000000..640a3e0 --- /dev/null +++ b/.werks/5591 @@ -0,0 +1,15 @@ +Title: Only load graphs that are currently visible +Level: 2 +Component: metrics +Compatible: compat +Edition: cee +Version: 1.5.0i3 +Date: 1483371250 +Class: feature + +With this change the graphs shown by the GUI are only rendered +when they are (partially) visible to the user. The initial loading +of the graphs out of the viewport is now being delayed until they +become visible to the user. + +This is a performance improvement for views showing a lot of graphs.

6 years, 8 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits January 2018