Checkmk git commits July 2017

checkmk-commits@lists.checkmk.com

11 participants
286 discussions

4936 apache_status: Bakery can now configure host/ DNS names as instance addresses

by Lars Michelsen

Module: check_mk Branch: master Commit: b6b5653eb93b76a7c253134c00deca84764820ee URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b6b5653eb93b76… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 4 17:42:55 2017 +0200 4936 apache_status: Bakery can now configure host/DNS names as instance addresses Change-Id: I1ce89aafe91c6cdd9a8e48a3459849bbc02dc5bf --- .werks/4936 | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.werks/4936 b/.werks/4936 new file mode 100644 index 0000000..cfd88ac --- /dev/null +++ b/.werks/4936 @@ -0,0 +1,10 @@ +Title: apache_status: Bakery can now configure host/DNS names as instance addresses +Level: 1 +Component: agents +Compatible: compat +Edition: cee +Version: 1.5.0i1 +Date: 1499182940 +Class: feature + +

6 years, 12 months

4786 lvm_lvs: New check vor LVM logical volume pools

by Marcel Arentz

Module: check_mk Branch: master Commit: c79db101859367821ff28295b68a8e6c63570237 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c79db101859367… Author: Marcel Arentz <ma(a)mathias-kettner.de> Date: Thu Jun 1 16:08:59 2017 +0200 4786 lvm_lvs: New check vor LVM logical volume pools In LVM you can configure thin provisioned logical volume pools. These can be overprovisioned. This checkplugin measures the usage of these pools. Change-Id: Ia23027d63f57a0bdd61e8f2a2de54ceffa8a638d --- .werks/4786 | 11 +++++ agents/plugins/lvm | 3 ++ checks/lvm_lvs | 82 ++++++++++++++++++++++++++++++++++++ web/plugins/wato/check_parameters.py | 33 +++++++++++++++ 4 files changed, 129 insertions(+) diff --git a/.werks/4786 b/.werks/4786 new file mode 100644 index 0000000..ba0cbea --- /dev/null +++ b/.werks/4786 @@ -0,0 +1,11 @@ +Title: lvm_lvs: New check vor LVM logical volume pools +Level: 1 +Component: checks +Compatible: compat +Edition: cre +Version: 1.5.0i1 +Date: 1496326054 +Class: feature + +In LVM you can configure thin provisioned logical volume pools. These can +be overprovisioned. This checkplugin measures the usage of these pools. diff --git a/agents/plugins/lvm b/agents/plugins/lvm index 6f0b9de..00cd5fe 100755 --- a/agents/plugins/lvm +++ b/agents/plugins/lvm @@ -2,5 +2,8 @@ echo "<<<lvm_vgs>>>" vgs --units b --nosuffix --noheadings --separator ' ' +echo "<<<lvm_lvs:sep(124)>>>" +lvs --units b --nosuffix --noheadings --separator '|' + #echo "<<<lvm_pvs>>>" #pvs --units b --nosuffix --noheadings --separator ' ' diff --git a/checks/lvm_lvs b/checks/lvm_lvs new file mode 100644 index 0000000..8bae5bd --- /dev/null +++ b/checks/lvm_lvs @@ -0,0 +1,82 @@ +#!/usr/bin/python +# -*- encoding: utf-8; py-indent-offset: 4 -*- +# +------------------------------------------------------------------+ +# | ____ _ _ __ __ _ __ | +# | / ___| |__ ___ ___| | __ | \/ | |/ / | +# | | | | '_ \ / _ \/ __| |/ / | |\/| | ' / | +# | | |___| | | | __/ (__| < | | | | . \ | +# | \____|_| |_|\___|\___|_|\_\___|_| |_|_|\_\ | +# | | +# | Copyright Mathias Kettner 2017 mk(a)mathias-kettner.de | +# +------------------------------------------------------------------+ +# +# This file is part of Check_MK. +# The official homepage is at http://mathias-kettner.de/check_mk. +# +# check_mk is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License as published by +# the Free Software Foundation in version 2. check_mk is distributed +# in the hope that it will be useful, but WITHOUT ANY WARRANTY; with- +# out even the implied warranty of MERCHANTABILITY or FITNESS FOR A +# PARTICULAR PURPOSE. See the GNU General Public License for more de- +# tails. You should have received a copy of the GNU General Public +# License along with GNU Make; see the file COPYING. If not, write +# to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, +# Boston, MA 02110-1301 USA. + + +# example output + +factory_settings["lvm_lvs_default_levels"] = { + "levels_data" : (80.0, 90.0), + "levels_meta" : (80.0, 90.0), +} + +def parse_lvm_lvs(info): + parsed = {} + for line in info: + item = "%s/%s" % (line[1], line[4]) + if not line[4] == "" and not item in parsed: + parsed[item] = [] + + for line in info: + item = "%s/%s" % (line[1], line[0]) + if item in parsed: + parsed[item] = {"data" : line[6], "meta" : line[7]} + + return parsed + + +def inventory_lvm_lvs(parsed): + for key, values in parsed.iteritems(): + yield ( key, {} ) + + +def check_lvm_lvs(item, params, parsed): + for key, values in parsed.iteritems(): + if item == key: + for key, value in values.iteritems(): + value = float(value) + warn, crit = params["levels_%s" % key] + if value >= crit: + state = 2 + elif value >= warn: + state = 1 + else: + state = 0 + + key = key[0].upper()+key[1:] + yield 0, "%s usage: %.2f %%" % (key, value) + if state: + yield state, "(warn/crit at %s/%s)" % (warn, crit) + + +check_info['lvm_lvs'] = { + 'parse_function' : parse_lvm_lvs, + 'inventory_function' : inventory_lvm_lvs, + 'check_function' : check_lvm_lvs, + 'service_description' : 'LVM LV Pool %s', + 'has_perfdata' : True, + 'default_levels_variable' : 'lvm_lvs_default_levels', + 'group' : 'lvm_lvs_pools', +} diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py index 77d6853..685f2b7 100644 --- a/web/plugins/wato/check_parameters.py +++ b/web/plugins/wato/check_parameters.py @@ -4569,6 +4569,39 @@ register_check_parameters( register_check_parameters( subgroup_storage, + "lvm_lvs_pools", + _("Logical Volume Pools (LVM)"), + Dictionary( + elements = [ + ( "levels_meta", Tuple( + title = _("Levels for Meta"), + default_value = (80.0, 90.0), + elements = [ + Percentage(title = _("Warning at"), unit = _("%")), + Percentage(title = _("Critical at"), unit = _("%")) + ] + ), + ), + ( "levels_data", Tuple( + title = _("Levels for Data"), + default_value = (80.0, 90.0), + elements = [ + Percentage(title = _("Warning at"), unit = _("%")), + Percentage(title = _("Critical at"), unit = _("%")) + ] + ), + ), + ] + ), + TextAscii( + title = _("Logical Volume Pool"), + allow_empty = True, + ), + match_type = "dict" +) + +register_check_parameters( + subgroup_storage, "filehandler", _("Filehandler"), Dictionary(

6 years, 12 months

new odd bug

by Marcel Arentz

Module: check_mk Branch: master Commit: 6b5946ed5070f2865ec0cbc6e7fd6657b92e69ca URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=6b5946ed5070f2… Author: Marcel Arentz <ma(a)mathias-kettner.de> Date: Tue Jul 4 15:52:49 2017 +0200 new odd bug Change-Id: I9fcff1446b1822f99e3bcf171ac7415f5f135749 --- .bugs/2512 | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/.bugs/2512 b/.bugs/2512 new file mode 100644 index 0000000..4e563af --- /dev/null +++ b/.bugs/2512 @@ -0,0 +1,22 @@ +Title: failed service discovery in rare situations +Component: checks +State: open +Date: 2017-07-04 15:21:44 +Targetversion: 1.5.0 +Class: bug + +Situation: +In rare situation the service discovery will fail and discover no new snmp checks. Even if these are correctly implemented and the services are discovered on a different check_mk site. +This behaviour is rare and possibly hard to reproduce. Several different forms has been discovered: +1. Services are not discovered on commandline (cmk -IIv hostname) but in WATO Service Discovery. +2. Services are not discovered on cmd and not in WATO Service Discovery. The Discovery Check of the hosts see the missing services. +3. Nothing is discovered except forcing the check plugin with --checks=pluginname + +In some cases a workaround can be to discover the services in WATO. After that the discovery on cmd is working again. This is not working all the time. + +To reproduce the first occurance of this bug: + +cmk --flush hostname +cmk -IIv + +There is no known way to reproduce the third occurance nor to get it working again.

6 years, 12 months

4842 FIX Windows Agent / Exchange Monitoring: fixed broken MSExchange checks

by Andreas Boesl

Module: check_mk Branch: master Commit: d8284da6e5ba610b588fae26e823dd2898efaf3a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d8284da6e5ba61… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Tue Jul 4 14:48:42 2017 +0200 4842 FIX Windows Agent / Exchange Monitoring: fixed broken MSExchange checks All MSExchange Checks were missing in the latest version, due to an incorrect performance counter query. Change-Id: I5068fdb193bfeb1ad61c8dd185cb7f1ff35f7236 --- .werks/4842 | 12 ++++++++++++ agents/windows/SectionManager.cc | 14 +++++++------- agents/windows/build_version | 2 +- agents/windows/check_mk_agent-64.exe | Bin 1339904 -> 1340416 bytes agents/windows/check_mk_agent-64.unstripped.exe | Bin 15823277 -> 15823789 bytes agents/windows/check_mk_agent-64.unversioned.exe | Bin 1339904 -> 1340416 bytes agents/windows/check_mk_agent.exe | Bin 1317888 -> 1318400 bytes agents/windows/check_mk_agent.msi | Bin 2927616 -> 2928640 bytes agents/windows/check_mk_agent.unstripped.exe | Bin 13681693 -> 13682205 bytes agents/windows/check_mk_agent.unversioned.exe | Bin 1317888 -> 1318400 bytes agents/windows/install_agent-64.exe | Bin 591863 -> 591866 bytes agents/windows/install_agent.exe | Bin 589498 -> 589524 bytes agents/windows/plugins/mk_jolokia.exe | Bin 10088419 -> 10106761 bytes 13 files changed, 20 insertions(+), 8 deletions(-) diff --git a/.werks/4842 b/.werks/4842 new file mode 100644 index 0000000..75a3432 --- /dev/null +++ b/.werks/4842 @@ -0,0 +1,12 @@ +Title: Windows Agent / Exchange Monitoring: fixed broken MSExchange checks +Level: 1 +Component: checks +Compatible: compat +Edition: cre +Version: 1.5.0i1 +Date: 1499172445 +Class: fix + +All MSExchange Checks were missing in the latest version, due to an incorrect performance counter query. + + diff --git a/agents/windows/SectionManager.cc b/agents/windows/SectionManager.cc index 3643880..bd195b1 100644 --- a/agents/windows/SectionManager.cc +++ b/agents/windows/SectionManager.cc @@ -112,19 +112,19 @@ void SectionManager::loadStaticSections(Configuration &config, (new SectionGroup("msexch")) ->withToggleIfMissing() ->withSubSection((new SectionWMI("msexch_activesync")) - ->withObject(L"MSExchangeActiveSync")) + ->withObject(L"Win32_PerfRawData_MSExchangeActiveSync_MSExchangeActiveSync")) ->withSubSection((new SectionWMI("msexch_availability")) - ->withObject(L"MSExchangeAvailabilityService")) + ->withObject(L"Win32_PerfRawData_MSExchangeAvailabilityService")) ->withSubSection( - (new SectionWMI("msexch_owa"))->withObject(L"MSExchangeOWA")) + (new SectionWMI("msexch_owa"))->withObject(L"Win32_PerfRawData_MSExchangeOWA_MSExchangeOWA")) ->withSubSection((new SectionWMI("msexch_autodiscovery")) - ->withObject(L"MSExchangeAutodiscover")) + ->withObject(L"Win32_PerfRawData_MSExchangeAutodiscover_MSExchangeAutodiscover")) ->withSubSection((new SectionWMI("msexch_isclienttype")) - ->withObject(L"MSExchangeISClientType")) + ->withObject(L"Win32_PerfRawData_MSExchangeISClientType_MSExchangeISClientType")) ->withSubSection((new SectionWMI("msexch_isstore")) - ->withObject(L"MSExchangeISStore")) + ->withObject(L"Win32_PerfRawData_MSExchangeISStore_MSExchangeISStore")) ->withSubSection((new SectionWMI("msexch_rpcclientaccess")) - ->withObject(L"MSExchangeRpcClientAccess")) + ->withObject(L"Win32_PerfRawData_MSExchangeRpcClientAccess_MSExchangeRpcClientAccess")) ->withHiddenHeader() ->withSeparator(',')); diff --git a/agents/windows/build_version b/agents/windows/build_version index 07dcacc..f06c1c5 100644 --- a/agents/windows/build_version +++ b/agents/windows/build_version @@ -1 +1 @@ -2800 +2806 diff --git a/agents/windows/check_mk_agent-64.exe b/agents/windows/check_mk_agent-64.exe index 9842480..55424fc 100755 Binary files a/agents/windows/check_mk_agent-64.exe and b/agents/windows/check_mk_agent-64.exe differ diff --git a/agents/windows/check_mk_agent-64.unstripped.exe b/agents/windows/check_mk_agent-64.unstripped.exe index 6a6935d..24c8ff0 100755 Binary files a/agents/windows/check_mk_agent-64.unstripped.exe and b/agents/windows/check_mk_agent-64.unstripped.exe differ diff --git a/agents/windows/check_mk_agent-64.unversioned.exe b/agents/windows/check_mk_agent-64.unversioned.exe index 288d4bf..909f567 100755 Binary files a/agents/windows/check_mk_agent-64.unversioned.exe and b/agents/windows/check_mk_agent-64.unversioned.exe differ diff --git a/agents/windows/check_mk_agent.exe b/agents/windows/check_mk_agent.exe index 855f556..e2dd34d 100755 Binary files a/agents/windows/check_mk_agent.exe and b/agents/windows/check_mk_agent.exe differ diff --git a/agents/windows/check_mk_agent.msi b/agents/windows/check_mk_agent.msi index 800596e..28b83e5 100755 Binary files a/agents/windows/check_mk_agent.msi and b/agents/windows/check_mk_agent.msi differ diff --git a/agents/windows/check_mk_agent.unstripped.exe b/agents/windows/check_mk_agent.unstripped.exe index cb22bb3..6193098 100755 Binary files a/agents/windows/check_mk_agent.unstripped.exe and b/agents/windows/check_mk_agent.unstripped.exe differ diff --git a/agents/windows/check_mk_agent.unversioned.exe b/agents/windows/check_mk_agent.unversioned.exe index 3baaa64..06b2cc2 100755 Binary files a/agents/windows/check_mk_agent.unversioned.exe and b/agents/windows/check_mk_agent.unversioned.exe differ diff --git a/agents/windows/install_agent-64.exe b/agents/windows/install_agent-64.exe index 2f47628..d127af0 100755 Binary files a/agents/windows/install_agent-64.exe and b/agents/windows/install_agent-64.exe differ diff --git a/agents/windows/install_agent.exe b/agents/windows/install_agent.exe index 45e8927..c0f102b 100755 Binary files a/agents/windows/install_agent.exe and b/agents/windows/install_agent.exe differ diff --git a/agents/windows/plugins/mk_jolokia.exe b/agents/windows/plugins/mk_jolokia.exe index 553422b..2fdcbfc 100755 Binary files a/agents/windows/plugins/mk_jolokia.exe and b/agents/windows/plugins/mk_jolokia.exe differ

6 years, 12 months

Fixed another navigation issue in WATO rulesets

by Lars Michelsen

Module: check_mk Branch: master Commit: 5507cddd77e538c4aaaf74e084871d5ec6d04b57 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5507cddd77e538… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 4 15:31:39 2017 +0200 Fixed another navigation issue in WATO rulesets Change-Id: I3a3f11d92c19e1e1b67528777426af025d25d97f --- web/htdocs/wato.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index d4dce5c..482c1c8 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -12300,7 +12300,7 @@ class ModeRulesets(WatoMode): # Keeping this for compatibility reasons for the moment if self._group_name: html.set_var("search_p_ruleset_group", - DropdownChoice.option_id(html.get_unicode_input("group"))) + DropdownChoice.option_id(html.var("group"))) html.set_var("search_p_ruleset_group_USE", "on") html.del_var("group")

6 years, 12 months

Cleaned up merge problem

by Lars Michelsen

Module: check_mk Branch: master Commit: 63d5598a92bffe102408f4ccf674c219b8a44129 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=63d5598a92bffe… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 4 15:22:44 2017 +0200 Cleaned up merge problem Change-Id: I97d1efa108bde1d32cd29f7c24c6a1ce31f7c864 --- web/htdocs/sidebar.py | 1 - 1 file changed, 1 deletion(-) diff --git a/web/htdocs/sidebar.py b/web/htdocs/sidebar.py index 6b33707..b1a8b9f 100644 --- a/web/htdocs/sidebar.py +++ b/web/htdocs/sidebar.py @@ -404,7 +404,6 @@ def render_snapin(name, state): except Exception, e: log_exception() write_snapin_exception(e) - snapin_exception(e) html.close_div() html.close_div() return refresh_url

6 years, 12 months

4935 FIX Foldertree snapin: Fixed broken layout when using localized GUI

by Lars Michelsen

Module: check_mk Branch: master Commit: 6d166703e475dba7627ecb48b32d4243dc92b1f3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=6d166703e475db… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 4 15:02:33 2017 +0200 4935 FIX Foldertree snapin: Fixed broken layout when using localized GUI Change-Id: I5437effe341955d7451614e01d00efa841151035 --- .werks/4935 | 11 +++++++++++ web/htdocs/sidebar.py | 4 ++-- web/plugins/sidebar/wato.py | 43 +++++++++++++++++++++++++++++-------------- 3 files changed, 42 insertions(+), 16 deletions(-) diff --git a/.werks/4935 b/.werks/4935 new file mode 100644 index 0000000..2139c35 --- /dev/null +++ b/.werks/4935 @@ -0,0 +1,11 @@ +Title: Foldertree snapin: Fixed broken layout when using localized GUI +Level: 1 +Component: wato +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.5.0i1 +Date: 1499173204 + + diff --git a/web/htdocs/sidebar.py b/web/htdocs/sidebar.py index bce5777..6b33707 100644 --- a/web/htdocs/sidebar.py +++ b/web/htdocs/sidebar.py @@ -402,7 +402,9 @@ def render_snapin(name, state): refresh_url = url html.javascript("get_url(\"%s\", updateContents, \"snapin_%s\")" % (refresh_url, name)) except Exception, e: + log_exception() write_snapin_exception(e) + snapin_exception(e) html.close_div() html.close_div() return refresh_url @@ -466,8 +468,6 @@ def ajax_snapin(): with html.plugged(): try: - # For testing purposes uncomment: - # raise Exception("Test") snapin["render"]() except Exception, e: write_snapin_exception(e) diff --git a/web/plugins/sidebar/wato.py b/web/plugins/sidebar/wato.py index 9029b09..634d934 100644 --- a/web/plugins/sidebar/wato.py +++ b/web/plugins/sidebar/wato.py @@ -26,14 +26,15 @@ import config, wato, views, dashboard -# +----------------------------------------------------------------------+ +# .--WATO----------------------------------------------------------------. # | __ ___ _____ ___ | # | \ \ / / \|_ _/ _ \ | # | \ \ /\ / / _ \ | || | | | | # | \ V V / ___ \| || |_| | | # | \_/\_/_/ \_\_| \___/ | # | | -# +----------------------------------------------------------------------+ +# '----------------------------------------------------------------------' + def render_wato(mini): if not config.wato_enabled: html.write_text(_("WATO is disabled.")) @@ -100,15 +101,14 @@ sidebar_snapins["admin_mini"] = { """, } -# .----------------------------------------------------------------------. +#. +# .--Foldertree----------------------------------------------------------. # | _____ _ _ _ | # | | ___|__ | | __| | ___ _ __| |_ _ __ ___ ___ | # | | |_ / _ \| |/ _` |/ _ \ '__| __| '__/ _ \/ _ \ | # | | _| (_) | | (_| | __/ | | |_| | | __/ __/ | # | |_| \___/|_|\__,_|\___|_| \__|_| \___|\___| | # | | -# +----------------------------------------------------------------------+ -# | | # '----------------------------------------------------------------------' def compute_foldertree(): @@ -239,8 +239,18 @@ def render_wato_foldertree(): dashboard.load_dashboards() topic_views = visuals_by_topic(views.permitted_views().items() + dashboard.permitted_dashboards().items()) topics = [ (t, t) for t, s in topic_views ] + + html.open_table() + html.open_tr() + html.td(_('Topic:'), class_="label") + html.open_td() html.dropdown("topic", topics, deflt=selected_topic, onchange='wato_tree_topic_changed(this)') - html.span(_('Topic:'), class_="left") + html.close_td() + html.close_tr() + + html.open_tr() + html.td(_("View:"), class_="label") + html.open_td() for topic, view_list in topic_views: targets = [] @@ -261,7 +271,9 @@ def render_wato_foldertree(): html.dropdown("target_%s" % topic, targets, deflt=default, onchange='wato_tree_target_changed(this)', style=style) - html.span(_("View:"), class_="left") + html.close_td() + html.close_tr() + html.close_table() # Now render the whole tree if user_folders: @@ -276,18 +288,21 @@ sidebar_snapins['wato_foldertree'] = { 'render' : render_wato_foldertree, 'allowed' : [ 'admin', 'user', 'guest' ], 'styles' : """ +#snapin_wato_foldertree table { + width: 100%; + border-spacing: 0; +} #snapin_wato_foldertree select { - float: right; padding: 0; - width: 190px; + width: 100%; height: 19px; margin-bottom: 2px; } -#snapin_wato_foldertree span { - margin-top: 1px; - display: block; - color: #ffffff; - height: 20px; +#snapin_wato_foldertree table td.label { + width: 1px; +} +#snapin_wato_foldertree table td { + vertical-align: baseline; } """ }

6 years, 12 months

4934 FIX Views: Fixed possible broken table background when using "table" layout with zoomed pages

by Lars Michelsen

Module: check_mk Branch: master Commit: d5ad57309fa333f79d6701674089610b288b4623 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d5ad57309fa333… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 4 14:17:30 2017 +0200 4934 FIX Views: Fixed possible broken table background when using "table" layout with zoomed pages When using Firefox in the newest version (54 or newer) and zooming the Check_MK GUI pages it could happen that the background color of the tables in some views is not displayed. Change-Id: Id0bb4bcf50acd1908b83223c6cfb0ca271b986d7 --- .werks/4934 | 12 ++++++++++++ web/htdocs/pages.css | 1 - 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.werks/4934 b/.werks/4934 new file mode 100644 index 0000000..e8f0578 --- /dev/null +++ b/.werks/4934 @@ -0,0 +1,12 @@ +Title: Views: Fixed possible broken table background when using "table" layout with zoomed pages +Level: 1 +Component: multisite +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.5.0i1 +Date: 1499170520 + +When using Firefox in the newest version (54 or newer) and zooming the Check_MK GUI pages +it could happen that the background color of the tables in some views is not displayed. diff --git a/web/htdocs/pages.css b/web/htdocs/pages.css index 8ebc40a..e438a40 100644 --- a/web/htdocs/pages.css +++ b/web/htdocs/pages.css @@ -404,7 +404,6 @@ table.data { border-spacing: 0px; margin: 0; padding: 0; - border-collapse: collapse; empty-cells: show; width: 100%; }

6 years, 12 months

Fixed exception on werk page when rendering filters

by Lars Michelsen

Module: check_mk Branch: master Commit: 13cf93a4524a1f7f15a3bc9e136da1a0dd0c65c4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=13cf93a4524a1f… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 4 10:45:26 2017 +0200 Fixed exception on werk page when rendering filters Change-Id: Ie3d522b61a42459e017261c6f496392aa3323e88 --- web/htdocs/valuespec.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/htdocs/valuespec.py b/web/htdocs/valuespec.py index 9d75665..2e4abe0 100644 --- a/web/htdocs/valuespec.py +++ b/web/htdocs/valuespec.py @@ -1679,7 +1679,7 @@ class DropdownChoice(ValueSpec): @classmethod def option_id(cls, val): - return "%s" % hash(val) + return "%s" % hash(repr(val)) def validate_value(self, value, varprefix):

6 years, 12 months

Fixed additional problem with recently changed DropdownChoice() valuespec

by Lars Michelsen

Module: check_mk Branch: master Commit: 583bad859be8ff8f40eed5f95dd1cb6f3bf6302f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=583bad859be8ff… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 4 09:12:49 2017 +0200 Fixed additional problem with recently changed DropdownChoice() valuespec Change-Id: I5878c1edbe6ea7f989d140b1da4533759e29dfb1 --- web/htdocs/valuespec.py | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/web/htdocs/valuespec.py b/web/htdocs/valuespec.py index e4386ad..9d75665 100644 --- a/web/htdocs/valuespec.py +++ b/web/htdocs/valuespec.py @@ -1601,15 +1601,18 @@ class DropdownChoice(ValueSpec): self.classtype_info() if self._label: html.write("%s " % self._label) - # Convert values from choices to keys - defval = "0" + + choices = self.choices() + + defval = choices[0][0] if choices else None options = [] - for n, entry in enumerate(self.choices()): + for entry in self.choices(): if self._prefix_values: entry = (entry[0], "%s - %s" % entry) - options.append((str(n),) + entry[1:]) + + options.append(entry) if entry[0] == value: - defval = str(n) + defval = entry[0] # In complain mode: Use the value received from the HTML variable if self._invalid_choice == "complain" and value != None and self._value_is_invalid(value):

6 years, 12 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits July 2017