Checkmk git commits July 2017

checkmk-commits@lists.checkmk.com

11 participants
286 discussions

5020 FIX Log levels for the event console are now updated on activation of changes

by Sven Panne

Module: check_mk Branch: master Commit: 77c9ca4070fd7bcaabb2cbbb34b47795814e1f29 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=77c9ca4070fd7b… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Wed Jul 19 14:11:40 2017 +0200 5020 FIX Log levels for the event console are now updated on activation of changes Previously, a restart was necessary to propagate the changes. This has been fixed. Change-Id: I8c9bbcb43dd8a64daed0a579c272f63bedb72b07 --- .werks/5020 | 11 +++++++++++ bin/mkeventd | 6 +++--- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/.werks/5020 b/.werks/5020 new file mode 100644 index 0000000..2c4995f --- /dev/null +++ b/.werks/5020 @@ -0,0 +1,11 @@ +Title: Log levels for the event console are now updated on activation of changes +Level: 1 +Component: ec +Compatible: compat +Edition: cre +Version: 1.5.0i1 +Date: 1500466164 +Class: fix + +Previously, a restart was necessary to propagate the changes. This has been +fixed. diff --git a/bin/mkeventd b/bin/mkeventd index 5461c50..0839191 100755 --- a/bin/mkeventd +++ b/bin/mkeventd @@ -1252,7 +1252,6 @@ class EventServer(object): self._snmptrap = None self._mib_resolver = None self.logger = logger.getChild("EventServer") - self.logger.setLevel(g_config["log_level"]["cmk.mkeventd.EventServer"]) self.create_pipe() self.open_eventsocket() @@ -3081,7 +3080,6 @@ class StatusServer(object): self._reopen_sockets = False self._should_terminate = False self.logger = logger.getChild("StatusServer") - self.logger.setLevel(g_config["log_level"]["cmk.mkeventd.StatusServer"]) self.open_sockets() @@ -3637,7 +3635,6 @@ class EventStatus(object): def __init__(self): self.logger = logger.getChild("EventStatus") - self.logger.setLevel(g_config["log_level"]["cmk.mkeventd.EventStatus"]) self.flush() @@ -4708,6 +4705,9 @@ def load_configuration(): } logger.setLevel(g_config["log_level"]["cmk.mkeventd"]) + logger.getChild("EventServer").setLevel(g_config["log_level"]["cmk.mkeventd.EventServer"]) + logger.getChild("EventStatus").setLevel(g_config["log_level"]["cmk.mkeventd.EventStatus"]) + logger.getChild("StatusServer").setLevel(g_config["log_level"]["cmk.mkeventd.StatusServer"]) # Configure the auto deleting indexes in the DB when mongodb is enabled if g_config['archive_mode'] == 'mongodb':

6 years, 11 months

Fix the fix.

by Sven Panne

Module: check_mk Branch: master Commit: 932febfd97fd77f2e476bba74a995574bd577bfd URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=932febfd97fd77… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Wed Jul 19 09:24:41 2017 +0200 Fix the fix. Change-Id: I3ca5c437e123becebcb9ce57d3175bcbe18a9309 --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 8c9fdf0..b50d88b 100644 --- a/Makefile +++ b/Makefile @@ -175,7 +175,7 @@ $(DISTNAME).tar.gz: mk-livestatus-$(VERSION).tar.gz .werks/werks $(JAVASCRIPT_MI @echo "Making $(DISTNAME)" rm -rf $(DISTNAME) mkdir -p $(DISTNAME) - tar cf $(DISTNAME)/bin.tar $(TAROPTS) -C bin $$(cd bin ; ls | grep -v '\.cc$$') + tar cf $(DISTNAME)/bin.tar $(TAROPTS) -C bin $$(cd bin ; ls) tar rf $(DISTNAME)/bin.tar $(TAROPTS) -C agents/windows/msibuild msi-update gzip $(DISTNAME)/bin.tar pycompile lib ; \

6 years, 11 months

4810 ps.inlcude: Add levels of CPU utilization for single processes

by Tom Baerwinkel

Module: check_mk Branch: master Commit: f11506c21fd036094e3d5427bd92f11f33b8b2d2 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f11506c21fd036… Author: Tom Baerwinkel <tb(a)mathias-kettner.de> Date: Thu Jul 13 10:36:44 2017 +0200 4810 ps.inlcude: Add levels of CPU utilization for single processes For the rules "State and Count of Processes" and "Process Discovery" the option "Levels on CPU utilization of a single Process" was added. It allows to define levels on CPU utilization of a single process. CPU Averaging will not be applied to the CPU utilization of a single processes. Change-Id: Ida8dfb9e2675362264c07bb23d08861a5f605e26 --- .werks/4810 | 14 ++++ checks/ps.include | 32 ++++++++- web/plugins/wato/check_parameters.py | 135 +++++++++++++++++++---------------- 3 files changed, 117 insertions(+), 64 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=f11506c21f…

6 years, 11 months

Pack Makefile into bin.tar, it will be remove later. Ugly as hell...

by Sven Panne

Module: check_mk Branch: master Commit: 29400197ea7c8c662d0d1fa36147afd3d0715b0d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=29400197ea7c8c… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Wed Jul 19 08:19:52 2017 +0200 Pack Makefile into bin.tar, it will be remove later. Ugly as hell... Change-Id: I01af0364d5b27007a8041aa0600d7fd81d24d0a9 --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 9914b3e..8c9fdf0 100644 --- a/Makefile +++ b/Makefile @@ -175,7 +175,7 @@ $(DISTNAME).tar.gz: mk-livestatus-$(VERSION).tar.gz .werks/werks $(JAVASCRIPT_MI @echo "Making $(DISTNAME)" rm -rf $(DISTNAME) mkdir -p $(DISTNAME) - tar cf $(DISTNAME)/bin.tar $(TAROPTS) -C bin $$(cd bin ; ls | grep -v '\.cc$$\|Makefile$$') + tar cf $(DISTNAME)/bin.tar $(TAROPTS) -C bin $$(cd bin ; ls | grep -v '\.cc$$') tar rf $(DISTNAME)/bin.tar $(TAROPTS) -C agents/windows/msibuild msi-update gzip $(DISTNAME)/bin.tar pycompile lib ; \

6 years, 11 months

New bugs related to distributed monitoring

by Sven Rueß

Module: check_mk Branch: master Commit: 9d0c5772f9f35b6acc48c4928767e62aff6fcba4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=9d0c5772f9f35b… Author: Sven Rueß <sr(a)mathias-kettner.de> Date: Tue Jul 18 18:50:55 2017 +0200 New bugs related to distributed monitoring Change-Id: I3ef6b214266c9f097b2c5dedf2a341e364e927c0 --- .bugs/2938 | 14 ++++++++++++++ .bugs/2939 | 14 ++++++++++++++ 2 files changed, 28 insertions(+) diff --git a/.bugs/2938 b/.bugs/2938 new file mode 100644 index 0000000..9f20ff3 --- /dev/null +++ b/.bugs/2938 @@ -0,0 +1,14 @@ +Title: Automatic baking agents options breaks activation of changes in distributed setups +Component: wato +State: open +Date: 2017-07-18 18:43:49 +Targetversion: 1.2.8 +Class: bug + +If the option autimatic bake agents is activated in distributed setups, +the agents will be build on slave sites. That will break the activation of +changes on thsi slave site. + +This option should only applied to the master site and have to be ignored on slave sites. + +Workaround: Deactivate this option again. diff --git a/.bugs/2939 b/.bugs/2939 new file mode 100644 index 0000000..9c20201 --- /dev/null +++ b/.bugs/2939 @@ -0,0 +1,14 @@ +Title: Export WATO folder permissions breaks activate changes in distributed setups +Component: wato +State: open +Date: 2017-07-18 18:46:33 +Targetversion: 1.2.8 +Class: bug + +If the option Export WATO permissions is activated and around 1400 users are used in +user management, it will break activation of changes. It will end in a apache process +which is running on full power to calculate all the settings for all users. + +This option should be blocked if too much users exists or should be better optimized for higer user amounts. + +Workaround: Deactivte the option Export WATO permissions

6 years, 11 months

Reserved 2 bug IDS

by Sven Rueß

Module: check_mk Branch: master Commit: d1feaad61e9f1570220d65816f05c73ec0f65edb URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d1feaad61e9f15… Author: Sven Rueß <sr(a)mathias-kettner.de> Date: Tue Jul 18 18:43:26 2017 +0200 Reserved 2 bug IDS Change-Id: I26c646c094b8ce5593abe1b9f60a6ffba2931304 --- .bugs/first_free | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.bugs/first_free b/.bugs/first_free index 5672c98..fc818e9 100644 --- a/.bugs/first_free +++ b/.bugs/first_free @@ -1 +1 @@ -2938 +2940

6 years, 11 months

Added missing space

by Mathias Kettner

Module: check_mk Branch: master Commit: 3250f566b8806516e24af776459a7485fc20f924 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3250f566b88065… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Jul 18 12:26:14 2017 +0200 Added missing space Change-Id: I4876bafd746086bb1320f8bf95a9250e6806871f --- web/plugins/views/commands.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/plugins/views/commands.py b/web/plugins/views/commands.py index 82efaa0..2b19944 100644 --- a/web/plugins/views/commands.py +++ b/web/plugins/views/commands.py @@ -74,7 +74,7 @@ multisite_commands.append({ "title" : _("Reschedule active checks"), "render" : lambda: \ html.button("_resched_checks", _("Reschedule")) == \ - html.write_text(_("and spread over") + " ") == \ + html.write_text(" " + _("and spread over") + " ") == \ html.number_input("_resched_spread", 0, size=3) == \ html.write_text(" " + _("minutes") + " "), "action" : command_reschedule,

6 years, 11 months

Do not pack misc files under bin/ into distribution.

by Sven Panne

Module: check_mk Branch: master Commit: 4ac2ef2517e79747cdb67f206bdf206f09fbe0a8 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=4ac2ef2517e797… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Tue Jul 18 12:16:21 2017 +0200 Do not pack misc files under bin/ into distribution. Change-Id: I6ba4d33176eaaf05c8ab4468635ff5e4f9679163 --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index b50d88b..9914b3e 100644 --- a/Makefile +++ b/Makefile @@ -175,7 +175,7 @@ $(DISTNAME).tar.gz: mk-livestatus-$(VERSION).tar.gz .werks/werks $(JAVASCRIPT_MI @echo "Making $(DISTNAME)" rm -rf $(DISTNAME) mkdir -p $(DISTNAME) - tar cf $(DISTNAME)/bin.tar $(TAROPTS) -C bin $$(cd bin ; ls) + tar cf $(DISTNAME)/bin.tar $(TAROPTS) -C bin $$(cd bin ; ls | grep -v '\.cc$$\|Makefile$$') tar rf $(DISTNAME)/bin.tar $(TAROPTS) -C agents/windows/msibuild msi-update gzip $(DISTNAME)/bin.tar pycompile lib ; \

6 years, 11 months

Updated bug entries #2928, #2929

by Mathias Kettner

Module: check_mk Branch: master Commit: 3be6e72d05b725504677a349bb1edb3248ecc44d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3be6e72d05b725… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Jul 18 11:30:34 2017 +0200 Updated bug entries #2928, #2929 Change-Id: If9e95d9b5e3180748f25321f28ffa04f8f74f84e --- .bugs/2928 | 8 ++++++++ .bugs/2929 | 10 ++++++++++ 2 files changed, 18 insertions(+) diff --git a/.bugs/2928 b/.bugs/2928 new file mode 100644 index 0000000..bcd4ecc --- /dev/null +++ b/.bugs/2928 @@ -0,0 +1,8 @@ +Title: Order of command boxes in views are language dependent +Component: multisite +State: open +Date: 2017-07-18 11:29:17 +Targetversion: 1.4.0 +Class: bug + +The order in Englisch and German is different but should not. diff --git a/.bugs/2929 b/.bugs/2929 new file mode 100644 index 0000000..beb1e0e --- /dev/null +++ b/.bugs/2929 @@ -0,0 +1,10 @@ +Title: Command box in views is openable even if the icon is disabled +Component: multisite +State: open +Date: 2017-07-18 11:29:49 +Targetversion: 1.4.0 +Class: bug + +If you have a view with no services then the icon for the +command box is diabled. But nevertheless you can open +the box by clicking on it. This is not good.

6 years, 11 months

4851 FIX Improved WATO service discovery performance

by Andreas Boesl

Module: check_mk Branch: master Commit: 86e411d58d65d7ffc4861123d3419b41af2bfea4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=86e411d58d65d7… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Tue Jul 18 11:37:03 2017 +0200 4851 FIX Improved WATO service discovery performance The function responsible for the service discovery did not properly cache the data for later usage. This drastically slowed down the service discovery performance for hosts with lots of services. Change-Id: Idc60ddbc1e6ac12098bd1d2febc0d1e0aea7caa9 --- .werks/4851 | 13 +++++++++++++ cmk_base/discovery.py | 10 +++++++++- 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/.werks/4851 b/.werks/4851 new file mode 100644 index 0000000..74df3de --- /dev/null +++ b/.werks/4851 @@ -0,0 +1,13 @@ +Title: Improved WATO service discovery performance +Level: 1 +Component: checks +Compatible: compat +Edition: cre +Version: 1.5.0i1 +Date: 1500370603 +Class: fix + +The function responsible for the service discovery did not properly +cache the data for later usage. This drastically slowed down the +service discovery performance for hosts with lots of services. + diff --git a/cmk_base/discovery.py b/cmk_base/discovery.py index a070835..888438d 100644 --- a/cmk_base/discovery.py +++ b/cmk_base/discovery.py @@ -1133,6 +1133,8 @@ def get_check_preview(hostname, use_caches, do_snmp_scan, on_error): ipaddress = ip_lookup.lookup_ip_address(hostname) table = [] + parsed_infos = {} # temporary cache for parsed infos + for (check_type, item), (check_source, paramstring) in services.items(): params = None if check_source not in [ 'legacy', 'active', 'custom' ]: @@ -1169,7 +1171,13 @@ def get_check_preview(hostname, use_caches, do_snmp_scan, on_error): try: exitcode = None perfdata = [] - info = agent_data.get_info_for_check(hostname, ipaddress, infotype) + + if infotype in parsed_infos: + info = parsed_infos[infotype] + else: + info = agent_data.get_info_for_check(hostname, ipaddress, infotype) + parsed_infos[infotype] = info + # Handle cases where agent does not output data except MKAgentError, e: exitcode = 3

6 years, 11 months

← Newer
1
...
8
9
10
11
12
13
14
...
29
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits July 2017