Checkmk git commits June 2017

checkmk-commits@lists.checkmk.com

13 participants
266 discussions

4899 FIX Don' t fail WATO snapshot creation because of modified temporary files

by Lars Michelsen

Module: check_mk Branch: master Commit: 1f680da97b1d5dc0e51cd944239d91761f668621 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1f680da97b1d5d… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jun 26 16:25:40 2017 +0200 4899 FIX Don't fail WATO snapshot creation because of modified temporary files Change-Id: I49801f5fb3c32206084c5c45b0f269c7ac88ea6a --- .werks/4899 | 11 +++++++++++ web/htdocs/multitar.py | 3 +++ 2 files changed, 14 insertions(+) diff --git a/.werks/4899 b/.werks/4899 new file mode 100644 index 0000000..eeae645 --- /dev/null +++ b/.werks/4899 @@ -0,0 +1,11 @@ +Title: Don't fail WATO snapshot creation because of modified temporary files +Level: 1 +Component: wato +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.5.0i1 +Date: 1498487120 + + diff --git a/web/htdocs/multitar.py b/web/htdocs/multitar.py index 835036e..0c565ec 100644 --- a/web/htdocs/multitar.py +++ b/web/htdocs/multitar.py @@ -44,6 +44,9 @@ def create(filename, components): what, name, path = component excludes = [] + # exclude all temporary files + excludes.append(".*new*") + abspath = os.path.abspath(path) if os.path.exists(path): if what == "dir":

7 years, 5 months

4900 FIX Activate changes: Improved error reporting during activate changes

by Lars Michelsen

Module: check_mk Branch: master Commit: 70d1f37035aff2ede051b9ee65cb227204c0e8ed URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=70d1f37035aff2… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jun 26 16:26:34 2017 +0200 4900 FIX Activate changes: Improved error reporting during activate changes Change-Id: I3280f6be40f4ca4cb3c9754083955c1551122ba6 --- .werks/4900 | 11 +++++++++++ web/htdocs/multitar.py | 15 ++++++++++----- 2 files changed, 21 insertions(+), 5 deletions(-) diff --git a/.werks/4900 b/.werks/4900 new file mode 100644 index 0000000..5a4450f --- /dev/null +++ b/.werks/4900 @@ -0,0 +1,11 @@ +Title: Activate changes: Improved error reporting during activate changes +Level: 1 +Component: wato +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.5.0i1 +Date: 1498487162 + + diff --git a/web/htdocs/multitar.py b/web/htdocs/multitar.py index 0c565ec..62cbd8f 100644 --- a/web/htdocs/multitar.py +++ b/web/htdocs/multitar.py @@ -59,11 +59,16 @@ def create(filename, components): exclude_args = list(itertools.chain.from_iterable([ ("--exclude", f) for f in excludes ])) - subdata = subprocess.check_output( - [ "tar", "cf", "-", "--force-local" ] - + exclude_args - + [ "-C", basedir, filename ] - ) + cmd = [ "tar", "cf", "-", "--force-local" ] \ + + exclude_args \ + + [ "-C", basedir, filename ] + + p = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE) + subdata, stderr = p.communicate() + + if p.returncode != 0: + raise MKGeneralException("Failed to create tar: %s\nExit code: %d\nOutput: %s" % + (subprocess.list2cmdline(cmd), p.returncode, stderr)) info = tarfile.TarInfo(subtarname) info.mtime = time.time()

7 years, 5 months

4827 FIX domino_info: Fixed crash if some information is missing

by Marcel Arentz

Module: check_mk Branch: master Commit: 0accbb5ba6694dacc20b92978d1f75de4ea898a7 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=0accbb5ba6694d… Author: Marcel Arentz <ma(a)mathias-kettner.de> Date: Mon Jun 26 16:22:04 2017 +0200 4827 FIX domino_info: Fixed crash if some information is missing Change-Id: Ic75c313e52e2a1d92521fef940d88b91a06a98d2 --- .werks/4827 | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.werks/4827 b/.werks/4827 new file mode 100644 index 0000000..b40a98c --- /dev/null +++ b/.werks/4827 @@ -0,0 +1,10 @@ +Title: domino_info: Fixed crash if some information is missing +Level: 1 +Component: checks +Compatible: compat +Edition: cre +Version: 1.5.0i1 +Date: 1498486899 +Class: fix + +

7 years, 5 months

refactored domino_info

by Marcel Arentz

Module: check_mk Branch: master Commit: 86dbc47cefcec956a43a9768f9f82b18d1ee72f0 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=86dbc47cefcec9… Author: Marcel Arentz <ma(a)mathias-kettner.de> Date: Mon Jun 26 16:21:33 2017 +0200 refactored domino_info this is also a bugfix. But in this case the fix could notbe seperated from the refactoring. The problem has been principally in the old structure Change-Id: If20827806c3d56d72ff10c90aec0bb9e82ef65b1 --- checks/domino_info | 50 +++++++++++++++++++++----------------------------- 1 file changed, 21 insertions(+), 29 deletions(-) diff --git a/checks/domino_info b/checks/domino_info index 2748c5e..2bf0ad7 100644 --- a/checks/domino_info +++ b/checks/domino_info @@ -33,35 +33,27 @@ # .1.3.6.1.4.1.334.72.1.1.6.2.4.0 Release 8.5.3FP5 HF89 -domino_info_states = { - '1' : 'up', - '2' : 'down', - '3' : 'not-responding', - '4' : 'crashed', - '5' : 'unknown' -} - def inventory_domino_info(info): if info and len(info[0]) != 0: yield None, None def check_domino_info(_no_item, _no_params, info): - serverstate, domain, name, release = info + translate_status = { + '1' : (0, 'up'), + '2' : (2, 'down'), + '3' : (2, 'not-responding'), + '4' : (1, 'crashed'), + '5' : (3, 'unknown'), + } + status, domain, name, release = info[0] + + state, state_readable = translate_status[status] + yield state, "Server is %s" % state_readable + if len(domain) > 0: - maildomain = domain[0][0] - else: - maildomain = "-" - if int(serverstate[0][0]) > 4: - state = 1 - infotext = "Server is %s" % ( domino_info_states[serverstate[0][0]] ) - elif int(serverstate[0][0]) > 1: - state = 2 - infotext = "Server is %s" % ( domino_info_states[serverstate[0][0]] ) - else: - state = 0 - infotext = "Server is %s. Domain: %s, Name: %s, %s" \ - % ( domino_info_states[serverstate[0][0]], maildomain, name[0][0], release[0][0] ) - yield state, infotext + yield 0, "Domain: %s" % domain + + yield 0, "Name: %s, %s" % (name, release) check_info['domino_info'] = { "check_function" : check_domino_info, @@ -69,11 +61,11 @@ check_info['domino_info'] = { "service_description" : "Domino Info", "snmp_scan_function" : lambda oid: oid(".1.3.6.1.2.1.1.2.0").startswith(".1.3.6.1.4.1.311.1.1.3") or \ oid(".1.3.6.1.2.1.1.2.0").startswith(".1.3.6.1.4.1.8072.3.1.10"), - "snmp_info" : [ - [ ".1.3.6.1.4.1.334.72.2", [ 2 ] ], # lnNotesServerState - [ ".1.3.6.1.4.1.334.72.1.1.4", [ 8 ] ], # lnMailDomain - [ ".1.3.6.1.4.1.334.72.1.1.6.2", [ 1 ] ], # lnServerName - [ ".1.3.6.1.4.1.334.72.1.1.6.2", [ 4 ] ], # lnServerNotesVersion - ] + "snmp_info" : (".1.3.6.1.4.1.334.72", [ + "2.2", # lnNotesServerState + "1.1.4.8", # lnMailDomain + "1.1.6.2.1", # lnServerName + "1.1.6.2.4", # lnServerNotesVersion + ]), }

7 years, 5 months

4876 FIX mounts: Fixed wrong handling of NFS mounts on Linux which are detected as stale

by Simon Betz

Module: check_mk Branch: master Commit: 66e6473480441a5e7b7ad6808c5f709e775bfc4c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=66e6473480441a… Author: Simon Betz <si(a)mathias-kettner.de> Date: Mon Jun 26 15:54:15 2017 +0200 4876 FIX mounts: Fixed wrong handling of NFS mounts on Linux which are detected as stale Such mounts are marked with '\040(deleted)' und therefore discovered as new services while the related services report {{UNKNOWN - filesystem not mounted}}. This has been fixed. The service now reports {{WARN - Mount point detected as stale}}. Please see https://utcc.utoronto.ca/~cks/space/blog/linux/NFSStaleUnmounting for more information. Change-Id: I03dd6febbaaa7495522319f36acae8e7cb498123 --- .werks/4876 | 20 ++++++++++++++++++++ checks/mounts | 29 ++++++++++++++++++----------- 2 files changed, 38 insertions(+), 11 deletions(-) diff --git a/.werks/4876 b/.werks/4876 new file mode 100644 index 0000000..44692ee --- /dev/null +++ b/.werks/4876 @@ -0,0 +1,20 @@ +Title: mounts: Fixed wrong handling of NFS mounts on Linux which are detected as stale +Level: 1 +Component: checks +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.5.0i1 +Date: 1498484953 + +Such mounts are marked with '\040(deleted)' und therefore discovered +as new services while the related services report +{{UNKNOWN - filesystem not mounted}}. + +This has been fixed. The service now reports +{{WARN - Mount point detected as stale}}. + +Please see +https://utcc.utoronto.ca/~cks/space/blog/linux/NFSStaleUnmounting +for more information. diff --git a/checks/mounts b/checks/mounts index ddac74d..1d7fba4 100644 --- a/checks/mounts +++ b/checks/mounts @@ -24,6 +24,12 @@ # to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, # Boston, MA 02110-1301 USA. +# See https://utcc.utoronto.ca/~cks/space/blog/linux/NFSStaleUnmounting +# Output changes from +# knvmsapprd:/transreorg/sap/trans /transreorg/sap/trans nfs4 rw,relatime,vers=4.0,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,timeo=600,retrans=2,sec=sys,clientaddr=172.24.98.63,local_lock=none,addr=172.24.98.57 0 0 +# to +# knvmsapprd:/transreorg/sap/trans /transreorg/sap/trans\040(deleted) nfs4 rw,relatime,vers=4.0,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,timeo=600,retrans=2,sec=sys,clientaddr=172.24.98.63,local_lock=none,addr=172.24.98.57 0 0 + def inventory_mounts(info): inventory = [] @@ -33,11 +39,11 @@ def inventory_mounts(info): devices.append(dev) opts = options.split(",") opts.sort() - inventory.append( (mp, opts) ) + inventory.append( (mp.replace("\\040(deleted)", ""), opts) ) return inventory -def check_mounts(item, targetopts, info): +def check_mounts(item, targetopts, info): # Ignore options that are allowed to change def should_ignore_option(option): for ignored_option in [ "commit=", "localalloc=", "subvol=", "subvolid=" ]: @@ -46,7 +52,10 @@ def check_mounts(item, targetopts, info): return False for dev, mp, fstype, options, dump, fsck in info: - if item == mp: + if item == mp.replace("\\040(deleted)", ""): + if mp.endswith("\\040(deleted)"): + return 1, "Mount point detected as stale" + opts = options.split(",") # Now compute the exact difference. @@ -61,24 +70,22 @@ def check_mounts(item, targetopts, info): missing.append(o) if not missing and not exceeding: - return (0, "mount options exactly as expected") + return 0, "Mount options exactly as expected" infos = [] if missing: - infos.append("missing: %s" % ",".join(missing)) + infos.append("Missing: %s" % ",".join(missing)) if exceeding: - infos.append("exceeding: %s" % ",".join(exceeding)) + infos.append("Exceeding: %s" % ",".join(exceeding)) infotext = ", ".join(infos) if "ro" in exceeding: - return (2, "filesystem has switched to read-only " - "and is probably corrupted(!!), " + infotext) + return 2, "Filesystem has switched to read-only and is probably corrupted(!!), %s" % infotext # Just warn in other cases - return (1, infotext) - - return (3, "filesystem not mounted") + return 1, infotext + return 3, "Filesystem not mounted" check_info["mounts"] = {

7 years, 5 months

4825 FIX mkbackup: Fixed crash if size of backup is not reported because of a failure

by Marcel Arentz

Module: check_mk Branch: master Commit: 7943989ce12bfcf85736ede9cb1fb22a1d13d18e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7943989ce12bfc… Author: Marcel Arentz <ma(a)mathias-kettner.de> Date: Mon Jun 26 15:28:42 2017 +0200 4825 FIX mkbackup: Fixed crash if size of backup is not reported because of a failure Previously the check crashed if the size has not been reported. This can happen if the backup fails directly from the beginning. This bug has always been in this plugin until now. Change-Id: I8e425d12aa99aa0e7edff9b299f15c7c07a033ff --- .werks/4825 | 12 ++++++++++++ checks/mkbackup | 5 +++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/.werks/4825 b/.werks/4825 new file mode 100644 index 0000000..1166ad6 --- /dev/null +++ b/.werks/4825 @@ -0,0 +1,12 @@ +Title: mkbackup: Fixed crash if size of backup is not reported because of a failure +Level: 1 +Component: checks +Compatible: compat +Edition: cre +Version: 1.5.0i1 +Date: 1498483587 +Class: fix + +Previously the check crashed if the size has not been reported. This can +happen if the backup fails directly from the beginning. This bug has always +been in this plugin until now. diff --git a/checks/mkbackup b/checks/mkbackup index 8eed86a..2ff4449 100644 --- a/checks/mkbackup +++ b/checks/mkbackup @@ -106,8 +106,9 @@ def check_mkbackup(job_state): [ ("backup_duration", duration), ("backup_avgspeed", job_state["bytes_per_second"]) ] - yield 0, "Size: %s" % get_bytes_human_readable(job_state["size"]), \ - [ ("backup_size", job_state["size"]) ] + if "size" in job_state: + yield 0, "Size: %s" % get_bytes_human_readable(job_state["size"]), \ + [ ("backup_size", job_state["size"]) ] next_run = job_state["next_schedule"] if next_run == "disabled":

7 years, 5 months

4875 FIX Fixed graph labeling and unit of active HTTP service

by Simon Betz

Module: check_mk Branch: master Commit: 01b439333b260c6c0fdbbafc8610017d7ad5e553 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=01b439333b260c… Author: Simon Betz <si(a)mathias-kettner.de> Date: Mon Jun 26 15:19:25 2017 +0200 4875 FIX Fixed graph labeling and unit of active HTTP service Change-Id: I00fc3aaff760d28a48bd773def013045a263ca70 --- .werks/4875 | 11 +++++++++++ web/plugins/metrics/check_mk.py | 8 ++++---- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/.werks/4875 b/.werks/4875 new file mode 100644 index 0000000..fc43142 --- /dev/null +++ b/.werks/4875 @@ -0,0 +1,11 @@ +Title: Fixed graph labeling and unit of active HTTP service +Level: 1 +Component: checks +Class: fix +Compatible: compat +Edition: cee +State: unknown +Version: 1.5.0i1 +Date: 1498482913 + + diff --git a/web/plugins/metrics/check_mk.py b/web/plugins/metrics/check_mk.py index af1f2b9..0812c60 100644 --- a/web/plugins/metrics/check_mk.py +++ b/web/plugins/metrics/check_mk.py @@ -3070,9 +3070,9 @@ metric_info["apache_state_keep_alive"] = { "color" : "53/b", } -metric_info["http_bandwidth"] = { - "title" : _("HTTP bandwidth"), - "unit" : "bytes/s", +metric_info["response_size"] = { + "title" : _("Response size"), + "unit" : "bytes", "color" : "53/b", } @@ -3937,7 +3937,7 @@ check_metrics["check_mk_active-mail_loop"] = { check_metrics["check_mk_active-http"] = { "time" : { "name": "response_time" }, - "size" : { "name": "http_bandwidth" }, + "size" : { "name": "response_size" }, } check_metrics["check_mk_active-tcp"] = {

7 years, 5 months

transferred werk 4824 into master

by Marcel Arentz

Module: check_mk Branch: master Commit: 62641d8c4f99c95a4a22446e6749412e00367b2c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=62641d8c4f99c9… Author: Marcel Arentz <ma(a)mathias-kettner.de> Date: Mon Jun 26 15:10:05 2017 +0200 transferred werk 4824 into master Change-Id: I3ea5f558d36d41e59ce3574b437a480f8f4dc55d --- .werks/4824 | 11 +++++++++++ checks/f5_bigip_conns | 8 +++++++- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/.werks/4824 b/.werks/4824 new file mode 100644 index 0000000..b09dd4d --- /dev/null +++ b/.werks/4824 @@ -0,0 +1,11 @@ +Title: f5bigip_conns: Fixed crash if Parameters are at 'No Levels' +Level: 1 +Component: checks +Compatible: compat +Version: 1.5.0i1 +Date: 1498479772 +Class: fix + +2016-11-07 the fix 3939 readded performance data into the output. Since +then the check would crash if the Thresholds for the service has been set to +"No Levels". This has been fixed now. diff --git a/checks/f5_bigip_conns b/checks/f5_bigip_conns index 961993a..5febf54 100644 --- a/checks/f5_bigip_conns +++ b/checks/f5_bigip_conns @@ -88,7 +88,13 @@ def check_f5_bigip_conns(item, params, info): if val == None: infotext += " not configured" else: - warn, crit = params_values[:2] + # The check_parameters are a bit tricky: If thresholds are disabled, + # the value is None; otherwise it's a Tuple. + # TODO: Refactor the check parameter f5_connections and this check plugin! + if params_values == None: + warn, crit = (None, None) + else: + warn, crit = params_values[:2] perfdata.append((perfkey, val, warn, crit)) state, extrainfo, extraperf = check_levels(val, dsname, params_values)

7 years, 5 months

Added a code coverage Makefile target.

by Sven Panne

Module: check_mk Branch: master Commit: 72a2dff8931d0d54ad0dc39b6f3df64e0d4ee3e2 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=72a2dff8931d0d… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Mon Jun 26 14:16:00 2017 +0200 Added a code coverage Makefile target. Change-Id: I5db9382189b116f21ab8a6de0218debf88214b28 --- .gitignore | 1 + livestatus/src/Makefile.am | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 701b3cb..eadf38d 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,4 @@ +*.gcno *.pyc *kate-swp *~ diff --git a/livestatus/src/Makefile.am b/livestatus/src/Makefile.am index ae96155..7e824a2 100644 --- a/livestatus/src/Makefile.am +++ b/livestatus/src/Makefile.am @@ -163,7 +163,7 @@ liblivestatus_a_CXXFLAGS = -fPIC livestatus.o: $(liblivestatus_a_OBJECTS) # Note: libstdc++fs is only available as a static library, so we are lucky - $(CXX) $(LDFLAGS) -shared $^ -o $@ -lstdc++fs -lpthread -static-libstdc++ @BOOST_LDFLAGS@ @BOOST_ASIO_LIB@ + $(CXXLINK) -shared $^ -lstdc++fs -lpthread -static-libstdc++ @BOOST_LDFLAGS@ @BOOST_ASIO_LIB@ # To make sure we can dlopen() our NEB later $(CXX) $(liblivestatus_a_CXXFLAGS) $(CXXFLAGS) -c NagiosMockup.cc -o NagiosMockup.o $(CXX) $(liblivestatus_a_CXXFLAGS) $(CXXFLAGS) NagiosMockup.o $@ -o NagiosMockup

7 years, 5 months

4838 FIX netapp_api_volumes: No longer shows service descriptions with UUIDs

by Andreas Boesl

Module: check_mk Branch: master Commit: d797f5a8efc7a1c1cfd15f41d60a7e24066cb44c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d797f5a8efc7a1… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Mon Jun 26 13:34:44 2017 +0200 4838 FIX netapp_api_volumes: No longer shows service descriptions with UUIDs The datasource program rule for the netapp agent offers an option to skip the performance counters for volumes. When this option was set (default off) the service description changed from a vserver_name.volume_name style to the uuid. This has been fixed. You can now set the counters "off" without the risk of a changed service description. Change-Id: I40c2c67f1f33ebc0766585024c44ed2bf406f6f5 --- .werks/4838 | 14 ++++++++++++++ agents/special/agent_netapp | 20 +++++++++++--------- checks/netapp_api_volumes | 6 +++++- 3 files changed, 30 insertions(+), 10 deletions(-) diff --git a/.werks/4838 b/.werks/4838 new file mode 100644 index 0000000..83227a3 --- /dev/null +++ b/.werks/4838 @@ -0,0 +1,14 @@ +Title: netapp_api_volumes: No longer shows service descriptions with UUIDs +Level: 1 +Component: checks +Compatible: incomp +Edition: cre +Version: 1.5.0i1 +Date: 1498476639 +Class: fix + +The datasource program rule for the netapp agent offers an option to skip +the performance counters for volumes. When this option was set (default off) +the service description changed from a vserver_name.volume_name style +to the uuid. This has been fixed. You can now set the counters "off" +without the risk of a changed service description. diff --git a/agents/special/agent_netapp b/agents/special/agent_netapp index 0722baf..334093d 100755 --- a/agents/special/agent_netapp +++ b/agents/special/agent_netapp @@ -1037,22 +1037,24 @@ try: config_report = [ "volume-space-attributes.size-available", "volume-space-attributes.size-total", "volume-state-attributes.state", + "volume-id-attributes.owning-vserver-name", "volume-id-attributes.name", "volume-id-attributes.node", "volume-id-attributes.msid", "volume-inode-attributes.files-total", "volume-inode-attributes.files-used" ], - config_rename = { "volume-space-attributes.size-available": "size-available", - "volume-space-attributes.size-total" : "size-total", - "volume-state-attributes.state" : "state", - "volume-id-attributes.name" : "name", - "volume-id-attributes.msid" : "msid", - "volume-id-attributes.node" : "node", - "volume-inode-attributes.files-total" : "files-total", - "volume-inode-attributes.files-used" : "files-used" }, + config_rename = { "volume-space-attributes.size-available" : "size-available", + "volume-space-attributes.size-total" : "size-total", + "volume-state-attributes.state" : "state", + "volume-id-attributes.owning-vserver-name" : "vserver_name", + "volume-id-attributes.name" : "name", + "volume-id-attributes.msid" : "msid", + "volume-id-attributes.node" : "node", + "volume-inode-attributes.files-total" : "files-total", + "volume-inode-attributes.files-used" : "files-used" }, extra_info = create_dict(volume_counters, custom_key = [ "instance_uuid" ]), extra_info_report = sum(map(lambda x: ["%s" % x, "nfs_%s" % x, "cifs_%s" % x, "san_%s" % x, "fcp_%s" % x, "iscsi_%s" % x], - sum(map(lambda x: ["read_%s" % x, "write_%s" % x], ["data", "latency", "ops"]), [])), []) + [ "instance_name", "vserver_name" ], + sum(map(lambda x: ["read_%s" % x, "write_%s" % x], ["data", "latency", "ops"]), [])), []) + [ "instance_name" ], skip_missing_config_key = True ) diff --git a/checks/netapp_api_volumes b/checks/netapp_api_volumes index 74d5709..c6e6a41 100644 --- a/checks/netapp_api_volumes +++ b/checks/netapp_api_volumes @@ -52,7 +52,11 @@ def check_netapp_api_volumes(item, params, parsed): volume = parsed.get(item) if not volume: - return 3, "Volume not found in agent output" + # Specific error message for legacy checks with an uuid as item + if len(item.split("-")) > 4: + return 3, "The service description with an UUID is no longer supported. Please do a rediscovery." + else: + return 3, "Volume not found in agent output" if volume.get("state") != "online": return 1, "Volume is %s" % volume.get("state")

7 years, 5 months

← Newer
1
...
5
6
7
8
9
10
11
...
27
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits June 2017