Checkmk git commits June 2017

checkmk-commits@lists.checkmk.com

13 participants
266 discussions

4770 FIX ipmi_sensors: Added performance data for all temperature sensors

by Simon Betz

Module: check_mk Branch: master Commit: 43b8953672f2196685e9c115e30588e9e2981d60 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=43b8953672f219… Author: Simon Betz <si(a)mathias-kettner.de> Date: Tue Jun 6 13:38:32 2017 +0200 4770 FIX ipmi_sensors: Added performance data for all temperature sensors Change-Id: Idc3eac106467133bbb74632e3a376bb413c1d20e --- .werks/4770 | 11 +++++++++++ checks/ipmi_common.include | 3 ++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/.werks/4770 b/.werks/4770 new file mode 100644 index 0000000..9f2f128 --- /dev/null +++ b/.werks/4770 @@ -0,0 +1,11 @@ +Title: ipmi_sensors: Added performance data for all temperature sensors +Level: 1 +Component: checks +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.5.0i1 +Date: 1496749032 + + diff --git a/checks/ipmi_common.include b/checks/ipmi_common.include index d6a71e3..e568fe8 100644 --- a/checks/ipmi_common.include +++ b/checks/ipmi_common.include @@ -95,7 +95,8 @@ def check_ipmi_common_detailed(item, params, data, what, status_txt_mapping): old_perf_val += unit perfdata = [ (item, old_perf_val, warn_high, crit_high) ] - elif what == "freeipmi" and "temperature" in item.lower(): + elif what == "freeipmi" and \ + ("temperature" in item.lower() or "temp" in item.lower()): # Do not save performance data for FANs. This produces # much data and is - in my opinion - useless. perfdata = [ ("value", val, None, crit_high) ]

7 years

4769 FIX saprouter_cert: More robust detection of "not after" value

by Simon Betz

Module: check_mk Branch: master Commit: f9155f62523a6191d913c85a2d1d6fda2c6ff8e0 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f9155f62523a61… Author: Simon Betz <si(a)mathias-kettner.de> Date: Tue Jun 6 13:17:36 2017 +0200 4769 FIX saprouter_cert: More robust detection of "not after" value Change-Id: I6f7d60d4f0070e6e15c64aeb3260a7e80a2fdd72 --- .werks/4769 | 11 +++++++++++ checks/saprouter_cert | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.werks/4769 b/.werks/4769 new file mode 100644 index 0000000..83e0239 --- /dev/null +++ b/.werks/4769 @@ -0,0 +1,11 @@ +Title: saprouter_cert: More robust detection of "not after" value +Level: 1 +Component: checks +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.5.0i1 +Date: 1496747804 + + diff --git a/checks/saprouter_cert b/checks/saprouter_cert index 7e8d5a4..f2dac8a 100644 --- a/checks/saprouter_cert +++ b/checks/saprouter_cert @@ -66,7 +66,7 @@ def parse_saprouter_cert(info): if validity and "NotBefore:" in line: parsed[validity].setdefault("not_before", parse_date(line[-5:-1])) - elif validity and "NotAfter:" in line: + elif validity and ("NotAfter:" in line or "NotAfter" in line): parsed[validity].setdefault("not_after", parse_date(line[-5:-1])) elif "sso for user" == " ".join(line[:3]).lower():

7 years

4053 FIX Summary line in BI availability moved when sorting. It is fixed now.

by Roland Halbig

Module: check_mk Branch: master Commit: 2ac28f509d5177565a09fa2c4db514d297cd7bce URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2ac28f509d5177… Author: Roland Halbig <rh(a)mathias-kettner.de> Date: Tue Jun 6 12:09:33 2017 +0200 4053 FIX Summary line in BI availability moved when sorting. It is fixed now. Change-Id: I1eee0167aaaf2145b2935251053c7e27c704f245 --- .werks/4053 | 10 ++++++++++ web/plugins/views/availability.py | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/.werks/4053 b/.werks/4053 new file mode 100644 index 0000000..4bd63e1 --- /dev/null +++ b/.werks/4053 @@ -0,0 +1,10 @@ +Title: Summary line in BI availability moved when sorting. It is fixed now. +Level: 1 +Component: multisite +Compatible: compat +Edition: cre +Version: 1.4.0p2 +Date: 1496743605 +Class: fix + + diff --git a/web/plugins/views/availability.py b/web/plugins/views/availability.py index b7e3cb5..aa905ce 100644 --- a/web/plugins/views/availability.py +++ b/web/plugins/views/availability.py @@ -422,7 +422,7 @@ def render_availability_table(group_title, availability_table, what, avoptions): table.cell(title, text, css=css, help=help) if "summary" in av_table: - table.row(css="summary") + table.row(css="summary", fixed=True) if show_urls: table.cell("", "") # Empty cell in URLs column table.cell("", _("Summary"), css="heading")

7 years

4707 FIX netapp_api_vf_stats: improved computation of CPU utilization, now showing number of processors

by Andreas Boesl

Module: check_mk Branch: master Commit: bc45e8874688fa112da02717fd40ad93faf7c582 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=bc45e8874688fa… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Tue Jun 6 11:40:50 2017 +0200 4707 FIX netapp_api_vf_stats: improved computation of CPU utilization, now showing number of processors Change-Id: I1294a41f11ab47f2aaf2d13b7b7eea4344ffc5f6 --- .werks/4707 | 11 +++++++++++ checks/netapp_api_vf_stats | 16 +++++++++++++--- 2 files changed, 24 insertions(+), 3 deletions(-) diff --git a/.werks/4707 b/.werks/4707 new file mode 100644 index 0000000..2b313cf --- /dev/null +++ b/.werks/4707 @@ -0,0 +1,11 @@ +Title: netapp_api_vf_stats: improved computation of CPU utilization, now showing number of processors +Level: 1 +Component: checks +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.5.0i1 +Date: 1496741969 + + diff --git a/checks/netapp_api_vf_stats b/checks/netapp_api_vf_stats index 27cc0fa..7dc86fe 100644 --- a/checks/netapp_api_vf_stats +++ b/checks/netapp_api_vf_stats @@ -41,9 +41,17 @@ def check_netapp_api_vf_stats(item, params, parsed): now = time.time() cpu_busy = int(vf["vfiler_cpu_busy"]) - ticks_per_sec = get_rate("netapp_api_vf_stats.cpu_util.%s" % item, now, cpu_busy, onwrap=RAISE) - cpusecs_per_sec = ticks_per_sec / 1000.0 / 1000 / 10000 - used_perc = 100.0 * cpusecs_per_sec + ticks_per_sec = get_rate("netapp_api_vf_stats.cpu_busy", now, cpu_busy, onwrap=RAISE) + + cpu_busy_base = int(vf["vfiler_cpu_busy_base"]) + ticks_per_sec_base = get_rate("netapp_api_vf_stats.cpu_busy_base", now, cpu_busy_base, onwrap=RAISE) + + if ticks_per_sec == 0: + raise MKCounterWrapped("Counter wrapped") + + num_processors = float(vf.get("num_processors", 1)) + + used_perc = ticks_per_sec / num_processors / ticks_per_sec_base * 100 # Due to timeing invariancies the measured level can become > 100%. # This makes users unhappy, so cut it off. @@ -54,6 +62,7 @@ def check_netapp_api_vf_stats(item, params, parsed): state, infotext, perfdata = check_cpu_util(used_perc, params, now).next() perfdata[0] = perfdata[0][:5] + infotext += ", Num Processors: %d" % num_processors return state, infotext, perfdata @@ -96,3 +105,4 @@ check_info["netapp_api_vf_stats.traffic"] = { 'service_description' : 'Traffic vFiler %s', } +

7 years

Fixed speed calculation for tplink switches

by Simon Betz

Module: check_mk Branch: master Commit: 3281c06ad4c972372fb3db1f2c948ecdea3e6ed3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3281c06ad4c972… Author: Simon Betz <si(a)mathias-kettner.de> Date: Tue Jun 6 10:46:12 2017 +0200 Fixed speed calculation for tplink switches Change-Id: Iabaf74602f481eeb77bafef2075415abf891ae19 --- checks/if.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/checks/if.include b/checks/if.include index 0a869ef..f1efe10 100644 --- a/checks/if.include +++ b/checks/if.include @@ -341,7 +341,7 @@ def inventory_if_common(info, has_nodeinfo = False): # Fix bug in TP Link switches ifSpeed = saveint(ifSpeed) - if ifSpeed > 9000000 * 100 * 1000: + if ifSpeed > 9 * 1000 * 1000 * 1000 * 1000: ifSpeed /= 1000000 # compute item now - also for unmonitored ports - in order to see if it is unique.

7 years

Reserved 1 bug IDS

by Sven Rueß

Module: check_mk Branch: master Commit: 114becf6dc7c9b8c074c41d733f9277bf4167192 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=114becf6dc7c9b… Author: Sven Rueß <sr(a)mathias-kettner.de> Date: Fri Jun 2 16:34:57 2017 +0200 Reserved 1 bug IDS Change-Id: I0a37ff13d948b8a989fe7c35a6b821f9e7c81798 --- .bugs/first_free | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.bugs/first_free b/.bugs/first_free index 5afe26c..537c182 100644 --- a/.bugs/first_free +++ b/.bugs/first_free @@ -1 +1 @@ -2925 +2926

7 years

ToDo Agent Bakery

by Sven Rueß

Module: check_mk Branch: master Commit: 265281578a59b840caf42aefc106974afea98455 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=265281578a59b8… Author: Sven Rueß <sr(a)mathias-kettner.de> Date: Fri Jun 2 16:38:10 2017 +0200 ToDo Agent Bakery Change-Id: I3233911a7e1f247e0b321fc9510daf73e3081846 --- .bugs/2925 | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.bugs/2925 b/.bugs/2925 new file mode 100644 index 0000000..692e0e8 --- /dev/null +++ b/.bugs/2925 @@ -0,0 +1,11 @@ +Title: Agent Bakery: Selection for package creation +Component: wato +State: open +Date: 2017-06-02 16:35:15 +Targetversion: 1.5.0 +Class: todo + +In Agent Bakery are all installation packages create for one installation group. +Customers want to choose, which packages should be created. +If a customer is only using Windows and debian based systems, RPM and TGZ is not needed. +Make a configuration option, where the customer can choose, which packages will be created.

7 years

4706 FIX Fixed broken upload of snmp mibs ( cannot import name defaultMibPackages)

by Andreas Boesl

Module: check_mk Branch: master Commit: becad1bc22064ed7287aeec5b086e2d4edf6c010 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=becad1bc22064e… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Fri Jun 2 16:02:10 2017 +0200 4706 FIX Fixed broken upload of snmp mibs (cannot import name defaultMibPackages) Change-Id: Id59621ca0bf07bcb4cfe1522c9a462585e9bee19 --- .werks/4706 | 11 +++++++++++ web/plugins/wato/mkeventd.py | 5 ++++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/.werks/4706 b/.werks/4706 new file mode 100644 index 0000000..640ac78 --- /dev/null +++ b/.werks/4706 @@ -0,0 +1,11 @@ +Title: Fixed broken upload of snmp mibs (cannot import name defaultMibPackages) +Level: 1 +Component: ec +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.5.0i1 +Date: 1496412087 + + diff --git a/web/plugins/wato/mkeventd.py b/web/plugins/wato/mkeventd.py index 777b639..f5b2f63 100644 --- a/web/plugins/wato/mkeventd.py +++ b/web/plugins/wato/mkeventd.py @@ -2048,11 +2048,14 @@ def validate_and_compile_mib(mibname, content): from pysmi.searcher.pyfile import PyFileSearcher from pysmi.writer.pyfile import PyFileWriter from pysmi.reader.localfile import FileReader - from pysmi.codegen.pysnmp import PySnmpCodeGen, baseMibs, defaultMibPackages + from pysmi.codegen.pysnmp import PySnmpCodeGen from pysmi.writer.callback import CallbackWriter from pysmi.reader.callback import CallbackReader from pysmi.searcher.stub import StubSearcher from pysmi.error import PySmiError + + defaultMibPackages = PySnmpCodeGen.defaultMibPackages + baseMibs = PySnmpCodeGen.baseMibs except ImportError, e: raise Exception(_('You are missing the needed pysmi python module (%s).') % e)

7 years

4705 FIX Fixed broken flexible notifications configuration

by Andreas Boesl

Module: check_mk Branch: master Commit: 668a8200196fff87f4dbf25b9ccf75e70deb1e5d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=668a8200196fff… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Fri Jun 2 14:03:14 2017 +0200 4705 FIX Fixed broken flexible notifications configuration The user configuration page no longer raises an exception upon <i>Save</i> when flexible notifications are enabled. Change-Id: I714a94d364b5af543a236b7d6961de8dc78bf82b --- .werks/4705 | 12 ++++ web/htdocs/wato.py | 190 ++------------------------------------------------ web/htdocs/watolib.py | 185 +++++++++++++++++++++++++++++++++++++++++++++++- 3 files changed, 199 insertions(+), 188 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=668a820019…

7 years

4691 FIX Make Smart Ping more robust

by Sven Panne

Module: check_mk Branch: master Commit: acb49b1854c7ed9a6e1c4754d25955775954c679 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=acb49b1854c7ed… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Fri Jun 2 13:31:17 2017 +0200 4691 FIX Make Smart Ping more robust In some environments, Smart Ping can be confronted with esoteric link-layer header types and non-IPv4 packets. This could lead to incorrectly reported Smart Pings, which are normally harmless, but confusing in the presence of logging. This has been fixed. Change-Id: Id73c8e5b9cdb2d0a030f1b1702253b123078762f --- .werks/4691 | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.werks/4691 b/.werks/4691 new file mode 100644 index 0000000..97e8ba1 --- /dev/null +++ b/.werks/4691 @@ -0,0 +1,13 @@ +Title: Make Smart Ping more robust +Level: 1 +Component: core +Compatible: compat +Edition: cee +Version: 1.5.0i1 +Date: 1496402879 +Class: fix + +In some environments, Smart Ping can be confronted with esoteric link-layer +header types and non-IPv4 packets. This could lead to incorrectly reported +Smart Pings, which are normally harmless, but confusing in the presence of +logging. This has been fixed.

7 years

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits June 2017