Checkmk git commits May 2017

checkmk-commits@lists.checkmk.com

12 participants
254 discussions

by Sven Rueß

Module: check_mk Branch: master Commit: cfee39d9e812a211d9ce92f737f4434465347777 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=cfee39d9e812a2… Author: Sven Rueß <sr(a)mathias-kettner.de> Date: Fri May 26 16:26:16 2017 +0200 New Bug with icon upload Change-Id: I330978b41cbe83acd462a086ce504d30bdba8c0c --- .bugs/2921 | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/.bugs/2921 b/.bugs/2921 new file mode 100644 index 0000000..1c237df --- /dev/null +++ b/.bugs/2921 @@ -0,0 +1,15 @@ +Title: Icon upload saves icon with full path +Component: multisite +State: open +Date: 2017-05-26 16:20:45 +Targetversion: 1.2.8 +Class: bug + +If a customers uploads its own icons in 1.2.8p18, all icons will be save with the local upload path as +file name. + +For example: +C:\Users\Username\Documents\Icons\service.png will be stored in Check_MK like +~/local/share/check_mk/web/htdocs/images/icon/C:\\Users\\Username\\Documents\\Icons\\service.png + +Those icons are not shown to the customer.

7 years, 3 months

Reserved 1 bug IDS

by Sven Rueß

Module: check_mk Branch: master Commit: c05244f843b3cadb10bfa7970c35affdaa580674 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c05244f843b3ca… Author: Sven Rueß <sr(a)mathias-kettner.de> Date: Fri May 26 16:20:16 2017 +0200 Reserved 1 bug IDS Change-Id: I5c11b13c4e6a51f3f0b4ea50c211c92fc599fb21 --- .bugs/first_free | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.bugs/first_free b/.bugs/first_free index abe0cf8..d0b1c49 100644 --- a/.bugs/first_free +++ b/.bugs/first_free @@ -1 +1 @@ -2921 +2922

7 years, 3 months

Ignore pylint warning: wrong variable type detected

by Lars Michelsen

Module: check_mk Branch: master Commit: d1de0857478ec18a766a57bf83919afecb01bc4b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d1de0857478ec1… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed May 24 16:35:30 2017 +0200 Ignore pylint warning: wrong variable type detected Change-Id: Id667af19382d8accd60cbf2b19ce8b119f348a82 --- web/htdocs/htmllib.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/htdocs/htmllib.py b/web/htdocs/htmllib.py index 937e506..210d9df 100644 --- a/web/htdocs/htmllib.py +++ b/web/htdocs/htmllib.py @@ -2613,7 +2613,7 @@ class html(HTMLGenerator, RequestHandler): counts = self.get_button_counts() weights = counts.items() weights.sort(cmp = lambda a,b: cmp(a[1], b[1])) - best = dict(weights[-bestof:]) + best = dict(weights[-bestof:]) # pylint: disable=invalid-unary-operand-type if id_ not in best: display="none" self.context_button_hidden = True

7 years, 3 months

4594 FIX snmp_uptime: Fixed uptime

by Simon Betz

Module: check_mk Branch: master Commit: 9a8cf64dcb9f4990569a32d10a245e7367d7dcea URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=9a8cf64dcb9f49… Author: Simon Betz <si(a)mathias-kettner.de> Date: Fri May 26 09:08:40 2017 +0200 4594 FIX snmp_uptime: Fixed uptime Change-Id: I3feae45fcac32971be69a9f37f7d8de4de61c3ee --- .werks/4594 | 12 ++++++++++++ checks/snmp_uptime | 13 +++++++++++-- 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/.werks/4594 b/.werks/4594 new file mode 100644 index 0000000..97576dc --- /dev/null +++ b/.werks/4594 @@ -0,0 +1,12 @@ +Title: snmp_uptime: Fixed uptime +Level: 1 +Component: checks +Compatible: compat +Edition: cre +Version: 1.5.0i1 +Date: 1493975963 +Class: fix + +On Linux appliances {{.1.3.6.1.2.1.1.3.0}} means uptime of snmpd and +{{.1.3.6.1.2.1.25.1.1.0}} the system uptime. Use second value if it +is available. diff --git a/checks/snmp_uptime b/checks/snmp_uptime index d123e70..d4bf2ee 100644 --- a/checks/snmp_uptime +++ b/checks/snmp_uptime @@ -29,8 +29,12 @@ def inventory_snmp_uptime(info): if len(info) > 0 and len(info[0]) >= 1: return [ (None, {}) ] + def check_snmp_uptime(checktype, params, info): - uptime = parse_snmp_uptime(info[0][0]) + if info[0][1]: + uptime = parse_snmp_uptime(info[0][1]) + else: + uptime = parse_snmp_uptime(info[0][0]) return check_uptime_seconds(params, uptime) @@ -39,7 +43,12 @@ check_info["snmp_uptime"] = { 'inventory_function' : inventory_snmp_uptime, 'service_description' : 'Uptime', 'has_perfdata' : True, - 'snmp_info' : ('.1.3.6.1.2.1.1', ['3.0']), # DISMAN-EVENT-MIB::sysUpTime + # On Linux appliances: .1.3.6.1.2.1.1.3.0 means uptime of snmpd + # .1.3.6.1.2.1.25.1.1.0 means system uptime + 'snmp_info' : ('.1.3.6.1.2.1', [ + '1.3', # DISMAN-EVENT-MIB::sysUpTime + '25.1.1', # HOST-RESOURCES-MIB::hrSystemUptime + ]), 'snmp_scan_function' : lambda oid: oid(".1.3.6.1.2.1.1.1.0") not in [ None, "" ], 'group' : 'uptime', 'includes' : [ 'uptime.include' ],

7 years, 3 months

New Web-API features: Manage hosttags

by Andreas Boesl

Module: check_mk Branch: master Commit: 86cdd3c7aa140f63ce7627e4321e9b17bb5d3cc0 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=86cdd3c7aa140f… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Mon May 15 09:28:59 2017 +0200 New Web-API features: Manage hosttags Change-Id: Ide72c09a444f28792c3f25f7924804700c69d2d2 --- .werks/4700 | 28 +++ web/htdocs/wato.py | 583 ++++++++++++++++++++----------------------- web/htdocs/watolib.py | 431 +++++++++++++++++++++++++++++++- web/plugins/webapi/webapi.py | 315 +++++++++++++++-------- 4 files changed, 943 insertions(+), 414 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=86cdd3c7aa…

7 years, 3 months

Localization/Escaping: Fixed lynter errors.

by Roland Halbig

Module: check_mk Branch: master Commit: 889fae438cf998d3871bbbc9a78fdbadceb1c74e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=889fae438cf998… Author: Roland Halbig <rh(a)mathias-kettner.de> Date: Wed May 24 16:26:55 2017 +0200 Localization/Escaping: Fixed lynter errors. Change-Id: Iea6c010887c115bed17ef94d64f5850819cd186c --- web/htdocs/crash_reporting.py | 17 ++++++++--------- web/htdocs/htmllib.py | 4 ++-- web/htdocs/wato.py | 28 +++++++++++++++------------- web/htdocs/watolib.py | 4 ++-- web/htdocs/werks.py | 2 +- web/plugins/wato/check_mk_configuration.py | 4 ++-- web/plugins/wato/inventory.py | 4 ++-- 7 files changed, 32 insertions(+), 31 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=889fae438c…

7 years, 3 months

Added escaping checks to localization lynting.

by Roland Halbig

Module: check_mk Branch: master Commit: 51b1a7443dc1024f8b936fd7d1600fef923f553f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=51b1a7443dc102… Author: Roland Halbig <rh(a)mathias-kettner.de> Date: Wed May 24 09:18:50 2017 +0200 Added escaping checks to localization lynting. Change-Id: I452e71717cf2367d79742d258b338a60a99bea67 --- tests/pylint/pylintrc | 4 +- tests/testlib/pylint_checker_localization.py | 231 +++++++++++++++++++++++++++ tests/testlib/pylint_checker_test.py | 81 ---------- web/htdocs/htmllib.py | 4 +- 4 files changed, 235 insertions(+), 85 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=51b1a7443d…

7 years, 3 months

Refactoring: replaced attrencodes.

by Roland Halbig

Module: check_mk Branch: master Commit: 62db5fffba7f481af72c6ac56988e56df37a2690 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=62db5fffba7f48… Author: Roland Halbig <rh(a)mathias-kettner.de> Date: Thu Apr 20 15:02:26 2017 +0200 Refactoring: replaced attrencodes. Change-Id: I0396aff0931990807754bdcc886343f7f5466493 --- tags.py | 17 + tags.txt | 5093 ++++++++++++++++++++++++++++ tests/pylint/pylintrc | 1 + tests/testlib/pylint_checker_test.py | 81 + tests/testlib/pylint_checker_wrong_i18n.py | 1 + tests/web/test_escaping.py | 8 + web/auto_refactor.py | 297 ++ web/htdocs/backup.py | 10 +- web/htdocs/htmllib.py | 31 +- web/htdocs/index.py | 4 +- web/htdocs/key_mgmt.py | 6 +- web/htdocs/logwatch.py | 18 +- web/htdocs/notify.py | 7 +- web/htdocs/pagetypes.py | 12 +- web/htdocs/wato.py | 109 +- web/htdocs/watolib.py | 2 +- web/plugins/dashboard/dashlets.py | 2 +- web/plugins/sidebar/shipped.py | 3 +- web/plugins/views/availability.py | 2 +- web/plugins/views/inventory.py | 4 +- web/plugins/wato/check_parameters.py | 2 +- web/plugins/wato/mkeventd.py | 66 +- web/refactored_file.py | 894 +++++ 23 files changed, 6529 insertions(+), 141 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=62db5fffba…

7 years, 3 months

removed useless print command

by Marcel Arentz

Module: check_mk Branch: master Commit: 91a85b428a069b240e57145309d51dc972fd96e3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=91a85b428a069b… Author: Marcel Arentz <ma(a)mathias-kettner.de> Date: Wed May 24 16:30:30 2017 +0200 removed useless print command Change-Id: Ife8fa710d2851919f70d039175989d3ca801f49d --- checks/f5_bigip_conns | 1 - 1 file changed, 1 deletion(-) diff --git a/checks/f5_bigip_conns b/checks/f5_bigip_conns index 086407d..961993a 100644 --- a/checks/f5_bigip_conns +++ b/checks/f5_bigip_conns @@ -38,7 +38,6 @@ def inventory_f5_bigip_conns(info): def check_f5_bigip_conns(item, params, info): - print info # Connection rate now = time.time() total_native_compat_rate = 0

7 years, 3 months

4743 FIX f5_bigip_conns: Fixed crash if empty values

by Marcel Arentz

Module: check_mk Branch: master Commit: 6fe18e1d6a64c628d506d32fc1148946d2c523ad URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=6fe18e1d6a64c6… Author: Marcel Arentz <ma(a)mathias-kettner.de> Date: Wed May 24 16:27:21 2017 +0200 4743 FIX f5_bigip_conns: Fixed crash if empty values Change-Id: I1bbacff538da617f962a8cdb34e4105cc80764e4 --- .werks/4743 | 10 ++++++++++ checks/f5_bigip_conns | 20 ++++++++++++++++---- 2 files changed, 26 insertions(+), 4 deletions(-) diff --git a/.werks/4743 b/.werks/4743 new file mode 100644 index 0000000..10e163e --- /dev/null +++ b/.werks/4743 @@ -0,0 +1,10 @@ +Title: f5_bigip_conns: Fixed crash if empty values +Level: 1 +Component: checks +Compatible: compat +Edition: cre +Version: 1.5.0i1 +Date: 1495636008 +Class: fix + + diff --git a/checks/f5_bigip_conns b/checks/f5_bigip_conns index f9dc011..086407d 100644 --- a/checks/f5_bigip_conns +++ b/checks/f5_bigip_conns @@ -38,17 +38,29 @@ def inventory_f5_bigip_conns(info): def check_f5_bigip_conns(item, params, info): + print info # Connection rate now = time.time() total_native_compat_rate = 0 conns_dict = {} for line in info: - native_conn_rate = get_rate("native", now, int(line[2])) - compat_conn_rate = get_rate("compat", now, int(line[3])) - total_native_compat_rate += native_conn_rate + compat_conn_rate + if line[2] != "": + native_conn_rate = get_rate("native", now, int(line[2])) + else: + native_conn_rate = 0 + + if line[3] != "": + compat_conn_rate = get_rate("compat", now, int(line[3])) + else: + compat_conn_rate = 0 - stat_http_req_rate = get_rate("stathttpreqs", now, int(line[4])) + total_native_compat_rate += native_conn_rate + compat_conn_rate + + if line[4] != "": + stat_http_req_rate = get_rate("stathttpreqs", now, int(line[4])) + else: + stat_http_req_rate = None if line[0] != "": conns_dict.setdefault("total", 0)

7 years, 3 months

← Newer
1
2
3
4
5
6
7
8
...
26
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits May 2017