Checkmk git commits April 2017

checkmk-commits@lists.checkmk.com

11 participants
159 discussions

Corrected component/category of werk #8328

by Marcel Schulte

Module: check_mk Branch: master Commit: 07f90bf7d48a76658463cf6dd0139e84c12d9515 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=07f90bf7d48a76… Author: Marcel Schulte <ms(a)mathias-kettner.de> Date: Tue Apr 4 21:14:08 2017 +0200 Corrected component/category of werk #8328 Change-Id: If75e9da1648d50b6a824586a0f79f1ba06b52f95 --- .werks/8328 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.werks/8328 b/.werks/8328 index a57c0d3..49b5713 100644 --- a/.werks/8328 +++ b/.werks/8328 @@ -1,7 +1,7 @@ Title: windows textfiles can now be configured with tags Level: 1 Edition: cee -Component: checks +Component: agents Compatible: compat Version: 1.4.0i1 Date: 1463128563

7 years, 5 months

4468 FIX mk_logwatch.exe: added missing executable for recently converted linux mk_logwatch

by Andreas Boesl

Module: check_mk Branch: master Commit: e9fc3f87c168b455e5b1bbca8ce1bd922c8c7756 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e9fc3f87c168b4… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Tue Apr 4 16:38:37 2017 +0200 4468 FIX mk_logwatch.exe: added missing executable for recently converted linux mk_logwatch Change-Id: I46790971e93bc299280d36e0d744ccdd19f0d9bc --- .werks/4468 | 10 ++++++++ agents/windows/frozen_binaries/Makefile | 41 ++++++++++++++++++++++++++++++++ agents/windows/plugins/mk_logwatch.exe | Bin 0 -> 4555413 bytes 3 files changed, 51 insertions(+) diff --git a/.werks/4468 b/.werks/4468 new file mode 100644 index 0000000..3c799a8 --- /dev/null +++ b/.werks/4468 @@ -0,0 +1,10 @@ +Title: mk_logwatch.exe: added missing executable for recently converted linux mk_logwatch +Level: 1 +Component: checks +Compatible: compat +Edition: cre +Version: 1.5.0i1 +Date: 1491316639 +Class: fix + + diff --git a/agents/windows/frozen_binaries/Makefile b/agents/windows/frozen_binaries/Makefile new file mode 100644 index 0000000..1cbbc32 --- /dev/null +++ b/agents/windows/frozen_binaries/Makefile @@ -0,0 +1,41 @@ +.PHONY: clean + +build: mk_logwatch.exe + +include pyinstaller-deps.make + +mk_logwatch.exe: src/python-$(PYTHON_VERSION).msi $(PYTHON_PACKAGES) src/vcredist_x86.exe $(PLUGINS_DIR)/mk_logwatch + mkdir $(BUILD_DIR) ; \ + cd $(BUILD_DIR) ; \ + cp -pr $(CURDIR)/src/* . ; \ + cd $(BUILD_DIR) ; cabextract vcredist_x86.exe + cd $(BUILD_DIR) ; cabextract vc_red.cab + cd $(BUILD_DIR) ; export WINEPREFIX=$(BUILD_DIR) ; \ + wine vcredist_x86.exe /qb ; \ + wine msiexec /qn /i python-$(PYTHON_VERSION).msi ; \ + mv msvcr90.dll*VC90_CRT_x86* drive_c/Python27/msvcr90.dll ; \ + mv msvcp90.dll*VC90_CRT_x86* drive_c/Python27/msvcp90.dll ; \ + mv msvcm90.dll*VC90_CRT_x86* drive_c/Python27/msvcm90.dll ; \ + mv manifest*VC90_CRT_x86* drive_c/Python27/Microsoft.VC90.CRT.manifest ; \ + cp -r pip drive_c ; \ + cd drive_c/pip ; \ + wine c:\\Python27\\python.exe -m pip install --no-index --find-links="c:\\pip" * ; \ + mkdir $(BUILD_DIR)/drive_c/compile ; \ + cp $(PLUGINS_DIR)/mk_logwatch $(BUILD_DIR)/drive_c/compile/mk_logwatch.py ; \ + cd $(BUILD_DIR)/drive_c/compile ; \ + wine c:\\Python27\\Scripts\\pyinstaller.exe \ + --clean \ + --onefile \ + --upx-dir="C:\\upx" \ + --log-level=INFO \ + mk_logwatch.py ; \ + if [ ! -e dist/mk_logwatch.exe ] ; \ + then \ + echo "ERROR: Failed to create venv_wine/drive_c/compile/dist/mk_logwatch.exe" ; \ + exit 1 ; \ + fi ; + cp $(BUILD_DIR)/drive_c/compile/dist/mk_logwatch.exe ../plugins + rm -rf $(BUILD_DIR) + +clean: + [ ! -d $(BUILD_DIR) ] || rm -rf $(BUILD_DIR) diff --git a/agents/windows/plugins/mk_logwatch.exe b/agents/windows/plugins/mk_logwatch.exe new file mode 100755 index 0000000..1f18d82 Binary files /dev/null and b/agents/windows/plugins/mk_logwatch.exe differ

7 years, 5 months

Fixed rpath length limitation issue in fake version for tests

by Lars Michelsen

Module: check_mk Branch: master Commit: e18c709be14f892d517571b0172fac0134223325 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e18c709be14f89… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Apr 4 14:36:40 2017 +0200 Fixed rpath length limitation issue in fake version for tests Change-Id: I4a809c3e9c2612d4ca6bf07248084936f2817919 --- tests/testlib/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/testlib/__init__.py b/tests/testlib/__init__.py index 179aa3b..8be7f85 100644 --- a/tests/testlib/__init__.py +++ b/tests/testlib/__init__.py @@ -340,7 +340,7 @@ class Site(object): raise Exception("Failed to set new version to bin/omd") if os.system("sudo chrpath -r %s/lib %s/bin/python" % - (self.version.version_path(), self.version.version_path())) >> 8 != 0: + (self.root, self.version.version_path())) >> 8 != 0: raise Exception("Failed to set new version to bin/python")

7 years, 5 months

Tests with fake version: Also update version in python path

by Lars Michelsen

Module: check_mk Branch: master Commit: 36528ef7b5104f8412cb142bb465416375f7da91 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=36528ef7b5104f… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Apr 4 13:40:30 2017 +0200 Tests with fake version: Also update version in python path Change-Id: Ib78af96eaf22eeb1a83fa7c3a36cb28165a48859 --- tests/testlib/__init__.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/testlib/__init__.py b/tests/testlib/__init__.py index 8e25b9f..179aa3b 100644 --- a/tests/testlib/__init__.py +++ b/tests/testlib/__init__.py @@ -339,6 +339,10 @@ class Site(object): (src_version, new_version_name, self.version.version_path())) >> 8 != 0: raise Exception("Failed to set new version to bin/omd") + if os.system("sudo chrpath -r %s/lib %s/bin/python" % + (self.version.version_path(), self.version.version_path())) >> 8 != 0: + raise Exception("Failed to set new version to bin/python") + def _update_with_f12_files(self): paths = [

7 years, 5 months

Tests: Added new dependency

by Lars Michelsen

Module: check_mk Branch: master Commit: 8c5d6f158801dc10ad893ebfc23c74cf257f8a42 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8c5d6f158801dc… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Apr 4 13:41:09 2017 +0200 Tests: Added new dependency Change-Id: Id71d93167c783c18acb9bdfa29f25b09413b07c9 --- tests/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/Makefile b/tests/Makefile index 4675a01..a7b19ec 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -47,7 +47,8 @@ test-bandit-ci: setup: sudo apt-get install \ python-pip \ - python-lxml + python-lxml \ + chrpath sudo pip install --upgrade pip sudo pip install --upgrade \ pytest \

7 years, 5 months

4433 FIX Fixed freshness and staleness for always-up and cluster hosts.

by Sven Panne

Module: check_mk Branch: master Commit: 5e690cc6aafac26d7ee7258bac9286b4470e8165 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5e690cc6aafac2… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Tue Apr 4 13:24:29 2017 +0200 4433 FIX Fixed freshness and staleness for always-up and cluster hosts. Host which should be considered always-up and cluster hosts had wrong freshness and staleness values: They were effectively only checked once, but never again, so they were considered unfresh and stale after some time. This has been fixed. Change-Id: I13a3319e5832eb80a6faec54bad280349107c7b5 --- .werks/4433 | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.werks/4433 b/.werks/4433 new file mode 100644 index 0000000..de8a7ff --- /dev/null +++ b/.werks/4433 @@ -0,0 +1,13 @@ +Title: Fixed freshness and staleness for always-up and cluster hosts. +Level: 1 +Component: core +Compatible: compat +Edition: cee +Version: 1.5.0i1 +Date: 1491304933 +Class: fix + +Host which should be considered always-up and cluster hosts had wrong +freshness and staleness values: They were effectively only checked once, but +never again, so they were considered unfresh and stale after some time. +This has been fixed.

7 years, 5 months

GUI crawl: Fix permission issue when saving new result files

by Lars Michelsen

Module: check_mk Branch: master Commit: db56c55b3f4acec14a0aac9ff6d5f9af92ca82d2 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=db56c55b3f4ace… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Apr 4 12:12:05 2017 +0200 GUI crawl: Fix permission issue when saving new result files Change-Id: Ibbd6bcce2676b001abae555ad92fc37be74a9241 --- tests/web/test_crawl.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/web/test_crawl.py b/tests/web/test_crawl.py index 4e372b0..9ad3119 100644 --- a/tests/web/test_crawl.py +++ b/tests/web/test_crawl.py @@ -393,7 +393,8 @@ class TestCrawler(object): ("var/log/apache/error_log", self.apache_error_log_file()), ]: if self.site.file_exists(site_path): - open(test_path, "w").write(self.site.read_file(site_path)) + open(test_path+".tmp", "w").write(self.site.read_file(site_path)) + os.rename(test_path+".tmp", test_path) pytest.fail("Crawled %d URLs in %d seconds. Failures:\n%s" % (len(self.visited), time.time() - self.started, "\n".join(self.errors)))

7 years, 5 months

4581 FIX postgres_stats: Fixed confusion of VACUUM and ANALYSE timestamp in agent plugin

by Simon Betz

Module: check_mk Branch: master Commit: f8831b8ebffa1971660bb8bd939e3414d3be82ab URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f8831b8ebffa19… Author: Simon Betz <si(a)mathias-kettner.de> Date: Tue Apr 4 11:46:28 2017 +0200 4581 FIX postgres_stats: Fixed confusion of VACUUM and ANALYSE timestamp in agent plugin Change-Id: Icd7ace1e8ff2b6bd29c97d3e96ffee9d54a3dbc5 --- .werks/4581 | 11 +++++++++++ agents/plugins/mk_postgres | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.werks/4581 b/.werks/4581 new file mode 100644 index 0000000..9870269 --- /dev/null +++ b/.werks/4581 @@ -0,0 +1,11 @@ +Title: postgres_stats: Fixed confusion of VACUUM and ANALYSE timestamp in agent plugin +Level: 1 +Component: checks +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.5.0i1 +Date: 1491299038 + + diff --git a/agents/plugins/mk_postgres b/agents/plugins/mk_postgres index 0db8504..77837d8 100755 --- a/agents/plugins/mk_postgres +++ b/agents/plugins/mk_postgres @@ -93,7 +93,7 @@ FIRST="" for db in $DATABASES ; do LASTVACUUM="$(echo "BEGIN;SET statement_timeout=30000;COMMIT;SELECT current_database() AS datname, nspname AS sname, relname AS tname, CASE WHEN v IS NULL THEN -1 ELSE round(extract(epoch FROM v)) END AS vtime, - CASE WHEN g IS NULL THEN -1 ELSE round(extract(epoch FROM v)) END AS atime + CASE WHEN g IS NULL THEN -1 ELSE round(extract(epoch FROM g)) END AS atime FROM (SELECT nspname, relname, GREATEST(pg_stat_get_last_vacuum_time(c.oid), pg_stat_get_last_autovacuum_time(c.oid)) AS v, GREATEST(pg_stat_get_last_analyze_time(c.oid), pg_stat_get_last_autoanalyze_time(c.oid)) AS g FROM pg_class c, pg_namespace n

7 years, 5 months

4432 FIX Avoid starvation of normal checks by real-time checks

by Sven Panne

Module: check_mk Branch: master Commit: 7c7139818f674408ce6854fd2a850d7ea5e407c4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7c7139818f6744… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Tue Apr 4 11:02:22 2017 +0200 4432 FIX Avoid starvation of normal checks by real-time checks Real-time checks could easily starvate normal checks, because they prevented scheduling of the Check_MK agent with a high probability. This has been fixed now. Change-Id: I7ec883906857a1632dc92c44e386b358bab2630b --- .werks/4432 | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.werks/4432 b/.werks/4432 new file mode 100644 index 0000000..3252bf6 --- /dev/null +++ b/.werks/4432 @@ -0,0 +1,12 @@ +Title: Avoid starvation of normal checks by real-time checks +Level: 1 +Component: core +Compatible: compat +Edition: cee +Version: 1.5.0i1 +Date: 1491296216 +Class: fix + +Real-time checks could easily starvate normal checks, because they prevented +scheduling of the Check_MK agent with a high probability. This has been +fixed now.

7 years, 5 months

Fixed some minor typos.

by Sven Panne

Module: check_mk Branch: master Commit: 019b6025edc9c46e7b750073fea44033fd39aaf4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=019b6025edc9c4… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Tue Apr 4 10:08:58 2017 +0200 Fixed some minor typos. Change-Id: I5be25c4da10e053b7c8e505d224915111528d082 --- .werks/8350 | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/.werks/8350 b/.werks/8350 index 9a7cea4..d968d10 100644 --- a/.werks/8350 +++ b/.werks/8350 @@ -7,8 +7,8 @@ Version: 1.2.7i4 Date: 1450274655 Class: feature -This release introduces a new feature named Real-time checks. With the new -Real-time checks it is possible to monitor specific things a lot shorter +This release introduces a new feature named real-time checks. With the new +real-time checks it is possible to monitor specific things a lot shorter intervals than the normal interval of 60 seconds. This feature has mainly been developed to get detailed graphs for some values @@ -16,15 +16,15 @@ which change often like for example the memory usage or CPU utilization. But not only the performance data is updated in this interval. The complete service state is updated which may also result in faster notifications. -The Real-time checks are working like this: The core is listening on the network -for incoming Real-time check results which are basically UDP packets sent by -the agents in an interval of one second. This needds to be enabled using the +The real-time checks are working like this: The core is listening on the network +for incoming real-time check results, which are basically UDP packets sent by +the agents in an interval of one second. This needs to be enabled using the configuration option <i>Global Settings > Enable handling of Real-Time Checks</i>. You need to configure the UDP port to listen on (6559 by default) and the secret -which is used to decrypt the Real-time checks. This secret needs to be equal for -the Check_MK server and all agents which are sending Real-time check results. +which is used to decrypt the real-time checks. This secret needs to be equal for +the Check_MK server and all agents which are sending real-time check results. -The agents need to be configured to send Real-time check results. This can currently +The agents need to be configured to send real-time check results. This can currently be done for the Linux and Windows Agents. On linux you need to create a file /etc/check_mk/real_time_checks.cfg with the following contents: @@ -42,7 +42,7 @@ real-time check secret which is shared between the Check_MK agent and the server to encrypt the transfered data. For example <tt>chmod 640 /etc/check_mk/real_time_checks.cfg</tt> is a good idea. -On windows you need to add the following to the <tt>[global]</tt> section +On Windows you need to add the following to the <tt>[global]</tt> section of your check_mk.ini and restart the Check_MK service: F+:check_mk.ini @@ -54,15 +54,15 @@ F-: The agent is working as usual, waiting for connections from the Check_MK server. Once a Check_MK server is contacting the agent, the agent is responding with -it's regular response. Now, when Real-time checks are enabled, the agent is +it's regular response. Now, when real-time checks are enabled, the agent is sending one UDP packet for each enabled section per second to the host address which had queried the Check_MK agent, which is normally the Check_MK servers address. -The data which can be processed as Real-time check is limited, so we limit the -sections which can be send as Real-time checks. Currently you can enable only +The data which can be processed as real-time check is limited, so we limit the +sections which can be sent as real-time checks. Currently you can enable only the <tt>mem</tt> and <tt>cpu</tt> sections on linux and <tt>mem</tt> and -<tt>winperf</tt> on windows systems. This might be extended in the future. +<tt>winperf</tt> on Windows systems. This might be extended in the future. To get detailed graphs, you now need to configure your RRD databases to be able to store these detailed information. This can be done via the ruleset @@ -71,7 +71,7 @@ to store these detailed information. This can be done via the ruleset You need to create a new rule and first need to ensure that you only apply the rule to checks which get real-time check information as the RRDs of these services need more disk space. So you should only select the CPU/Memory services -of hosts which are sending Real-time check results. +of hosts which are sending real-time check results. Then you need to configure this rule to have a 1 second precision for a duration of your choice. @@ -100,6 +100,6 @@ You need to configure these numbers: After you configured this, you need to run <tt>cmk --convert-rrds -v</tt> to convert the existing RRDs. -After the conversion has finished and processing of the Real-time checks works +After the conversion has finished and processing of the real-time checks works correctly, you should see the service state, output and graphs e.g. of the "CPU utilisation" service updating in an interval of one second.

7 years, 5 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits April 2017