Checkmk git commits March 2017

checkmk-commits@lists.checkmk.com

11 participants
379 discussions

Cleaned up useless user name lookup from exception handling

by Lars Michelsen

Module: check_mk Branch: master Commit: cc2c04415137409114037e3f16ac296d17508523 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=cc2c0441513740… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Mar 30 09:32:18 2017 +0200 Cleaned up useless user name lookup from exception handling Change-Id: I4f418898466b27aa5f046a908028f8321a3f5e21 --- modules/check_mk_base.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/modules/check_mk_base.py b/modules/check_mk_base.py index 34e116a..7e08189 100644 --- a/modules/check_mk_base.py +++ b/modules/check_mk_base.py @@ -1038,9 +1038,7 @@ def save_item_state(hostname): os.makedirs(cmk.paths.counters_dir) file(filename, "w").write("%r\n" % g_item_state) except Exception, e: - import pwd - username = pwd.getpwuid(os.getuid())[0] - raise MKGeneralException("User %s cannot write to %s: %s" % (username, filename, e)) + raise MKGeneralException("Cannot write to %s: %s" % (filename, traceback.format_exc())) # Store arbitrary values until the next execution of a check

7 years, 2 months

4576 FIX if64, if64adm: Fixed interface speed handling, if highspeed data is not available or zero

by Simon Betz

Module: check_mk Branch: master Commit: 38256b17db97fce35849cc98332ad9b5f9c48ded URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=38256b17db97fc… Author: Simon Betz <si(a)mathias-kettner.de> Date: Thu Mar 30 11:37:15 2017 +0200 4576 FIX if64, if64adm: Fixed interface speed handling, if highspeed data is not available or zero Change-Id: Idef4cb2ac237999ae62766007dec5a46cbbb5d0f --- .werks/4576 | 11 +++++++++++ checks/if64.include | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.werks/4576 b/.werks/4576 new file mode 100644 index 0000000..7d74940 --- /dev/null +++ b/.werks/4576 @@ -0,0 +1,11 @@ +Title: if64, if64adm: Fixed interface speed handling, if highspeed data is not available or zero +Level: 1 +Component: checks +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.5.0i1 +Date: 1490866454 + + diff --git a/checks/if64.include b/checks/if64.include index 74194e3..69853ce 100644 --- a/checks/if64.include +++ b/checks/if64.include @@ -35,7 +35,7 @@ def parse_if64(info): # ifHighSpeed (idx 21) can't represent interfaces with less than 10^6 bit bandwidth, # ifSpeed (idx 4) is capped at 4GBit. # combine the two to get the actual interface speed - if line[-1] == "0": + if line[-1] in [ "0", "" ]: real_speed = saveint(line[4]) else: real_speed = saveint(line[-1]) * 1000000

7 years, 3 months

Reserved 20 Werk IDS

by Simon Betz

Module: check_mk Branch: master Commit: 7976a946a742233fb17f1c380102ed3b29a8f2cd URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7976a946a74223… Author: Simon Betz <si(a)mathias-kettner.de> Date: Thu Mar 30 11:34:00 2017 +0200 Reserved 20 Werk IDS Change-Id: Ide2efdb2dfed5f74c3cf45f48bc7caa59964bef6 --- .werks/first_free | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.werks/first_free b/.werks/first_free index 3c86c24..148775a 100644 --- a/.werks/first_free +++ b/.werks/first_free @@ -1 +1 @@ -4576 +4596

7 years, 3 months

exclude frozen_binaries build dir from packaging

by Andreas Boesl

Module: check_mk Branch: master Commit: 74147569c4e01792fbac78c369515cea62b47411 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=74147569c4e017… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Thu Mar 30 10:20:42 2017 +0200 exclude frozen_binaries build dir from packaging Change-Id: I38b53f14fb063e550d35f7c59af1c2f4838a0c45 --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 4a73478..033d150 100644 --- a/Makefile +++ b/Makefile @@ -197,6 +197,7 @@ $(DISTNAME).tar.gz: mk-livestatus-$(VERSION).tar.gz .werks/werks $(JAVASCRIPT_MI --exclude "windows/*.h" \ --exclude "windows/openhardwaremonitor" \ --exclude "windows/sections" \ + --exclude "windows/frozen_binaries" \ --exclude .f12 $$(cd agents ; ls) cd $(DISTNAME) ; ../scripts/make_package_info $(VERSION) > package_info install -m 755 scripts/*.{sh,py} $(DISTNAME)

7 years, 3 months

Updated werk 4527

by Simon Betz

Module: check_mk Branch: master Commit: 37910caf8aacb7a99f51ac32eb15ba1b421dd82e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=37910caf8aacb7… Author: Simon Betz <si(a)mathias-kettner.de> Date: Thu Mar 30 09:50:29 2017 +0200 Updated werk 4527 Change-Id: If396bc2288933599435a6b62892c5d44c35d6a51 --- web/plugins/wato/check_parameters.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py index e5513ba..01eb252 100644 --- a/web/plugins/wato/check_parameters.py +++ b/web/plugins/wato/check_parameters.py @@ -1787,7 +1787,7 @@ register_check_parameters( ), forth = transform_websphere_mq_queues ), - TextAscii(title = _("Name of channel or queue")), + TextAscii(title = _("Name of queue")), match_type = "dict", )

7 years, 3 months

4527 websphere_mq_channels: Now has its own WATO ruleset

by Simon Betz

Module: check_mk Branch: master Commit: 2fbc439346377492ae6ef13310fdb814dcd90f85 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2fbc4393463774… Author: Simon Betz <si(a)mathias-kettner.de> Date: Fri Mar 24 13:33:05 2017 +0100 4527 websphere_mq_channels: Now has its own WATO ruleset In order to separate Websphere MQ queues from channels, above check plugin got its own WATO ruleset. This means that all rules that have been configured for the {{MQ Channels}} services have to be migrated to the new ruleset {{Websphere MQ Channels}}. Change-Id: Ia954cbf38d8aceaa6337e477f47926a00303f877 --- .werks/4527 | 14 ++++++ checks/websphere_mq_channels | 2 +- web/plugins/wato/check_parameters.py | 97 ++++++++++++++++++++---------------- 3 files changed, 70 insertions(+), 43 deletions(-) diff --git a/.werks/4527 b/.werks/4527 new file mode 100644 index 0000000..5f73316 --- /dev/null +++ b/.werks/4527 @@ -0,0 +1,14 @@ +Title: websphere_mq_channels: Now has its own WATO ruleset +Level: 1 +Component: checks +Class: feature +Compatible: incomp +Edition: cre +State: unknown +Version: 1.5.0i1 +Date: 1490358517 + +In order to separate Websphere MQ queues from channels, above +check plugin got its own WATO ruleset. This means that all +rules that have been configured for the {{MQ Channels}} services +have to be migrated to the new ruleset {{Websphere MQ Channels}}. diff --git a/checks/websphere_mq_channels b/checks/websphere_mq_channels index 1408143..b179a82 100644 --- a/checks/websphere_mq_channels +++ b/checks/websphere_mq_channels @@ -111,6 +111,6 @@ check_info["websphere_mq_channels"] = { "service_description" : "MQ Channel %s", "has_perfdata" : True, "default_levels_variable" : "websphere_mq_channels_default_levels", - "group" : "websphere_mq", + "group" : "websphere_mq_channels", } diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py index 7ad5521..e5513ba 100644 --- a/web/plugins/wato/check_parameters.py +++ b/web/plugins/wato/check_parameters.py @@ -1680,8 +1680,45 @@ register_check_parameters( match_type = "dict", ) +websphere_mq_common_elements = [ + ("message_count", + OptionalDropdownChoice( + title = _('Maximum number of messages'), + choices = [ (None, _("Ignore these levels")) ], + otherlabel = _("Set absolute levels"), + explicit = \ + Tuple( + title = _('Maximum number of messages'), + elements = [ + Integer(title = _("Warning at")), + Integer(title = _("Critical at")), + ] + ), + default_value = (1000, 1200) + ) + ), + ("status", + Dictionary( + title = _('Override check state based on channel state (only for channels)'), + elements = [ + ("STOPPED", MonitoringState( + title = _("State when channel is stopped"), + default_value = 1)), + ("RETRYING", MonitoringState( + title = _("State when channel is retrying"), + default_value = 2)), + ("RUNNING", MonitoringState( + title = _("State when channel is running"), + default_value = 0)), + ("other", MonitoringState( + title = _("State when channel status is unknown"), + default_value = 2)), + ], + optional_keys = [] + )), +] -def transform_websphere_mq(source): +def transform_websphere_mq_queues(source): if isinstance(source, tuple): return {"message_count": source} @@ -1695,33 +1732,16 @@ def transform_websphere_mq(source): else: return source - register_check_parameters( subgroup_applications, "websphere_mq", - _("Websphere Message Queues"), + _("Websphere MQ"), Transform( Dictionary( elements = [ - ("message_count", - OptionalDropdownChoice( - title = _('Maximum number of messages'), - choices = [ (None, _("Ignore these levels")) ], - otherlabel = _("Set absolute levels"), - explicit = \ - Tuple( - title = _('Maximum number of messages'), - elements = [ - Integer(title = _("Warning at")), - Integer(title = _("Critical at")), - ] - ), - default_value = (1000, 1200) - ) - ), ("message_count_perc", OptionalDropdownChoice( - title = _('Percentage of Queue Length'), + title = _('Percentage of queue length'), help = _('This setting only applies if the WebSphere MQ reports the queue length'), choices = [ (None, _("Ignore these levels")) ], otherlabel = _("Set relative levels"), @@ -1735,26 +1755,8 @@ register_check_parameters( ), default_value = (80.0, 90.0) ) - ), - ("status", - Dictionary( - title = _('Override check state based on channel state (only for channels)'), - elements = [ - ("STOPPED", MonitoringState( - title = _("State when channel is stopped"), - default_value = 1)), - ("RETRYING", MonitoringState( - title = _("State when channel is retrying"), - default_value = 2)), - ("RUNNING", MonitoringState( - title = _("State when channel is running"), - default_value = 0)), - ("other", MonitoringState( - title = _("State when channel status is unknown"), - default_value = 2)), - ], - optional_keys = [] - )), + ), ] + \ + websphere_mq_common_elements + [ ("messages_not_processed", Dictionary( title = _("Settings for messages not processed"), @@ -1783,9 +1785,20 @@ register_check_parameters( ), ], ), - forth = transform_websphere_mq + forth = transform_websphere_mq_queues + ), + TextAscii(title = _("Name of channel or queue")), + match_type = "dict", +) + +register_check_parameters( + subgroup_applications, + "websphere_mq_channels", + _("Websphere MQ Channels"), + Dictionary( + elements = websphere_mq_common_elements ), - TextAscii(title = _("Name of Channel or Queue")), + TextAscii(title = _("Name of channel")), match_type = "dict", )

7 years, 3 months

Minor cleanup

by Simon Betz

Module: check_mk Branch: master Commit: f768e0a477030df6a27c6c1392aa8e317fa29622 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f768e0a477030d… Author: Simon Betz <si(a)mathias-kettner.de> Date: Thu Mar 30 09:21:19 2017 +0200 Minor cleanup Change-Id: I1e1c65292f425badef53f2eef16ded34d02e6733 --- checks/if.include | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/checks/if.include b/checks/if.include index 06ac2e0..0a869ef 100644 --- a/checks/if.include +++ b/checks/if.include @@ -842,6 +842,9 @@ def check_if_common_single(item, params, info, force_counter_wrap = False, nodeinfo = " on node %s" % group_node infotext += "[%s%s] " % (", ".join(member_info), nodeinfo) + if ifPhysAddress: + infotext += 'MAC: %s, ' % if_render_mac_address(ifPhysAddress) + # prepare reference speed for computing relative bandwidth usage speed = saveint(ifSpeed) if speed: @@ -853,9 +856,6 @@ def check_if_common_single(item, params, info, force_counter_wrap = False, else: ref_speed = None - if ifPhysAddress: - infotext += 'MAC: %s, ' % if_render_mac_address(ifPhysAddress) - # Check speed settings of interface, but only if speed information # is available. This is not always the case. if speed:

7 years, 3 months

Unified rendering MAC address in interface check and inventory plugins for SNMP devices

by Simon Betz

Module: check_mk Branch: master Commit: d4d8baedb60b9edc4471ab524129b7270d950a7a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d4d8baedb60b9e… Author: Simon Betz <si(a)mathias-kettner.de> Date: Thu Mar 30 09:16:49 2017 +0200 Unified rendering MAC address in interface check and inventory plugins for SNMP devices Change-Id: I274c2f8fb99bb87be58be4f73c037c3009d85df4 --- checks/if | 2 +- checks/if.include | 15 +++++++++------ checks/if64_tplink | 38 +++++++++++++++++++------------------- checks/if_brocade | 2 +- checks/if_lancom | 2 +- inventory/if | 8 +++----- 6 files changed, 34 insertions(+), 33 deletions(-) diff --git a/checks/if b/checks/if index 7867542..6832df8 100644 --- a/checks/if +++ b/checks/if @@ -60,7 +60,7 @@ check_info["if"] = { 19, # ifOutDiscards 13 20, # ifOutErrors 14 21, # ifOutQLen 15 - 6, # ifPhysAddress 16 + BINARY(6), # ifPhysAddress 16 ]), # check if number of network interfaces (IF-MIB::ifNumber.0) is at least 2 # use if64 if possible and not disabled diff --git a/checks/if.include b/checks/if.include index 575952a..06ac2e0 100644 --- a/checks/if.include +++ b/checks/if.include @@ -105,6 +105,14 @@ def if_extract_node(line, has_nodeinfo): return None, line +def if_render_mac_address(ifPhysAddress): + if type(ifPhysAddress) != list: + mac_bytes = map(ord, ifPhysAddress) + else: + mac_bytes = ifPhysAddress + return (":".join(["%02s" % hex(m)[2:] for m in mac_bytes]).replace(' ', '0')).upper() + + def if_item_matches(item, ifIndex, ifAlias, ifDescr): return item.lstrip("0") == ifIndex \ or (item == "0" * len(item) and saveint(ifIndex) == 0) \ @@ -846,12 +854,7 @@ def check_if_common_single(item, params, info, force_counter_wrap = False, ref_speed = None if ifPhysAddress: - if type(ifPhysAddress) != list: - mac_bytes = map(ord, ifPhysAddress) - else: - mac_bytes = ifPhysAddress - mac = ":".join(["%02s" % hex(m)[2:] for m in mac_bytes]).replace(' ', '0') - infotext += 'MAC: %s, ' % mac + infotext += 'MAC: %s, ' % if_render_mac_address(ifPhysAddress) # Check speed settings of interface, but only if speed information # is available. This is not always the case. diff --git a/checks/if64_tplink b/checks/if64_tplink index cc86b2a..2359d6b 100644 --- a/checks/if64_tplink +++ b/checks/if64_tplink @@ -42,26 +42,26 @@ check_info["if64_tplink"] = { 'has_perfdata': True, 'includes': [ 'if.include' ], 'snmp_info': ( ".1.3.6.1", [ - "2.1.2.2.1.1", # ifIndex 0 - "2.1.2.2.1.2", # ifDescr 1 - "2.1.2.2.1.3", # ifType 2 - "2.1.31.1.1.1.15", # ifHighSpeed .. 1000 means 1Gbit - "2.1.2.2.1.8", # ifOperStatus 4 - "2.1.31.1.1.1.6", # ifHCInOctets 5 - "2.1.31.1.1.1.7", # ifHCInUcastPkts 6 - "2.1.31.1.1.1.8", # ifHCInMulticastPkts 7 - "2.1.31.1.1.1.9", # ifHCInBroadcastPkts 8 - "2.1.2.2.1.13", # ifInDiscards 9 - "2.1.2.2.1.14", # ifInErrors 10 - "2.1.31.1.1.1.10", # ifHCOutOctets 11 - "2.1.31.1.1.1.11", # ifHCOutUcastPkts 12 - "2.1.31.1.1.1.12", # ifHCOutMulticastPkts 13 - "2.1.31.1.1.1.13", # ifHCOutBroadcastPkts 14 - "2.1.2.2.1.19", # ifOutDiscards 15 - "2.1.2.2.1.20", # ifOutErrors 16 - "2.1.2.2.1.21", # ifOutQLen 17 + "2.1.2.2.1.1", # ifIndex 0 + "2.1.2.2.1.2", # ifDescr 1 + "2.1.2.2.1.3", # ifType 2 + "2.1.31.1.1.1.15", # ifHighSpeed .. 1000 means 1Gbit + "2.1.2.2.1.8", # ifOperStatus 4 + "2.1.31.1.1.1.6", # ifHCInOctets 5 + "2.1.31.1.1.1.7", # ifHCInUcastPkts 6 + "2.1.31.1.1.1.8", # ifHCInMulticastPkts 7 + "2.1.31.1.1.1.9", # ifHCInBroadcastPkts 8 + "2.1.2.2.1.13", # ifInDiscards 9 + "2.1.2.2.1.14", # ifInErrors 10 + "2.1.31.1.1.1.10", # ifHCOutOctets 11 + "2.1.31.1.1.1.11", # ifHCOutUcastPkts 12 + "2.1.31.1.1.1.12", # ifHCOutMulticastPkts 13 + "2.1.31.1.1.1.13", # ifHCOutBroadcastPkts 14 + "2.1.2.2.1.19", # ifOutDiscards 15 + "2.1.2.2.1.20", # ifOutErrors 16 + "2.1.2.2.1.21", # ifOutQLen 17 "4.1.11863.1.1.3.2.1.1.1.1.2", # special for TP Link - "2.1.2.2.1.6", # ifPhysAddress 19 + BINARY("2.1.2.2.1.6"), # ifPhysAddress 19 ]), 'snmp_scan_function': \ lambda oid: ".4.1.11863." in oid(".1.3.6.1.2.1.1.2.0") and \ diff --git a/checks/if_brocade b/checks/if_brocade index c6cc193..69b08cf 100644 --- a/checks/if_brocade +++ b/checks/if_brocade @@ -81,7 +81,7 @@ check_info["if_brocade"] = { "2.2.1.20", # ifOutErrors 16 "2.2.1.21", # ifOutQLen 17 "31.1.1.1.18", # ifAlias 18 - "2.2.1.6", # ifPhysAddress 19 + BINARY("2.2.1.6"), # ifPhysAddress 19 # Used in order to ignore some logical NICs "2.2.1.2", # ifDescr 20 ]), diff --git a/checks/if_lancom b/checks/if_lancom index 15f3c4b..99e5e51 100644 --- a/checks/if_lancom +++ b/checks/if_lancom @@ -81,7 +81,7 @@ check_info["if_lancom"] = { "2.2.1.20", # ifOutErrors 16 "2.2.1.21", # ifOutQLen 17 "31.1.1.1.18", # ifAlias 18 - "2.2.1.6", # ifPhysAddress 19 + BINARY("2.2.1.6"), # ifPhysAddress 19 # Used in order to ignore some logical NICs "2.2.1.2", # ifDescr 20 ]), diff --git a/inventory/if b/inventory/if index 7d6e182..b24bc6a 100644 --- a/inventory/if +++ b/inventory/if @@ -40,9 +40,6 @@ def inv_if(info, params): [ '6', '32', '62', '117', '127', '128', '129', '180', '181', '182', '205', '229' ]) unused_duration = params.get("unused_duration", 30 * 86400) - def render_mac_address(bytestring): - return ":".join(["%02s" % hex(ord(m))[2:] for m in bytestring]).replace(' ', '0').upper() - total_ethernet_ports = 0 available_ethernet_ports = 0 @@ -87,7 +84,7 @@ def inv_if(info, params): "description" : if_descr, "alias" : if_alias, "speed" : speed, - "phys_address" : render_mac_address(if_phys_address), + "phys_address" : if_render_mac_address(if_phys_address), "oper_status" : int(if_oper_status), "admin_status" : int(if_admin_status), # 1(up) or 2(down) "port_type" : int(if_type), @@ -121,10 +118,11 @@ inv_info['inv_if'] = { "31.1.1.1.15", # ifHighSpeed .. 1000 means 1Gbit "2.2.1.8", # ifOperStatus "2.2.1.7", # ifAdminStatus - "2.2.1.6", # ifPhysAddress + BINARY("2.2.1.6"), # ifPhysAddress "2.2.1.9", # ifLastChange ]), ( ".1.3.6.1.2.1.1", [ "3.0" ] ), # uptime ], 'snmp_scan_function': lambda oid: int(oid(".1.3.6.1.2.1.2.1.0")) >= 2, + 'includes': ['if.include'], }

7 years, 3 months

4552 FIX win_dhcp_pools: Fixed conversion of old type of rules (1.2.6) to new type (1.2.8)

by Marcel Arentz

Module: check_mk Branch: master Commit: 951cb9b1e24dd551361d32758aabc2da3fd73fc9 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=951cb9b1e24dd5… Author: Marcel Arentz <ma(a)mathias-kettner.de> Date: Wed Mar 29 16:29:04 2017 +0200 4552 FIX win_dhcp_pools: Fixed conversion of old type of rules (1.2.6) to new type (1.2.8) If rules for this checkplugin have been set up in 1.2.6 the GUI crashed in 1.2.8 if someone wanted to modify these rules. Change-Id: I36eeb89f566d564dc51bfd0ce8cdeefebec12cab --- .werks/4552 | 11 +++++++++++ web/plugins/wato/check_parameters.py | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.werks/4552 b/.werks/4552 new file mode 100644 index 0000000..35f827c --- /dev/null +++ b/.werks/4552 @@ -0,0 +1,11 @@ +Title: win_dhcp_pools: Fixed conversion of old type of rules (1.2.6) to new type (1.2.8) +Level: 1 +Component: checks +Compatible: compat +Edition: cre +Version: 1.5.0i1 +Date: 1490797569 +Class: fix + +If rules for this checkplugin have been set up in 1.2.6 the GUI crashed in +1.2.8 if someone wanted to modify these rules. diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py index 9c7ff91..7ad5521 100644 --- a/web/plugins/wato/check_parameters.py +++ b/web/plugins/wato/check_parameters.py @@ -9974,7 +9974,7 @@ register_check_parameters( title = _("Pool name"), allow_empty = False, ), - match_type = "dict", + match_type = "first", ) register_check_parameters(

7 years, 3 months

4534 FIX emcvnx_mirrorview: Handles 'Request failed.' correct,

by Simon Betz

id. sync mirror feature is not installed or unavailable. Message-ID: <58dbc2bb.6WqJW9jqY9TnKDYA%si(a)mathias-kettner.de> User-Agent: Heirloom mailx 12.5 6/20/10 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Module: check_mk Branch: master Commit: 8e8cd2a9a40f4d67ec27175b6d1859d81faae00d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8e8cd2a9a40f4d… Author: Simon Betz <si(a)mathias-kettner.de> Date: Wed Mar 29 16:09:45 2017 +0200 4534 FIX emcvnx_mirrorview: Handles 'Request failed.' correct, id. sync mirror feature is not installed or unavailable. Change-Id: Ia14c8b3e0cc9793b9da481c568fa069630927457 --- .werks/4534 | 11 +++++++++++ checks/emcvnx_mirrorview | 6 +++++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/.werks/4534 b/.werks/4534 new file mode 100644 index 0000000..1720c16 --- /dev/null +++ b/.werks/4534 @@ -0,0 +1,11 @@ +Title: emcvnx_mirrorview: Handles 'Request failed.' correct, id. sync mirror feature is not installed or unavailable. +Level: 1 +Component: checks +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.5.0i1 +Date: 1490796442 + + diff --git a/checks/emcvnx_mirrorview b/checks/emcvnx_mirrorview index 168bb6a..35fad6e 100644 --- a/checks/emcvnx_mirrorview +++ b/checks/emcvnx_mirrorview @@ -96,9 +96,13 @@ def parse_emcvnx_mirrorview(info): parsed = {} for line in info: - if line[0] == "MirrorView Name": + if line[0] == "Request failed. Management Server - Sync Mirror Feature software is not installed or unavailable.": + break + + elif line[0] == "MirrorView Name": lun_name = line[1].replace("_", " ").replace("Mirror", "").strip() parsed.setdefault(lun_name, {}) + else: if "UID" in line[0]: lun_value = ":".join(line[1:]).strip()

7 years, 3 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits March 2017