Checkmk git commits February 2017

checkmk-commits@lists.checkmk.com

10 participants
452 discussions

by Sven Panne

Module: check_mk Branch: master Commit: 175f3ada1cb7701518452681d775f1e477839e96 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=175f3ada1cb770… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Thu Feb 23 09:03:06 2017 +0100 Reserved 10 Werk IDS Change-Id: I98dc2cba68f786ac8db82b1e04ca1e034e4b8646 --- .werks/first_free | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.werks/first_free b/.werks/first_free index 42efc6d..3c7295b 100644 --- a/.werks/first_free +++ b/.werks/first_free @@ -1 +1 @@ -4426 +4436

7 years, 6 months

Reserved 10 Werk IDS

by Lars Michelsen

Module: check_mk Branch: master Commit: ae0b0fbe73dd8fd46e5e7ccde3c8ec8416853cdd URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ae0b0fbe73dd8f… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Feb 23 08:53:36 2017 +0100 Reserved 10 Werk IDS Change-Id: I18db6050151db3c02ed8ddbd1d81eb389eff163b --- .werks/first_free | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.werks/first_free b/.werks/first_free index 468d6fb..42efc6d 100644 --- a/.werks/first_free +++ b/.werks/first_free @@ -1 +1 @@ -4416 +4426

7 years, 6 months

Fixed werk enumeration issue in werk tool

by Lars Michelsen

Module: check_mk Branch: master Commit: df7124daa10efe0dd42b3326523cd312c6f40c8e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=df7124daa10efe… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Feb 23 08:53:33 2017 +0100 Fixed werk enumeration issue in werk tool Change-Id: I46e6c71afc1df7aee08e88434330f97905d7f3d2 --- .werks/first_free | 2 +- werk | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.werks/first_free b/.werks/first_free index 56c2a0b..468d6fb 100644 --- a/.werks/first_free +++ b/.werks/first_free @@ -1 +1 @@ -8760 +4416 diff --git a/werk b/werk index fd33ac9..6c247f8 100755 --- a/werk +++ b/werk @@ -737,8 +737,8 @@ def main_fetch_ids(args): # enterprise werks were between 8000 and 8749. Skip over this area for new # reserved werk ids - if first_free >= 8000 or first_free < 8750: - first_free = 8750 + if first_free >= 8000 and first_free < 8780: + first_free = 8780 except: first_free = 0 new_first_free = first_free + num

7 years, 6 months

4393 FIX The permissions on events were not always handled correctly

by Lars Michelsen

Module: check_mk Branch: master Commit: e5adbfa6f652ebd85816768bcf79f4f584cb2d79 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e5adbfa6f652eb… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Feb 23 08:47:49 2017 +0100 4393 FIX The permissions on events were not always handled correctly When rulesets have "contact group" permissions configured and set the rulset config to have precedence, this was not handled correctly, making users don't see event that they should see. Change-Id: Ifa69ffa008b2c4502b2745525f0a7d4b3d7edf5e --- .werks/4393 | 13 +++++++++++++ web/plugins/sidebar/shipped.py | 3 +++ 2 files changed, 16 insertions(+) diff --git a/.werks/4393 b/.werks/4393 new file mode 100644 index 0000000..f3143b8 --- /dev/null +++ b/.werks/4393 @@ -0,0 +1,13 @@ +Title: The permissions on events were not always handled correctly +Level: 1 +Component: ec +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.5.0i1 +Date: 1487835927 + +When rulesets have "contact group" permissions configured and set the +rulset config to have precedence, this was not handled correctly, making +users don't see event that they should see. diff --git a/web/plugins/sidebar/shipped.py b/web/plugins/sidebar/shipped.py index d685795..58d15b2 100644 --- a/web/plugins/sidebar/shipped.py +++ b/web/plugins/sidebar/shipped.py @@ -635,9 +635,12 @@ def get_tactical_overview_data(extra_filter_headers): extra_headers=extra_filter_headers) try: + sites.live().set_auth_domain("ec") event_data = sites.live().query_summed_stats(event_query) except livestatus.MKLivestatusNotFoundError: event_data = [0, 0, 0] + finally: + sites.live().set_auth_domain("read") except livestatus.MKLivestatusNotFoundError: return None, None, None, None

7 years, 6 months

Updated bug entries #2819

by Lars Michelsen

Module: check_mk Branch: master Commit: fbd3fab0ec5f21513ee12902e9c65cca1720bcd3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=fbd3fab0ec5f21… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Feb 23 08:02:33 2017 +0100 Updated bug entries #2819 Change-Id: I668404c0358c880e93286a8884d96fbe95d69341 --- .bugs/2819 | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.bugs/2819 b/.bugs/2819 index e6e8c82..65ea8bc 100644 --- a/.bugs/2819 +++ b/.bugs/2819 @@ -1,10 +1,12 @@ Title: Agent bakery: Possible broken agent deployment status files Component: agents -State: open +Class: bug +State: done Date: 2016-04-19 17:28:35 Targetversion: 1.2.8 -Class: bug htdocs/agent_bakery.py save_agent_deployment_status() is using locking. Possible race condition which can e.g. result in a somehow corrupted or empty file. Add locking. + +2017-02-23 07:59:44: changed state open -> done

7 years, 6 months

Updated bug entries #2855, #2330, #2843, #2461, #2837

by Lars Michelsen

Module: check_mk Branch: master Commit: 719224e432b8f41bcdcf922bb39c4ff084ca4a99 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=719224e432b8f4… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Feb 22 15:30:42 2017 +0100 Updated bug entries #2855, #2330, #2843, #2461, #2837 Change-Id: I089cda857cd61734be6089b423a68257bee38a2f --- .bugs/2330 | 2 +- .bugs/2461 | 2 +- .bugs/2837 | 2 +- .bugs/2843 | 2 +- .bugs/2855 | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.bugs/2330 b/.bugs/2330 index 35c21a1..e80a420 100644 --- a/.bugs/2330 +++ b/.bugs/2330 @@ -2,7 +2,7 @@ Title: Cluster should always have only it's nodes as parents Component: core State: open Date: 2016-02-16 13:42:50 -Targetversion: 1.2.9 +Targetversion: 1.4.0 Class: bug bin mir nicht 100% sicher ob es als Bug definiert werden sollte, evtl. übersehe ich einen Use-Case. diff --git a/.bugs/2461 b/.bugs/2461 index 4724f48..6bd5afc 100644 --- a/.bugs/2461 +++ b/.bugs/2461 @@ -2,7 +2,7 @@ Title: Predictive icon for Interface outbound traffic missing Component: multisite State: open Date: 2016-04-05 16:25:10 -Targetversion: 1.2.8p1 +Targetversion: 1.4.0 Class: bug There is only one icon created by the icon plugin for the first diff --git a/.bugs/2837 b/.bugs/2837 index caad744..ac9fb13 100644 --- a/.bugs/2837 +++ b/.bugs/2837 @@ -2,7 +2,7 @@ Title: Mixture of report context types due to importing templates creates proble Component: reporting State: open Date: 2016-02-26 16:11:54 -Targetversion: 1.2.9 +Targetversion: 1.4.0 Class: bug Create a report with context type "one single host". This automatically inherits diff --git a/.bugs/2843 b/.bugs/2843 index 722c4ba..b1fcd20 100644 --- a/.bugs/2843 +++ b/.bugs/2843 @@ -2,7 +2,7 @@ Title: SSH private key of linux remote handler visible in agent package Component: agents State: open Date: 2017-02-14 15:05:49 -Targetversion: 1.2.9 +Targetversion: 1.4.0 Class: bug The private SSH key for remote login and execution of remote alert handlers diff --git a/.bugs/2855 b/.bugs/2855 index 2cfbd3d..a898b31 100644 --- a/.bugs/2855 +++ b/.bugs/2855 @@ -2,6 +2,6 @@ Title: cmk-update-agent: Needs to protect against parallel executions Component: agents State: open Date: 2016-12-22 11:52:28 -Targetversion: 1.2.9 +Targetversion: 1.4.0 Class: bug

7 years, 6 months

Updated bug entries #2818

by Lars Michelsen

Module: check_mk Branch: master Commit: 84c852195a28940f0a1caa3e067cecf45359ac8b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=84c852195a2894… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Feb 22 15:27:48 2017 +0100 Updated bug entries #2818 Change-Id: I0cba2032fcbe972af98dbb3fabee4a25b87d79af --- .bugs/2818 | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.bugs/2818 b/.bugs/2818 index 1914fb2..65dbf4f 100644 --- a/.bugs/2818 +++ b/.bugs/2818 @@ -2,7 +2,7 @@ Title: Old host rrd directory is created even when using new one Component: core State: open Date: 2016-04-05 17:04:56 -Targetversion: 1.2.8 +Targetversion: 1.4.0 Class: bug Unsure where the issue is located, but what happens is: @@ -14,3 +14,8 @@ Unsure where the issue is located, but what happens is: This is done even when var/check_mk/rrd/[hostname] is used for storing the RRD files. + +---- + +This is done by Perfdatabase::getPNPBase() which class makeDirectory(base). +TODO(sp): Please investigate and clean this up.

7 years, 6 months

4392 FIX Fixed possible broken agent deployment status data

by Lars Michelsen

Module: check_mk Branch: master Commit: 464ce14a79ccd7916a4c0c8f013cfb7b2331b76d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=464ce14a79ccd7… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Feb 23 07:59:40 2017 +0100 4392 FIX Fixed possible broken agent deployment status data The agent deployment status of hosts, stored on the Check_MK server, could corrupt or be reset in case of parallel write operations to the file storing this information. Change-Id: Ic69cb02613448419ecca65fcc66c9576b2b204b0 --- .bugs/2461 | 2 +- .bugs/2497 | 7 +++++-- .bugs/2837 | 7 +++++-- .werks/4392 | 12 ++++++++++++ 4 files changed, 23 insertions(+), 5 deletions(-) diff --git a/.bugs/2461 b/.bugs/2461 index 6bd5afc..57373cf 100644 --- a/.bugs/2461 +++ b/.bugs/2461 @@ -2,7 +2,7 @@ Title: Predictive icon for Interface outbound traffic missing Component: multisite State: open Date: 2016-04-05 16:25:10 -Targetversion: 1.4.0 +Targetversion: 1.5.0 Class: bug There is only one icon created by the icon plugin for the first diff --git a/.bugs/2497 b/.bugs/2497 index dc39b93..f856fc3 100644 --- a/.bugs/2497 +++ b/.bugs/2497 @@ -1,9 +1,9 @@ Title: Multisite cronjobs have config.user_id not set correcty Component: multisite -State: open +Class: bug +State: done Date: 2016-06-29 12:29:30 Targetversion: future -Class: bug This value should be set to None (and maybe a buch of other user related settings in config). There should *no* user be logged in, but all permissions @@ -11,3 +11,6 @@ be active. Currently there seems to the randomly the user from the last login that that Apache process has made. + +2017-02-23 07:43:30: changed state open -> done +This has already been fixed. diff --git a/.bugs/2837 b/.bugs/2837 index ac9fb13..27f67b8 100644 --- a/.bugs/2837 +++ b/.bugs/2837 @@ -1,9 +1,9 @@ Title: Mixture of report context types due to importing templates creates problems Component: reporting -State: open +Class: bug +State: done Date: 2016-02-26 16:11:54 Targetversion: 1.4.0 -Class: bug Create a report with context type "one single host". This automatically inherits the default template (which has no context). Now add a PNP Graph to the default @@ -12,3 +12,6 @@ template (this is possible). This now results in a strange error, where Needs to be investigated. We cannot disallow importing non-context templates into reports with context. We cannot disallow added elements that have a single context into contextless reports either. + +2017-02-23 07:51:55: changed state open -> done +Just tried this with 1.4.0 - it works. diff --git a/.werks/4392 b/.werks/4392 new file mode 100644 index 0000000..c16c40a --- /dev/null +++ b/.werks/4392 @@ -0,0 +1,12 @@ +Title: Fixed possible broken agent deployment status data +Level: 1 +Component: agents +Compatible: compat +Edition: cee +Version: 1.5.0i1 +Date: 1487833072 +Class: fix + +The agent deployment status of hosts, stored on the Check_MK +server, could corrupt or be reset in case of parallel write +operations to the file storing this information.

7 years, 6 months

Updated bug entries #2303

by Lars Michelsen

Module: check_mk Branch: master Commit: a815467093a8c07bfd87c2ddc9b3296c39ad2ffc URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a815467093a8c0… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Feb 23 08:28:21 2017 +0100 Updated bug entries #2303 Change-Id: I7bd9f9f6cb42bdd03fa38a07954426fcbd2c75ea --- .bugs/2303 | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.bugs/2303 b/.bugs/2303 index 72f7600..fbbd737 100644 --- a/.bugs/2303 +++ b/.bugs/2303 @@ -1,6 +1,6 @@ Title: heartbeat_crm: parse old output, get at least in warning if unmanaged Component: checks -State: open +State: closed Date: 2015-02-20 15:29:17 Targetversion: future Class: bug @@ -8,3 +8,8 @@ Class: bug There are three example outputs in server-linux-heartbeat-{1,2,3} in our (MK's) archive. in server-linux-heartbeat-2 there are some unmanaged nodes. Someone who understands this output needs to have a look. + +2017-02-23 08:04:08: changed state open -> closed + +2017-02-23 08:04:20: changed state closed -> closed +Works.

7 years, 6 months

preliminary fix for test_werks.py

by Andreas Boesl

Module: check_mk Branch: master Commit: 2740d17542c48982d03454ac65c3fb11f5543b53 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2740d17542c489… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Wed Feb 22 17:10:13 2017 +0100 preliminary fix for test_werks.py Change-Id: Ic3ebfa5ab059ca441561359d2ddc57e10223d145 --- tests/lib/test_werks.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/lib/test_werks.py b/tests/lib/test_werks.py index f0cd484..8a4c06b 100644 --- a/tests/lib/test_werks.py +++ b/tests/lib/test_werks.py @@ -43,7 +43,7 @@ def test_write_precompiled_werks(tmpdir, site, monkeypatch): cmc_werks = dict([ (w["id"], w) for w in all_werks.values() if w["edition"] == "cee" ]) assert len(cmk_werks) > 1000 - assert [ w for w in cmk_werks.keys() if w >= 7500 ] == [] + assert [ w for w in cmk_werks.keys() if w >= 9000 ] == [] cmk.werks.write_precompiled_werks(os.path.join(tmp_dir, "werks"), cmk_werks)

7 years, 6 months

← Newer
1
...
5
6
7
8
9
10
11
...
46
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits February 2017