Checkmk git commits February 2017

checkmk-commits@lists.checkmk.com

10 participants
452 discussions

by Lars Michelsen

Module: check_mk Branch: master Commit: 129cdc329a67d77dbd21c8678f3ac847d487a510 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=129cdc329a67d7… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Feb 20 12:07:16 2017 +0100 cleaned up comments Change-Id: Id4bbf5ef346ec6cd070a3ce309a5b74b0fc769c4 --- web/htdocs/views.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/web/htdocs/views.py b/web/htdocs/views.py index 093355d..f2486d8 100644 --- a/web/htdocs/views.py +++ b/web/htdocs/views.py @@ -755,9 +755,6 @@ class Cell(object): if tdclass == "" and content == "": return "", "" - # Removed this here. Belive this is the wrong place for such an action - #content = html.utf8_to_entities(content) - # Add the optional link to another view if content and self._has_link(): content = link_to_view(content, row, self._link_view_name) @@ -767,7 +764,6 @@ class Cell(object): tooltip_cell = Cell(self._view, (self.tooltip_painter_name(), None)) tooltip_tdclass, tooltip_content = tooltip_cell.render_content(row) tooltip_text = html.strip_tags(tooltip_content) - #tooltiptext = html.utf8_to_entities(html.strip_tags(txt)) content = '<span title="%s">%s</span>' % (tooltip_text, content) return tdclass, content

7 years, 7 months

Reserved 20 Werk IDS

by Lars Michelsen

Module: check_mk Branch: master Commit: 2468f6985c61908bfad5cda9c064d50bf2c785fd URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2468f6985c6190… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Feb 20 14:25:38 2017 +0100 Reserved 20 Werk IDS Change-Id: Iddbada1545a67ffe6b703c0cda95630ac3bfc2e0 --- .werks/first_free | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.werks/first_free b/.werks/first_free index 75df125..1626a73 100644 --- a/.werks/first_free +++ b/.werks/first_free @@ -1 +1 @@ -4386 +4406

7 years, 7 months

Removed commented out code

by Lars Michelsen

Module: check_mk Branch: master Commit: 0ded6a3da0f4f9b25727d6b0f360030ea0f16c3d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=0ded6a3da0f4f9… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Feb 20 13:50:19 2017 +0100 Removed commented out code Change-Id: Iff08695eb7f6406f4bbd629aa921cff3baacefb4 --- web/htdocs/availability.py | 1 - 1 file changed, 1 deletion(-) diff --git a/web/htdocs/availability.py b/web/htdocs/availability.py index 1c750ed..e09b7d6 100644 --- a/web/htdocs/availability.py +++ b/web/htdocs/availability.py @@ -1581,7 +1581,6 @@ def get_bi_leaf_history(tree, aggr_group, time_range, countdown_logrow_limit): data = sites.live().query(query) if not data: return [], None - # raise MKGeneralException(_("No historical data available for this aggregation. Query was: <pre>%s</pre>") % query) sites.live().set_prepend_site(False) sites.live().set_only_sites(None)

7 years, 7 months

4386 FIX Fixed exception when creating links from service views to service group views

by Lars Michelsen

Module: check_mk Branch: master Commit: 380ac414fc6462e54158047999057bc3a386e130 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=380ac414fc6462… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Feb 20 14:27:03 2017 +0100 4386 FIX Fixed exception when creating links from service views to service group views When adding a service group column together with a link to the service group list view, an exception occured while rendering the service group painter. Change-Id: I52837391f4b371bde9ca81a91385bebb024c8300 --- .werks/4386 | 11 +++++++++++ web/htdocs/views.py | 11 +++++++++-- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/.werks/4386 b/.werks/4386 new file mode 100644 index 0000000..d0f2e73 --- /dev/null +++ b/.werks/4386 @@ -0,0 +1,11 @@ +Title: Fixed exception when creating links from service views to service group views +Level: 1 +Component: multisite +Class: fix +Compatible: compat +State: unknown +Version: 1.5.0i1 +Date: 1487597151 + +When adding a service group column together with a link to the service group list view, +an exception occured while rendering the service group painter. diff --git a/web/htdocs/views.py b/web/htdocs/views.py index f2486d8..73f82a9 100644 --- a/web/htdocs/views.py +++ b/web/htdocs/views.py @@ -2714,8 +2714,15 @@ def url_to_view(row, view_name): # See get_link_filter_names() comment for details for src_key, dst_key in visuals.get_link_filter_names(view, datasource['infos'], datasource.get('link_filters', {})): - url_vars += visuals.get_filter(src_key).variable_settings(row) - url_vars += visuals.get_filter(dst_key).variable_settings(row) + try: + url_vars += visuals.get_filter(src_key).variable_settings(row) + except KeyError: + pass + + try: + url_vars += visuals.get_filter(dst_key).variable_settings(row) + except KeyError: + pass # Some special handling for the site filter which is meant as optional hint # Always add the site filter var when some useful information is available

7 years, 7 months

New bug added

by Sven Rueß

Module: check_mk Branch: master Commit: b3c6460813163ffe4a14d1656d19a1d3dc699597 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b3c6460813163f… Author: Sven Rueß <sr(a)mathias-kettner.de> Date: Mon Feb 20 12:23:59 2017 +0100 New bug added Change-Id: I8b2da0ebdedf914a7cb1d877c4e194f9c9c2baed --- .bugs/2557 | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.bugs/2557 b/.bugs/2557 new file mode 100644 index 0000000..2cd4a0d --- /dev/null +++ b/.bugs/2557 @@ -0,0 +1,13 @@ +Title: Notification setting for event console events +Component: notification +State: open +Date: 2017-02-20 12:22:24 +Targetversion: 1.2.8 +Class: bug + +The setting Event Console alerts in the notification rules is not used as expected. +If you select this option, it shows the option Do not match Event Console alerts. +That should be the system standard. +Unfortunately we accept all events from Event Console as standard. +We have to specify it explicit to ignore those messages. +We should add a new option to tell the user, All Event Console alerts will be processed.

7 years, 7 months

Added new ToDo

by Sven Rueß

Module: check_mk Branch: master Commit: 15c2829a472bdca2068f206e27e5b88288f2aab4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=15c2829a472bdc… Author: Sven Rueß <sr(a)mathias-kettner.de> Date: Mon Feb 20 12:27:02 2017 +0100 Added new ToDo Change-Id: Iea0b4df7af100eada57266dfa42edd7f7fd8bfd6 --- .bugs/2557 | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/.bugs/2557 b/.bugs/2557 index 2cd4a0d..0014412 100644 --- a/.bugs/2557 +++ b/.bugs/2557 @@ -1,13 +1,10 @@ -Title: Notification setting for event console events -Component: notification +Title: Need host alias as name for availibilty reports +Component: multisite State: open -Date: 2017-02-20 12:22:24 +Date: 2017-02-20 12:24:36 Targetversion: 1.2.8 -Class: bug +Class: todo -The setting Event Console alerts in the notification rules is not used as expected. -If you select this option, it shows the option Do not match Event Console alerts. -That should be the system standard. -Unfortunately we accept all events from Event Console as standard. -We have to specify it explicit to ignore those messages. -We should add a new option to tell the user, All Event Console alerts will be processed. +In the availibility table only the hostname can be used. The customer can +not configure with column to show instead of it. It will be helpful +to get the host alias available for the selection.

7 years, 7 months

Reserved 1 bug IDS

by Sven Rueß

Module: check_mk Branch: master Commit: 8bfc1cc9e6c187ba7a3020a593ab9ed6d0bfdb2a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8bfc1cc9e6c187… Author: Sven Rueß <sr(a)mathias-kettner.de> Date: Mon Feb 20 12:24:27 2017 +0100 Reserved 1 bug IDS Change-Id: Ic15f7d7e629efe0508a3d494a65d7736f2b7217a --- .bugs/first_free | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.bugs/first_free b/.bugs/first_free index 45f6930..aed4b56 100644 --- a/.bugs/first_free +++ b/.bugs/first_free @@ -1 +1 @@ -2557 +2558

7 years, 7 months

Updated bug entries #2509

by Lars Michelsen

Module: check_mk Branch: master Commit: 83c160b5ab2baaab43388184b5f2dd13b33859c7 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=83c160b5ab2baa… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Feb 20 10:47:15 2017 +0100 Updated bug entries #2509 Change-Id: Ie7d826c69d3910f553a756d2777577d49b446b49 --- .bugs/2509 | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.bugs/2509 b/.bugs/2509 index f4a33a1..3f61966 100644 --- a/.bugs/2509 +++ b/.bugs/2509 @@ -1,8 +1,11 @@ Title: Notifications: Pending Changes after editing or creating rule Component: notification -State: open +Class: bug +State: done Date: 2016-11-21 09:41:13 Targetversion: future -Class: bug If editing or creating a rule in notifications a pending changes will appear. But there are no pending changes and in consequence none can be activated. Still the pending changes are displayed. + +2017-02-20 10:47:12: changed state open -> done +Seems that this has already been fixed.

7 years, 7 months

Updated bug entries #2408, #2428

by Lars Michelsen

Module: check_mk Branch: master Commit: 5c9aa82f6b221f12f1b7ceea809f5a7e06def5df URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5c9aa82f6b221f… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Feb 20 10:40:50 2017 +0100 Updated bug entries #2408, #2428 Change-Id: I81d7278b3ac7fea1e81b287b637959b47e50fb37 --- .bugs/2408 | 7 +++++-- .bugs/2428 | 7 +++++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/.bugs/2408 b/.bugs/2408 index 23b0323..302138b 100644 --- a/.bugs/2408 +++ b/.bugs/2408 @@ -1,9 +1,9 @@ Title: linux agent: make MK_CONFDIR available to outside tools Component: checks -State: open +Class: bug +State: done Date: 2016-05-04 09:24:02 Targetversion: 1.2.9 -Class: bug Currently, the user can set the MK_CONFDIR through the agent bakery, but this will only affect the agent itself and the plugins started by it. Other tools @@ -17,3 +17,6 @@ agent to get all the parameters as used by the agent. Alternatively the agent could accept a parameter "--variables" that make it output such variables and then quit. Tools would then have to parse that output, but it would be easier to use in non-bash languages. + +2017-02-20 10:31:42: changed state open -> done +Has been fixed now by dynamically replacing it during baking. diff --git a/.bugs/2428 b/.bugs/2428 index 15eee87..f4aa2e0 100644 --- a/.bugs/2428 +++ b/.bugs/2428 @@ -1,11 +1,14 @@ Title: Make a clean install of the agents/ directory Component: core -State: open +Class: bug +State: done Date: 2016-03-09 10:58:31 Targetversion: 1.2.9 -Class: bug The contents of the source code direcgory agents/ in the GIT cannot shipped 1:1 into the Check_MK site anylonger. We need an installation script of the like that e.g. tars the source codes into nice tarballs, skips internal files and presents a nice list of files for download on the Agents page in WATO. + +2017-02-20 10:32:44: changed state open -> done +Cleaned up the shipped files a bit

7 years, 7 months

Do not deploy the windows agent source into the sites anymore

by Lars Michelsen

Module: check_mk Branch: master Commit: 1f7f60990c85705c4512c7ecfd12921368f394d3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1f7f60990c8570… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Feb 20 10:41:13 2017 +0100 Do not deploy the windows agent source into the sites anymore Change-Id: I1ffb4020a76bf106d65ff912295b0f2258daed7c --- Makefile | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 22dff53..2363691 100644 --- a/Makefile +++ b/Makefile @@ -182,9 +182,14 @@ $(DISTNAME).tar.gz: mk-livestatus-$(VERSION).tar.gz .werks/werks $(JAVASCRIPT_MI --exclude "*.unversioned.exe" \ --exclude "*.res" \ --exclude "*~" \ + --exclude "*.c" \ --exclude "Makefile" \ - --exclude "crash.exe" \ - --exclude "openhardwaremonitor" \ + --exclude "windows/README" \ + --exclude "windows/crash.exe" \ + --exclude "windows/*.cc" \ + --exclude "windows/*.h" \ + --exclude "windows/openhardwaremonitor" \ + --exclude "windows/sections" \ --exclude .f12 $$(cd agents ; ls) cd $(DISTNAME) ; ../scripts/make_package_info $(VERSION) > package_info install -m 755 scripts/*.{sh,py} $(DISTNAME)

7 years, 7 months

← Newer
1
...
13
14
15
16
17
18
19
...
46
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits February 2017