Checkmk git commits December 2017

checkmk-commits@lists.checkmk.com

10 participants
219 discussions

5475 FIX Do not suppress recovery notifications via throttling.

by Sven Panne

Module: check_mk Branch: master Commit: 1eab0296858ba6dc1e7020f93c21993a21e4f5e3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1eab0296858ba6… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Wed Dec 20 16:15:48 2017 +0100 5475 FIX Do not suppress recovery notifications via throttling. When notification throttling was enabled, recovery notifications were not handled specially, so they could be suppressed just like problem notifications. This has been fixed, revovery notifications always pass through throttling now. Change-Id: I89cb56ac0842033b859064502b49c4f7db816b98 --- .werks/5475 | 13 +++++++++++++ cmk_base/notify.py | 4 ++++ 2 files changed, 17 insertions(+) diff --git a/.werks/5475 b/.werks/5475 new file mode 100644 index 0000000..232b28d --- /dev/null +++ b/.werks/5475 @@ -0,0 +1,13 @@ +Title: Do not suppress recovery notifications via throttling. +Level: 1 +Component: cmc +Compatible: compat +Edition: cee +Version: 1.5.0i3 +Date: 1513782696 +Class: fix + +When notification throttling was enabled, recovery notifications were not +handled specially, so they could be suppressed just like problem +notifications. This has been fixed, revovery notifications always pass +through throttling now. diff --git a/cmk_base/notify.py b/cmk_base/notify.py index ff01fc5..acb6abb 100644 --- a/cmk_base/notify.py +++ b/cmk_base/notify.py @@ -695,6 +695,10 @@ def rbn_match_escalation(rule, context): def rbn_match_escalation_throtte(rule, context): if "match_escalation_throttle" in rule: + # We do not want to suppress recovery notifications. + if (context["WHAT"] == "HOST" and context.get("HOSTSTATE", "UP") == "UP") or \ + (context["WHAT"] == "SERVICE" and context.get("SERVICESTATE", "OK") == "OK"): + return from_number, rate = rule["match_escalation_throttle"] if context["WHAT"] == "HOST": notification_number = int(context.get("HOSTNOTIFICATIONNUMBER", 1))

6 years, 9 months

Changed some evaluations of salesforce instance states

by Simon Betz

Module: check_mk Branch: master Commit: 2dfc839caaef4356fe66f391039b8682f9517791 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2dfc839caaef43… Author: Simon Betz <si(a)mathias-kettner.de> Date: Wed Dec 20 15:32:09 2017 +0100 Changed some evaluations of salesforce instance states Change-Id: I5f0574677430700288b1a31aac858346026c1e69 --- checks/salesforce_instances | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/checks/salesforce_instances b/checks/salesforce_instances index 84518b0..6e09451 100644 --- a/checks/salesforce_instances +++ b/checks/salesforce_instances @@ -46,12 +46,12 @@ def inventory_salesforce_instances(parsed): def check_salesforce_instances(item, params, parsed): map_states = { "OK": (0, "OK"), - "MAJOR_INCIDENT_CORE": (0, "major incident core"), - "MINOR_INCIDENT_CORE": (0, "minor incident core"), + "MAJOR_INCIDENT_CORE": (2, "major incident core"), + "MINOR_INCIDENT_CORE": (1, "minor incident core"), "MAINTENANCE_CORE": (0, "maintenance core"), "INFORMATIONAL_CORE": (0, "informational core"), - "MAJOR_INCIDENT_NONCORE": (0, "major incident noncore"), - "MINOR_INCIDENT_NONCORE": (0, "minor incident noncore"), + "MAJOR_INCIDENT_NONCORE": (2, "major incident noncore"), + "MINOR_INCIDENT_NONCORE": (1, "minor incident noncore"), "MAINTENANCE_NONCORE": (0, "maintenance noncore"), "INFORMATIONAL_NONCORE": (0, "informational noncore"), }

6 years, 9 months

Added some informational states to check plugin salesforce_instances

by Simon Betz

Module: check_mk Branch: master Commit: ffc2b309c3e9cb09a1cc32003357ee2aae01edbc URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ffc2b309c3e9cb… Author: Simon Betz <si(a)mathias-kettner.de> Date: Wed Dec 20 15:29:59 2017 +0100 Added some informational states to check plugin salesforce_instances Change-Id: I25cd024739c571793621d772964cc59f1a152adc --- checks/salesforce_instances | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/checks/salesforce_instances b/checks/salesforce_instances index 89dac3e..84518b0 100644 --- a/checks/salesforce_instances +++ b/checks/salesforce_instances @@ -44,13 +44,23 @@ def inventory_salesforce_instances(parsed): def check_salesforce_instances(item, params, parsed): + map_states = { + "OK": (0, "OK"), + "MAJOR_INCIDENT_CORE": (0, "major incident core"), + "MINOR_INCIDENT_CORE": (0, "minor incident core"), + "MAINTENANCE_CORE": (0, "maintenance core"), + "INFORMATIONAL_CORE": (0, "informational core"), + "MAJOR_INCIDENT_NONCORE": (0, "major incident noncore"), + "MINOR_INCIDENT_NONCORE": (0, "minor incident noncore"), + "MAINTENANCE_NONCORE": (0, "maintenance noncore"), + "INFORMATIONAL_NONCORE": (0, "informational noncore"), + } + for entry in parsed: if entry.get("key") == item: - if entry.get("status") != "OK": - yield 2, "Status: %s" % entry.get("status", "not OK") - else: - yield 0, "Status: OK" - + status = entry.get("status") + state, state_readable = map_states.get(status, (3, "unknown[%s]" % status)) + yield state, "Status: %s" % state_readable if entry.get("environment"): yield 0, "Environment: %s" % entry["environment"] release_info = []

6 years, 9 months

5474 FIX Revocery notifications have at least notification number 1

by Sven Panne

Module: check_mk Branch: master Commit: 804b1bb797f61f178e596504e8ef33b3859d30a4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=804b1bb797f61f… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Wed Dec 20 15:27:32 2017 +0100 5474 FIX Revocery notifications have at least notification number 1 When periodic notifications were off, recovery notifications were sent out with notification number 0. This is different from what nagios does and it is inconsistent: Recovery notifications should have the same notification number as their corresponding problem notification. This has been fixed, the recovery notification numbers are now always at least 1, perhaps greater in case of periodic notifications. Change-Id: Ib145f88381d7cb65ca8dcb83a90dcdddf64cd1a8 --- .werks/5474 | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/.werks/5474 b/.werks/5474 new file mode 100644 index 0000000..e90e354 --- /dev/null +++ b/.werks/5474 @@ -0,0 +1,15 @@ +Title: Revocery notifications have at least notification number 1 +Level: 1 +Component: cmc +Compatible: compat +Edition: cee +Version: 1.5.0i3 +Date: 1513779635 +Class: fix + +When periodic notifications were off, recovery notifications were sent out +with notification number 0. This is different from what nagios does and it +is inconsistent: Recovery notifications should have the same notification +number as their corresponding problem notification. This has been fixed, +the recovery notification numbers are now always at least 1, perhaps greater +in case of periodic notifications.

6 years, 9 months

5588 Agent bakery: Added search form to filter the table of baked agents

by Lars Michelsen

Module: check_mk Branch: master Commit: cb55cc69242b22b4f6a67b9c85fbbdc398e4e1a8 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=cb55cc69242b22… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Dec 20 13:43:45 2017 +0100 5588 Agent bakery: Added search form to filter the table of baked agents Change-Id: Ice11902084b19fbea76d379d9085b40bec9e8492 --- .werks/5588 | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.werks/5588 b/.werks/5588 new file mode 100644 index 0000000..9bf1fa3 --- /dev/null +++ b/.werks/5588 @@ -0,0 +1,9 @@ +Title: Agent bakery: Added search form to filter the table of baked agents +Level: 1 +Component: agents +Compatible: compat +Edition: cee +Version: 1.5.0i3 +Date: 1513773783 +Class: feature +

6 years, 9 months

Updated bug entries #3051

by Lars Michelsen

Module: check_mk Branch: master Commit: a8498e22066a9b34f21fbc446fccce03be9d3054 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a8498e22066a9b… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Dec 20 11:25:12 2017 +0100 Updated bug entries #3051 Change-Id: I47efee1e48335bc1730386a93754ad50e14032c3 --- .bugs/3051 | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/.bugs/3051 b/.bugs/3051 new file mode 100644 index 0000000..3688950 --- /dev/null +++ b/.bugs/3051 @@ -0,0 +1,24 @@ +Title: Bakery: New host does not have an agent by default +Component: wato +State: open +Date: 2017-12-20 11:21:26 +Targetversion: 1.5.0 +Class: bug + +When using the agent bakery, e.g. only with the VANILLA and GENERIC agent and a new host is being added to the +monitoring, the bakery does not find an agent for this new host. + +The "host agent" page is also showing no agent: + +http://localhost/heute/check_mk/wato.py?folder=&host=localhost&mode=agent_of_host# + +This seems to be caused by the agent_bakery.find_agents_of_host function which assumes that the hosts can be +matched explicitly by the stored agent configs. + +Since the new host was not available during last baking, the host is not listed in the agent configs and no +agent is matching. + +How to solve this? + +Idea #1: Mark the bakery dirty on new / renamed hosts? +Idea #2: Change agent_bakery.find_agents_of_host to match at least the GENERIC agent for these hosts?

6 years, 9 months

5589 Agent bakery: ... (X hosts) text can now be clicked to show all hosts of a backed agent

by Lars Michelsen

Module: check_mk Branch: master Commit: b4f722e475c8263257413996b04f00a18cb23b6f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b4f722e475c826… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Dec 20 14:48:11 2017 +0100 5589 Agent bakery: ... (X hosts) text can now be clicked to show all hosts of a backed agent Change-Id: Id4010a4ae73c3bf6f861507dbd177e203416a543 --- .werks/5589 | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.werks/5589 b/.werks/5589 new file mode 100644 index 0000000..3e57535 --- /dev/null +++ b/.werks/5589 @@ -0,0 +1,10 @@ +Title: Agent bakery: ... (X hosts) text can now be clicked to show all hosts of a backed agent +Level: 1 +Component: agents +Compatible: compat +Edition: cee +Version: 1.5.0i3 +Date: 1513777646 +Class: feature + +

6 years, 9 months

5587 Agent updater: Display user name on password prompt during registration

by Lars Michelsen

Module: check_mk Branch: master Commit: 2d987698607ff87137630bdd8da4c6a46a892cb6 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2d987698607ff8… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Dec 20 11:14:21 2017 +0100 5587 Agent updater: Display user name on password prompt during registration When the agent updater asks the user for the password of the admin user to perform the registration with and the user has not just been inserted, the agent updater will print the user name the password is asked for on the command prompt. Change-Id: I8bda41f63be1f6c2732772b72ca068fa011fd8ab --- .werks/5587 | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.werks/5587 b/.werks/5587 new file mode 100644 index 0000000..f19f95a --- /dev/null +++ b/.werks/5587 @@ -0,0 +1,13 @@ +Title: Agent updater: Display user name on password prompt during registration +Level: 1 +Component: agents +Compatible: compat +Edition: cee +Version: 1.5.0i2 +Date: 1513764777 +Class: feature + +When the agent updater asks the user for the password of the admin user to +perform the registration with and the user has not just been inserted, the +agent updater will print the user name the password is asked for on the +command prompt.

6 years, 9 months

Reserved 20 bug IDS

by Lars Michelsen

Module: check_mk Branch: master Commit: e53124cae29beef7707fb313d6de1aac294a75b8 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e53124cae29bee… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Dec 20 11:21:22 2017 +0100 Reserved 20 bug IDS Change-Id: I7cbadb415d4644eacc9721dcac5526f3c9184738 --- .bugs/first_free | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.bugs/first_free b/.bugs/first_free index 08022a4..4b99933 100644 --- a/.bugs/first_free +++ b/.bugs/first_free @@ -1 +1 @@ -3051 +3071

6 years, 9 months

Updated bug entries #0912, #0853

by Lars Michelsen

Module: check_mk Branch: master Commit: 89e7dbecc7b4fcf370790b2497728b982fbd0a80 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=89e7dbecc7b4fc… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Dec 20 08:56:38 2017 +0100 Updated bug entries #0912, #0853 Change-Id: I159dc086485d66dce6d70caa6b09a2d8d19c6507 --- .bugs/853 | 7 +++++-- .bugs/912 | 7 +++++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/.bugs/853 b/.bugs/853 index 5b24245..1b01c72 100644 --- a/.bugs/853 +++ b/.bugs/853 @@ -1,8 +1,11 @@ Title: Wato Distributed Setup: Liveproxy Component: wato -State: open +Class: nastiness +State: done Date: 2015-08-10 15:41:06 Targetversion: 1.2.7 -Class: nastiness The Liveproxy has lot of settings who the most of the useres never change. This settings should be hidded per default + +2017-12-20 08:54:41: changed state open -> done +Has been moved to global settings as default setting. Sites now use the global value by default. diff --git a/.bugs/912 b/.bugs/912 index 6983948..04ec5f5 100644 --- a/.bugs/912 +++ b/.bugs/912 @@ -1,9 +1,12 @@ Title: Distributed WATO - activate changes -> restart shows no progress bar Component: wato -State: open +Class: nastiness +State: done Date: 2013-02-04 10:08:08 Targetversion: 1.2.2 -Class: nastiness When clicking on "restart" for a single site, no background action with a progress bar is started. Instead, the browser only shows a loading mouse pointer. + +2017-12-20 08:55:09: changed state open -> done +Fixed

6 years, 9 months

← Newer
1
2
3
4
5
6
7
...
22
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits December 2017