Checkmk git commits September 2016

checkmk-commits@lists.checkmk.com

9 participants
301 discussions

3814 FIX win_netstat: fixed unicode warning while parsing data

by Andreas Boesl

Module: check_mk Branch: master Commit: f59e711d4735f9c9763471bbdc63f4fe9e9a7387 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f59e711d4735f9… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Mon Sep 26 16:04:03 2016 +0200 3814 FIX win_netstat: fixed unicode warning while parsing data --- .werks/3814 | 9 +++++++++ ChangeLog | 1 + checks/win_netstat | 2 +- 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/.werks/3814 b/.werks/3814 new file mode 100644 index 0000000..114ec40 --- /dev/null +++ b/.werks/3814 @@ -0,0 +1,9 @@ +Title: win_netstat: fixed unicode warning while parsing data +Level: 1 +Component: checks +Compatible: compat +Version: 1.4.0i1 +Date: 1474898629 +Class: fix + + diff --git a/ChangeLog b/ChangeLog index 9de7d78..4e24b70 100644 --- a/ChangeLog +++ b/ChangeLog @@ -410,6 +410,7 @@ * 3888 FIX: df checks: Fixed invalid displayed WARN / CRIT lines in graphs when using "bytes left" thresholds * 3840 FIX: cisco_qos: Fixed wrong units in graphs... * 3890 FIX: check_mk_agent.openbsd: Fixed broken MRPE checks + * 3814 FIX: win_netstat: fixed unicode warning while parsing data Multisite: * 3187 notification view: new filter for log command via regex diff --git a/checks/win_netstat b/checks/win_netstat index fb247b3..3853095 100644 --- a/checks/win_netstat +++ b/checks/win_netstat @@ -54,7 +54,7 @@ win_netstat_states = { # German - "ABH\x99REN" : "LISTENING", + u"ABH\x99REN" : "LISTENING", "HERGESTELLT" : "ESTABLISHED", "WARTEND" : "TIME_WAIT", # Add further states in any required language here. Sorry, Windows

7 years, 11 months

Regenerated .exe files

by Sven Panne

Module: check_mk Branch: master Commit: 898299ac67770dd5d48c267e40b558e8168dab7b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=898299ac67770d… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Mon Sep 26 15:32:23 2016 +0200 Regenerated .exe files Note for the future: Please do a "make format" in the top-level directory of this project before checking in C++ files, otherwise we'll get spurious commits like this. We should really, really move all build artifacts out of version control... :-/ To show just a few numbers: A quick check with the BFG Repo-Cleaner (https://rtyley.github.io/bfg-repo-cleaner/) shows that our bare check_mk repo shrinks from 290MB to 84MB when the .exe files are removed. In other words, 71% of the whole repo are just build artifacts. --- agents/windows/build_version | 2 +- agents/windows/check_mk_agent-64.exe | Bin 1323008 -> 1323008 bytes agents/windows/check_mk_agent-64.unstripped.exe | Bin 15007391 -> 15346336 bytes agents/windows/check_mk_agent-64.unversioned.exe | Bin 1323008 -> 1323008 bytes agents/windows/check_mk_agent.exe | Bin 1297408 -> 1297408 bytes agents/windows/check_mk_agent.msi | Bin 2890240 -> 2890240 bytes agents/windows/check_mk_agent.unstripped.exe | Bin 13270746 -> 13270746 bytes agents/windows/check_mk_agent.unversioned.exe | Bin 1297408 -> 1297408 bytes agents/windows/install_agent-64.exe | Bin 584255 -> 584188 bytes agents/windows/install_agent.exe | Bin 580929 -> 580926 bytes 10 files changed, 1 insertion(+), 1 deletion(-) diff --git a/agents/windows/build_version b/agents/windows/build_version index d84af76..cf7d7d1 100644 --- a/agents/windows/build_version +++ b/agents/windows/build_version @@ -1 +1 @@ -2085 +2087 diff --git a/agents/windows/check_mk_agent-64.exe b/agents/windows/check_mk_agent-64.exe index 8bcf0d1..9c7f963 100755 Binary files a/agents/windows/check_mk_agent-64.exe and b/agents/windows/check_mk_agent-64.exe differ diff --git a/agents/windows/check_mk_agent-64.unstripped.exe b/agents/windows/check_mk_agent-64.unstripped.exe index 559f31a..bea4148 100755 Binary files a/agents/windows/check_mk_agent-64.unstripped.exe and b/agents/windows/check_mk_agent-64.unstripped.exe differ diff --git a/agents/windows/check_mk_agent-64.unversioned.exe b/agents/windows/check_mk_agent-64.unversioned.exe index 6ab8c42..529be0c 100755 Binary files a/agents/windows/check_mk_agent-64.unversioned.exe and b/agents/windows/check_mk_agent-64.unversioned.exe differ diff --git a/agents/windows/check_mk_agent.exe b/agents/windows/check_mk_agent.exe index ffb72da..7b6af7b 100755 Binary files a/agents/windows/check_mk_agent.exe and b/agents/windows/check_mk_agent.exe differ diff --git a/agents/windows/check_mk_agent.msi b/agents/windows/check_mk_agent.msi index 8bc89fd..93699a4 100755 Binary files a/agents/windows/check_mk_agent.msi and b/agents/windows/check_mk_agent.msi differ diff --git a/agents/windows/check_mk_agent.unstripped.exe b/agents/windows/check_mk_agent.unstripped.exe index 9acda74..32c613b 100755 Binary files a/agents/windows/check_mk_agent.unstripped.exe and b/agents/windows/check_mk_agent.unstripped.exe differ diff --git a/agents/windows/check_mk_agent.unversioned.exe b/agents/windows/check_mk_agent.unversioned.exe index 9c1d465..4344e08 100755 Binary files a/agents/windows/check_mk_agent.unversioned.exe and b/agents/windows/check_mk_agent.unversioned.exe differ diff --git a/agents/windows/install_agent-64.exe b/agents/windows/install_agent-64.exe index a193b30..b1002c8 100755 Binary files a/agents/windows/install_agent-64.exe and b/agents/windows/install_agent-64.exe differ diff --git a/agents/windows/install_agent.exe b/agents/windows/install_agent.exe index d9b4622..d671fa7 100755 Binary files a/agents/windows/install_agent.exe and b/agents/windows/install_agent.exe differ

7 years, 11 months

3747 epson_beamer_lamp: New check to monitor the lamp operation time of Epson beamers

by Konstantin Büttner

Module: check_mk Branch: master Commit: 6d39081515766b140ed0d8446026c038e1da67aa URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=6d39081515766b… Author: Konstantin Büttner <kb(a)mathias-kettner.de> Date: Mon Sep 26 15:15:36 2016 +0200 3747 epson_beamer_lamp: New check to monitor the lamp operation time of Epson beamers --- .werks/3747 | 9 ++++++ ChangeLog | 1 + checkman/epson_beamer_lamp | 10 ++++++ checks/epson_beamer_lamp | 60 ++++++++++++++++++++++++++++++++++++ web/plugins/wato/check_parameters.py | 14 +++++++++ 5 files changed, 94 insertions(+) diff --git a/.werks/3747 b/.werks/3747 new file mode 100644 index 0000000..e4e7afd --- /dev/null +++ b/.werks/3747 @@ -0,0 +1,9 @@ +Title: epson_beamer_lamp: New check to monitor the lamp operation time of Epson beamers +Level: 1 +Component: checks +Compatible: compat +Version: 1.4.0i1 +Date: 1474895699 +Class: feature + + diff --git a/ChangeLog b/ChangeLog index c9c0568..9de7d78 100644 --- a/ChangeLog +++ b/ChangeLog @@ -171,6 +171,7 @@ * 3878 apc_symmetra: divided into several checks... NOTE: Please refer to the migration notes! * 3879 ipmi, ipmi_sensors: unified ipmi checks which now work the same way... + * 3747 epson_beamer_lamp: New check to monitor the lamp operation time of Epson beamers * 3073 FIX: windows agent: relative paths to mrpe scripts are now treated as relative to the agent installation directory... * 3061 FIX: mk_jolokia: Fixed debugging of the agent plugin * 3074 FIX: windows agent: fixed incorrect values for 32-bit performance counters diff --git a/checkman/epson_beamer_lamp b/checkman/epson_beamer_lamp new file mode 100644 index 0000000..521bf66 --- /dev/null +++ b/checkman/epson_beamer_lamp @@ -0,0 +1,10 @@ +title: Lamp runtime of Epson beamers +agents: snmp +catalog: hw/environment/epson +license: GPL +distribution: check_mk +description: + This check monitors the lamp runtime of Epson beamers. + +inventory: + One service per beamer is created. diff --git a/checks/epson_beamer_lamp b/checks/epson_beamer_lamp new file mode 100644 index 0000000..994c51a --- /dev/null +++ b/checks/epson_beamer_lamp @@ -0,0 +1,60 @@ +#!/usr/bin/python +# -*- encoding: utf-8; py-indent-offset: 4 -*- +# +------------------------------------------------------------------+ +# | ____ _ _ __ __ _ __ | +# | / ___| |__ ___ ___| | __ | \/ | |/ / | +# | | | | '_ \ / _ \/ __| |/ / | |\/| | ' / | +# | | |___| | | | __/ (__| < | | | | . \ | +# | \____|_| |_|\___|\___|_|\_\___|_| |_|_|\_\ | +# | | +# | Copyright Mathias Kettner 2016 mk(a)mathias-kettner.de | +# +------------------------------------------------------------------+ +# +# This file is part of Check_MK. +# The official homepage is at http://mathias-kettner.de/check_mk. +# +# check_mk is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License as published by +# the Free Software Foundation in version 2. check_mk is distributed +# in the hope that it will be useful, but WITHOUT ANY WARRANTY; with- +# out even the implied warranty of MERCHANTABILITY or FITNESS FOR A +# PARTICULAR PURPOSE. See the GNU General Public License for more de- +# tails. You should have received a copy of the GNU General Public +# License along with GNU Make; see the file COPYING. If not, write +# to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, +# Boston, MA 02110-1301 USA. + +epson_beamer_lamp_default_levels = (1000*3600, 1500*3600) + + +def inventory_epson_beamer_lamp(info): + if info: + return [ (None, "epson_beamer_lamp_default_levels") ] + + +def check_epson_beamer_lamp(_no_item, params, info): + lamp_hrs = int(info[0][0]) + lamp_time = lamp_hrs * 3600 + status = 0 + infotext = "Operation time: %d h" % lamp_hrs + if params: + warn, crit = params + levelstext = " (warn/crit at %.0f/%.0f hours)" % tuple(map(lambda x: x/3600.0, params)) + if lamp_time >= crit: + status = 2 + elif lamp_time >= warn: + status = 1 + if status: + infotext += levelstext + return status, infotext + + + +check_info['epson_beamer_lamp'] = { + "inventory_function" : inventory_epson_beamer_lamp, + "check_function" : check_epson_beamer_lamp, + "service_description" : "Beamer Lamp", + "snmp_info" : (".1.3.6.1.4.1.1248.4.1.1.1.1", [ "0" ]), + "snmp_scan_function" : lambda oid: "1248" in oid(".1.3.6.1.2.1.1.2.0").lower(), + "group" : "lamp_operation_time", +} diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py index 4581310..d018160 100644 --- a/web/plugins/wato/check_parameters.py +++ b/web/plugins/wato/check_parameters.py @@ -3238,6 +3238,20 @@ register_check_parameters( match_type = "dict" ) + +register_check_parameters( + subgroup_environment, + "lamp_operation_time", + _("Beamer lamp operation time"), + Tuple( + elements = [ + Age(title = _("Warning at"), default_value = 1000*3600, display = [ "hours" ]), + Age(title = _("Critical at"), default_value = 1500*3600, display = [ "hours" ]), + ]), + None, + match_type = "first", +) + #. # .--Storage-------------------------------------------------------------. # | ____ _ |

7 years, 11 months

ListChoice/SSHKeyPair: Fixed possible duplicate HTTP var in forms (add_var =True was missing in hidden_field calls)

by Lars Michelsen

Module: check_mk Branch: master Commit: d0044b82dfea619ce9aab8de603dad5e199a12b7 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d0044b82dfea61… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Sep 26 14:47:53 2016 +0200 ListChoice/SSHKeyPair: Fixed possible duplicate HTTP var in forms (add_var=True was missing in hidden_field calls) --- web/htdocs/valuespec.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/web/htdocs/valuespec.py b/web/htdocs/valuespec.py index c8ac050..8e084c2 100644 --- a/web/htdocs/valuespec.py +++ b/web/htdocs/valuespec.py @@ -1765,7 +1765,7 @@ class ListChoice(ValueSpec): html.write("</td>") html.write("</tr></table>") # Make sure that at least one variable with the prefix is present - html.hidden_field(varprefix, "1") + html.hidden_field(varprefix, "1", add_var=True) def value_to_text(self, value): self.load_elements() @@ -3908,7 +3908,7 @@ class SSHKeyPair(ValueSpec): def render_input(self, varprefix, value): if value: html.write(_("Fingerprint: %s") % self.value_to_text(value)) - html.hidden_field(varprefix, self._encode_key_for_url(value)) + html.hidden_field(varprefix, self._encode_key_for_url(value), add_var=True) else: html.write(_("Key pair will be generated when you save."))

7 years, 11 months

Updated bug entries #2469

by Lars Michelsen

Module: check_mk Branch: master Commit: dcc6276c5e989b1bd5540560baa155c8fcd0beb8 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=dcc6276c5e989b… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Sep 26 14:49:45 2016 +0200 Updated bug entries #2469 --- .bugs/2469 | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.bugs/2469 b/.bugs/2469 new file mode 100644 index 0000000..d3360ea --- /dev/null +++ b/.bugs/2469 @@ -0,0 +1,9 @@ +Title: Timeofday()/AbsolueDate() are inconsistent with their default values +Component: multisite +State: open +Date: 2016-09-26 14:48:34 +Targetversion: 1.2.8 +Class: nastiness + +Timeofday() does not have the current time filled in by default, but AbsolueDate() has. +This should be changed to be consistent.

7 years, 11 months

Fixed lib_dir location. Should be lib/ instead of lib/check_mk

by Lars Michelsen

Module: check_mk Branch: master Commit: 2719a0a9a16fdb808d9309dcbfb54319cf231352 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2719a0a9a16fdb… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Sep 26 14:44:01 2016 +0200 Fixed lib_dir location. Should be lib/ instead of lib/check_mk --- lib/paths.py | 2 +- modules/packaging.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/paths.py b/lib/paths.py index 5ddb2a1..82e2ae2 100644 --- a/lib/paths.py +++ b/lib/paths.py @@ -169,7 +169,7 @@ def _set_overridable_paths(local=False): var_prefix+"doc_dir" : os.path.join(omd_root, rel_base, "share/doc/check_mk"), var_prefix+"locale_dir" : os.path.join(omd_root, rel_base, "share/check_mk/locale"), var_prefix+"bin_dir" : os.path.join(omd_root, rel_base, "bin"), - var_prefix+"lib_dir" : os.path.join(omd_root, rel_base, "lib/check_mk"), + var_prefix+"lib_dir" : os.path.join(omd_root, rel_base, "lib"), }) diff --git a/modules/packaging.py b/modules/packaging.py index e0a2835..3b53289 100644 --- a/modules/packaging.py +++ b/modules/packaging.py @@ -57,8 +57,8 @@ package_parts = [ (part, title, perm, ldir and ldir or dir) for part, title, per ( "web", "Multisite extensions", 0644, cmk.paths.web_dir, cmk.paths.local_web_dir ), ( "pnp-templates", "PNP4Nagios templates", 0644, cmk.paths.pnp_templates_dir, cmk.paths.local_pnp_templates_dir ), ( "doc", "Documentation files", 0644, cmk.paths.doc_dir, cmk.paths.local_doc_dir ), - ( "bin", "Binaries", 0755, None, cmk.paths.local_bin_dir ), - ( "lib", "Libraries", 0644, None, cmk.paths.local_lib_dir), + ( "bin", "Binaries", 0755, None, cmk.paths.local_bin_dir ), + ( "lib", "Libraries", 0644, None, cmk.paths.local_lib_dir), ]] package_ignored_files = {

7 years, 11 months

clang-formatted

by Sven Panne

Module: check_mk Branch: master Commit: c86264ab1e370a0ebaa8a1bd42eb67cacb75bac2 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c86264ab1e370a… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Mon Sep 26 14:03:18 2016 +0200 clang-formatted --- agents/windows/ExternalCmd.cc | 3 --- livestatus/src/TableEventConsoleStatus.cc | 25 +++++++++++++------------ 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/agents/windows/ExternalCmd.cc b/agents/windows/ExternalCmd.cc index 78dbb09..8287536 100644 --- a/agents/windows/ExternalCmd.cc +++ b/agents/windows/ExternalCmd.cc @@ -48,7 +48,6 @@ ExternalCmd::ExternalCmd(const char *cmdline) { // child process needs to be able to inherit the pipe handles security_attributes.bInheritHandle = true; - if (!CreatePipe(&_stdout, &_script_stdout, &security_attributes, 0)) { throw win_exception("failed to create pipe"); } @@ -69,7 +68,6 @@ ExternalCmd::ExternalCmd(const char *cmdline) { si.hStdOutput = _script_stdout; si.hStdError = with_stderr ? _script_stdout : _script_stderr; - PROCESS_INFORMATION pi; ZeroMemory(&pi, sizeof(PROCESS_INFORMATION)); std::unique_ptr<char[], decltype(free) *> cmdline_buf(strdup(cmdline), @@ -110,7 +108,6 @@ void ExternalCmd::closeScriptHandles() { ::CloseHandle(_script_stdout); } - DWORD ExternalCmd::exitCode() { DWORD res; GetExitCodeProcess(_process, &res); diff --git a/livestatus/src/TableEventConsoleStatus.cc b/livestatus/src/TableEventConsoleStatus.cc index 5f26b80..fa48bcb 100644 --- a/livestatus/src/TableEventConsoleStatus.cc +++ b/livestatus/src/TableEventConsoleStatus.cc @@ -36,20 +36,19 @@ TableEventConsoleStatus::TableEventConsoleStatus() addColumn(new IntEventConsoleColumn( "status_config_load_time", "The time when the Event Console config was loaded")); - addColumn(new IntEventConsoleColumn( - "status_num_open_events", - "The number of currently open events")); - addColumn(new IntEventConsoleColumn( - "status_virtual_memory_size", - "The current virtual memory size in bytes")); + addColumn(new IntEventConsoleColumn("status_num_open_events", + "The number of currently open events")); + addColumn( + new IntEventConsoleColumn("status_virtual_memory_size", + "The current virtual memory size in bytes")); addColumn(new IntEventConsoleColumn( "status_messages", "The number of messages received since startup of the Event Console")); addColumn(new DoubleEventConsoleColumn("status_message_rate", "The incoming message rate")); - addColumn(new DoubleEventConsoleColumn("status_average_message_rate", - "The average incoming message rate")); + addColumn(new DoubleEventConsoleColumn( + "status_average_message_rate", "The average incoming message rate")); addColumn( new IntEventConsoleColumn("status_connects", "The number of connects")); addColumn(new DoubleEventConsoleColumn("status_connect_rate", @@ -86,10 +85,12 @@ TableEventConsoleStatus::TableEventConsoleStatus() addColumn(new DoubleEventConsoleColumn("status_average_rule_hit_rate", "The average rule hit rate")); - addColumn(new DoubleEventConsoleColumn("status_average_processing_time", - "The average incoming message processing time")); - addColumn(new DoubleEventConsoleColumn("status_average_request_time", - "The average status client request time")); + addColumn(new DoubleEventConsoleColumn( + "status_average_processing_time", + "The average incoming message processing time")); + addColumn( + new DoubleEventConsoleColumn("status_average_request_time", + "The average status client request time")); addColumn(new DoubleEventConsoleColumn("status_average_sync_time", "The average sync time")); addColumn(new StringEventConsoleColumn(

7 years, 11 months

IWYU

by Sven Panne

Module: check_mk Branch: master Commit: 90804ca29ac2b758106225f5b5d0cea860311121 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=90804ca29ac2b7… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Mon Sep 26 14:20:30 2016 +0200 IWYU --- livestatus/src/OutputBuffer.cc | 1 - livestatus/src/ServicelistFilter.cc | 1 + livestatus/src/module.cc | 1 - livestatus/src/unixcat.cc | 1 - 4 files changed, 1 insertion(+), 3 deletions(-) diff --git a/livestatus/src/OutputBuffer.cc b/livestatus/src/OutputBuffer.cc index 8557370..d7457af 100644 --- a/livestatus/src/OutputBuffer.cc +++ b/livestatus/src/OutputBuffer.cc @@ -24,7 +24,6 @@ #include "OutputBuffer.h" #include <sys/select.h> -#include <sys/time.h> #include <unistd.h> #include <chrono> #include <cstdio> diff --git a/livestatus/src/ServicelistFilter.cc b/livestatus/src/ServicelistFilter.cc index 0a36cb8..df62d11 100644 --- a/livestatus/src/ServicelistFilter.cc +++ b/livestatus/src/ServicelistFilter.cc @@ -22,6 +22,7 @@ // to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, // Boston, MA 02110-1301 USA. +// IWYU pragma: no_include <ext/alloc_traits.h> #include "ServicelistFilter.h" #include <cstring> #include <ostream> diff --git a/livestatus/src/module.cc b/livestatus/src/module.cc index e0eea10..2ead0fb 100644 --- a/livestatus/src/module.cc +++ b/livestatus/src/module.cc @@ -31,7 +31,6 @@ #include <sys/select.h> #include <sys/socket.h> #include <sys/stat.h> -#include <sys/time.h> #include <sys/types.h> // IWYU pragma: keep #include <sys/un.h> #include <unistd.h> diff --git a/livestatus/src/unixcat.cc b/livestatus/src/unixcat.cc index 80d6ac7..eaebf2f 100644 --- a/livestatus/src/unixcat.cc +++ b/livestatus/src/unixcat.cc @@ -26,7 +26,6 @@ #include <sys/select.h> #include <sys/socket.h> #include <sys/stat.h> -#include <sys/time.h> #include <sys/types.h> // IWYU pragma: keep #include <sys/un.h> #include <unistd.h>

7 years, 11 months

Less debug output

by Sven Panne

Module: check_mk Branch: master Commit: 78403467584b0cb6bf905bf0aa0bd9918e4a4602 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=78403467584b0c… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Mon Sep 26 14:04:19 2016 +0200 Less debug output --- Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/Makefile b/Makefile index 34f573d..5bf1583 100644 --- a/Makefile +++ b/Makefile @@ -281,7 +281,6 @@ livestatus/config.h: livestatus/configure livestatus/config.h.in cd livestatus && ./configure CXXFLAGS="$(CXX_FLAGS)" GTAGS: livestatus/config.h - @echo "making $@: $? is newer" $(MAKE) -C livestatus distclean-tags $(MAKE) -C livestatus GTAGS

7 years, 11 months

Make recent clang-tidy versions happy.

by Sven Panne

Module: check_mk Branch: master Commit: 0a03e47bd0c839411a536f563e22183435cc7da5 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=0a03e47bd0c839… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Mon Sep 26 14:33:29 2016 +0200 Make recent clang-tidy versions happy. --- livestatus/src/unixcat.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/livestatus/src/unixcat.cc b/livestatus/src/unixcat.cc index eaebf2f..7233a79 100644 --- a/livestatus/src/unixcat.cc +++ b/livestatus/src/unixcat.cc @@ -62,7 +62,8 @@ ssize_t read_with_timeout(int from, char *buffer, int size, int us) { } void *copy_thread(void *info) { - signal(SIGWINCH, SIG_IGN); + // https://llvm.org/bugs/show_bug.cgi?id=29089 + signal(SIGWINCH, SIG_IGN); // NOLINT struct thread_info *ti = reinterpret_cast<struct thread_info *>(info); int from = ti->from; @@ -113,7 +114,8 @@ int main(int argc, char **argv) { exit(1); } - signal(SIGWINCH, SIG_IGN); + // https://llvm.org/bugs/show_bug.cgi?id=29089 + signal(SIGWINCH, SIG_IGN); // NOLINT const char *unixpath = argv[1]; struct stat st;

7 years, 11 months

← Newer
1
...
6
7
8
9
10
11
12
...
31
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits September 2016