Checkmk git commits August 2016

checkmk-commits@lists.checkmk.com

8 participants
256 discussions

FIX mkeventd.py for sites with disabled Event Console

by Marcel Schulte

Module: check_mk Branch: master Commit: 931fd7c15792d8bab5381f6806462a8349c09c02 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=931fd7c15792d8… Author: Marcel Schulte <ms(a)mathias-kettner.de> Date: Thu Aug 4 12:33:17 2016 +0200 FIX mkeventd.py for sites with disabled Event Console --- web/plugins/wato/mkeventd.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/web/plugins/wato/mkeventd.py b/web/plugins/wato/mkeventd.py index 20dcf0d..e9d2093 100644 --- a/web/plugins/wato/mkeventd.py +++ b/web/plugins/wato/mkeventd.py @@ -2680,7 +2680,7 @@ if mkeventd_enabled: # do not run an own eventd but want to query one or send notifications # to one. group = _("Notifications") -register_configvar(groups["ec"], +register_configvar(group, "mkeventd_notify_contactgroup", GroupSelection( "contact", @@ -2699,7 +2699,7 @@ register_configvar(groups["ec"], domain = "multisite", need_restart = True) -register_configvar(groups["ec"], +register_configvar(group, "mkeventd_notify_remotehost", Optional( TextAscii( @@ -2719,7 +2719,7 @@ register_configvar(groups["ec"], domain = "multisite", need_restart = True) -register_configvar(groups["ec"], +register_configvar(group, "mkeventd_notify_facility", DropdownChoice( title = _("Syslog facility for Event Console notifications"),

8 years, 1 month

Guard against mixing up check results from different hosts.

by Sven Panne

Module: check_mk Branch: master Commit: 8bb5727619c50c0394ee9c6f637fea476314eb27 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8bb5727619c50c… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Thu Aug 4 10:48:14 2016 +0200 Guard against mixing up check results from different hosts. --- modules/check_mk_base.py | 4 ++-- modules/discovery.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/check_mk_base.py b/modules/check_mk_base.py index 95d36ed..dabc466 100644 --- a/modules/check_mk_base.py +++ b/modules/check_mk_base.py @@ -1279,7 +1279,7 @@ def do_check(hostname, ipaddress, only_check_types = None): save_snmp_stats() if opt_keepalive: - add_keepalive_result_line(output) + add_keepalive_active_check_result(hostname, output) verbose(output) else: sys.stdout.write(core_state_names[status] + " - " + output.encode('utf-8')) @@ -1914,7 +1914,7 @@ def submit_check_result(host, servicedesc, result, sa, cached_at=None, cache_int def submit_to_core(host, service, state, output, cached_at = None, cache_interval = None): if opt_keepalive: # Regular case for the CMC - check helpers are running in keepalive mode - add_keepalive_check_result(service, state, output, cached_at, cache_interval) + add_keepalive_check_result(host, service, state, output, cached_at, cache_interval) elif check_submission == "pipe" or monitoring_core == "cmc": # In case of CMC this is used when running "cmk" manually diff --git a/modules/discovery.py b/modules/discovery.py index f91a33a..68c8b9e 100644 --- a/modules/discovery.py +++ b/modules/discovery.py @@ -383,7 +383,7 @@ def check_discovery(hostname, ipaddress=None): status = spec.get(what, 3) if opt_keepalive: - add_keepalive_result_line(output) + add_keepalive_active_check_result(hostname, output) return status else: sys.stdout.write(core_state_names[status] + " - " + output)

8 years, 1 month

3713 new filter: hosts with certain service problems

by Simon Betz

Module: check_mk Branch: master Commit: 2e6d46a84ee96e7795953abad4499533cb6d5a3e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2e6d46a84ee96e… Author: Simon Betz <si(a)mathias-kettner.de> Date: Thu Aug 4 11:14:15 2016 +0200 3713 new filter: hosts with certain service problems --- .werks/3713 | 9 +++++++++ ChangeLog | 1 + web/plugins/visuals/filters.py | 30 ++++++++++++++++++++++++++++++ 3 files changed, 40 insertions(+) diff --git a/.werks/3713 b/.werks/3713 new file mode 100644 index 0000000..4efb72d --- /dev/null +++ b/.werks/3713 @@ -0,0 +1,9 @@ +Title: new filter: hosts with certain service problems +Level: 1 +Component: multisite +Compatible: compat +Version: 1.4.0i1 +Date: 1470302026 +Class: feature + + diff --git a/ChangeLog b/ChangeLog index 85510f9..f49f6fc 100644 --- a/ChangeLog +++ b/ChangeLog @@ -346,6 +346,7 @@ * 3592 Views: Added sorter for host names (without site) * 3141 added user interfaces and permissions to view and acknowledge failed notifications * 3640 new filter option for status details: can now be negated + * 3713 new filter: hosts with certain service problems * 3059 FIX: Fixed highlighting of availability timeline time slices * 3175 FIX: Fix timeranges of graphs that are embedded in a dashboard... * 3076 FIX: fixed broken views in check_mk raw edition diff --git a/web/plugins/visuals/filters.py b/web/plugins/visuals/filters.py index 6e1e83e..8f89447 100644 --- a/web/plugins/visuals/filters.py +++ b/web/plugins/visuals/filters.py @@ -523,7 +523,37 @@ class FilterHostState(Filter): declare_filter(115, FilterHostState()) +class FilterHostsHavingServiceProblems(Filter): + def __init__(self): + Filter.__init__(self, "hosts_having_service_problems", + _("Hosts having certain service problems"), "host", + ["hosts_having_services_warn", "hosts_having_services_crit", + "hosts_having_services_pending", "hosts_having_services_unknown"], []) + + def display(self): + html.begin_checkbox_group() + for var, text in [ + ("warn", _("WARN")), + ("crit", _("CRIT")), + ("pending", _("PEND")), + ("unknown", _("UNKNOWN")), ]: + html.checkbox("hosts_having_services_%s" % var, True, label=text) + html.end_checkbox_group() + + def filter(self, infoname): + headers = [] + for var in [ "warn", "crit", "pending", "unknown" ]: + if html.get_checkbox("hosts_having_services_%s" % var) == True: + headers.append("Filter: num_services_%s > 0\n" % var) + + len_headers = len(headers) + if len_headers > 0: + headers.append("Or: %d\n" % len_headers) + return "".join(headers) + else: + return "" +declare_filter(120, FilterHostsHavingServiceProblems()) class FilterTristate(Filter): def __init__(self, name, title, info, column, deflt = -1):

8 years, 1 month

3757 FIX Bulk import: Ensuring non ASCII characters are not imported into regular attributes

by Lars Michelsen

Module: check_mk Branch: master Commit: 00c3cf12fa7fe8b21f77c4a97f7f4a67933253fe URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=00c3cf12fa7fe8… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Aug 4 09:57:56 2016 +0200 3757 FIX Bulk import: Ensuring non ASCII characters are not imported into regular attributes --- .werks/3757 | 10 ++++++++++ ChangeLog | 1 + web/htdocs/wato.py | 5 +++++ 3 files changed, 16 insertions(+) diff --git a/.werks/3757 b/.werks/3757 new file mode 100644 index 0000000..f299464 --- /dev/null +++ b/.werks/3757 @@ -0,0 +1,10 @@ +Title: Bulk import: Ensuring non ASCII characters are not imported into regular attributes +Level: 1 +Component: wato +Class: fix +Compatible: compat +State: unknown +Version: 1.4.0i1 +Date: 1470297437 + + diff --git a/ChangeLog b/ChangeLog index c0db3eb..85510f9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -526,6 +526,7 @@ * 3754 FIX: Cluster nodes are now correctly validated for invalid characters * 3755 FIX: Preventing to insert non ASCII characters in host addresses now * 3756 FIX: Bulk import: Fixed exception when host name contained special characters + * 3757 FIX: Bulk import: Ensuring non ASCII characters are not imported into regular attributes Notifications: * 3263 Notifications: allow users to restrict by their contact groups... diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index b4366b0..ca8bb11 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -3198,6 +3198,11 @@ class ModeBulkImport(WatoMode): if attribute == "alias": attributes[attribute] = value.decode("utf-8") else: + try: + unicode(value) + except: + raise MKUserError(None, _("Non-ASCII characters are not allowed in the " + "attribute \"%s\".") % attribute) attributes[attribute] = value if host_name == None:

8 years, 1 month

3756 FIX Bulk import: Fixed exception when host name contained special characters

by Lars Michelsen

Module: check_mk Branch: master Commit: a9dc506a197fa8707b98161453fedc9fe1612032 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a9dc506a197fa8… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Aug 4 09:53:25 2016 +0200 3756 FIX Bulk import: Fixed exception when host name contained special characters --- .werks/3756 | 10 ++++++++++ ChangeLog | 1 + web/htdocs/wato.py | 8 ++++---- 3 files changed, 15 insertions(+), 4 deletions(-) diff --git a/.werks/3756 b/.werks/3756 new file mode 100644 index 0000000..7b89307 --- /dev/null +++ b/.werks/3756 @@ -0,0 +1,10 @@ +Title: Bulk import: Fixed exception when host name contained special characters +Level: 1 +Component: wato +Class: fix +Compatible: compat +State: unknown +Version: 1.4.0i1 +Date: 1470297185 + + diff --git a/ChangeLog b/ChangeLog index 7f8b44f..c0db3eb 100644 --- a/ChangeLog +++ b/ChangeLog @@ -525,6 +525,7 @@ * 3735 FIX: Fixed wrong host search link in case of deleting site with hosts assigned * 3754 FIX: Cluster nodes are now correctly validated for invalid characters * 3755 FIX: Preventing to insert non ASCII characters in host addresses now + * 3756 FIX: Bulk import: Fixed exception when host name contained special characters Notifications: * 3263 Notifications: allow users to restrict by their contact groups... diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index 432ea6f..b4366b0 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -3074,7 +3074,7 @@ class ModeBulkImport(WatoMode): file_id = "%s-%d" % (config.user_id, int(time.time())) f = create_user_file(self._file_path(), "w") - f.write(content) + f.write(content.encode("utf-8")) f.close() # make selections available to next page @@ -3185,15 +3185,15 @@ class ModeBulkImport(WatoMode): for col_num, value in enumerate(row): attribute = html.var("attribute_%d" % col_num) if attribute == "host_name": - if not re.match('^[a-zA-Z0-9-_.]+$', value): - raise MKUserError(None, _("Invalid host name: %r. Only the characters a-z, A-Z, " - "0-9, _, . and - are allowed.") % value) + Hostname().validate_value(value, "host") host_name = value + elif attribute and attribute != "-": if attribute in attributes: raise MKUserError(None, _("The attribute \"%s\" is assigned to multiple columns. " "You can not populate one attribute from multiple columns. " "The column to attribute associations need to be unique.") % attribute) + # FIXME: Couldn't we decode all attributes? if attribute == "alias": attributes[attribute] = value.decode("utf-8")

8 years, 1 month

3755 FIX Preventing to insert non ASCII characters in host addresses now

by Lars Michelsen

Module: check_mk Branch: master Commit: a4746e22b06fffc8842be93a4f7e93fe6fdfde63 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a4746e22b06fff… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Aug 4 09:40:12 2016 +0200 3755 FIX Preventing to insert non ASCII characters in host addresses now --- .bugs/2465 | 7 ++- .werks/3755 | 9 ++++ ChangeLog | 1 + web/plugins/wato/builtin_attributes.py | 80 +++++++++++++++++--------------- 4 files changed, 58 insertions(+), 39 deletions(-) diff --git a/.bugs/2465 b/.bugs/2465 index 3a2de88..045cd05 100644 --- a/.bugs/2465 +++ b/.bugs/2465 @@ -1,9 +1,9 @@ Title: ipaddress and ipv6address attributes allow non ASCII characters Component: wato -State: open +Class: bug +State: done Date: 2016-08-03 17:09:06 Targetversion: 1.2.8 -Class: bug It's configured with the TextAttribute() object. Shouldn't we make it only accept ASCII characters just like the TextASCII() valuespec? Or change these attributes to ValueSpecAttribute() and really @@ -12,3 +12,6 @@ use TextAscii()? We should not allow non ascii characters in these fields. But there are umlaut domains. So: what do to? + +2016-08-04 09:37:35: changed state open -> done +Fixed in master diff --git a/.werks/3755 b/.werks/3755 new file mode 100644 index 0000000..217808c --- /dev/null +++ b/.werks/3755 @@ -0,0 +1,9 @@ +Title: Preventing to insert non ASCII characters in host addresses now +Level: 1 +Component: wato +Compatible: compat +Version: 1.4.0i1 +Date: 1470296371 +Class: fix + + diff --git a/ChangeLog b/ChangeLog index 375ef30..7f8b44f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -524,6 +524,7 @@ * 3733 FIX: BI rule editor: Increased size of argument/parameter/id input fields * 3735 FIX: Fixed wrong host search link in case of deleting site with hosts assigned * 3754 FIX: Cluster nodes are now correctly validated for invalid characters + * 3755 FIX: Preventing to insert non ASCII characters in host addresses now Notifications: * 3263 Notifications: allow users to restrict by their contact groups... diff --git a/web/plugins/wato/builtin_attributes.py b/web/plugins/wato/builtin_attributes.py index 2beba20..fcc1c78 100644 --- a/web/plugins/wato/builtin_attributes.py +++ b/web/plugins/wato/builtin_attributes.py @@ -34,43 +34,49 @@ declare_host_attribute(NagiosTextAttribute("alias", "alias", _("Alias"), show_in_table = True, show_in_folder = False) -declare_host_attribute(TextAttribute("ipaddress", _("IPv4 Address"), - _("In case the name of the host is not resolvable via <tt>/etc/hosts</tt> " - "or DNS by your monitoring server, you can specify an explicit IP " - "address or a resolvable DNS name of the host here. Notes: " - "1. If you leave this attribute empty, hostname resolution will be done when " - "you activate the configuration. " - "Check_MKs builtin DNS cache is activated per default in the global " - "configuration to speed up the activation process. The cache is normally " - "updated daily with a cron job. You can manually update the cache with the " - "command <tt>cmk -v --update-dns-cache</tt>. " - "2. If you enter a DNS name here, the DNS resolution will be carried out " - "each time the host is checked. Check_MKs DNS cache will NOT be queried. " - "Use this only for hosts with dynamic IP addresses." - ), - allow_empty = False), - show_in_table = True, - show_in_folder = False, - depends_on_tags = ["ip-v4"]) - -declare_host_attribute(TextAttribute("ipv6address", _("IPv6 Address"), - _("In case the name of the host is not resolvable via <tt>/etc/hosts</tt> " - "or DNS by your monitoring server, you can specify an explicit IPv6 " - "address or a resolvable DNS name of the host here. Notes: " - "1. If you leave this attribute empty, hostname resolution will be done when " - "you activate the configuration. " - "Check_MKs builtin DNS cache is activated per default in the global " - "configuration to speed up the activation process. The cache is normally " - "updated daily with a cron job. You can manually update the cache with the " - "command <tt>cmk -v --update-dns-cache</tt>. " - "2. If you enter a DNS name here, the DNS resolution will be carried out " - "each time the host is checked. Check_MKs DNS cache will NOT be queried. " - "Use this only for hosts with dynamic IP addresses." - ), - allow_empty = False), - show_in_table = True, - show_in_folder = False, - depends_on_tags = ["ip-v6"]) +declare_host_attribute(ValueSpecAttribute("ipaddress", + TextAscii( + title = _("IPv4 Address"), + help = _("In case the name of the host is not resolvable via <tt>/etc/hosts</tt> " + "or DNS by your monitoring server, you can specify an explicit IP " + "address or a resolvable DNS name of the host here. Notes: " + "1. If you leave this attribute empty, hostname resolution will be done when " + "you activate the configuration. " + "Check_MKs builtin DNS cache is activated per default in the global " + "configuration to speed up the activation process. The cache is normally " + "updated daily with a cron job. You can manually update the cache with the " + "command <tt>cmk -v --update-dns-cache</tt>. " + "2. If you enter a DNS name here, the DNS resolution will be carried out " + "each time the host is checked. Check_MKs DNS cache will NOT be queried. " + "Use this only for hosts with dynamic IP addresses."), + allow_empty = False, + )), + show_in_table = True, + show_in_folder = False, + depends_on_tags = ["ip-v4"] +) + +declare_host_attribute(ValueSpecAttribute("ipv6address", + TextAscii( + title = _("IPv6 Address"), + help = _("In case the name of the host is not resolvable via <tt>/etc/hosts</tt> " + "or DNS by your monitoring server, you can specify an explicit IPv6 " + "address or a resolvable DNS name of the host here. Notes: " + "1. If you leave this attribute empty, hostname resolution will be done when " + "you activate the configuration. " + "Check_MKs builtin DNS cache is activated per default in the global " + "configuration to speed up the activation process. The cache is normally " + "updated daily with a cron job. You can manually update the cache with the " + "command <tt>cmk -v --update-dns-cache</tt>. " + "2. If you enter a DNS name here, the DNS resolution will be carried out " + "each time the host is checked. Check_MKs DNS cache will NOT be queried. " + "Use this only for hosts with dynamic IP addresses."), + allow_empty = False, + )), + show_in_table = True, + show_in_folder = False, + depends_on_tags = ["ip-v6"] +) _snmpv3_auth_elements = [ DropdownChoice(

8 years, 1 month

Updated label and help text for custom host macros

by Lars Michelsen

Module: check_mk Branch: master Commit: 5bd104d9d3846002b253957d26c52e976495017b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5bd104d9d38460… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Aug 3 17:25:17 2016 +0200 Updated label and help text for custom host macros --- web/htdocs/wato.py | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index 47ada5c..432ea6f 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -14691,10 +14691,19 @@ def mode_edit_custom_attr(phase, what): label = _("Show the setting of the attribute in the list table")) forms.section(_('Add as custom macro')) - html.help(_('The attribute can be added to the contact definiton in order ' - 'to use it for notifications.')) + if what == "user": + html.help(_('The attribute can be added to the contact definiton in order ' + 'to use it for notifications.')) + label = _("Make this variable available in notifications") + else: + html.help(_("The attribute can be added to the host definition in order to " + "use it as monitoring macro in different places, for example " + "as macro in check commands or notifications.")) + label = _("Make this variable available as monitoring macro, " + "e.g. in check commands or in notifications.") + html.checkbox('add_custom_macro', attr.get('add_custom_macro', False), - label = _("Make this variable available in notifications")) + label=label) forms.end() html.show_localization_hint()

8 years, 1 month

Updated bug entries #2466

by Lars Michelsen

Module: check_mk Branch: master Commit: b227cdea10de74c26984bfa31d4cb02f1cf98ed4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b227cdea10de74… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Aug 3 17:16:44 2016 +0200 Updated bug entries #2466 --- .bugs/2466 | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.bugs/2466 b/.bugs/2466 new file mode 100644 index 0000000..d0505b5 --- /dev/null +++ b/.bugs/2466 @@ -0,0 +1,13 @@ +Title: Unicode characters in HTTP variables crash the GUI in different places +Component: multisite +State: open +Date: 2016-08-03 17:14:34 +Targetversion: 1.2.8 +Class: bug + +When a unicode character is added to URL variables read with html.vars() and this +is added to the HTML output which may already be unicode, this results into an exception. + +For example this URL: http://localhost/stable/check_mk/view.py?asdx=asd&view_name=allhosts%F0%9F%… + +We should solve this in a general place, for example html.var().

8 years, 1 month

Updated bug entries #2465

by Lars Michelsen

Module: check_mk Branch: master Commit: 85d5fbee4b366fb995afd771634be69465ac4f4c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=85d5fbee4b366f… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Aug 3 17:11:16 2016 +0200 Updated bug entries #2465 --- .bugs/2465 | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/.bugs/2465 b/.bugs/2465 new file mode 100644 index 0000000..3a2de88 --- /dev/null +++ b/.bugs/2465 @@ -0,0 +1,14 @@ +Title: ipaddress and ipv6address attributes allow non ASCII characters +Component: wato +State: open +Date: 2016-08-03 17:09:06 +Targetversion: 1.2.8 +Class: bug + +It's configured with the TextAttribute() object. Shouldn't we make it only accept ASCII characters +just like the TextASCII() valuespec? Or change these attributes to ValueSpecAttribute() and really +use TextAscii()? + +We should not allow non ascii characters in these fields. + +But there are umlaut domains. So: what do to?

8 years, 1 month

3754 FIX Cluster nodes are now correctly validated for invalid characters

by Lars Michelsen

Module: check_mk Branch: master Commit: a656c974e005b33077a500378103ef9ad9161d2d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a656c974e005b3… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Aug 3 17:04:13 2016 +0200 3754 FIX Cluster nodes are now correctly validated for invalid characters --- .werks/3754 | 10 ++++++++++ ChangeLog | 1 + web/htdocs/wato.py | 12 +++++++++--- 3 files changed, 20 insertions(+), 3 deletions(-) diff --git a/.werks/3754 b/.werks/3754 new file mode 100644 index 0000000..4684dff --- /dev/null +++ b/.werks/3754 @@ -0,0 +1,10 @@ +Title: Cluster nodes are now correctly validated for invalid characters +Level: 1 +Component: wato +Class: fix +Compatible: compat +State: unknown +Version: 1.4.0i1 +Date: 1470236636 + + diff --git a/ChangeLog b/ChangeLog index f8e56d2..375ef30 100644 --- a/ChangeLog +++ b/ChangeLog @@ -523,6 +523,7 @@ * 3726 FIX: Web API: Fixed default output format - using JSON as intended... * 3733 FIX: BI rule editor: Increased size of argument/parameter/id input fields * 3735 FIX: Fixed wrong host search link in case of deleting site with hosts assigned + * 3754 FIX: Cluster nodes are now correctly validated for invalid characters Notifications: * 3263 Notifications: allow users to restrict by their contact groups... diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index 5288484..47ada5c 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -1307,9 +1307,8 @@ def mode_edit_host(phase, new, is_cluster): # Cluster: nodes if is_cluster: - vs = ListOfStrings(valuespec = TextAscii(size = 19), orientation="horizontal") forms.section(_("Nodes")) - vs.render_input("nodes", host and host.cluster_nodes() or []) + vs_cluster_nodes().render_input("nodes", host and host.cluster_nodes() or []) html.help(_('Enter the host names of the cluster nodes. These ' 'hosts must be present in WATO. ')) @@ -1325,13 +1324,20 @@ def mode_edit_host(phase, new, is_cluster): html.end_form() +def vs_cluster_nodes(): + return ListOfStrings( + valuespec = TextAscii(size = 19), + orientation = "horizontal", + ) + # Called by mode_edit_host() for new/clone/edit def action_edit_host(mode, hostname, is_cluster): attributes = collect_attributes("host") if is_cluster: - cluster_nodes = ListOfStrings().from_html_vars("nodes") + cluster_nodes = vs_cluster_nodes().from_html_vars("nodes") + vs_cluster_nodes().validate_value(cluster_nodes, "nodes") if len(cluster_nodes) < 1: raise MKUserError("nodes_0", _("The cluster must have at least one node")) for nr, cluster_node in enumerate(cluster_nodes):

8 years, 1 month

← Newer
1
...
19
20
21
22
23
24
25
26
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits August 2016