Checkmk git commits May 2016

checkmk-commits@lists.checkmk.com

6 participants
231 discussions

3607 FIX wut_webtherm: fixed missing sensor data if only decimal comma marked values are available

by Simon Betz

Module: check_mk Branch: master Commit: b5def96c0abb167b0d0173761d045d324e206f73 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b5def96c0abb16… Author: Simon Betz <si(a)mathias-kettner.de> Date: Fri May 20 11:19:50 2016 +0200 3607 FIX wut_webtherm: fixed missing sensor data if only decimal comma marked values are available --- .werks/3607 | 10 ++++++++++ ChangeLog | 1 + checks/wut_webtherm | 18 ++++++++++++------ 3 files changed, 23 insertions(+), 6 deletions(-) diff --git a/.werks/3607 b/.werks/3607 new file mode 100644 index 0000000..1102894 --- /dev/null +++ b/.werks/3607 @@ -0,0 +1,10 @@ +Title: wut_webtherm: fixed missing sensor data if only decimal comma marked values are available +Level: 1 +Component: checks +Class: fix +Compatible: compat +State: unknown +Version: 1.2.9i1 +Date: 1463735636 + + diff --git a/ChangeLog b/ChangeLog index ea55290..2615aad 100644 --- a/ChangeLog +++ b/ChangeLog @@ -226,6 +226,7 @@ * 3536 FIX: alcatel_timetra_chassis: fixed exception when check is not OK * 3604 FIX: ups_capacity.include: fixed displaying wrong levels and cleanup * 3605 FIX: kemp_loadmaster_ha, kemp_loadmaster_realserver, kemp_loadmaster_services: fixed discovery if data is wrong or incomplete + * 3607 FIX: wut_webtherm: fixed missing sensor data if only decimal comma marked values are available Multisite: * 3187 notification view: new filter for log command via regex diff --git a/checks/wut_webtherm b/checks/wut_webtherm index fcdc7f4..42dc58e 100644 --- a/checks/wut_webtherm +++ b/checks/wut_webtherm @@ -36,24 +36,29 @@ def parse_wut_webtherm(info): "3" : "air_pressure", } parsed = {} - for index, reading in info: + for index, reading_de, reading_en in info: + if reading_en: + reading_str = reading_en + elif reading_de: + reading_str = reading_de.replace(",", ".") + webtherm_type, sensor_id = index.split(".") # Dependent on webtherm_type we have to determine # which sensors are available. Feel free to # declare more sensor types here. - if "---" not in reading and reading: + if "---" not in reading_str and reading_str: # We have only temperature sensors if int(webtherm_type) <= 9: # TODO: this is just a guess parsed[sensor_id] = { "type" : "temp", - "reading" : float(reading), + "reading" : float(reading_str), } # Here we have three different types of sensors: # 1 = temp, 2 = humid, 3 = air pressure else: parsed[sensor_id] = { "type" : map_sensor_type[sensor_id], - "reading" : float(reading), + "reading" : float(reading_str), } return parsed @@ -94,8 +99,9 @@ check_info["wut_webtherm"] = { 'service_description' : 'Temperature %s', 'has_perfdata' : True, 'snmp_info' : ('.1.3.6.1.4.1.5040.1.2', ['1', '2', '3', '6', '7', '8', '9', '16', '18', '36'], [ - '1.2.1.1', # sensorNo - '1.8.1.1' # valuePkt + '1.2.1.1', # WebGraph-Thermo-Hygro-Barometer-MIB::wtWebGraphThermoBaroSensorNo + '1.3.1.1', # WebGraph-Thermo-Hygro-Barometer-MIB::wtWebGraphThermoBaroTempValue + '1.8.1.1', # WebGraph-Thermo-Hygro-Barometer-MIB::wtWebGraphThermoBaroTempValuePkt ]), 'snmp_scan_function' : detect_webtherm, 'group' : 'temperature',

8 years, 4 months

Unobscurified convert_history_line a bit.

by Sven Panne

Module: check_mk Branch: master Commit: bca4a41df0a3db1483c609e14fa82c2285ee8ca3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=bca4a41df0a3db… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Fri May 20 10:57:45 2016 +0200 Unobscurified convert_history_line a bit. --- bin/mkeventd | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/bin/mkeventd b/bin/mkeventd index 400d616..2e32c86 100755 --- a/bin/mkeventd +++ b/bin/mkeventd @@ -158,19 +158,19 @@ def unsplit(s): # Speed-critical function for converting string representation # of log line back to Python values def convert_history_line(values): - values[0] = float(values[0]) # time - values[4] = int(values[4]) - values[5] = int(values[5]) - values[7] = float(values[7]) - values[8] = float(values[8]) - values[10] = int(values[10]) - values[14] = int(values[14]) - values[15] = int(values[15]) - values[16] = int(values[16]) - values[18] = int(values[18]) - values[21] = unsplit(values[21]) # match groups + values[0] = float(values[0]) # history_time + values[4] = int(values[4]) # event_id + values[5] = int(values[5]) # event_count + values[7] = float(values[7]) # event_first + values[8] = float(values[8]) # event_last + values[10] = int(values[10]) # event_sl + values[14] = int(values[14]) # event_pid + values[15] = int(values[15]) # event_priority + values[16] = int(values[16]) # event_facility + values[18] = int(values[18]) # event_state + values[21] = unsplit(values[21]) # event_match_groups if len(values) >= 23: - values[22] = unsplit(values[22]) # contact groups + values[22] = unsplit(values[22]) # event_contact_groups else: values.append(None)

8 years, 4 months

3606 saprouter_cert: new check which monitors the age of validity of a SAP router certificate

by Simon Betz

Module: check_mk Branch: master Commit: ee0cb1871634d9306aff737a719d25596faa6e1d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ee0cb1871634d9… Author: Simon Betz <si(a)mathias-kettner.de> Date: Fri May 20 10:01:00 2016 +0200 3606 saprouter_cert: new check which monitors the age of validity of a SAP router certificate To make this check work you have to install the <tt>mk_saprouter</tt> plugin and configure the user and path to sapgenpse in the related config file. It's recommended to run the plugin asynchronously. --- .werks/3606 | 11 +++ ChangeLog | 1 + agents/cfg_examples/saprouter.cfg | 27 ++++++++ agents/plugins/mk_saprouter | 41 +++++++++++ checkman/saprouter_cert | 19 ++++++ checks/saprouter_cert | 124 ++++++++++++++++++++++++++++++++++ web/plugins/wato/check_parameters.py | 20 ++++++ 7 files changed, 243 insertions(+) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=ee0cb18716…

8 years, 4 months

Hook in new EC tables.

by Sven Panne

Module: check_mk Branch: master Commit: 6f972d65ddfff87d58e4ea19b2b5522ffcaa435a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=6f972d65ddfff8… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Fri May 20 09:17:34 2016 +0200 Hook in new EC tables. --- livestatus/src/Store.cc | 3 +++ livestatus/src/Store.h | 6 ++++++ 2 files changed, 9 insertions(+) diff --git a/livestatus/src/Store.cc b/livestatus/src/Store.cc index 4bc0061..b9b34d3 100644 --- a/livestatus/src/Store.cc +++ b/livestatus/src/Store.cc @@ -87,6 +87,9 @@ Store::Store() addTable(&_table_statehistory); addTable(&_table_status); addTable(&_table_timeperiods); + addTable(&_table_eventconsoleevents); + addTable(&_table_eventconsolehistory); + addTable(&_table_eventconsolestatus); g_table_hosts = &_table_hosts; g_table_services = &_table_services; diff --git a/livestatus/src/Store.h b/livestatus/src/Store.h index e5079ce..26f6a2c 100644 --- a/livestatus/src/Store.h +++ b/livestatus/src/Store.h @@ -38,6 +38,9 @@ #include "TableContactgroups.h" #include "TableContacts.h" #include "TableDownComm.h" +#include "TableEventConsoleEvents.h" +#include "TableEventConsoleHistory.h" +#include "TableEventConsoleStatus.h" #include "TableHostgroups.h" #include "TableHosts.h" #include "TableHostsByGroup.h" @@ -84,6 +87,9 @@ private: TableLog _table_log; TableStateHistory _table_statehistory; TableColumns _table_columns; + TableEventConsoleEvents _table_eventconsoleevents; + TableEventConsoleHistory _table_eventconsolehistory; + TableEventConsoleStatus _table_eventconsolestatus; std::map<std::string, Table *> _tables;

8 years, 4 months

Test commit for CI.

by Sven Panne

Module: check_mk Branch: master Commit: fb8cda2b0e30963ddd280e1a52754020cb6682e7 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=fb8cda2b0e3096… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Fri May 20 09:51:59 2016 +0200 Test commit for CI. --- livestatus/src/Store.h | 1 - 1 file changed, 1 deletion(-) diff --git a/livestatus/src/Store.h b/livestatus/src/Store.h index 26f6a2c..88893f0 100644 --- a/livestatus/src/Store.h +++ b/livestatus/src/Store.h @@ -92,7 +92,6 @@ private: TableEventConsoleStatus _table_eventconsolestatus; std::map<std::string, Table *> _tables; - std::mutex _command_mutex; void addTable(Table *table);

8 years, 4 months

Fetched livestatus from downstream.

by Sven Panne

Module: check_mk Branch: master Commit: b0f36265a41e604ce83d91841f04cca206d90b9c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b0f36265a41e60… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Fri May 20 09:13:22 2016 +0200 Fetched livestatus from downstream. --- livestatus/src/Makefile.am | 4 + livestatus/src/TableEventConsole.cc | 147 ++++++++++++++++++++++++++++ livestatus/src/TableEventConsole.h | 121 +++++++++++++++++++++++ livestatus/src/TableEventConsoleEvents.cc | 56 +++++++++++ livestatus/src/TableEventConsoleEvents.h | 38 +++++++ livestatus/src/TableEventConsoleHistory.cc | 61 ++++++++++++ livestatus/src/TableEventConsoleHistory.h | 38 +++++++ livestatus/src/TableEventConsoleStatus.cc | 86 ++++++++++++++++ livestatus/src/TableEventConsoleStatus.h | 38 +++++++ 9 files changed, 589 insertions(+) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=b0f36265a4…

8 years, 4 months

3605 FIX kemp_loadmaster_ha, kemp_loadmaster_realserver,

by Simon Betz

kemp_loadmaster_services: fixed discovery if data is wrong or incomplete Message-ID: <573dc464.Su4UsWCaaK3jWyQZ%si(a)mathias-kettner.de> User-Agent: Heirloom mailx 12.5 6/20/10 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Module: check_mk Branch: master Commit: 8ab0a8cea19bb9caad54697b76111cac2c097f47 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8ab0a8cea19bb9… Author: Simon Betz <si(a)mathias-kettner.de> Date: Thu May 19 15:48:57 2016 +0200 3605 FIX kemp_loadmaster_ha, kemp_loadmaster_realserver, kemp_loadmaster_services: fixed discovery if data is wrong or incomplete --- .werks/3605 | 10 ++++ ChangeLog | 1 + checks/kemp_loadmaster_ha | 31 +++++++---- checks/kemp_loadmaster_realserver | 21 ++++---- checks/kemp_loadmaster_services | 107 ++++++++++++++++++++++++++----------- 5 files changed, 117 insertions(+), 53 deletions(-) diff --git a/.werks/3605 b/.werks/3605 new file mode 100644 index 0000000..39bf2b9 --- /dev/null +++ b/.werks/3605 @@ -0,0 +1,10 @@ +Title: kemp_loadmaster_ha, kemp_loadmaster_realserver, kemp_loadmaster_services: fixed discovery if data is wrong or incomplete +Level: 1 +Component: checks +Class: fix +Compatible: compat +State: unknown +Version: 1.2.9i1 +Date: 1463665694 + + diff --git a/ChangeLog b/ChangeLog index 8f3dde3..f1f45ae 100644 --- a/ChangeLog +++ b/ChangeLog @@ -224,6 +224,7 @@ * 3535 FIX: docsis_cm_status: fixed missing performance data * 3536 FIX: alcatel_timetra_chassis: fixed exception when check is not OK * 3604 FIX: ups_capacity.include: fixed displaying wrong levels and cleanup + * 3605 FIX: kemp_loadmaster_ha, kemp_loadmaster_realserver, kemp_loadmaster_services: fixed discovery if data is wrong or incomplete Multisite: * 3187 notification view: new filter for log command via regex diff --git a/checks/kemp_loadmaster_ha b/checks/kemp_loadmaster_ha index b560591..6f9cd27 100644 --- a/checks/kemp_loadmaster_ha +++ b/checks/kemp_loadmaster_ha @@ -25,14 +25,24 @@ # Boston, MA 02110-1301 USA. +# .1.3.6.1.4.1.12196.13.0.9.0 1 +# .1.3.6.1.4.1.12196.13.0.10.0 7.1-20b.20140926-1505 + + def inventory_kemp_loadmaster_ha(info): - return [ ( None, None ) ] + if info and info[0][0] != "0": + return [ ( None, None ) ] + def check_kemp_loadmaster_ha(_no_item, _no_params, info): - states = ( 'none', 'Master', 'Standby', 'Passive' ) - state = states[saveint(info[0][0])] - firmware = info[0][1] - return 0, "Device is: %s (Firmware: %s)" % ( state, firmware ) + map_states = { + "0" : "none", + "1" : "master", + "2" : "standby", + "3" : "passive", + } + + return 0, "Device is: %s (Firmware: %s)" % ( map_states[info[0][0]], info[0][1] ) check_info["kemp_loadmaster_ha"] = { @@ -40,8 +50,11 @@ check_info["kemp_loadmaster_ha"] = { "inventory_function" : inventory_kemp_loadmaster_ha, "service_description" : "HA State", "has_perfdata" : False, - "snmp_scan_function" : lambda oid: oid(".1.3.6.1.2.1.1.2.0") in [".1.3.6.1.4.1.12196.250.10", ".1.3.6.1.4.1.2021.250.10" ] \ - and oid(".1.3.6.1.4.1.12196.13.0.9.*"), - "snmp_info" : ( ".1.3.6.1.4.1.12196.13.0", [ 9, 10 ] ), + "snmp_info" : ( ".1.3.6.1.4.1.12196.13.0", [ + "9", # B100-MIB::hAstate + "10", # B100-MIB::patchVersion + ]), + "snmp_scan_function" : lambda oid: oid(".1.3.6.1.2.1.1.2.0") in \ + [".1.3.6.1.4.1.12196.250.10", ".1.3.6.1.4.1.2021.250.10" ] and \ + oid(".1.3.6.1.4.1.12196.13.0.9.*"), } - diff --git a/checks/kemp_loadmaster_realserver b/checks/kemp_loadmaster_realserver index 7679456..1265d41 100644 --- a/checks/kemp_loadmaster_realserver +++ b/checks/kemp_loadmaster_realserver @@ -36,12 +36,11 @@ def inventory_kemp_loadmaster_realserver(info): for line in info: - if line[2] != '4': # Skip disabled servers + if line[2] not in [ '4', '' ]: # Skip disabled servers yield line[0], None def check_kemp_loadmaster_realserver(item, _no_params, info): - # states as they are defined in corresponding MIB: B100-MIB::rSstate states = { '1' : (0, 'in service', ), '2' : (2, 'out of service', ), @@ -56,17 +55,15 @@ def check_kemp_loadmaster_realserver(item, _no_params, info): check_info["kemp_loadmaster_realserver"] = { - "check_function" : check_kemp_loadmaster_realserver, "inventory_function" : inventory_kemp_loadmaster_realserver, + "check_function" : check_kemp_loadmaster_realserver, "service_description" : "Real Server %s", - "snmp_scan_function" : lambda oid: oid(".1.3.6.1.2.1.1.2.0") in [ - ".1.3.6.1.4.1.12196.250.10", - ".1.3.6.1.4.1.2021.250.10" - ], "snmp_info" : ( ".1.3.6.1.4.1.12196.13.2.1", [ - 2, # IP address: B100-MIB::rSip - 5, # ID: B100-MIB::rSidx - 8, # state: B100-MIB::rSstate - ] ), + 2, # IP address: B100-MIB::rSip + 5, # ID: B100-MIB::rSidx + 8, # state: B100-MIB::rSstate + ]), + "snmp_scan_function" : lambda oid: oid(".1.3.6.1.2.1.1.2.0") in \ + [ ".1.3.6.1.4.1.12196.250.10", + ".1.3.6.1.4.1.2021.250.10"], } - diff --git a/checks/kemp_loadmaster_services b/checks/kemp_loadmaster_services index d9c81d1..243f39b 100644 --- a/checks/kemp_loadmaster_services +++ b/checks/kemp_loadmaster_services @@ -25,44 +25,87 @@ # Boston, MA 02110-1301 USA. +# .1.3.6.1.4.1.12196.13.1.1.13.1 Exchange HTTPS +# .1.3.6.1.4.1.12196.13.1.1.13.3 Exchange MAPI +# .1.3.6.1.4.1.12196.13.1.1.13.4 Exchange SMTP +# .1.3.6.1.4.1.12196.13.1.1.13.5 Lync Internal WebSvc HTTP +# .1.3.6.1.4.1.12196.13.1.1.13.6 Lync Internal WebSvc HTTPS +# .1.3.6.1.4.1.12196.13.1.1.14.1 1 +# .1.3.6.1.4.1.12196.13.1.1.14.3 1 +# .1.3.6.1.4.1.12196.13.1.1.14.4 1 +# .1.3.6.1.4.1.12196.13.1.1.14.5 1 +# .1.3.6.1.4.1.12196.13.1.1.14.6 1 +# .1.3.6.1.4.1.12196.13.1.1.21.1 882 +# .1.3.6.1.4.1.12196.13.1.1.21.3 6386 +# .1.3.6.1.4.1.12196.13.1.1.21.4 3 +# .1.3.6.1.4.1.12196.13.1.1.21.5 1 +# .1.3.6.1.4.1.12196.13.1.1.21.6 1 + +# Some devices provide strange, wrong or incomplete data +# and it's not possible to exclude them via std. OIDs +# .1.3.6.1.4.1.12196.13.1.1.13.1 lbwebinterface --> B100-MIB::vSname.1 +# .1.3.6.1.4.1.12196.13.1.1.13.2 --> B100-MIB::vSname.2 +# .1.3.6.1.4.1.12196.13.1.1.13.3 --> B100-MIB::vSname.3 +# .1.3.6.1.4.1.12196.13.1.1.14.1 LB_WI --> B100-MIB::vSstate.1 +# .1.3.6.1.4.1.12196.13.1.1.14.2 --> B100-MIB::vSstate.2 +# .1.3.6.1.4.1.12196.13.1.1.14.3 CAG_LB --> B100-MIB::vSstate.3 + + kemp_loadmaster_service_default_levels = ( 1500, 2000 ) -def inventory_kemp_loadmaster_services(info): - return [ ( x[0], kemp_loadmaster_service_default_levels ) for x in info ] - -def check_kemp_loadmaster_services(item, _no_params, info): - service_states = ( 'in Service', - 'out of Service', - 'failed', - 'disabled', - 'sorry', - 'redirect', - 'errormsg') - for line in info: - if line[0] == item: - service_state, conns = map(saveint, line[1:]) - message = "State: %s" % (service_states[service_state-1]) - perfdata = [ ('conns', conns) ] - state = 3 - if service_state in [ 1, 6 ]: - message += ", Active Connections: %s" % conns - state = 0 - if service_state == 5: - state = 1 - if service_state in [ 2, 3, 7 ]: - state = 2 - return (state, message, perfdata) - return 3, "Service not found" + +def parse_kemp_loadmaster_services(info): + map_states = { + "1" : (0, 'in service'), + "2" : (2, 'out of service'), + "3" : (2, 'failed'), + "4" : (3, 'disabled'), + "5" : (1, 'sorry'), + "6" : (0, 'redirect'), + "7" : (2, 'error message'), + } + + parsed = {} + for name, status, conns in info: + if not (name == "" or len(status) > 1): + parsed.setdefault(name, {"state" : map_states[status]}) + if conns.isdigit(): + parsed[name].update({"conns" : int(conns)}) + + return parsed + + +def inventory_kemp_loadmaster_services(parsed): + for item, iteminfo in parsed.items(): + if iteminfo["state"] not in ["4", ""]: + yield item, kemp_loadmaster_service_default_levels + + +def check_kemp_loadmaster_services(item, _no_params, parsed): + if item in parsed: + data = parsed[item] + state, state_readable = data["state"] + infotext = "State: %s" % state_readable + + perfdata = [] + if data.get("conns"): + infotext += ", Active connections: %s" % data["conns"] + perfdata.append( ('conns', data["conns"]) ) + + return state, infotext, perfdata + check_info["kemp_loadmaster_services"] = { - "check_function" : check_kemp_loadmaster_services, + "parse_function" : parse_kemp_loadmaster_services, "inventory_function" : inventory_kemp_loadmaster_services, + "check_function" : check_kemp_loadmaster_services, "service_description" : "Service %s", "has_perfdata" : True, - "snmp_scan_function" : lambda oid: oid(".1.3.6.1.2.1.1.2.0") == ".1.3.6.1.4.1.12196.250.10" or oid(".1.3.6.1.2.1.1.2.0") == ".1.3.6.1.4.1.2021.250.10", "snmp_info" : ( ".1.3.6.1.4.1.12196.13.1.1", [ - 13, # name - 14, # state - 21, # conns - ] ), + "13", # B100-MIB::vSname + "14", # B100-MIB::vSstate + "21", # B100-MIB::conns + ]), + "snmp_scan_function" : lambda oid: oid(".1.3.6.1.2.1.1.2.0") == ".1.3.6.1.4.1.12196.250.10" or \ + oid(".1.3.6.1.2.1.1.2.0") == ".1.3.6.1.4.1.2021.250.10", }

8 years, 4 months

Formatted. Testing CI on the way...

by Sven Panne

Module: check_mk Branch: master Commit: 02ea9e886d4456ab30c154aa1f3f02122facb32e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=02ea9e886d4456… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Thu May 19 15:17:56 2016 +0200 Formatted. Testing CI on the way... --- livestatus/src/Query.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/livestatus/src/Query.h b/livestatus/src/Query.h index 3f1eda9..256520d 100644 --- a/livestatus/src/Query.h +++ b/livestatus/src/Query.h @@ -132,7 +132,7 @@ public: void optimizeBitmask(const char *columnname, uint32_t *bitmask); int timezoneOffset() { return _timezone_offset; } AndingFilter *filter() { return &_filter; } - std::unordered_set<Column*> *allColumns() { return &_all_columns; } + std::unordered_set<Column *> *allColumns() { return &_all_columns; } private: bool doStats();

8 years, 4 months

Updated bug entries #2494

by Mathias Kettner

Module: check_mk Branch: master Commit: 82c4204921c9895a9194fa4b601aafef88076e57 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=82c4204921c989… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu May 19 14:54:54 2016 +0200 Updated bug entries #2494 --- .bugs/2494 | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.bugs/2494 b/.bugs/2494 new file mode 100644 index 0000000..01bf7fe --- /dev/null +++ b/.bugs/2494 @@ -0,0 +1,9 @@ +Title: Cloning of roles creates roles with an existing non-unique alias +Component: wato +State: open +Date: 2016-05-19 14:53:37 +Targetversion: 1.2.8 +Class: bug + +This prevents you from saving the properties. And creates in invalid state. +Rather create an artificial Alias like "Clone of role Administrator" or the like.

8 years, 4 months

Revert "Test commit for CI."

by Sven Panne

Module: check_mk Branch: master Commit: de1d8ce2f1d7b7d0a39dd5b6e16602e5c6b875e8 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=de1d8ce2f1d7b7… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Thu May 19 14:54:33 2016 +0200 Revert "Test commit for CI." This reverts commit 75c4270b2265d624bdf188224b6af259f5f9afa2. --- livestatus/src/LogCache.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/livestatus/src/LogCache.cc b/livestatus/src/LogCache.cc index 509c8a4..8c93a12 100644 --- a/livestatus/src/LogCache.cc +++ b/livestatus/src/LogCache.cc @@ -201,12 +201,11 @@ void LogCache::handleNewMessage(Logfile *logfile, time_t /*unused*/, _num_at_last_check + CHECK_MEM_CYCLE) { return; // Do not check this time } - int foobar; // [1] Begin by deleting old logfiles // Begin deleting with the oldest logfile available _logfiles_t::iterator it; - for (it = _logfiles.begin(); it != _logfiles.end(); it++) { + for (it = _logfiles.begin(); it != _logfiles.end(); ++it) { Logfile *log = it->second; if (log == logfile) { // Do not touch the logfile the Query is currently accessing

8 years, 4 months

← Newer
1
...
5
6
7
8
9
10
11
...
24
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits May 2016