Checkmk git commits February 2016

checkmk-commits@lists.checkmk.com

7 participants
402 discussions

by Sven Panne

Module: check_mk Branch: master Commit: 83271fbce59c9e84dfec545e13c53aee9f944eaa URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=83271fbce59c9e… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Thu Feb 4 10:20:14 2016 +0100 Fixed error message. --- livestatus/src/unixcat.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/livestatus/src/unixcat.c b/livestatus/src/unixcat.c index 42b194d..4e205e4 100644 --- a/livestatus/src/unixcat.c +++ b/livestatus/src/unixcat.c @@ -112,9 +112,10 @@ void *copy_thread(void *info) { while (bytes_to_write > 0) { ssize_t bytes_written = write(to, buffer, bytes_to_write); if (bytes_written == -1) { + uintmax_t b = bytes_to_write; fprintf(stderr, - "Error: Cannot write %" PRIuMAX " bytes to %d: %s\n", - (uintmax_t)bytes_to_write, to, strerror(errno)); + "Error: Cannot write %" PRIuMAX " bytes to %d: %s\n", b, + to, strerror(errno)); break; } buffer += bytes_written;

8 years, 7 months

clang-tidy fixes for google-readability-braces-around-statements and readability-braces-around-statements checks.

by Sven Panne

Module: check_mk Branch: master Commit: 48e61c6f628997d88f8eb8262ff8bce88fcd233d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=48e61c6f628997… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Thu Feb 4 09:03:05 2016 +0100 clang-tidy fixes for google-readability-braces-around-statements and readability-braces-around-statements checks. --- .clang-tidy | 4 +- livestatus/src/AndingFilter.cc | 25 +- livestatus/src/AttributelistColumn.cc | 13 +- livestatus/src/BlobColumn.cc | 3 +- livestatus/src/ClientQueue.cc | 4 +- livestatus/src/Column.cc | 19 +- livestatus/src/ContactgroupsColumn.cc | 13 +- livestatus/src/ContactgroupsMemberColumn.cc | 4 +- livestatus/src/ContactsColumn.cc | 9 +- livestatus/src/CountAggregator.cc | 4 +- livestatus/src/CustomTimeperiodColumn.cc | 11 +- livestatus/src/CustomVarsColumn.cc | 38 +- livestatus/src/CustomVarsExplicitColumn.cc | 12 +- livestatus/src/CustomVarsFilter.cc | 11 +- livestatus/src/DoubleAggregator.cc | 20 +- livestatus/src/DownCommColumn.cc | 18 +- livestatus/src/GlobalCountersColumn.cc | 5 +- livestatus/src/HostFileColumn.cc | 8 +- livestatus/src/HostServiceState.cc | 4 +- livestatus/src/HostSpecialDoubleColumn.cc | 4 +- livestatus/src/HostSpecialIntColumn.cc | 11 +- livestatus/src/HostgroupsColumn.cc | 17 +- livestatus/src/HostlistColumn.cc | 13 +- livestatus/src/HostlistColumnFilter.cc | 7 +- livestatus/src/HostlistStateColumn.cc | 29 +- livestatus/src/InputBuffer.cc | 31 +- livestatus/src/IntAggregator.cc | 15 +- livestatus/src/IntColumnFilter.cc | 31 +- livestatus/src/ListColumnFilter.cc | 12 +- livestatus/src/LogCache.cc | 30 +- livestatus/src/LogEntry.cc | 51 ++- livestatus/src/Logfile.cc | 32 +- livestatus/src/MetricsColumn.cc | 4 +- livestatus/src/OffsetDoubleColumn.cc | 8 +- livestatus/src/OffsetIntColumn.cc | 9 +- livestatus/src/OffsetStringColumn.cc | 9 +- livestatus/src/OffsetStringMacroColumn.cc | 47 +-- livestatus/src/OffsetStringServiceMacroColumn.cc | 5 +- livestatus/src/OffsetTimeperiodColumn.cc | 16 +- livestatus/src/OringFilter.cc | 7 +- livestatus/src/OutputBuffer.cc | 7 +- livestatus/src/PerfdataAggregator.cc | 40 ++- livestatus/src/Query.cc | 407 ++++++++++++++-------- livestatus/src/ServiceSpecialDoubleColumn.cc | 7 +- livestatus/src/ServiceSpecialIntColumn.cc | 4 +- livestatus/src/ServicegroupsColumn.cc | 13 +- livestatus/src/ServicelistColumn.cc | 16 +- livestatus/src/ServicelistColumnFilter.cc | 6 +- livestatus/src/ServicelistStateColumn.cc | 30 +- livestatus/src/StatsColumn.cc | 18 +- livestatus/src/Store.cc | 21 +- livestatus/src/StringColumn.cc | 5 +- livestatus/src/StringColumnFilter.cc | 9 +- livestatus/src/Table.cc | 22 +- livestatus/src/TableColumns.cc | 4 +- livestatus/src/TableCommands.cc | 4 +- livestatus/src/TableContactgroups.cc | 4 +- livestatus/src/TableContacts.cc | 4 +- livestatus/src/TableDownComm.cc | 21 +- livestatus/src/TableHostgroups.cc | 13 +- livestatus/src/TableHosts.cc | 12 +- livestatus/src/TableLog.cc | 46 ++- livestatus/src/TableServicegroups.cc | 13 +- livestatus/src/TableServices.cc | 27 +- livestatus/src/TableStateHistory.cc | 150 +++++--- livestatus/src/TableTimeperiods.cc | 4 +- livestatus/src/TimeColumnFilter.cc | 3 +- livestatus/src/TimeperiodsCache.cc | 17 +- livestatus/src/auth.cc | 4 +- livestatus/src/global_counters.c | 5 +- livestatus/src/logger.c | 3 +- livestatus/src/mk_inventory.cc | 5 +- livestatus/src/module.c | 121 ++++--- livestatus/src/pnp4nagios.cc | 8 +- livestatus/src/strutil.cc | 27 +- livestatus/src/unixcat.c | 9 +- livestatus/src/waittriggers.cc | 32 +- 77 files changed, 1148 insertions(+), 606 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=48e61c6f62…

8 years, 7 months

#3067 openhardwaremonitor.smart: initial support for S.M.A.R.T. harddisk health monitoring via OpenHardwareMonitor

by Sebastian Herbord

Module: check_mk Branch: master Commit: 8e759a964b39ba679dd09c95587d36200c68ed95 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8e759a964b39ba… Author: Sebastian Herbord <sh(a)mathias-kettner.de> Date: Thu Feb 4 09:38:24 2016 +0100 #3067 openhardwaremonitor.smart: initial support for S.M.A.R.T. harddisk health monitoring via OpenHardwareMonitor OHM reports aggregated health attributes and the check will only pick up on those it currently supports (only one so far). This will be extended over time. --- .werks/3067 | 10 +++ ChangeLog | 1 + checkman/openhardwaremonitor.smart | 27 ++++++++ checks/openhardwaremonitor | 112 ++++++++++++++++++++++++++-------- web/plugins/wato/check_parameters.py | 41 +++++++++++-- 5 files changed, 158 insertions(+), 33 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=8e759a964b…

8 years, 7 months

Updated bug entries #2177

by Mathias Kettner

Module: check_mk Branch: master Commit: a3701cc4240baaa4cd43bc45e157609c2fd72f2f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a3701cc4240baa… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Feb 3 16:44:45 2016 +0100 Updated bug entries #2177 --- .bugs/2177 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.bugs/2177 b/.bugs/2177 index e496dd3..e43860c 100644 --- a/.bugs/2177 +++ b/.bugs/2177 @@ -2,7 +2,7 @@ Title: new windows agent: eventlog monitoring should be able to process cleared Component: checks State: open Date: 2015-07-30 16:04:54 -Targetversion: future +Targetversion: 1.2.8 Class: bug If someone clears the event log with the event viewer, the windows agent

8 years, 7 months

gb: fix alignment of bug list

by Mathias Kettner

Module: check_mk Branch: master Commit: 9bf55cfeb3da0f933bd00acd9cb6f580bf748ff3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=9bf55cfeb3da0f… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Feb 3 16:43:48 2016 +0100 gb: fix alignment of bug list --- gb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gb b/gb index 511ae86..1d47532 100755 --- a/gb +++ b/gb @@ -211,7 +211,7 @@ def list_bug(bug): bold = "" lines, cols = get_tty_size() title = bug["title"][:cols - 45] - sys.stdout.write("#%04d %-8s %-9s %-10s %s%-8s%s %s%s%s\n" % + sys.stdout.write("#%04d %-8s %-9s %-12s %s%-8s%s %s%s%s\n" % (int(bug["id"]), bug_state(bug), bug["class"], bug["component"], tty_bold,

8 years, 7 months

Reclassified bugs

by Mathias Kettner

8 years, 7 months

gb: new option --ids for show: show only bug ids

by Mathias Kettner

Module: check_mk Branch: master Commit: 01b4a0b0184eb3bbf9c2ddc3cbee4c4781292c74 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=01b4a0b0184eb3… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Feb 3 16:16:39 2016 +0100 gb: new option --ids for show: show only bug ids --- gb | 51 ++++++++++++++++++++++++++++++--------------------- 1 file changed, 30 insertions(+), 21 deletions(-) diff --git a/gb b/gb index 3607f70..511ae86 100755 --- a/gb +++ b/gb @@ -52,11 +52,11 @@ def get_tty_size(): pass return (24, 99999) -grep_colors = [ +grep_colors = [ tty_bold + tty_magenta, tty_bold + tty_cyan, tty_bold + tty_green, -] +] def bail_out(text): sys.stderr.write(text + "\n") @@ -119,14 +119,14 @@ def bug_is_modified(bugid): def load_bug(bugid): - bug = { + bug = { "id" : bugid, "state" : "unknown", "title" : "unknown", "component" : "general", "targetversion" : "future", } - + f = file(str(bugid)) for line in f: line = line.strip() @@ -168,7 +168,7 @@ def add_comment(bug, title, comment): bug["description"] += """ %s: %s %s""" % (time.strftime("%F %T"), title, comment) - + def usage(): @@ -214,7 +214,7 @@ def list_bug(bug): sys.stdout.write("#%04d %-8s %-9s %-10s %s%-8s%s %s%s%s\n" % (int(bug["id"]), bug_state(bug), - bug["class"], bug["component"], tty_bold, + bug["class"], bug["component"], tty_bold, bug["targetversion"], tty_normal, bold, title, tty_normal)) def show_bug(bug): @@ -222,6 +222,12 @@ def show_bug(bug): sys.stdout.write("\n%s\n" % bug["description"]) def main_list(args, format): + if "--ids" in args: + args.remove("--ids") + show_only_ids = True + else: + show_only_ids = False + bugs = g_bugs.values() # arguments are tags from state, component and class. Multiple values @@ -238,8 +244,8 @@ def main_list(args, format): hit = False for tp, values in [ - ( "component", components ), - ( "state", states ), + ( "component", components ), + ( "state", states ), ( "class", classes ), ( "targetversion", targetversions), ]: @@ -268,7 +274,7 @@ def main_list(args, format): if not skip: newbugs.append(bug) bugs = newbugs - + # Sort if sort: newbugs.sort(sort) @@ -278,7 +284,10 @@ def main_list(args, format): # Output if format == "console": for bug in bugs: - list_bug(bug) + if show_only_ids: + print bug["id"] + else: + list_bug(bug) else: output_csv(bugs) @@ -331,7 +340,7 @@ def main_show(args): ids = [ g_last_bug ] elif ids[0] == 'all': ids = [ id for (id, bug) in g_bugs.items() ] - + for id in ids: if id != ids[0]: sys.stdout.write("-------------------------------------------------------------------------------\n") @@ -349,7 +358,7 @@ def get_input(what, default = ""): return default else: return value - + def get_long_input(what): sys.stdout.write("Enter %s. End with CTRL-D.\n" % what) usertext = sys.stdin.read() @@ -383,7 +392,7 @@ def input_choice(what, choices): ctc[c] = choice texts.append(choice.replace(c, tty_bold + c + tty_normal, 1)) break - + while True: sys.stdout.write("%s (%s): " % (what, ", ".join(texts))) sys.stdout.flush() @@ -407,7 +416,7 @@ def main_new(args): bug["class"] = input_choice("Class", classes) bug["component"] = input_choice("Component", components) bug["targetversion"] = input_choice("Target Version", targetversions) - + bug["description"] = get_long_input("description") g_bugs[bug["id"]] = bug save_bug(bug) @@ -466,7 +475,7 @@ def grep(line, kw, n): else: col = grep_colors[n % len(grep_colors)] return line[0:i] + col + line[i:i+len(kw)] + tty_normal + line[i+len(kw):] - + def main_grep(args): if '-v' in args: @@ -524,7 +533,7 @@ def main_edit(args): bail_out("No last bug. Please specify id.") else: - ids = args[0] + ids = args[0] if not os.path.exists(ids): bail_out("No bug with this id.") editor = os.getenv("EDITOR") @@ -605,12 +614,12 @@ def main_fetch_ids(args): bail_out("Cannot commit.") -# _ -# _ __ ___ __ _(_)_ __ -# | '_ ` _ \ / _` | | '_ \ +# _ +# _ __ ___ __ _(_)_ __ +# | '_ ` _ \ / _` | | '_ \ # | | | | | | (_| | | | | | # |_| |_| |_|\__,_|_|_| |_| -# +# goto_bugsdir() load_config() @@ -635,7 +644,7 @@ commands = { "ids" : main_fetch_ids, } -hits = [] +hits = [] for name, func in commands.items(): if name == cmd: hits = [ (name, func) ]

8 years, 7 months

clang-tidy fixes for readability-inconsistent-declaration-parameter-name check.

by Sven Panne

Module: check_mk Branch: master Commit: 8c88c4d904826f58857a3b40d2c65dae4a0aeae0 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8c88c4d904826f… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Wed Feb 3 16:00:39 2016 +0100 clang-tidy fixes for readability-inconsistent-declaration-parameter-name check. --- .clang-tidy | 3 +-- livestatus/src/ContactgroupsMemberColumn.h | 2 +- livestatus/src/ContactsColumn.h | 2 +- livestatus/src/DoubleColumnFilter.h | 2 +- livestatus/src/DowntimeOrComment.h | 6 +++--- livestatus/src/HostContactsColumn.h | 2 +- livestatus/src/HostFileColumn.h | 2 +- livestatus/src/Logfile.h | 10 +++++----- livestatus/src/Query.h | 6 +++--- livestatus/src/ServiceContactsColumn.h | 2 +- livestatus/src/ServicelistStateColumn.h | 2 +- livestatus/src/StringColumnFilter.h | 2 +- livestatus/src/Table.h | 2 +- livestatus/src/TableLog.h | 2 +- livestatus/src/TableStateHistory.h | 3 ++- livestatus/src/auth.h | 2 +- livestatus/src/store_c.h | 2 +- livestatus/src/strutil.h | 2 +- 18 files changed, 27 insertions(+), 27 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=8c88c4d904…

8 years, 7 months

clang-tidy fixes for readability-implicit-bool-cast check.

by Sven Panne

Module: check_mk Branch: master Commit: adaac03a7e5fb3ec59a8be3199bb2cac55e18131 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=adaac03a7e5fb3… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Wed Feb 3 15:55:40 2016 +0100 clang-tidy fixes for readability-implicit-bool-cast check. --- .clang-tidy | 3 +- livestatus/src/AndingFilter.cc | 4 +- livestatus/src/AttributelistColumn.cc | 16 +- livestatus/src/BlobColumn.cc | 2 +- livestatus/src/Column.cc | 6 +- livestatus/src/ContactgroupsColumn.cc | 10 +- livestatus/src/ContactsColumn.cc | 6 +- livestatus/src/CountAggregator.cc | 2 +- livestatus/src/CustomTimeperiodColumn.cc | 9 +- livestatus/src/CustomVarsColumn.cc | 15 +- livestatus/src/CustomVarsExplicitColumn.cc | 6 +- livestatus/src/CustomVarsFilter.cc | 15 +- livestatus/src/DownCommColumn.cc | 4 +- livestatus/src/DowntimeOrComment.cc | 2 +- livestatus/src/HostContactsColumn.cc | 2 +- livestatus/src/HostFileColumn.cc | 6 +- livestatus/src/HostSpecialDoubleColumn.cc | 2 +- livestatus/src/HostSpecialIntColumn.cc | 2 +- livestatus/src/HostgroupsColumn.cc | 12 +- livestatus/src/HostlistColumn.cc | 7 +- livestatus/src/HostlistColumnFilter.cc | 4 +- livestatus/src/HostlistStateColumn.cc | 11 +- livestatus/src/InputBuffer.cc | 6 +- livestatus/src/IntColumnFilter.cc | 6 +- livestatus/src/ListColumnFilter.cc | 6 +- livestatus/src/LogCache.cc | 4 +- livestatus/src/LogEntry.cc | 69 ++++---- livestatus/src/Logfile.cc | 16 +- livestatus/src/MetricsColumn.cc | 2 +- livestatus/src/OffsetDoubleColumn.cc | 4 +- livestatus/src/OffsetIntColumn.cc | 4 +- livestatus/src/OffsetStringColumn.cc | 6 +- livestatus/src/OffsetStringMacroColumn.cc | 50 +++--- livestatus/src/OffsetStringServiceMacroColumn.cc | 2 +- livestatus/src/OffsetTimeperiodColumn.cc | 4 +- livestatus/src/OutputBuffer.cc | 4 +- livestatus/src/PerfdataAggregator.cc | 11 +- livestatus/src/Query.cc | 198 +++++++++++----------- livestatus/src/ServiceContactsColumn.cc | 2 +- livestatus/src/ServiceSpecialDoubleColumn.cc | 8 +- livestatus/src/ServiceSpecialIntColumn.cc | 2 +- livestatus/src/ServicegroupsColumn.cc | 10 +- livestatus/src/ServicelistColumn.cc | 14 +- livestatus/src/ServicelistColumnFilter.cc | 6 +- livestatus/src/ServicelistStateColumn.cc | 11 +- livestatus/src/StatsColumn.cc | 4 +- livestatus/src/Store.cc | 14 +- livestatus/src/StringColumn.cc | 2 +- livestatus/src/StringColumnFilter.cc | 11 +- livestatus/src/Table.cc | 6 +- livestatus/src/TableCommands.cc | 2 +- livestatus/src/TableContactgroups.cc | 2 +- livestatus/src/TableContacts.cc | 2 +- livestatus/src/TableDownComm.cc | 2 +- livestatus/src/TableHostgroups.cc | 4 +- livestatus/src/TableHosts.cc | 22 +-- livestatus/src/TableLog.cc | 5 +- livestatus/src/TableServicegroups.cc | 8 +- livestatus/src/TableServices.cc | 44 ++--- livestatus/src/TableStateHistory.cc | 59 ++++--- livestatus/src/TableTimeperiods.cc | 2 +- livestatus/src/TimeColumnFilter.cc | 2 +- livestatus/src/TimeperiodsCache.cc | 10 +- livestatus/src/auth.cc | 22 +-- livestatus/src/store_c.cc | 10 +- livestatus/src/strutil.cc | 26 +-- livestatus/src/waittriggers.cc | 3 +- 67 files changed, 437 insertions(+), 416 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=adaac03a7e…

8 years, 7 months

Added clang-tidy Makefile target plus initial configuration.

by Sven Panne

Module: check_mk Branch: master Commit: 14dd66ab533cbedc519a6540a3104d68c54b54f3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=14dd66ab533cbe… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Wed Feb 3 15:15:05 2016 +0100 Added clang-tidy Makefile target plus initial configuration. --- .clang-tidy | 37 +++++++++++++++++++++++++++++++++++++ Makefile | 10 +++++++--- compiled_sources | 7 +++++++ 3 files changed, 51 insertions(+), 3 deletions(-) diff --git a/.clang-tidy b/.clang-tidy new file mode 100644 index 0000000..23e8d35 --- /dev/null +++ b/.clang-tidy @@ -0,0 +1,37 @@ +--- +# Classification of the excludes: +# +# * unclear, need to figure out if we want that: +# * cert-err58-cpp ("construction of 'foo' with static storage duration may throw an exception that cannot be caught") +# * cppcoreguidelines-pro-bounds-array-to-pointer-decay ("do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead") +# * cppcoreguidelines-pro-bounds-constant-array-index ("do not use array subscript when the index is not an integer constant expression; use gsl::at() instead") +# * cppcoreguidelines-pro-bounds-pointer-arithmetic ("do not use pointer arithmetic") +# * google-runtime-int ("consider replacing 'unsigned long' with 'uint64'") +# +# * undesirable checks: +# * cppcoreguidelines-pro-type-static-cast-downcast ("do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead") +# * llvm-include-order ("#includes are not sorted properly") +# +# * desirable checks, but hard to fix currently: +# * cert-dcl50-cpp ("do not define a C-style variadic function; consider using a function parameter pack or currying instead") +# * cppcoreguidelines-pro-type-vararg ("do not call c-style vararg functions") +# +# * desirable checks, but some places need to be suppressed: +# * cppcoreguidelines-pro-type-const-cast ("do not use const_cast") +# +# * desirable checks, but not yet fixed: +# * cppcoreguidelines-pro-type-cstyle-cast ("do not use C-style cast to convert between unrelated types") +# * cppcoreguidelines-pro-type-reinterpret-cast ("do not use reinterpret_cast") +# * google-readability-braces-around-statements ("statement should be inside braces") +# * google-readability-casting ("C-style casts are discouraged; use reinterpret_cast") +# * readability-braces-around-statements ("statement should be inside braces") +# * readability-else-after-return ("don't use else after return") +# * readability-implicit-bool-cast ("implicit cast 'foo' -> bool") +# * readability-inconsistent-declaration-parameter-name ("function 'foo' has a definition with different parameter names") +# * readability-named-parameter ("all parameters should be named in a function") +# +Checks: '*,-cert-dcl50-cpp,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-cstyle-cast,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-vararg,-google-readability-braces-around-statements,-google-readability-casting,-google-runtime-int,-llvm-include-order,-readability-braces-around-statements,-readability-else-after-return,-readability-implicit-bool-cast,-readability-inconsistent-declaration-parameter-name,-readability-named-parameter' +CheckOptions: + - key: google-readability-namespace-comments.SpacesBeforeComments + value: '1' +... diff --git a/Makefile b/Makefile index aa2e4bc..f35e1a5 100644 --- a/Makefile +++ b/Makefile @@ -35,6 +35,7 @@ TAROPTS := --owner=root --group=root --exclude=.svn --exclude=*~ \ CLANG_VERSION := 3.8 CLANG_FORMAT := clang-format-$(CLANG_VERSION) +CLANG_TIDY := clang-tidy-$(CLANG_VERSION) SCAN_BUILD := scan-build-$(CLANG_VERSION) CPPCHECK := cppcheck DOXYGEN := doxygen @@ -70,9 +71,9 @@ FILES_TO_FORMAT := $(wildcard $(addprefix agents/,*.cc *.c *.h)) \ $(wildcard $(addprefix mkeventd/src/,*.cc *.c *.h)) .PHONY: all check-binaries check check-permissions check-spaces check-version \ - clang-analyzer clean cppcheck dist documentation format headers \ - healspaces help iwyu minify-js mk-eventd mk-livestatus mrproper \ - optimize-images packages setup setversion version + clang-analyzer clang-tidy clean cppcheck dist documentation format \ + headers healspaces help iwyu minify-js mk-eventd mk-livestatus \ + mrproper optimize-images packages setup setversion version all: dist packages @@ -262,6 +263,9 @@ compile_commands.json: $(FILES_TO_FORMAT) $(MAKE) -C livestatus clean $(BEAR) $(MAKE) -C livestatus -j8 +clang-tidy: compile_commands.json + ./compiled_sources | xargs $(CLANG_TIDY) + # Not really perfect rules, but better than nothing iwyu: $(MAKE) -C livestatus clean diff --git a/compiled_sources b/compiled_sources new file mode 100755 index 0000000..89c6d23 --- /dev/null +++ b/compiled_sources @@ -0,0 +1,7 @@ +#!/usr/bin/python + +import json + +with open('compile_commands.json') as cc: + for command_object in json.load(cc): + print('"%s"' % command_object['file'])

8 years, 7 months

← Newer
1
...
29
30
31
32
33
34
35
...
41
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits February 2016