Checkmk git commits November 2016

checkmk-commits@lists.checkmk.com

9 participants
299 discussions

Revert "4106 mk_oracle.ps1: added Oracle wallet support to Windows plugin"

by Marcel Schulte

Module: check_mk Branch: master Commit: cc265c5e46b2bd5926de6cd61d5752abe504d73f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=cc265c5e46b2bd… Author: Marcel Schulte <ms(a)mathias-kettner.de> Date: Tue Nov 29 08:44:02 2016 +0100 Revert "4106 mk_oracle.ps1: added Oracle wallet support to Windows plugin" This reverts commit 40d69947837df6855e67415926f9cfee2e36cfee. --- .werks/4106 | 1 + ChangeLog | 1 - agents/windows/plugins/mk_oracle.ps1 | 23 ++++++----------------- 3 files changed, 7 insertions(+), 18 deletions(-) diff --git a/.werks/4106 b/.werks/4106 index 4c67f5b..3534f67 100644 --- a/.werks/4106 +++ b/.werks/4106 @@ -8,3 +8,4 @@ Class: feature Now you are able to filter by host- resp. service-service-level defined in global settings/notifications. + diff --git a/ChangeLog b/ChangeLog index 70b7b23..e6878e9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -11,7 +11,6 @@ * 4094 apc_rackpdu_power: now detects all phases or banks connected to this pdu NOTE: Please refer to the migration notes! * 3993 Some minor performance improvements during config generation... - * 4106 mk_oracle.ps1: added Oracle wallet support to Windows plugin... * 3987 FIX: Check_MK Agent Access: Windows agent reported incorrect only from value * 3952 FIX: diskstat: fixed bug if multipath devices having an alias... * 3939 FIX: f5_bigip_conns: readded performance data and graphs... diff --git a/agents/windows/plugins/mk_oracle.ps1 b/agents/windows/plugins/mk_oracle.ps1 index 0188ab1..bd212b9 100644 --- a/agents/windows/plugins/mk_oracle.ps1 +++ b/agents/windows/plugins/mk_oracle.ps1 @@ -123,8 +123,7 @@ Param( ) # if debug=1 then output if ($DEBUG -gt 0) { - $MYTIME=Get-Date -Format o - echo "${MYTIME} DEBUG:${error_message}" + echo "DEBUG:${error_message}" } } @@ -385,17 +384,11 @@ Param( else { $assysdbaconnect="" } + #$TNSALIAS="$the_host`:$the_port/$sqlsid" $UPPER_SID=$sqlsid.toupper() - - # use oracle wallet if requested in cfg file - if ($the_user -like "/" ) { - $SQL_CONNECT="/@$UPPER_SID$assysdbaconnect" - } - else { - $TNSALIAS="(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=$the_host)(PORT=$the_port))(CONNECT_DATA=(SID=$UPPER_SID)))" - # we presume we can use an EZconnect - $SQL_CONNECT="$the_user/$the_password@$TNSALIAS$assysdbaconnect" - } + $TNSALIAS="(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=$the_host)(PORT=$the_port))(CONNECT_DATA=(SID=$UPPER_SID)))" + # we presume we can use an EZconnect + $SQL_CONNECT="$the_user/$the_password@$TNSALIAS$assysdbaconnect" debug_echo "value of sql_connect in dbuser = $SQL_CONNECT" } else { debug_echo "DBUSER is not defined" @@ -1276,7 +1269,7 @@ $list_inst=(get-service -Name "Oracle*Service*" -include "OracleService*", "Orac # the following line ensures that the output of the files generated by calling # Oracle SQLplus through Powershell are not limited to 80 character width. The # 80 character width limit is the default -$Host.UI.RawUI.BufferSize = New-Object Management.Automation.Host.Size (512, 150) +$Host.UI.RawUI.BufferSize = New-Object Management.Automation.Host.Size (512, 50) # We have to set some value for the ORACLE_SID, although here a nonsense value # This value is used when we want to simply list all the banners @@ -1427,10 +1420,6 @@ if ($the_count -gt 0) { } } } - # We need an line break after last output from sections - # otherwise the agent adds <<<local>>> as parameter to the last line of plugin - echo "" - } debug_echo "got to the end"

8 years

updated windows binaries

by Andreas Boesl

Module: check_mk Branch: master Commit: 8cf13de9a23b61470893610508695ee91e46e868 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8cf13de9a23b61… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Mon Nov 28 17:17:29 2016 +0100 updated windows binaries --- agents/windows/build_version | 2 +- agents/windows/check_mk_agent-64.exe | Bin 1326592 -> 1326592 bytes agents/windows/check_mk_agent-64.unstripped.exe | Bin 15535465 -> 15499902 bytes agents/windows/check_mk_agent-64.unversioned.exe | Bin 1326592 -> 1326592 bytes agents/windows/check_mk_agent.exe | Bin 1302016 -> 1302016 bytes agents/windows/check_mk_agent.msi | Bin 2898432 -> 2898432 bytes agents/windows/check_mk_agent.unstripped.exe | Bin 13400795 -> 13400795 bytes agents/windows/check_mk_agent.unversioned.exe | Bin 1302016 -> 1302016 bytes agents/windows/install_agent-64.exe | Bin 585460 -> 585388 bytes agents/windows/install_agent.exe | Bin 582213 -> 582214 bytes 10 files changed, 1 insertion(+), 1 deletion(-) diff --git a/agents/windows/build_version b/agents/windows/build_version index 600debb..adcf4b8 100644 --- a/agents/windows/build_version +++ b/agents/windows/build_version @@ -1 +1 @@ -2155 +2158 diff --git a/agents/windows/check_mk_agent-64.exe b/agents/windows/check_mk_agent-64.exe index b590692..aafb5ec 100755 Binary files a/agents/windows/check_mk_agent-64.exe and b/agents/windows/check_mk_agent-64.exe differ diff --git a/agents/windows/check_mk_agent-64.unstripped.exe b/agents/windows/check_mk_agent-64.unstripped.exe index 1680d7c..73c4b2d 100755 Binary files a/agents/windows/check_mk_agent-64.unstripped.exe and b/agents/windows/check_mk_agent-64.unstripped.exe differ diff --git a/agents/windows/check_mk_agent-64.unversioned.exe b/agents/windows/check_mk_agent-64.unversioned.exe index 895328b..249afa6 100755 Binary files a/agents/windows/check_mk_agent-64.unversioned.exe and b/agents/windows/check_mk_agent-64.unversioned.exe differ diff --git a/agents/windows/check_mk_agent.exe b/agents/windows/check_mk_agent.exe index 56b8dc1..f4de2cd 100755 Binary files a/agents/windows/check_mk_agent.exe and b/agents/windows/check_mk_agent.exe differ diff --git a/agents/windows/check_mk_agent.msi b/agents/windows/check_mk_agent.msi index bc8c15c..45451d3 100755 Binary files a/agents/windows/check_mk_agent.msi and b/agents/windows/check_mk_agent.msi differ diff --git a/agents/windows/check_mk_agent.unstripped.exe b/agents/windows/check_mk_agent.unstripped.exe index 957afac..04ccdb8 100755 Binary files a/agents/windows/check_mk_agent.unstripped.exe and b/agents/windows/check_mk_agent.unstripped.exe differ diff --git a/agents/windows/check_mk_agent.unversioned.exe b/agents/windows/check_mk_agent.unversioned.exe index 2b543c3..3127386 100755 Binary files a/agents/windows/check_mk_agent.unversioned.exe and b/agents/windows/check_mk_agent.unversioned.exe differ diff --git a/agents/windows/install_agent-64.exe b/agents/windows/install_agent-64.exe index a587f44..a68c464 100755 Binary files a/agents/windows/install_agent-64.exe and b/agents/windows/install_agent-64.exe differ diff --git a/agents/windows/install_agent.exe b/agents/windows/install_agent.exe index c4fbd87..f7ef050 100755 Binary files a/agents/windows/install_agent.exe and b/agents/windows/install_agent.exe differ

8 years

Reserved 10 Werk IDS

by Marcel Schulte

Module: check_mk Branch: master Commit: b62fd285f18c798110385f0c5c57aa030d40c3e4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b62fd285f18c79… Author: Marcel Schulte <ms(a)mathias-kettner.de> Date: Mon Nov 28 17:10:33 2016 +0100 Reserved 10 Werk IDS --- .werks/first_free | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.werks/first_free b/.werks/first_free index 31e10a3..9c248c8 100644 --- a/.werks/first_free +++ b/.werks/first_free @@ -1 +1 @@ -4116 +4126

8 years

4106 mk_oracle.ps1: added Oracle wallet support to Windows plugin

by Marcel Schulte

Module: check_mk Branch: master Commit: 40d69947837df6855e67415926f9cfee2e36cfee URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=40d69947837df6… Author: Marcel Schulte <ms(a)mathias-kettner.de> Date: Mon Nov 28 09:40:14 2016 +0100 4106 mk_oracle.ps1: added Oracle wallet support to Windows plugin The plugin for windows could be used with the Oracle wallet. The support is limitted to all Instances except ASM. This function is only for administrators who really knows how to use the wallet. You have to add an entry with the name of the instance. Please check the connection with SQLPlus before trying to use the plugin. The plugin use the following connection: sqlplus /@<ORACLE_SID> You have to add a credential to the wallet with the ORACLE_SID as name for the entry: Example: mkstore -wrl <Wallet Directory> createCredential „<ORACLE_SID>" <Username> <Password> The wallet is only used, when username is set to '/'. Password, hostname and listener-port is ignored, because the tnsnames.ora is used. Please read the doumentation from Oracle for using the wallet. The sqlnet.ora must be configured for your environment and the wallet must be created before adding some entries. You could use TNS_ADMIN in mk_oracle.cfg.txt for pointing to the sqlnet configuration for the plugin. --- .werks/4106 | 1 - ChangeLog | 1 + agents/windows/plugins/mk_oracle.ps1 | 23 +++++++++++++++++------ 3 files changed, 18 insertions(+), 7 deletions(-) diff --git a/.werks/4106 b/.werks/4106 index 3534f67..4c67f5b 100644 --- a/.werks/4106 +++ b/.werks/4106 @@ -8,4 +8,3 @@ Class: feature Now you are able to filter by host- resp. service-service-level defined in global settings/notifications. - diff --git a/ChangeLog b/ChangeLog index e6878e9..70b7b23 100644 --- a/ChangeLog +++ b/ChangeLog @@ -11,6 +11,7 @@ * 4094 apc_rackpdu_power: now detects all phases or banks connected to this pdu NOTE: Please refer to the migration notes! * 3993 Some minor performance improvements during config generation... + * 4106 mk_oracle.ps1: added Oracle wallet support to Windows plugin... * 3987 FIX: Check_MK Agent Access: Windows agent reported incorrect only from value * 3952 FIX: diskstat: fixed bug if multipath devices having an alias... * 3939 FIX: f5_bigip_conns: readded performance data and graphs... diff --git a/agents/windows/plugins/mk_oracle.ps1 b/agents/windows/plugins/mk_oracle.ps1 index bd212b9..0188ab1 100644 --- a/agents/windows/plugins/mk_oracle.ps1 +++ b/agents/windows/plugins/mk_oracle.ps1 @@ -123,7 +123,8 @@ Param( ) # if debug=1 then output if ($DEBUG -gt 0) { - echo "DEBUG:${error_message}" + $MYTIME=Get-Date -Format o + echo "${MYTIME} DEBUG:${error_message}" } } @@ -384,11 +385,17 @@ Param( else { $assysdbaconnect="" } - #$TNSALIAS="$the_host`:$the_port/$sqlsid" $UPPER_SID=$sqlsid.toupper() - $TNSALIAS="(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=$the_host)(PORT=$the_port))(CONNECT_DATA=(SID=$UPPER_SID)))" - # we presume we can use an EZconnect - $SQL_CONNECT="$the_user/$the_password@$TNSALIAS$assysdbaconnect" + + # use oracle wallet if requested in cfg file + if ($the_user -like "/" ) { + $SQL_CONNECT="/@$UPPER_SID$assysdbaconnect" + } + else { + $TNSALIAS="(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=$the_host)(PORT=$the_port))(CONNECT_DATA=(SID=$UPPER_SID)))" + # we presume we can use an EZconnect + $SQL_CONNECT="$the_user/$the_password@$TNSALIAS$assysdbaconnect" + } debug_echo "value of sql_connect in dbuser = $SQL_CONNECT" } else { debug_echo "DBUSER is not defined" @@ -1269,7 +1276,7 @@ $list_inst=(get-service -Name "Oracle*Service*" -include "OracleService*", "Orac # the following line ensures that the output of the files generated by calling # Oracle SQLplus through Powershell are not limited to 80 character width. The # 80 character width limit is the default -$Host.UI.RawUI.BufferSize = New-Object Management.Automation.Host.Size (512, 50) +$Host.UI.RawUI.BufferSize = New-Object Management.Automation.Host.Size (512, 150) # We have to set some value for the ORACLE_SID, although here a nonsense value # This value is used when we want to simply list all the banners @@ -1420,6 +1427,10 @@ if ($the_count -gt 0) { } } } + # We need an line break after last output from sections + # otherwise the agent adds <<<local>>> as parameter to the last line of plugin + echo "" + } debug_echo "got to the end"

8 years

4077 FIX Fixed "Request URI too long" when cloning role after editing another one

by Lars Michelsen

Module: check_mk Branch: master Commit: f74d454f34d899f87a404b1f6bd0e01455648641 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f74d454f34d899… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Nov 28 14:38:16 2016 +0100 4077 FIX Fixed "Request URI too long" when cloning role after editing another one --- .werks/4077 | 9 +++++++++ ChangeLog | 1 + web/htdocs/wato.py | 4 ++-- 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/.werks/4077 b/.werks/4077 new file mode 100644 index 0000000..02abfb6 --- /dev/null +++ b/.werks/4077 @@ -0,0 +1,9 @@ +Title: Fixed "Request URI too long" when cloning role after editing another one +Level: 1 +Component: wato +Compatible: compat +Version: 1.4.0i3 +Date: 1480340280 +Class: fix + + diff --git a/ChangeLog b/ChangeLog index c82c455..e6878e9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -60,6 +60,7 @@ * 4068 FIX: Fixed possible exception in case of wrong automation secrets between multiple sites... * 3992 FIX: netapp_api_connection: fixed GUI display bug when editing rules * 4076 FIX: Git integration: Using mail address of user in author info + * 4077 FIX: Fixed "Request URI too long" when cloning role after editing another one Notifications: * 4042 FIX: Fix missing From address in synchronous SMTP notifications... diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index 1164e61..88b2695 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -10751,8 +10751,8 @@ def mode_roles(phase): # Actions table.cell(_("Actions"), css="buttons") edit_url = folder_preserving_link([("mode", "edit_role"), ("edit", id)]) - clone_url = html.makeactionuri([("_clone", id)]) - delete_url = html.makeactionuri([("_delete", id)]) + clone_url = make_action_link([("mode", "roles"), ("_clone", id)]) + delete_url = make_action_link([("mode", "roles"), ("_delete", id)]) html.icon_button(edit_url, _("Properties"), "edit") html.icon_button(clone_url, _("Clone"), "clone") if not role.get("builtin"):

8 years

4106 new filter host/service-service-level

by Simon Betz

Module: check_mk Branch: master Commit: dde1c7356f2daf1aacfcb32c96562160fd131e4f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=dde1c7356f2daf… Author: Simon Betz <si(a)mathias-kettner.de> Date: Mon Nov 28 13:53:10 2016 +0100 4106 new filter host/service-service-level Now you are able to filter by host- resp. service-service-level defined in global settings/notifications. --- .werks/4106 | 11 +++++++++++ ChangeLog | 1 + web/plugins/views/painters.py | 21 ++++++++++++++++----- web/plugins/visuals/filters.py | 34 ++++++++++++++++++++++++++++++++++ 4 files changed, 62 insertions(+), 5 deletions(-) diff --git a/.werks/4106 b/.werks/4106 new file mode 100644 index 0000000..3534f67 --- /dev/null +++ b/.werks/4106 @@ -0,0 +1,11 @@ +Title: new filter host/service-service-level +Level: 1 +Component: multisite +Compatible: compat +Version: 1.4.0i3 +Date: 1480337391 +Class: feature + +Now you are able to filter by host- resp. service-service-level +defined in global settings/notifications. + diff --git a/ChangeLog b/ChangeLog index 8b0d8ba..c82c455 100644 --- a/ChangeLog +++ b/ChangeLog @@ -36,6 +36,7 @@ Multisite: * 4070 Added a painter for the service check period * 4095 new filter host auxiliary tags + * 4106 new filter host/service-service-level... * 3974 FIX: Sorting comments in hover menu of comments icon by time now * 4040 FIX: Fix error in view about "No WATO folder ..." in case of host imported via cmcdump... * 4046 FIX: Repaired html rendering.... diff --git a/web/plugins/views/painters.py b/web/plugins/views/painters.py index 283c4e3..8f2a093 100644 --- a/web/plugins/views/painters.py +++ b/web/plugins/views/painters.py @@ -138,15 +138,24 @@ multisite_painter_options["matrix_omit_uniform"] = { # This helper function returns the value of the given custom var -def paint_custom_var(what, key, row): +def paint_custom_var(what, key, row, choices=None): + if choices is None: + choices = [] + if what: what += '_' + custom_vars = dict(zip(row[what + "custom_variable_names"], row[what + "custom_variable_values"])) if key in custom_vars: - return key, custom_vars[key] - return key, "" + custom_val = custom_vars[key] + if choices: + custom_val = dict(choices).get(int(custom_val), custom_val) + return key, custom_val + + return key, "" + def paint_nagios_link(row): @@ -1187,7 +1196,8 @@ multisite_painters["svc_servicelevel"] = { "title" : _("Service service level"), "short" : _("Service Level"), "columns" : [ "service_custom_variable_names", "service_custom_variable_values" ], - "paint" : lambda row: paint_custom_var('service', 'EC_SL', row), + "paint" : lambda row: paint_custom_var('service', 'EC_SL', row, + config.mkeventd_service_levels), "sorter" : 'servicelevel', } @@ -1745,7 +1755,8 @@ multisite_painters["host_servicelevel"] = { "title" : _("Host service level"), "short" : _("Service Level"), "columns" : [ "host_custom_variable_names", "host_custom_variable_values" ], - "paint" : lambda row: paint_custom_var('host', 'EC_SL', row), + "paint" : lambda row: paint_custom_var('host', 'EC_SL', row, + config.mkeventd_service_levels), "sorter" : 'servicelevel', } diff --git a/web/plugins/visuals/filters.py b/web/plugins/visuals/filters.py index f360a17..3c535a9 100644 --- a/web/plugins/visuals/filters.py +++ b/web/plugins/visuals/filters.py @@ -1215,6 +1215,40 @@ declare_filter(302, FilterHostAuxTags()) +# choices = [ (value, "readable"), .. ] +class FilterCustomVarChoice(Filter): + def __init__(self, name, title, info, custom_var, choices): + Filter.__init__(self, name, title, info, [ name ], []) + self.custom_var = custom_var + self.choices = choices + + + def display(self): + selection = [ ("", "") ] + self.choices + html.sorted_select(self.name, selection) + + + def filter(self, infoname): + this_custom_value = html.var(self.name) + if this_custom_value: + return "Filter: %s_custom_variables = %s %s\n" % \ + ( self.info, self.custom_var, lqencode(this_custom_value) ) + else: + return "" + + + +declare_filter(310, FilterCustomVarChoice( + "svc_service_level", _("Service service level"), + "service", "EC_SL", config.mkeventd_service_levels )) + + +declare_filter(310, FilterCustomVarChoice( + "hst_service_level", _("Host service level"), + "host", "EC_SL", config.mkeventd_service_levels )) + + + class FilterStarred(FilterTristate): def __init__(self, what): self.what = what

8 years

Reserved 10 Werk IDS

by Simon Betz

Module: check_mk Branch: master Commit: b6966fb7b249f21b78b3752448af1cf1e0926902 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b6966fb7b249f2… Author: Simon Betz <si(a)mathias-kettner.de> Date: Mon Nov 28 13:49:33 2016 +0100 Reserved 10 Werk IDS --- .werks/first_free | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.werks/first_free b/.werks/first_free index 39604ea..31e10a3 100644 --- a/.werks/first_free +++ b/.werks/first_free @@ -1 +1 @@ -4106 +4116

8 years

4076 FIX Git integration: Using mail address of user in author info

by Lars Michelsen

Module: check_mk Branch: master Commit: 09d0efb16082b7b7fb2654693a6df54f72db8a95 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=09d0efb16082b7… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Nov 28 12:28:46 2016 +0100 4076 FIX Git integration: Using mail address of user in author info --- .werks/4076 | 9 +++++++++ ChangeLog | 1 + web/htdocs/config.py | 16 +++++++++------- 3 files changed, 19 insertions(+), 7 deletions(-) diff --git a/.werks/4076 b/.werks/4076 new file mode 100644 index 0000000..35b7a38 --- /dev/null +++ b/.werks/4076 @@ -0,0 +1,9 @@ +Title: Git integration: Using mail address of user in author info +Level: 1 +Component: wato +Compatible: compat +Version: 1.4.0i3 +Date: 1480322901 +Class: fix + + diff --git a/ChangeLog b/ChangeLog index 4d2b296..8b0d8ba 100644 --- a/ChangeLog +++ b/ChangeLog @@ -58,6 +58,7 @@ * 4045 FIX: Tactical Overview: do not count OK events as problems * 4068 FIX: Fixed possible exception in case of wrong automation secrets between multiple sites... * 3992 FIX: netapp_api_connection: fixed GUI display bug when editing rules + * 4076 FIX: Git integration: Using mail address of user in author info Notifications: * 4042 FIX: Fix missing From address in synchronous SMTP notifications... diff --git a/web/htdocs/config.py b/web/htdocs/config.py index 1ef46c1..1b051da 100644 --- a/web/htdocs/config.py +++ b/web/htdocs/config.py @@ -297,10 +297,10 @@ class LoggedInUser(object): def __init__(self, user_id): self.id = user_id + self._load_confdir() self._load_roles() self._load_attributes() self._load_permissions() - self._load_confdir() self._load_site_config() @@ -342,12 +342,14 @@ class LoggedInUser(object): def _load_attributes(self): - if self.id in multisite_users: - self.attributes = multisite_users[self.id] - else: - self.attributes = { - "roles" : self.role_ids, - } + self.attributes = self.load_file("cached_profile", None) + if self.attributes == None: + if self.id in multisite_users: + self.attributes = multisite_users[self.id] + else: + self.attributes = { + "roles" : self.role_ids, + } self.alias = self.attributes.get("alias", self.id) self.email = self.attributes.get("email", self.id)

8 years

3994 FIX windows agent: fixed memory and file handle leak when using windows eventlog

by Andreas Boesl

Module: check_mk Branch: master Commit: 81cb55645fdd0c4e47cf340fb19d92268a878175 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=81cb55645fdd0c… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Mon Nov 28 10:34:02 2016 +0100 3994 FIX windows agent: fixed memory and file handle leak when using windows eventlog The windows agent did never close any dll files it opened... --- .werks/3994 | 10 +++ ChangeLog | 1 + agents/windows/EventLog.cc | 42 ++++------- agents/windows/EventLog.h | 89 +++++++++++++++++++++-- agents/windows/build_version | 2 +- agents/windows/check_mk_agent-64.exe | Bin 1326080 -> 1326592 bytes agents/windows/check_mk_agent-64.unstripped.exe | Bin 15489028 -> 15535465 bytes agents/windows/check_mk_agent-64.unversioned.exe | Bin 1326080 -> 1326592 bytes agents/windows/check_mk_agent.exe | Bin 1300992 -> 1302016 bytes agents/windows/check_mk_agent.msi | Bin 2896896 -> 2898432 bytes agents/windows/check_mk_agent.unstripped.exe | Bin 13394018 -> 13400795 bytes agents/windows/check_mk_agent.unversioned.exe | Bin 1300992 -> 1302016 bytes agents/windows/crash.exe | Bin 101624 -> 101624 bytes agents/windows/install_agent-64.exe | Bin 585192 -> 585460 bytes agents/windows/install_agent.exe | Bin 581743 -> 582213 bytes agents/windows/nowin.exe | Bin 103760 -> 103760 bytes 16 files changed, 110 insertions(+), 34 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=81cb55645f…

8 years

4075 Activate Changes has been reworked

by Lars Michelsen

Module: check_mk Branch: master Commit: 413dbeb2c40d39db049fab7b250ff7f410e19cb1 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=413dbeb2c40d39… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Nov 28 09:36:58 2016 +0100 4075 Activate Changes has been reworked The activate changes dialog of WATO has been reworked to improve several things: <ul> <li>It is now possible to add a comment during an activation. This optional comment is written to the audit log and can be used to document the logical reason for the changes you have made.</li> <li>Several activations can now run in parallel while they not affect the same site. This means that on each site one activation can be executed at the same time.</li> <li>Pending changes are now correctly acknowledged. In previous version when you started an activating, made a change during the run, the run acknowledged this just created change even if it has not been activated by the just finished activation run.</li> <li>Pending changes are now tracked for each site individually. Previous version only knew whether or not a change has been activated on <i>all</i> sites.</li> <li>Fixed locking problems during activation leading to possible issues when multiple users execute activations in parallel.</li> <li>You can now select a custom collection of sites and activate them in a bulk.</li> </ul> --- .werks/4075 | 25 +++++++++++++++++++++++++ ChangeLog | 1 + 2 files changed, 26 insertions(+) diff --git a/.werks/4075 b/.werks/4075 new file mode 100644 index 0000000..1da3a63 --- /dev/null +++ b/.werks/4075 @@ -0,0 +1,25 @@ +Title: Activate Changes has been reworked +Level: 2 +Component: wato +Compatible: compat +Version: 1.4.0i3 +Date: 1480321696 +Class: feature + +The activate changes dialog of WATO has been reworked to improve several things: + +<ul> + <li>It is now possible to add a comment during an activation. This optional comment + is written to the audit log and can be used to document the logical reason for + the changes you have made.</li> + <li>Several activations can now run in parallel while they not affect the same site. + This means that on each site one activation can be executed at the same time.</li> + <li>Pending changes are now correctly acknowledged. In previous version when you started + an activating, made a change during the run, the run acknowledged this just created + change even if it has not been activated by the just finished activation run.</li> + <li>Pending changes are now tracked for each site individually. Previous version only + knew whether or not a change has been activated on <i>all</i> sites.</li> + <li>Fixed locking problems during activation leading to possible issues when multiple + users execute activations in parallel.</li> + <li>You can now select a custom collection of sites and activate them in a bulk.</li> +</ul> diff --git a/ChangeLog b/ChangeLog index cb6ec53..5896fc2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -47,6 +47,7 @@ WATO: * 3984 Permissions can now be filtered by providing a search term on the "edit role" page... * 4044 Display host/service notification delay with d/h/m/s, not with fractions of minute + * 4075 Activate Changes has been reworked... * 4039 FIX: Fix UnicodeEncodeError exception in WATO folder display... * 4041 FIX: Fix exception when editing global configuration settings... * 3975 FIX: Improved error handling when trying to edit not existing global setting

8 years

← Newer
1
2
3
4
5
6
7
...
30
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits November 2016