Checkmk git commits January 2016

checkmk-commits@lists.checkmk.com

9 participants
303 discussions

Fixed possible exception when trying to transform dashboards

by Lars Michelsen

Module: check_mk Branch: master Commit: a11b5134288a8b043bfe3bb240000afc509027bd URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a11b5134288a8b… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jan 25 11:38:11 2016 +0100 Fixed possible exception when trying to transform dashboards --- web/htdocs/dashboard.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/web/htdocs/dashboard.py b/web/htdocs/dashboard.py index 7d00b29..b350d66 100644 --- a/web/htdocs/dashboard.py +++ b/web/htdocs/dashboard.py @@ -31,6 +31,7 @@ import wato loaded_with_language = False builtin_dashboards = {} +builtin_dashboards_transformed = False dashlet_types = {} # Declare constants to be used in the definitions of the dashboards @@ -57,8 +58,8 @@ def load_plugins(force): # Load plugins for dashboards. Currently these files # just may add custom dashboards by adding to builtin_dashboards. - load_web_plugins("dashboard", globals()) builtin_dashboards_transformed = False + load_web_plugins("dashboard", globals()) # This must be set after plugin loading to make broken plugins raise # exceptions all the time and not only the first time (when the plugins

8 years, 7 months

Smaller code cleanups

by Lars Michelsen

Module: check_mk Branch: master Commit: 1021a111ec6005546d529b54c94b7eceea017527 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1021a111ec6005… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jan 25 10:41:29 2016 +0100 Smaller code cleanups --- web/plugins/views/commands.py | 60 ++++++++++++++++++----------------------- 1 file changed, 26 insertions(+), 34 deletions(-) diff --git a/web/plugins/views/commands.py b/web/plugins/views/commands.py index bce0edc..8fbe3b0 100644 --- a/web/plugins/views/commands.py +++ b/web/plugins/views/commands.py @@ -501,16 +501,10 @@ config.declare_permission("action.downtimes", [ "user", "admin" ]) def command_downtime(cmdtag, spec, row): - try: - wato.recurring_downtimes_types - have_recurring_downtimes = True - except: - have_recurring_downtimes = False - down_from = int(time.time()) down_to = None - if have_recurring_downtimes and html.get_checkbox("_down_do_recur"): + if has_recurring_downtimes() and html.get_checkbox("_down_do_recur"): recurring_type = int(html.var("_down_recurring")) title_start = _("schedule a periodic downtime every %s") % wato.recurring_downtimes_types[recurring_type] else: @@ -611,8 +605,7 @@ def command_downtime(cmdtag, spec, row): duration = 0 if html.get_checkbox("_down_do_recur"): - recurring = int(html.var("_down_recurring")) - fixed_and_recurring = recurring * 2 + fixed + fixed_and_recurring = recurring_type * 2 + fixed else: fixed_and_recurring = fixed @@ -665,7 +658,6 @@ def get_child_hosts(site, hosts, recurse): def paint_downtime_buttons(what): - html.write(_('Downtime Comment')+": ") html.text_input("_down_comment", "", size=60, submit="") html.write("<hr>") @@ -707,22 +699,28 @@ def paint_downtime_buttons(what): html.checkbox("_include_childs_recurse", False, label=_('Do this recursively')) elif what == "service": html.write("<hr>") - html.checkbox("_on_hosts", False, label=_('Schedule downtimes on the affected hosts instead of on the individual services')) - - try: - wato.recurring_downtimes_types # Check if this exists - have_recurring_downtimes = True - except: - have_recurring_downtimes = False + html.checkbox("_on_hosts", False, label=_('Schedule downtimes on the affected ' + 'hosts instead of on the individual ' + 'services')) - if have_recurring_downtimes: + if has_recurring_downtimes(): html.write("<hr>") - html.checkbox("_down_do_recur", False, label=_("Repeat this downtime on a regular base every")) + html.checkbox("_down_do_recur", False, + label=_("Repeat this downtime on a regular base every")) html.write(" ") - html.select("_down_recurring", [ (str(k), v) for (k,v) in sorted(wato.recurring_downtimes_types.items())], "3") + recurring_selections = [ (str(k), v) for (k,v) in + sorted(wato.recurring_downtimes_types.items())] + html.select("_down_recurring", recurring_selections, "3") html.write(_("(This only works when using CMC)")) +def has_recurring_downtimes(): + try: + wato.recurring_downtimes_types # Check if this exists + return True + except NameError: + return False + multisite_commands.append({ "tables" : [ "host" ], @@ -755,26 +753,20 @@ multisite_commands.append({ multisite_commands.append({ "tables" : [ "downtime" ], "permission" : "action.downtimes", - "title" : _("Downtimes"), - "render" : lambda: \ - html.button("_remove_downtimes", _("Remove")), - "action" : lambda cmdtag, spec, row: \ - html.has_var("_remove_downtimes") and \ - ( "DEL_%s_DOWNTIME;%d" % (cmdtag, spec), - _("remove")) + "title" : _("Remove downtimes"), + "render" : lambda: html.button("_remove_downtimes", _("Remove")), + "action" : lambda cmdtag, spec, row: html.has_var("_remove_downtimes") and \ + ( "DEL_%s_DOWNTIME;%d" % (cmdtag, spec), _("remove")) }) # REMOVE COMMENTS (table comments) multisite_commands.append({ "tables" : [ "comment" ], "permission" : "action.addcomment", - "title" : _("Comments"), - "render" : lambda: \ - html.button("_remove_comments", _("Remove")), - "action" : lambda cmdtag, spec, row: \ - html.has_var("_remove_comments") and \ - ( "DEL_%s_COMMENT;%d" % (cmdtag, spec), - _("remove")) + "title" : _("Remove comments"), + "render" : lambda: html.button("_remove_comments", _("Remove")), + "action" : lambda cmdtag, spec, row: html.has_var("_remove_comments") and \ + ( "DEL_%s_COMMENT;%d" % (cmdtag, spec), _("remove")) }) #.

8 years, 7 months

Datetime valuespec can now optinally handle empty input and result in None

by Lars Michelsen

Module: check_mk Branch: master Commit: 7fcd499a8a095c572131ff94bbf7d14bcbe8d627 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7fcd499a8a095c… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jan 25 10:39:59 2016 +0100 Datetime valuespec can now optinally handle empty input and result in None --- web/htdocs/htmllib.py | 5 ++++- web/htdocs/valuespec.py | 9 ++++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/web/htdocs/htmllib.py b/web/htdocs/htmllib.py index 15ed9b0..4ee35fa 100644 --- a/web/htdocs/htmllib.py +++ b/web/htdocs/htmllib.py @@ -529,8 +529,11 @@ class html(GUITester): self.write(r'''onmouseover='this.style.backgroundImage="url(\"images/contextlink%s_hi.png\")";' ''' % what) self.write(r'''onmouseout='this.style.backgroundImage="url(\"images/contextlink%s.png\")";' ''' % what) + def number_input(self, varname, deflt = "", size=8, style="", submit=None): - self.text_input(varname, str(deflt), "number", size=size, style=style, submit=submit) + if deflt != None: + deflt = str(deflt) + self.text_input(varname, deflt, "number", size=size, style=style, submit=submit) # Needed if input elements are put into forms without the helper diff --git a/web/htdocs/valuespec.py b/web/htdocs/valuespec.py index c691b3c..3ffb467 100644 --- a/web/htdocs/valuespec.py +++ b/web/htdocs/valuespec.py @@ -1935,7 +1935,7 @@ class RelativeDate(OptionalDropdownChoice): # A ValueSpec for editing a date. The date is # represented as a UNIX timestamp x where x % seconds_per_day -# is zero (or will be ignored if non-zero), as long es +# is zero (or will be ignored if non-zero), as long as # include_time is not set to True class AbsoluteDate(ValueSpec): def __init__(self, **kwargs): @@ -1946,6 +1946,11 @@ class AbsoluteDate(ValueSpec): self._format = kwargs.get("format", self._include_time and "%F %T" or "%F") self._default_value = kwargs.get("default_value", None) self._allow_empty = kwargs.get('allow_empty', False) + # The default is that "None" means show current date/time in the + # input fields. This option changes the input fields to be empty by default + # and makes the value able to be None when no time is set. + # FIXME: Shouldn't this be the default? + self._none_means_empty = kwargs.get("none_means_empty", False) def default_value(self): if self._default_value != None: @@ -1963,6 +1968,8 @@ class AbsoluteDate(ValueSpec): return self.default_value() def split_date(self, value): + if self._none_means_empty and value == None: + return (None,) * 6 lt = time.localtime(value) return lt.tm_year, lt.tm_mon, lt.tm_mday, \ lt.tm_hour, lt.tm_min, lt.tm_sec

8 years, 7 months

#2892 qlogic_fcport: now supports QLogic FC Switch SANBox 5802 series

by Simon Betz

Module: check_mk Branch: master Commit: 805067d3791b0f84e1f0cf53955ad7db610d4d18 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=805067d3791b0f… Author: Simon Betz <si(a)mathias-kettner.de> Date: Mon Jan 25 10:13:29 2016 +0100 #2892 qlogic_fcport: now supports QLogic FC Switch SANBox 5802 series --- .werks/2892 | 9 +++++++++ ChangeLog | 1 + checks/qlogic_fcport | 4 +++- 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/.werks/2892 b/.werks/2892 new file mode 100644 index 0000000..419953c --- /dev/null +++ b/.werks/2892 @@ -0,0 +1,9 @@ +Title: qlogic_fcport: now supports QLogic FC Switch SANBox 5802 series +Level: 1 +Component: checks +Compatible: compat +Version: 1.2.7i4 +Date: 1453713134 +Class: feature + + diff --git a/ChangeLog b/ChangeLog index c58f68b..44621a6 100644 --- a/ChangeLog +++ b/ChangeLog @@ -93,6 +93,7 @@ NOTE: Please refer to the migration notes! * 1323 win_printers: Warning and Critical levels can now be set... * 1324 New Check for Dell Equallogic SAN Devices + * 2892 qlogic_fcport: now supports QLogic FC Switch SANBox 5802 series * 2660 FIX: fixed windows agent using the wrong working directory... * 2664 FIX: ps: Speedup in situation with many matching processes... * 2661 FIX: windows agent: fixed incomplete process list... diff --git a/checks/qlogic_fcport b/checks/qlogic_fcport index c2b4cad..8050960 100644 --- a/checks/qlogic_fcport +++ b/checks/qlogic_fcport @@ -216,10 +216,12 @@ check_info["qlogic_fcport"] = { # .1.3.6.1.4.1.3873.1.14 Qlogic-Switch # .1.3.6.1.4.1.3873.1.8 Qlogic-4Gb SAN Switch Module for IBM BladeCenter # .1.3.6.1.4.1.3873.1.12 QLogic 8 Gb and 4/8 Gb Intelligent Pass-thru Module + # .1.3.6.1.4.1.3873.1.9 QLogic SANBox 5802 FC Switch 'snmp_scan_function' : lambda oid: \ oid(".1.3.6.1.2.1.1.2.0").startswith(".1.3.6.1.4.1.3873.1.14") \ or oid(".1.3.6.1.2.1.1.2.0").startswith(".1.3.6.1.4.1.3873.1.8") \ - or oid(".1.3.6.1.2.1.1.2.0").startswith(".1.3.6.1.4.1.3873.1.12"), + or oid(".1.3.6.1.2.1.1.2.0").startswith(".1.3.6.1.4.1.3873.1.12") \ + or oid(".1.3.6.1.2.1.1.2.0").startswith(".1.3.6.1.4.1.3873.1.9"), 'group': 'qlogic_fcport', 'default_levels_variable': 'qlogic_fcport_default_levels', }

8 years, 7 months

Refactoring: splitup code for graph popups and graph dashlets

by Mathias Kettner

Module: check_mk Branch: master Commit: aaf1299761fe1f08f9f48b6f069cd641b939cf05 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=aaf1299761fe1f… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Sun Jan 24 13:41:08 2016 +0100 Refactoring: splitup code for graph popups and graph dashlets --- web/htdocs/js/checkmk.js | 2 +- web/htdocs/metrics.py | 194 ++++++++++++++++++++++--------------- web/htdocs/views.py | 2 +- web/plugins/dashboard/dashlets.py | 2 +- web/plugins/icons/builtin.py | 2 +- web/plugins/pages/shipped.py | 3 +- web/plugins/views/painters.py | 28 +++--- 7 files changed, 139 insertions(+), 94 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=aaf1299761…

8 years, 8 months

#2947 FIX LDAP: Simplified automatic sync logic

by Lars Michelsen

Module: check_mk Branch: master Commit: 77c71adb65c268ca28981cd4d846e09a5f419d19 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=77c71adb65c268… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jan 22 17:10:30 2016 +0100 #2947 FIX LDAP: Simplified automatic sync logic By default once an LDAP connection has been configured the LDAP synchronization was performed automatically in background in different situations: <ul> <li>During regular page processing (every 5 minutes)</li> <li>When opening the users configuration page</li> <li>Before activating the changed configuration</li> <li>On a remote site, when it receives a new configuration</li> </ul> This was configuable using the config option Automatic User Synchronization. One problem with the default configuration was that it enabled the sync also for slave sites in distributed environments. Having the sync enabled on a slave site a change in LDAP would trigger a change on the slave site which is then preventing further activating of changes from the master. One had to drop this change entry manually to solve this situation. Another problem was that such LDAP sync was executed in some kind of random way when any HTTP request could trigger it. This felt odd in cases where the LDAP sync could take a longer time when for example saving of a view took 50 seconds instead of less than one second. The sync during activating of the configuration was slowing down the workflow when the sync took longer. So we decided to change the automatic user synchronization to work this way now: It is now scheduled by the generic multisite cron job which is executed once a minute. The LDAP sync then triggered and starts when the previous synchronization has finished more than 5 minutes before. This interval can still be configured for each LDAP connection. The new default configuration is that the automatic LDAP synchronization is performed only on the master site in distributed setups. But you can change the option Automatic User Synchronization to either On all sites to make it be executed on all your sites or completely disable the automatic synchronization. You have the option to change this setting for individual sites using the site specific global settings. Once at least one LDAP connection is configured the Sync Users button is shown on the users page. It can be used to trigger the user synchronization manually. --- .werks/2947 | 56 ++++++++++++++++ ChangeLog | 1 + web/htdocs/index.py | 10 +-- web/htdocs/userdb.py | 71 ++++++++++++++++++--- web/htdocs/wato.py | 20 +++--- web/plugins/config/builtin.py | 2 +- web/plugins/{wato/userdb.py => cron/user_sync.py} | 14 +--- web/plugins/userdb/ldap.py | 4 +- web/plugins/wato/check_mk_configuration.py | 31 ++++----- 9 files changed, 148 insertions(+), 61 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=77c71adb65…

8 years, 8 months

metrics now imports operator, needed in plugins

by Mathias Kettner

Module: check_mk Branch: master Commit: bd776ec0879692fa41afd1483f188ab90d77e8b9 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=bd776ec0879692… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Jan 22 16:30:29 2016 +0100 metrics now imports operator, needed in plugins --- web/htdocs/metrics.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/htdocs/metrics.py b/web/htdocs/metrics.py index 1e34523..5a524c3 100644 --- a/web/htdocs/metrics.py +++ b/web/htdocs/metrics.py @@ -34,7 +34,7 @@ # unit: The definition-dict of a unit like in unit_info # graph_template: Template for a graph. Essentially a dict with the key "metrics" -import math, time, colorsys, shlex +import math, time, colorsys, shlex, operator import config, defaults, pagetypes, table from lib import * from valuespec import *

8 years, 8 months

Prepare Views snapin for links to custom graphs

by Mathias Kettner

Module: check_mk Branch: master Commit: aec126fff4d9ffcffd846e5a348bc664f6478277 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=aec126fff4d9ff… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Jan 22 10:19:49 2016 +0100 Prepare Views snapin for links to custom graphs --- web/htdocs/pagetypes.py | 25 +++++++++++++++++++++---- web/htdocs/visuals.py | 6 ++++-- web/plugins/sidebar/shipped.py | 11 +++++------ 3 files changed, 30 insertions(+), 12 deletions(-) diff --git a/web/htdocs/pagetypes.py b/web/htdocs/pagetypes.py index d057041..9e332cc 100644 --- a/web/htdocs/pagetypes.py +++ b/web/htdocs/pagetypes.py @@ -167,6 +167,9 @@ class Base: def description(self): return self._.get("description", "") + def is_empty(self): + return False + # Default values for the creation dialog can be overridden by the # sub class. @classmethod @@ -326,6 +329,14 @@ class PageRenderer: page.render() + # Links for the sidebar + @classmethod + def sidebar_links(self): + for page in self.pages(): + if not page.is_empty() and not page.is_hidden(): + yield page.topic(), page.title(), page.page_url() + + #. # .--Overridable---------------------------------------------------------. @@ -692,10 +703,10 @@ class Overridable: ### if render_custom_context_buttons: ### render_custom_context_buttons() - ### for other_what, info in visual_types.items(): - ### if what != other_what: - ### html.context_button(info["plural_title"].title(), 'edit_%s.py' % other_what, other_what[:-1]) - ### html.end_context_buttons() + + for other_type_name, other_pagetype in page_types.items(): + if self.type_name() != other_type_name: + html.context_button(other_pagetype.phrase("title_plural").title(), '%ss.py' % other_type_name, other_type_name) html.end_context_buttons() # Deletion @@ -1018,13 +1029,19 @@ def declare(page_type): page_type.declare_overriding_permissions() page_types[page_type.type_name()] = page_type + def page_type(page_type_name): return page_types[page_type_name] + def has_page_type(page_type_name): return page_type_name in page_types +def all_page_types(): + return page_types + + # Global module functions for the integration into the rest of the code # index.py uses the following function in order to complete its diff --git a/web/htdocs/visuals.py b/web/htdocs/visuals.py index 2995cd7..f5859dd 100644 --- a/web/htdocs/visuals.py +++ b/web/htdocs/visuals.py @@ -279,9 +279,11 @@ def page_list(what, title, visuals, custom_columns = [], for other_what, info in visual_types.items(): if what != other_what: html.context_button(info["plural_title"].title(), 'edit_%s.py' % other_what, other_what[:-1]) + # TODO: We hack in those visuals that already have been moved to pagetypes here - html.context_button(_("Graph collections"), "graph_collections.py", "graph_collection") - html.context_button(_("Bookmarks lists"), "bookmark_lists.py", "bookmark_list") + html.context_button(_("Graph Collections"), "graph_collections.py", "graph_collection") + html.context_button(_("Custom Graphs"), "custom_graphs.py", "custom_graph") + html.context_button(_("Bookmark Lists"), "bookmark_lists.py", "bookmark_list") html.end_context_buttons() diff --git a/web/plugins/sidebar/shipped.py b/web/plugins/sidebar/shipped.py index 9580b08..a4b93cf 100644 --- a/web/plugins/sidebar/shipped.py +++ b/web/plugins/sidebar/shipped.py @@ -29,8 +29,6 @@ import pagetypes, table from valuespec import * from lib import * - -#. # .--About---------------------------------------------------------------. # | _ _ _ | # | / \ | |__ ___ _ _| |_ | @@ -110,10 +108,11 @@ def render_views(): bulletlink(title, 'dashboard.py?name=%s' % name, onclick = "return wato_views_clicked(this)") # TODO: One day pagestypes should handle the complete snapin. - if pagetypes.has_page_type("graph_collection"): - for t, title, url in pagetypes.page_type("graph_collection").sidebar_links(): - if t == topic: - bulletlink(title, url) + for page_type in pagetypes.all_page_types().values(): + if issubclass(page_type, pagetypes.PageRenderer): + for t, title, url in page_type.sidebar_links(): + if t == topic: + bulletlink(title, url) if not first: # at least one item rendered html.end_foldable_container()

8 years, 8 months

#2946 FIX LDAP: User created during login does not trigger full user synchronisation anymore

by Lars Michelsen

Module: check_mk Branch: master Commit: 643525cdb88233f87e21e4a07c850d6087c140a3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=643525cdb88233… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jan 22 15:47:08 2016 +0100 #2946 FIX LDAP: User created during login does not trigger full user synchronisation anymore Previously, when a LDAP user logged in for the first time and the user was not created by an LDAP sync before, it triggered a full LDAP sync which might have created a lot of other users. This has been changed now to only synchronize this single user based on the sync configuration. --- .werks/2946 | 12 ++++++++++++ ChangeLog | 1 + web/plugins/userdb/ldap.py | 8 +++----- 3 files changed, 16 insertions(+), 5 deletions(-) diff --git a/.werks/2946 b/.werks/2946 new file mode 100644 index 0000000..62ba8ed --- /dev/null +++ b/.werks/2946 @@ -0,0 +1,12 @@ +Title: LDAP: User created during login does not trigger full user synchronisation anymore +Level: 1 +Component: multisite +Compatible: compat +Version: 1.2.7i4 +Date: 1453473922 +Class: fix + +Previously, when a LDAP user logged in for the first time and the user was not created +by an LDAP sync before, it triggered a full LDAP sync which might have created a lot +of other users. This has been changed now to only synchronize this single user based +on the sync configuration. diff --git a/ChangeLog b/ChangeLog index eb42ac9..c11edbe 100644 --- a/ChangeLog +++ b/ChangeLog @@ -240,6 +240,7 @@ * 2904 FIX: Improved error handling when custom url dashlets raise an exception... * 2830 FIX: Improved sorting in view column "Services colored according to state"... * 2945 FIX: LDAP: Fixed broken sync for LDAP connections named "ldap"... + * 2946 FIX: LDAP: User created during login does not trigger full user synchronisation anymore... WATO: * 2442 WATO remove host: improved cleanup of obsolete host files... diff --git a/web/plugins/userdb/ldap.py b/web/plugins/userdb/ldap.py index f2ce5a0..8423536 100644 --- a/web/plugins/userdb/ldap.py +++ b/web/plugins/userdb/ldap.py @@ -906,11 +906,6 @@ class LDAPUserConnector(UserConnector): self.log('SYNC STARTED') self.log(' SYNC PLUGINS: %s' % ', '.join(self._config['active_plugins'].keys())) - # Unused at the moment, always sync all users - #filt = None - #if only_username: - # filt = '(%s=%s)' % (self.user_id_attr(), only_username) - ldap_users = self.get_users() import wato @@ -939,6 +934,9 @@ class LDAPUserConnector(UserConnector): mode_create, user = load_user(user_id) user_connection_id = cleanup_connection_id(user.get('connector')) + if only_username and user_id != only_username: + continue # Only one user should be synced, skip others. + # Name conflict: Found a user that has an equal name, but is not controlled # by this connector. Don't sync it. When an LDAP connection suffix is configured # use this for constructing a unique username. If not or if the name+suffix is

8 years, 8 months

Preventing password completion of browsers in LDAP connection edit form

by Lars Michelsen

Module: check_mk Branch: master Commit: 3e8e5f8f7ad66430286b12bce12712a688b5dc6f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3e8e5f8f7ad664… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jan 22 15:05:38 2016 +0100 Preventing password completion of browsers in LDAP connection edit form --- web/htdocs/wato.py | 1 + 1 file changed, 1 insertion(+) diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index f5078cf..c929f8d 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -6005,6 +6005,7 @@ def mode_edit_ldap_connection(phase): html.write('<div id=ldap>') html.write('<table><tr><td>') html.begin_form("connection", method="POST") + html.prevent_password_auto_completion() vs.render_input("connection", connection_cfg) vs.set_focus("connection") html.button("_save", _("Save"))

8 years, 8 months

← Newer
1
...
10
11
12
13
14
15
16
...
31
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits January 2016