Checkmk git commits September 2015

checkmk-commits@lists.checkmk.com

8 participants
275 discussions

Check_MK Git: check_mk: #2627 FIX knuerr_sensors: no longer creates a service for unnamed sensor

by Sebastian Herbord

Module: check_mk Branch: master Commit: cafe7e55ea7106ae427eebcc9d545be3da683b31 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=cafe7e55ea7106… Author: Sebastian Herbord <sh(a)mathias-kettner.de> Date: Mon Sep 21 10:06:31 2015 +0200 #2627 FIX knuerr_sensors: no longer creates a service for unnamed sensor The device seems to send readings for unconnected sensor slots. A missing name seems to be the only indication that no sensor is connected. --- .werks/2627 | 10 ++++++++++ ChangeLog | 1 + checks/knuerr_sensors | 3 ++- 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/.werks/2627 b/.werks/2627 new file mode 100644 index 0000000..5834fb7 --- /dev/null +++ b/.werks/2627 @@ -0,0 +1,10 @@ +Title: knuerr_sensors: no longer creates a service for unnamed sensor +Level: 1 +Component: checks +Compatible: compat +Version: 1.2.7i3 +Date: 1442822660 +Class: fix + +The device seems to send readings for unconnected sensor slots. A missing name seems to be the only +indication that no sensor is connected. diff --git a/ChangeLog b/ChangeLog index fe028fa..1f5b67a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -193,6 +193,7 @@ * 2428 FIX: "Clustered services for overlapping cluster": Improved rule matching... * 2608 FIX: kemp_loadmaster_ha: Fixed wrong discovery on snmp monitored linux systems * 2609 FIX: mysql_capacity: Can now handle sizes reported being NULL... + * 2627 FIX: knuerr_sensors: no longer creates a service for unnamed sensor... Multisite: * 2385 SEC: Fixed possible reflected XSS on all GUI pages where users can produce unhandled exceptions... diff --git a/checks/knuerr_sensors b/checks/knuerr_sensors index 968fcde..5b2e1db 100644 --- a/checks/knuerr_sensors +++ b/checks/knuerr_sensors @@ -26,7 +26,8 @@ def inventory_knuerr_sensors(info): for sensor, state in info: - yield sensor, None + if sensor: + yield sensor, None def check_knuerr_sensors(item, _no_params, info): for sensor, state in info:

8 years, 12 months

Check_MK Git: check_mk: #2615 FIX Fixed bug in legacy dashboard conversion when having users not permitted to access embedded views

by Lars Michelsen

Module: check_mk Branch: master Commit: 328a58cb1b4c4021e9dfd48de057e265a63ae711 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=328a58cb1b4c40… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Sep 18 14:09:49 2015 +0200 #2615 FIX Fixed bug in legacy dashboard conversion when having users not permitted to access embedded views When you have legacy dashoards (defined via plugin, located below local/share/check_mk/web/plugins/dashboards) defined which include a view where some of your users don't have access to and these users are the first ones to access the GUI after apache reload/restart, this could result in exceptions like this for other users: "KeyError: 'datasource'". --- .werks/2615 | 12 +++++++++++ ChangeLog | 1 + web/htdocs/dashboard.py | 52 +++++++++++++++++++++++++++++++++-------------- web/htdocs/views.py | 3 +++ 4 files changed, 53 insertions(+), 15 deletions(-) diff --git a/.werks/2615 b/.werks/2615 new file mode 100644 index 0000000..77e199b --- /dev/null +++ b/.werks/2615 @@ -0,0 +1,12 @@ +Title: Fixed bug in legacy dashboard conversion when having users not permitted to access embedded views +Level: 1 +Component: multisite +Class: fix +Compatible: compat +State: unknown +Version: 1.2.7i3 +Date: 1442578060 + +When you have legacy dashoards (defined via plugin, located below local/share/check_mk/web/plugins/dashboards) defined which include a view where some of your users don't have access to and these +users are the first ones to access the GUI after apache reload/restart, this could result +in exceptions like this for other users: "KeyError: 'datasource'". diff --git a/ChangeLog b/ChangeLog index 601b674..ede647a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -239,6 +239,7 @@ * 2597 FIX: Fix settings downtimes on BI aggregates in distributed environment... * 2598 FIX: Remove button for removing downtimes an BI aggregates because it cannot work... * 2607 FIX: Fixed broken links from BI views to aggregation group views + * 2615 FIX: Fixed bug in legacy dashboard conversion when having users not permitted to access embedded views... WATO: * 2365 Removed old deprecated notification global options for plain emails... diff --git a/web/htdocs/dashboard.py b/web/htdocs/dashboard.py index e85bd67..e37b121 100644 --- a/web/htdocs/dashboard.py +++ b/web/htdocs/dashboard.py @@ -180,7 +180,7 @@ def transform_builtin_dashboards(): view_name = dashlet['view'].split('&')[0] # Copy the view definition into the dashlet - load_view_into_dashlet(dashlet, nr, view_name) + load_view_into_dashlet(dashlet, nr, view_name, load_from_all_views=True) del dashlet['view'] else: @@ -206,21 +206,44 @@ def transform_builtin_dashboards(): dashboard.setdefault('description', dashboard.get('title', '')) builtin_dashboards_transformed = True -def load_view_into_dashlet(dashlet, nr, view_name, add_context=None): +def load_view_into_dashlet(dashlet, nr, view_name, add_context=None, load_from_all_views=False): import views views.load_views() - views = views.permitted_views() - if view_name in views: - view = copy.deepcopy(views[view_name]) - dashlet.update(view) - if add_context: - dashlet['context'].update(add_context) - - # Overwrite the views default title with the context specific title - dashlet['title'] = visuals.visual_title('view', view) - dashlet['title_url'] = html.makeuri_contextless( - [('view_name', view_name)] + visuals.get_singlecontext_vars(view).items(), - filename='view.py') + + permitted_views = views.permitted_views() + + # it is random which user is first accessing + # an apache python process, initializing the dashboard loading and conversion of + # old dashboards. In case of the conversion we really try hard to make the conversion + # work in all cases. So we need all views instead of the views of the user. + if load_from_all_views and view_name not in permitted_views: + # This is not really 100% correct according to the logic of visuals.available(), + # but we do this for the rare edge case during legacy dashboard conversion, so + # this should be sufficient + view = None + for (u, n), this_view in views.all_views().items(): + # take the first view with a matching name + if view_name == n: + view = this_view + break + + if not view: + raise MKGeneralException(_("Failed to convert a builtin dashboard which is referencing " + "the view \"%s\". You will have to migrate it to the new " + "dashboard format on your own to work properly." % view_name)) + else: + view = permitted_views[view_name] + + view = copy.deepcopy(view) # Clone the view + dashlet.update(view) + if add_context: + dashlet['context'].update(add_context) + + # Overwrite the views default title with the context specific title + dashlet['title'] = visuals.visual_title('view', view) + dashlet['title_url'] = html.makeuri_contextless( + [('view_name', view_name)] + visuals.get_singlecontext_vars(view).items(), + filename='view.py') dashlet['type'] = 'view' dashlet['name'] = 'dashlet_%d' % nr @@ -681,7 +704,6 @@ def ajax_dashlet(): if the_dashlet['type'] not in dashlet_types: raise MKGeneralException(_('The requested dashlet type does not exist.')) - render_dashlet_content(ident, the_dashlet, stash_html_vars=False) #. diff --git a/web/htdocs/views.py b/web/htdocs/views.py index 360ab29..284c85c 100644 --- a/web/htdocs/views.py +++ b/web/htdocs/views.py @@ -101,6 +101,9 @@ def permitted_views(): load_views() return available_views +def all_views(): + return multisite_views + # Convert views that are saved in the pre 1.2.6-style # FIXME: Can be removed one day. Mark as incompatible change or similar. def transform_old_views():

9 years

Check_MK Git: check_mk: #2626 ps check configurable to list state of individual processes in long output

by Sebastian Herbord

Module: check_mk Branch: master Commit: f82654d2a7d13c813df84cdf5d093342f239f27c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f82654d2a7d13c… Author: Sebastian Herbord <sh(a)mathias-kettner.de> Date: Fri Sep 18 13:26:08 2015 +0200 #2626 ps check configurable to list state of individual processes in long output The configuration parameter is called "Enable per-process details in long-output" and it can be set to either text or HTML output. HTML output works only if html escaping has been disabled in global settings which may be a potential security problem. --- .werks/2626 | 11 ++++ ChangeLog | 1 + checks/ps.include | 94 ++++++++++++++++++++++++++++++++-- web/plugins/wato/check_parameters.py | 18 ++++++- 4 files changed, 118 insertions(+), 6 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=f82654d2a7…

9 years

Check_MK Git: check_mk: #2614 FIX Fixed exception when processing events with umlaut in names from history

by Lars Michelsen

Module: check_mk Branch: master Commit: 58cb8ece2d72094f4dccb1cd4824f578996e3fa3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=58cb8ece2d7209… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Sep 18 12:42:52 2015 +0200 #2614 FIX Fixed exception when processing events with umlaut in names from history --- .werks/2614 | 10 ++++++++++ ChangeLog | 1 + mkeventd/bin/mkeventd | 2 +- 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.werks/2614 b/.werks/2614 new file mode 100644 index 0000000..2c3a62c --- /dev/null +++ b/.werks/2614 @@ -0,0 +1,10 @@ +Title: Fixed exception when processing events with umlaut in names from history +Level: 1 +Component: ec +Class: fix +Compatible: compat +State: unknown +Version: 1.2.7i3 +Date: 1442572943 + + diff --git a/ChangeLog b/ChangeLog index 92b5031..601b674 100644 --- a/ChangeLog +++ b/ChangeLog @@ -296,6 +296,7 @@ * 2322 FIX: mkeventd: MIBs are now only loaded if SNMP Traps translation is activated... * 2460 FIX: Slightly more robust SNMP trap translation... * 2534 FIX: Fixed implementation of skipping rule packs + * 2614 FIX: Fixed exception when processing events with umlaut in names from history Livestatus: * 2493 FIX: Fixed wrong JSON format when using stats queries together with header columns... diff --git a/mkeventd/bin/mkeventd b/mkeventd/bin/mkeventd index 3794562..615ab2e 100755 --- a/mkeventd/bin/mkeventd +++ b/mkeventd/bin/mkeventd @@ -858,7 +858,7 @@ def parse_history_file(path, headers, filters, greptexts, limit): break try: - parts = line.rstrip('\n').split('\t') + parts = line.decode('utf-8').rstrip('\n').split('\t') convert_history_line(parts) values = [line_no] + parts if g_status_server.filter_row(headers, filters, values):

9 years

Check_MK Git: check_mk: .f12 deploys to heute site by default

by Lars Michelsen

Module: check_mk Branch: master Commit: deb405ef05e500c995ca1fca2c6a1c3fd336f28d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=deb405ef05e500… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Sep 18 11:57:40 2015 +0200 .f12 deploys to heute site by default --- .gitignore | 1 - .site | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 530c05a..6b8333b 100644 --- a/.gitignore +++ b/.gitignore @@ -19,4 +19,3 @@ check-mk-agent-*.msi .metadata RemoteSystemsTempFiles .directory -.site diff --git a/.site b/.site new file mode 100644 index 0000000..48a0c6f --- /dev/null +++ b/.site @@ -0,0 +1 @@ +heute

9 years

Check_MK Git: check_mk: #2613 SEC Additional fix for refleced XSS on index page using start_url

by Lars Michelsen

Module: check_mk Branch: master Commit: 380b27b93ce721f1ab561b143f23cc560ab7caaa URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=380b27b93ce721… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Sep 18 10:31:39 2015 +0200 #2613 SEC Additional fix for refleced XSS on index page using start_url The issue has already been addressed in werk #2388, but was not really fixing the problem for all cases. --- .werks/2613 | 11 +++++++++++ ChangeLog | 1 + web/htdocs/main.py | 2 +- 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/.werks/2613 b/.werks/2613 new file mode 100644 index 0000000..2ae4414 --- /dev/null +++ b/.werks/2613 @@ -0,0 +1,11 @@ +Title: Additional fix for refleced XSS on index page using start_url +Level: 1 +Component: multisite +Class: security +Compatible: compat +State: unknown +Version: 1.2.7i3 +Date: 1442565029 + +The issue has already been addressed in werk #2388, but was not really +fixing the problem for all cases. diff --git a/ChangeLog b/ChangeLog index d439275..92b5031 100644 --- a/ChangeLog +++ b/ChangeLog @@ -209,6 +209,7 @@ * 2491 Allow clickable URLs in comments and downtime texts... * 2512 Custom Icons/Actions: URLs target frames can now be configured... * 2612 SEC: Fixed possible XSS on service detail page using the long service output... + * 2613 SEC: Additional fix for refleced XSS on index page using start_url... * 2314 FIX: Availability: fixed exception when grouping by host or service group * 2361 FIX: Fix exception for missing key 'title' in certain cases of older customized views * 2379 FIX: Plugin-Output: Fixed handling of URLs within output of check_http... diff --git a/web/htdocs/main.py b/web/htdocs/main.py index 2ce6dd8..8133673 100644 --- a/web/htdocs/main.py +++ b/web/htdocs/main.py @@ -36,7 +36,7 @@ def page_index(): start_url = default_start_url # Also prevent using of "javascript:" URLs which could used to inject code - if start_url.startswith('javascript:'): + if start_url.lower().startswith('javascript:'): start_url = default_start_url if "%s" in config.page_heading:

9 years

Check_MK Git: check_mk: wato_import.py minor fix: .wato file are now written

by Bastian Kuhn

Module: check_mk Branch: master Commit: 723e7c334f539dfbda918b982b2d9fd233adb5a0 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=723e7c334f539d… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Fri Sep 18 10:24:15 2015 +0200 wato_import.py minor fix: .wato file are now written --- doc/treasures/wato_import.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/doc/treasures/wato_import.py b/doc/treasures/wato_import.py index 5d8f17b..8a6ad35 100644 --- a/doc/treasures/wato_import.py +++ b/doc/treasures/wato_import.py @@ -83,3 +83,7 @@ for folder in folders: ziel.write(ips) ziel.write('})\n\n') ziel.close() + + wato = open(pathlokal + folder + '/.wato','w') + wato.write("{'attributes': {}, 'num_hosts': %d, 'title': '%s'}\n" % ( len(folders[folder]), folder) ) + wato.close()

9 years

Check_MK Git: check_mk: #2612 SEC Fixed possible XSS on service detail page using the long service output

by Lars Michelsen

Module: check_mk Branch: master Commit: 673f0addeeb867f3c620d0bcbc1d43ac14783492 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=673f0addeeb867… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Sep 18 10:08:10 2015 +0200 #2612 SEC Fixed possible XSS on service detail page using the long service output Normaly all check results displayed in the GUI are HTML escaped by default. The escaping was missing for the long service output of the service detail page. So one could create multi line check results containing HTML/Javascript code which would be executed when a user opens the service detail page of the service with the check result containing the injected code. The issue has been fixed by escaping the long output exactly like the normal plugin output. One difference is left: newline characters are replaced by HTML newlines to make displaying of multiple lines still possible. If you want the old behaviour back, you can disable the plugin output escaping using the global settings. But please note that an attacker might be able to inject javascript code. --- .werks/2612 | 23 +++++++++++++++++++++++ ChangeLog | 1 + web/plugins/views/painters.py | 2 +- 3 files changed, 25 insertions(+), 1 deletion(-) diff --git a/.werks/2612 b/.werks/2612 new file mode 100644 index 0000000..bc65f16 --- /dev/null +++ b/.werks/2612 @@ -0,0 +1,23 @@ +Title: Fixed possible XSS on service detail page using the long service output +Level: 2 +Component: multisite +Class: security +Compatible: compat +State: unknown +Version: 1.2.7i3 +Date: 1442563370 + +Normaly all check results displayed in the GUI are HTML escaped by default. +The escaping was missing for the long service output of the service detail +page. So one could create multi line check results containing HTML/Javascript +code which would be executed when a user opens the service detail page of +the service with the check result containing the injected code. + +The issue has been fixed by escaping the long output exactly like the normal +plugin output. One difference is left: newline characters are replaced by +HTML newlines to make displaying of multiple lines still possible. + +If you want the old behaviour back, you can disable the plugin output escaping +using the global settings. But please note that an attacker might be able to +inject javascript code. + diff --git a/ChangeLog b/ChangeLog index 759efe1..d439275 100644 --- a/ChangeLog +++ b/ChangeLog @@ -208,6 +208,7 @@ * 2501 Implemented new crash report handling... * 2491 Allow clickable URLs in comments and downtime texts... * 2512 Custom Icons/Actions: URLs target frames can now be configured... + * 2612 SEC: Fixed possible XSS on service detail page using the long service output... * 2314 FIX: Availability: fixed exception when grouping by host or service group * 2361 FIX: Fix exception for missing key 'title' in certain cases of older customized views * 2379 FIX: Plugin-Output: Fixed handling of URLs within output of check_http... diff --git a/web/plugins/views/painters.py b/web/plugins/views/painters.py index fd085cf..f72e398 100644 --- a/web/plugins/views/painters.py +++ b/web/plugins/views/painters.py @@ -517,7 +517,7 @@ multisite_painters["svc_long_plugin_output"] = { "title" : _("Long output of check plugin (multiline)"), "short" : _("Status detail"), "columns" : ["service_long_plugin_output"], - "paint" : lambda row: paint_stalified(row, row["service_long_plugin_output"].replace('\\n', '<br>').replace('\n', '<br>')), + "paint" : lambda row: paint_stalified(row, format_plugin_output(row["service_long_plugin_output"], row).replace('\\n', '<br>').replace('\n', '<br>')), } multisite_painters["svc_perf_data"] = { "title" : _("Service performance data"),

9 years

Check_MK Git: check_mk: #2611 FIX Fixed host view permission checks on host related pages

by Lars Michelsen

Module: check_mk Branch: master Commit: 0fe2ad1c69e7b40fd04f49168a21614bb9fad300 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=0fe2ad1c69e7b4… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Sep 18 09:05:45 2015 +0200 #2611 FIX Fixed host view permission checks on host related pages Different host related pages (properties, services, rulesets, diagnose) were lacking a "read host" permission checks. So user were able to view details about hosts which they were not permitted. --- .werks/2611 | 12 ++++++++++++ ChangeLog | 1 + web/htdocs/wato.py | 13 +++++++++++++ 3 files changed, 26 insertions(+) diff --git a/.werks/2611 b/.werks/2611 new file mode 100644 index 0000000..3b4c2dc --- /dev/null +++ b/.werks/2611 @@ -0,0 +1,12 @@ +Title: Fixed host view permission checks on host related pages +Level: 1 +Component: wato +Class: fix +Compatible: compat +State: unknown +Version: 1.2.7i3 +Date: 1442559852 + +Different host related pages (properties, services, rulesets, diagnose) were lacking +a "read host" permission checks. So user were able to view details about hosts which +they were not permitted. diff --git a/ChangeLog b/ChangeLog index 11e3c61..759efe1 100644 --- a/ChangeLog +++ b/ChangeLog @@ -267,6 +267,7 @@ * 2560 FIX: Fixed rare exception when using bulk host move... * 2603 FIX: Git integration: Preventing issues with *.mk.new files... * 2610 FIX: Fixed host search showing results of not permitted folder + * 2611 FIX: Fixed host view permission checks on host related pages... Notifications: * 2478 Integrated notification plugin for mobile phone push messages via Pushover... diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index 4635fdb..b1f3526 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -2003,11 +2003,14 @@ def mode_edithost(phase, new, cluster): host = g_folder[".hosts"][clonename] cluster = ".nodes" in host mode = "clone" + check_host_permissions(clonename) + elif not new and hostname in g_folder[".hosts"]: title = _("Properties of host") + " " + hostname host = g_folder[".hosts"][hostname] cluster = ".nodes" in host mode = "edit" + check_host_permissions(hostname) else: if cluster: title = _("Create new cluster") @@ -2017,6 +2020,7 @@ def mode_edithost(phase, new, cluster): host = {} mode = "new" new = True + check_new_host_permissions(g_folder, host, hostname) if phase == "title": return title @@ -2252,6 +2256,8 @@ def mode_rename_host(phase): if hostname not in g_folder[".hosts"]: raise MKGeneralException(_("You called this page with an invalid host name.")) + check_host_permissions(hostname) + host = g_folder[".hosts"][hostname] is_cluster = ".nodes" in host @@ -2545,6 +2551,9 @@ def mode_object_parameters(phase): is_cluster = ".nodes" in host service = html.var("service") + if hostname: + check_host_permissions(hostname) + if phase == "title": title = _("Parameters of") + " " + hostname if service: @@ -2903,6 +2912,8 @@ def mode_diag_host(phase): if not hostname: raise MKGeneralException(_('The hostname is missing.')) + check_host_permissions(hostname) + if phase == 'title': return _('Diagnostic of host') + " " + hostname @@ -3125,6 +3136,8 @@ def mode_inventory(phase, firsttime): raise MKGeneralException(_("You called this page for a non-existing host.")) host = g_folder[".hosts"][hostname] + check_host_permissions(hostname) + if phase == "title": title = _("Services of host %s") % hostname if html.var("_scan"):

9 years

Check_MK Git: check_mk: #2610 FIX Fixed host search showing results of not permitted folder

by Lars Michelsen

Module: check_mk Branch: master Commit: 6d72c5af83db6926d7c033197ea16301f3dbc90d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=6d72c5af83db69… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Sep 18 08:51:55 2015 +0200 #2610 FIX Fixed host search showing results of not permitted folder --- .werks/2610 | 10 ++++++++++ ChangeLog | 1 + web/htdocs/wato.py | 4 ++++ 3 files changed, 15 insertions(+) diff --git a/.werks/2610 b/.werks/2610 new file mode 100644 index 0000000..c8b696a --- /dev/null +++ b/.werks/2610 @@ -0,0 +1,10 @@ +Title: Fixed host search showing results of not permitted folder +Level: 1 +Component: wato +Class: fix +Compatible: compat +State: unknown +Version: 1.2.7i3 +Date: 1442559080 + + diff --git a/ChangeLog b/ChangeLog index e15c45b..11e3c61 100644 --- a/ChangeLog +++ b/ChangeLog @@ -266,6 +266,7 @@ * 2552 FIX: API: Service Discovery action is now creating missing pending log entry and marks the site dirty * 2560 FIX: Fixed rare exception when using bulk host move... * 2603 FIX: Git integration: Preventing issues with *.mk.new files... + * 2610 FIX: Fixed host search showing results of not permitted folder Notifications: * 2478 Integrated notification plugin for mobile phone push messages via Pushover... diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index 48950c6..4635fdb 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -3491,6 +3491,10 @@ def search_hosts_in_folders(folder, crit): def search_hosts_in_folder(folder, crit): found = [] + + if check_folder_permissions(folder, "read", exception=False) != True: + return 0 + hosts = load_hosts(folder) for hostname, host in hosts.items(): if crit[".name"] and crit[".name"].lower() not in hostname.lower():

9 years

← Newer
1
...
7
8
9
10
11
12
13
...
28
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits September 2015