Checkmk git commits February 2015

checkmk-commits@lists.checkmk.com

8 participants
297 discussions

Check_MK Git: check_mk: #2040 Allow commands for setting downtimes and acknowledging on BI aggregates

by Mathias Kettner

Module: check_mk Branch: master Commit: 5887711f63d30fab62bf7455ee9145471a95de53 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5887711f63d30f… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Feb 26 16:34:11 2015 +0100 #2040 Allow commands for setting downtimes and acknowledging on BI aggregates The commands for scheduling downtimes and for acknowledging problems and removing acknowledgements now can be done on BI aggregates. This is the same as performing these commands on all hosts and services that are contained in the selected BI aggregates. Note: removing downtimes currently does not work that way. --- .werks/2040 | 12 ++++ ChangeLog | 1 + mkeventd/web/plugins/visuals/mkeventd.py | 2 + web/htdocs/bi.py | 2 - web/htdocs/views.py | 19 ++++-- web/plugins/views/commands.py | 92 +++++++++++++++++++++++------- web/plugins/visuals/infos.py | 12 ++++ 7 files changed, 112 insertions(+), 28 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=5887711f63…

9 years, 4 months

Check_MK Git: check_mk: Added manpages for sansymphony checks

by Bastian Kuhn

Module: check_mk Branch: master Commit: 3e8cc2dc822b4b041aa934d8978328748cc1435c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3e8cc2dc822b4b… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Thu Feb 26 16:27:38 2015 +0100 Added manpages for sansymphony checks --- agents/windows/plugins/sansymphony.ps1 | 24 ++++++++++++++++++++++++ checkman/sansymphony_alerts | 13 +++++++++++++ checkman/sansymphony_pool | 19 +++++++++++++++++++ checkman/sansymphony_ports | 14 ++++++++++++++ checkman/sansymphony_serverstatus | 15 +++++++++++++++ checkman/sansymphony_virtualdiskstatus | 14 ++++++++++++++ modules/catalog.py | 1 + 7 files changed, 100 insertions(+) diff --git a/agents/windows/plugins/sansymphony.ps1 b/agents/windows/plugins/sansymphony.ps1 index e697b50..388d314 100644 --- a/agents/windows/plugins/sansymphony.ps1 +++ b/agents/windows/plugins/sansymphony.ps1 @@ -1,6 +1,30 @@ # check_datacore.ps1 # Version 0.2 # Author : Andre Eckstein, Andre.Eckstein(a)Bechtle.com +# Prerequisites +# ------------- +# 1. Datacore SANsymphony V8 or V9 must be installed +# SANmelody and Sansymphony are not supported. +# +# 2. The SANsymphony CMDlets need to be installed on the monitored Datacore Server +# If not installed you need to install the CMDlets with the SANsymphony V installation routine. +# - Enabling of .net 4 Framwork support in PowerShell +# Support for .net 4 must be enabled. To achieve this, create a file with the name powershell.exe.config with the following content: +# +# <?xml version="1.0" encoding="utf-8" ?> +# <configuration> +# <startup useLegacyV2RuntimeActivationPolicy="true"> +# <supportedRuntime version="v4.0"/> +# <supportedRuntime version="v2.0.50727" /> +# </startup> +# </configuration> +# +# And just put that file into the following directories: +# c:\windows\system32\WindowsPowerShell\v1.0\ and c:\windows\sysWOW64\WindowsPowerShell\v1.0\ +# +# 3. A working Check_MK agent on the monitored host +# Be sure that the Check_MK agent is working without the sansymphony.ps1 plugin. You can verify this by calling telnet <servername or ip> 6556. +# There should be a lot text output showing the different sections. #configuration: diff --git a/checkman/sansymphony_alerts b/checkman/sansymphony_alerts new file mode 100644 index 0000000..ea2a8e3 --- /dev/null +++ b/checkman/sansymphony_alerts @@ -0,0 +1,13 @@ +title: Sansymphony: Alerts +agents: windows +catalog: app/sansymphony +license: GPL +distribution: check_mk +description: + This check measures the current amount of unacknowlegded alerts reported by the sansymphony management. + Levels for {WARN} and {CRIT} can be specified for the number of alerts. + + The windows agent needs to be extended with the sansymphony.ps1 provided in agents/windows/plugins. + +inventory: + One service will be created diff --git a/checkman/sansymphony_pool b/checkman/sansymphony_pool new file mode 100644 index 0000000..fc664cf --- /dev/null +++ b/checkman/sansymphony_pool @@ -0,0 +1,19 @@ +title: Sansymphony: Pool +catalog: app/sansymphony +agents: windows +distribution: check_mk +license: GPL +description: + + This check measures if the dynamic pool is running, if the cache is in ReadWrite mode and the filling rate of the reported pool allocation. + If the dynamic pool not running, {CRIT} will be reported. + If the cache is not in ReadWrite mode, also {CRIT} will be reported. + Also it is possible to set levels to the measured filling rate of the disk pool allocation. + + The windows agent needs to be extended with the sansymphony.ps1 provided in agents/windows/plugins. + +Performance data: + The check outputs the disk pool allocation in percent. + +Inventory: + One service will be created diff --git a/checkman/sansymphony_ports b/checkman/sansymphony_ports new file mode 100644 index 0000000..fca81f0 --- /dev/null +++ b/checkman/sansymphony_ports @@ -0,0 +1,14 @@ +title: Sansymphony: Ports +agents: windows +catalog: app/sansymphony +distribution: check_mk +license: GPL +description: + This check measures the port status of the reported port states by the sansymphony management. + If the port state is up, {OK} will be reported. + If the port state is down, {CRIT} will be reported. + + The windows agent needs to be extended with the sansymphony.ps1 provided in agents/windows/plugins. + +Inventory: + One service will be created diff --git a/checkman/sansymphony_serverstatus b/checkman/sansymphony_serverstatus new file mode 100644 index 0000000..810e126 --- /dev/null +++ b/checkman/sansymphony_serverstatus @@ -0,0 +1,15 @@ +title: Sansymphony: Serverstatus +agents: windows +catalog: app/sansymphony +distribution: check_mk +license: GPL +description: + + This check measures the status of the server and cache state reported by the sansymphony management. + If the serverstatus is Online, {OK} will be reported. Offline will lead to a {CRIT} state. + If the cache not is in WritebackGlobal mode, {CRIT} will be reported. + + The windows agent needs to be extended with the sansymphony.ps1 provided in agents/windows/plugins. + +Inventory: + One service will be created diff --git a/checkman/sansymphony_virtualdiskstatus b/checkman/sansymphony_virtualdiskstatus new file mode 100644 index 0000000..d6718cd --- /dev/null +++ b/checkman/sansymphony_virtualdiskstatus @@ -0,0 +1,14 @@ +title: Sansymphony: Virtualdiskstatus +agents: windows +catalog: app/sansymphony +distribution: check_mk +license: GPL +description: + + This check measures the state of the virtualdiskstatus reported by the sansymphony management. + If the virtualdiskstatus is Online, {OK} will be reported. Otherwise the check reports a {CRIT} state. + + The windows agent needs to be extended with the sansymphony.ps1 provided in agents/windows/plugins. + +Inventory: + One service will be created diff --git a/modules/catalog.py b/modules/catalog.py index 8db56f1..c9e52e9 100644 --- a/modules/catalog.py +++ b/modules/catalog.py @@ -106,6 +106,7 @@ manpage_catalog_titles = { "sap" : "SAP R/3", "tsm" : "IBM Tivoli Storage Manager (TSM)", "unitrends" : "Unitrends", + "sansymphony" : "Datacore SANsymphony", "os" : "Operating Systems", "aix" : "AIX",

9 years, 4 months

Check_MK Git: check_mk: Updated bug entries #2289

by Lars Michelsen

Module: check_mk Branch: master Commit: a5345dd3f235e88cadaf02962a4ee67253da7fe4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a5345dd3f235e8… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Feb 26 14:48:45 2015 +0100 Updated bug entries #2289 --- .bugs/2289 | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.bugs/2289 b/.bugs/2289 new file mode 100644 index 0000000..7045da7 --- /dev/null +++ b/.bugs/2289 @@ -0,0 +1,10 @@ +Title: "Host is not managed by WATO" link to other WATO in non distributed WATO setup +Component: multisite +State: open +Date: 2015-02-26 14:48:24 +Targetversion: future +Class: feature + +In distributed multisite setups, but non distributed WATO setups it would +be nice to have a link to the remote WATO instead of a simple exception +that the host is not managed by the local WATO.

9 years, 4 months

Check_MK Git: check_mk: cisco_sensor_*, brocade.*: deal with leading spaces with new SNMP logic

by Lars Michelsen

Module: check_mk Branch: master Commit: 92692d25112b0a47391225f7f83ecf8781fe5eb7 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=92692d25112b0a… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Feb 26 15:54:32 2015 +0100 cisco_sensor_*, brocade.*: deal with leading spaces with new SNMP logic --- checks/brocade | 1 + checks/cisco_sensor_item.include | 2 ++ 2 files changed, 3 insertions(+) diff --git a/checks/brocade b/checks/brocade index 2cba239..3ed0683 100644 --- a/checks/brocade +++ b/checks/brocade @@ -38,6 +38,7 @@ def brocade_sensor_convert(info, what): return_list = [] for presence, state, name in info: + name = name.lstrip() # remove leading spaces provided via SNMP if name.startswith(what) and presence != "6" and (saveint(state) > 0 or what == "Power"): sensor_id = name.split('#')[-1] return_list.append([sensor_id, name, state]) diff --git a/checks/cisco_sensor_item.include b/checks/cisco_sensor_item.include index dbe9c34..3d45140 100644 --- a/checks/cisco_sensor_item.include +++ b/checks/cisco_sensor_item.include @@ -25,6 +25,8 @@ # Boston, MA 02110-1301 USA. def cisco_sensor_item(trial_string, fall_back): + trial_string = trial_string.lstrip() # remove leading spaces which might be provided via SNMP + # trial_string can be: # Empty # A single string

9 years, 4 months

Check_MK Git: check_mk: #2022 FIX SNMP: Fixed handling of backslashes in SNMP data

by Lars Michelsen

Module: check_mk Branch: master Commit: efd56aa0dc2b4126edadc1e472ad9fcdf94c2594 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=efd56aa0dc2b41… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Feb 26 15:50:20 2015 +0100 #2022 FIX SNMP: Fixed handling of backslashes in SNMP data Some checks like the hr_fs checks e.g. create services with backslashes in the service descriptions when monitoring windows filesystems. Those services were named "Filesystem c:\\..." for example, which was using a double backslash which is wrong. This behaviour has now been changed to just use a single slash. With this change your services will be reported as UNKNOWN when you have such services with double backslashes in their names. You will then need to rediscover the services to get them with just a single slash. If you like to keep the performance graph history, you will need to migrate them on your own. --- .werks/2022 | 19 +++++++++++++++++++ ChangeLog | 2 ++ modules/snmp.py | 6 +++++- 3 files changed, 26 insertions(+), 1 deletion(-) diff --git a/.werks/2022 b/.werks/2022 new file mode 100644 index 0000000..ca275be --- /dev/null +++ b/.werks/2022 @@ -0,0 +1,19 @@ +Title: SNMP: Fixed handling of backslashes in SNMP data +Level: 2 +Component: checks +Compatible: incomp +Version: 1.2.7i1 +Date: 1424962027 +Class: fix + +Some checks like the hr_fs checks e.g. create services with +backslashes in the service descriptions when monitoring +windows filesystems. Those services were named "Filesystem c:\\..." +for example, which was using a double backslash which is wrong. +This behaviour has now been changed to just use a single slash. + +With this change your services will be reported as UNKNOWN when +you have such services with double backslashes in their names. +You will then need to rediscover the services to get them with +just a single slash. If you like to keep the performance graph +history, you will need to migrate them on your own. diff --git a/ChangeLog b/ChangeLog index 6f9d88e..cee1858 100644 --- a/ChangeLog +++ b/ChangeLog @@ -200,6 +200,8 @@ * 2048 FIX: netapp_api_fan, netapp_api_psu, netapp_api_temp: fixed typo in service description Shelfes -> Shelves NOTE: Please refer to the migration notes! * 2021 FIX: if_lancom: Also used for checking ELSA/T-Systems branded devices + * 2022 FIX: SNMP: Fixed handling of backslashes in SNMP data... + NOTE: Please refer to the migration notes! Multisite: * 1758 Improved exception hander: Shows details without additional debug request, added mailto link for error report... diff --git a/modules/snmp.py b/modules/snmp.py index 4225dc4..cbd955f 100644 --- a/modules/snmp.py +++ b/modules/snmp.py @@ -41,7 +41,11 @@ def strip_snmp_value(value, hex_plain = False): if len(v) > 2 and is_hex_string(v): return not hex_plain and convert_from_hex(v) or value else: - return v.strip() + # Fix for non hex encoded string which have been somehow encoded by the + # netsnmp command line tools. An example: + # Checking windows systems via SNMP with hr_fs: disk names like c:\ + # are reported as c:\\, fix this to single \ + return v.strip().replace('\\\\', '\\') else: return v

9 years, 4 months

Check_MK Git: check_mk: Updated bug entries #0846

by Bastian Kuhn

Module: check_mk Branch: master Commit: 3c48e5ad41cd2c31fb4efcac54f31c8874f8ba24 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3c48e5ad41cd2c… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Thu Feb 26 15:07:41 2015 +0100 Updated bug entries #0846 --- .bugs/846 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.bugs/846 b/.bugs/846 index 74fbb86..5f18112 100644 --- a/.bugs/846 +++ b/.bugs/846 @@ -1,6 +1,6 @@ Title: Manual Checks -> ntp (peers) Component: wato -State: open +State: done Date: 2015-02-26 14:27:53 Targetversion: 1.2.6 Class: bug

9 years, 4 months

Check_MK Git: check_mk: #1223 FIX Fixed manual configuration of ntp peer check

by Bastian Kuhn

Module: check_mk Branch: master Commit: 999f238ba8b8382f89a951678b8f7d58d0a55362 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=999f238ba8b838… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Thu Feb 26 15:06:56 2015 +0100 #1223 FIX Fixed manual configuration of ntp peer check The ntp peer check can now be configured using wato. Just use the rule "State of NTP peer" instead "State of NTP time synchronisation". --- .werks/1223 | 11 +++++++++++ ChangeLog | 1 + checks/ntp | 2 +- web/plugins/wato/check_parameters.py | 24 ++++++++++++++++++------ 4 files changed, 31 insertions(+), 7 deletions(-) diff --git a/.werks/1223 b/.werks/1223 new file mode 100644 index 0000000..68267b9 --- /dev/null +++ b/.werks/1223 @@ -0,0 +1,11 @@ +Title: Fixed manual configuration of ntp peer check +Level: 1 +Component: wato +Class: fix +Compatible: compat +State: unknown +Version: 1.2.7i1 +Date: 1424959497 + +The ntp peer check can now be configured using wato. Just use the rule "State of NTP peer" instead "State of NTP time synchronisation". + diff --git a/ChangeLog b/ChangeLog index 3bc4700..6850611 100644 --- a/ChangeLog +++ b/ChangeLog @@ -281,6 +281,7 @@ * 2003 FIX: Fix saving of "Users are allowed to directly login into the Web GUI of this site"... * 2010 FIX: Improved error message when trying to add group assignment rule without having a group configured * 1946 FIX: WATO Web-API: edit host action does no longer unset all unspecified attributes... + * 1223 FIX: Fixed manual configuration of ntp peer check... Notifications: * 1662 notification plugin spectrum: finalized script. now able to handle host notications diff --git a/checks/ntp b/checks/ntp index e1634f8..1e98f95 100644 --- a/checks/ntp +++ b/checks/ntp @@ -159,7 +159,7 @@ check_info["ntp"] = { 'inventory_function': inventory_ntp, 'service_description': 'NTP Peer %s', 'has_perfdata': True, - 'group': 'ntp_time', + 'group': 'ntp_peer', } check_info["ntp.time"] = { diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py index f3e5f49..8314bfa 100644 --- a/web/plugins/wato/check_parameters.py +++ b/web/plugins/wato/check_parameters.py @@ -6041,11 +6041,7 @@ register_check_parameters( help = _("The identifier of the thermal sensor.")), "dict" ) - -register_check_parameters( - subgroup_os, - "ntp_time", - _("State of NTP time synchronisation"), +ntp_params = \ Tuple( elements = [ Integer( @@ -6066,11 +6062,27 @@ register_check_parameters( help = _("The offset in ms at which a critical state is triggered."), ), ] - ), + ) + +register_check_parameters( + subgroup_os, + "ntp_time", + _("State of NTP time synchronisation"), + ntp_params, None, "first" ) +register_check_parameters( + subgroup_os, + "ntp_peer", + _("State of NTP peer"), + ntp_params, + TextAscii( + title = _("Name of the peer")), + "first" +) + def apc_convert_from_tuple(params): if type(params) in (list, tuple): params = { "levels": params}

9 years, 4 months

Check_MK Git: check_mk: Added new service description Filesystem to example BI rules

by Mathias Kettner

Module: check_mk Branch: master Commit: 38e7a571ca2c6a625834758ff9db9368381dafc4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=38e7a571ca2c6a… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Feb 26 14:42:42 2015 +0100 Added new service description Filesystem to example BI rules --- web/htdocs/bi.py | 6 +++--- web/plugins/wato/bi.py | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/web/htdocs/bi.py b/web/htdocs/bi.py index a0f4fc8..27ac5b6 100644 --- a/web/htdocs/bi.py +++ b/web/htdocs/bi.py @@ -718,13 +718,13 @@ def compile_aggregation_rule(aggr_type, rule, args, lvl): ) if len(rule) != 4: - raise MKConfigError(_("<h3>Invalid aggregation rule</h1>" + raise MKConfigError(_("<b>Invalid aggregation rule</b><br><br>" "Aggregation rules must contain four elements: description, argument list, " "aggregation function and list of nodes. Your rule has %d elements: " "<pre>%s</pre>") % (len(rule), pprint.pformat(rule))) if lvl == 50: - raise MKConfigError(_("<h3>Depth limit reached</h3>" + raise MKConfigError(_("<b>Depth limit reached</b><br><br>" "The nesting level of aggregations is limited to 50. You either configured " "too many levels or built an infinite recursion. This happened in rule <pre>%s</pre>") % pprint.pformat(rule)) @@ -733,7 +733,7 @@ def compile_aggregation_rule(aggr_type, rule, args, lvl): # check arguments and convert into dictionary if len(arglist) != len(args): - raise MKConfigError(_("<h1>Invalid rule usage</h1>" + raise MKConfigError(_("<b>Invalid rule usage</b><br><br>" "The rule '%s' needs %d arguments: <tt>%s</tt><br>" "You've specified %d arguments: <tt>%s</tt>") % ( description, len(arglist), repr(arglist), len(args), repr(args))) diff --git a/web/plugins/wato/bi.py b/web/plugins/wato/bi.py index 7d1e423..b2781e3 100644 --- a/web/plugins/wato/bi.py +++ b/web/plugins/wato/bi.py @@ -138,6 +138,7 @@ aggregation_rules["filesystems"] = ( ( "$HOST$", "Disk|MD" ), ( "multipathing", [ "$HOST$" ]), ( FOREACH_SERVICE, "$HOST$", "fs_(.*)", "filesystem", [ "$HOST$", "$1$" ] ), + ( FOREACH_SERVICE, "$HOST$", "Filesystem(.*)", "filesystem", [ "$HOST$", "$1$" ] ), ] ) @@ -147,6 +148,7 @@ aggregation_rules["filesystem"] = ( "worst", [ ( "$HOST$", "fs_$FS$$" ), + ( "$HOST$", "Filesystem$FS$$" ), ( "$HOST$", "Mount options of $FS$$" ), ] )

9 years, 4 months

Check_MK Git: check_mk: Updated bug entries #0846

by Bastian Kuhn

Module: check_mk Branch: master Commit: 23a84e9af06325083e4fdb6b99c89d5eb605bb72 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=23a84e9af06325… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Thu Feb 26 14:29:50 2015 +0100 Updated bug entries #0846 --- .bugs/846 | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.bugs/846 b/.bugs/846 new file mode 100644 index 0000000..74fbb86 --- /dev/null +++ b/.bugs/846 @@ -0,0 +1,8 @@ +Title: Manual Checks -> ntp (peers) +Component: wato +State: open +Date: 2015-02-26 14:27:53 +Targetversion: 1.2.6 +Class: bug + +It is possible to configure the Checktype ntp (NTP peers) manualy in Wato, but then the item is missing. ntp.time etc dond need a item, what leads to his issue.

9 years, 4 months

Check_MK Git: check_mk: apc_symmetra: Added warn/crit levels to perfdata

by Konstantin Büttner

Module: check_mk Branch: master Commit: 4f043227f07de9e8a310dea6ad97c6fcd7e3eda0 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=4f043227f07de9… Author: Konstantin Büttner <kb(a)mathias-kettner.de> Date: Thu Feb 26 14:15:04 2015 +0100 apc_symmetra: Added warn/crit levels to perfdata --- checks/apc_symmetra | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/checks/apc_symmetra b/checks/apc_symmetra index 78d3986..f30a576 100644 --- a/checks/apc_symmetra +++ b/checks/apc_symmetra @@ -199,6 +199,7 @@ def check_apc(item, params, info): battime_state = 0 hrs = int(RunTimeRemaining) / 3600 mins, secs = divmod(int(RunTimeRemaining) % 3600, 60) + battime_warn, battime_crit = None, None label = "" if params.get('battime'): battime_warn, battime_crit = params['battime'] @@ -210,7 +211,7 @@ def check_apc(item, params, info): label = "(!)" single_states.append( (battime_state, "run time remaining: %02d:%02d:%02d%s" % (hrs, mins, secs, label), - ("runtime", RunTimeRemaining/60)) ) + ("runtime", RunTimeRemaining/60, battime_warn, battime_crit)) ) # 10. Adv Output load (load in percent) load_state = 0

9 years, 4 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits February 2015