Checkmk git commits October 2015

checkmk-commits@lists.checkmk.com

9 participants
299 discussions

Check_MK Git: check_mk: #2619 FIX services_summary: Fixed exception on WATO services summary page

by Lars Michelsen

Module: check_mk Branch: master Commit: ad672c5aa4cc257de84ca3d8be267c78a7970544 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ad672c5aa4cc25… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Oct 5 12:03:06 2015 +0200 #2619 FIX services_summary: Fixed exception on WATO services summary page --- .werks/2619 | 9 +++++++++ ChangeLog | 1 + checks/services | 2 +- 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/.werks/2619 b/.werks/2619 new file mode 100644 index 0000000..4cad4a1 --- /dev/null +++ b/.werks/2619 @@ -0,0 +1,9 @@ +Title: services_summary: Fixed exception on WATO services summary page +Level: 1 +Component: checks +Compatible: compat +Version: 1.2.7i3 +Date: 1444039289 +Class: fix + + diff --git a/ChangeLog b/ChangeLog index f8c2f56..96e42be 100644 --- a/ChangeLog +++ b/ChangeLog @@ -205,6 +205,7 @@ * 2627 FIX: knuerr_sensors: no longer creates a service for unnamed sensor... * 2631 FIX: janitza_umg_freq: fixed crash when no frequency measurements were reported by the device * 2653 FIX: winperf_msx_queues: fixed incorrect cancelation of check claiming no counters were available... + * 2619 FIX: services_summary: Fixed exception on WATO services summary page Multisite: * 2385 SEC: Fixed possible reflected XSS on all GUI pages where users can produce unhandled exceptions... diff --git a/checks/services b/checks/services index 7b028d2..6eee378 100644 --- a/checks/services +++ b/checks/services @@ -240,7 +240,7 @@ check_info['services'] = { } factory_settings["services_summary_default_levels"] = { - "ignored": (), + "ignored": [], "state_if_stopped": 0 }

8 years, 11 months

Check_MK Git: check_mk: #2648 FIX Fix crash of core in case of case of certain garbled log lines

by Mathias Kettner

Module: check_mk Branch: master Commit: 79861d5e53542f489f5b55f69ea48e40760dba0b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=79861d5e53542f… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Oct 5 11:49:27 2015 +0200 #2648 FIX Fix crash of core in case of case of certain garbled log lines A query to the table <tt>log</tt> could crash the core when certain garbled lines in the history file are being seen. This has been fixed. --- .werks/2648 | 11 +++++++++++ ChangeLog | 1 + livestatus/src/LogEntry.cc | 6 ++++++ 3 files changed, 18 insertions(+) diff --git a/.werks/2648 b/.werks/2648 new file mode 100644 index 0000000..b08da49 --- /dev/null +++ b/.werks/2648 @@ -0,0 +1,11 @@ +Title: Fix crash of core in case of case of certain garbled log lines +Level: 1 +Component: livestatus +Class: fix +Compatible: compat +State: unknown +Version: 1.2.7i3 +Date: 1444038366 + +A query to the table <tt>log</tt> could crash the core when certain garbled lines +in the history file are being seen. This has been fixed. diff --git a/ChangeLog b/ChangeLog index 0c5702e..f1f3b48 100644 --- a/ChangeLog +++ b/ChangeLog @@ -333,6 +333,7 @@ * 2493 FIX: Fixed wrong JSON format when using stats queries together with header columns... * 2542 FIX: Fix segmentation fault when filtering for service columns in log table... * 2581 FIX: Fix crashing Nagios core in rare case when excessive commands are being executed... + * 2648 FIX: Fix crash of core in case of case of certain garbled log lines... HW/SW-Inventory: * 2128 mk_inventory.vbs: inventory plugin for Windows now available as vbs script... diff --git a/livestatus/src/LogEntry.cc b/livestatus/src/LogEntry.cc index 5634b8e..015decf 100644 --- a/livestatus/src/LogEntry.cc +++ b/livestatus/src/LogEntry.cc @@ -405,6 +405,9 @@ inline bool LogEntry::handleProgrammEntry() inline int LogEntry::serviceStateToInt(char *s) { + if (!s) + return 3; // can happen at garbled log line + char *last = s + strlen(s) - 1; if (*last == ')') last--; @@ -423,6 +426,9 @@ inline int LogEntry::serviceStateToInt(char *s) inline int LogEntry::hostStateToInt(char *s) { + if (!s) + return 2; // can happen at garbled log line + char *last = s + strlen(s) - 1; if (*last == ')') // handle CUSTOM (UP) and DOWNTIMESTOPPED (DOWN) last--;

8 years, 11 months

Check_MK Git: check_mk: #2647 FIX Fix crash of CMC in case of duplicate host

by Mathias Kettner

Module: check_mk Branch: master Commit: a11781a83e4175632684c972f3381e118a80d31d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a11781a83e4175… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Oct 5 11:40:20 2015 +0200 #2647 FIX Fix crash of CMC in case of duplicate host In certain situtations when you have a non-valid configuration (e.g. a duplicate host) than the Check_MK Micro Core would not be able to start correctly due to a problem in the handling of errors in the RRD creation helper. This has been fixed. --- .werks/1723 | 2 +- .werks/2647 | 12 ++++++++++++ ChangeLog | 1 + modules/check_mk.py | 2 +- 4 files changed, 15 insertions(+), 2 deletions(-) diff --git a/.werks/1723 b/.werks/1723 index d5e4dcc..048e175 100644 --- a/.werks/1723 +++ b/.werks/1723 @@ -1,4 +1,4 @@ -Title: New check API function get_average() as more intelligent replacement for get_counter() +Title: New check API function get_rate() as more intelligent replacement for get_counter() Level: 2 Component: core Compatible: compat diff --git a/.werks/2647 b/.werks/2647 new file mode 100644 index 0000000..83f72d5 --- /dev/null +++ b/.werks/2647 @@ -0,0 +1,12 @@ +Title: Fix crash of CMC in case of duplicate host +Level: 1 +Component: core +Compatible: compat +Version: 1.2.7i3 +Date: 1444037957 +Class: fix + +In certain situtations when you have a non-valid configuration (e.g. a duplicate +host) than the Check_MK Micro Core would not be able to start correctly due to +a problem in the handling of errors in the RRD creation helper. This has been +fixed. diff --git a/ChangeLog b/ChangeLog index c7ff3fc..0c5702e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -10,6 +10,7 @@ * 2430 FIX: Fixed crash with availability queries when using nagios as core... * 2643 FIX: Fix spurious CRIT status on check on mknotifyd... * 2617 FIX: Improved error handling in case of agent error but piggyback data available + * 2647 FIX: Fix crash of CMC in case of duplicate host... Checks & Agents: * 2312 New checks for EMC VPLEX: emc_vplex_cpu, emc_vplex_director_stats, emc_vplex_if, emc_vplex_volumes... diff --git a/modules/check_mk.py b/modules/check_mk.py index 1118770..7bef583 100755 --- a/modules/check_mk.py +++ b/modules/check_mk.py @@ -6036,7 +6036,7 @@ try: read_config_files(with_conf_d=True, validate_hosts=False) sys.exit(do_notify(args)) elif o == '--create-rrd': - read_config_files(with_conf_d=True) + read_config_files(with_conf_d=True, validate_hosts=False) execfile(modules_dir + "/rrd.py") do_create_rrd(args) done = True

8 years, 11 months

Check_MK Git: check_mk: #2636 ucd_mem, ucd_processes, ucd_disk: new checks for systems using UCD SNMP Daemon

by Simon Betz

Module: check_mk Branch: master Commit: ec0b76411d03d314b4bee0948ee26b0043317bc7 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ec0b76411d03d3… Author: Simon Betz <si(a)mathias-kettner.de> Date: Mon Oct 5 11:01:51 2015 +0200 #2636 ucd_mem, ucd_processes, ucd_disk: new checks for systems using UCD SNMP Daemon These checks monitor the total and used memory, the number of processes and the available und used space of mounted disks via SNMP on systems running the UCD SNMP daemon. --- .werks/2634 | 5 ++--- .werks/2636 | 11 +++++++++++ ChangeLog | 3 ++- checkman/artec_load | 15 --------------- checkman/artec_mem | 16 ---------------- checkman/artec_processes | 18 ------------------ checkman/{artec_disk => ucd_disk} | 8 +++++--- checkman/ucd_mem | 18 ++++++++++++++++++ checkman/ucd_processes | 20 ++++++++++++++++++++ checks/ucd_mem | 2 +- 10 files changed, 59 insertions(+), 57 deletions(-) diff --git a/.werks/2634 b/.werks/2634 index e937d40..435e4ba 100644 --- a/.werks/2634 +++ b/.werks/2634 @@ -1,4 +1,4 @@ -Title: artec_disk, artec_documents, artec_load, artec_mem, artec_processes, artec_temp: new checks for ARTEC Mail Archive Appliance +Title: artec_documents, artec_temp: new checks for ARTEC Mail Archive Appliance Level: 1 Component: checks Compatible: compat @@ -6,6 +6,5 @@ Version: 1.2.7i3 Date: 1443085698 Class: feature -These checks monitor the used disk space of the mount points, the number of -documents, the CPU load, the used memory, the number of processes and the +These checks monitor the number of documents and the temperature of the ARTEC Mail Archive Appliance. diff --git a/.werks/2636 b/.werks/2636 new file mode 100644 index 0000000..5915bbc --- /dev/null +++ b/.werks/2636 @@ -0,0 +1,11 @@ +Title: ucd_mem, ucd_processes, ucd_disk: new checks for systems using UCD SNMP Daemon +Level: 1 +Component: checks +Compatible: compat +Version: 1.2.7i3 +Date: 1444035440 +Class: feature + +These checks monitor the total and used memory, the number of processes and +the available und used space of mounted disks via SNMP on systems running +the UCD SNMP daemon. diff --git a/ChangeLog b/ChangeLog index a23c8e9..c7ff3fc 100644 --- a/ChangeLog +++ b/ChangeLog @@ -91,10 +91,11 @@ * 2626 ps check configurable to list state of individual processes in long output... * 2628 check_bi_aggr service now also goes into downtime if the monitored BI aggregation is in downtime... * 2633 cisco_stackpower: new check which monitors the link status of stack ports of Cisco Switches 3750-E Series - * 2634 artec_disk, artec_documents, artec_load, artec_mem, artec_processes, artec_temp: new checks for ARTEC Mail Archive Appliance... + * 2634 artec_documents, artec_temp: new checks for ARTEC Mail Archive Appliance... * 2632 oracle_diva_csm, oracle_diva_csm.actor, oracle_diva_csm.archive, oracle_diva_csm.drive: new checks for DIVA CSM devices * 2635 pandacom_psu, pandacom_fan, pandacom_sys_temp, pandacom_10gm_temp, pandacom_fc_temp: new checks for Pandacom SpeedCarrier Chassis 5u... * 2433 interface checks: now able to configure the infotext shown in the check output... + * 2636 ucd_mem, ucd_processes, ucd_disk: new checks for systems using UCD SNMP Daemon... * 2315 FIX: windows agent: BOM replacement, fixed incorrect byte offset... * 2316 FIX: windows agent: fix garbled output of cached agent plugins... * 2358 FIX: check_mk_agent.solaris: more correct computation of zfs used space... diff --git a/checkman/artec_load b/checkman/artec_load deleted file mode 100644 index c96f8ec..0000000 --- a/checkman/artec_load +++ /dev/null @@ -1,15 +0,0 @@ -title: ARTEC Mail Archive Appliance: CPU load -agents: snmp -catalog: hw/other -license: GPL -distribution: check_mk -description: - This check monitors the CPU load of the ARTEC Mail Archive Appliance. - - Upper default levels are set to 5, 8. These levels are configurable. - -perfdata: - CPU load in percent. - -inventory: - One service is created. diff --git a/checkman/artec_mem b/checkman/artec_mem deleted file mode 100644 index 6076910..0000000 --- a/checkman/artec_mem +++ /dev/null @@ -1,16 +0,0 @@ -title: ARTEC Mail Archive Appliance: Memory -agents: snmp -catalog: hw/other -license: GPL -distribution: check_mk -description: - This check monitors the available and total memory - of the ARTEC Mail Archive Appliance. - - Upper default levels are set to 50, 90 %. These levels are configurable. - -perfdata: - The used memory. - -inventory: - One service is created. diff --git a/checkman/artec_processes b/checkman/artec_processes deleted file mode 100644 index 42f18c2..0000000 --- a/checkman/artec_processes +++ /dev/null @@ -1,18 +0,0 @@ -title: ARTEC Mail Archive Appliance: Processes -agents: snmp -catalog: hw/other -license: GPL -distribution: check_mk -description: - This check monitors the processes of the ARTEC Mail Archive Appliance. - - Upper default levels are set to 80, 90 %. These levels are configurable. - -item: - The index and type of processes. - -perfdata: - The number of processes. - -inventory: - One service per process type is created. diff --git a/checkman/artec_disk b/checkman/ucd_disk similarity index 57% rename from checkman/artec_disk rename to checkman/ucd_disk index a7586eb..70648fd 100644 --- a/checkman/artec_disk +++ b/checkman/ucd_disk @@ -1,11 +1,13 @@ -title: ARTEC Mail Archive Appliance: Disk +title: Disk space of mounted disks on systems using UCD SNMP Daemon agents: snmp -catalog: hw/other +catalog: os/kernel license: GPL distribution: check_mk description: This check monitors the available and used space of the mounted disks - of the ARTEC Mail Archive Appliance. + via SNMP on systems running the UCD SNMP daemon. + This daemon is mostly found on Linux systems and used by some hardware + appliances (such as Riverbed Steelhead). Upper default levels are set to 80, 90 %. These levels are configurable. diff --git a/checkman/ucd_mem b/checkman/ucd_mem new file mode 100644 index 0000000..cfc2b9a --- /dev/null +++ b/checkman/ucd_mem @@ -0,0 +1,18 @@ +title: Total and used Memory on systems using UCD SNMP Daemon +agents: snmp +catalog: os/kernel +license: GPL +distribution: check_mk +description: + This check monitors the available and total memory + via SNMP on systems running the UCD SNMP daemon. + This daemon is mostly found on Linux systems and used by some hardware + appliances (such as Riverbed Steelhead). + + Upper default levels are set to 80, 90 %. These levels are configurable. + +perfdata: + The used memory. + +inventory: + One service is created. diff --git a/checkman/ucd_processes b/checkman/ucd_processes new file mode 100644 index 0000000..acf5785 --- /dev/null +++ b/checkman/ucd_processes @@ -0,0 +1,20 @@ +title: Processes on systems using UCD SNMP Daemon +agents: snmp +catalog: os/kernel +license: GPL +distribution: check_mk +description: + This check monitors the processes via SNMP on systems running the UCD SNMP daemon. + This daemon is mostly found on Linux systems and used by some hardware + appliances (such as Riverbed Steelhead). + + The upper and lower crit levels are sent by the device itself. + +item: + The index and type of processes. + +perfdata: + The number of processes. + +inventory: + One service per process type is created. diff --git a/checks/ucd_mem b/checks/ucd_mem index 4adb609..19d66fc 100644 --- a/checks/ucd_mem +++ b/checks/ucd_mem @@ -30,7 +30,7 @@ # suggested by cutomer factory_settings["ucd_mem_default_levels"] = { - "levels" : ("perc_used", (50.0, 90.0)) + "levels" : ("perc_used", (80.0, 90.0)) }

8 years, 11 months

Check_MK Git: check_mk: change check names of artec_{load/mem/disk/ processes} -> ucd_{load/mem/disk/processes}

by Simon Betz

Module: check_mk Branch: master Commit: 0194d1e6265732a8cd4ac66ab35fd9d55afcfe46 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=0194d1e6265732… Author: Simon Betz <si(a)mathias-kettner.de> Date: Mon Oct 5 10:41:42 2015 +0200 change check names of artec_{load/mem/disk/processes} -> ucd_{load/mem/disk/processes} --- checks/{artec_load => ucd.include} | 42 +++++++++++------------------ checks/ucd_cpu_load | 14 +++------- checks/ucd_cpu_util | 14 ++++------ checks/{artec_disk => ucd_disk} | 14 +++++----- checks/{artec_mem => ucd_mem} | 18 ++++++------- checks/{artec_processes => ucd_processes} | 14 +++++----- 6 files changed, 48 insertions(+), 68 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=0194d1e626…

8 years, 11 months

Check_MK Git: check_mk: added gb regarding excessive agent output

by Sebastian Herbord

Module: check_mk Branch: master Commit: cb209b3d9a2e36ae5ed9267782a8ba2be9d7df35 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=cb209b3d9a2e36… Author: Sebastian Herbord <sh(a)mathias-kettner.de> Date: Mon Oct 5 10:13:50 2015 +0200 added gb regarding excessive agent output --- .bugs/2362 | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.bugs/2362 b/.bugs/2362 new file mode 100644 index 0000000..d5da5b0 --- /dev/null +++ b/.bugs/2362 @@ -0,0 +1,11 @@ +Title: Excessive Agent output can interfere with check_mk +Component: core +State: open +Date: 2015-10-05 09:44:32 +Targetversion: 1.2.7 +Class: nastiness + +Currently check_mk will always try to process all agent output. If the agent produces a lot of output, some checks may cause excessive cpu load and memory usage, effectively making the monitoring system unusable. +To the user this will appear like a bug since the amount of data between agent and monitoring system is not visualised and not warned about so there is no way for the user to find the cause of the slowness. +To remedy this we could add readings and warn/crit levels on the agent output size, agent response time, execution time and memory usage. +In addition we should add support for memory profiling of individual checks so that problematic checks are easier to identify. \ No newline at end of file

8 years, 11 months

Check_MK Git: check_mk: #2433 interface checks: now able to configure the infotext shown in the check output

by Andreas Boesl

Module: check_mk Branch: master Commit: b6b64eecf057bceacbca697f9edfe5b4de8428ae URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b6b64eecf057bc… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Sat Oct 3 15:16:46 2015 +0200 #2433 interface checks: now able to configure the infotext shown in the check output You can now configure with the WATO rule <i>Network interfaces and switch ports</i> the infotext between the [] brackets. The following options are available. <ul> <li>Show alias</li> <li>Show description</li> <li>Show alias and description</li> <li>Show alias if set, else description</li> <li>Show description if set, else alias</li> <li>Hide infotext</li> </ul> --- .werks/2433 | 19 ++++++++++++++ ChangeLog | 1 + checks/if.include | 47 ++++++++++++++++++++++++---------- web/plugins/wato/check_parameters.py | 16 ++++++++++++ 4 files changed, 70 insertions(+), 13 deletions(-) diff --git a/.werks/2433 b/.werks/2433 new file mode 100644 index 0000000..6532a8a --- /dev/null +++ b/.werks/2433 @@ -0,0 +1,19 @@ +Title: interface checks: now able to configure the infotext shown in the check output +Level: 1 +Component: checks +Compatible: compat +Version: 1.2.7i3 +Date: 1443877893 +Class: feature + +You can now configure with the WATO rule <i>Network interfaces and switch ports</i> the +infotext between the [] brackets. The following options are available. + +<ul> +<li>Show alias</li> +<li>Show description</li> +<li>Show alias and description</li> +<li>Show alias if set, else description</li> +<li>Show description if set, else alias</li> +<li>Hide infotext</li> +</ul> diff --git a/ChangeLog b/ChangeLog index 662364b..a23c8e9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -94,6 +94,7 @@ * 2634 artec_disk, artec_documents, artec_load, artec_mem, artec_processes, artec_temp: new checks for ARTEC Mail Archive Appliance... * 2632 oracle_diva_csm, oracle_diva_csm.actor, oracle_diva_csm.archive, oracle_diva_csm.drive: new checks for DIVA CSM devices * 2635 pandacom_psu, pandacom_fan, pandacom_sys_temp, pandacom_10gm_temp, pandacom_fc_temp: new checks for Pandacom SpeedCarrier Chassis 5u... + * 2433 interface checks: now able to configure the infotext shown in the check output... * 2315 FIX: windows agent: BOM replacement, fixed incorrect byte offset... * 2316 FIX: windows agent: fix garbled output of cached agent plugins... * 2358 FIX: check_mk_agent.solaris: more correct computation of zfs used space... diff --git a/checks/if.include b/checks/if.include index ae416f9..87422f2 100644 --- a/checks/if.include +++ b/checks/if.include @@ -576,20 +576,41 @@ def check_if_common_single(item, params, info, force_counter_wrap = False, # The detailed group info is added later on infotext = group_name + " Status " else: - # Display port number or alias in infotext if that is not part - # of the service description anyway - if item.lstrip("0") == ifIndex \ - and (item == ifAlias or ifAlias == '') \ - and (item == ifDescr or ifDescr == ''): # description trivial - infotext = "" - elif item == "%s %s" % (ifAlias, ifIndex) and ifDescr != '': # non-unique Alias - infotext = "[%s/%s]" % (ifAlias, ifDescr) - elif item != ifAlias and ifAlias != '': # alias useful - infotext = "[%s] " % ifAlias - elif item != ifDescr and ifDescr != '': # description useful - infotext = "[%s] " % ifDescr + if "infotext_format" in params: + bracket_info = "" + if params["infotext_format"] == "alias": + bracket_info = ifAlias + elif params["infotext_format"] == "description": + bracket_info = ifDescr + elif params["infotext_format"] == "alias_and_description": + bracket_info = [] + ifAlias and bracket_info.append(ifAlias) + ifDescr and bracket_info.append(ifDescr) + bracket_info = ", ".join(bracket_info) + elif params["infotext_format"] == "alias_or_description": + bracket_info = ifAlias and ifAlias or ifDescr + elif params["infotext_format"] == "desription_or_alias": + bracket_info = ifDescr and ifDescr or ifAlias + + if bracket_info: + infotext = "[%s]" % bracket_info + else: + infotext = "" else: - infotext = "[%s] " % ifIndex + # Display port number or alias in infotext if that is not part + # of the service description anyway + if item.lstrip("0") == ifIndex \ + and (item == ifAlias or ifAlias == '') \ + and (item == ifDescr or ifDescr == ''): # description trivial + infotext = "" + elif item == "%s %s" % (ifAlias, ifIndex) and ifDescr != '': # non-unique Alias + infotext = "[%s/%s]" % (ifAlias, ifDescr) + elif item != ifAlias and ifAlias != '': # alias useful + infotext = "[%s] " % ifAlias + elif item != ifDescr and ifDescr != '': # description useful + infotext = "[%s] " % ifDescr + else: + infotext = "[%s] " % ifIndex if node != None: infotext = "%son %s: " % ( infotext, node ) diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py index 0262b3f..95084a3 100644 --- a/web/plugins/wato/check_parameters.py +++ b/web/plugins/wato/check_parameters.py @@ -3291,6 +3291,22 @@ register_check_parameters( ( "bit", _("Bits") ), ( "byte", _("Bytes") ),], )), + ( "infotext_format", + DropdownChoice( + title = _("Change infotext in check output"), + help = _("This setting allows you to modify the information text which is displayed between " + "the two brackets in the check output. Please note that this setting does not work for " + "grouped interfaces, since the additional information of grouped interfaces is different"), + choices = [ + ("alias", _("Show alias")), + ("description", _("Show description")), + ("alias_and_description", _("Show alias and description")), + ("alias_or_description", _("Show alias if set, else description")), + ("desription_or_alias", _("Show description if set, else alias")), + ("hide", _("Hide infotext")), + ] + ) + ), ( "traffic", ListOf(CascadingDropdown( title = _("Direction"),

8 years, 12 months

Check_MK Git: check_mk: Updated werks

by Mathias Kettner

Module: check_mk Branch: master Commit: c68cf38c6accf722dc1674cb5e76d5e43714d2df URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c68cf38c6accf7… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Oct 2 15:58:17 2015 +0200 Updated werks --- .werks/1507 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.werks/1507 b/.werks/1507 index c165a9a..2fccd1f 100644 --- a/.werks/1507 +++ b/.werks/1507 @@ -1,6 +1,6 @@ Title: New optional parse_function for check API Level: 2 -Component: checks +Component: core Compatible: compat Version: 1.2.6b1 Date: 1415193630

8 years, 12 months

Check_MK Git: check_mk: #2646 New system for displaying time graphs of metrics

by Mathias Kettner

Module: check_mk Branch: master Commit: 1f1cdfbfbbb2adbb52527880d84aec1977abb66d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1f1cdfbfbbb2ad… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Oct 2 15:42:11 2015 +0200 #2646 New system for displaying time graphs of metrics Check_MK now has a new implementation of how metrics time graphs (formerly known as performance graphs or PNP graphs) are being created. Instead of hand crafted PNP templates, templates are now being created by Check_MK's new metrics system. In the new declaration file <tt>share/check_mk/web/plugins/metrics/check_mk.py</tt> all names of performance variables are being assigned to units, titles and colors. Graph and Perf-O-Meter definitions both make use of these. The advantages are: LI:Graphs and Perf-O-Meters are much simpler to declare LI:Graphs and Perf-O-Meters now share the same color scheme LI:Graphs are more streamlined LI:It is now much easier to change some general properties of all graphs LI:Default graphs are more intelligent LI:Future addons that work with metrics data are easier to implement Note: existing PNP templates have not been removed but still exist and have precedence over the automatically generated ones. But they will not be maintained anymore and no new manual templates will be created by us anymore. --- .werks/2646 | 30 ++++++++++++++++++++++++++++++ ChangeLog | 1 + 2 files changed, 31 insertions(+) diff --git a/.werks/2646 b/.werks/2646 new file mode 100644 index 0000000..b989a24 --- /dev/null +++ b/.werks/2646 @@ -0,0 +1,30 @@ +Title: New system for displaying time graphs of metrics +Level: 3 +Component: multisite +Compatible: compat +Version: 1.2.7i3 +Date: 1443792930 +Class: feature + +Check_MK now has a new implementation of how metrics time graphs (formerly +known as performance graphs or PNP graphs) are being created. Instead of +hand crafted PNP templates, templates are now being created by Check_MK's +new metrics system. + +In the new declaration file +<tt>share/check_mk/web/plugins/metrics/check_mk.py</tt> all names of +performance variables are being assigned to units, titles and colors. +Graph and Perf-O-Meter definitions both make use of these. + +The advantages are: + +LI:Graphs and Perf-O-Meters are much simpler to declare +LI:Graphs and Perf-O-Meters now share the same color scheme +LI:Graphs are more streamlined +LI:It is now much easier to change some general properties of all graphs +LI:Default graphs are more intelligent +LI:Future addons that work with metrics data are easier to implement + +Note: existing PNP templates have not been removed but still exist and +have precedence over the automatically generated ones. But they will not be +maintained anymore and no new manual templates will be created by us anymore. diff --git a/ChangeLog b/ChangeLog index f8c2f56..662364b 100644 --- a/ChangeLog +++ b/ChangeLog @@ -227,6 +227,7 @@ * 2601 Access to Werks (change log) directly in the user interface... * 2602 Tracking of incompatible Werks... * 2616 LDAP: Improved handling of multiple connections (Name conflicts, cross directory sync)... + * 2646 New system for displaying time graphs of metrics... * 2314 FIX: Availability: fixed exception when grouping by host or service group * 2361 FIX: Fix exception for missing key 'title' in certain cases of older customized views * 2379 FIX: Plugin-Output: Fixed handling of URLs within output of check_http...

8 years, 12 months

Check_MK Git: check_mk: Minor code cleanup

by Mathias Kettner

Module: check_mk Branch: master Commit: 969a11aedf7ac19dfb12cc3ec0cb07df9bea30b2 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=969a11aedf7ac1… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Oct 2 12:04:53 2015 +0200 Minor code cleanup --- checks/brocade_fcport | 4 ++-- checks/fc_port | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/checks/brocade_fcport b/checks/brocade_fcport index 84e4fba..bd03aa4 100644 --- a/checks/brocade_fcport +++ b/checks/brocade_fcport @@ -40,9 +40,9 @@ brocade_fcport_speed = [ 'unknown', '1Gbit', '2Gbit', 'auto-Neg', '4Gbit', ' isl_speed = { "1": 0, # other (1) - None of the following. "2": 0.155, # oneEighth (2) - 155 Mbaud. - "4": 0.266, #•quarter (4) - 266 Mbaud. + "4": 0.266, # quarter (4) - 266 Mbaud. "8": 0.532, # half (8) - 532 Mbaud. - "16": 1, #•full (16) - 1 Gbaud. + "16": 1, # full (16) - 1 Gbaud. "32": 2, # double (32) - 2 Gbaud. "64": 4, # quadruple (64) - 4 Gbaud. "128": 8, # octuple (128) - 8 Gbaud. diff --git a/checks/fc_port b/checks/fc_port index b2b8650..e416f4b 100644 --- a/checks/fc_port +++ b/checks/fc_port @@ -55,8 +55,8 @@ fc_port_phystates = { 4: ('active', 0), 5: ('loopback', 1), 6: ('txfault', 1), - 7: ('noMedia', 1), - 8: ('linkDown',2), + 7: ('no media', 1), + 8: ('link down',2), } # taken from connUnitPortType

8 years, 12 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits October 2015