Checkmk git commits September 2014

checkmk-commits@lists.checkmk.com

5 participants
195 discussions

Check_MK Git: check_mk: Updated bug entries #2183

by Mathias Kettner

Module: check_mk Branch: master Commit: 28dfb6367744b3f0f1c29d8a8babd7bb85b2a404 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=28dfb6367744b3… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Sep 19 11:02:38 2014 +0200 Updated bug entries #2183 --- .bugs/2183 | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.bugs/2183 b/.bugs/2183 new file mode 100644 index 0000000..80523ac --- /dev/null +++ b/.bugs/2183 @@ -0,0 +1,11 @@ +Title: cmk --check-inventory fails with exit code 4 on invalid configuration +Component: core +State: open +Date: 2014-09-19 11:01:41 +Targetversion: future +Class: bug + +If you have a duplicate host, for example, then the Inventory check fails with +4. This makes Nagios unhappy. + +Solution: Fail with code 3 and a useful error message

9 years, 12 months

Check_MK Git: check_mk: Internal code cleanup in WATO rules

by Mathias Kettner

Module: check_mk Branch: master Commit: 6c0ddcfc23fa32a3748a41d95063f6d8518b1fb1 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=6c0ddcfc23fa32… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Sep 19 10:55:54 2014 +0200 Internal code cleanup in WATO rules --- web/plugins/wato/check_parameters.py | 1 - 1 file changed, 1 deletion(-) diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py index c5b9e40..65058fc 100644 --- a/web/plugins/wato/check_parameters.py +++ b/web/plugins/wato/check_parameters.py @@ -1840,7 +1840,6 @@ register_check_parameters( ], optional_keys = [ "offset" ], ), - back = transform_msx_queues, forth = transform_msx_queues, ), TextAscii(

9 years, 12 months

Check_MK Git: check_mk: vms: fixed incorrect runtime.host name

by Andreas Boesl

Module: check_mk Branch: master Commit: c9a6d6c367af503ac7deb5724ce3c8df69a49aef URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c9a6d6c367af50… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Thu Sep 18 18:47:10 2014 +0200 vms: fixed incorrect runtime.host name --- agents/special/agent_vsphere | 2 ++ 1 file changed, 2 insertions(+) diff --git a/agents/special/agent_vsphere b/agents/special/agent_vsphere index 12b034d..97fd671 100755 --- a/agents/special/agent_vsphere +++ b/agents/special/agent_vsphere @@ -853,6 +853,8 @@ if not error: else: # we don't need this in the agent output del vm_data["config.hardware.device"] + if "runtime.host" in vm_data: + vm_data["runtime.host"] = hostsystems.get(vm_data["runtime.host"], vm_data["runtime.host"]) vms[vm_data.get("name")] = vm_data

9 years, 12 months

Check_MK Git: check_mk: kernel: internal code cleanup

by Mathias Kettner

Module: check_mk Branch: master Commit: 18201772d77a0d16c87720f42484b1c9b1266cd6 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=18201772d77a0d… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Sep 18 12:00:15 2014 +0200 kernel: internal code cleanup --- checks/kernel | 38 +++++++++++++++++++++++++++++++------- 1 file changed, 31 insertions(+), 7 deletions(-) diff --git a/checks/kernel b/checks/kernel index caa301c..cd7cb7e 100644 --- a/checks/kernel +++ b/checks/kernel @@ -24,6 +24,17 @@ # to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, # Boston, MA 02110-1301 USA. +# .--kernel--Counters----------------------------------------------------. +# | ____ _ | +# | / ___|___ _ _ _ __ | |_ ___ _ __ ___ | +# | | | / _ \| | | | '_ \| __/ _ \ '__/ __| | +# | | |__| (_) | |_| | | | | || __/ | \__ \ | +# | \____\___/ \__,_|_| |_|\__\___|_| |___/ | +# | | +# +----------------------------------------------------------------------+ +# | Check page faults, context switches and process creations | +# '----------------------------------------------------------------------' + # Inventory creates three checks per default: inventory_kernel_counters = [ "pgmajfault", "ctxt", "processes" ] kernel_default_levels = None @@ -72,6 +83,26 @@ def check_kernel(item, params, info): infotext += ", " + text return state, infotext, perfdata +check_info["kernel"] = { + 'check_function': check_kernel, + 'inventory_function': inventory_kernel, + 'service_description': 'Kernel %s', + 'has_perfdata': True, + 'group': 'vm_counter', +} + +#. +# .--kernel.util--CPU Utilization----------------------------------------. +# | _ _ _ _ _ _ _ _ | +# | | | | | |_(_) (_)______ _| |_(_) ___ _ __ | +# | | | | | __| | | |_ / _` | __| |/ _ \| '_ \ | +# | | |_| | |_| | | |/ / (_| | |_| | (_) | | | | | +# | \___/ \__|_|_|_/___\__,_|\__|_|\___/|_| |_| | +# | | +# +----------------------------------------------------------------------+ +# | Check system/user/io-wait | +# '----------------------------------------------------------------------' + kernel_util_default_levels = None def inventory_cpu_utilization(info): @@ -156,10 +187,3 @@ check_info["kernel.util"] = { 'group': 'cpu_iowait', } -check_info["kernel"] = { - 'check_function': check_kernel, - 'inventory_function': inventory_kernel, - 'service_description': 'Kernel %s', - 'has_perfdata': True, - 'group': 'vm_counter', -}

9 years, 12 months

Check_MK Git: check_mk: #1403 kernel.util: allow levels for the total CPU utilization

by Mathias Kettner

Module: check_mk Branch: master Commit: ca833488b6c6aca367f7a8fa9d5ba2fb769ba0e1 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ca833488b6c6ac… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Sep 18 14:39:25 2014 +0200 #1403 kernel.util: allow levels for the total CPU utilization The CPU utilization check for Linux only allowed to set levels for the disk wait percentage. The parameters have been converted to a dictionary and now allow to set levels on the total CPU utilization as well. Please note: if you have defined the variable {kernel_util_default_levels} in your {main.mk}, then you need to convert this to a dictionary - otherwise it will be ignored. Instead of F+:main.mk kernel_util_default_levels = (10, 20) F-: ... please now write...: F+:main.mk kernel_util_default_levels = { "iowait" : (10, 20) } F-: Users of WATO are not affected by this and do not need to change anything. --- .werks/1403 | 26 +++++++++++++ ChangeLog | 2 + checkman/kernel.util | 19 +++++---- checks/kernel | 70 ++++++++++++++++++++++------------ web/plugins/wato/check_parameters.py | 53 +++++++++++++++++-------- 5 files changed, 121 insertions(+), 49 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=ca833488b6…

9 years, 12 months

Check_MK Git: check_mk: fixed exception when querying esx host

by Andreas Boesl

Module: check_mk Branch: master Commit: c1a1268f2c0daa8c5a1d1bd59f632b2eba052469 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c1a1268f2c0daa… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Thu Sep 18 11:48:54 2014 +0200 fixed exception when querying esx host --- agents/special/agent_vsphere | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/agents/special/agent_vsphere b/agents/special/agent_vsphere index 45edf35..12b034d 100755 --- a/agents/special/agent_vsphere +++ b/agents/special/agent_vsphere @@ -642,7 +642,7 @@ try: systeminfo[entry] = function and function(element[0]) or element[0] elif name == "login": my_cookie = reply_headers.get("Set-Cookie") - if reply_msg != "OK": + if "InvalidLogin" in reply_data: raise Exception("Login response is not 'OK'. Please check the credentials") except Exception, e: @@ -890,7 +890,8 @@ if not error: print "<<<esx_vsphere_objects:sep(9)>>>" if "hostsystem" in query_objects: if opt_direct and opt_hostname: - print "hostsystem\t%s\t\t%s" % ( opt_hostname, hostsystems_properties[hostname]["runtime.powerState"][0] ) + for hostname, data in hostsystems_properties.items(): + print "hostsystem\t%s\t\t%s" % ( opt_hostname, hostsystems_properties[hostname]["runtime.powerState"][0] ) else: for hostname, data in hostsystems_properties.items(): print "hostsystem\t%s\t\t%s" % ( convert_hostname(hostsystems_properties[hostname]["name"][0]),

9 years, 12 months

Check_MK Git: check_mk: agent_vsphere: fixed invalid piggyback section when using direct mode

by Andreas Boesl

Module: check_mk Branch: master Commit: fad58d937377cdc284023bfdbdd720d06033803f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=fad58d937377cd… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Thu Sep 18 11:26:03 2014 +0200 agent_vsphere: fixed invalid piggyback section when using direct mode --- agents/special/agent_vsphere | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/agents/special/agent_vsphere b/agents/special/agent_vsphere index 8d2410a..45edf35 100755 --- a/agents/special/agent_vsphere +++ b/agents/special/agent_vsphere @@ -807,9 +807,7 @@ if not error: # TODO: improve error handling: check if multiple results and opt_direct for hostname, properties in hostsystems_properties.items(): - if opt_direct and opt_hostname: - print "<<<<%s>>>>" % opt_hostname - else: + if not opt_direct: print "<<<<%s>>>>" % convert_hostname(properties["name"][0]) print "<<<esx_vsphere_hostsystem>>>"

9 years, 12 months

Check_MK Git: check_mk: #1402 FIX Fixed cased where counting events did not reach required count

by Mathias Kettner

Module: check_mk Branch: master Commit: c3702f776df8dc87b8495b864ece66bdbd26f2db URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c3702f776df8dc… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Sep 17 15:17:18 2014 +0200 #1402 FIX Fixed cased where counting events did not reach required count This bug was found and fixed by Andreas Döhler! --- .werks/1402 | 9 +++++++++ ChangeLog | 1 + mkeventd/bin/mkeventd | 2 +- 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/.werks/1402 b/.werks/1402 new file mode 100644 index 0000000..9f7dc27 --- /dev/null +++ b/.werks/1402 @@ -0,0 +1,9 @@ +Title: Fixed cased where counting events did not reach required count +Level: 2 +Component: ec +Compatible: compat +Version: 1.2.5i6 +Date: 1410959775 +Class: fix + +This bug was found and fixed by Andreas Döhler! diff --git a/ChangeLog b/ChangeLog index c73328e..49e2596 100644 --- a/ChangeLog +++ b/ChangeLog @@ -133,6 +133,7 @@ * 1395 Event Console can now create notifications via Check_MK RBN... * 1007 FIX: check_mkevents: fix case where events contain binary zeroes * 1399 FIX: Fix left-over tac processes when showing Event Console history... + * 1402 FIX: Fixed cased where counting events did not reach required count... HW/SW-Inventory: * 0643 windows inventory: OS now contains the install date, reg_uninstall now contains the path... diff --git a/mkeventd/bin/mkeventd b/mkeventd/bin/mkeventd index ee18dc5..9a59be8 100755 --- a/mkeventd/bin/mkeventd +++ b/mkeventd/bin/mkeventd @@ -1206,7 +1206,7 @@ class EventServer: if event["first"] + count["period"] <= now: # End of period reached log("Rule %s: reached only %d out of %d events within %d seconds. " "Resetting to zero." % (rule["id"], event["count"], count["count"], count["period"])) - event["phase"] = closed + event["phase"] = "closed" log_event_history(event, "COUNTFAILED") events_to_delete.append(nr)

9 years, 12 months

Check_MK Git: check_mk: Reserved 10 Werk IDS

by Mathias Kettner

Module: check_mk Branch: master Commit: 2c249f93a2cfd540c7b6e8c261f4856afc8fc18d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2c249f93a2cfd5… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Sep 17 15:15:59 2014 +0200 Reserved 10 Werk IDS --- .werks/first_free | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.werks/first_free b/.werks/first_free index accf44d..5b23536 100644 --- a/.werks/first_free +++ b/.werks/first_free @@ -1 +1 @@ -1402 +1412

9 years, 12 months

Check_MK Git: check_mk: fixed werk display

by Andreas Boesl

Module: check_mk Branch: master Commit: a208610496861ac83c7279260a0c71fe05029a2d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a208610496861a… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Wed Sep 17 11:54:34 2014 +0200 fixed werk display --- .werks/973 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.werks/973 b/.werks/973 index 7d8eaed..7e06f22 100644 --- a/.werks/973 +++ b/.werks/973 @@ -13,7 +13,7 @@ Renaming a host is a complex precedure that will not only rename the host in WAT but also in: <ul> -<li>all rules from <i>Host & Service Parameters</i></li> +<li>all rules from Host & Service Parameters</li> <li>cluster's node definitions</li> <li>a host's parent definitions</li> <li>Business Intelligence rules</li>

9 years, 12 months

← Newer
1
...
4
5
6
7
8
9
10
...
20
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits September 2014