Checkmk git commits July 2014

checkmk-commits@lists.checkmk.com

7 participants
221 discussions

Check_MK Git: check_mk: #1068 livedump: Added optional check interval ( detect staleness) / option to encrypt mails

by Lars Michelsen

Module: check_mk Branch: master Commit: d738e9f339af59b6939e92f0305eef4886c523b3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d738e9f339af59… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jul 30 09:53:48 2014 +0200 #1068 livedump: Added optional check interval (detect staleness) / option to encrypt mails Added a new option "-i" to livedump to make the check_interval of the hosts / services configurable. When this is set the staleness detection on the destination system works. Added option to use AES encrypted messages with livedump-mail-fetch. Added a short documentation to the livedump README for details. --- .werks/1068 | 12 +++++++ ChangeLog | 1 + doc/treasures/livedump/README | 29 +++++++++++++++++ doc/treasures/livedump/livedump | 24 +++++++++++--- doc/treasures/livedump/livedump-mail-fetch | 48 ++++++++++++++++++++++++---- 5 files changed, 103 insertions(+), 11 deletions(-) diff --git a/.werks/1068 b/.werks/1068 new file mode 100644 index 0000000..8487e94 --- /dev/null +++ b/.werks/1068 @@ -0,0 +1,12 @@ +Title: livedump: Added optional check interval (detect staleness) / option to encrypt mails +Level: 1 +Component: checks +Version: 1.2.5i6 +Date: 1406706675 +Class: feature + +Added a new option "-i" to livedump to make the check_interval of the hosts / services +configurable. When this is set the staleness detection on the destination system works. + +Added option to use AES encrypted messages with livedump-mail-fetch. Added a short +documentation to the livedump README for details. diff --git a/ChangeLog b/ChangeLog index 9316b4d..45698d8 100644 --- a/ChangeLog +++ b/ChangeLog @@ -2,6 +2,7 @@ Checks & Agents: * 0185 knuerr_rms_humidity, knuerr_rms_temp: Two new Checks to Monitor the Temperature and the Humidity on Knürr RMS Devices * 1065 heartbeat_crm / heartbeat_crm.resources: Rewrote checks / formalized parameters... + * 1068 livedump: Added optional check interval (detect staleness) / option to encrypt mails... * 1051 FIX: tcp_conn_stats: fix missing performance data... * 1142 FIX: winperf_ts_sessions: fix computation, check has never really worked diff --git a/doc/treasures/livedump/README b/doc/treasures/livedump/README index 3f478ab..eac5c43 100644 --- a/doc/treasures/livedump/README +++ b/doc/treasures/livedump/README @@ -67,3 +67,32 @@ Make sure that all columns are prefixed with host_ in these. If you are using this is in conjunction with NSCA transport and do not wish to transfer the templated configuration, you can use the filter to only export services that have "obsess_over_service = 1" set. + +Encrypted Transport (E-Mail) +---------------------------- +When you use mail to transport the output of livedump. For example with this +command: + +livedump | mail -s "status" lm(a)mathias-kettner.de + +You can extend this mechanism to make the contents (not the whole message) +be encrypted. This can be reached by different ways, we use an AES encryption +with a preshared key here. + +First you need openssl on the sending site. Then you need a file which first line +contains the preshared key which will be used to encrypt the data. Then you need +to first send the livedump data to openssl to let it encrypt it and forward it to +the mail command afterwards. + +livedump | openssl aes-256-cbc -a -kfile /path/to/my/preshared-key-file | mail -s "status" lm(a)mathias-kettner.de + +Please ensure that the permissions to the preshared key file are as limited as +possible. Everyone who has access to an email and the key can decrypt it. + +This command should turn the mail contents in a block of cryptic characters when +you take a look at the generated mail in your mail client. + +Now you need to configure the receiving side. We use the script "livedump-mail-fetch" +here. To make it able to handle the encrypted message, you need to set the variable +encrypt to hold your preshared key as string. All incoming mails will then be decrypted +beforce being processed. diff --git a/doc/treasures/livedump/livedump b/doc/treasures/livedump/livedump index 8feb977..443b9a6 100755 --- a/doc/treasures/livedump/livedump +++ b/doc/treasures/livedump/livedump @@ -30,6 +30,10 @@ import os, sys, getopt, livestatus, tempfile, time check_mk_version = '(inofficial)' def dump_templates(): + check_interval = "" + if opt_check_interval != None: + check_interval = "check_interval %d" % opt_check_interval + sys.stdout.write(""" define host { name livedump-host @@ -37,7 +41,7 @@ define host { register 0 active_checks_enabled 0 passive_checks_enabled 1 - + %s } define service { @@ -46,6 +50,7 @@ define service { active_checks_enabled 0 passive_checks_enabled 1 check_period 0x0 + %s } define command { @@ -57,7 +62,7 @@ define timeperiod { timeperiod_name 0x0 alias Never ever } -""") +""" % (check_interval, check_interval)) def encode_row(row): for key, val in row.items(): @@ -257,6 +262,12 @@ def usage(): This header is also used in service queries. -S, --service-header H add header H to service queries (usually Filter: ...) + -i, --interval assume this check interval for hosts/services. This is + used in nagios config definition "check_interval". + Will be used for staleness checks on the server. This + option is only used when dumping the config together + with templates (-C -T). + -v, --verbose output debug information an stderr --debug do not catch Python exceptions @@ -277,11 +288,11 @@ def print_version(): # | Main entry point, getopt, etc. | # '----------------------------------------------------------------------' -short_options = 'hVvc:H:S:O:TCMG' -long_options = [ "help", "version", "verbose", "debug", "socket=", +short_options = 'hVvc:H:S:O:TCMGi:s:' +long_options = [ "help", "version", "verbose", "debug", "socket=", "host-header=", "host-only-header=", "service-header=", "dump-templates", "config", "state", "mark-mode", - "include-groups" ] + "include-groups", "interval" ] opt_verbose = False opt_debug = False @@ -292,6 +303,7 @@ opt_host_only_headers = "" opt_service_headers = "" opt_dump_templates = False opt_groups = False +opt_check_interval = None try: opts, args = getopt.getopt(sys.argv[1:], short_options, long_options) @@ -328,6 +340,8 @@ for o,a in opts: opt_mark_mode = True elif o in [ '-G', '--include-groups' ]: opt_groups = True + elif o in [ '-i', '--interval' ]: + opt_check_interval = int(a) # Main modes try: diff --git a/doc/treasures/livedump/livedump-mail-fetch b/doc/treasures/livedump/livedump-mail-fetch index d3b8f7f..e88b89f 100755 --- a/doc/treasures/livedump/livedump-mail-fetch +++ b/doc/treasures/livedump/livedump-mail-fetch @@ -27,6 +27,15 @@ pop_pass = "secretpassword" # By default the mail body is treated to be encoded as "quoted-printable". # In the other case no decoding is not performed. encoding = "quoted-printable" +# By default the mails are not decrypted. If you configure a string here +# it is assumed to be the preshared key to decrypt the AES encrypted mails. +encrypt = None + +if encrypt: + from base64 import b64decode + from Crypto import Random + from Crypto.Hash import MD5 + from Crypto.Cipher import AES M = poplib.POP3_SSL(pop_server) M.user(pop_user) @@ -39,6 +48,27 @@ numMessages = len(M.list()[1]) status_mails = [] config_mails = [] +# This decrypts mail bodies generated with openssl. e.g. with this command: +# openssl aes-256-cbc -a -kfile /path/to/my/preshared-key-file +def decrypt(body): + encrypted = b64decode(body) + salt = encrypted[8:16] + data = encrypted[16:] + + # Need 32 bytes for the key and 16 bytes for the IV + def openssl_kdf(req): + prev = '' + while req>0: + prev = MD5.new(prev+encrypt+salt).digest() + req -= 16 + yield prev + mat = ''.join([ x for x in openssl_kdf(32+16) ]) + key = mat[0:32] + iv = mat[32:48] + + dec = AES.new(key, AES.MODE_CBC, iv) + return dec.decrypt(data) + pattern = re.compile(r"^Subject: (.*)") for i in range(numMessages): for header_lines in M.top(i + 1, 0)[1]: @@ -59,10 +89,13 @@ if config_mails: mail_index, ident = config_mails[-1] code, mail, num = M.retr(mail_index) body_start_index = mail.index('') + body = '\n'.join(mail[body_start_index:]) + + if encrypt: + body = decrypt(body) + if encoding == 'quoted-printable': - body = quopri.decodestring('\n'.join(mail[body_start_index:])) - else: - body = '\n'.join(mail[body_start_index:]) + body = quopri.decodestring(body) file("%s/etc/nagios/conf.d/remote-%s.cfg" % (omd_root, ident), "w").write(body) @@ -71,10 +104,13 @@ if status_mails: for index in status_mails: code, mail, code = M.retr(index) body_start_index = mail.index('') + body = '\n'.join(mail[body_start_index:]) + + if encrypt: + body = decrypt(body) + if encoding == 'quoted-printable': - body = quopri.decodestring('\n'.join(mail[body_start_index:])) - else: - body = '\n'.join(mail[body_start_index:]) + body = quopri.decodestring(body) fd, path = tempfile.mkstemp('', 'c', "%s/tmp/nagios/checkresults" % omd_root) os.write(fd, body)

10 years, 1 month

Check_MK Git: check_mk: #1091 FIX logwatch patterns: allow unicode text in pattern comment

by Andreas Boesl

Module: check_mk Branch: master Commit: bd640263af67ea055e75126abbb39af35c9e7cb3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=bd640263af67ea… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Tue Jul 29 17:33:12 2014 +0200 #1091 FIX logwatch patterns: allow unicode text in pattern comment --- .werks/1091 | 9 +++++++++ ChangeLog | 1 + web/plugins/wato/check_parameters.py | 2 +- 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/.werks/1091 b/.werks/1091 new file mode 100644 index 0000000..675925e --- /dev/null +++ b/.werks/1091 @@ -0,0 +1,9 @@ +Title: logwatch patterns: allow unicode text in pattern comment +Level: 1 +Component: wato +Class: fix +State: unknown +Version: 1.2.5i6 +Date: 1406647953 + + diff --git a/ChangeLog b/ChangeLog index 6cf5446..c64bf6f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -14,6 +14,7 @@ WATO: * 1064 FIX: Fixed rare issue with WATO communication in distributed setups (different OS versions)... * 1089 FIX: Snapshot restore: fixed exception during exception handling...... + * 1091 FIX: logwatch patterns: allow unicode text in pattern comment 1.2.5i5: diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py index 101e891..d7b684f 100644 --- a/web/plugins/wato/check_parameters.py +++ b/web/plugins/wato/check_parameters.py @@ -76,7 +76,7 @@ register_rule(group + '/' + subgroup_applications, title = _("Pattern (Regex)"), size = 40, ), - TextAscii( + TextUnicode( title = _("Comment"), size = 40, ),

10 years, 1 month

Check_MK Git: check_mk: #0186 touchstone_cable_modem_fec: New Check to monitor the Forward error correction on touchstone cable modems

by Bastian Kuhn

Module: check_mk Branch: master Commit: b04df555675a934e037e32e9ef7be2d9ae797153 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b04df555675a93… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Tue Jul 29 16:25:44 2014 +0200 #0186 touchstone_cable_modem_fec: New Check to monitor the Forward error correction on touchstone cable modems --- .werks/186 | 8 +++++ ChangeLog | 1 + checkman/touchstone_cable_modem_fec | 15 +++++++++ checks/touchstone_cable_modem_fec | 57 ++++++++++++++++++++++++++++++++++ web/plugins/wato/check_parameters.py | 33 ++++++++++++++++++++ 5 files changed, 114 insertions(+) diff --git a/.werks/186 b/.werks/186 new file mode 100644 index 0000000..e9785af --- /dev/null +++ b/.werks/186 @@ -0,0 +1,8 @@ +Title: touchstone_cable_modem_fec: New Check to monitor the Forward error correction on touchstone cable modems +Level: 1 +Component: checks +Version: 1.2.5i6 +Date: 1406643907 +Class: feature + + diff --git a/ChangeLog b/ChangeLog index b9e0046..6cf5446 100644 --- a/ChangeLog +++ b/ChangeLog @@ -2,6 +2,7 @@ Checks & Agents: * 0185 knuerr_rms_humidity, knuerr_rms_temp: Two new Checks to Monitor the Temperature and the Humidity on Knürr RMS Devices * 1065 heartbeat_crm / heartbeat_crm.resources: Rewrote checks / formalized parameters... + * 0186 touchstone_cable_modem_fec: New Check to monitor the Forward error correction on touchstone cable modems * 1051 FIX: tcp_conn_stats: fix missing performance data... * 1142 FIX: winperf_ts_sessions: fix computation, check has never really worked * 1090 FIX: zfsget: fixed exception which happened on incomplete zfs entries diff --git a/checkman/touchstone_cable_modem_fec b/checkman/touchstone_cable_modem_fec new file mode 100644 index 0000000..4a62c65 --- /dev/null +++ b/checkman/touchstone_cable_modem_fec @@ -0,0 +1,15 @@ +title: Touchstone Cable Modem: Forward error correction +agents: snmp +catalog: hw/network/arris +license: GPL +distribution: +description: + This check monitors the Forward Error correction rate on Touchestone Cable Modems. + It is possible to set levels for good, uncorrected and corrected packages. + +item: + None + +inventory: + One service will be created + diff --git a/checks/touchstone_cable_modem_fec b/checks/touchstone_cable_modem_fec new file mode 100644 index 0000000..daca175 --- /dev/null +++ b/checks/touchstone_cable_modem_fec @@ -0,0 +1,57 @@ +#!/usr/bin/python +# -*- encoding: utf-8; py-indent-offset: 4 -*- +# +------------------------------------------------------------------+ +# | ____ _ _ __ __ _ __ | +# | / ___| |__ ___ ___| | __ | \/ | |/ / | +# | | | | '_ \ / _ \/ __| |/ / | |\/| | ' / | +# | | |___| | | | __/ (__| < | | | | . \ | +# | \____|_| |_|\___|\___|_|\_\___|_| |_|_|\_\ | +# | | +# | Copyright Mathias Kettner 2013 mk(a)mathias-kettner.de | +# +------------------------------------------------------------------+ +# +# This file is part of Check_MK. +# The official homepage is at http://mathias-kettner.de/check_mk. +# +# check_mk is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License as published by +# the Free Software Foundation in version 2. check_mk is distributed +# in the hope that it will be useful, but WITHOUT ANY WARRANTY; with- +# out even the implied warranty of MERCHANTABILITY or FITNESS FOR A +# PARTICULAR PURPOSE. See the GNU General Public License for more de- +# ails. You should have received a copy of the GNU General Public +# License along with GNU Make; see the file COPYING. If not, write +# to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, +# Boston, MA 02110-1301 USA. + +factory_settings["touchstone_cable_modem_fec_default_levels"] = { + "good" : ( 250000000000, 260000000000 ), + "corrected" : ( 250000000000, 260000000000 ), + "uncorrected" : ( 250000000000, 260000000000 ), +} + +def inventory_touchstone_cable_modem_fec(info): + return [ (None, {}) ] + +def check_touchstone_cable_modem_fec(_no_item, params, info): + fec = {} + fec['good'], fec['corrected'], fec['uncorrected'] = map(int, info[0]) + for what in ['good', 'corrected', 'uncorrected']: + warn, crit = params[what] + state = 0 + if fec[what] >= crit: + state = 2 + elif fec[what] >= warn: + state = 1 + yield state, "FEC %s at %s" % ( what, fec[what] ), [ ( what, fec[what], warn, crit ) ] + +check_info["touchstone_cable_modem_fec"] = { + "check_function" : check_touchstone_cable_modem_fec, + "inventory_function" : inventory_touchstone_cable_modem_fec, + "service_description" : "FEC", + "snmp_scan_function" : lambda oid: oid(".1.3.6.1.2.1.1.2.0") == ".1.3.6.1.4.1.4115.820.1.0.0.0.0.0", + "snmp_info" : ( ".1.3.6.1.2.1.10.127.1.1.4.1", [ 2, 3, 4 ]), + "default_levels_variable" : "touchstone_cable_modem_fec_default_levels", + "group" : "fec", +} + diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py index 2dc57fc..101e891 100644 --- a/web/plugins/wato/check_parameters.py +++ b/web/plugins/wato/check_parameters.py @@ -1317,6 +1317,39 @@ register_check_parameters( register_check_parameters( subgroup_networking, + 'fec', + _("Forward error correction"), + Dictionary( + elements = [ + ( 'good', Tuple( + title = _("Levels for good Packages"), + elements = [ + Integer( title = _("Warning at"), default_value="250000000000"), + Integer( title = _("Critical at"), default_value="260000000000"), + ] + )), + ( 'corrected', Tuple( + title = _("Levels for corrected Packages"), + elements = [ + Integer( title = _("Warning at"), default_value="250000000000"), + Integer( title = _("Critical at"), default_value="260000000000"), + ] + )), + ( 'uncorrected', Tuple( + title = _("Levels for uncorrected Packages"), + elements = [ + Integer( title = _("Warning at"), default_value="250000000000"), + Integer( title = _("Critical at"), default_value="260000000000"), + ] + )), + ] + ), + None, + "dict" +) + +register_check_parameters( + subgroup_networking, "vpn_tunnel", _("VPN Tunnel"), Dictionary(

10 years, 1 month

Check_MK Git: check_mk: fixed syntax error

by Andreas Boesl

Module: check_mk Branch: master Commit: fc83a01bbcd52b4e0aa6cf10b8316860553a986b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=fc83a01bbcd52b… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Tue Jul 29 16:11:29 2014 +0200 fixed syntax error --- checks/zfsget | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/checks/zfsget b/checks/zfsget index a03564b..ca34418 100644 --- a/checks/zfsget +++ b/checks/zfsget @@ -99,7 +99,7 @@ def parse_zfsget(info): if zfs_agent_data: new_entry = parse_zfs_entry(zfs_agent_data) if new_entry: - zfs_converted.append() + zfs_converted.append(new_entry) zfs_agent_data = [] zfs_agent_data.append(line[:3])

10 years, 1 month

Check_MK Git: check_mk: #1090 FIX zfsget: fixed exception which happened on incomplete zfs entries

by Andreas Boesl

Module: check_mk Branch: master Commit: d502ea1a1f9058cc604c1814947c39f8dcdbf8a8 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d502ea1a1f9058… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Tue Jul 29 15:38:57 2014 +0200 #1090 FIX zfsget: fixed exception which happened on incomplete zfs entries --- .werks/1090 | 9 +++++++++ ChangeLog | 1 + checks/zfsget | 10 ++++++---- 3 files changed, 16 insertions(+), 4 deletions(-) diff --git a/.werks/1090 b/.werks/1090 new file mode 100644 index 0000000..1204ab5 --- /dev/null +++ b/.werks/1090 @@ -0,0 +1,9 @@ +Title: zfsget: fixed exception which happened on incomplete zfs entries +Level: 1 +Component: checks +Class: fix +State: unknown +Version: 1.2.5i6 +Date: 1406641044 + + diff --git a/ChangeLog b/ChangeLog index 9316b4d..b9e0046 100644 --- a/ChangeLog +++ b/ChangeLog @@ -4,6 +4,7 @@ * 1065 heartbeat_crm / heartbeat_crm.resources: Rewrote checks / formalized parameters... * 1051 FIX: tcp_conn_stats: fix missing performance data... * 1142 FIX: winperf_ts_sessions: fix computation, check has never really worked + * 1090 FIX: zfsget: fixed exception which happened on incomplete zfs entries Multisite: * 1066 Implemented Dashboard Designer... diff --git a/checks/zfsget b/checks/zfsget index f4b0ec5..a03564b 100644 --- a/checks/zfsget +++ b/checks/zfsget @@ -59,7 +59,7 @@ # tsrdb10exp 5128704 21 4982717 1% /tsrdb10exp # tsrdb10dat 30707712 19914358 10789464 65% /u01 -def parse_zfs_entrie(info): +def parse_zfs_entry(info): def mb(x): return saveint(x) / (1024.0 * 1024) entry = {} @@ -71,8 +71,8 @@ def parse_zfs_entrie(info): entry[what] = mb(value) elif what in [ 'mountpoint', 'type', 'name' ]: entry[what] = value - if entry: - return entry + + return entry def parse_zfsget(info): run_zfs = True @@ -97,7 +97,9 @@ def parse_zfsget(info): if last_name != name: last_name = name if zfs_agent_data: - zfs_converted.append(parse_zfs_entrie(zfs_agent_data)) + new_entry = parse_zfs_entry(zfs_agent_data) + if new_entry: + zfs_converted.append() zfs_agent_data = [] zfs_agent_data.append(line[:3])

10 years, 1 month

Check_MK Git: check_mk: #1067 FIX Fixed login problem in LDAP connector when no user filter specified

by Lars Michelsen

Module: check_mk Branch: master Commit: 967caa6012f6194a317b0ca4c4095ac4b2cb957a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=967caa6012f619… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 29 15:21:44 2014 +0200 #1067 FIX Fixed login problem in LDAP connector when no user filter specified The 1.2.5i5 released introduced a bug which prevents user logins when the LDAP configured does not has a LDAP user filter set. If you encounter this problem either update to this release or set a user filter to prevent the exception. --- .werks/1067 | 12 ++++++++++++ ChangeLog | 1 + web/plugins/userdb/ldap.py | 2 +- 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/.werks/1067 b/.werks/1067 new file mode 100644 index 0000000..0eb0eaf --- /dev/null +++ b/.werks/1067 @@ -0,0 +1,12 @@ +Title: Fixed login problem in LDAP connector when no user filter specified +Level: 2 +Component: multisite +Class: fix +State: unknown +Version: 1.2.5i6 +Date: 1406640020 + +The 1.2.5i5 released introduced a bug which prevents user logins when the +LDAP configured does not has a LDAP user filter set. If you encounter this +problem either update to this release or set a user filter to prevent the +exception. diff --git a/ChangeLog b/ChangeLog index 3e7cdc6..9316b4d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -7,6 +7,7 @@ Multisite: * 1066 Implemented Dashboard Designer... + * 1067 FIX: Fixed login problem in LDAP connector when no user filter specified... WATO: * 1064 FIX: Fixed rare issue with WATO communication in distributed setups (different OS versions)... diff --git a/web/plugins/userdb/ldap.py b/web/plugins/userdb/ldap.py index 3cf8883..e4ec3e7 100644 --- a/web/plugins/userdb/ldap.py +++ b/web/plugins/userdb/ldap.py @@ -475,7 +475,7 @@ def ldap_get_user(username, no_escape = False): result = ldap_search( ldap_replace_macros(config.ldap_userspec['dn']), '(&(%s=%s)%s)' % (ldap_user_id_attr(), ldap.filter.escape_filter_chars(username), - config.ldap_userspec['filter']), + config.ldap_userspec.get('filter', '')), [ldap_user_id_attr()], )

10 years, 1 month

Check_MK Git: check_mk: #1066 Implemented Dashboard Designer

by Lars Michelsen

Module: check_mk Branch: master Commit: e605b7f8fc92cd99d5e314ccd9d7d62115bab9e6 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e605b7f8fc92cd… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 29 13:04:42 2014 +0200 #1066 Implemented Dashboard Designer This change implements the long awaited Dashboard Designer. With this feature users can edit existing dashboards, create new ones and provide their dashboards to other users just like it can be done with the views. Another nice feature is the formalized context we introduced for views and dashboards. With this concept it is possible to create a host specific dashboard once and open it for several different hosts. You can create a "Oracle Database dashboard" once which can show you the state of a single database server. The name of the database server (context: hostname) of your choice can be provided when accessing the dashboard to "instanciate" such a dashboard. Dashboards edited by users are saved in <tt>var/check_mk/web/USER/user_dashboards.mk</tt> just like edited views are now saved in <tt>var/check_mk/web/USER/user_views.mk</tt>. The views saved by a user before this release which are stored in <tt>var/check_mk/web/USER/views.mk</tt> will be migrated automatically once the user edits it's first view. From this time the new edited views will be read/written from/to the new file. For details take a look at the <a href="/checkmk_multisite_dashboards.html">dashboard documentation</a>. --- .werks/1066 | 25 +++++++++++++++++++++++++ ChangeLog | 3 +++ 2 files changed, 28 insertions(+) diff --git a/.werks/1066 b/.werks/1066 new file mode 100644 index 0000000..0682ef7 --- /dev/null +++ b/.werks/1066 @@ -0,0 +1,25 @@ +Title: Implemented Dashboard Designer +Level: 3 +Component: multisite +Version: 1.2.5i6 +Date: 1406631300 +Class: feature + +This change implements the long awaited Dashboard Designer. With this feature users +can edit existing dashboards, create new ones and provide their dashboards to other +users just like it can be done with the views. + +Another nice feature is the formalized context we introduced for views and dashboards. +With this concept it is possible to create a host specific dashboard once and open +it for several different hosts. You can create a "Oracle Database dashboard" once +which can show you the state of a single database server. The name of the database +server (context: hostname) of your choice can be provided when accessing the dashboard +to "instanciate" such a dashboard. + +Dashboards edited by users are saved in <tt>var/check_mk/web/USER/user_dashboards.mk</tt> +just like edited views are now saved in <tt>var/check_mk/web/USER/user_views.mk</tt>. The +views saved by a user before this release which are stored in <tt>var/check_mk/web/USER/views.mk</tt> +will be migrated automatically once the user edits it's first view. From this time the +new edited views will be read/written from/to the new file. + +For details take a look at the <a href="/checkmk_multisite_dashboards.html">dashboard documentation</a>. diff --git a/ChangeLog b/ChangeLog index bd20700..3e7cdc6 100644 --- a/ChangeLog +++ b/ChangeLog @@ -5,6 +5,9 @@ * 1051 FIX: tcp_conn_stats: fix missing performance data... * 1142 FIX: winperf_ts_sessions: fix computation, check has never really worked + Multisite: + * 1066 Implemented Dashboard Designer... + WATO: * 1064 FIX: Fixed rare issue with WATO communication in distributed setups (different OS versions)... * 1089 FIX: Snapshot restore: fixed exception during exception handling......

10 years, 1 month

Check_MK Git: New commits on branch master

by git version control

URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=52b4435a6e4d9d… Merge: 511274b 0f51040 Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 29 12:51:45 2014 +0200 Merge branch 'dashedit' Conflicts: agents/windows/Makefile URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=0f5104064b8f88… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jul 28 13:38:04 2014 +0200 Editing views of new format in users_views.mk file in user profile URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d808f23b996f5c… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jul 28 11:52:49 2014 +0200 Fixed different issues with the dashboard editor ; minor improvments URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1cf50b12b6dcdb… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jul 28 11:30:25 2014 +0200 Split visual table into "builtin" and "custom" ones URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f721ed2f96f20e… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jul 28 09:43:42 2014 +0200 Fixed dashboard layout of network topology URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2c6d5629cca0c6… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Jul 24 14:30:37 2014 +0200 dashboard editor: minor cleanups / usability improvements URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d3465a775f5afa… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Jul 24 13:28:08 2014 +0200 The views snapin shows dashboards and views again URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=6c75305a7520de… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Jul 24 10:21:07 2014 +0200 simplified dynamic dashboard position / sizing URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=4f13942365c9a2… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Jul 24 10:12:34 2014 +0200 Various smaller improvements / fixes for editing dashboards URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=78cd5272f45167… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Jul 24 09:48:34 2014 +0200 Changed builtin dashboards to new format URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=324c2cc39949c6… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Jul 24 09:14:43 2014 +0200 Fixed default settings of checkbox filters URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=01ae43887f79e8… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Jul 24 08:58:17 2014 +0200 Fixed dashboard global context in view dashlets URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=9c3ed7620b0cab… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jul 23 19:37:18 2014 +0200 Errors in dashlet handler function should not prevent whole dashboard rendering URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=9d3b342be56988… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jul 23 19:27:06 2014 +0200 Fixed editing of views (also dashlet views) with hard coded context URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=50a626e31702a9… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jul 23 16:48:08 2014 +0200 Improved graph scaling again URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3ea72de8c6064b… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jul 23 14:57:51 2014 +0200 Dashlets added directly from views have now a title by default URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e79b9aef0ecc42… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jul 23 14:49:05 2014 +0200 Fixed scaling of pnp graphs in several cases URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a196177c199fe7… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jul 23 09:16:21 2014 +0200 Added choice to add existing views to dashboard from dashboard edit menu URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f1dd7b5f0815bd… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jul 23 08:14:59 2014 +0200 Hiding dashboard controls wheel on bottom of screen when not hovered URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=698cf3ed663c51… Merge: df8953d 53f1e69 Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 22 16:25:02 2014 +0200 Merge branch 'dashedit' of mathias-kettner.de:check_mk into dashedit URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=df8953d0eec19c… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 22 16:24:55 2014 +0200 Fixed opening dashboard edit menu in view mode URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7a755797d69309… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 22 16:12:45 2014 +0200 Dashboard edit menu is now accessible from page context menu URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8635b43feaf61f… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 22 14:23:05 2014 +0200 Dashboard editor: Different minor improvements / fixes URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c2fea034643e53… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 22 13:55:28 2014 +0200 Dashboard snapin does not display topic when only one topic is used URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=53f1e69d307f10… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Jul 22 10:03:54 2014 +0200 Fixed exception with legacy views of single context type URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c25cd50ec1559e… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Jul 17 14:03:59 2014 +0200 Improved sizer label styling URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=cdd643b9afecac… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jul 16 15:43:30 2014 +0200 Fixed syntax URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f565d56614ff22… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jul 16 15:41:46 2014 +0200 build process: fixed build of branch agent URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=185ecd88f94ac6… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jul 16 12:05:06 2014 +0200 Removed old comments / code URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=78b65326363f79… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jul 16 12:02:05 2014 +0200 It is now possible to add existing views to dashboards (see footer icons) URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e7625c6cdb643f… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 15 15:11:36 2014 +0200 PNP graphs can now be added to dashboard right from the host/service detail pages URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1dd5f8ac0a26c4… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 15 11:54:39 2014 +0200 Cleaned up styling of static text dashlet URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=631205e5896ec8… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 15 11:44:13 2014 +0200 Implemented deletion of dashlets URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7b98bd3b19e24b… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 15 08:32:03 2014 +0200 Dashboard graphs do now scale with the size of the dashlet URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=4fcf982795f414… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jul 14 15:12:24 2014 +0200 Fixed globe rendering after reload URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2ed5f6c9f9d09c… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jul 14 15:10:46 2014 +0200 Fixed globe rendering after reload URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c5dd6851283ad8… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jul 14 15:04:07 2014 +0200 Fixed dashboard modification check for builtin dashboards URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3115d1e9ba1dc9… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jul 14 14:44:19 2014 +0200 Cleaned up variable naming in visual module code URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=531ea0998515c2… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jul 14 14:31:35 2014 +0200 Dashboard: Fixed setting html title when page title is now shown URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=4d6c71d1c0989e… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jul 14 14:28:36 2014 +0200 Open dashboard recognize editing and reload themselfs URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f75ca867f45b15… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jul 14 11:33:59 2014 +0200 dashboard editor: some IE<9 fixes URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=abdaf9a6f8bac8… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jul 14 09:17:19 2014 +0200 Fixed mobile GUI rendering URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3b78721085e774… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jul 14 09:04:19 2014 +0200 Minor cleanups URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=eca8d3ed46ad71… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jul 14 08:55:44 2014 +0200 Migrated builtin dashboards to new format URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=50e0d0c8ea58a1… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jul 11 16:48:46 2014 +0200 PNP dashlets use the context mechanism now URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=cf205ed81cfde4… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jul 11 14:57:41 2014 +0200 View dashlets can now be added to dashboards URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f35e400d37c25b… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jul 11 12:13:12 2014 +0200 Made single object context input fields optional; Fixed single service on multi host view URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=25c8fb6e43b99b… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jul 11 12:00:36 2014 +0200 Recoded view rendering to work with the context type of views URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1c1f326a1ae595… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Jul 10 20:19:16 2014 +0200 Multisite: plugin loading does not catch all AttributeError exceptions anymore URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a2e5e52a0ac199… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Jul 10 10:29:50 2014 +0200 Loading / transforming of old to new views URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=6a31b2aed08de8… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jul 9 16:25:24 2014 +0200 More progress in view editor refactoring URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d429d060588c33… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 8 16:10:53 2014 +0200 Additional steps in view editor rewriting URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=974b034022c1c7… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 8 10:03:55 2014 +0200 View / visual editor refactoring in progress URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3d46773841a6e6… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jul 7 09:39:33 2014 +0200 Added minimum dashlet size during resizing URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f4ce58f3d19dea… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jul 4 15:16:31 2014 +0200 Started with implementing context types for visuals URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=fec9884349ff01… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jul 4 11:56:32 2014 +0200 Fixed view editor after visual editor implementation URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=be9f0bcf2e75c0… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jul 2 17:35:08 2014 +0200 hide dashlet content overflow URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=49a9c3f371115e… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jul 2 11:25:06 2014 +0200 Added dashlet edit button; Sorted dashlet types in add menu URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=aaf322186973f3… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jul 2 10:11:14 2014 +0200 Added absolute sized dashlets resize code URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=23a4ca1c567b4a… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 1 13:58:06 2014 +0200 Added missing file URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7ddc988a128108… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 1 13:37:40 2014 +0200 Dashlet changes can now be persisted; Started with dashlet add/edit dialog URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a0cce473652350… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jun 30 08:38:13 2014 +0200 Added controls (anchors, sizer) to dashlets URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5b48635aad6c9a… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Jun 26 16:38:25 2014 +0200 Simplyfied dashlet layout URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a7d9ac195d6572… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Jun 26 15:12:11 2014 +0200 Started implementing the dashboard editor URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=6a2f294631044f… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jun 25 12:03:04 2014 +0200 Replaced individual localized view texts to user custom localization mechanism; Generalized view editor to visuals editor; Dashboard global parameters can now be edited URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d211a77224ec38… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jun 24 15:59:35 2014 +0200 Prozess dashboard resize less often during window resize URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e61381ae74089c… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jun 24 15:43:17 2014 +0200 Started refactoring the dashboard code

10 years, 1 month

Check_MK Git: check_mk: #1065 heartbeat_crm / heartbeat_crm.resources: Rewrote checks / formalized parameters

by Lars Michelsen

Module: check_mk Branch: master Commit: b6ec6428f3d7954815abdce01737305ed20ec844 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b6ec6428f3d795… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jul 29 11:36:44 2014 +0200 #1065 heartbeat_crm / heartbeat_crm.resources: Rewrote checks / formalized parameters Both checks heartbeat_crm and heartbeat_crm.resources nailed down the resources / DC to the node which held the resources / DC during inventory. This was not fitting most users requirements and has been changed. By default the node currently holding the resources / DC does not matter anymore as long as they are held by at least one node. If you like to change this behaviour back to the old default, you need to configure the inventory rule <tt>Heartbeat CRM Inventory</tt> and re-run an inventory on the affected hosts. Already inventorized checks should continue working as they did before. The change only affects newly inventorized services. Two new WATO rules <tt>Heartbeat CRM general status</tt> and <tt>Heartbeat CRM resource status</tt> have been added to make the parameters of these checks configurable. --- .werks/1065 | 21 ++++++ ChangeLog | 1 + checkman/heartbeat_crm | 26 +++---- checkman/heartbeat_crm.resources | 12 +-- checks/heartbeat_crm | 137 ++++++++++++++++++++-------------- web/plugins/wato/check_parameters.py | 83 ++++++++++++++++++++ 6 files changed, 201 insertions(+), 79 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=b6ec6428f3…

10 years, 1 month

Check_MK Git: check_mk: #1089 FIX Snapshot restore: fixed exception during exception handling...

by Andreas Boesl

Module: check_mk Branch: master Commit: c008c57bc2e1477c6ec36097501c38bbd787ed62 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c008c57bc2e147… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Tue Jul 29 11:34:51 2014 +0200 #1089 FIX Snapshot restore: fixed exception during exception handling... If there were an error during the extracting of a backup domain, the backup process crashed entirely instead of continueing with the next backup domain. --- .werks/1089 | 9 +++++++++ ChangeLog | 1 + web/htdocs/multitar.py | 4 ++-- 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/.werks/1089 b/.werks/1089 new file mode 100644 index 0000000..8f6dff6 --- /dev/null +++ b/.werks/1089 @@ -0,0 +1,9 @@ +Title: Snapshot restore: fixed exception during exception handling... +Level: 1 +Component: wato +Version: 1.2.5i6 +Date: 1406626339 +Class: fix + +If there were an error during the extracting of a backup domain, the backup process +crashed entirely instead of continueing with the next backup domain. diff --git a/ChangeLog b/ChangeLog index 3b88b9f..fa3b013 100644 --- a/ChangeLog +++ b/ChangeLog @@ -6,6 +6,7 @@ WATO: * 1064 FIX: Fixed rare issue with WATO communication in distributed setups (different OS versions)... + * 1089 FIX: Snapshot restore: fixed exception during exception handling...... 1.2.5i5: diff --git a/web/htdocs/multitar.py b/web/htdocs/multitar.py index d9ddd53..b461070 100644 --- a/web/htdocs/multitar.py +++ b/web/htdocs/multitar.py @@ -213,9 +213,9 @@ def extract_domains(tar, domains): stdout, stderr = p.communicate() exit_code = p.wait() if exit_code: - return [ "%s - %s" % (domains["title"], stderr) ] + return [ "%s - %s" % (domain["title"], stderr) ] except Exception, e: - return [ "%s - %s" % (domains["title"], str(e)) ] + return [ "%s - %s" % (domain["title"], str(e)) ] def execute_restore(domain, is_pre_restore = True):

10 years, 1 month

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits July 2014