Checkmk git commits May 2014

checkmk-commits@lists.checkmk.com

5 participants
134 discussions

Check_MK Git: check_mk: FIX Fix availability computation for hosts

by Mathias Kettner

Module: check_mk Branch: master Commit: 043d1e96044c7e40cc823d436788be9ed1b0cfe8 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=043d1e96044c7e… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu May 22 10:39:53 2014 +0200 FIX Fix availability computation for hosts The host state "down" was classified as "host_down". This lead to incorrect numbers for host availability. --- .werks/890 | 10 ++++++++++ ChangeLog | 1 + web/plugins/views/availability.py | 7 +++++-- 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/.werks/890 b/.werks/890 new file mode 100644 index 0000000..9622e82 --- /dev/null +++ b/.werks/890 @@ -0,0 +1,10 @@ +Title: Fix availability computation for hosts +Level: 2 +Component: reporting +Class: fix +State: unknown +Version: 1.2.5i3 +Date: 1400747938 + +The host state "down" was classified as "host_down". This lead to incorrect numbers +for host availability. diff --git a/ChangeLog b/ChangeLog index 9da13c1..d92c7c1 100644 --- a/ChangeLog +++ b/ChangeLog @@ -126,6 +126,7 @@ * 0966 CSV export for availability works now also for BI aggregates * 0967 BI Availability timewarp: new buttons for moving back and forth * 0962 FIX: Fix CSV-Export in availability table + * 0890 FIX: Fix availability computation for hosts... Event Console: * 0885 New option for writing all messages into a syslog-like logfile... diff --git a/web/plugins/views/availability.py b/web/plugins/views/availability.py index 9901ada..ccdf4ee 100644 --- a/web/plugins/views/availability.py +++ b/web/plugins/views/availability.py @@ -727,7 +727,7 @@ def do_render_availability(rows, what, avoptions, timeline, timewarpcode): consider = False else: s = "in_downtime" - elif span["host_down"] and avoptions["consider"]["host_down"]: + elif what != "host" and span["host_down"] and avoptions["consider"]["host_down"]: s = "host_down" elif span["is_flapping"] and avoptions["consider"]["flapping"]: s = "flapping" @@ -860,7 +860,7 @@ def render_timeline(timeline_rows, from_time, until_time, considered_duration, width = min_percentage + rest_percentage * row["duration"] / considered_duration html.write('<td onmouseover="timeline_hover(%d, 1);" onmouseout="timeline_hover(%d, 0);" ' 'style="width: %.1f%%" title="%s" class="%s"></td>' % ( - row_nr, row_nr, width, title, css)) + row_nr, row_nr, width, html.attrencode(title), css)) html.write('</tr></table>') if style == "inline": @@ -895,6 +895,9 @@ def render_timeline(timeline_rows, from_time, until_time, considered_duration, for sid, css, sname, help in availability_columns: if sid == state_id: table.cell(_("State"), sname, css=css + " state narrow") + break + else: + table.cell(_("State"), "(%s/%s)" % (sid,sname)) table.cell(_("Additional information"), row["log_output"]) table.end()

10 years, 1 month

Check_MK Git: check_mk: fast_lta_headunit.status: On the slave node status appReadOnly is ok too

by Bernd Stroessenreuther

Module: check_mk Branch: master Commit: 82fbc65ea9d19328ff0f4c2f9b77c8766f0692b9 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=82fbc65ea9d193… Author: Bernd Stroessenreuther <bs(a)mathias-kettner.de> Date: Wed May 21 20:27:06 2014 +0200 fast_lta_headunit.status: On the slave node status appReadOnly is ok too --- checkman/fast_lta_headunit.status | 1 + checks/fast_lta_headunit | 3 +++ 2 files changed, 4 insertions(+) diff --git a/checkman/fast_lta_headunit.status b/checkman/fast_lta_headunit.status index da52791..b0659ab 100644 --- a/checkman/fast_lta_headunit.status +++ b/checkman/fast_lta_headunit.status @@ -6,6 +6,7 @@ distribution: check_mk description: Checks the Head Unit Status of a FAST LTA Storage System. Returns {OK} on status {appReady} and {CRIT} on every other. + On the slave node status {appReadOnly} is {OK} too. inventory: Finds exactly one check on every system (head unit). diff --git a/checks/fast_lta_headunit b/checks/fast_lta_headunit index 2e44e81..dc98687 100644 --- a/checks/fast_lta_headunit +++ b/checks/fast_lta_headunit @@ -65,6 +65,9 @@ def check_fast_lta_headunit_status(item, _no_params, info): if info[0][0][0] == "60": status = 0 + elif info[0][0][0] == "70" and info[0][0][1] == "0": + # on Slave node appReadOnly is also an ok state + status = 0 else: status = 2

10 years, 1 month

Check_MK Git: check_mk: FIX dashboards: fixed bug not updating header timestamp

by Andreas Boesl

Module: check_mk Branch: master Commit: 8dc0287803b11d48fbebf5bd5a7f7eb239d0591c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8dc0287803b11d… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Wed May 21 17:53:54 2014 +0200 FIX dashboards: fixed bug not updating header timestamp The header timestamp for dashboards only got updated if there were at least one 'url'-dashlet present. If a dashboard only contained links to views the header time was never updated. --- .werks/921 | 9 +++++++++ ChangeLog | 1 + web/htdocs/js/dashboard.js | 5 +++++ 3 files changed, 15 insertions(+) diff --git a/.werks/921 b/.werks/921 new file mode 100644 index 0000000..7bf2cfe --- /dev/null +++ b/.werks/921 @@ -0,0 +1,9 @@ +Title: dashboards: fixed bug not updating header timestamp +Level: 1 +Component: multisite +Version: 1.2.5i3 +Date: 1400687252 +Class: fix + +The header timestamp for dashboards only got updated if there were at least one 'url'-dashlet present. +If a dashboard only contained links to views the header time was never updated. diff --git a/ChangeLog b/ChangeLog index f1b12bc..9da13c1 100644 --- a/ChangeLog +++ b/ChangeLog @@ -93,6 +93,7 @@ * 0909 FIX: Table checkboxes: Fixed bug where selected checkboxes got ignored... * 0811 FIX: Fixed handling of exceptions occuring before login in debug mode * 0912 FIX: Multisite Views: Fixed bug where custom views could not get deleted + * 0921 FIX: dashboards: fixed bug not updating header timestamp... WATO: * 0784 Improved security of WATO bulk inventory by using transaction ids diff --git a/web/htdocs/js/dashboard.js b/web/htdocs/js/dashboard.js index 43d1338..1b2eb0e 100644 --- a/web/htdocs/js/dashboard.js +++ b/web/htdocs/js/dashboard.js @@ -151,6 +151,11 @@ function dashboard_scheduler(force) { } } setTimeout(function() { dashboard_scheduler(0); }, 1000); + // Update timestamp every minute + // Required if there are no refresh_dashlets present or all refresh times are > 60sec + if (timestamp % 60 == 0) { + updateHeaderTime(); + } } function dashboard_update_contents(id, code) {

10 years, 1 month

Check_MK Git: check_mk: fix of werk 613

by Goetz Golla

Module: check_mk Branch: master Commit: 02940d07813c1f2c1a55f06934a1410ec76e2725 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=02940d07813c1f… Author: Goetz Golla <gg(a)mathias-kettner.de> Date: Wed May 21 15:53:03 2014 +0200 fix of werk 613 --- .werks/613 | 2 +- ChangeLog | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.werks/613 b/.werks/613 index a32578b..8deedcc 100644 --- a/.werks/613 +++ b/.werks/613 @@ -1,6 +1,6 @@ Title: liveproxyd: fewer log messages in case a site is unreachable Level: 1 -Component: reporting +Component: liveproxy Version: 1.2.5i3 Date: 1400679878 Class: fix diff --git a/ChangeLog b/ChangeLog index 40b1486..03ed5f1 100644 --- a/ChangeLog +++ b/ChangeLog @@ -124,7 +124,6 @@ * 0966 CSV export for availability works now also for BI aggregates * 0967 BI Availability timewarp: new buttons for moving back and forth * 0962 FIX: Fix CSV-Export in availability table - * 0613 FIX: liveproxyd: fewer log messages in case a site is unreachable Event Console: * 0885 New option for writing all messages into a syslog-like logfile... @@ -136,6 +135,7 @@ Livestatus-Proxy: * 0970 FIX: liveproxyd: handle situations with more then 1024 open files... + * 0613 FIX: liveproxyd: fewer log messages in case a site is unreachable HW/SW-Inventory: * 0913 lnx_distro: Now able to detect SuSE distributions...

10 years, 1 month

Check_MK Git: check_mk: FIX liveproxyd: fewer log messages in case a site is unreachable

by Goetz Golla

Module: check_mk Branch: master Commit: 79ea70e9871c4974ba42b5d5602169f73315420b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=79ea70e9871c49… Author: Goetz Golla <gg(a)mathias-kettner.de> Date: Wed May 21 15:50:34 2014 +0200 FIX liveproxyd: fewer log messages in case a site is unreachable --- .werks/613 | 8 ++++++++ ChangeLog | 1 + doc/treasures/liveproxy/liveproxyd | 4 ++-- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/.werks/613 b/.werks/613 new file mode 100644 index 0000000..a32578b --- /dev/null +++ b/.werks/613 @@ -0,0 +1,8 @@ +Title: liveproxyd: fewer log messages in case a site is unreachable +Level: 1 +Component: reporting +Version: 1.2.5i3 +Date: 1400679878 +Class: fix + + diff --git a/ChangeLog b/ChangeLog index c5ccf4c..40b1486 100644 --- a/ChangeLog +++ b/ChangeLog @@ -124,6 +124,7 @@ * 0966 CSV export for availability works now also for BI aggregates * 0967 BI Availability timewarp: new buttons for moving back and forth * 0962 FIX: Fix CSV-Export in availability table + * 0613 FIX: liveproxyd: fewer log messages in case a site is unreachable Event Console: * 0885 New option for writing all messages into a syslog-like logfile... diff --git a/doc/treasures/liveproxy/liveproxyd b/doc/treasures/liveproxy/liveproxyd index 946cc96..ed9f254 100755 --- a/doc/treasures/liveproxy/liveproxyd +++ b/doc/treasures/liveproxy/liveproxyd @@ -154,7 +154,7 @@ def do_heartbeats(): if now - since >= rate: if not send_heartbeat(sitename, sitestate): if now - since >= 2 * rate: - log("Could not send heartbeat for %d secs - no free channel" % (2 * rate)) + log("Could not send heartbeat to %s for %d secs - no free channel" % ( sitename, (2 * rate))) disconnect_from_site(sitename) @@ -169,7 +169,7 @@ def send_heartbeat(sitename, sitestate): if next_channel == None or channel["since"] < next_channel["since"]: next_channel = channel if not next_channel: - log("Cannot send heartbeat to %s: no channel ready" % sitename) + #log("Cannot send heartbeat to %s: no channel ready" % sitename) return False else:

10 years, 1 month

Check_MK Git: check_mk: Show preview of active and custom checks in WATO services table

by Mathias Kettner

Module: check_mk Branch: master Commit: 996932163dd10069ca4fb3f0ead9d79a2af90631 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=996932163dd100… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed May 21 15:45:21 2014 +0200 Show preview of active and custom checks in WATO services table In the list of the services of a host now also for active and custom checks (i.e. non Check_MK-services) the output of the check plugin is being displayed. This is done by a Check_MK executing the check plugin with the configured arguments instead of the monitoring core. This can be used to test the outcome of check plugins before any changes are being activated. Note: because of issues with permissions and pathnames this feature only works on OMD based platforms. --- .werks/976 | 17 ++++++++++ ChangeLog | 1 + modules/automation.py | 80 +++++++++++++++++++++++++++++++++++++++++++++ web/htdocs/js/wato.js | 42 ++++++++++++++++++++++++ web/htdocs/wato.py | 21 +++++++++++- web/plugins/pages/wato.py | 19 ++++++----- 6 files changed, 170 insertions(+), 10 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=996932163d…

10 years, 1 month

Check_MK Git: check_mk: blade_bays: now also detects if blade server is switched off

by Andreas Boesl

Module: check_mk Branch: master Commit: 8ed43c2511efc6068515fa73a6d2aa85152ecc52 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8ed43c2511efc6… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Wed May 21 14:51:28 2014 +0200 blade_bays: now also detects if blade server is switched off --- .werks/920 | 8 ++++++++ ChangeLog | 1 + checks/blade_bays | 2 ++ 3 files changed, 11 insertions(+) diff --git a/.werks/920 b/.werks/920 new file mode 100644 index 0000000..9dfb3ce --- /dev/null +++ b/.werks/920 @@ -0,0 +1,8 @@ +Title: blade_bays: now also detects if blade server is switched off +Level: 1 +Component: checks +Version: 1.2.5i3 +Date: 1400676633 +Class: feature + + diff --git a/ChangeLog b/ChangeLog index f7003d1..c5ccf4c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -54,6 +54,7 @@ * 0957 fast_lta_silent_cubes.capacity: New check for Total Capacity over all Silent Cubes on FAST LTA Storage Systems * 0975 esx_vsphere_vm.guest_tools: renamed check (formerly esx_vsphere_vm.guestTools)... NOTE: Please refer to the migration notes! + * 0920 blade_bays: now also detects if blade server is switched off * 0777 FIX: special agent emcvnx: did not work with security file authentication... * 0786 FIX: zfsget: fixed compatibility with older Solaris agents... * 0809 FIX: brocade_fcport: Fixed recently introduced problem with port speed detection diff --git a/checks/blade_bays b/checks/blade_bays index d528dc7..75032d1 100644 --- a/checks/blade_bays +++ b/checks/blade_bays @@ -59,6 +59,8 @@ def check_blade_bays(item, _no_params, info): (blade_bays_module_state.get(state, 'Unhandled'), type, line[3])) elif state == 2: return (1, "Not present") + elif state == 3: + return (1, "Device is switched off") elif state == 0: return (1, "Device is in standby") else:

10 years, 1 month

Check_MK Git: check_mk: FIX df.include: failed for checks with grouping patterns

by Bernd Stroessenreuther

Module: check_mk Branch: master Commit: d68bf2c8628bc018af900b991ed7b93bb36583b0 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d68bf2c8628bc0… Author: Bernd Stroessenreuther <bs(a)mathias-kettner.de> Date: Wed May 21 14:09:01 2014 +0200 FIX df.include: failed for checks with grouping patterns df checks did fail when using filesystems grouping patterns. Now fixed. --- .werks/958 | 9 +++++++++ ChangeLog | 1 + checks/df.include | 6 +++--- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/.werks/958 b/.werks/958 new file mode 100644 index 0000000..8dbdead --- /dev/null +++ b/.werks/958 @@ -0,0 +1,9 @@ +Title: df.include: failed for checks with grouping patterns +Level: 1 +Component: checks +Version: 1.2.5i3 +Date: 1400674014 +Class: fix + +df checks did fail when using filesystems grouping patterns. Now fixed. + diff --git a/ChangeLog b/ChangeLog index acecb10..f7003d1 100644 --- a/ChangeLog +++ b/ChangeLog @@ -80,6 +80,7 @@ * 0969 FIX: blade_health: correctly output error message in non-OK state * 0611 FIX: nfsexports.solaris: fix in determination of path prefix * 0953 FIX: brocade_mlx_temp: special treatment for devices sometimes not delivering temperature by SNMP + * 0958 FIX: df.include: failed for checks with grouping patterns... Multisite: * 0779 Hostgroups (Summary): Empty hostgroups are no longer shown (can be re-enabled by filter) diff --git a/checks/df.include b/checks/df.include index 9141868..7b0b4ff 100644 --- a/checks/df.include +++ b/checks/df.include @@ -252,8 +252,8 @@ def df_check_filesystem_list(item, params, fslist_blocks, fslist_inodes = None): total_blocks_size = 0 total_blocks_avail = 0 total_inodes = 0 - total_inodse_avail = 0 - for idx, (mp, size_mb, avail_mb) in enumerate(fslist_block): + total_inodes_avail = 0 + for idx, (mp, size_mb, avail_mb) in enumerate(fslist_blocks): for pattern in patterns: if fnmatch.fnmatch(mp, pattern): count += 1 @@ -268,7 +268,7 @@ def df_check_filesystem_list(item, params, fslist_blocks, fslist_inodes = None): if count == 0: return (3, "No filesystem matching the patterns") else: - status, infotext, perfdata = df_check_filesystem_single(g_hostname, item, total_size, total_avail, params) + status, infotext, perfdata = df_check_filesystem_single(g_hostname, item, total_blocks_size, total_blocks_avail, total_inodes, total_inodes_avail, params) infotext += " (%d filesystems)" % count return status, infotext, perfdata else:

10 years, 1 month

Check_MK Git: check_mk: fast_lta_silent_cubes: Optimized service description

by Bernd Stroessenreuther

Module: check_mk Branch: master Commit: 1c41eb3aee3185a9e0f746a6b793a88b83e62917 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1c41eb3aee3185… Author: Bernd Stroessenreuther <bs(a)mathias-kettner.de> Date: Wed May 21 11:52:47 2014 +0200 fast_lta_silent_cubes: Optimized service description --- checks/fast_lta_silent_cubes | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/checks/fast_lta_silent_cubes b/checks/fast_lta_silent_cubes index 581fd6a..5e6f169 100644 --- a/checks/fast_lta_silent_cubes +++ b/checks/fast_lta_silent_cubes @@ -43,7 +43,7 @@ def check_fast_lta_silent_cubes_status(item, params, info): check_info["fast_lta_silent_cubes.capacity"] = { "check_function" : check_fast_lta_silent_cubes_status, "inventory_function" : inventory_fast_lta_silent_cubes_status, - "service_description" : "Silent Cubes Capacity %s", + "service_description" : "Fast LTA SC Capacity %s", "has_perfdata" : True, "group" : "filesystem", "includes" : [ "df.include" ],

10 years, 1 month

Check_MK Git: check_mk: esx_vsphere_vm.guest_tools: renamed check ( formerly esx_vsphere_vm.guestTools)

by Mathias Kettner

Module: check_mk Branch: master Commit: 4f7f194566e4ba6492c17c6e810e8b4d270d1fb4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=4f7f194566e4ba… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed May 21 10:31:17 2014 +0200 esx_vsphere_vm.guest_tools: renamed check (formerly esx_vsphere_vm.guestTools) Due to a inconstent naming we had to rename the check {esx_vsphere_vm.guestTools} into {esx_vsphere_vm.guest_tools}. Please reinventorize the affected hosts in order to switch over to the new plugin. --- .werks/975 | 9 +++++++++ ChangeLog | 2 ++ checks/esx_vsphere_vm | 5 ++++- 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/.werks/975 b/.werks/975 new file mode 100644 index 0000000..601647a --- /dev/null +++ b/.werks/975 @@ -0,0 +1,9 @@ +Title: esx_vsphere_vm.guest_tools: renamed check (formerly esx_vsphere_vm.guestTools) +Level: 1 +Component: checks +Version: 1.2.5i3 +Date: 1400660997 +Class: incomp + +Due to a inconstent naming we had to rename the check {esx_vsphere_vm.guestTools} into {esx_vsphere_vm.guest_tools}. +Please reinventorize the affected hosts in order to switch over to the new plugin. diff --git a/ChangeLog b/ChangeLog index f0a9fda..fac7fc8 100644 --- a/ChangeLog +++ b/ChangeLog @@ -51,6 +51,8 @@ * 0162 if_brocade: New if64 Check version for Brocade VDX Switches... NOTE: Please refer to the migration notes! * 0956 fast_lta_headunit.status, fast_lta_headunit.replication: New checks for FAST LTA Storage Systems + * 0975 esx_vsphere_vm.guest_tools: renamed check (formerly esx_vsphere_vm.guestTools)... + NOTE: Please refer to the migration notes! * 0777 FIX: special agent emcvnx: did not work with security file authentication... * 0786 FIX: zfsget: fixed compatibility with older Solaris agents... * 0809 FIX: brocade_fcport: Fixed recently introduced problem with port speed detection diff --git a/checks/esx_vsphere_vm b/checks/esx_vsphere_vm index 219b12e..fdef02e 100644 --- a/checks/esx_vsphere_vm +++ b/checks/esx_vsphere_vm @@ -119,6 +119,7 @@ check_info['esx_vsphere_vm.name'] = { +#. # .--Runtime Host--------------------------------------------------------. # | ____ _ _ _ _ _ | # | | _ \ _ _ _ __ | |_(_)_ __ ___ ___ | | | | ___ ___| |_ | @@ -152,6 +153,7 @@ check_info['esx_vsphere_vm.running_on'] = { } +#. # .--VM Datastores--------------------------------------------------------. # | __ ____ __ ____ _ _ | # | \ \ / / \/ | | _ \ __ _| |_ __ _ ___| |_ ___ _ __ ___ | @@ -248,13 +250,14 @@ def check_esx_vsphere_vm_guest_tools(_no_item, params, info): return state, info -check_info['esx_vsphere_vm.guestTools'] = { +check_info['esx_vsphere_vm.guest_tools'] = { "inventory_function" : inventory_esx_vsphere_vm_guest_tools, "check_function" : check_esx_vsphere_vm_guest_tools, "service_description" : "ESX Guest Tools", "group" : "vm_guest_tools" } + #. # .--Heartbeat-----------------------------------------------------------. # | _ _ _ _ _ |

10 years, 1 month

← Newer
1
2
3
4
5
6
7
8
9
...
14
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits May 2014