Checkmk git commits December 2014

checkmk-commits@lists.checkmk.com

6 participants
519 discussions

Check_MK Git: check_mk: Removed now unused image

by Lars Michelsen

Module: check_mk Branch: master Commit: 72fbf23fe495bad071b77b66e73e3b3edfe1b80a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=72fbf23fe495ba… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Dec 1 23:30:03 2014 +0100 Removed now unused image --- web/htdocs/images/mk_logo_small.gif | Bin 453 -> 0 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/web/htdocs/images/mk_logo_small.gif b/web/htdocs/images/mk_logo_small.gif deleted file mode 100644 index 5c9b871..0000000 Binary files a/web/htdocs/images/mk_logo_small.gif and /dev/null differ

9 years, 9 months

Check_MK Git: check_mk: Updated bug entries #2209

by Lars Michelsen

Module: check_mk Branch: master Commit: 1cb780fcb3130387a853224196ec98004e12a15b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1cb780fcb31303… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Dec 1 23:47:15 2014 +0100 Updated bug entries #2209 --- .bugs/2209 | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.bugs/2209 b/.bugs/2209 new file mode 100644 index 0000000..5fc22d1 --- /dev/null +++ b/.bugs/2209 @@ -0,0 +1,8 @@ +Title: Dashboard toggle edit should add/remove edit=1 to/from the URL +Component: multisite +State: open +Date: 2014-12-01 23:45:31 +Targetversion: 1.2.5i1 +Class: nastiness + +Otherwise reloading the page would result in toggling edit mode.

9 years, 9 months

Check_MK Git: check_mk: Added new makefile target optimize-images to shrink PNG images

by Lars Michelsen

Module: check_mk Branch: master Commit: fe6bc56af4114bfd919cbe56db6c035107dd535d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=fe6bc56af4114b… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Dec 1 23:43:14 2014 +0100 Added new makefile target optimize-images to shrink PNG images --- .bugs/2208 | 7 +++++++ Makefile | 6 ++++++ 2 files changed, 13 insertions(+) diff --git a/.bugs/2208 b/.bugs/2208 new file mode 100644 index 0000000..e154b85 --- /dev/null +++ b/.bugs/2208 @@ -0,0 +1,7 @@ +Title: Add "make optimize-images" to normal build process +Component: multisite +State: open +Date: 2014-12-01 22:53:37 +Targetversion: 1.2.5i1 +Class: todo + diff --git a/Makefile b/Makefile index ca94567..0cfb58d 100644 --- a/Makefile +++ b/Makefile @@ -267,6 +267,12 @@ healspaces: @echo "Removing trailing spaces from code lines..." @sed -ri 's/[[:space:]]+$$//g' $(HEAL_SPACES_IN) +optimize-images: + @for F in web/htdocs/images/*.png web/htdocs/images/icons/*.png; do \ + echo "Optimizing $$F..." ; \ + pngcrush -q -rem alla -brute $$F $$F.opt ; \ + mv $$F.opt $$F; \ + done clean: rm -rf dist.tmp rpm.topdir *.rpm *.deb *.exe \

9 years, 9 months

Check_MK Git: check_mk: Updated bug entries #2161

by Lars Michelsen

Module: check_mk Branch: master Commit: 415b6bb6b5a004e902d8fe956176115f9b5e6bd8 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=415b6bb6b5a004… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Dec 2 10:04:31 2014 +0100 Updated bug entries #2161 --- .bugs/2161 | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.bugs/2161 b/.bugs/2161 index 47e1fd1..3779f2f 100644 --- a/.bugs/2161 +++ b/.bugs/2161 @@ -1,11 +1,14 @@ Title: Visual: single-context views with hardcoded context should not display filter Component: multisite -State: open +Class: bug +State: done Date: 2014-09-02 12:20:34 Targetversion: future -Class: bug Currently the filter is being displayed, with an Warning icon, and any changes are silently ignored. The filter should not be visible in that case. + +2014-12-02 10:04:25: changed state open -> done +The default seting can now be overriden.

9 years, 9 months

Check_MK Git: check_mk: #1579 FIX Views: Setting for hard coded single context filters can now be changed by URL and filter

by Lars Michelsen

Module: check_mk Branch: master Commit: fc066d9e86eec81c882c709b4f7a7cbea8efc156 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=fc066d9e86eec8… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Dec 2 10:04:05 2014 +0100 #1579 FIX Views: Setting for hard coded single context filters can now be changed by URL and filter When a view has a hard coded value for a single context filter, the value could not be changed by the user when watching a view, neither by URL nor filter form. This has been changed now to make it possible to override the default value. --- .werks/1579 | 11 +++++++++++ ChangeLog | 1 + web/htdocs/visuals.py | 6 +++--- 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/.werks/1579 b/.werks/1579 new file mode 100644 index 0000000..3ac34ce --- /dev/null +++ b/.werks/1579 @@ -0,0 +1,11 @@ +Title: Views: Setting for hard coded single context filters can now be changed by URL and filter +Level: 1 +Component: multisite +Compatible: compat +Version: 1.2.5i7 +Date: 1417510947 +Class: fix + +When a view has a hard coded value for a single context filter, the value could +not be changed by the user when watching a view, neither by URL nor filter form. +This has been changed now to make it possible to override the default value. diff --git a/ChangeLog b/ChangeLog index 5d7e4e5..b6f4c24 100644 --- a/ChangeLog +++ b/ChangeLog @@ -91,6 +91,7 @@ * 1557 FIX: Fix sorting of hostnames that only differ in lower/uppercaseness * 1577 FIX: Fixed editing of views using the "Downtime for host/service" sorter or column... * 1578 FIX: Folding states of containers with umlauts in titles are now persisted... + * 1579 FIX: Views: Setting for hard coded single context filters can now be changed by URL and filter... WATO: * 1170 Added buttons to move rules to top/bottom of the list to ruleset edit dialog diff --git a/web/htdocs/visuals.py b/web/htdocs/visuals.py index f7115a7..5185dfc 100644 --- a/web/htdocs/visuals.py +++ b/web/htdocs/visuals.py @@ -903,10 +903,10 @@ def add_context_to_uri_vars(visual, only_infos=None, only_count=False): only_infos = infos.keys() # all datasources! # Populate the HTML vars with missing context vars. The context vars set - # in single context are enforced (can not be overwritten by URL). The normal - # filter vars in "multiple" context are not enforced. + # in single context are not enforced (they can be overwritten by URL or by + # changing the filter form). for key in get_single_info_keys(visual): - if key in visual['context']: + if key in visual['context'] and not html.has_var(key): html.set_var(key, visual['context'][key]) # Now apply the multiple context filters

9 years, 9 months

Check_MK Git: check_mk: #1577 FIX Fixed editing of views using the " Downtime for host/service" sorter or column

by Lars Michelsen

Module: check_mk Branch: master Commit: 732d9c6302167f4cb08aa23db36e21992a7d18b8 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=732d9c6302167f… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Dec 1 23:24:51 2014 +0100 #1577 FIX Fixed editing of views using the "Downtime for host/service" sorter or column --- .werks/1577 | 10 ++++++++++ web/plugins/views/painters.py | 8 ++++---- web/plugins/views/sorters.py | 2 +- 3 files changed, 15 insertions(+), 5 deletions(-) diff --git a/.werks/1577 b/.werks/1577 new file mode 100644 index 0000000..c33902d --- /dev/null +++ b/.werks/1577 @@ -0,0 +1,10 @@ +Title: Fixed editing of views using the "Downtime for host/service" sorter or column +Level: 1 +Component: multisite +Compatible: compat +Version: 1.2.5i7 +Date: 1417449307 +Class: fix + +Views which were using the "Downtime for host/service" (downtime_what) sorter or column +were loosing this information when opening the view for editing and saving it again. diff --git a/web/plugins/views/painters.py b/web/plugins/views/painters.py index f264933..0f1c01d 100644 --- a/web/plugins/views/painters.py +++ b/web/plugins/views/painters.py @@ -1625,8 +1625,8 @@ multisite_painters["downtime_comment"] = { } multisite_painters["downtime_fixed"] = { - "title" : _("Type of Downtime"), - "short" : _("Type"), + "title" : _("Downtime start mode"), + "short" : _("Start"), "columns" : ["downtime_fixed"], "paint" : lambda row: (None, row["downtime_fixed"] == 0 and _("flexible") or _("fixed")), } @@ -1634,8 +1634,8 @@ multisite_painters["downtime_fixed"] = { multisite_painters["downtime_what"] = { "title" : _("Downtime for host/service"), "short" : _("for"), - "columns" : ["is_service"], - "paint" : lambda row: (None, row["is_service"] and _("Service") or _("Host")), + "columns" : ["downtime_is_service"], + "paint" : lambda row: (None, row["downtime_is_service"] and _("Service") or _("Host")), } multisite_painters["downtime_type"] = { diff --git a/web/plugins/views/sorters.py b/web/plugins/views/sorters.py index bbe2815..1c02cdc 100644 --- a/web/plugins/views/sorters.py +++ b/web/plugins/views/sorters.py @@ -300,7 +300,7 @@ declare_1to1_sorter("downtime_author", cmp_simple_string) declare_1to1_sorter("downtime_comment", cmp_simple_string) declare_1to1_sorter("downtime_fixed", cmp_simple_number) declare_1to1_sorter("downtime_type", cmp_simple_number) -declare_simple_sorter("downtime_what", _("Downtime type (host/service)"), "is_service", cmp_simple_number) +declare_simple_sorter("downtime_what", _("Downtime for host/service"), "downtime_is_service", cmp_simple_number) declare_simple_sorter("downtime_start_time", _("Downtime start"), "downtime_start_time", cmp_simple_number) declare_simple_sorter("downtime_end_time", _("Downtime end"), "downtime_end_time", cmp_simple_number) declare_simple_sorter("downtime_entry_time", _("Downtime entry time"), "downtime_entry_time", cmp_simple_number)

9 years, 9 months

Check_MK Git: check_mk: #1578 FIX Folding states of containers with umlauts in titles are now persisted

by Lars Michelsen

Module: check_mk Branch: master Commit: 43bee2fa33379f9e3584c15a90edea45e168e8d6 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=43bee2fa33379f… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Dec 1 23:26:05 2014 +0100 #1578 FIX Folding states of containers with umlauts in titles are now persisted --- .werks/1578 | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.werks/1578 b/.werks/1578 new file mode 100644 index 0000000..d0396f9 --- /dev/null +++ b/.werks/1578 @@ -0,0 +1,10 @@ +Title: Folding states of containers with umlauts in titles are now persisted +Level: 1 +Component: multisite +Compatible: compat +Version: 1.2.5i7 +Date: 1417453414 +Class: fix + +When a foldable container has umlauts in the title, for example when a view +topic has umlauts in it, the folding state was not persisted across page reloads.

9 years, 9 months

Check_MK Git: check_mk: #1578 FIX Folding states of containers with umlauts in titles are now persisted

by Lars Michelsen

Module: check_mk Branch: master Commit: ad40b21f50affb6f57a212d6afaa70881839060c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ad40b21f50affb… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Dec 1 23:26:16 2014 +0100 #1578 FIX Folding states of containers with umlauts in titles are now persisted --- web/htdocs/config.py | 2 ++ web/htdocs/htmllib.py | 2 +- web/htdocs/js/bi.js | 4 ++-- web/htdocs/js/checkmk.js | 7 ++++--- web/htdocs/js/sidebar.js | 27 ++++++++++++++------------- web/htdocs/js/wato.js | 25 +++++++++++++------------ web/htdocs/lib.py | 11 ++++++++++- web/htdocs/visuals.py | 1 + web/htdocs/weblib.py | 3 ++- 9 files changed, 49 insertions(+), 33 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=ad40b21f50…

9 years, 9 months

Check_MK Git: check_mk: Removed unused image file

by Lars Michelsen

Module: check_mk Branch: master Commit: ef6546fe463a8577fa03e1f42066736fb0937c4d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ef6546fe463a85… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Dec 1 23:28:01 2014 +0100 Removed unused image file --- web/htdocs/images/mk_logo_126x72.gif | Bin 2234 -> 0 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/web/htdocs/images/mk_logo_126x72.gif b/web/htdocs/images/mk_logo_126x72.gif deleted file mode 100644 index 8122270..0000000 Binary files a/web/htdocs/images/mk_logo_126x72.gif and /dev/null differ

9 years, 9 months

Check_MK Git: check_mk: Replaced ugly MK logo GIF with PNG variant

by Lars Michelsen

Module: check_mk Branch: master Commit: 73190d8f462e91ccb29e972eab22645fa80d5630 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=73190d8f462e91… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Dec 1 23:01:07 2014 +0100 Replaced ugly MK logo GIF with PNG variant --- web/htdocs/images/logo_mk_small.png | Bin 0 -> 1198 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/web/htdocs/images/logo_mk_small.png b/web/htdocs/images/logo_mk_small.png new file mode 100644 index 0000000..24f5560 Binary files /dev/null and b/web/htdocs/images/logo_mk_small.png differ

9 years, 9 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits December 2014