Checkmk git commits December 2014

checkmk-commits@lists.checkmk.com

6 participants
519 discussions

Check_MK Git: check_mk: ibm_svc_portfc: removed IBM SVC prefix

by Bastian Kuhn

Module: check_mk Branch: master Commit: d874c6c23dab292920cef771c86b356cfbf6d687 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d874c6c23dab29… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Thu Dec 4 09:12:39 2014 +0100 ibm_svc_portfc: removed IBM SVC prefix --- checks/ibm_svc_portfc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/checks/ibm_svc_portfc b/checks/ibm_svc_portfc index d6ecfaf..b2d171c 100644 --- a/checks/ibm_svc_portfc +++ b/checks/ibm_svc_portfc @@ -74,7 +74,7 @@ def check_ibm_svc_portfc(item, _no_params, info): check_info["ibm_svc_portfc"] = { "check_function" : check_ibm_svc_portfc, "inventory_function" : inventory_ibm_svc_portfc, - "service_description" : "IBM SVC FC Port %s", + "service_description" : "FC Port %s", "has_perfdata" : False, }

9 years, 9 months

Check_MK Git: check_mk: ibm_svc_host: Fixed typo in groups definition

by Bastian Kuhn

Module: check_mk Branch: master Commit: 94994b2a5eda8bd1e633954a181ae688ab2f90a9 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=94994b2a5eda8b… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Thu Dec 4 09:14:13 2014 +0100 ibm_svc_host: Fixed typo in groups definition --- checks/ibm_svc_host | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/checks/ibm_svc_host b/checks/ibm_svc_host index 3f3fd5a..ece741d 100644 --- a/checks/ibm_svc_host +++ b/checks/ibm_svc_host @@ -88,6 +88,6 @@ check_info["ibm_svc_host"] = { "service_description" : "Hosts", "has_perfdata" : True, "default_levels_variable": "ibm_svc_host_default_levels", - "group" : "ibm_svc_hosts", + "group" : "ibm_svc_host", }

9 years, 9 months

Check_MK Git: check_mk: checkpoint_packets: Also fixed scan function here

by Bastian Kuhn

Module: check_mk Branch: master Commit: 9ba4dbc9532f2a6f74e4cd59c272cba2d6b2ed51 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=9ba4dbc9532f2a… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Thu Dec 4 11:25:23 2014 +0100 checkpoint_packets: Also fixed scan function here --- checks/checkpoint_packets | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/checks/checkpoint_packets b/checks/checkpoint_packets index a6eeffc..4ba0bcc 100644 --- a/checks/checkpoint_packets +++ b/checks/checkpoint_packets @@ -77,7 +77,8 @@ check_info["checkpoint_packets"] = { "group" : "checkpoint_packets", "default_levels_variable" : "checkpoint_packets_default_levels", # detect a checkpoint kernel - "snmp_scan_function" : lambda oid: oid(".1.3.6.1.2.1.1.1.0").split(" ")[2].endswith("cp"), + "snmp_scan_function" : lambda oid: oid(".1.3.6.1.2.1.1.1.0").split(" ")[2].endswith("cp")\ + and oid(".1.3.6.1.4.1.2620.1.1.21.0").lower().startswith('firewall'), # checkpoint.products.fw.fwPolicyStat.fwNumConn "snmp_info" : ( ".1.3.6.1.4.1.2620.1.1", [ 4, # fwAccepted

9 years, 9 months

Check_MK Git: check_mk: ibm_svc_nodestats: Fixed service Description

by Bastian Kuhn

Module: check_mk Branch: master Commit: 68a448b58e562673d8c88a14fcd23cba4e4e01c3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=68a448b58e5626… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Thu Dec 4 10:35:18 2014 +0100 ibm_svc_nodestats: Fixed service Description --- checks/ibm_svc_nodestats | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/checks/ibm_svc_nodestats b/checks/ibm_svc_nodestats index 76bb11d..545ec80 100644 --- a/checks/ibm_svc_nodestats +++ b/checks/ibm_svc_nodestats @@ -141,7 +141,7 @@ def check_ibm_svc_nodestats_diskio(item, _no_params, info): check_info["ibm_svc_nodestats.diskio"] = { "check_function" : check_ibm_svc_nodestats_diskio, "inventory_function" : inventory_ibm_svc_nodestats_diskio, - "service_description" : "Disk Throughput %s", + "service_description" : "Disk IO %s", "has_perfdata" : True, }

9 years, 9 months

Check_MK Git: check_mk: checkpoint_connections: Fixed scan function, check now only apears on firewalls

by Bastian Kuhn

Module: check_mk Branch: master Commit: 2a60262cbf3f118091998709c5c07b8ec3dd6f41 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2a60262cbf3f11… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Thu Dec 4 11:17:50 2014 +0100 checkpoint_connections: Fixed scan function, check now only apears on firewalls --- checks/checkpoint_connections | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/checks/checkpoint_connections b/checks/checkpoint_connections index 637b32e..dba029e 100644 --- a/checks/checkpoint_connections +++ b/checks/checkpoint_connections @@ -50,7 +50,8 @@ check_info["checkpoint_connections"] = { "has_perfdata" : True, "group" : "checkpoint_connections", # detect a checkpoint kernel - "snmp_scan_function" : lambda oid: oid(".1.3.6.1.2.1.1.1.0").split(" ")[2].endswith("cp"), + "snmp_scan_function" : lambda oid: oid(".1.3.6.1.2.1.1.1.0").split(" ")[2].endswith("cp") \ + and oid(".1.3.6.1.4.1.2620.1.1.21.0").lower().startswith('firewall'), # checkpoint.products.fw.fwPolicyStat.fwNumConn "snmp_info" : ( ".1.3.6.1.4.1.2620.1.1.25", [ 3 ]), }

9 years, 9 months

Check_MK Git: check_mk: #1627 megaraid_ldisks: Warn if current cache or write policy differs from logical drive default policy

by Mathias Kettner

Module: check_mk Branch: master Commit: 8a154dd8e0377f017614aa50a57151eb12f440f5 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8a154dd8e0377f… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Dec 4 12:15:16 2014 +0100 #1627 megaraid_ldisks: Warn if current cache or write policy differs from logical drive default policy Thanks to Jukka Santala --- .werks/1627 | 9 +++++++++ ChangeLog | 1 + checks/megaraid_ldisks | 35 ++++++++++++++++++++++++++++------- 3 files changed, 38 insertions(+), 7 deletions(-) diff --git a/.werks/1627 b/.werks/1627 new file mode 100644 index 0000000..ba5da8e --- /dev/null +++ b/.werks/1627 @@ -0,0 +1,9 @@ +Title: megaraid_ldisks: Warn if current cache or write policy differs from logical drive default policy +Level: 1 +Component: checks +Compatible: compat +Version: 1.2.5i7 +Date: 1417691670 +Class: feature + +Thanks to Jukka Santala diff --git a/ChangeLog b/ChangeLog index f5794c3..128ace9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -46,6 +46,7 @@ * 1615 qnap_disks: Added support for Fujitsu NAS QR802 * 1616 drbd: Added support for Ahead/Behind cluster states (DRBD >= 8.3.10) * 1626 Renamed service descriptions of filesystem, process and logwatch checks... + * 1627 megaraid_ldisks: Warn if current cache or write policy differs from logical drive default policy... * 1478 FIX: kernel.util, statgrab_cpu: fix computation of utilization... * 1480 FIX: brocade_vdx_status: disable check on some devices that do not support it... * 1485 FIX: dell_om_disks, dell_om_esmlog, dell_om_mem, dell_om_processors, dell_om_sensors: detect more devices... diff --git a/checks/megaraid_ldisks b/checks/megaraid_ldisks index 097fa40..bb56eb5 100644 --- a/checks/megaraid_ldisks +++ b/checks/megaraid_ldisks @@ -47,21 +47,42 @@ def inventory_megaraid_ldisks(info): def check_megaraid_ldisks(item, _no_params, info): adapter = None + cache = None + write = None found = False + result = 0 + infotext = '' for line in info: l = ' '.join(line) if line[0] == "Adapter" and not l.endswith('No Virtual Drive Configured.'): adapter = int(line[1]) elif line[0] == "Virtual" and (line[1] == "Disk:" or line[1] == "Drive:"): + if found: + break disk = int(line[2]) found = "%d/%d" % (adapter, disk) == item - elif found and line[0].startswith("State"): - state = " ".join(line[1:]).replace(': ', '') - infotext = "state is %s" % state - if state == "Optimal": - return (0, infotext) - else: - return (2, infotext) + elif found: + if line[0].startswith("State"): + state = " ".join(line[1:]).replace(': ', '') + infotext += "state is %s" % state + if state != "Optimal": + result = max(result, 2) + elif line[0].startswith("Default") and line[1].startswith("Cache"): + cache = " ".join(line[3:]).replace(': ', '') + elif line[0].startswith("Current") and line[1].startswith("Cache"): + state = " ".join(line[3:]).replace(': ', '') + if cache != state: + infotext += ", cache is %s, expected %s" % (state, cache) + result = max(result, 1) + elif line[0].startswith("Default") and line[1].startswith("Write"): + write = " ".join(line[3:]).replace(': ', '') + elif line[0].startswith("Current") and line[1].startswith("Write"): + state = " ".join(line[3:]).replace(': ', '') + if write != state: + infotext += ", write is %s, expected %s" % (write, cache) + result = max(result, 1) + if found: + return (result, infotext) return (3, "no such adapter/logical disk found")

9 years, 9 months

Check_MK Git: check_mk: megaraid_bbu: fix exception if Full Charge Capacity is unknown

by Mathias Kettner

Module: check_mk Branch: master Commit: f7ee98e44637538fe3741118e70c1b52db4ec477 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f7ee98e4463753… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Dec 4 12:13:58 2014 +0100 megaraid_bbu: fix exception if Full Charge Capacity is unknown --- checks/megaraid_bbu | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/checks/megaraid_bbu b/checks/megaraid_bbu index baa07cc..ca7d8ac 100644 --- a/checks/megaraid_bbu +++ b/checks/megaraid_bbu @@ -86,8 +86,9 @@ def check_megaraid_bbu(item, _no_params, info): if 'Relative State of Charge' not in controller: charge = ", No charge information reported for this controller" else: - charge = ", Charge is %s, Capacity is %s" % \ - (controller['Relative State of Charge'], controller['Full Charge Capacity']) + charge = ", Charge is %s" % controller['Relative State of Charge'] + if 'Full Charge Capacity' in controller: + charge += ", Charge is %s, Capacity is %s" % controller['Full Charge Capacity'] # verify defined important parameters to current level for varname, (refvalue, refstate) in megaraid_bbu_refvalues.items():

9 years, 9 months

Check_MK Git: check_mk: Slight styling improvement in WATO global option

by Mathias Kettner

Module: check_mk Branch: master Commit: 2c658d868c1bd6cad1c553dcd09c172757e12ace URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2c658d868c1bd6… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Dec 4 11:38:21 2014 +0100 Slight styling improvement in WATO global option --- web/htdocs/valuespec.py | 7 ++++++- web/plugins/wato/check_mk_configuration.py | 3 ++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/web/htdocs/valuespec.py b/web/htdocs/valuespec.py index 131718e..6eaa33f 100644 --- a/web/htdocs/valuespec.py +++ b/web/htdocs/valuespec.py @@ -1465,6 +1465,7 @@ class ListChoice(ValueSpec): self._render_function = kwargs.get("render_function", lambda id, val: val) self._toggle_all = kwargs.get("toggle_all", False) + self._render_orientation = kwargs.get("render_orientation", "horizontal") # other: vertical # In case of overloaded functions with dynamic elements def load_elements(self): @@ -1503,7 +1504,11 @@ class ListChoice(ValueSpec): def value_to_text(self, value): self.load_elements() d = dict(self._elements) - return ", ".join([ self._render_function(v, d.get(v,v)) for v in value ]) + texts = [ self._render_function(v, d.get(v,v)) for v in value ] + if self._render_orientation == "horizontal": + return ", ".join(texts) + else: + return "<table><tr><td>" + "<br>".join(texts) + "</td></tr></table>" def from_html_vars(self, varprefix): self.load_elements() diff --git a/web/plugins/wato/check_mk_configuration.py b/web/plugins/wato/check_mk_configuration.py index fe2de60..c675230 100644 --- a/web/plugins/wato/check_mk_configuration.py +++ b/web/plugins/wato/check_mk_configuration.py @@ -1105,7 +1105,8 @@ register_configvar(group, ( "ps.perf", _("State and Count of Processes (with additional performance data)")), ( "wmic_process", _("Ressource consumption of windows processes")), ( "logwatch", _("Check logfiles for relevant new messages")), - ] + ], + render_orientation = "vertical", ), need_restart = True )

9 years, 9 months

Check_MK Git: check_mk: #1626 Renamed service descriptions of filesystem, process and logwatch checks

by Mathias Kettner

Module: check_mk Branch: master Commit: db16accb234bbe349a4b3134d4b2428246df15ae URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=db16accb234bbe… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Dec 4 11:23:12 2014 +0100 #1626 Renamed service descriptions of filesystem, process and logwatch checks The service descriptions of several check types have been renamed in order to be more consistent the the rest of the services. For example <tt>fs_</tt> has been renamed into <tt>Filesystem</tt>. In order not to run in problems this renaming is just enabled for <i>new sites</i> per default. You can switch existing sites to the new naming scheme with a new global WATO option <i>Use new service descriptions</i> in the section <i>Operation mode of Check_MK</i>. Please be aware that renaming services in operative systems have many implications, such as: <ul> <li>Notifications being sent about non-OK new services</li> <li>Performance data will start new and not continue the old one</li> <li>History and availability will break</li> </ul> --- .werks/1626 | 23 +++++++++++++++++++++ ChangeLog | 1 + checks/df | 2 +- checks/df_netapp | 2 +- checks/df_netapp32 | 2 +- checks/esx_vsphere_datastores | 2 +- checks/hr_fs | 2 +- checks/logwatch | 2 +- checks/ps | 4 ++-- checks/vms_diskstat | 2 +- checks/wmic_process | 2 +- checks/zfsget | 2 +- doc/README.renaming_services | 25 ++++++++++++++++++++++ modules/check_mk.py | 26 ++++++++++++++++++++++- web/htdocs/wato.py | 24 ++++++++++++++++++++- web/plugins/wato/check_mk_configuration.py | 31 ++++++++++++++++++++++++++++ 16 files changed, 139 insertions(+), 13 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=db16accb23…

9 years, 9 months

Check_MK Git: check_mk: docsis_channels_downstream: Fixed wrong check catalog entry

by Lars Michelsen

Module: check_mk Branch: master Commit: b28af8ee3273b927c84a5c7c1baf49f4d342015f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b28af8ee3273b9… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Dec 4 10:40:48 2014 +0100 docsis_channels_downstream: Fixed wrong check catalog entry --- checkman/docsis_channels_downstream | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/checkman/docsis_channels_downstream b/checkman/docsis_channels_downstream index 54734bc..bb4db3e 100644 --- a/checkman/docsis_channels_downstream +++ b/checkman/docsis_channels_downstream @@ -1,6 +1,6 @@ title: DOCSIS: Downstream Channels agents: snmp -catalog: hw/network/docsis +catalog: hw/network/generic license: GPL distribution: description:

9 years, 9 months

← Newer
1
...
36
37
38
39
40
41
42
...
52
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits December 2014