Checkmk git commits December 2014

checkmk-commits@lists.checkmk.com

6 participants
519 discussions

Check_MK Git: check_mk: Fixed link to WATO for Check_MK Discovery service

by Lars Michelsen

Module: check_mk Branch: master Commit: c0fb4f251b5c0e7e249d6b6bec1e903d89c55080 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c0fb4f251b5c0e… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Dec 4 16:08:13 2014 +0100 Fixed link to WATO for Check_MK Discovery service --- web/plugins/icons/wato.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/plugins/icons/wato.py b/web/plugins/icons/wato.py index 053b301..977a1e5 100644 --- a/web/plugins/icons/wato.py +++ b/web/plugins/icons/wato.py @@ -53,7 +53,7 @@ def paint_wato(what, row, tags, custom_vars): wato_folder = filename[6:-8].rstrip("/") if what == "host": return wato_link(wato_folder, row["site"], row["host_name"], "edithost") - elif row["service_description"].lower() == "check_mk inventory": + elif row["service_description"] in [ "Check_MK inventory", "Check_MK Discovery" ]: return wato_link(wato_folder, row["site"], row["host_name"], "inventory") multisite_icons.append({

9 years, 11 months

Check_MK Git: check_mk: #1653 FIX megaraid_pdisks: Resulting states are now hard coded within the check

by Lars Michelsen

Module: check_mk Branch: master Commit: a60379cae2184510efb934e7535c33283726f6a9 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a60379cae21845… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Dec 4 17:16:14 2014 +0100 #1653 FIX megaraid_pdisks: Resulting states are now hard coded within the check The megaraid_pdisks check was using the state the device had during initial inventory as expected OK state. When a device was failed during inventory, the state never changed to CRITICAL, even if the device is failed. This has been fixed by hard coding the resulting states now. Online, Hotspare -> OK Failed -> CRITICAL --- .werks/1653 | 15 +++++++++++++++ ChangeLog | 1 + checkman/megaraid_pdisks | 7 +------ checks/megaraid_pdisks | 26 +++++++++++++------------- 4 files changed, 30 insertions(+), 19 deletions(-) diff --git a/.werks/1653 b/.werks/1653 new file mode 100644 index 0000000..7e9505f --- /dev/null +++ b/.werks/1653 @@ -0,0 +1,15 @@ +Title: megaraid_pdisks: Resulting states are now hard coded within the check +Level: 1 +Component: checks +Compatible: compat +Version: 1.2.5i7 +Date: 1417709673 +Class: fix + +The megaraid_pdisks check was using the state the device had during initial +inventory as expected OK state. When a device was failed during inventory, +the state never changed to CRITICAL, even if the device is failed. +This has been fixed by hard coding the resulting states now. + +Online, Hotspare -> OK +Failed -> CRITICAL diff --git a/ChangeLog b/ChangeLog index 3a35158..3093406 100644 --- a/ChangeLog +++ b/ChangeLog @@ -105,6 +105,7 @@ * 1598 FIX: bluecat_dhcp: Check is not longer found in inventory if dhcp service is not activated * 1635 FIX: multipath: fix parsing output of multipath on RedHat6 with space in alias * 1652 FIX: kaspersky_av_quarantine: Fixed exception when a file was found in quarantine + * 1653 FIX: megaraid_pdisks: Resulting states are now hard coded within the check... Multisite: * 1508 Allow input of plugin output and perfdata when faking check results... diff --git a/checkman/megaraid_pdisks b/checkman/megaraid_pdisks index 8ed296b..e348b08 100644 --- a/checkman/megaraid_pdisks +++ b/checkman/megaraid_pdisks @@ -19,10 +19,5 @@ item: A combination of the enclosure and the slot number, separated by a slash, for example {"0/4"} for enclosure {0} and slot {4}. -parameter: - targetstate (string): The target state of the disk as output - by {MegaCli}. - inventory: - All disks are automatically inventorized. The current state is - taken as the target state. + One service is created for each found disk. diff --git a/checks/megaraid_pdisks b/checks/megaraid_pdisks index 9ffcd7a..61b3937 100644 --- a/checks/megaraid_pdisks +++ b/checks/megaraid_pdisks @@ -86,7 +86,7 @@ def megaraid_pdisks_parse(info): elif line[0] == "Slot": slot = int(line[-1]) elif line[0] == "Firmware" and line[1] == "state:": - state = line[2] + state = line[2].rstrip(',') elif line[0] == "Inquiry" and line[1] == "Data:": name = " ".join(line[2:]) #Adapter, Enclosure, Encolsure Device ID, Slot, State, Name @@ -96,31 +96,31 @@ def megaraid_pdisks_parse(info): return return_var - def inventory_megaraid_pdisks(info): - info = megaraid_pdisks_parse(info) inventory = [] for adapter, enclosure, enc_dev_id, slot, state, name in info: - inventory.append(("%s%s/%s" % (adapter, enclosure, slot), repr(state))) + inventory.append(("%s%s/%s" % (adapter, enclosure, slot), None)) return inventory -def check_megaraid_pdisks(item, target_state, info): +megaraid_pdisks_states = { + 'Online' : 0, + 'Hotspare' : 0, + 'Failed' : 2, +} + +def check_megaraid_pdisks(item, _no_params, info): info = megaraid_pdisks_parse(info) for adapter, enclosure, enc_dev_id, slot, state, name in info: if "%s%s/%s" % (adapter, enclosure, slot) == item: - infotext = "%s (%s)" % (state, name) - if state == target_state: - return (0, infotext) - else: - return (2, infotext) - return (3, "No disk in encl/slot %s found" % item) - + print state + return megaraid_pdisks_states.get(state, 3), "%s (%s)" % (state, name) + return 3, "No disk in encl/slot %s found" % item check_info["megaraid_pdisks"] = { 'check_function': check_megaraid_pdisks, 'inventory_function': inventory_megaraid_pdisks, 'service_description': 'RAID PDisk Adapt/Enc/Sl %s', - 'has_perfdata': True, + 'has_perfdata': False, 'group': 'raid_disk', }

9 years, 11 months

Check_MK Git: check_mk: Views snapin: Fixed order of default topics

by Lars Michelsen

Module: check_mk Branch: master Commit: 836a0d41fee023d97a4f3c4decc72ab1cfcd40d0 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=836a0d41fee023… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Dec 4 16:13:03 2014 +0100 Views snapin: Fixed order of default topics --- web/plugins/sidebar/shipped.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/plugins/sidebar/shipped.py b/web/plugins/sidebar/shipped.py index 210e2ab..d9d10f9 100644 --- a/web/plugins/sidebar/shipped.py +++ b/web/plugins/sidebar/shipped.py @@ -68,7 +68,7 @@ sidebar_snapins["about"] = { # -------------------------------------------------------------- def visuals_by_topic(permitted_visuals, - default_order = [ _("Overview"), _("Hosts"), _("Hostgroups"), _("Services"), _("Servicegroups"), + default_order = [ _("Overview"), _("Hosts"), _("Host Groups"), _("Services"), _("Service Groups"), _("Business Intelligence"), _("Problems"), _("Addons") ]): s = [ (_u(visual.get("topic") or _("Other")), _u(visual.get("title")), name, 'painters' in visual) for name, visual

9 years, 11 months

Check_MK Git: check_mk: #1651 FIX Consolidated painters of service list views

by Lars Michelsen

Module: check_mk Branch: master Commit: 82afff89b1719b6268141e5244a404ba59de6262 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=82afff89b1719b… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Dec 4 16:34:01 2014 +0100 #1651 FIX Consolidated painters of service list views The painters (columns) of views which are listing multiple services were using different orders of the painters. We consolidatet the columns now to have a better consistent feeling. --- .werks/1651 | 11 ++++ ChangeLog | 1 + web/plugins/views/builtin.py | 134 ++++++++++-------------------------------- 3 files changed, 43 insertions(+), 103 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=82afff89b1…

9 years, 11 months

Check_MK Git: check_mk: #1652 FIX kaspersky_av_quarantine:

by Lars Michelsen

Fixed exception when a file was found in quarantine Message-ID: <54808aa7.lwlPUF6ECSjAd9/W%lm(a)mathias-kettner.de> User-Agent: Heirloom mailx 12.5 6/20/10 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Module: check_mk Branch: master Commit: 35210c8112ae9ff6c3f54137914aeb66febda8b3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=35210c8112ae9f… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Dec 4 16:46:08 2014 +0100 #1652 FIX kaspersky_av_quarantine: Fixed exception when a file was found in quarantine --- .werks/1652 | 9 +++++++++ ChangeLog | 1 + checks/kaspersky_av_quarantine | 15 ++++++++------- 3 files changed, 18 insertions(+), 7 deletions(-) diff --git a/.werks/1652 b/.werks/1652 new file mode 100644 index 0000000..937a50a --- /dev/null +++ b/.werks/1652 @@ -0,0 +1,9 @@ +Title: kaspersky_av_quarantine: Fixed exception when a file was found in quarantine +Level: 1 +Component: checks +Compatible: compat +Version: 1.2.5i7 +Date: 1417707947 +Class: fix + + diff --git a/ChangeLog b/ChangeLog index 0ff736b..58745f3 100644 --- a/ChangeLog +++ b/ChangeLog @@ -103,6 +103,7 @@ * 1647 FIX: agent_ipmi: Check_MK service gets critical now when ipmi-sensors command fails * 1453 FIX: drbd.stats: tried to send non-numeric write order parameter to rrd... * 1598 FIX: bluecat_dhcp: Check is not longer found in inventory if dhcp service is not activated + * 1652 FIX: kaspersky_av_quarantine: Fixed exception when a file was found in quarantine Multisite: * 1508 Allow input of plugin output and perfdata when faking check results... diff --git a/checks/kaspersky_av_quarantine b/checks/kaspersky_av_quarantine index eca9360..1289a59 100644 --- a/checks/kaspersky_av_quarantine +++ b/checks/kaspersky_av_quarantine @@ -25,21 +25,22 @@ # Boston, MA 02110-1301 USA. # Example output from agent: -#<<<kaspersky_quarantine:sep(58)>>> -#Quarantine/backup statistics: -# Objects: 0 -# Size: 0 -# Last added: unknown +# <<<kaspersky_av_quarantine:sep(58)>>> +# Quarantine/backup statistics: +# Objects: 0 +# Size: 0 +# Last added: unknown def inventory_kaspersky_av_quarantine(info): return [( None, None )] def check_kaspersky_av_quarantine(item, _no_params, info): - info = dict(info) + # Reformat info when some lines have more than 2 elements + info = dict([ [l[0], ' '.join(l[1:])] for l in info ]) objects = int(info['Objects']) perf = [ ( 'objects', objects ) ] if objects > 0: - return 2, " %d Objects in Quarantine. Last added: %s" % ( objects, info['Last added'].strip() ), perf + return 2, "%d Objects in Quarantine, Last added: %s" % (objects, info['Last added'].strip()), perf return 0, "No objects in Quarantine", perf check_info["kaspersky_av_quarantine"] = {

9 years, 11 months

Check_MK Git: check_mk: Reserved 20 Werk IDS

by Andreas Boesl

Module: check_mk Branch: master Commit: 9fdacb54bf40fb28372b753e34c59b4954c47b54 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=9fdacb54bf40fb… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Thu Dec 4 17:08:54 2014 +0100 Reserved 20 Werk IDS --- .werks/first_free | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.werks/first_free b/.werks/first_free index af2b5c5..9b53651 100644 --- a/.werks/first_free +++ b/.werks/first_free @@ -1 +1 @@ -1657 +1677

9 years, 11 months

Check_MK Git: check_mk: carel_sensors: new scan function to detect older devices as well

by Goetz Golla

Module: check_mk Branch: master Commit: e242bf891e059ee53af23a98e340d42138cb9aef URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e242bf891e059e… Author: Goetz Golla <gg(a)mathias-kettner.de> Date: Thu Dec 4 16:33:52 2014 +0100 carel_sensors: new scan function to detect older devices as well --- checks/carel_sensors | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/checks/carel_sensors b/checks/carel_sensors index 043958d..6a8c8b0 100644 --- a/checks/carel_sensors +++ b/checks/carel_sensors @@ -89,7 +89,6 @@ def inventory_carel_sensors_temp(parsed): def check_carel_sensors_temp(item, params, parsed): return check_temperature(parsed["temp"][item], params) - check_info["carel_sensors"] = { "parse_function" : carel_sensors_parse, "inventory_function" : inventory_carel_sensors_temp, @@ -98,6 +97,9 @@ check_info["carel_sensors"] = { "group" : "room_temperature", "has_perfdata" : True, "snmp_info" : ( ".1.3.6.1.4.1.9839.2.1", [ OID_END, "2" ] ), - "snmp_scan_function" : lambda oid: "pCO" in oid(".1.3.6.1.2.1.1.1.0"), + "snmp_scan_function" : lambda oid: ( "pCO" in oid(".1.3.6.1.2.1.1.1.0") or \ + oid(".1.3.6.1.2.1.1.1.0").endswith("armv4l") + ) and \ + oid(".1.3.6.1.4.1.9839.1.1.0") , "includes" : [ "temperature.include" ], }

9 years, 11 months

Check_MK Git: check_mk: #1635 FIX multipath: fix parsing output of multipath on RedHat6 with space in alias

by Mathias Kettner

Module: check_mk Branch: master Commit: 2f855a9606a788402e39002c570bbd4b1b641d7b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2f855a9606a788… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Dec 4 16:22:00 2014 +0100 #1635 FIX multipath: fix parsing output of multipath on RedHat6 with space in alias --- .werks/1635 | 9 +++++++++ ChangeLog | 1 + checks/multipath | 16 ++++++++++++++-- 3 files changed, 24 insertions(+), 2 deletions(-) diff --git a/.werks/1635 b/.werks/1635 new file mode 100644 index 0000000..b0188eb --- /dev/null +++ b/.werks/1635 @@ -0,0 +1,9 @@ +Title: multipath: fix parsing output of multipath on RedHat6 with space in alias +Level: 1 +Component: checks +Compatible: compat +Version: 1.2.5i7 +Date: 1417706487 +Class: fix + + diff --git a/ChangeLog b/ChangeLog index 20dd62c..a2b3f32 100644 --- a/ChangeLog +++ b/ChangeLog @@ -101,6 +101,7 @@ * 1647 FIX: agent_ipmi: Check_MK service gets critical now when ipmi-sensors command fails * 1453 FIX: drbd.stats: tried to send non-numeric write order parameter to rrd... * 1598 FIX: bluecat_dhcp: Check is not longer found in inventory if dhcp service is not activated + * 1635 FIX: multipath: fix parsing output of multipath on RedHat6 with space in alias Multisite: * 1508 Allow input of plugin output and perfdata when faking check results... diff --git a/checks/multipath b/checks/multipath index 667042a..7aab5f9 100644 --- a/checks/multipath +++ b/checks/multipath @@ -130,6 +130,18 @@ inventory_multipath_rules = [] # \_ round-robin 0 [prio=-1][enabled] # \_ 4:0:0:11 sdt 65:48 [active][undef] +# This one here is from RedHat 6. Very creative... +# 1IET 00010001 dm-4 IET,VIRTUAL-DISK +# size=200G features='0' hwhandler='0' wp=rw +# |-+- policy='round-robin 0' prio=0 status=active +# | `- 23:0:0:1 sdk 8:160 active undef running +# |-+- policy='round-robin 0' prio=0 status=enabled +# | `- 21:0:0:1 sdj 8:144 active undef running +# |-+- policy='round-robin 0' prio=0 status=enabled +# | `- 22:0:0:1 sdg 8:96 active undef running +# `-+- policy='round-robin 0' prio=0 status=enabled +# `- 20:0:0:1 sdi 8:128 active undef running + # And a completely new situation: # <<<multipath>>> # Nov 05 17:17:03 | DM multipath kernel driver not loaded @@ -148,11 +160,11 @@ def parse_multipath(info): # 2: matched regex-group id of alias (optional) reg_headers = [ (get_regex(r"^[0-9a-z]{33}$"), 0, None), # 1. (should be included in 3.) - (get_regex(r"^([^\s]+)\s$([0-9A-Za-z_-]+)$"), 2, 1), # 2. + (get_regex(r"^([^\s]+)\s$([0-9A-Za-z_-]+)$"), 2, 1), # 2. (get_regex(r"^[a-zA-Z0-9_]+$"), 0, None), # 3. (get_regex(r"^([0-9a-z]{33}|[0-9a-z]{49})\s?dm.+$"), 1, None), # 4. (get_regex(r"^[a-zA-Z0-9_]+dm-.+$"), 0, None), # 5. Remove this line in 1.2.0 - (get_regex(r"^([a-zA-Z0-9_-]+)\s?dm-.+$"), 1, None), # 6. and 7. + (get_regex(r"^([-a-zA-Z0-9_ ]+)\s?dm-[0-9]+.*$"), 1, None), # 6. and 7. ] reg_prio = get_regex("[[ ]prio=")

9 years, 11 months

Check_MK Git: check_mk: #1634 FIX Fix editing of cluster hosts in WATO: cluster-property no longer goes lost

by Mathias Kettner

Module: check_mk Branch: master Commit: ff3f09526f6fde567ecfc01b56dfc4fcbd424a1c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ff3f09526f6fde… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Dec 4 15:59:30 2014 +0100 #1634 FIX Fix editing of cluster hosts in WATO: cluster-property no longer goes lost When editing a cluster host in WATO the list of nodes (and thereore the cluster property) got list. This bug was probably introduced while creating the new WATO webservice. This has been fixed. --- .werks/1634 | 11 +++++++++++ ChangeLog | 7 ++++--- web/htdocs/wato.py | 6 +++++- 3 files changed, 20 insertions(+), 4 deletions(-) diff --git a/.werks/1634 b/.werks/1634 new file mode 100644 index 0000000..f60c99a --- /dev/null +++ b/.werks/1634 @@ -0,0 +1,11 @@ +Title: Fix editing of cluster hosts in WATO: cluster-property no longer goes lost +Level: 2 +Component: wato +Compatible: compat +Version: 1.2.5i7 +Date: 1417705023 +Class: fix + +When editing a cluster host in WATO the list of nodes (and thereore the cluster +property) got list. This bug was probably introduced while creating the new WATO +webservice. This has been fixed. diff --git a/ChangeLog b/ChangeLog index 800838e..20dd62c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -48,11 +48,11 @@ * 1616 drbd: Added support for Ahead/Behind cluster states (DRBD >= 8.3.10) * 1626 Renamed service descriptions of filesystem, process and logwatch checks... * 1627 megaraid_ldisks: Warn if current cache or write policy differs from logical drive default policy... - * 1597 bluecat_dhcp, bluecat_dns: Checks can now be used in Check_MK Cluster Mode * 1629 check_mk_agent.freebsd: several new features and improvements, now only use statgrab... * 1630 smart: update in plugin that also outputs information about disks attached to a MegaRAID controller... * 1631 juniper_bgp_state: check now detects and supports more differen device models... * 1645 Added basic kernel section to FreeBSD agent... + * 1597 bluecat_dhcp, bluecat_dns: Checks can now be used in Check_MK Cluster Mode * 1478 FIX: kernel.util, statgrab_cpu: fix computation of utilization... * 1480 FIX: brocade_vdx_status: disable check on some devices that do not support it... * 1485 FIX: dell_om_disks, dell_om_esmlog, dell_om_mem, dell_om_processors, dell_om_sensors: detect more devices... @@ -95,12 +95,12 @@ * 1617 FIX: lnx_if: Deal with data provided by cluster host * 1618 FIX: ad_replication: Output of timeLastSuccess and timeLastFailure was inverted... * 1623 FIX: hp_proliant_mem: support for some yet unhandled status situations - * 1598 FIX: bluecat_dhcp: Check is not longer found in inventory if dhcp service is not activated * 1640 FIX: check_jolokia_metrics_serv_req: Fixed wrong levels shown for upper thresholds - * 1453 FIX: drbd.stats: tried to send non-numeric write order parameter to rrd... * 1632 FIX: hr_fs: remove ugly "mounted on:" information appearing on Juniper devices * 1646 FIX: hyperv_vms: Plugin garbles following plugin output when no VMs exist... * 1647 FIX: agent_ipmi: Check_MK service gets critical now when ipmi-sensors command fails + * 1453 FIX: drbd.stats: tried to send non-numeric write order parameter to rrd... + * 1598 FIX: bluecat_dhcp: Check is not longer found in inventory if dhcp service is not activated Multisite: * 1508 Allow input of plugin output and perfdata when faking check results... @@ -183,6 +183,7 @@ * 1637 FIX: Fixed exception in notification analysis when notifications have not NOTIFICATIONTYPE set * 1639 FIX: Interfaces with speed more than 10GBit/s can now be configured correctly * 1633 FIX: Fix problem that attributes of new WATO folders have not been saved... + * 1634 FIX: Fix editing of cluster hosts in WATO: cluster-property no longer goes lost... Notifications: * 1512 Bulk notification can now be grouped according to custom macro values... diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index c213df8..5563842 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -17474,7 +17474,11 @@ def update_hosts_in_folder(folder, hosts): updated_hosts = {} for hostname, attributes in hosts.items(): - cleaned_attr = dict([(k, v) for (k, v) in attributes.get("set", {}).iteritems() if not k.startswith('.') ]) + cleaned_attr = dict([ + (k, v) for + (k, v) in + attributes.get("set", {}).iteritems() + if (not k.startswith('.') or k == ".nodes") ]) # unset keys for key in attributes.get("unset", []): if key in cleaned_attr:

9 years, 11 months

Check_MK Git: check_mk: #1633 FIX Fix problem that attributes of new WATO folders have not been saved

by Mathias Kettner

Module: check_mk Branch: master Commit: ea09ae0948c8bbb8a1d66ff2accbae67764aa25a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ea09ae0948c8bb… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Dec 4 15:43:28 2014 +0100 #1633 FIX Fix problem that attributes of new WATO folders have not been saved When you created a new folder then only its name and title would be saved, not any further attributes. This problem seems to exist from the very beginning of WATO but nobody noticed... --- .werks/1633 | 11 +++++++++++ ChangeLog | 1 + web/htdocs/wato.py | 5 ++++- 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/.werks/1633 b/.werks/1633 new file mode 100644 index 0000000..ffbf275 --- /dev/null +++ b/.werks/1633 @@ -0,0 +1,11 @@ +Title: Fix problem that attributes of new WATO folders have not been saved +Level: 2 +Component: wato +Compatible: compat +Version: 1.2.5i7 +Date: 1417704150 +Class: fix + +When you created a new folder then only its name and title would be saved, +not any further attributes. This problem seems to exist from the very +beginning of WATO but nobody noticed... diff --git a/ChangeLog b/ChangeLog index dbae9ed..26b41ab 100644 --- a/ChangeLog +++ b/ChangeLog @@ -178,6 +178,7 @@ * 1625 FIX: Safely handle characters that have a special meaning in regexes when creating service-specific rules... * 1637 FIX: Fixed exception in notification analysis when notifications have not NOTIFICATIONTYPE set * 1639 FIX: Interfaces with speed more than 10GBit/s can now be configured correctly + * 1633 FIX: Fix problem that attributes of new WATO folders have not been saved... Notifications: * 1512 Bulk notification can now be grouped according to custom macro values... diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index 76ff350..c213df8 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -1804,8 +1804,11 @@ def mode_editfolder(phase, new): if new: check_folder_permissions(g_folder, "write") check_user_contactgroups(attributes.get("contactgroups", (False, []))) - create_wato_folder(g_folder, name, title) + g_folder["attributes"] = attributes + save_folder(g_folder) + log_audit(g_folder, "new-folder", _("Created new folder %s") % title) + else: # TODO: migrate this block into own function edit_wato_folder(..) cgs_changed = get_folder_cgconf_from_attributes(attributes) != \

9 years, 11 months

← Newer
1
...
32
33
34
35
36
37
38
...
52
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits December 2014