Checkmk git commits December 2014

checkmk-commits@lists.checkmk.com

6 participants
519 discussions

Check_MK Git: check_mk: mk_sap: Fixed syntax error

by Lars Michelsen

Module: check_mk Branch: master Commit: dd5cef1a8e71e3df17897aa8c66141087f5a08e5 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=dd5cef1a8e71e3… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Dec 10 08:27:10 2014 +0100 mk_sap: Fixed syntax error --- agents/plugins/mk_sap | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/agents/plugins/mk_sap b/agents/plugins/mk_sap index dfd1ef9..2d46d75 100755 --- a/agents/plugins/mk_sap +++ b/agents/plugins/mk_sap @@ -108,8 +108,8 @@ SKIP_MTCLASSES = [ MTE_LONG_TXT, ] -MK_CONFDIR = os.getenv("MK_CONFDIR)" or "/etc/check_mk" -MK_VARDIR = os.getenv("MK_VARDIR)" or "/var/lib/check_mk" +MK_CONFDIR = os.getenv("MK_CONFDIR") or "/etc/check_mk" +MK_VARDIR = os.getenv("MK_VARDIR") or "/var/lib/check_mk" STATE_FILE = MK_VARDIR + '/sap.state' state_file_changed = False

9 years, 9 months

Check_MK Git: check_mk: Updated bug entries #2168

by Andreas Boesl

Module: check_mk Branch: master Commit: 155c603c537b5137cfe52214e5190f23ebf866b4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=155c603c537b51… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Wed Dec 10 14:42:34 2014 +0100 Updated bug entries #2168 --- .bugs/2168 | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/.bugs/2168 b/.bugs/2168 new file mode 100644 index 0000000..34a9646 --- /dev/null +++ b/.bugs/2168 @@ -0,0 +1,36 @@ +Title: Custom-Sorter for Service Descriptions +Component: multisite +State: open +Date: 2014-12-10 14:36:33 +Targetversion: future +Class: phantasm + +Implement a sorter which can accomplish this: + +TEMP Unit1 +TEMP Unit2 +TEMP Unit3 +PSU Unit1 +PSU Unit2 +PSU Unit3 +FAN Unit1 +FAN Unit2 +FAN Unit3 + +can be sorted like this + +TEMP Unit1 +PSU Unit1 +FAN Unit1 +TEMP Unit2 +PSU Unit2 +FAN Unit2 +TEMP Unit3 +PSU Unit3 +FAN Unit3 + +Howto: +Split service description at keyword, exchange elements, resort table + +Feature is configurable via display options. +Maybe highlight service blocks of the same unit.

9 years, 9 months

Check_MK Git: check_mk: Updated bug entries #2265

by Mathias Kettner

Module: check_mk Branch: master Commit: e1f37292c4fd6d3e70bb2973979f7a9df70a8d1f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e1f37292c4fd6d… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Dec 10 11:00:56 2014 +0100 Updated bug entries #2265 --- .bugs/2265 | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/.bugs/2265 b/.bugs/2265 new file mode 100644 index 0000000..a041f7e --- /dev/null +++ b/.bugs/2265 @@ -0,0 +1,17 @@ +Title: Preserve files in OMD tmpfs during reboot or update +Component: core +State: open +Date: 2014-12-10 09:51:47 +Targetversion: 1.2.5i1 +Class: todo + +When unmounting the tmpfs of an OMD site would should create a tarball +of tmp, without tmp/run. Before this we need to do some cleanup things: + +- Nobody must have PID files or sockets in other place than tmp/run + (fix apache and rrdcached) +- Create *all* directories already via skel (e.g. tmp/check_mk/piggyback + is missing here) + +When later mounting the tmpfs populate it from skel as usual and then +extract all files from the tarball that match *existing* directories.

9 years, 9 months

Check_MK Git: check_mk: Updated bug entries #2278, #2279

by Bastian Kuhn

Module: check_mk Branch: master Commit: e81468bfda92eba16e64ec4797f49b5c14752274 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e81468bfda92eb… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Wed Dec 10 10:37:04 2014 +0100 Updated bug entries #2278, #2279 --- .bugs/2278 | 8 ++++++++ .bugs/2279 | 7 +++++++ 2 files changed, 15 insertions(+) diff --git a/.bugs/2278 b/.bugs/2278 new file mode 100644 index 0000000..dc54425 --- /dev/null +++ b/.bugs/2278 @@ -0,0 +1,8 @@ +Title: Icon /images/icon_view.png is missing +Component: multisite +State: open +Date: 2014-12-10 10:35:11 +Targetversion: 1.2.5i1 +Class: bug + +The Context button icon in e.g. list of dashboards diff --git a/.bugs/2279 b/.bugs/2279 new file mode 100644 index 0000000..d1074d8 --- /dev/null +++ b/.bugs/2279 @@ -0,0 +1,7 @@ +Title: Dashboards: No Umlauts possible in static text dashlet +Component: multisite +State: open +Date: 2014-12-10 10:36:27 +Targetversion: 1.2.5i1 +Class: bug +

9 years, 9 months

Check_MK Git: check_mk: Updated bug entries #2277

by Bastian Kuhn

Module: check_mk Branch: master Commit: 808312a0a1325d2fdf70cd933dd3dac8e38bb51b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=808312a0a1325d… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Wed Dec 10 09:59:27 2014 +0100 Updated bug entries #2277 --- .bugs/2277 | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/.bugs/2277 b/.bugs/2277 new file mode 100644 index 0000000..eabbd87 --- /dev/null +++ b/.bugs/2277 @@ -0,0 +1,14 @@ +Title: It's not possible to edit a dashlet anymore +Component: checks +State: open +Date: 2014-12-10 09:57:05 +Targetversion: 1.2.5i1 +Class: bug + +Clicking the edit button for a dashlet and saving the formular after leads to the following error: +Internal error:: local variable 'action' referenced before assignment (Retry with debug mode) + +and then you get the following error when trying to open the view again: + + +Missing needed host parameter. ( Sorry the dasboard not view )

9 years, 9 months

Check_MK Git: check_mk: Updated bug entries #2276

by Bastian Kuhn

Module: check_mk Branch: master Commit: a8d07666afa0b592acf3c062e0eff3ec6edeb7de URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a8d07666afa0b5… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Wed Dec 10 09:55:16 2014 +0100 Updated bug entries #2276 --- .bugs/2276 | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.bugs/2276 b/.bugs/2276 new file mode 100644 index 0000000..da27363 --- /dev/null +++ b/.bugs/2276 @@ -0,0 +1,8 @@ +Title: It's not possible to add Views to dasbboards etc. anymore +Component: multisite +State: open +Date: 2014-12-10 09:54:19 +Targetversion: 1.2.5i1 +Class: bug + +The Dialog doesn't appear. Just for PNP Graphs it still works

9 years, 9 months

Check_MK Git: check_mk: #1752 FIX win_exefiles: handle case gracefully where no size information is available

by Mathias Kettner

Module: check_mk Branch: master Commit: a70fb6da67aa03cb995a36ea61713360ce636166 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a70fb6da67aa03… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Dec 9 17:32:06 2014 +0100 #1752 FIX win_exefiles: handle case gracefully where no size information is available --- .werks/1752 | 9 +++++++++ ChangeLog | 1 + inventory/win_exefiles | 2 +- 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/.werks/1752 b/.werks/1752 new file mode 100644 index 0000000..aa0cf01 --- /dev/null +++ b/.werks/1752 @@ -0,0 +1,9 @@ +Title: win_exefiles: handle case gracefully where no size information is available +Level: 1 +Component: inv +Compatible: compat +Version: 1.2.5i7 +Date: 1418142708 +Class: fix + + diff --git a/ChangeLog b/ChangeLog index b21a2c7..7fd6fe9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -301,6 +301,7 @@ * 1452 Solaris HW/SW-Inventory added... * 1547 FIX: win_cpuinfo: fix case where NumberOfCores is missing (Windows 2003)... * 1552 FIX: mk_inventory.ps1: fix garbled or missing entries by removing bogus binary zeroes... + * 1752 FIX: win_exefiles: handle case gracefully where no size information is available inventory: * 1516 FIX: win_disks: fix exception in case of empty signature diff --git a/inventory/win_exefiles b/inventory/win_exefiles index 5a67862..6d277c2 100644 --- a/inventory/win_exefiles +++ b/inventory/win_exefiles @@ -46,7 +46,7 @@ def inv_win_exefiles(info): "path" : "\\".join(parts[:-1]), "package_type" : "exe", "install_date" : install_date, - "size" : int(size), + "size" : saveint(size), "version" : product_version, "summary" : description, "vendor" : product_name,

9 years, 9 months

Check_MK Git: check_mk: #1753 FIX win_bios: handle case with colons in BIOS version

by Mathias Kettner

Module: check_mk Branch: master Commit: 0ec4c0389fc5627e522ca812b29406bbbd1d98c1 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=0ec4c0389fc562… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Dec 9 17:34:51 2014 +0100 #1753 FIX win_bios: handle case with colons in BIOS version --- .werks/1753 | 9 +++++++++ ChangeLog | 1 + inventory/win_bios | 7 ++++++- 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/.werks/1753 b/.werks/1753 new file mode 100644 index 0000000..4d84a21 --- /dev/null +++ b/.werks/1753 @@ -0,0 +1,9 @@ +Title: win_bios: handle case with colons in BIOS version +Level: 1 +Component: inv +Compatible: compat +Version: 1.2.5i7 +Date: 1418142876 +Class: fix + + diff --git a/ChangeLog b/ChangeLog index 7fd6fe9..d4f200b 100644 --- a/ChangeLog +++ b/ChangeLog @@ -302,6 +302,7 @@ * 1547 FIX: win_cpuinfo: fix case where NumberOfCores is missing (Windows 2003)... * 1552 FIX: mk_inventory.ps1: fix garbled or missing entries by removing bogus binary zeroes... * 1752 FIX: win_exefiles: handle case gracefully where no size information is available + * 1753 FIX: win_bios: handle case with colons in BIOS version inventory: * 1516 FIX: win_disks: fix exception in case of empty signature diff --git a/inventory/win_bios b/inventory/win_bios index c346878..ac199a7 100644 --- a/inventory/win_bios +++ b/inventory/win_bios @@ -40,7 +40,12 @@ def inv_win_bios(info): node = inv_tree("hardware.bios.") smbios_version = "" bios_version = "" - for varname, value in info: + for line in info: + # Separator : seams not ideal. Some systems have : in the BIOS version + if len(line) > 2: + line = [ line[0], ":".join(line[1:]) ] + varname, value = line + varname = re.sub(" *","", varname) value = re.sub("^ ", "", value) if varname == "BIOSVersion":

9 years, 9 months

Check_MK Git: check_mk: #1751 FIX winperf_ts_sessions: try to fix invalid number of active and inactive sessions

by Mathias Kettner

Module: check_mk Branch: master Commit: 8b29f838047e0f7dd6c383f8d4c431372b9504b7 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8b29f838047e0f… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Dec 9 17:24:42 2014 +0100 #1751 FIX winperf_ts_sessions: try to fix invalid number of active and inactive sessions M$ seems to have changed the order of the performance counters in newer OS versions (horray!). We try to compensate for that by doing some computations. --- .werks/1751 | 10 ++++++++++ ChangeLog | 1 + checkman/winperf_ts_sessions | 4 ++-- checks/winperf_ts_sessions | 12 +++++++++--- 4 files changed, 22 insertions(+), 5 deletions(-) diff --git a/.werks/1751 b/.werks/1751 new file mode 100644 index 0000000..45ca05a --- /dev/null +++ b/.werks/1751 @@ -0,0 +1,10 @@ +Title: winperf_ts_sessions: try to fix invalid number of active and inactive sessions +Level: 1 +Component: checks +Compatible: compat +Version: 1.2.5i7 +Date: 1418142192 +Class: fix + +M$ seems to have changed the order of the performance counters in newer OS versions +(horray!). We try to compensate for that by doing some computations. diff --git a/ChangeLog b/ChangeLog index ee57b1f..b21a2c7 100644 --- a/ChangeLog +++ b/ChangeLog @@ -158,6 +158,7 @@ * 1736 FIX: lparstat_aix: Trying to deal with more kind of lparstat output... * 1737 FIX: mk_sap: Working around garbled SAP state file when multiple instances were running parallel * 1738 FIX: oracle_instance: Be compatible to old oracle agent outputs + * 1751 FIX: winperf_ts_sessions: try to fix invalid number of active and inactive sessions... Multisite: * 1508 Allow input of plugin output and perfdata when faking check results... diff --git a/checkman/winperf_ts_sessions b/checkman/winperf_ts_sessions index f55db18..e2d10eb 100644 --- a/checkman/winperf_ts_sessions +++ b/checkman/winperf_ts_sessions @@ -8,11 +8,11 @@ description: Server Sessions using the windows performance counters (agent section {<<<winperf_ts_sessions>>>}). - To make this check work, you need to configure the agent via it's .ini + To make this check work, you need to configure the agent via it's <tt>check_mk.ini</tt> file to forward the terminal service session related counters. Take a look at the windows monitoring documentation for details. - It allows to set {WARN} and {CRIT} tresholds on the active and idle session. + It allows to set WARN and CRIT tresholds on the active and idle session. inventory: The check generates service per host. diff --git a/checks/winperf_ts_sessions b/checks/winperf_ts_sessions index 8866f98..a1846bc 100644 --- a/checks/winperf_ts_sessions +++ b/checks/winperf_ts_sessions @@ -27,9 +27,9 @@ # Example output from agent: # <<<winperf_ts_sessions>>> # 1385714515.93 2102 -# 2 1 rawcount -# 4 1 rawcount -# 6 0 rawcount +# 2 20 rawcount +# 4 18 rawcount +# 6 2 rawcount # Counters, relative to the base ID (e.g. 2102) # 2 Total number of Terminal Services sessions. @@ -45,6 +45,12 @@ def check_winperf_ts_sessions(_unused, params, info): return 3, "Performance counters not available" total, active, inactive = [ int(l[1]) for l in info[1:4] ] + # Tom Moore said, that the order of the columns has recently changed + # in newer Windows versions (hooray!) and is now active, inactive, total. + # We try to accomodate for that. + if active + inactive != total: + active, inactive, total = total, active, inactive + state = 0 state_txt = [] for val, key, title in [ (active, 'active', 'Active'),

9 years, 9 months

Check_MK Git: check_mk: #1750 FIX Handle rare cases where SNMP response string begins with a line feed

by Mathias Kettner

Module: check_mk Branch: master Commit: 6f6783023701f2226a79944c7936d5b1b3a56bba URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=6f6783023701f2… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Dec 9 17:09:18 2014 +0100 #1750 FIX Handle rare cases where SNMP response string begins with a line feed The SNMP engine von Check_MK already handled the case correctly that a string contains newlines. But the rare case that it <i>started</i> with a newline was not handled correctly. This has been fixed now. --- .werks/1750 | 11 +++++++++++ ChangeLog | 1 + modules/snmp.py | 2 +- 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/.werks/1750 b/.werks/1750 new file mode 100644 index 0000000..eac8470 --- /dev/null +++ b/.werks/1750 @@ -0,0 +1,11 @@ +Title: Handle rare cases where SNMP response string begins with a line feed +Level: 1 +Component: core +Compatible: compat +Version: 1.2.5i7 +Date: 1418141289 +Class: fix + +The SNMP engine von Check_MK already handled the case correctly that a string +contains newlines. But the rare case that it <i>started</i> with a newline +was not handled correctly. This has been fixed now. diff --git a/ChangeLog b/ChangeLog index b2bae67..40944d3 100644 --- a/ChangeLog +++ b/ChangeLog @@ -14,6 +14,7 @@ * 1628 FIX: Remove trailing backslashes from service descriptions... * 1649 FIX: Check_MK inventory service has been renamed to Check_MK Discovery... * 1706 FIX: Fix file permissions when installing MKPs to 0644 or 0755... + * 1750 FIX: Handle rare cases where SNMP response string begins with a line feed... Checks & Agents: * 1197 climaveneta_temp: New check for temperature sensors on Climaveneta clima devices diff --git a/modules/snmp.py b/modules/snmp.py index d5c0050..c376d06 100644 --- a/modules/snmp.py +++ b/modules/snmp.py @@ -445,7 +445,7 @@ def snmpwalk_on_suboid(hostname, ip, oid, hex_plain = False): or value.startswith('No Such Object available') or value.startswith('No Such Instance currently exists'): continue - if len(value) > 0 and value[0] == '"' and value[-1] != '"': # to be continued + if value == '"' or (len(value) > 1 and value[0] == '"' and (value[-1] != '"')): # to be continued while True: # scan for end of this dataset nextline = line_iter.next().strip() value += " " + nextline

9 years, 9 months

← Newer
1
...
16
17
18
19
20
21
22
...
52
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits December 2014