Checkmk git commits September 2013

checkmk-commits@lists.checkmk.com

6 participants
227 discussions

Check_MK Git: check_mk: Updated bug entries #0971

by Bernd Stroessenreuther

Module: check_mk Branch: master Commit: 54e70b2f9ea1fd90c084a1f7410b49d3a482f63b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=54e70b2f9ea1fd… Author: Bernd Stroessenreuther <bs(a)mathias-kettner.de> Date: Thu Sep 5 14:04:06 2013 +0200 Updated bug entries #0971 --- .bugs/971 | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.bugs/971 b/.bugs/971 index f05e062..0ec00ff 100644 --- a/.bugs/971 +++ b/.bugs/971 @@ -34,3 +34,9 @@ Since there is more than 1 slash in the line, the split will return more than th 2013-09-02 11:45:03: changed state open -> done agent plugin apache_status now also works, if prog name contains slashes + +2013-09-05: User did test, positive: +I've tried the new apache_status plugin on the server where it previously failed and it now seems to work +So good job +On servers that had no issues it still works as before as far as I can see (I've tested it on 3 servers). +

11 years

Check_MK Git: check_mk: esx_vsphere_datastores: now a little bit more tolerant when parsing accessible attribute

by Andreas Boesl

Module: check_mk Branch: master Commit: 562b40518d923a367396453edd45f31d7dd00f10 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=562b40518d923a… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Thu Sep 5 13:01:21 2013 +0200 esx_vsphere_datastores: now a little bit more tolerant when parsing accessible attribute --- checks/esx_vsphere_datastores | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/checks/esx_vsphere_datastores b/checks/esx_vsphere_datastores index 8dec7cb..62efcb5 100644 --- a/checks/esx_vsphere_datastores +++ b/checks/esx_vsphere_datastores @@ -44,7 +44,7 @@ def esx_vsphere_datastores_parse(info): else: key, value = line if key == "accessible": - value = value == "True" + value = value.lower() == "true" elif key in [ "capacity", "freeSpace", "uncommitted" ]: value = int(value) store[key] = value

11 years

Check_MK Git: check_mk: Changed several forms in WATO to POST

by Lars Michelsen

Module: check_mk Branch: master Commit: ee2631cb5286e32c4718b36ce044771b1671ab1f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ee2631cb5286e3… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Sep 5 09:44:04 2013 +0200 Changed several forms in WATO to POST --- ChangeLog | 2 ++ web/htdocs/wato.py | 22 +++++++++++----------- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/ChangeLog b/ChangeLog index fd1e1f2..8fa6364 100644 --- a/ChangeLog +++ b/ChangeLog @@ -165,6 +165,8 @@ * FIX: More consistent handling of folderpath select in rule editor * FIX: Now correctly handling depends_on_tags on page rendering for inherited values + * FIX: Changed several forms from GET to POST to prevent "Request-URI too + large" error messages during submitting forms Notifications: * Flexible Notification can now filter service levels diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index f8b50f0..4fa9eb2 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -1313,7 +1313,7 @@ def show_hosts(folder): html.write("</td></tr>\n") # Show table of hosts in this folder - html.begin_form("hosts", None, "POST") + html.begin_form("hosts", method = "POST") html.write("<table class=data>\n") # Remember if that host has a target folder (i.e. was imported with @@ -1847,7 +1847,7 @@ def mode_editfolder(phase, new): if len(lock_message) > 0: html.write("<div class=info>" + lock_message + "</div>") - html.begin_form("edithost") + html.begin_form("edithost", method = "POST") # title forms.header(_("Title")) @@ -2248,7 +2248,7 @@ def show_service_table(host, firsttime): table.sort() - html.begin_form("checks", None, "POST") + html.begin_form("checks", method = "POST") fixall = 0 if config.may("wato.services"): for entry in table: @@ -2382,7 +2382,7 @@ def mode_search(phase): render_folder_path() ## # Show search form - html.begin_form("edithost") + html.begin_form("edithost", method = "POST") forms.header(_("General Properties")) forms.section(_("Hostname")) html.text_input("host") @@ -2701,7 +2701,7 @@ def mode_bulk_inventory(phase): ) else: - html.begin_form("bulkinventory", None, "POST") + html.begin_form("bulkinventory", method = "POST") html.hidden_fields() # Mode of action @@ -2785,7 +2785,7 @@ def mode_bulk_edit(phase): "hosts share the same setting for this attribute. If you leave that selection, all hosts " "will keep their individual settings.") + "</p>") - html.begin_form("edithost", None, "POST") + html.begin_form("edithost", method = "POST") configure_attributes(False, hosts, "bulk", parent = g_folder) forms.end() html.button("_save", _("Save & Finish")) @@ -2853,7 +2853,7 @@ def mode_bulk_cleanup(phase): "default values.") % len(hostnames)) html.write("</p>") - html.begin_form("bulkcleanup", None, "POST") + html.begin_form("bulkcleanup", method = "POST") forms.header(_("Attributes to remove from hosts")) if not bulk_cleanup_attributes(g_folder, hosts): forms.end() @@ -3073,7 +3073,7 @@ def mode_parentscan(phase): ) else: - html.begin_form("parentscan", None, "POST") + html.begin_form("parentscan", method = "POST") html.hidden_fields() # Mode of action @@ -5280,7 +5280,7 @@ def mode_snapshot(phase): table.end() html.write("<h3>" + _("Restore from uploaded file") + "</h3>") - html.begin_form("upload_form", None, "POST") + html.begin_form("upload_form", method = "POST") html.upload_file("_upload_file") html.button("upload_button", _("Restore from file"), "submit") html.hidden_fields() @@ -9615,7 +9615,7 @@ def mode_edit_hosttag(phase): - html.begin_form("hosttaggroup") + html.begin_form("hosttaggroup", method = 'POST') forms.header(_("Edit group") + (tag_id and " %s" % tag_id or "")) # Tag ID @@ -10337,7 +10337,7 @@ def mode_rulesets(phase): html.write('</div>') def create_new_rule_form(rulespec, hostname = None, item = None, varname = None): - html.begin_form("new_rule", add_transid = False) + html.begin_form("new_rule", add_transid = False, method = "POST") html.write('<table>') if hostname:

11 years

Check_MK Git: check_mk: df helptext updated

by Andreas Boesl

Module: check_mk Branch: master Commit: e9c1c553789cfd158f46e60ca512539be90bdad4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e9c1c553789cfd… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Wed Sep 4 17:35:27 2013 +0200 df helptext updated --- web/plugins/wato/check_parameters.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py index 8d95d6d..0a4f9a0 100644 --- a/web/plugins/wato/check_parameters.py +++ b/web/plugins/wato/check_parameters.py @@ -1498,7 +1498,7 @@ register_check_parameters( TextAscii( title = _("Mount point"), help = _("For Linux/UNIX systems, specify the mount point, for Windows systems " - "the drive letter uppercase followed by a colon, e.g. <tt>C:</tt>"), + "the drive letter uppercase followed by a colon and a slash, e.g. <tt>C:/</tt>"), allow_empty = False), "dict" ) @@ -2604,8 +2604,8 @@ register_check_parameters( title = _("Device"), help = _("For a summarized throughput of all disks, specify <tt>SUMMARY</tt>, for a " "sum of read or write throughput write <tt>read</tt> or <tt>write</tt> resp. " - "A per-disk IO is specified by the drive letter and a colon on Windows " - "(e.g. <tt>C:</tt>) or by the device name on Linux/UNIX (e.g. <tt>/dev/sda</tt>).")), + "A per-disk IO is specified by the drive letter, a colon and a slash on Windows " + "(e.g. <tt>C:/</tt>) or by the device name on Linux/UNIX (e.g. <tt>/dev/sda</tt>).")), "first" )

11 years

Check_MK Git: check_mk: Fixed problem when sidebar_notify_interval is not configured

by Lars Michelsen

Module: check_mk Branch: master Commit: 4342b74e48c757663a3ae7098a3e6681b85ce218 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=4342b74e48c757… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Sep 4 14:43:14 2013 +0200 Fixed problem when sidebar_notify_interval is not configured --- web/htdocs/sidebar.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/htdocs/sidebar.py b/web/htdocs/sidebar.py index b348445..8c1f4fe 100644 --- a/web/htdocs/sidebar.py +++ b/web/htdocs/sidebar.py @@ -176,7 +176,7 @@ def page_side(): if not config.may("general.see_sidebar"): return html.html_head(_("Check_MK Sidebar"), javascripts=["sidebar"], stylesheets=["sidebar", "status"]) - html.write('<body class="side" onload="initScrollPos(); setSidebarHeight(); init_messages(%d);" ' + html.write('<body class="side" onload="initScrollPos(); setSidebarHeight(); init_messages(%s);" ' 'onunload="storeScrollPos()">\n' % config.sidebar_notify_interval or 'null') html.write('<div id="check_mk_sidebar">\n')

11 years

Check_MK Git: check_mk: FIX: cisco_qos: Catch policies without post/ drop byte information

by Lars Michelsen

Module: check_mk Branch: master Commit: 65eaa188ccf2fd897a495d57f7fe46adf9ef43d5 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=65eaa188ccf2fd… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Sep 4 11:43:31 2013 +0200 FIX: cisco_qos: Catch policies without post/drop byte information --- ChangeLog | 1 + checks/cisco_qos | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 2851764..fd1e1f2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -75,6 +75,7 @@ * FIX: hr_mem: handle virtual memory correct on some devices * FIX: apache_status agent plugin: now also works, if prog name contains slashes * FIX: check_dns: parameter -A does not get an additional string + * FIX: cisco_qos: Catch policies without post/drop byte information Notifications: * notify.py: Matching service level: Use the hosts service level if a diff --git a/checks/cisco_qos b/checks/cisco_qos index b12009c..bc26568 100644 --- a/checks/cisco_qos +++ b/checks/cisco_qos @@ -199,8 +199,8 @@ def check_cisco_qos(item, params, info): # to "1" instead of the plicy_if_id policy_id = config[policy_if_id+'.1'] policy_name = policies[policy_id] - post_b = post_bytes[policy_if_id+'.'+policy_if_id2] - drop_b = drop_bytes[policy_if_id+'.'+policy_if_id2] + post_b = post_bytes.get(policy_if_id+'.'+policy_if_id2, 0) + drop_b = drop_bytes.get(policy_if_id+'.'+policy_if_id2, 0) speed = saveint(if_speeds[if_id]) speed_found = False

11 years

Check_MK Git: check_mk: Updated bug entries #1020

by Lars Michelsen

Module: check_mk Branch: master Commit: 5fbfe33f489dddf7c23dde1fd8c0a02b39695664 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5fbfe33f489ddd… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Sep 4 11:30:46 2013 +0200 Updated bug entries #1020 --- .bugs/1020 | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.bugs/1020 b/.bugs/1020 new file mode 100644 index 0000000..1729a53 --- /dev/null +++ b/.bugs/1020 @@ -0,0 +1,12 @@ +Title: cmk --snmpwalk does not always get all oids +Component: core +State: open +Date: 2013-09-04 11:27:53 +Targetversion: 1.2.3 +Class: bug + +In some cases, on somehow broken devices, the cmk --snmpwalk feature does not +get complete results. At the moment it walks the standard OIDs 1.2.6.1.2 and +1.2.6.1.4. + +An option to try to fix this problem is to add the oid returned by .1.3.6.1.2.1.1.2.0 .

11 years

Check_MK Git: check_mk: Updated bug entries #0937

by Andreas Boesl

Module: check_mk Branch: master Commit: 24c14d79f5dbea160cf78fbb6183212932f1815c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=24c14d79f5dbea… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Wed Sep 4 11:31:59 2013 +0200 Updated bug entries #0937 --- .bugs/937 | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.bugs/937 b/.bugs/937 index fcf112b..7d23dae 100644 --- a/.bugs/937 +++ b/.bugs/937 @@ -1,8 +1,11 @@ Title: Availability timerange "Last year" not working Component: multisite -State: open +Class: bug +State: done Date: 2013-09-04 11:23:15 Targetversion: 1.2.3i2 -Class: bug see topic + +2013-09-04 11:31:56: changed state open -> done +Text interpretation problem -> user error :)

11 years

Check_MK Git: check_mk: Updated bug entries #1019

by Lars Michelsen

Module: check_mk Branch: master Commit: fb686f958c896da763a5c6a71df636e4c8617acf URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=fb686f958c896d… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Sep 4 11:24:17 2013 +0200 Updated bug entries #1019 --- .bugs/1019 | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.bugs/1019 b/.bugs/1019 new file mode 100644 index 0000000..a970d1d --- /dev/null +++ b/.bugs/1019 @@ -0,0 +1,10 @@ +Title: Oracle Tablespace Monitoring - TEMP Tablespaces +Component: checks +State: open +Date: 2013-09-04 11:22:25 +Targetversion: 1.4.0 +Class: nastiness + +It is senseless to apply thresholds to TEMP tablespaces in oracle. On startup, the tablespace +is small, but once allocated it grows and grows, but never gets smaller again. So we should +either completely remove those tablespaces or at least disable the thresholds by default.

11 years

Check_MK Git: check_mk: Updated bug entries #0937

by Andreas Boesl

Module: check_mk Branch: master Commit: e6a772ee127ede64a8b83e1ec7befe28bb73a64b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e6a772ee127ede… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Wed Sep 4 11:24:04 2013 +0200 Updated bug entries #0937 --- .bugs/937 | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.bugs/937 b/.bugs/937 new file mode 100644 index 0000000..fcf112b --- /dev/null +++ b/.bugs/937 @@ -0,0 +1,8 @@ +Title: Availability timerange "Last year" not working +Component: multisite +State: open +Date: 2013-09-04 11:23:15 +Targetversion: 1.2.3i2 +Class: bug + +see topic

11 years

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits September 2013