Checkmk git commits July 2013

checkmk-commits@lists.checkmk.com

4 participants
235 discussions

Check_MK Git: check_mk: edit_form: new preview mode

by Mathias Kettner

Module: check_mk Branch: master Commit: 1b7a2ef34b3b921bd4cf9c50b6eb814962c5f484 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1b7a2ef34b3b92… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Jul 30 17:03:57 2013 +0200 edit_form: new preview mode --- web/htdocs/forms.py | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/web/htdocs/forms.py b/web/htdocs/forms.py index 91873ee..78d90ac 100644 --- a/web/htdocs/forms.py +++ b/web/htdocs/forms.py @@ -40,11 +40,17 @@ def get_input(valuespec, varprefix): return value + +# preview = True: Do not output error messages, do not consume +# current transaction. This is for preview mode def edit_dictionary(entries, value, focus=None, hover_help=True, validate=None, buttontext=None, title=None, - buttons = None, method="GET"): + buttons = None, method="GET", preview=False): new_value = value.copy() - if html.var("filled_in") == "form" and html.check_transaction(): + if html.var("filled_in") == "form" and html.transaction_valid(): + if not preview: + html.check_transaction() + messages = [] for name, vs in entries: try: @@ -63,10 +69,14 @@ def edit_dictionary(entries, value, focus=None, hover_help=True, html.add_user_error(e.varname, e.message) if messages: - html.show_error("".join(["%s<br>\n" % m for m in messages])) + if not preview: + html.show_error("".join(["%s<br>\n" % m for m in messages])) + else: + return None else: return new_value + html.begin_form("form", method=method) header(title and title or _("Properties")) first = True

11 years, 2 months

Check_MK Git: check_mk: futher optimizations for manpage catalog

by Bernd Stroessenreuther

Module: check_mk Branch: master Commit: e17642d1c434f6936eeaa50fed11bf4479830efd URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e17642d1c434f6… Author: Bernd Stroessenreuther <bs(a)mathias-kettner.de> Date: Tue Jul 30 14:00:51 2013 +0200 futher optimizations for manpage catalog --- checkman/cisco_hsrp | 2 +- checkman/fortigate_cpu | 2 +- checkman/fortigate_memory | 2 +- checkman/fortigate_sessions | 2 +- checkman/hp_eml_sum | 2 +- checkman/hpux_tunables | 5 +---- checkman/snmp_uptime | 2 +- checkman/vxvm_enclosures | 2 +- checkman/vxvm_multipath | 2 +- checkman/vxvm_objstatus | 2 +- 10 files changed, 10 insertions(+), 13 deletions(-) diff --git a/checkman/cisco_hsrp b/checkman/cisco_hsrp index a777b42..d55b821 100644 --- a/checkman/cisco_hsrp +++ b/checkman/cisco_hsrp @@ -1,4 +1,4 @@ -title: Cisco routers: HSRP group status +title: Cisco Routers: HSRP Group Status agents: snmp catalog: hw/network/cisco license: GPLv3 diff --git a/checkman/fortigate_cpu b/checkman/fortigate_cpu index c2f24be..97a7ab9 100644 --- a/checkman/fortigate_cpu +++ b/checkman/fortigate_cpu @@ -1,4 +1,4 @@ -title: CPU utilization of FortiGate firewalls +title: FortiGate firewalls: CPU utilization agents: snmp catalog: hw/network/fortinet license: GPL diff --git a/checkman/fortigate_memory b/checkman/fortigate_memory index d1d1270..710795e 100644 --- a/checkman/fortigate_memory +++ b/checkman/fortigate_memory @@ -1,4 +1,4 @@ -title: Used RAM on FortiGate firewalls +title: FortiGate firewalls: RAM Usage agents: snmp catalog: hw/network/fortinet license: GPL diff --git a/checkman/fortigate_sessions b/checkman/fortigate_sessions index d7f4ce4..0f2c8b9 100644 --- a/checkman/fortigate_sessions +++ b/checkman/fortigate_sessions @@ -1,4 +1,4 @@ -title: Current number of sessions on FortiGate firewalls +title: FortiGate firewalls: Current Number of Sessions agents: snmp catalog: hw/network/fortinet license: GPL diff --git a/checkman/hp_eml_sum b/checkman/hp_eml_sum index df098db..e47c9ec 100644 --- a/checkman/hp_eml_sum +++ b/checkman/hp_eml_sum @@ -1,4 +1,4 @@ -title: Summary status of HP StorageWorks EML E-Series enterprise tape library +title: HP StorageWorks EML E-Series Enterprise Tape Library: Summary Status agents: snmp catalog: hw/storagehw/hp license: GPL diff --git a/checkman/hpux_tunables b/checkman/hpux_tunables index 3f4ab73..8dd62a2 100644 --- a/checkman/hpux_tunables +++ b/checkman/hpux_tunables @@ -1,4 +1,4 @@ -title: Kernel tunables on HP-UX +title: Kernel tunables agents: hpux catalog: os/kernel license: GPL @@ -22,9 +22,6 @@ description: Number of shared memory segments (semmns) -item: - {None} - inventory: {hpux_tunables} generates one check per host for each of the supported tunables. diff --git a/checkman/snmp_uptime b/checkman/snmp_uptime index 819fc01..fb0ba9a 100644 --- a/checkman/snmp_uptime +++ b/checkman/snmp_uptime @@ -1,6 +1,6 @@ title: Uptime of SNMP hosts agents: snmp -catalog: generic +catalog: os/misc license: GPL distribution: check_mk description: diff --git a/checkman/vxvm_enclosures b/checkman/vxvm_enclosures index 189f14c..0c43122 100644 --- a/checkman/vxvm_enclosures +++ b/checkman/vxvm_enclosures @@ -1,4 +1,4 @@ -title: VxVM Enclosures +title: Veritas VxVM: Enclosures agents: hpux, linux catalog: os/storage license: GPL diff --git a/checkman/vxvm_multipath b/checkman/vxvm_multipath index a5132f0..e2dc1a2 100644 --- a/checkman/vxvm_multipath +++ b/checkman/vxvm_multipath @@ -1,4 +1,4 @@ -title: VxVM Multipath +title: Veritas VxVM: Multipath agents: hpux, linux catalog: os/storage license: GPL diff --git a/checkman/vxvm_objstatus b/checkman/vxvm_objstatus index 78b3c78..6140302 100644 --- a/checkman/vxvm_objstatus +++ b/checkman/vxvm_objstatus @@ -1,4 +1,4 @@ -title: status of objects in VxVM +title: Veritas VxVM: Status of Objects agents: hpux, linux catalog: os/storage license: GPL

11 years, 2 months

Check_MK Git: check_mk: unified capitalization of the name Cisco

by Bernd Stroessenreuther

Module: check_mk Branch: master Commit: 0dd6de0930b8d6f7b77c9384f181962c206ca526 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=0dd6de0930b8d6… Author: Bernd Stroessenreuther <bs(a)mathias-kettner.de> Date: Tue Jul 30 13:41:48 2013 +0200 unified capitalization of the name Cisco --- checkman/aironet_clients | 4 ++-- checkman/aironet_errors | 4 ++-- checkman/cisco_cpu | 4 ++-- checkman/cisco_mem | 2 +- checkman/cisco_power | 4 ++-- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/checkman/aironet_clients b/checkman/aironet_clients index 279f561..e57763c 100644 --- a/checkman/aironet_clients +++ b/checkman/aironet_clients @@ -1,11 +1,11 @@ -title: CISCO Aironet access points: Client status +title: Cisco Aironet access points: Client status agents: snmp catalog: hw/network/cisco license: GPL distribution: check_mk description: This check monitors three aspects of the client status - of an CISCO Aironet access point: the number of clients + of an Cisco Aironet access point: the number of clients logged in, their average signal strength and their average signal quality. You may provide levels for strength and quality. If zero clients are logged in, this check is always OK. diff --git a/checkman/aironet_errors b/checkman/aironet_errors index e4153d2..704fb35 100644 --- a/checkman/aironet_errors +++ b/checkman/aironet_errors @@ -1,11 +1,11 @@ -title: CISCO Aironet access points: CRC errors +title: Cisco Aironet access points: CRC errors agents: snmp catalog: hw/network/cisco license: GPL distribution: check_mk description: This check monitors the rate of CRC errors on MAC level - on each of the radios of an CISCO Aironet access point. + on each of the radios of an Cisco Aironet access point. item: The number of the radio - usually {1} or {2} (integer). diff --git a/checkman/cisco_cpu b/checkman/cisco_cpu index 4bae11b..412ed09 100644 --- a/checkman/cisco_cpu +++ b/checkman/cisco_cpu @@ -4,13 +4,13 @@ catalog: hw/network/cisco license: GPL distribution: check_mk description: - Check CPU utilization of the last 5 minutes in percent on CISCO devices. + Check CPU utilization of the last 5 minutes in percent on Cisco devices. perfdata: Just one value: The CPU utilization of the last 5 minutes in percent. inventory: - One service per CISCO device is created. + One service per Cisco device is created. [parameters] warning (int): The percentage of CPU utilization that triggers a warning level. diff --git a/checkman/cisco_mem b/checkman/cisco_mem index b372091..fe67e5b 100644 --- a/checkman/cisco_mem +++ b/checkman/cisco_mem @@ -4,7 +4,7 @@ catalog: hw/network/cisco license: GPL distribution: check_mk description: - This check monitors the memory usage of CISCO devices. The check distinguises between + This check monitors the memory usage of Cisco devices. The check distinguises between CPU and I/O pool. inventory: diff --git a/checkman/cisco_power b/checkman/cisco_power index bd130db..87c59ba 100644 --- a/checkman/cisco_power +++ b/checkman/cisco_power @@ -1,11 +1,11 @@ -title: CISCO switches: Redundant Power Supplies +title: Cisco switches: Redundant Power Supplies agents: snmp catalog: hw/network/cisco license: GPL distribution: check_mk description: This check monitors the health of redundant power supplies in - CISCO switches. If one of the two power supplies fails, the + Cisco switches. If one of the two power supplies fails, the check returns {CRIT}. item:

11 years, 2 months

Check_MK Git: check_mk: title optimization for manpage catalog

by Bernd Stroessenreuther

11 years, 2 months

Check_MK Git: check_mk: windows agent: bugfix: wait for plugins to finish when caching is disabled

by Andreas Boesl

Module: check_mk Branch: master Commit: 2009441e076893782cbddb45f3a60f64711db683 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2009441e076893… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Tue Jul 30 12:01:32 2013 +0200 windows agent: bugfix: wait for plugins to finish when caching is disabled --- agents/windows/check_mk_agent.cc | 2 +- agents/windows/check_mk_agent.exe | Bin 151040 -> 151040 bytes agents/windows/install_agent.exe | Bin 146432 -> 146572 bytes 3 files changed, 1 insertion(+), 1 deletion(-) diff --git a/agents/windows/check_mk_agent.cc b/agents/windows/check_mk_agent.cc index efeeaf6..16773bf 100755 --- a/agents/windows/check_mk_agent.cc +++ b/agents/windows/check_mk_agent.cc @@ -2410,7 +2410,7 @@ void run_external_programs(char *dirname, script_type type, bool dry_run = false cont, // argument to thread function 0, // use default creation flags NULL); // returns the thread identifier - if (g_caching_method == CACHE_OFF && g_caching_method == CACHE_SYNC) { + if (g_caching_method == CACHE_OFF || g_caching_method == CACHE_SYNC) { crash_log("Thread wait (%s): %s", (g_caching_method == CACHE_OFF ? "CACHE OFF" : "CACHE SYNC"), cont->path); WaitForSingleObject(cont->worker_thread, INFINITE); diff --git a/agents/windows/check_mk_agent.exe b/agents/windows/check_mk_agent.exe index f8a42ac..5204606 100755 Binary files a/agents/windows/check_mk_agent.exe and b/agents/windows/check_mk_agent.exe differ diff --git a/agents/windows/install_agent.exe b/agents/windows/install_agent.exe index 6623c5b..dac059e 100755 Binary files a/agents/windows/install_agent.exe and b/agents/windows/install_agent.exe differ

11 years, 2 months

Check_MK Git: check_mk: last change in esx_vsphere_hostsystem.

by Bernd Stroessenreuther

multipath now represented in the check manpage too Message-ID: <51f783cc.LUZS8z2+1NnxrudS%bs(a)mathias-kettner.de> User-Agent: Heirloom mailx 12.4 7/29/08 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Module: check_mk Branch: master Commit: 2c17e564acfcfed102e6cc200317f862f95ff00d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2c17e564acfcfe… Author: Bernd Stroessenreuther <bs(a)mathias-kettner.de> Date: Tue Jul 30 11:13:43 2013 +0200 last change in esx_vsphere_hostsystem.multipath now represented in the check manpage too --- checkman/esx_vsphere_hostsystem.multipath | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/checkman/esx_vsphere_hostsystem.multipath b/checkman/esx_vsphere_hostsystem.multipath index 428d5a7..2b74cd5 100644 --- a/checkman/esx_vsphere_hostsystem.multipath +++ b/checkman/esx_vsphere_hostsystem.multipath @@ -6,10 +6,10 @@ distribution: check_mk description: This check monitors the state of all Multipath devices on an ESX host system. It returns {CRIT} if at least one - path is dead or in {unknown} state. + path is {dead} or in {unknown} state. It returns {WARN} if at least one path is {disabled}. It also returns - {WARN} if the number of paths in {standby} mode is higher than the - number of {active} paths. + {WARN} if at least one path is in {standby} mode and the number of paths + in {standby} mode is not equal to the number of {active} paths. inventory: One service per multipath device will be created. Paths

11 years, 2 months

Check_MK Git: check_mk: last change in esx_vsphere_hostsystem.

by Bernd Stroessenreuther

multipath now represented in the check manpage too Message-ID: <51f78215.PM7vwcTBwBlBpOfT%bs(a)mathias-kettner.de> User-Agent: Heirloom mailx 12.4 7/29/08 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Module: check_mk Branch: master Commit: 5a29e6a8791114ce8c0e0329ffe5253400d2e2ea URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5a29e6a8791114… Author: Bernd Stroessenreuther <bs(a)mathias-kettner.de> Date: Tue Jul 30 11:06:24 2013 +0200 last change in esx_vsphere_hostsystem.multipath now represented in the check manpage too --- checkman/esx_vsphere_hostsystem.multipath | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/checkman/esx_vsphere_hostsystem.multipath b/checkman/esx_vsphere_hostsystem.multipath index 36079cb..428d5a7 100644 --- a/checkman/esx_vsphere_hostsystem.multipath +++ b/checkman/esx_vsphere_hostsystem.multipath @@ -5,9 +5,11 @@ license: GPL distribution: check_mk description: This check monitors the state of all Multipath devices - on an ESX host system. It gets critical if at least one + on an ESX host system. It returns {CRIT} if at least one path is dead or in {unknown} state. - It gets warning if at least one path is disabled or in standby mode. + It returns {WARN} if at least one path is {disabled}. It also returns + {WARN} if the number of paths in {standby} mode is higher than the + number of {active} paths. inventory: One service per multipath device will be created. Paths

11 years, 2 months

Check_MK Git: check_mk: removed entry agentless again from agents section: was the wrong place

by Bernd Stroessenreuther

Module: check_mk Branch: master Commit: f0339c8eceb372ee970df2877c2a44241d85cc79 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f0339c8eceb372… Author: Bernd Stroessenreuther <bs(a)mathias-kettner.de> Date: Mon Jul 29 17:29:09 2013 +0200 removed entry agentless again from agents section: was the wrong place --- modules/check_mk.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/modules/check_mk.py b/modules/check_mk.py index 5b6a553..e4142c2 100755 --- a/modules/check_mk.py +++ b/modules/check_mk.py @@ -3491,8 +3491,7 @@ def show_check_manual(checkname): agent = agent.strip() ags.append({ "vms" : "VMS", "linux":"Linux", "aix": "AIX", "solaris":"Solaris", "windows":"Windows", "snmp":"SNMP", - "openvms" : "OpenVMS", "vsphere" : "vSphere", - "agentless" : "Networking checks without agent" } + "openvms" : "OpenVMS", "vsphere" : "vSphere" } .get(agent, agent.upper())) print_splitline(header_color_left, "Supported Agents: ", header_color_right, ", ".join(ags)) distro = header['distribution']

11 years, 2 months

Check_MK Git: check_mk: fixed typo in catalog.py

by Bernd Stroessenreuther

Module: check_mk Branch: master Commit: 9260eae2d9c81d4ded0fa2bd40857aa05f2d2901 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=9260eae2d9c81d… Author: Bernd Stroessenreuther <bs(a)mathias-kettner.de> Date: Mon Jul 29 17:17:00 2013 +0200 fixed typo in catalog.py --- modules/catalog.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/catalog.py b/modules/catalog.py index 2ad2daa..4fe9fd0 100644 --- a/modules/catalog.py +++ b/modules/catalog.py @@ -68,7 +68,7 @@ manpage_catalog_titles = { "misc" : "Miscellaneous", "storage" : "Filesystems, Disks and RAID", - "agentless" : "Networking checks without agent" + "agentless" : "Networking checks without agent", "generic" : "Generic check plugins", "unsorted" : "Uncategorized", }

11 years, 2 months

Check_MK Git: check_mk: added description for catalog: agentless

by Bernd Stroessenreuther

Module: check_mk Branch: master Commit: 59516ddc0ade2aca5df4bbcdf9fa31fb15c25889 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=59516ddc0ade2a… Author: Bernd Stroessenreuther <bs(a)mathias-kettner.de> Date: Mon Jul 29 17:12:21 2013 +0200 added description for catalog: agentless --- checkman/check_http | 2 +- modules/catalog.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/checkman/check_http b/checkman/check_http index f956423..5af259c 100644 --- a/checkman/check_http +++ b/checkman/check_http @@ -1,4 +1,4 @@ -title: HTTP/HTTPS connections +title: HTTP/HTTPS connection agents: active catalog: agentless license: GPL diff --git a/modules/catalog.py b/modules/catalog.py index d8e1f6b..2ad2daa 100644 --- a/modules/catalog.py +++ b/modules/catalog.py @@ -68,6 +68,7 @@ manpage_catalog_titles = { "misc" : "Miscellaneous", "storage" : "Filesystems, Disks and RAID", + "agentless" : "Networking checks without agent" "generic" : "Generic check plugins", "unsorted" : "Uncategorized", }

11 years, 2 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits July 2013