Checkmk git commits March 2013

checkmk-commits@lists.checkmk.com

3 participants
209 discussions

Check_MK Git: check_mk: Makefile: fix checks for mingw

by Mathias Kettner

Module: check_mk Branch: master Commit: 9274ab8362555e16d220fb4bc7e8b172b3182ae6 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=9274ab8362555e… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Mar 28 11:58:34 2013 +0100 Makefile: fix checks for mingw --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 7dbce1f..55a333f 100644 --- a/Makefile +++ b/Makefile @@ -133,7 +133,7 @@ version: -o "$$(head -c 12 /etc/issue)" = "Ubuntu 11.04" \ -o "$$(head -c 12 /etc/issue)" = "Ubuntu 11.10" \ -o "$$(head -c 12 /etc/issue)" = "Ubuntu 12.04" \ - -o "$$(head -c 20 /etc/issue)" = "Debian GNU/Linux 6.0" ] \ + -o "$$(head -c 12 /etc/issue)" = "Ubuntu 12.10" ] \ || { echo 'You are not on the reference system!' ; exit 1; } @newversion=$$(dialog --stdout --inputbox "New Version:" 0 0 "$(VERSION)") ; \ if [ -n "$$newversion" ] ; then $(MAKE) NEW_VERSION=$$newversion setversion ; fi

11 years, 3 months

Check_MK Git: check_mk: FIX: make filesystem_default_levels effective in esx_vsphere_datastores

by Mathias Kettner

Module: check_mk Branch: master Commit: 5b007d1cb344ceba5f471bd427371a545db35c26 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5b007d1cb344ce… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Mar 28 09:03:56 2013 +0100 FIX: make filesystem_default_levels effective in esx_vsphere_datastores --- checks/esx_vsphere_datastores | 13 +++++++------ checks/vms_diskstat | 1 + 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/checks/esx_vsphere_datastores b/checks/esx_vsphere_datastores index b621981..695e6d8 100644 --- a/checks/esx_vsphere_datastores +++ b/checks/esx_vsphere_datastores @@ -81,12 +81,13 @@ def check_esx_vsphere_datastores(item, params, info): return state, infotext, perfdata check_info['esx_vsphere_datastores'] = { - "inventory_function" : inventory_esx_vsphere_datastores, - "check_function" : check_esx_vsphere_datastores, - "service_description" : "fs_%s", - "includes" : [ 'df.include' ], - "has_perfdata" : True, - "group" : "filesystem", + "inventory_function" : inventory_esx_vsphere_datastores, + "check_function" : check_esx_vsphere_datastores, + "service_description" : "fs_%s", + "includes" : [ 'df.include' ], + "has_perfdata" : True, + "group" : "filesystem", + "default_levels_variable" : "filesystem_default_levels", } #. diff --git a/checks/vms_diskstat b/checks/vms_diskstat index 32fef75..bf30841 100644 --- a/checks/vms_diskstat +++ b/checks/vms_diskstat @@ -57,4 +57,5 @@ check_info['vms_diskstat.df'] = { "has_perfdata" : True, "group" : "filesystem", "includes" : [ "df.include" ], + "default_levels_variable" : "filesystem_default_levels", }

11 years, 3 months

Check_MK Git: check_mk: agent_vsphere: option for including data of Check_MK Agent

by Mathias Kettner

Module: check_mk Branch: master Commit: 7e7964878a92c73608cf5e91892e131a224bab51 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7e7964878a92c7… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Mar 27 19:50:49 2013 +0100 agent_vsphere: option for including data of Check_MK Agent --- agents/special/agent_vsphere | 68 ++++++++++++++++++++----------- checks/agent_vsphere | 7 ++- modules/check_mk_base.py | 4 +- web/plugins/wato/datasource_programs.py | 5 +- 4 files changed, 53 insertions(+), 31 deletions(-) diff --git a/agents/special/agent_vsphere b/agents/special/agent_vsphere index a9a80ba..815b01c 100755 --- a/agents/special/agent_vsphere +++ b/agents/special/agent_vsphere @@ -26,6 +26,7 @@ import sys import argparse +import socket import inspect, pprint # FOR DEBUGGING @@ -47,6 +48,11 @@ parser.add_argument('-D', '--direct', action="store_true", "we expect data about only one HostSystem to be found and do " "not create piggy host data for that host.") +parser.add_argument('-a', '--agent', action="store_true", + help="Also retrieve data from the normal Check_MK Agent. This makes " + "sense if you query a vCenter that is installed on a Windows " + "host that you also want to monitor with Check_MK.") + parser.add_argument('--debug', action="store_true", help="Debug mode: let Python exceptions come through") @@ -55,13 +61,49 @@ parser.add_argument('HOST', params = vars(parser.parse_args()) +def get_agent_info_tcp(hostname): + output = "" + try: + if hostname[0] in "123456789": + ipaddress = hostname + else: + ipaddress = socket.gethostbyname(hostname) + s = socket.socket(socket.AF_INET, socket.SOCK_STREAM) + try: + s.settimeout(3.0) + except: + pass # some old Python versions lack settimeout(). Better ignore than fail + s.connect((ipaddress, 6556)) + try: + s.setblocking(1) + except: + pass + output = "" + while True: + out = s.recv(4096, socket.MSG_WAITALL) + if out and len(out) > 0: + output += out + else: + break + s.close() + return output + except Exception, e: + if params["debug"]: + raise + return output + +error_exit = 1 +if params['agent']: + sys.stdout.write(get_agent_info_tcp(params["HOST"])) + error_exit = 0 # do not fail if vSphere fails + try: from pysphere import VIServer, VIProperty, MORTypes from pysphere.resources import VimService_services as VI except: sys.stderr.write("pysphere API not found. Please install and try again.\n") - sys.exit(1) + sys.exit(error_exit) host = VIServer() @@ -72,34 +114,12 @@ except: if params['debug']: raise sys.stderr.write("Cannot connect to vSphere Server. May the wrong credentials. Please correct and make a reinventory.\n") - sys.exit(1) + sys.exit(error_exit) print "<<<check_mk>>>" print "Version: %s" % host.get_api_version() print "AgentOs: %s " % host.get_server_type() -# import inspect, pprint -# for x in host._retrieve_properties_traversal(property_names=[], obj_type = MORTypes.ManagedEntity): -# print x.Obj -# print inspect.getmembers(x) -# sys.exit(17) - -# hosts = host.get_hosts() -# pprint.pprint(inspect.getmembers(VIProperty(host, hosts.keys()[0]).hardware)) -# sys.exit(1) - -#for p in VIProperty(host, hosts.keys()[0]).network: - # print host.get_resource_pools(p) - # for n in p: - # pprint.pprint(inspect.getmembers(p)) - -# print p -# print hosts - - -# sys.exit(1) - - def output_mors(what, properties, direct=False): if what == "hostsystem": diff --git a/checks/agent_vsphere b/checks/agent_vsphere index 8b5af0e..6c310e0 100644 --- a/checks/agent_vsphere +++ b/checks/agent_vsphere @@ -35,14 +35,15 @@ def agent_vsphere_arguments(params, hostname, ipaddress): args = '' if "tcp_port" in params: args += " -p %d" % params["tcp_port"] - if "lower" in params: - args += " -lower" args += " -u " + quote_shell_string(params["user"]) args += " -s " + quote_shell_string(params["secret"]) args += " -i " + ",".join(params["infos"]) - if params.get("direct"): + direct = params.get("direct", False) + if direct: args += ' --direct' + if direct == "agent": + args += ' --agent' args += " " + quote_shell_string(ipaddress) return args diff --git a/modules/check_mk_base.py b/modules/check_mk_base.py index 2cabeaf..1c5ae56 100755 --- a/modules/check_mk_base.py +++ b/modules/check_mk_base.py @@ -561,9 +561,9 @@ def get_agent_info(hostname, ipaddress, max_cache_age): if hostname in g_broken_agent_hosts: raise MKAgentError("") - # If the host ist listed in datasource_programs the data from + # If the host is listed in datasource_programs the data from # that host is retrieved by calling an external program (such - # as ssh or rsy) instead of a TCP connect. + # as ssh or rsh or agent_vsphere) instead of a TCP connect. commandline = get_datasource_program(hostname, ipaddress) if commandline: output = get_agent_info_program(commandline) diff --git a/web/plugins/wato/datasource_programs.py b/web/plugins/wato/datasource_programs.py index 29e81a5..ef8d568 100644 --- a/web/plugins/wato/datasource_programs.py +++ b/web/plugins/wato/datasource_programs.py @@ -75,8 +75,9 @@ register_rule(group, DropdownChoice( title = _("Type of query"), choices = [ - ( True, _("Queried host is a host system" ) ), - ( False, _("Queried host is the vCenter") ), + ( True, _("Queried host is a host system" ) ), + ( False, _("Queried host is the vCenter") ), + ( "agent", _("Queried host is the vCenter with Check_MK Agent installed") ), ], default = True, )

11 years, 3 months

Check_MK Git: check_mk: Added Manpage for esx_vsphere_objects

by Mathias Kettner

Module: check_mk Branch: master Commit: 051de2a8a65176e1d1a390c38fe14419f1c5254e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=051de2a8a65176… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Mar 27 13:55:21 2013 +0100 Added Manpage for esx_vsphere_objects --- checkman/esx_vsphere_objects | 20 ++++++++++++++++++++ 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/checkman/esx_vsphere_objects b/checkman/esx_vsphere_objects new file mode 100644 index 0000000..46db1d8 --- /dev/null +++ b/checkman/esx_vsphere_objects @@ -0,0 +1,20 @@ +title: Check completeness of output of ESX special agent +agents: vsphere +author: Mathias Kettner <mk(a)mathias-kettner.de> +license: GPL +distribution: check_mk +description: + This check makes sure that items sent by the ESX special agent (hostsystems + and VMs) are stil present later on. The information about this data can also + be used for determining the architecture of a VMWare farm out of the monitoring + data. + + The check will get critical if a host system or virtual machine, that was once + present, is now missing. + +inventory: + One service per hostsystem and per VM will be created. + +item: + The text {HostSystem} or {VM} followed by a space followed by the name of the host system + or VM.

11 years, 3 months

Check_MK Git: check_mk: ESX: Try to fix problem where no VM is present

by Mathias Kettner

Module: check_mk Branch: master Commit: aa90bd0f534b149b8d698ac9313250efd1578338 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=aa90bd0f534b14… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Mar 27 13:50:32 2013 +0100 ESX: Try to fix problem where no VM is present --- agents/special/agent_vsphere | 26 ++++++++-------- checks/esx_vsphere_objects | 67 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 80 insertions(+), 13 deletions(-) diff --git a/agents/special/agent_vsphere b/agents/special/agent_vsphere index 5713cbd..a9a80ba 100755 --- a/agents/special/agent_vsphere +++ b/agents/special/agent_vsphere @@ -65,8 +65,7 @@ except: host = VIServer() -object_collection = {} - +object_collection = [] try: host.connect(params['HOST'], params['user'], params['secret']) except: @@ -112,7 +111,11 @@ def output_mors(what, properties, direct=False): count = 0 sections = [] - for mor in host._retrieve_properties_traversal(property_names=properties.keys(), obj_type=obj_type): + mors = host._retrieve_properties_traversal(property_names=properties.keys(), obj_type=obj_type) + if not mors: + return + + for mor in mors: count += 1 # Parse result into a dictionary. Key is the property name, # value is the value (some custom Python classes) @@ -121,13 +124,10 @@ def output_mors(what, properties, direct=False): # Convert property value using specified conversion function data[p.Name] = properties[p.Name](p.Val) - # Get the name of this Host/VirtualMachine - # May there a comments in the field, so split at whitespace - try: - name = data["name"].split()[0] - object_collection[name] = (what, data['name']) - except: - pass + # Remember the total list of output objects. We will put this into + # a special section + object_collection.append((what, data["name"])) + name = data["name"].split()[0] # get rid of comment # Output multiplexed Check_MK Agent output (new in version 1.2.3i1) if direct: @@ -277,7 +277,7 @@ if "virtualmachine" in mortypes: print "<<<<>>>>" -print "<<<local>>>" -for name, data in object_collection.items(): - print "0 %s-%s - OK: collecting piggyback data for %s" % (data[0], name, data[1]) +print "<<<esx_vsphere_objects:sep(9)>>>" +for what, name in object_collection: + print "%s\t%s" % (what, name) host.disconnect() diff --git a/checks/esx_vsphere_objects b/checks/esx_vsphere_objects new file mode 100644 index 0000000..61d8db5 --- /dev/null +++ b/checks/esx_vsphere_objects @@ -0,0 +1,67 @@ +#!/usr/bin/python +# -*- encoding: utf-8; py-indent-offset: 4 -*- +# +------------------------------------------------------------------+ +# | ____ _ _ __ __ _ __ | +# | / ___| |__ ___ ___| | __ | \/ | |/ / | +# | | | | '_ \ / _ \/ __| |/ / | |\/| | ' / | +# | | |___| | | | __/ (__| < | | | | . \ | +# | \____|_| |_|\___|\___|_|\_\___|_| |_|_|\_\ | +# | | +# | Copyright Mathias Kettner 2013 mk(a)mathias-kettner.de | +# +------------------------------------------------------------------+ +# +# This file is part of Check_MK. +# The official homepage is at http://mathias-kettner.de/check_mk. +# +# check_mk is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License as published by +# the Free Software Foundation in version 2. check_mk is distributed +# in the hope that it will be useful, but WITHOUT ANY WARRANTY; with- +# out even the implied warranty of MERCHANTABILITY or FITNESS FOR A +# PARTICULAR PURPOSE. See the GNU General Public License for more de- +# ails. You should have received a copy of the GNU General Public +# License along with GNU Make; see the file COPYING. If not, write +# to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, +# Boston, MA 02110-1301 USA. + +# Example output from agent: +# <<<esx_vsphere_objects:sep(9)>>> +# hostsystem esx.wacker.corp +# virtualmachine LinuxI +# virtualmachine OpenSUSE_II +# virtualmachine OpenSUSE_III +# virtualmachine OpenSUSE_IV +# virtualmachine OpenSUSE_V +# virtualmachine WindowsXP I +# virtualmachine LinuxII +# virtualmachine LinuxIII +# virtualmachine LinuxIV +# virtualmachine LinuxV +# virtualmachine OpenSUSE_I + +vsphere_object_names = { + "hostsystem" : "HostSystem", + "virtualmachine" : "VM", +} + +def inventory_esx_vsphere_objects(info): + return [ (vsphere_object_names[line[0]] + " " + line[1], None) for line in info ] + +def check_esx_vsphere_objects(item, _no_params, info): + for line in info: + if vsphere_object_names[line[0]] + " " + line[1] == item: + return 0, "information about this object present" + + what = item.split()[0] + name = item.split()[1] + if what == "VM": + return 3, "Virtual machine %s is missing" % name + else: + return 3, "No data about host system %s" % name + + +check_info['esx_vsphere_objects'] = { + "inventory_function" : inventory_esx_vsphere_objects, + "check_function" : check_esx_vsphere_objects, + "service_description" : "%s", +}

11 years, 3 months

Check_MK Git: check_mk: esx_vsphere_sensors: handle unknown sensor as warning

by Mathias Kettner

Module: check_mk Branch: master Commit: 36f7918ce9df98a38b4683082d644926b07eb222 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=36f7918ce9df98… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Mar 27 13:27:00 2013 +0100 esx_vsphere_sensors: handle unknown sensor as warning --- checks/esx_vsphere_sensors | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/checks/esx_vsphere_sensors b/checks/esx_vsphere_sensors index 4947b9e..1f96016 100644 --- a/checks/esx_vsphere_sensors +++ b/checks/esx_vsphere_sensors @@ -43,6 +43,9 @@ def check_esx_vsphere_sensors(_no_item, _no_params, info): if health_key == "yellow": state = max(state, 1) infos[-1] += "(!)" + elif health_key == "unknown": + state = max(state, 1) + infos[-1] += "(!)" else: state = 2 infos[-1] += "(!!)"

11 years, 3 months

Check_MK Git: check_mk: esx_vsphere_datastores: New check for ESX datastores

by Mathias Kettner

Module: check_mk Branch: master Commit: 489f8c3cc3bfe78bf7488985c7da08101f27f773 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=489f8c3cc3bfe7… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Mar 27 13:12:37 2013 +0100 esx_vsphere_datastores: New check for ESX datastores --- ChangeLog | 5 +- agents/special/agent_vsphere | 39 ++++++++- checkman/esx_vsphere_datastores | 26 ++++++ checks/esx_vsphere_datastores | 92 +++++++++++++++++++++ pnp-templates/check_mk-esx_vsphere_datastores.php | 1 + web/htdocs/valuespec.py | 6 +- web/plugins/perfometer/check_mk.py | 1 + web/plugins/wato/datasource_programs.py | 23 +++-- 8 files changed, 175 insertions(+), 18 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=489f8c3cc3…

11 years, 3 months

Check_MK Git: check_mk: Merge branch 'master' of ssh://mathias-kettner.de/ check_mk

by Mathias Kettner

Module: check_mk Branch: master Commit: 4ee4a9fa57c1dbf507cda777fa8d1c07683eee09 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=4ee4a9fa57c1db… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Mar 27 13:12:40 2013 +0100 Merge branch 'master' of ssh://mathias-kettner.de/check_mk ---

11 years, 3 months

Check_MK Git: check_mk: resolved merge conflict

by Andreas Boesl

Module: check_mk Branch: master Commit: f41e62f82263bbc67f24bbd95638395cef1f1c01 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f41e62f82263bb… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Wed Mar 27 12:57:35 2013 +0100 resolved merge conflict --- ChangeLog | 3 +- agents/windows/plugins/mssql.vbs | 39 +++++++++++++++++++++++++++---------- checks/mssql_versions | 6 ++++- 3 files changed, 35 insertions(+), 13 deletions(-) diff --git a/ChangeLog b/ChangeLog index f9751c3..d8ea486 100644 --- a/ChangeLog +++ b/ChangeLog @@ -90,7 +90,8 @@ * ADD: wmic_processs: cpucores now being considered when calculating user/kernel percentages. (thanks to William Baum) * FIX: UPS checks support Eaton Evolution - + * FIX: windows agent plugin: mssql now exits after 10 seconds + Notifications: * FIX: fixed crash on host notification when contact had explicit services set diff --git a/agents/windows/plugins/mssql.vbs b/agents/windows/plugins/mssql.vbs index f515f14..80ffd7d 100644 --- a/agents/windows/plugins/mssql.vbs +++ b/agents/windows/plugins/mssql.vbs @@ -21,11 +21,24 @@ Option Explicit -Dim WMI, prop, instId, instVersion, instIds, instName +Dim WMI, prop, instId, instVersion, instIds, instName, output + +WScript.Timeout = 10 ' Directory of all database instance names Set instIds = CreateObject("Scripting.Dictionary") + +output = "" +Sub addOutput(text) + output = output & text & vbLf +End Sub + + +' Dummy empty output. +' Contains timeout error if this scripts runtime exceeds the timeout +WScript.echo "<<<mssql_versions>>>" + ' Loop all found local MSSQL server instances ' Try different trees to handle different versions of MSSQL On Error Resume Next @@ -43,7 +56,7 @@ If Err.Number <> 0 Then ' try MSSQL < 10 Set WMI = GetObject("WINMGMTS:\\.\root\Microsoft\SqlServer\ComputerManagement") If Err.Number <> 0 Then - wscript.echo "Error: " & Err.Number & " " & Err.Description + addOutput( "Error: " & Err.Number & " " & Err.Description ) Err.Clear() wscript.quit() End If @@ -57,8 +70,8 @@ For Each prop In WMI.ExecQuery("SELECT * FROM SqlServiceAdvancedProperty WHERE " instId = Replace(prop.ServiceName, "$", "_") instVersion = prop.PropertyStrValue - WScript.echo "<<<mssql_versions>>>" - WScript.echo instId & " " & instVersion + addOutput( "<<<mssql_versions>>>" ) + addOutput( instId & " " & instVersion ) ' Now query the server instance for the databases ' Use name as key and always empty value for the moment @@ -103,7 +116,7 @@ For Each instId In instIds.Keys RS.Open "SELECT counter_name, object_name, instance_name, cntr_value " & _ "FROM sys.dm_os_performance_counters " & _ "WHERE object_name NOT LIKE '%Deprecated%'", CONN - wscript.echo "<<<mssql_counters>>>" + addOutput( "<<<mssql_counters>>>" ) Dim objectName, counterName, instanceName, value Do While NOT RS.Eof objectName = Replace(Replace(Trim(RS("object_name")), " ", "_"), "$", "_") @@ -113,7 +126,7 @@ For Each instId In instIds.Keys instanceName = "None" End If value = Trim(RS("cntr_value")) - wscript.echo objectName & " " & counterName & " " & instanceName & " " & value + addOutput( objectName & " " & counterName & " " & instanceName & " " & value ) RS.MoveNext Loop RS.Close @@ -130,7 +143,7 @@ For Each instId In instIds.Keys RS.Close ' Now gather the db size and unallocated space - wscript.echo "<<<mssql_tablespaces>>>" + addOutput( "<<<mssql_tablespaces>>>" ) Dim i, dbSize, unallocated, reserved, data, indexSize, unused For Each dbName in dbNames.Keys ' Switch to other database and then ask for stats @@ -164,15 +177,15 @@ For Each instId In instIds.Keys Set RS = RS.NextRecordset i = i + 1 Loop - wscript.echo instId & " " & Replace(dbName, " ", "_") & " " & dbSize & " " & unallocated & " " & reserved & " " & _ - data & " " & indexSize & " " & unused + addOutput( instId & " " & Replace(dbName, " ", "_") & " " & dbSize & " " & unallocated & " " & reserved & " " & _ + data & " " & indexSize & " " & unused ) Set RS = CreateObject("ADODB.Recordset") Next ' Loop all databases to get the date of the last backup. Only show databases ' which have at least one backup Dim lastBackupDate - wscript.echo "<<<mssql_backup>>>" + addOutput( "<<<mssql_backup>>>" ) For Each dbName in dbNames.Keys RS.open "SELECT CONVERT(VARCHAR, DATEADD(s, DATEDIFF(s, '19700101', MAX(backup_finish_date)), '19700101'), 120) AS last_backup_date " & _ "FROM msdb.dbo.backupset " & _ @@ -180,7 +193,7 @@ For Each instId In instIds.Keys Do While Not RS.Eof lastBackupDate = Trim(RS("last_backup_date")) If lastBackupDate <> "" Then - wscript.echo instId & " " & Replace(dbName, " ", "_") & " " & lastBackupDate + addOutput( instId & " " & Replace(dbName, " ", "_") & " " & lastBackupDate ) End If RS.MoveNext Loop @@ -192,3 +205,7 @@ Next Set RS = nothing Set CONN = nothing + +' finally output collected data +WScript.echo output + diff --git a/checks/mssql_versions b/checks/mssql_versions index c4c76be..a6116df 100644 --- a/checks/mssql_versions +++ b/checks/mssql_versions @@ -28,7 +28,11 @@ # MSSQL_SQLEXPRESS 10.50.1600.1 def inventory_mssql_versions(info): - return [ (line[0], None) for line in info if len(line) >= 2 ] + inventory = [] + for line in info: + if len(line) == 2 and line[0] != "Error:": + inventory.append((line[0], None)) + return inventory def check_mssql_versions(item, _unused, info): for line in info:

11 years, 3 months

Check_MK Git: check_mk: Add logentry class filter to view '

by Mathias Kettner

Host- and Service events' Message-ID: <5152c1eb.y85OvZTQ+MlMZC5S%mk(a)mathias-kettner.de> User-Agent: Heirloom mailx 12.4 7/29/08 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Module: check_mk Branch: master Commit: 915f364eda57ff2f56a072ee077402b462c8b82f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=915f364eda57ff… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Mar 27 10:54:35 2013 +0100 Add logentry class filter to view 'Host- and Service events' --- ChangeLog | 1 + web/plugins/views/builtin.py | 3 ++- 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index 953d7f2..f9751c3 100644 --- a/ChangeLog +++ b/ChangeLog @@ -107,6 +107,7 @@ * New filter for IP address of a host * Quicksearch: allow searching for complete IP addresses and IP address prefixes + * Add logentry class filter to view 'Host- and Service events' BI: * FIX: fix exception with expansion level being 'None' diff --git a/web/plugins/views/builtin.py b/web/plugins/views/builtin.py index 1812b20..80b0daa 100644 --- a/web/plugins/views/builtin.py +++ b/web/plugins/views/builtin.py @@ -1641,7 +1641,8 @@ multisite_builtin_views.update({ 'serviceregex', 'logtime', 'log_plugin_output', - 'log_state',], + 'log_state', + 'log_class'], 'sorters': [('log_time', False), ('log_lineno', False)], 'title': _('Host- and Service events'), 'topic': _('Other')},

11 years, 3 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits March 2013