Checkmk git commits February 2013

checkmk-commits@lists.checkmk.com

3 participants
346 discussions

Check_MK Git: check_mk: First implementation of SAP monitoring with Check_MK

by Lars Michelsen

Module: check_mk Branch: master Commit: 249646ae1d8beb008703906b3c6e8b13eb70df40 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=249646ae1d8beb… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Feb 21 13:22:26 2013 +0100 First implementation of SAP monitoring with Check_MK --- ChangeLog | 5 + agents/plugins/mk_sap | 420 ++++++++++++++++++++++++++++++++++ agents/sap/sap.cfg | 58 +++++ agents/sap/sapnwrfc-0.19.tar.gz | Bin 0 -> 40733 bytes checkman/sap.dialog | 22 ++ checkman/sap.value | 51 ++++ checks/sap | 139 +++++++++++ web/plugins/wato/check_parameters.py | 35 +++ 8 files changed, 730 insertions(+), 0 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=249646ae1d…

11 years, 6 months

Check_MK Git: check_mk: Make TextAreaUnicode tolerate None values

by Mathias Kettner

Module: check_mk Branch: master Commit: f5e6a9668d90783f8656ae9293cdfa2ad756458a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f5e6a9668d9078… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Feb 21 15:11:27 2013 +0100 Make TextAreaUnicode tolerate None values --- web/htdocs/valuespec.py | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/web/htdocs/valuespec.py b/web/htdocs/valuespec.py index 5dc445d..a229732 100644 --- a/web/htdocs/valuespec.py +++ b/web/htdocs/valuespec.py @@ -511,6 +511,8 @@ class TextAreaUnicode(TextUnicode): return "<pre class=ve_textarea>%s</pre>" % value def render_input(self, varprefix, value): + if value == None: + value = "" # should never happen, but avoids exception for invalid input if self._rows == "auto": attrs = { "onkeyup" : 'valuespec_textarea_resize(this);' } if html.has_var(varprefix):

11 years, 6 months

Check_MK Git: check_mk: Merge branch 'master' of ssh://mathias-kettner.de/ check_mk

by Mathias Kettner

Module: check_mk Branch: master Commit: e9fc3c6effb45aa3b4e7e4fa9b6622bffc2a318b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e9fc3c6effb45a… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Feb 21 15:11:30 2013 +0100 Merge branch 'master' of ssh://mathias-kettner.de/check_mk ---

11 years, 6 months

Check_MK Git: check_mk: FIX: check_mk_base: fixed rounding error in get_bytes_human_readable

by Andreas Boesl

Module: check_mk Branch: master Commit: 0569d8ec91444fcfb90e17e33a7e59b80c940ace URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=0569d8ec91444f… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Thu Feb 21 14:28:17 2013 +0100 FIX: check_mk_base: fixed rounding error in get_bytes_human_readable --- ChangeLog | 1 + modules/check_mk_base.py | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog index 7178e6b..e06afbf 100644 --- a/ChangeLog +++ b/ChangeLog @@ -41,6 +41,7 @@ * Linux agent: limit netstat to 10 seconds * ps: Allow %1, %2, .. instead of %s in process_inventory. That allows reordering of matched groups + * FIX: check_mk_base: fixed rounding error in get_bytes_human_readable Multisite: * FIX: Fixed problem with error during localization scanning diff --git a/modules/check_mk_base.py b/modules/check_mk_base.py index a547100..7fd93c1 100755 --- a/modules/check_mk_base.py +++ b/modules/check_mk_base.py @@ -1290,6 +1290,7 @@ def savefloat(f): # The unit parameter simply changes the returned string, but does not interfere # with any calcluations def get_bytes_human_readable(b, base=1024.0, bytefrac=True, unit="B"): + base = float(base) # Handle negative bytes correctly prefix = '' if b < 0:

11 years, 6 months

Check_MK Git: check_mk: FIX: allow unicode encoded extra_service_conf

by Mathias Kettner

Module: check_mk Branch: master Commit: 356637e3b796f10391e7cc2804eecabc0831cacc URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=356637e3b796f1… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Feb 21 14:09:53 2013 +0100 FIX: allow unicode encoded extra_service_conf --- ChangeLog | 1 + modules/check_mk.py | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index e42011d..7178e6b 100644 --- a/ChangeLog +++ b/ChangeLog @@ -28,6 +28,7 @@ 1.2.2b4: Core: * FIX: Fix output of cmk -D: datasource programs were missing + * FIX: allow unicode encoded extra_service_conf * New configuration variable contactgroup_members Checks & Agents: diff --git a/modules/check_mk.py b/modules/check_mk.py index 395a858..74609c9 100755 --- a/modules/check_mk.py +++ b/modules/check_mk.py @@ -1745,7 +1745,7 @@ def create_nagios_servicedefs(outfile, hostname): } """ % ( template, hostname, description, logwatch, - extra_service_conf_of(hostname, description), checkname )) + extra_service_conf_of(hostname, description).encode("utf-8"), checkname )) checknames_to_define.add(checkname) have_at_least_one_service = True @@ -1807,7 +1807,7 @@ define service { host_name\t\t\t%s %s service_description\t\tCheck_MK } -""" % (active_service_template, hostname, extra_service_conf_of(hostname, "Check_MK"))) +""" % (active_service_template, hostname, extra_service_conf_of(hostname, "Check_MK").encode("utf-8"))) # Inventory checks - if user has configured them. Not for clusters. if inventory_check_interval and not is_cluster(hostname): outfile.write("""

11 years, 6 months

Check_MK Git: check_mk: ValueSpec: CascadingDropdown: fix choice normalization

by Mathias Kettner

Module: check_mk Branch: master Commit: c518d8c1a3a3513cf68c7ff17a5885998ab72779 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c518d8c1a3a351… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Feb 21 13:56:58 2013 +0100 ValueSpec: CascadingDropdown: fix choice normalization --- web/htdocs/valuespec.py | 18 +++++++++++------- 1 files changed, 11 insertions(+), 7 deletions(-) diff --git a/web/htdocs/valuespec.py b/web/htdocs/valuespec.py index 9b519ce..5dc445d 100644 --- a/web/htdocs/valuespec.py +++ b/web/htdocs/valuespec.py @@ -942,23 +942,27 @@ class CascadingDropdown(ValueSpec): ValueSpec.__init__(self, **kwargs) if type(kwargs["choices"]) == list: - self._choices = [] - for entry in kwargs["choices"]: - if len(entry) == 2: # plain entry with no sub-valuespec - entry = entry + (None,) # normlize to three entries - self._choices.append(entry) + self._choices = self.normalize_choices(kwargs["choices"]) else: - self._choices = kwargs["choices"] # function + self._choices = kwargs["choices"] # function, store for later self._separator = kwargs.get("separator", ", ") self._html_separator = kwargs.get("html_separator", "<br>") self._sorted = kwargs.get("sorted", True) + def normalize_choices(self, choices): + new_choices = [] + for entry in choices: + if len(entry) == 2: # plain entry with no sub-valuespec + entry = entry + (None,) # normlize to three entries + new_choices.append(entry) + return new_choices + def choices(self): if type(self._choices) == list: return self._choices else: - return self._choices() + return self.normalize_choices(self._choices()) def canonical_value(self): choices = self.choices()

11 years, 6 months

Check_MK Git: check_mk: Suggest use default value for filesystem levels that make sense

by Mathias Kettner

Module: check_mk Branch: master Commit: 788380326d9361f406ae53cec26d2236663f8d92 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=788380326d9361… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Feb 21 13:45:52 2013 +0100 Suggest use default value for filesystem levels that make sense --- ChangeLog | 1 + web/plugins/wato/check_parameters.py | 23 +++++++++++++---------- 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/ChangeLog b/ChangeLog index 208e8c3..e42011d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -59,6 +59,7 @@ * FIX: flexible notification valuespec is now localizable * FIX: Alias values of host/service/contact groups need to be set and unique within the group + * Suggest use default value for filesystem levels that make sense 1.2.2b3: Checks & Agents: diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py index 194fbdd..05f0cba 100644 --- a/web/plugins/wato/check_parameters.py +++ b/web/plugins/wato/check_parameters.py @@ -1080,16 +1080,18 @@ checkgroups.append(( Tuple( title = _("Levels for the used space"), elements = [ - Percentage(title = _("Warning at"), label = _("% usage"), allow_int = True), - Percentage(title = _("Critical at"), label = _("% usage"), allow_int = True)])), + Percentage(title = _("Warning at"), label = _("% usage"), allow_int = True, default_value=80), + Percentage(title = _("Critical at"), label = _("% usage"), allow_int = True, default_value=90)])), ( "magic", Float( title = _("Magic factor (automatic level adaptation for large filesystems)"), + default_value = 0.8, minvalue = 0.1, maxvalue = 1.0)), ( "magic_normsize", Integer( title = _("Reference size for magic factor"), + default_value = 20, minvalue = 1, label = _("GB"))), ( "levels_low", @@ -1098,12 +1100,13 @@ checkgroups.append(( help = _("The filesystem levels will never fall below these values, when using " "the magic factor and the filesystem is very small."), elements = [ - Percentage(title = _("Warning at"), label = _("usage"), allow_int = True), - Percentage(title = _("Critical at"), label = _("usage"), allow_int = True)])), + Percentage(title = _("Warning at"), label = _("usage"), allow_int = True, default_value=50), + Percentage(title = _("Critical at"), label = _("usage"), allow_int = True, default_value=60)])), ( "trend_range", Optional( Integer( title = _("Range for filesystem trend computation"), + default_value = 24, minvalue = 1, label= _("hours")), title = _("Trend computation"), @@ -1112,22 +1115,22 @@ checkgroups.append(( Tuple( title = _("Levels on trends in MB per range"), elements = [ - Integer(title = _("Warning at"), label = _("MB / range")), - Integer(title = _("Critical at"), label = _("MB / range")) + Integer(title = _("Warning at"), label = _("MB / range"), default_value = 100), + Integer(title = _("Critical at"), label = _("MB / range"), default_value = 200) ])), ( "trend_perc", Tuple( title = _("Levels for the percentual growth"), elements = [ - Percentage(title = _("Warning at"), label = _("% / range")), - Percentage(title = _("Critical at"), label = _("% / range")) + Percentage(title = _("Warning at"), label = _("% / range"), default_value = 5,), + Percentage(title = _("Critical at"), label = _("% / range"), default_value = 10,), ])), ( "trend_timeleft", Tuple( title = _("Levels on the time left until the filesystem gets full"), elements = [ - Integer(title = _("Warning at"), label = _("hours left")), - Integer(title = _("Critical at"), label = _("hours left")) + Integer(title = _("Warning at"), label = _("hours left"), default_value = 12,), + Integer(title = _("Critical at"), label = _("hours left"), default_value = 6, ), ])), ( "trend_perfdata", Checkbox(

11 years, 6 months

Check_MK Git: check_mk: Fixed some wrong English texts

by Mathias Kettner

Module: check_mk Branch: master Commit: 985536e3037f75dfd087fba3dea05b04572a486c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=985536e3037f75… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Feb 21 13:38:06 2013 +0100 Fixed some wrong English texts --- web/plugins/wato/check_parameters.py | 40 +++++++++++++++++----------------- 1 files changed, 20 insertions(+), 20 deletions(-) diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py index d2b94bf..194fbdd 100644 --- a/web/plugins/wato/check_parameters.py +++ b/web/plugins/wato/check_parameters.py @@ -659,8 +659,8 @@ checkgroups.append(( Tuple( title = _("Minimal size"), elements = [ - Filesize(title = _("Warning lower as")), - Filesize(title = _("Critical lower as")), + Filesize(title = _("Warning when lower then")), + Filesize(title = _("Critical when lower then")), ] ) ), @@ -668,8 +668,8 @@ checkgroups.append(( Tuple( title = _("Maximal size"), elements = [ - Filesize(title = _("Warning higher as")), - Filesize(title = _("Critical higher as")), + Filesize(title = _("Warning when higher then")), + Filesize(title = _("Critical when higher then")), ] ) ) @@ -790,8 +790,8 @@ checkgroups.append(( Tuple( title = _("Minimal size"), elements = [ - Filesize(title = _("Warning lower as")), - Filesize(title = _("Critical lower as")), + Filesize(title = _("Warning when lower then")), + Filesize(title = _("Critical when lower then")), ] ) ), @@ -799,8 +799,8 @@ checkgroups.append(( Tuple( title = _("Maximal size"), elements = [ - Filesize(title = _("Warning higher as")), - Filesize(title = _("Critical higher as")), + Filesize(title = _("Warning when higher then")), + Filesize(title = _("Critical when higher then")), ] ) ), @@ -808,8 +808,8 @@ checkgroups.append(( Tuple( title = _("Minimal file count"), elements = [ - Integer(title = _("Warning lower as")), - Integer(title = _("Critical lower as")), + Integer(title = _("Warning when lower then")), + Integer(title = _("Critical when lower then")), ] ) ), @@ -817,8 +817,8 @@ checkgroups.append(( Tuple( title = _("Maximal file count"), elements = [ - Integer(title = _("Warning higher as")), - Integer(title = _("Critical higher as")), + Integer(title = _("Warning when higher then")), + Integer(title = _("Critical when higher then")), ] ) ), @@ -840,8 +840,8 @@ checkgroups.append(( Tuple( title = _("Read"), elements = [ - Filesize(title = _("Warning lower as")), - Filesize(title = _("Critical lower as")), + Filesize(title = _("Warning when lower then")), + Filesize(title = _("Critical when lower then")), ] ) ), @@ -849,8 +849,8 @@ checkgroups.append(( Tuple( title = _("Write"), elements = [ - Filesize(title = _("Warning higher as")), - Filesize(title = _("Critical higher as")), + Filesize(title = _("Warning when higher then")), + Filesize(title = _("Critical when higher then")), ] ) ) @@ -884,8 +884,8 @@ checkgroups.append(( Tuple( title = _("Absolute levels"), elements = [ - Filesize(title = _("Warning higher as")), - Filesize(title = _("Critical higher as")), + Filesize(title = _("Warning when higher then")), + Filesize(title = _("Critical when higher then")), ] ) ])), @@ -903,8 +903,8 @@ checkgroups.append(( Tuple( title = _("Absolute levels"), elements = [ - Filesize(title = _("Warning higher as")), - Filesize(title = _("Critical higher as")), + Filesize(title = _("Warning when higher then")), + Filesize(title = _("Critical when higher then")), ] ) ])),

11 years, 6 months

Check_MK Git: check_mk: Merge branch 'master' of ssh://mathias-kettner.de/ check_mk

by Mathias Kettner

Module: check_mk Branch: master Commit: 1c1157f1f823d6482f13e0a88dfcb65a8d1ce414 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1c1157f1f823d6… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Feb 21 13:26:58 2013 +0100 Merge branch 'master' of ssh://mathias-kettner.de/check_mk ---

11 years, 6 months

Check_MK Git: check_mk: Renamed search field of WIKI snapin

by Mathias Kettner

Module: check_mk Branch: master Commit: 496a8a7b3c1c414b7aedb5ad20f356f57df6d6ab URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=496a8a7b3c1c41… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Feb 21 13:26:56 2013 +0100 Renamed search field of WIKI snapin --- doc/treasures/wiki_snapin.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/doc/treasures/wiki_snapin.py b/doc/treasures/wiki_snapin.py index e9c070e..1520d35 100644 --- a/doc/treasures/wiki_snapin.py +++ b/doc/treasures/wiki_snapin.py @@ -99,7 +99,7 @@ def render_wiki(): } """ % defaults.omd_site) html.begin_form("wikisearch", onsubmit="wiki_search();") - html.text_input("search", "", id="wikisearch_input", ) + html.text_input("wikisearch", "", id="wikisearch_input", ) html.end_form() if defaults.omd_root:

11 years, 6 months

← Newer
1
2
3
4
5
6
7
8
9
...
35
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits February 2013