Checkmk git commits October 2013

checkmk-commits@lists.checkmk.com

6 participants
384 discussions

Check_MK Git: check_mk: Updated bug entries #1023

by Lars Michelsen

Module: check_mk Branch: master Commit: b09a2f0f3d170f4254551853f8f9317affc623fe URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b09a2f0f3d170f… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Oct 15 14:25:42 2013 +0200 Updated bug entries #1023 --- .bugs/1023 | 75 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 75 insertions(+) diff --git a/.bugs/1023 b/.bugs/1023 new file mode 100644 index 0000000..2a5acd7 --- /dev/null +++ b/.bugs/1023 @@ -0,0 +1,75 @@ +Title: inline_snmp uses MIBs (if installed) -> might break checks +Component: core +State: open +Date: 2013-10-15 14:21:28 +Targetversion: 1.2.3i3 +Class: bug + +We use the option s.UseSprintValue = 1 to make the netsnmp libraries translate some values for us. +Problem arises when some mibs are installed which lead to translated values, e.g.: + +OMD[ber]:~$ cmk --debug -nv bervm002.vm.bbf.local +Check_mk version 2013.10.14 +Connecting via TCP to 10.55.10.32:6556. +CPU utilization OK - 0.3% used, 16 CPUs +Check_MK Agent Version OK - windows / 1.2.1i4 +Disk IO SUMMARY OK - 0.00B/sec read, 225.21kB/sec write, IOs: 56.36/sec, Read Queue: 0.00, Write Queue: 0.26 +bervm002.vm.bbf.local 10.55.10.32 ('.1.3.6.1.4.1.232', ['11.1.3.0', '11.2.14.1.1.5.0', '2.2.2.1.0']) +Executing BULKWALK of ".1.3.6.1.4.1.232.11.1.3" on bervm002.vm.bbf.local +.1.3.6.1.4.1.232.11.1.3.0 => [unknown] 'INTEGER' +Executing BULKWALK of ".1.3.6.1.4.1.232.11.2.14.1.1.5" on bervm002.vm.bbf.local +.1.3.6.1.4.1.232.11.2.14.1.1.5.0 => [5.12] 'OCTETSTR' +.1.3.6.1.4.1.232.11.2.14.1.1.5.1 => [2011.05.05] 'OCTETSTR' +.1.3.6.1.4.1.232.11.2.14.1.1.5.2 => [2.07] 'OCTETSTR' +.1.3.6.1.4.1.232.11.2.14.1.1.5.3 => [2.9] 'OCTETSTR' +Executing BULKWALK of ".1.3.6.1.4.1.232.2.2.2.1" on bervm002.vm.bbf.local +.1.3.6.1.4.1.232.2.2.2.1.0 => [CZ20258062] 'OCTETSTR' +Traceback (most recent call last): + File "/omd/sites/ber/share/check_mk/modules/check_mk.py", line 5701, in <module> + do_check(hostname, ipaddress, check_types) + File "/omd/sites/ber/share/check_mk/modules/check_mk_base.py", line 895, in do_check + agent_version, num_success, error_sections, problems = do_all_checks_on_host(hostname, ipaddress, only_check_types) + File "/omd/sites/ber/share/check_mk/modules/check_mk_base.py", line 1091, in do_all_checks_on_host + result = check_function(item, params, info) + File "/omd/sites/ber/share/check_mk/checks/hp_proliant", line 40, in check_proliant_general + snmp_state = hp_proliant_general_status_map[int(info[0][0])] +ValueError: invalid literal for int() with base 10: 'unknown' + + +and without: + +OMD[ber]:~$ cmk --debug -nv bervm002.vm.bbf.local +Check_mk version 2013.10.14 +Connecting via TCP to 10.55.10.32:6556. +CPU utilization OK - 100.0% used, 16 CPUs +Check_MK Agent Version OK - windows / 1.2.1i4 +Disk IO SUMMARY OK - 0.00B/sec read, 97.94kB/sec write, IOs: 24.58/sec, Read Queue: 0.00, Write Queue: 0.13 +bervm002.vm.bbf.local 10.55.10.32 ('.1.3.6.1.4.1.232', ['11.1.3.0', '11.2.14.1.1.5.0', '2.2.2.1.0']) +Executing BULKWALK of ".1.3.6.1.4.1.232.11.1.3" on bervm002.vm.bbf.local +.1.3.6.1.4.1.232.11.1.3.0 => [1] 'INTEGER' +Executing BULKWALK of ".1.3.6.1.4.1.232.11.2.14.1.1.5" on bervm002.vm.bbf.local +.1.3.6.1.4.1.232.11.2.14.1.1.5.0 => [5.12] 'OCTETSTR' +.1.3.6.1.4.1.232.11.2.14.1.1.5.1 => [2011.05.05] 'OCTETSTR' +.1.3.6.1.4.1.232.11.2.14.1.1.5.2 => [2.07] 'OCTETSTR' +.1.3.6.1.4.1.232.11.2.14.1.1.5.3 => [2.9] 'OCTETSTR' +Executing BULKWALK of ".1.3.6.1.4.1.232.2.2.2.1" on bervm002.vm.bbf.local +.1.3.6.1.4.1.232.2.2.2.1.0 => [CZ20258062] 'OCTETSTR' +General Status OK - General Status is Unknown (Firmware: 5.12, S/N: CZ20258062) +bervm002.vm.bbf.local 10.55.10.32 ('.1.3.6.1.4.1.232.1.2.2.1.1', ['1', '2', '3', '6']) +Executing BULKWALK of ".1.3.6.1.4.1.232.1.2.2.1.1.1" on bervm002.vm.bbf.local +.1.3.6.1.4.1.232.1.2.2.1.1.1.0 => [0] 'INTEGER' +.1.3.6.1.4.1.232.1.2.2.1.1.1.1 => [1] 'INTEGER' +Executing BULKWALK of ".1.3.6.1.4.1.232.1.2.2.1.1.2" on bervm002.vm.bbf.local +.1.3.6.1.4.1.232.1.2.2.1.1.2.0 => [0] 'INTEGER' +.1.3.6.1.4.1.232.1.2.2.1.1.2.1 => [0] 'INTEGER' +Executing BULKWALK of ".1.3.6.1.4.1.232.1.2.2.1.1.3" on bervm002.vm.bbf.local +.1.3.6.1.4.1.232.1.2.2.1.1.3.0 => [Intel Xeon] 'OCTETSTR' +.1.3.6.1.4.1.232.1.2.2.1.1.3.1 => [Intel Xeon] 'OCTETSTR' +Executing BULKWALK of ".1.3.6.1.4.1.232.1.2.2.1.1.6" on bervm002.vm.bbf.local +.1.3.6.1.4.1.232.1.2.2.1.1.6.0 => [2] 'INTEGER' +.1.3.6.1.4.1.232.1.2.2.1.1.6.1 => [2] 'INTEGER' +HW CPU 0 OK - CPU0 "Intel Xeon" in slot 0 is in state "ok" +HW CPU 1 OK - CPU1 "Intel Xeon" in slot 0 is in state "ok" + +Can we switch of the Sprintf option to have the raw values? +Which ones need to be translated on our own?

10 years, 11 months

Check_MK Git: check_mk: Updated bug entries #1076

by Mathias Kettner

Module: check_mk Branch: master Commit: 48049d46b354d5232216d8a876d3c548f1c2ab21 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=48049d46b354d5… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Oct 16 23:18:45 2013 +0200 Updated bug entries #1076 --- .bugs/1076 | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.bugs/1076 b/.bugs/1076 new file mode 100644 index 0000000..8434893 --- /dev/null +++ b/.bugs/1076 @@ -0,0 +1,11 @@ +Title: $COUNT$ empty in non-counting rule +Component: ec +State: open +Date: 2013-10-16 23:17:16 +Targetversion: 1.4.0 +Class: bug + +If you use the placeholder $COUNT$ in actions or emails and have no counting +rule, then the macro is not being replaced. Would should make a better macro +replacement, that is not based on the actual fields of an event but on the +declared fields, and apply default values for any missing field.

10 years, 11 months

Check_MK Git: check_mk: Updated bug entries #1075

by Mathias Kettner

Module: check_mk Branch: master Commit: 7d563871daf1c4d6b98ddad9c4906ba01e733aa3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7d563871daf1c4… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Oct 16 21:52:21 2013 +0200 Updated bug entries #1075 --- .bugs/1075 | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.bugs/1075 b/.bugs/1075 new file mode 100644 index 0000000..c73c80e --- /dev/null +++ b/.bugs/1075 @@ -0,0 +1,10 @@ +Title: Do averaging in the prediction algo +Component: checks +State: open +Date: 2013-10-16 21:48:25 +Targetversion: future +Class: feature + +We could add averaging directly into the prediction +algo (it est averaging over time). So that we smoothing +as well the reference data as the current check data.

10 years, 11 months

Check_MK Git: check_mk: Updated bug entries #1074

by Mathias Kettner

Module: check_mk Branch: master Commit: c27032919a024b7e8c23b1e7040366683726e859 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c27032919a024b… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Oct 16 21:45:07 2013 +0200 Updated bug entries #1074 --- .bugs/1074 | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.bugs/1074 b/.bugs/1074 new file mode 100644 index 0000000..f8c19f0 --- /dev/null +++ b/.bugs/1074 @@ -0,0 +1,9 @@ +Title: Predictive monitoring does not take into account DST +Component: checks +State: open +Date: 2013-10-16 21:43:31 +Targetversion: 1.4.0 +Class: bug + +The predictive monitoring appearantly does not handle +daylight saving time correctly.

10 years, 11 months

Check_MK Git: check_mk: fixed merge conflict

by Bastian Kuhn

Module: check_mk Branch: master Commit: 051856f0921ff22a71bc2cbde430d84b4f838379 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=051856f0921ff2… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Wed Oct 16 17:59:07 2013 +0200 fixed merge conflict ---

10 years, 11 months

Check_MK Git: check_mk: Dell Open Manage: SNNP Checks for Physical Disks, CPU and Memory

by Bastian Kuhn

Module: check_mk Branch: master Commit: 8815b6c958724bef385c9702afe2f4e46ccfa047 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8815b6c958724b… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Wed Oct 16 17:57:48 2013 +0200 Dell Open Manage: SNNP Checks for Physical Disks, CPU and Memory --- ChangeLog | 1 + checkman/dell_om_disks | 19 +++++++ checkman/dell_om_esmlog | 16 ++++++ checkman/dell_om_mem | 18 ++++++ checkman/dell_om_processors | 17 ++++++ checkman/dell_om_sensors | 18 ++++++ checks/dell_om_disks | 129 +++++++++++++++++++++++++++++++++++++++++++ checks/dell_om_esmlog | 58 +++++++++++++++++++ checks/dell_om_mem | 78 ++++++++++++++++++++++++++ checks/dell_om_processors | 84 ++++++++++++++++++++++++++++ checks/dell_om_sensors | 70 +++++++++++++++++++++++ 11 files changed, 508 insertions(+) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=8815b6c958…

10 years, 11 months

Check_MK Git: check_mk: Updated bug entries #0831, #0671

by Bastian Kuhn

Module: check_mk Branch: master Commit: fc82fa155a275914caf614e576f3a07e3817ff56 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=fc82fa155a2759… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Wed Oct 16 13:43:18 2013 +0200 Updated bug entries #0831, #0671 --- .bugs/671 | 7 +++++-- .bugs/831 | 8 ++++++++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/.bugs/671 b/.bugs/671 index d27a46e..6dd1984 100644 --- a/.bugs/671 +++ b/.bugs/671 @@ -1,9 +1,12 @@ Title: Quicksearch: search for IP addresses Component: multisite -State: open +Class: feature +State: done Date: 2012-03-30 16:12:34 Targetversion: future -Class: feature In Quicksearch it should be possible to search for IP addresses (and find hosts). + +2013-10-16 13:41:07: changed state open -> done +Its possible since a few versions diff --git a/.bugs/831 b/.bugs/831 new file mode 100644 index 0000000..998061d --- /dev/null +++ b/.bugs/831 @@ -0,0 +1,8 @@ +Title: Quicksearch: Duplicate results +Component: multisite +State: open +Date: 2013-10-16 13:41:13 +Targetversion: 1.4.0 +Class: bug + +In Version 1.2.3i4, the quicksearch repeats some of the results what means that some of the hosts are shown twice.

10 years, 11 months

Check_MK Git: check_mk: Fixed typos

by Bastian Kuhn

Module: check_mk Branch: master Commit: 880de2797a02b20a575ed27a9ffd087790d34a3a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=880de2797a02b2… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Wed Oct 16 08:12:43 2013 +0200 Fixed typos --- web/htdocs/wato.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index a573c7d..e42506b 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -8382,8 +8382,7 @@ def load_notification_table(): ( "service_blacklist", ListOfStrings( title = _("Blacklist the following services"), - help = _("Configure regular expressions that match the beginning of the service names here. Prefix an " - "entry with <tt>!</tt> in order to <i>exclude</i> that service."), + help = _("Configure regular expressions that match the beginning of the service names here."), orientation = "horizontal", valuespec = RegExp(size = 20), validate = validate_only_services,

10 years, 11 months

Check_MK Git: check_mk: FIX: local: tolerate invalid output lines

by Mathias Kettner

Module: check_mk Branch: master Commit: 48f30672bade9d385f3bbd91547839fd00e6ab16 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=48f30672bade9d… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Oct 16 17:29:40 2013 +0200 FIX: local: tolerate invalid output lines --- ChangeLog | 5 +++-- checks/local | 12 ++++++++++-- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 6525e3e..8d9c1f6 100644 --- a/ChangeLog +++ b/ChangeLog @@ -29,11 +29,12 @@ * hpux_cpu, blade_bx_load: support predictive levels, add perf-o-meter, make WATO-configable * check_sql: Database port can now be explicitly set - * FIX: esx_vsphere_counters: added missing ramdisk type upgradescratch - * FIX: esx_vsphere_hostsystem: fixed bug in handling of params * steelhead_perrs: New check for Rivergate Gateways * alcatel_power: Check for power supplies on Alcatel switches * qnap_disks: New check for Hardisks in Qnap devices + * FIX: esx_vsphere_counters: added missing ramdisk type upgradescratch + * FIX: esx_vsphere_hostsystem: fixed bug in handling of params + * FIX: local: tolerate invalid output lines WATO: * You can now have site-specific global settings when using diff --git a/checks/local b/checks/local index 9862a53..056d6b0 100644 --- a/checks/local +++ b/checks/local @@ -26,11 +26,19 @@ def inventory_local(info): - return [ (line[1], '', '""') for line in info ] + inventory = [] + # Ignore invalid lines, tolerate bugs in local checks + # of unexperianced users + for line in info: + if len(line) >= 4: + inventory.append( (line[1], None) ) + return inventory def check_local(item, params, info): for line in info: - if line[1] == item: + # Ignore invalid lines, tolerate bugs in local checks + # of unexperianced users + if len(line) >= 2 and line[1] == item: state = int(line[0]) perftxt = line[2] output = " ".join(line[3:])

10 years, 11 months

Check_MK Git: check_mk: check_tcp: Now able to set custom service description

by Andreas Boesl

Module: check_mk Branch: master Commit: 1f8dc39436beb14837c2e3b6731f3fe087e2f921 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1f8dc39436beb1… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Wed Oct 16 16:15:29 2013 +0200 check_tcp: Now able to set custom service description --- ChangeLog | 1 + checks/check_tcp | 2 +- web/plugins/wato/active_checks.py | 6 ++++++ 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 6525e3e..3110be6 100644 --- a/ChangeLog +++ b/ChangeLog @@ -34,6 +34,7 @@ * steelhead_perrs: New check for Rivergate Gateways * alcatel_power: Check for power supplies on Alcatel switches * qnap_disks: New check for Hardisks in Qnap devices + * check_tcp: Now able to set custom service description WATO: * You can now have site-specific global settings when using diff --git a/checks/check_tcp b/checks/check_tcp index c491171..8c4d780 100644 --- a/checks/check_tcp +++ b/checks/check_tcp @@ -84,7 +84,7 @@ def check_tcp_arguments(params): active_check_info['tcp'] = { "command_line" : '$USER1$/check_tcp $ARG1$', "argument_function" : check_tcp_arguments, - "service_description" : lambda args: "TCP Port %d" % args[0], + "service_description" : lambda args: args[1].get("svc_description", "TCP Port %d" % args[0]), "has_perfdata" : True, } diff --git a/web/plugins/wato/active_checks.py b/web/plugins/wato/active_checks.py index c25ccc7..52d46d2 100644 --- a/web/plugins/wato/active_checks.py +++ b/web/plugins/wato/active_checks.py @@ -239,6 +239,12 @@ register_rule(group, help = _("If you specify a hostname here, then a dynamic DNS lookup " "will be done instead of using the IP address of the host " "as configured in your host properties."))), + ( "svc_description", + TextAscii( + title = _("Custom service description"), + allow_empty = False, + help = _("Here you can specify a custom service description. " + "If this parameter is not set the service is named <tt>TCP Port {Portnumber}</tt>"))), ( "response_time", Tuple( title = _("Expected response time"),

10 years, 11 months

← Newer
1
...
17
18
19
20
21
22
23
...
39
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits October 2013