Checkmk git commits October 2013

checkmk-commits@lists.checkmk.com

6 participants
384 discussions

Check_MK Git: check_mk: FIX: Avoid timed browser reload after execution of exections

by Mathias Kettner

Module: check_mk Branch: master Commit: 748548df5f6d7cebcb17619fde5d8192a860176c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=748548df5f6d7c… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Sun Oct 20 12:54:36 2013 -0400 FIX: Avoid timed browser reload after execution of exections Still the wohl workflow is stull much too complicated in the implementation. There are still some subtle work flows where things do not work out correctly. --- .bugs/977 | 8 ++++++-- ChangeLog | 1 + web/htdocs/views.py | 6 ++++-- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/.bugs/977 b/.bugs/977 index 913fa05..1a1a0ff 100644 --- a/.bugs/977 +++ b/.bugs/977 @@ -1,9 +1,9 @@ Title: Invalid reload after command execution Component: multisite -State: open +Class: bug +State: done Date: 2013-06-23 11:21:05 Targetversion: 1.2.3i5 -Class: bug When you issue a command on hosts/services and confirm then you see a blue message with a link back to the view. In that situation there must be no @@ -14,3 +14,7 @@ An even better resolution would be to drop that intermediate page at all and instead print the result of the command in a kind of overlay window that goes away after a view seconds or when you hover over it. That saves one mouse click. + +2013-10-20 12:53:59: changed state open -> done +Disabled reload after execution of actions and also +during confirmation. diff --git a/ChangeLog b/ChangeLog index 2dc4a71..6093cb2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -27,6 +27,7 @@ * FIX: Fix output format python for several numeric columns * FIX: Fixed searching hosts by aliases/adresses * FIX: Remove duplicate entries from Quicksearch + * FIX: Avoid timed browser reload after execution of exections BI: * FIX: Fix exception when showing BI tree in reporting time warp diff --git a/web/htdocs/views.py b/web/htdocs/views.py index 6420737..5958fc0 100644 --- a/web/htdocs/views.py +++ b/web/htdocs/views.py @@ -1429,6 +1429,8 @@ def render_view(view, rows, datasource, group_painters, painters, show_checkboxes, layout, num_columns, show_filters, show_footer, hide_filters, browser_reload): + if html.transaction_valid() and html.do_actions(): + html.set_browser_reload(0) # Show heading (change between "preview" mode and full page mode) if show_heading: @@ -1528,8 +1530,8 @@ def render_view(view, rows, datasource, group_painters, painters, if show_buttons: update_context_links( # don't take display_options into account here ('c' is set during reload) - row_count > 0 and should_show_command_form('C', datasource) \ - and not html.do_actions(), + row_count > 0 and should_show_command_form('C', datasource), + # and not html.do_actions(), can_display_checkboxes )

11 years

Check_MK Git: check_mk: Updated bug entries #1042

by Mathias Kettner

Module: check_mk Branch: master Commit: e2a6ebb94c41c7992931fad270fea3b58a111f10 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e2a6ebb94c41c7… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Sat Oct 19 18:48:10 2013 -0400 Updated bug entries #1042 --- .bugs/1042 | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.bugs/1042 b/.bugs/1042 index fbda47b..dc5ac21 100644 --- a/.bugs/1042 +++ b/.bugs/1042 @@ -1,9 +1,9 @@ Title: Package should have dependency to apache2-prefork Component: multisite -State: open +Class: bug +State: done Date: 2013-08-30 15:48:55 Targetversion: 1.2.3i5 -Class: bug Problems in Multisite GUI if apache is running with mpm prefork works so the package should depend on apache2-mpm but at least the deb for ubuntu 13.04 @@ -58,3 +58,6 @@ index 5895796..8cbe9b1 100644 OS_PACKAGES += libboost-program-options1.49.0 OS_PACKAGES += libdbi1 OS_PACKAGES += libevent-1.4-2 + +2013-10-19 18:46:27: changed state open -> done +Fixed in our OMD builds.

11 years

Check_MK Git: check_mk: Fixed catalog path of new DELL checks

by Mathias Kettner

Module: check_mk Branch: master Commit: 257481d08e2896da88b645b2113937f47f81f6f0 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=257481d08e2896… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Oct 18 22:33:33 2013 -0400 Fixed catalog path of new DELL checks --- .bugs/981 | 7 +++++-- checkman/dell_om_disks | 4 ++-- checkman/dell_om_esmlog | 4 ++-- checkman/dell_om_mem | 8 ++++---- checkman/dell_om_processors | 4 ++-- checkman/dell_om_sensors | 4 ++-- 6 files changed, 17 insertions(+), 14 deletions(-) diff --git a/.bugs/981 b/.bugs/981 index 931e24f..81f78aa 100644 --- a/.bugs/981 +++ b/.bugs/981 @@ -1,9 +1,9 @@ Title: liveproxyd: keep site closed for a while after an error Component: livestatus -State: open +Class: todo +State: done Date: 2013-10-09 18:48:24 Targetversion: 1.2.3i3 -Class: todo When the livestatus proxy daemon cannot connect to a site for any reason, or if a heartbeat fails, it should mark @@ -13,3 +13,6 @@ occurrs. That way we tackle: - flapping connections - problems with permament errors (cannot resolve hostname) + +2013-10-18 22:29:14: changed state open -> done +There already is such a setting. diff --git a/checkman/dell_om_disks b/checkman/dell_om_disks index 6e54670..c1ed81c 100644 --- a/checkman/dell_om_disks +++ b/checkman/dell_om_disks @@ -1,6 +1,6 @@ -title: Dell Open Manage Disk Status +title: Dell Open Manage: Disks agents: snmp -catalog: hw/dell +catalog: hw/server/dell license: GPL distribution: check_mk description: diff --git a/checkman/dell_om_esmlog b/checkman/dell_om_esmlog index c00deb3..d2446e7 100644 --- a/checkman/dell_om_esmlog +++ b/checkman/dell_om_esmlog @@ -1,6 +1,6 @@ -title: Dell Open Manage ESM log health +title: Dell Open Manage: ESM log agents: snmp -catalog: hw/dell +catalog: hw/server/dell license: GPL distribution: check_mk description: diff --git a/checkman/dell_om_mem b/checkman/dell_om_mem index 5ac1e57..4b3e16c 100644 --- a/checkman/dell_om_mem +++ b/checkman/dell_om_mem @@ -1,6 +1,6 @@ -title: Dell Open Manage Physical Memory Status +title: Dell Open Manage: Physical Memory agents: snmp -catalog: hw/dell +catalog: hw/server/dell license: GPL distribution: check_mk description: @@ -11,8 +11,8 @@ description: by the device. The check also reports the size of the module. item: - The Name of the Modul port + The name of the module port inventory: - One check is created for each Module + One check is created for each module diff --git a/checkman/dell_om_processors b/checkman/dell_om_processors index 19ec427..643d8ba 100644 --- a/checkman/dell_om_processors +++ b/checkman/dell_om_processors @@ -1,6 +1,6 @@ -title: Dell Open Manage Processor Status +title: Dell Open Manage: Processor health agents: snmp -catalog: hw/dell +catalog: hw/server/dell license: GPL distribution: check_mk description: diff --git a/checkman/dell_om_sensors b/checkman/dell_om_sensors index 854a635..86a61d0 100644 --- a/checkman/dell_om_sensors +++ b/checkman/dell_om_sensors @@ -1,6 +1,6 @@ -title: Dell Open Manage Sensort (Fan, Temperature) status +title: Dell Open Manage: Sensors (Fan, Temperature) agents: snmp -catalog: hw/dell +catalog: hw/server/dell license: GPL distribution: check_mk description:

11 years

Check_MK Git: check_mk: Minor update in WATO texts for check_tcp

by Mathias Kettner

Module: check_mk Branch: master Commit: 9d2ac921d6afc4fafbdc651552b40288f66c9d25 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=9d2ac921d6afc4… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Oct 18 22:10:27 2013 -0400 Minor update in WATO texts for check_tcp --- web/plugins/wato/active_checks.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/web/plugins/wato/active_checks.py b/web/plugins/wato/active_checks.py index f6efe8e..b89f021 100644 --- a/web/plugins/wato/active_checks.py +++ b/web/plugins/wato/active_checks.py @@ -305,6 +305,12 @@ register_rule(group, Dictionary( title = _("Optional parameters"), elements = [ + ( "svc_description", + TextUnicode( + title = _("Service description"), + allow_empty = False, + help = _("Here you can specify a service description. " + "If this parameter is not set, the service is named <tt>TCP Port {Portnumber}</tt>"))), ( "hostname", TextAscii( title = _("DNS Hostname"), @@ -312,12 +318,6 @@ register_rule(group, help = _("If you specify a hostname here, then a dynamic DNS lookup " "will be done instead of using the IP address of the host " "as configured in your host properties."))), - ( "svc_description", - TextUnicode( - title = _("Custom service description"), - allow_empty = False, - help = _("Here you can specify a custom service description. " - "If this parameter is not set the service is named <tt>TCP Port {Portnumber}</tt>"))), ( "response_time", Tuple( title = _("Expected response time"),

11 years

Check_MK Git: check_mk: Updated bug entries #0978, #0949

by Mathias Kettner

Module: check_mk Branch: master Commit: 28a887b6692144014c5b4879e4c9b0447b845143 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=28a887b6692144… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Oct 18 22:19:30 2013 -0400 Updated bug entries #0978, #0949 --- .bugs/949 | 7 +++++-- .bugs/978 | 8 ++++++-- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/.bugs/949 b/.bugs/949 index ef050db..be43955 100644 --- a/.bugs/949 +++ b/.bugs/949 @@ -1,11 +1,14 @@ Title: Add directory local/share/check_mk/mibs Component: core -State: open +Class: nastiness +State: done Date: 2013-08-29 10:51:27 Targetversion: future -Class: nastiness The option --snmptranslate allows to install SNMP MIBs in that directory. In non-OMD-Situtations another directory is being used. Setup/OMD should make sure that those directories always exist. + +2013-10-18 22:12:02: changed state open -> done +Done in omdistro.org. Will soon be available also in CMK builds. diff --git a/.bugs/978 b/.bugs/978 index b64fe32..e43193d 100644 --- a/.bugs/978 +++ b/.bugs/978 @@ -1,9 +1,13 @@ Title: list index out of range when deleting last site Component: wato -State: open +Class: nastiness +State: works4me Date: 2013-09-17 18:05:17 Targetversion: 1.4.0 -Class: nastiness Configure two sites in the Distributed Monitoring setup. Then delete both sites. After you delete the last one you can a WATO exception. + +2013-10-18 22:16:14: changed state open -> works4me +Cannot reproduced. But could have been the same bug that has +already been fixed recently.

11 years

Check_MK Git: check_mk: sensatronics_temp: renamed service description

by Mathias Kettner

Module: check_mk Branch: master Commit: c9c675d0ce63b8a2dfd8b7193cf9688952224e81 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c9c675d0ce63b8… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Sat Oct 19 12:37:34 2013 -0400 sensatronics_temp: renamed service description Is now consistent with all other temperature checks --- checks/sensatronics_temp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/checks/sensatronics_temp b/checks/sensatronics_temp index 0fbd9c0..4007a33 100644 --- a/checks/sensatronics_temp +++ b/checks/sensatronics_temp @@ -33,7 +33,7 @@ def check_sensatronics_temp(item, params, info): if line[0] == item: warn, crit = params temperatur = savefloat(line[1]) - message = "Temperatur: %.2f°C" % temperatur + message = "Temperature: %.2f°C" % temperatur perf = [ ('temp', temperatur, warn, crit ) ] if temperatur > crit: return 2, message, perf @@ -46,7 +46,7 @@ def check_sensatronics_temp(item, params, info): check_info["sensatronics_temp"] = { "check_function" : check_sensatronics_temp, "inventory_function" : inventory_sensatronics_temp, - "service_description" : "Sensor %s", + "service_description" : "Temperature %s", "has_perfdata" : True, "group" : "room_temperature", "snmp_scan_function" : lambda oid: oid(".1.3.6.1.2.1.1.2.0") in [".1.3.6.1.4.1.16174.1.1.1"] ,

11 years

Check_MK Git: check_mk: Updated bug entries #0941

by Mathias Kettner

Module: check_mk Branch: master Commit: 1c6995c5d7e2008007c62c9e1da3246351a26dbb URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1c6995c5d7e200… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Oct 18 22:09:43 2013 -0400 Updated bug entries #0941 --- .bugs/941 | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.bugs/941 b/.bugs/941 index 3922102..7ecc8c0 100644 --- a/.bugs/941 +++ b/.bugs/941 @@ -1,9 +1,9 @@ Title: check_tcp service description, duplicates Component: checks -State: open +Class: nastiness +State: done Date: 2013-10-16 11:47:45 Targetversion: future -Class: nastiness Create two active tcp checks with the same port on one host Each service description is 'TCP Port 24' @@ -14,3 +14,6 @@ Error creating configuration: ERROR: Duplicate service description (active check - 2nd occurrance: checktype = active(tcp), item = None + +2013-10-18 22:09:38: changed state open -> done +Service description can now be specified.

11 years

Check_MK Git: check_mk: BI: Fixed blue triangle link

by Mathias Kettner

Module: check_mk Branch: master Commit: 3f464ef6a3fd723fcab0ac05599130b5fd6637e9 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3f464ef6a3fd72… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Oct 18 09:10:06 2013 -0500 BI: Fixed blue triangle link --- .bugs/1078 | 6 ++++-- ChangeLog | 2 ++ web/plugins/views/bi.py | 20 +++++++++++++++----- web/plugins/views/builtin.py | 32 ++++++++++++++++---------------- 4 files changed, 37 insertions(+), 23 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=3f464ef6a3…

11 years

Check_MK Git: check_mk: Updated bug entries #0997

by Mathias Kettner

Module: check_mk Branch: master Commit: 5e65138159cc717aca8bdcfe1f268802f0660445 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5e65138159cc71… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Oct 18 09:16:03 2013 -0500 Updated bug entries #0997 --- .bugs/997 | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.bugs/997 b/.bugs/997 index da1d2f5..82d0e03 100644 --- a/.bugs/997 +++ b/.bugs/997 @@ -1,8 +1,12 @@ Title: OptionalDropdownChoice and Rule Items Component: wato -State: open +Class: bug +State: works4me Date: 2013-08-07 16:47:10 Targetversion: future -Class: bug When using OptionalDropdownChoices otheritems are not displayed + +2013-10-18 09:16:00: changed state open -> works4me +Cannot find any problem here. "otheritems" is not defined anyway. +There is just an "otherlabel".

11 years

Check_MK Git: check_mk: Fixed code indentation in one WATO rule

by Mathias Kettner

Module: check_mk Branch: master Commit: 31e583ee51801d168778f6d2904b43238702cc4a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=31e583ee51801d… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Oct 18 09:15:23 2013 -0500 Fixed code indentation in one WATO rule --- web/plugins/wato/check_parameters.py | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py index 1dd18c2..e76dd2f 100644 --- a/web/plugins/wato/check_parameters.py +++ b/web/plugins/wato/check_parameters.py @@ -1381,8 +1381,6 @@ register_check_parameters( has_inventory = False, ) - - register_check_parameters( subgroup_applications, "msx_queues", @@ -1393,17 +1391,17 @@ register_check_parameters( Integer(title = _("Warning if above"), unit = _("E-Mails")), Integer(title = _("Critical if above"), unit = _("E-Mails")) ]), - OptionalDropdownChoice( - title = _("Explicit Queue Names"), - help = _("Select queue names that the rule should apply"), - choices = [ - ( "Active Remote Delivery", _("Active Remote Delivery") ), - ( "Retry Remote Delivery", _("Retry Remote Delivery") ), - ( "Active Mailbox Delivery", _("Active Mailbox Delivery") ), - ( "Poison Queue Length", _("Poison Queue Length") ), - ], - otherlabel = _("specify manually ->"), - explicit = TextAscii(allow_empty = False)), + OptionalDropdownChoice( + title = _("Explicit Queue Names"), + help = _("Select queue names that the rule should apply"), + choices = [ + ( "Active Remote Delivery", _("Active Remote Delivery") ), + ( "Retry Remote Delivery", _("Retry Remote Delivery") ), + ( "Active Mailbox Delivery", _("Active Mailbox Delivery") ), + ( "Poison Queue Length", _("Poison Queue Length") ), + ], + otherlabel = _("specify manually ->"), + explicit = TextAscii(allow_empty = False)), "first" )

11 years

← Newer
1
...
10
11
12
13
14
15
16
...
39
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits October 2013