Checkmk git commits January 2013

checkmk-commits@lists.checkmk.com

3 participants
210 discussions

Check_MK Git: check_mk: Updated bug entries #0904, #0905, #0902, #0903

by Lars Michelsen

Module: check_mk Branch: master Commit: bfdeac25808749639367332beb452533131470d4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=bfdeac25808749… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Jan 31 11:23:30 2013 +0100 Updated bug entries #0904, #0905, #0902, #0903 --- .bugs/902 | 9 +++++++++ .bugs/903 | 8 ++++++++ .bugs/904 | 8 ++++++++ .bugs/905 | 26 ++++++++++++++++++++++++++ .bugs/config | 1 + 5 files changed, 52 insertions(+), 0 deletions(-) diff --git a/.bugs/902 b/.bugs/902 new file mode 100644 index 0000000..ccc22ac --- /dev/null +++ b/.bugs/902 @@ -0,0 +1,9 @@ +Title: execute action but directly drop message afterwards +Component: ec +State: open +Date: 2013-01-31 11:13:50 +Targetversion: 1.2.2 +Class: feature + +We need to be able to execute actions but directly drop the message +afterwards without creating an event from it. diff --git a/.bugs/903 b/.bugs/903 new file mode 100644 index 0000000..e0ec6ea --- /dev/null +++ b/.bugs/903 @@ -0,0 +1,8 @@ +Title: Umlauts in regexes never match +Component: ec +State: open +Date: 2013-01-31 11:14:47 +Targetversion: 1.2.2 +Class: bug + +When adding umlauts like ä to regex patterns, they do never match. diff --git a/.bugs/904 b/.bugs/904 new file mode 100644 index 0000000..2226d0b --- /dev/null +++ b/.bugs/904 @@ -0,0 +1,8 @@ +Title: References like \1 \2 to regex groups do not work in "expect regular messages" mode +Component: ec +State: open +Date: 2013-01-31 11:17:10 +Targetversion: 1.2.2 +Class: bug + +In this case, e.g. when rewriting the message text, it only shows \1 \2. diff --git a/.bugs/905 b/.bugs/905 new file mode 100644 index 0000000..a830a7e --- /dev/null +++ b/.bugs/905 @@ -0,0 +1,26 @@ +Title: We need an option to make "expect messages" based on subregexes possible +Component: ec +State: open +Date: 2013-01-31 11:18:44 +Targetversion: 1.2.2 +Class: feature + +For example, when having several logentries which are sent regularly, like + +SRV-12345 is alive +SRV-52345 is alive +SRV-62345 is alive +SRV-72345 is alive +SRV-82345 is alive + +The following pattern matches them all: + +SRV-([0-9]{5}) is alive + +Imagine, we have about 2000 different SRV-* entries in the log and we must +create a regular message expectation rule for each of those single SRV-* +items. + +Once a number (subpatter) is received for the first time, the expection counter +must start and raise an event for this single number if it has not been received +for about a minute. diff --git a/.bugs/config b/.bugs/config index 729d4bf..7e02900 100644 --- a/.bugs/config +++ b/.bugs/config @@ -12,6 +12,7 @@ components = [ ( "checks", "Checks and Agent plugins" ), ( "multisite", "Multisite GUI" ), ( "livestatus", "Livestatus" ), + ( "ec", "Event Console" ), ( "livecheck", "Livecheck part in Livestatus, livecheck helper" ), ( "wato", "Check_MK's Web Administration Tool" ), ( "bi", "BI - Business Intelligence" ),

11 years, 8 months

Check_MK Git: check_mk: Updated bug entries #0907

by Lars Michelsen

Module: check_mk Branch: master Commit: 208231d141c5c3edf5a074baa7c26e0093c4cde1 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=208231d141c5c3… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Jan 31 11:30:28 2013 +0100 Updated bug entries #0907 --- .bugs/907 | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/.bugs/907 b/.bugs/907 new file mode 100644 index 0000000..226cc5c --- /dev/null +++ b/.bugs/907 @@ -0,0 +1,12 @@ +Title: Create default rules +Component: ec +State: open +Date: 2013-01-31 11:28:37 +Targetversion: 1.2.2 +Class: feature + +Create a set of default rules, at least one rule which should remain as +"last rule" which simply drops all messages not handled by the rules +above. When having a rule, it is possible to count the times this rule +was used to maybe define better "catch & drop" rules at the beginning +of the ruleset

11 years, 8 months

Check_MK Git: check_mk: Merge branch 'master' of mathias-kettner.de: check_mk

by Lars Michelsen

Module: check_mk Branch: master Commit: 79315452bd85ee4cb3ad4942dc07bc66fba83ecf URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=79315452bd85ee… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Jan 31 11:30:46 2013 +0100 Merge branch 'master' of mathias-kettner.de:check_mk ---

11 years, 8 months

Check_MK Git: check_mk: Merge branch 'master' of ssh://mathias-kettner.de/ check_mk

by Mathias Kettner

Module: check_mk Branch: master Commit: 446ed4be9fe4e878421135ace1d40bfca4fc99ba URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=446ed4be9fe4e8… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Jan 30 17:59:53 2013 +0100 Merge branch 'master' of ssh://mathias-kettner.de/check_mk ---

11 years, 8 months

Check_MK Git: check_mk: Fix alignment of number inputs

by Mathias Kettner

Module: check_mk Branch: master Commit: aabd66271710c9d5d7056719c19c00bbe4ded934 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=aabd66271710c9… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Jan 30 17:59:49 2013 +0100 Fix alignment of number inputs --- web/htdocs/check_mk.css | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/web/htdocs/check_mk.css b/web/htdocs/check_mk.css index 1d03130..d76586a 100644 --- a/web/htdocs/check_mk.css +++ b/web/htdocs/check_mk.css @@ -72,6 +72,10 @@ button, input, td, th, select, textarea { font-size: 9pt; } +input.number { + text-align: right; +} + /* Styling for input elements */ input, select, textarea { padding: 3px;

11 years, 8 months

Check_MK Git: check_mk: Improved performance of logwatch. ec check in case of many messages

by Lars Michelsen

Module: check_mk Branch: master Commit: fe3a48ebffa242f95043b7702ea263b25eaeba70 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=fe3a48ebffa242… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jan 30 17:25:36 2013 +0100 Improved performance of logwatch.ec check in case of many messages --- ChangeLog | 1 + checks/logwatch | 7 ++++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 2ca36a8..769a6a4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -21,6 +21,7 @@ * FIX: logwatch.ec: use UNIX socket instead of Pipe for forwarding into EC * FIX: logwatch.ec: fixed exception when forwarding "OK" lines * FIX: logwatch.ec: fixed forwarding of single log lines to event console + * Improved performance of logwatch.ec check in case of many messages * livestatus_status: new check for monitoring performance of monitoring Multisite: diff --git a/checks/logwatch b/checks/logwatch index 1fd8f04..b42c87e 100644 --- a/checks/logwatch +++ b/checks/logwatch @@ -432,11 +432,12 @@ def check_logwatch_ec(_unused, params, info): # 2. create syslog message of each line # <128> Oct 24 10:44:27 Klappspaten /var/log/syslog: Oct 24 10:44:27 Klappspaten logger: asdasdad as # <facility+priority> timestamp hostname logfile: message - facility = params.get('facility', 17) # default to "local1" + facility = params.get('facility', 17) << 3 # default to "local1" messages = [] + cur_time = syslog_time() for logfile, line in logs: - msg = '<%d>' % ((facility << 3) + logwatch_to_prio(line[0]),) - msg += '%s %s %s: %s' % (syslog_time(), g_hostname, logfile, line[2:]) + msg = '<%d>' % (facility + logwatch_to_prio(line[0]),) + msg += '%s %s %s: %s' % (cur_time, g_hostname, logfile, line[2:]) messages.append(msg) # 3. send lines to event console

11 years, 8 months

Check_MK Git: check_mk: Fixed exception in mkeventd after latest socket/ pipe rewrite

by Lars Michelsen

Module: check_mk Branch: master Commit: 55520d3e1677f7cb578e05a294f090d28f4ef6b3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=55520d3e1677f7… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jan 30 17:25:58 2013 +0100 Fixed exception in mkeventd after latest socket/pipe rewrite --- mkeventd/bin/mkeventd | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mkeventd/bin/mkeventd b/mkeventd/bin/mkeventd index bc0be97..72256a2 100755 --- a/mkeventd/bin/mkeventd +++ b/mkeventd/bin/mkeventd @@ -857,7 +857,7 @@ class EventServer: pass # Read events from builtin syslog server - if self._syslog.fileno() in readable: + if self._syslog != None and self._syslog.fileno() in readable: self.process_event_data(self._syslog.recv(4096)) if opt_profile.get("event"):

11 years, 8 months

Check_MK Git: check_mk: FIX: logwatch.ec: fixed exception when forwarding " OK" lines

by Lars Michelsen

Module: check_mk Branch: master Commit: a313d7350857b1f06b4b0361c8e3139007880a24 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a313d7350857b1… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jan 30 10:24:07 2013 +0100 FIX: logwatch.ec: fixed exception when forwarding "OK" lines --- ChangeLog | 1 + checks/logwatch | 2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index 07d1f42..9760bb0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -18,6 +18,7 @@ * jolokia_metrics.mem: now supports warn/crit levels for heap, nonheap, totalheap * jolokia_metrics.mem: add dedicated PNP graph * FIX: logwatch.ec: use UNIX socket instead of Pipe for forwarding into EC + * FIX: logwatch.ec: fixed exception when forwarding "OK" lines Multisite: * Added comment painter to notification related views diff --git a/checks/logwatch b/checks/logwatch index a8a0706..4e90529 100644 --- a/checks/logwatch +++ b/checks/logwatch @@ -403,7 +403,7 @@ def logwatch_to_prio(level): return 4 elif level == 'C': return 2 - elif level == '0': + elif level == 'O': return 5 elif level == 'u': return 4

11 years, 8 months

Check_MK Git: check_mk: Merge branch 'master' of mathias-kettner.de: check_mk

by Lars Michelsen

Module: check_mk Branch: master Commit: 4711a4bec6d14f869d1bfff17027ac2337e4ff60 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=4711a4bec6d14f… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jan 30 11:37:59 2013 +0100 Merge branch 'master' of mathias-kettner.de:check_mk Conflicts: ChangeLog ---

11 years, 8 months

Check_MK Git: check_mk: FIX: logwatch.ec: fixed forwarding of single log lines to event console

by Lars Michelsen

Module: check_mk Branch: master Commit: baccd286957cf47ef66886758bd3682c3f2275c0 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=baccd286957cf4… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jan 30 10:38:28 2013 +0100 FIX: logwatch.ec: fixed forwarding of single log lines to event console --- ChangeLog | 1 + checks/logwatch | 2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index 9760bb0..f85d995 100644 --- a/ChangeLog +++ b/ChangeLog @@ -19,6 +19,7 @@ * jolokia_metrics.mem: add dedicated PNP graph * FIX: logwatch.ec: use UNIX socket instead of Pipe for forwarding into EC * FIX: logwatch.ec: fixed exception when forwarding "OK" lines + * FIX: logwatch.ec: fixed forwarding of single log lines to event console Multisite: * Added comment painter to notification related views diff --git a/checks/logwatch b/checks/logwatch index 4e90529..05234ab 100644 --- a/checks/logwatch +++ b/checks/logwatch @@ -468,7 +468,7 @@ def check_logwatch_ec(_unused, params, info): # instead of the pipe! sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM) sock.connect(method) - sock.send('\n'.join(messages)) + sock.send('\n'.join(messages) + '\n') sock.close() num_messages = len(messages)

11 years, 8 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits January 2013