Checkmk git commits September 2012

checkmk-commits@lists.checkmk.com

1 participants
212 discussions

Check_MK Git: check_mk: Add new bug entry.

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 3c538abbadb9c2b61f7c28db4887cebaa98fb8a5 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3c538abbadb9c2… Author: Florian Heigl <fh(a)mathias-kettner.de> Date: Mon Sep 17 17:17:44 2012 +0200 Add new bug entry. --- .bugs/800 | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/.bugs/800 b/.bugs/800 new file mode 100644 index 0000000..a90a519 --- /dev/null +++ b/.bugs/800 @@ -0,0 +1,15 @@ +Title: mounts check reinventory seems to not change fs options +Component: checks +State: open +Date: 2012-09-17 17:12:57 +Targetversion: future +Class: nastiness + +This is a bit confusing, but it seems the mount options stay hardcoded +even if you run a new WATO inventory of a given system. +This goes as far as showing "OK" on the inventory screen, but the check +stays WARN anyways + +OK - missing: data=journal, exceeding: data=writeback + +You can test by changing the journal option forth and back.

12 years

Check_MK Git: check_mk: Merge branch 'master' of mathias-kettner.de: check_mk

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 3c9ef9292bbffcb5b18e8aea567d3860c0843ddc URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3c9ef9292bbffc… Author: Florian Heigl <fh(a)mathias-kettner.de> Date: Fri Sep 14 17:28:32 2012 +0200 Merge branch 'master' of mathias-kettner.de:check_mk ---

12 years

Check_MK Git: check_mk: mk_jolokia now gets server status for tomcat apps

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 75ce21be424ec9b56d6c04ec5d5f0acd852bbb84 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=75ce21be424ec9… Author: Florian Heigl <fh(a)mathias-kettner.de> Date: Fri Sep 14 17:28:24 2012 +0200 mk_jolokia now gets server status for tomcat apps --- agents/plugins/mk_jolokia | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/agents/plugins/mk_jolokia b/agents/plugins/mk_jolokia index bc83dc4..8a2ac77 100755 --- a/agents/plugins/mk_jolokia +++ b/agents/plugins/mk_jolokia @@ -166,6 +166,7 @@ global_vars = [ ( "java.lang:type=Runtime/Uptime", "Uptime", [] ), ] + specific_vars = { "weblogic" : [ ( "*:*/CompletedRequestCount", None, [ "ServerRuntime" ] ), @@ -179,6 +180,9 @@ specific_vars = { ], "tomcat" : [ ( "*:type=Manager,*/activeSessions,maxActiveSessions", None, [ "path", "context" ] ), + ( "*:type=Manager,*/stateName", None, [ "path", "context" ] ), +# ( "*:J2EEApplication=none,J2EEServer=none,WebModule=*,j2eeType=Servlet,name=jsp/stateName", None, [ "path", "context" ] ), +# ( "Catalina:J2EEApplication=none,J2EEServer=none,j2eeType=WebModule=,name=*,stateName", None, [ "path", "context" ] ), ], "jboss" : [ ( "*:type=Manager,*/activeSessions,maxActiveSessions", None, [ "path", "context" ] ),

12 years

Check_MK Git: check_mk: agents/plugins/mk_jolokia

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 05c893fb8af920da6d5a73047d82e2e88b5cbdd4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=05c893fb8af920… Author: Florian Heigl <fh(a)mathias-kettner.de> Date: Fri Sep 14 17:27:43 2012 +0200 agents/plugins/mk_jolokia mk_jolokia now gets server status for tomcat apps --- checks/jolokia_metrics | 22 +++++++++++++++++----- 1 files changed, 17 insertions(+), 5 deletions(-) diff --git a/checks/jolokia_metrics b/checks/jolokia_metrics index b419fb2..3237750 100644 --- a/checks/jolokia_metrics +++ b/checks/jolokia_metrics @@ -107,7 +107,7 @@ def inventory_jolokia_metrics_apps(info, what): needed_key = [ "StandbyThreadCount" ] levels = None else: - needed_key = [ "Running" ] + needed_key = [ "Running", "stateName" ] levels = None for inst, vals in parsed.iteritems(): for app, appstate in vals.get('apps', {}).items(): @@ -209,12 +209,24 @@ def check_jolokia_metrics_uptime(item, _unused, info): def check_jolokia_metrics_app_state(item, _unused, info): app = jolokia_metrics_app(info, item.split()) - if not app or not 'Running' in app: + app_state=3 + # FIXME: this could be nicer. + if app and "Running" in app: + if app['Running'] == '1': + app_state = 0 + else: + app_state = 2 + # wenn in app statename steht + elif app and "stateName" in app: + if app['stateName'] == 'STARTED': + app_state = 0 + else: + app_state = 2 + if app_state == 3: return (3, "UNKNOWN - data not found in agent output") - - if app['Running'] == '1': + elif app_state == 0: return (0, 'OK - application is running') - else: + elif app_state == 2: return (2, 'CRIT - application is not running (Running: %s)')

12 years

Check_MK Git: check_mk: FIX: fixed layout of login dialog when showing up error messages

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: e18989258b5a648c007078d6c8029da036a632ec URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e18989258b5a64… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Sep 14 14:35:14 2012 +0200 FIX: fixed layout of login dialog when showing up error messages --- .bugs/768 | 7 +++++-- ChangeLog | 1 + web/htdocs/login.css | 2 ++ 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.bugs/768 b/.bugs/768 index a299088..25a0773 100644 --- a/.bugs/768 +++ b/.bugs/768 @@ -1,9 +1,12 @@ Title: Login dialog - layout broken on failed login Component: multisite -State: open +Class: nastiness +State: done Date: 2012-06-11 09:17:50 Targetversion: 1.2.0 -Class: nastiness When you login with a wrong password, then the layout of the error field text is garbled (at least on Chrome). + +2012-09-14 14:34:41: changed state open -> done +Fixed layout in chrome and firefox. diff --git a/ChangeLog b/ChangeLog index bf7db01..fd88aa1 100644 --- a/ChangeLog +++ b/ChangeLog @@ -107,6 +107,7 @@ * FIX: fixed logwatch loosing the master_url parameter in distributed setups * FIX: Fixed doubled var "site" in view editor (site and siteopt filter) * FIX: Don't crash on requests without User-Agent HTTP header + * FIX: fixed layout of login dialog when showing up error messages Livecheck: * FIX: Compile livecheck also if diet libc is missing diff --git a/web/htdocs/login.css b/web/htdocs/login.css index 796700d..78c77f3 100644 --- a/web/htdocs/login.css +++ b/web/htdocs/login.css @@ -165,6 +165,8 @@ label { margin: 0px; padding: 8px 0px 0px 0px; color: black; + border-radius: 0; + box-shadow: 0 0 0; } #foot {

12 years

Check_MK Git: check_mk: Updated bug entries #0705

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 3195bb3ccf1d16c7eb388624ccd316f24a231059 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3195bb3ccf1d16… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Sep 14 14:37:59 2012 +0200 Updated bug entries #0705 --- .bugs/705 | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/.bugs/705 b/.bugs/705 new file mode 100644 index 0000000..3a1c8c6 --- /dev/null +++ b/.bugs/705 @@ -0,0 +1,9 @@ +Title: Logwatch: confirm not the whole logfile, only one block/message +Component: multisite +State: open +Date: 2012-09-14 14:36:42 +Targetversion: future +Class: feature + +When having several errors in one logfile in logwatch one might not want to confirm +all present error messages but only a subset of the messages.

12 years

Check_MK Git: check_mk: cmk -D shows multiple agent types e.g.

by git＠mathias-kettner.de

when using SNMP and TCP on one host User-Agent: Heirloom mailx 12.4 7/29/08 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Module: check_mk Branch: master Commit: 2bf58fa99334f1ba2293c075fb17d1ea94a1e213 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2bf58fa99334f1… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Sep 14 14:59:22 2012 +0200 cmk -D shows multiple agent types e.g. when using SNMP and TCP on one host --- ChangeLog | 1 + modules/check_mk.py | 22 +++++++++++++++------- 2 files changed, 16 insertions(+), 7 deletions(-) diff --git a/ChangeLog b/ChangeLog index fd88aa1..eaecce0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -8,6 +8,7 @@ * Contacts can now define *_notification_commands attributes which can now override the default notification command check-mk-notify * SNMP scan: fixed case where = was contained in SNMP info + * cmk -D shows multiple agent types e.g. when using SNMP and TCP on one host Checks & Agents: * New Checks for Siemens Blades (BX600) diff --git a/modules/check_mk.py b/modules/check_mk.py index 230cfeb..4491a82 100755 --- a/modules/check_mk.py +++ b/modules/check_mk.py @@ -3581,14 +3581,18 @@ def dump_host(hostname): print tty_yellow + "Parents: " + tty_normal + ", ".join(parents_list) print tty_yellow + "Host groups: " + tty_normal + ", ".join(hostgroups_of(hostname)) print tty_yellow + "Contact groups: " + tty_normal + ", ".join(host_contactgroups_of([hostname])) - agenttype = "TCP (port: %d)" % agent_port_of(hostname) - dapg = get_datasource_program(hostname, ipaddress) - if dapg: - agenttype = "Datasource program: %s" % dapg + + agenttypes = [] + if is_tcp_host(hostname): + agenttypes.append("TCP (port: %d)" % agent_port_of(hostname)) + else: + dapg = get_datasource_program(hostname, ipaddress) + if dapg: + agenttypes.append("Datasource program: %s" % dapg) if is_snmp_host(hostname): if is_usewalk_host(hostname): - agenttype = "SNMP (use stored walk)" + agenttypes.append("SNMP (use stored walk)") else: credentials = snmp_credentials_of(hostname) if is_bulkwalk_host(hostname): @@ -3598,8 +3602,12 @@ def dump_host(hostname): portinfo = snmp_port_of(hostname) if portinfo == None: portinfo = 'default' - agenttype = "SNMP (community: '%s', bulk walk: %s, port: %s)" % (credentials, bulk, portinfo) - print tty_yellow + "Type of agent: " + tty_normal + agenttype + agenttypes.append("SNMP (community: '%s', bulk walk: %s, port: %s)" % (credentials, bulk, portinfo)) + + if is_ping_host(hostname): + agenttypes.append('PING only') + + print tty_yellow + "Type of agent: " + tty_normal + '\n '.join(agenttypes) is_aggregated = host_is_aggregated(hostname) if is_aggregated: print tty_yellow + "Is aggregated: " + tty_normal + "yes"

12 years

Check_MK Git: check_mk: Merge branch 'master' of mathias-kettner.de: check_mk

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 23bd40f76ab44e6b2d7082e8fa5137098c401bcb URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=23bd40f76ab44e… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Sep 14 14:59:28 2012 +0200 Merge branch 'master' of mathias-kettner.de:check_mk ---

12 years

Check_MK Git: check_mk: Check Manpage for jolokia_metrics.app_state

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 98ecc01c1ce146273aa31c48d9bd07fc20e9e1d3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=98ecc01c1ce146… Author: Florian Heigl <fh(a)mathias-kettner.de> Date: Fri Sep 14 14:37:53 2012 +0200 Check Manpage for jolokia_metrics.app_state --- checkman/jolokia_metrics.app_state | 22 ++++++++++++++++++++++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/checkman/jolokia_metrics.app_state b/checkman/jolokia_metrics.app_state new file mode 100644 index 0000000..c0a6247 --- /dev/null +++ b/checkman/jolokia_metrics.app_state @@ -0,0 +1,22 @@ +title: State of JVM applications +agents: linux +author: Mathias Kettner <mk(a)mathias-kettner.de> +license: GPL +distribution: check_mk +description: + This check allows to monitor the state of a single application running on a JVM (i.e. /host-manager or /my-web-app) + + To use this plugin, Jolokia and the agent plugin need to be installed + on the monitored server. + + The check will return {OK} if the application is found running, or + {CRIT} if it is stopped. + +item: + The name of the application server instance as configured by the agent + followed by the name of the application. I.e. tomcat7 /examples + + +inventory: + One check is created for each application running inside an Jolokia + instance sent by the agent.

12 years

Check_MK Git: check_mk: Merge branch 'master' of mathias-kettner.de: check_mk

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: eb7d70b1bdeceb725b8297832160bd21ffe1e162 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=eb7d70b1bdeceb… Author: Florian Heigl <fh(a)mathias-kettner.de> Date: Fri Sep 14 14:13:21 2012 +0200 Merge branch 'master' of mathias-kettner.de:check_mk ---

12 years

← Newer
1
...
11
12
13
14
15
16
17
...
22
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits September 2012