Checkmk git commits August 2012

checkmk-commits@lists.checkmk.com

1 participants
82 discussions

Check_MK Git: check_mk: Catch error in get_url_sync function

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 47aa2e3c60f605bab16b8b04d90cd387b8d0a520 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=47aa2e3c60f605… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Thu Aug 9 11:50:34 2012 +0200 Catch error in get_url_sync function --- web/htdocs/js/checkmk.js | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/web/htdocs/js/checkmk.js b/web/htdocs/js/checkmk.js index e7e63d8..1a37e37 100644 --- a/web/htdocs/js/checkmk.js +++ b/web/htdocs/js/checkmk.js @@ -161,9 +161,14 @@ function get_url_sync(url) { var AJAX = new ActiveXObject("Microsoft.XMLHTTP"); } - AJAX.open("GET", url, false); - AJAX.send(null); - return AJAX.responseText; + try + { + AJAX.open("GET", url, false); + AJAX.send(null); + return AJAX.responseText; + } catch(err) { + return false; + } }

11 years, 10 months

Check_MK Git: check_mk: Updated bug entries #0737

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 650d335f345fd70870d3728079514b8be9d0182d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=650d335f345fd7… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Wed Aug 8 13:27:56 2012 +0200 Updated bug entries #0737 --- .bugs/737 | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/.bugs/737 b/.bugs/737 new file mode 100644 index 0000000..01c6a8c --- /dev/null +++ b/.bugs/737 @@ -0,0 +1,11 @@ +Title: Get Services, comments with info always empty +Component: livestatus +State: open +Date: 2012-08-08 12:00:25 +Targetversion: future +Class: bug + +GET servicesbyhostgroup\nColumns: host_name comments_with_info\n +ony retruns hostname, the comments with info are always empty. + +Refernce in Ticket System: #608092

11 years, 10 months

Check_MK Git: check_mk: Wato: Fixed handling of regex in check_http

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: cc9c34e297a0bd448b4ecb74c534f20ed257cc67 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=cc9c34e297a0bd… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Wed Aug 8 11:53:10 2012 +0200 Wato: Fixed handling of regex in check_http --- checks/check_http | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/checks/check_http b/checks/check_http index e96812c..46bfbb5 100644 --- a/checks/check_http +++ b/checks/check_http @@ -83,6 +83,13 @@ def check_http_arguments(params): if "expect_string" in settings: args += ' -s %s' % quote_shell_string(settings["expect_string"]) + if "expect_regex" in settings: + args += ' -r %s' % quote_shell_string(settings['expect_regex'][0]) + if settings['expect_regex'][1]: + args += ' -R' + if settings['expect_regex'][2]: + args += ' --invert-regex' + if "post_data" in settings: data, content_type = settings["post_data"] args += ' -P %s -T %s' % \

11 years, 10 months

Check_MK Git: check_mk: Merge branch 'master' of ssh://mathias-kettner.de/ check_mk

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 10b3a9eaefc4f6bfdd9bd87914ba243aba95f85e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=10b3a9eaefc4f6… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Wed Aug 8 11:34:11 2012 +0200 Merge branch 'master' of ssh://mathias-kettner.de/check_mk ---

11 years, 10 months

Check_MK Git: check_mk: Updated bug entries #0736, #0733, #0734, #0735

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: cdd4c2efd50bd25c66cd2cbfdffb57b6d14ff9cd URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=cdd4c2efd50bd2… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Wed Aug 8 11:33:58 2012 +0200 Updated bug entries #0736, #0733, #0734, #0735 --- .bugs/733 | 9 +++++++++ .bugs/734 | 45 +++++++++++++++++++++++++++++++++++++++++++++ .bugs/735 | 10 ++++++++++ .bugs/736 | 46 ++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 110 insertions(+), 0 deletions(-) diff --git a/.bugs/733 b/.bugs/733 new file mode 100644 index 0000000..09f290a --- /dev/null +++ b/.bugs/733 @@ -0,0 +1,9 @@ +Title: Turnoff context in logwatch +Component: checks +State: open +Date: 2012-08-06 16:02:17 +Targetversion: future +Class: feature + +It should be possible to turn the saving of context logentries from logwatch off. +In some cases are there hunderts of not needed entries and the 500kb limit are full with only one error line diff --git a/.bugs/734 b/.bugs/734 new file mode 100644 index 0000000..a61c8a9 --- /dev/null +++ b/.bugs/734 @@ -0,0 +1,45 @@ +Title: Logwatch, logfile names with date +Component: checks +State: open +Date: 2012-08-08 11:15:14 +Targetversion: future +Class: feature + +We have a requirement from our developers to monitor log files in the format: /path/logfile.20120719 with the date changing every day. +To do this, we added code to the parse and change the name in the config file: + +# cat /etc/check_mk/logwatch.cfg +/var/log/test.DATE +C test + +Now to interpret it, we changed the mk_logwatch + +[root@temolate2 ~]# diff mk_logwatch.newest /usr/lib/check_mk_agent/plugins/mk_logwatch +30,35d29 +< from datetime import date +< dd=date.today().strftime("%Y%m%d") +< yyear = date.today().strftime("%Y") +< year = date.today().strftime("%y") +< month = date.today().strftime("%m") +< day = date.today().strftime("%d") +278,284d270 +< gsave = glob +< glob=glob.replace('DATE',dd) +< glob=glob.replace('YYYY',yyear) +< glob=glob.replace('YY',year) +< glob=glob.replace('MM',month) +< glob=glob.replace('DD',day) +< +294c280 +< process_logfile(logfile, patterns, gsave) +--- +> process_logfile(logfile, patterns) + +Could you please add this feature to the next version of the logwatch plugin. + +Thanks! + +Best Regards, + +Roman Lazarev +Information Technology Division diff --git a/.bugs/735 b/.bugs/735 new file mode 100644 index 0000000..2ca4f76 --- /dev/null +++ b/.bugs/735 @@ -0,0 +1,10 @@ +Title: Notes field for Activate Changes in Wato +Component: wato +State: open +Date: 2012-08-08 11:18:29 +Targetversion: future +Class: feature + +* Add a notes field associated with an activate changes (auditing) - we would like to be able to say such and such a change was related to our ticketing system ticket xxxx, for instance + +o Optional - make it a choice to make the field required diff --git a/.bugs/736 b/.bugs/736 new file mode 100644 index 0000000..f575c61 --- /dev/null +++ b/.bugs/736 @@ -0,0 +1,46 @@ +Title: Livechecks goes zoombie +Component: livecheck +State: open +Date: 2012-08-08 11:32:12 +Targetversion: future +Class: bug + +Have been using livecheck and came across this rather nasty bug. We +use livecheck for a whole bunch of http checks (check_http) and after +a while, one of the checks will "hang" and the livecheck process +becomes a "Zombie" process. + +# ps faux +nagios 10880 12.4 2.0 573000 12380 ? Ssl 12:16 16:19 +/usr/bin/nagios -d /etc/nagios/nagios.cfg +nagios 10889 0.0 0.1 11848 1036 ? S 12:16 0:00 \_ +livecheck /var/spool/nagios/checkresults 30 60 +nagios 4100 0.0 0.0 0 0 ? Z 13:44 0:00 | +\_ [livecheck] +nagios 4120 0.0 0.5 138664 3504 ? S 13:44 0:01 +/usr/lib64/nagios/plugins/check_http -H xxx -t 15 -f follow -S + +# strace -p 10880 +Process 10880 attached - interrupt to quit +read(15, + +# strace -p 10889 +Process 10889 attached - interrupt to quit +read(4, + +# strace -p 4120 +Process 4120 attached - interrupt to quit +futex(0x7f996e8bde80, FUTEX_WAIT_PRIVATE, 2, NULL + +Nagios completely stops doing anything, when you kill the check_http +process, Nagios comes back to life: + +nagios.log: +[1343918059] Warning: A system time change of 0d 0h 47m 11s (forwards +in time) has been detected. Compensating... + + + + + +Reference in Ticket System: #110644

11 years, 10 months

Check_MK Git: check_mk: Multisite: Handling plain_error parameter also on page not found errors

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 59458a730643a14927961b2af2a45870a3b1834d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=59458a730643a1… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Aug 7 09:58:33 2012 +0200 Multisite: Handling plain_error parameter also on page not found errors --- web/htdocs/index.py | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/web/htdocs/index.py b/web/htdocs/index.py index ccd09e5..c5e5377 100644 --- a/web/htdocs/index.py +++ b/web/htdocs/index.py @@ -409,6 +409,9 @@ def handler(req, profiling = True): return response_code def page_not_found(): - html.header(_("Page not found")) - html.show_error(_("This page was not found. Sorry.")) + if html.has_var("_plain_error"): + html.write(_("Page not found")) + else: + html.header(_("Page not found")) + html.show_error(_("This page was not found. Sorry.")) html.footer()

11 years, 10 months

Check_MK Git: check_mk: Merge branch 'master' of mathias-kettner.de: check_mk

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 9e44e3b052625d9b4b350838d4c1585900c3b366 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=9e44e3b052625d… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Aug 7 09:58:37 2012 +0200 Merge branch 'master' of mathias-kettner.de:check_mk ---

11 years, 10 months

Check_MK Git: check_mk: Added helper function for custom host var painters

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 4a9e0423430429b88780d00d013f6fca006e5b71 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=4a9e0423430429… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Mon Aug 6 15:15:56 2012 +0200 Added helper function for custom host var painters --- web/plugins/views/painters.py | 11 ++++++++++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/web/plugins/views/painters.py b/web/plugins/views/painters.py index c789e38..9bce496 100644 --- a/web/plugins/views/painters.py +++ b/web/plugins/views/painters.py @@ -103,6 +103,16 @@ multisite_painter_options["ts_date"] = { ("%m/%d", "12/18") ] } +# This helper function returns the value of the given custom var +def paint_custom_host_var(what, row): + custom_vars = dict(zip(row["host_custom_variable_names"], + row["host_custom_variable_values"])) + + if what in custom_vars: + return what, custom_vars[what] + return what, "" + + # ___ # |_ _|___ ___ _ __ ___ # | |/ __/ _ \| '_ \/ __| @@ -145,7 +155,6 @@ def paint_icons(what, row): return "icons", output - def iconpainter_columns(what): cols = set(['site', 'host_name',

11 years, 10 months

Check_MK Git: check_mk: FIX: mssql agent: Fixed handling of databases with spaces in names

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 1bf1972584d75a3356470ff2da01f66ce134e558 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1bf1972584d75a… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Aug 6 10:06:37 2012 +0200 FIX: mssql agent: Fixed handling of databases with spaces in names --- ChangeLog | 3 ++- agents/windows/plugins/mssql.vbs | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index dad3486..8796b47 100644 --- a/ChangeLog +++ b/ChangeLog @@ -6,7 +6,6 @@ * parent scan: skip gateways that are reachable via PING Checks & Agents: - * mssql_backup: Fixed problems with datetime/timezone calculations * New Checks for Siemens Blades (BX600) * New Checks for Fortigate Firewalls * FIX: megaraid_pdisks: handle case where no enclosure device exists @@ -21,9 +20,11 @@ * vms_system.ios: new check for total direct/buffered IOs on OpenVMS * vms_system.procs: new check for number of processes on OpenVMS * vms_queuejobs: new check for monitoring current VMS queue jobs + * FIX: mssql_backup: Fixed problems with datetime/timezone calculations * FIX: mssql agent: Added compatibility code for MSSQL 9 * FIX: mssql agent: Fixed connection to default instances ("MSSQLSERVER") * FIX: mssql agent: Fixed check of databases with names starting with numbers + * FIX: mssql agent: Fixed handling of databases with spaces in names * f5_bigip_temp: add performance data * added perf-o-meters for a lot of temperature checks * cmctc_lcp.*: added new checks for Rittal CMC-TC LCP diff --git a/agents/windows/plugins/mssql.vbs b/agents/windows/plugins/mssql.vbs index 318b7b2..b143457 100644 --- a/agents/windows/plugins/mssql.vbs +++ b/agents/windows/plugins/mssql.vbs @@ -157,7 +157,7 @@ For Each instId In instIds.Keys Set RS = RS.NextRecordset i = i + 1 Loop - wscript.echo instId & " " & dbName & " " & dbSize & " " & unallocated & " " & reserved & " " & _ + wscript.echo instId & " " & Replace(dbName, " ", "_") & " " & dbSize & " " & unallocated & " " & reserved & " " & _ data & " " & indexSize & " " & unused Set RS = CreateObject("ADODB.Recordset") Next @@ -173,7 +173,7 @@ For Each instId In instIds.Keys Do While Not RS.Eof lastBackupDate = Trim(RS("last_backup_date")) If lastBackupDate <> "" Then - wscript.echo instId & " " & dbName & " " & lastBackupDate + wscript.echo instId & " " & Replace(dbName, " ", "_") & " " & lastBackupDate End If RS.MoveNext Loop

11 years, 10 months

Check_MK Git: check_mk: FIX: Syntax error in f5_bigip_interfaces check ( hope the file is complete)

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 6c5e308db1a73828580f1690d0761d44ef20f549 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=6c5e308db1a738… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Aug 3 09:55:34 2012 +0200 FIX: Syntax error in f5_bigip_interfaces check (hope the file is complete) --- checks/f5_bigip_interfaces | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/checks/carel_uniflair_cooling b/checks/carel_uniflair_cooling old mode 100755 new mode 100644 diff --git a/checks/f5_bigip_interfaces b/checks/f5_bigip_interfaces index 54dde44..2f90322 100644 --- a/checks/f5_bigip_interfaces +++ b/checks/f5_bigip_interfaces @@ -62,4 +62,4 @@ check_info["f5_bigip_interfaces"] = { "has_perfdata" : True, "snmp_scan_function" : lambda oid: ".1.3.6.1.4.1.3375.2.1.3.4.20" in oid(".1.3.6.1.2.1.1.2.0"), "snmp_info" : ( ".1.3.6.1.4.1.3375.2.1.2.4.4.3.1", [1, 13, 3, 5]), - +} diff --git a/checks/windows_multipath b/checks/windows_multipath old mode 100755 new mode 100644

11 years, 11 months

← Newer
1
2
3
4
5
6
7
8
9
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits August 2012