Checkmk git commits October 2012

checkmk-commits@lists.checkmk.com

1 participants
252 discussions

Check_MK Git: check_mk: Updated bug entries #0817, #0818, #0819, #0820

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 255f47efb3b7aeeee20eee71076570ad0a944a43 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=255f47efb3b7ae… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Wed Oct 24 14:16:55 2012 +0200 Updated bug entries #0817, #0818, #0819, #0820 --- .bugs/817 | 14 ++++++++++++++ .bugs/818 | 37 +++++++++++++++++++++++++++++++++++++ .bugs/819 | 20 ++++++++++++++++++++ .bugs/820 | 8 ++++++++ 4 files changed, 79 insertions(+), 0 deletions(-) diff --git a/.bugs/817 b/.bugs/817 new file mode 100644 index 0000000..db9326f --- /dev/null +++ b/.bugs/817 @@ -0,0 +1,14 @@ +Title: bugs in postgresql_sessions and mk_postgres +Component: checks +State: open +Date: 2012-10-24 09:49:37 +Targetversion: future +Class: bug + + postgresql_sessions: +wrong parsing when query from agent returned only one line with, e.g. +"f 1" +than I've got an error when run "cmk -v /dev/null ; then" + +on Debian there is only a user "postgres" not "pgsql" - maybe double +checks (postgres & pgsql) will do? (because of different distros) diff --git a/.bugs/818 b/.bugs/818 new file mode 100644 index 0000000..47e1d6f --- /dev/null +++ b/.bugs/818 @@ -0,0 +1,37 @@ +Title: check_mk_agent can incorrectly detect postfix on RHEL +Component: core +State: open +Date: 2012-10-24 10:19:40 +Targetversion: future +Class: nastiness + +osTicket ID 443234 +This probably happens on CentOS too, since it's so similar to RHEL. + +When the system has multiple MTA packages installed, and postfix is one of the installed packages, but postfix is not active, the mailq test returns a false result. This is how the code currently checks for the MTA: + +if which mailq >/dev/null 2>&1 && getent passwd postfix >/dev/null 2>&1; then +echo '' +mailq | tail -n 6 +fi + +However, on at least RHEL and CentOS, it is possible and not uncommon to have multiple MTA packages installed concurrently, but you only have one active at a time. The presence of the postfix user (or package) does not imply that postfix is the active MTA. In my case, Exim is active, but the mailq test thinks postfix is active and it doesn't work properly because it's looking for a postfix-formatted mailq, and that's not what it gets. + +The active profile is controlled by the "alternatives" subsystem. For full documentation, see update-alternatives(8). + +http://linux.die.net/man/8/update-alternatives + +A rough test to check for postfix vs. another mailer might look like this. This can probably be streamlined further, this is just something I threw together as a proof of concept... + +if [[ -f /etc/redhat-release || -f /etc/centos-release ]]; then +_mta=$(/usr/sbin/alternatives --display mta | awk '/link currently points to/ {print $5}' | sed -e 's,/usr/sbin/sendmail\.,,') +if [[ "$_mta" = "postfix" ]]; then +# postfix case +elif [[ "$_mta" = "exim" ]]; then +# exim case +else +# default case +fi +else +# this is not redhat or centos, so do your usual getent test here... +fi diff --git a/.bugs/819 b/.bugs/819 new file mode 100644 index 0000000..217a098 --- /dev/null +++ b/.bugs/819 @@ -0,0 +1,20 @@ +Title: Apache Status bug +Component: checks +State: open +Date: 2012-10-24 11:08:13 +Targetversion: 1.2.0 +Class: bug + +osTicket id 258581 +sorry to report a bug regarding the new apache_status in 1.2.0p3. + +I confirmed on the english mailing list, that also other people have the problem. +We get the same result on auto-detecting and specifying server and port: +./apache_status + +Exception (192.168.2.28:80): addinfourl instance has no attribute 'getcode'[root@www local]# + +We tested the server-status url with lynx and it is working fine. + +CentOS release 5.6 (Final) 32-Bit +httpd-2.2.3-65.el5.centos diff --git a/.bugs/820 b/.bugs/820 new file mode 100644 index 0000000..e325b99 --- /dev/null +++ b/.bugs/820 @@ -0,0 +1,8 @@ +Title: Refreshing of row count in multisite +Component: multisite +State: open +Date: 2012-10-24 11:54:14 +Targetversion: future +Class: nastiness + +The count of row in the upper corner of Mulisite show 0/n Rows after automatic refresh, even when the checkboxes not activated.

11 years, 10 months

Check_MK Git: check_mk: Merge branch 'master' of ssh://mathias-kettner.de/ check_mk

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 6511e3fac82748bce68568b4514ae872a449dd44 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=6511e3fac82748… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Oct 24 13:59:32 2012 +0200 Merge branch 'master' of ssh://mathias-kettner.de/check_mk ---

11 years, 10 months

Check_MK Git: check_mk: Added comments in check

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 3c9118a04279eab97eeab785190d4435e71eef6e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3c9118a04279ea… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Oct 24 09:29:00 2012 +0200 Added comments in check --- checks/winperf_phydisk | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/checks/winperf_phydisk b/checks/winperf_phydisk index 82002a2..be20e76 100644 --- a/checks/winperf_phydisk +++ b/checks/winperf_phydisk @@ -31,13 +31,13 @@ # 198 0 0 rawcount # 200 3716463928 3716463928 type(20570500) # 200 3454184016 3454184016 type(40030500) -# 1400 3716463928 3716463928 type(550500) +# 1400 3716463928 3716463928 type(550500) -----> Average Disk Queue Length # 202 1070680520 1070680520 type(20570500) # 202 3454184016 3454184016 type(40030500) -# 1402 1070680520 1070680520 type(550500) +# 1402 1070680520 1070680520 type(550500) -----> Average Disk Read Queue Length # 204 2645783408 2645783408 type(20570500) # 204 3454184016 3454184016 type(40030500) -# 1404 2645783408 2645783408 type(550500) +# 1404 2645783408 2645783408 type(550500) -----> Average Disk Write Queue Length # 206 627690886 627690886 average_timer # 206 571096 571096 average_base # 208 1856854327 1856854327 average_timer

11 years, 10 months

Check_MK Git: check_mk: zfslist: fix mixed up columns avail and total

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 6e07920f40a372467be2878b2637354494e42515 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=6e07920f40a372… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Oct 24 13:59:29 2012 +0200 zfslist: fix mixed up columns avail and total --- checks/zfslist | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/checks/zfslist b/checks/zfslist index 9130850..406e42f 100644 --- a/checks/zfslist +++ b/checks/zfslist @@ -38,7 +38,7 @@ # rpool/export/opt 842M 887G /opt # rpool/swap 8.00G 893G - # -# The columns are: name, used, avail, mountpoint +# The columns are: name, used, total, mountpoint def inventory_zfslist(info): @@ -62,12 +62,11 @@ def convert_zfssize(txt): def check_zfslist(item, params, info): fslist = [] - for name, used_txt, avail_txt, mountpoint in info: + for name, used_txt, total_txt, mountpoint in info: if "patterns" in params or item == mountpoint: used_mb = convert_zfssize(used_txt) - avail_mb = convert_zfssize(avail_txt) - size_mb = used_mb + avail_mb - fslist.append((mountpoint, size_mb, avail_mb)) + total_mb = convert_zfssize(total_txt) + fslist.append((mountpoint, total_mb, total_mb - used_mb)) return df_check_filesystem_list(item, params, fslist)

11 years, 10 months

Check_MK Git: check_mk: Reserved 10 bug IDS

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 6caa6da28b91f6f13175d161127bfed7df71e3ec URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=6caa6da28b91f6… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Oct 24 13:38:46 2012 +0200 Reserved 10 bug IDS --- .bugs/first_free | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/.bugs/first_free b/.bugs/first_free index 6966b4b..659400d 100644 --- a/.bugs/first_free +++ b/.bugs/first_free @@ -1 +1 @@ -867 +877

11 years, 10 months

Check_MK Git: check_mk: Merge branch 'master' of mathias-kettner.de: check_mk

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 98527468b31239b01c03aeedc927fe6ae2667936 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=98527468b31239… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Oct 24 13:37:29 2012 +0200 Merge branch 'master' of mathias-kettner.de:check_mk Conflicts: .bugs/first_free ChangeLog ---

11 years, 10 months

Check_MK Git: check_mk: logwatch_ec: Added new subcheck to forward all incoming logwatch

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: c8473180f2aedb8aba65cbf8389abb071a2ba3e1 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c8473180f2aedb… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Oct 24 13:03:02 2012 +0200 logwatch_ec: Added new subcheck to forward all incoming logwatch messages to the event console. With this check you can use the Event Console mechanisms and GUIs instead of the classic logwatch GUI. It can be enabled on "Global Settings" page in WATO for your whole installation. After enabling it you need to reinventorize your hosts. --- ChangeLog | 6 ++ checkman/logwatch | 7 +- checkman/logwatch_ec | 21 +++++ checks/logwatch | 129 ++++++++++++++++++++++++++-- web/plugins/wato/check_mk_configuration.py | 11 +++ web/plugins/wato/check_parameters.py | 86 ++++++++++++++++++ 6 files changed, 251 insertions(+), 9 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=c8473180f2…

11 years, 10 months

Check_MK Git: check_mk: Added optional site filter to notifications and events list views

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 1ca41f3157b7718b4dafa00f02f06fce29578cbe URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1ca41f3157b771… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Oct 23 08:56:56 2012 +0200 Added optional site filter to notifications and events list views --- web/plugins/views/builtin.py | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/web/plugins/views/builtin.py b/web/plugins/views/builtin.py index ea1c0e9..49bd369 100644 --- a/web/plugins/views/builtin.py +++ b/web/plugins/views/builtin.py @@ -1557,7 +1557,8 @@ multisite_builtin_views.update({ 'description': 'All historic events of hosts or services (alerts, downtimes, etc.)', 'group_painters': [('log_date', None)], 'hard_filters': [], - 'hard_filtervars': [('host', ''), + 'hard_filtervars': [('site', ''), + ('host', ''), ('service', ''), ('logtime_from_range', '86400'), ('logtime_from', '7'), @@ -1580,7 +1581,8 @@ multisite_builtin_views.update({ ('log_plugin_output', None)], 'play_sounds': False, 'public': True, - 'show_filters': ['hostregex', + 'show_filters': ['siteopt', + 'hostregex', 'serviceregex', 'logtime', 'log_plugin_output', @@ -2696,6 +2698,7 @@ multisite_builtin_views.update({ ('logclass4', ''), ('logclass5', ''), ('logclass6', ''), + ('site', ''), ('host', ''), ('service', ''), ('log_plugin_output', ''), @@ -2723,7 +2726,8 @@ multisite_builtin_views.update({ ('log_plugin_output', None, '')], 'play_sounds': False, 'public': True, - 'show_filters': ['hostregex', + 'show_filters': ['siteopt', + 'hostregex', 'serviceregex', 'log_plugin_output', 'logtime',

11 years, 10 months

Check_MK Git: check_mk: Updated bug entries #0817

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 2cffbf7f1bbad490881574eff57c9fdebd0a63d4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2cffbf7f1bbad4… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Oct 23 10:16:16 2012 +0200 Updated bug entries #0817 --- .bugs/817 | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/.bugs/817 b/.bugs/817 new file mode 100644 index 0000000..bf07275 --- /dev/null +++ b/.bugs/817 @@ -0,0 +1,9 @@ +Title: PING check removed when legacy check added to host +Component: core +State: open +Date: 2012-10-23 10:15:13 +Targetversion: future +Class: nastiness + +The PING check should remain on the host when the host has the tag +"ping" assigned, event when a legacy check has been added to the host.

11 years, 10 months

Check_MK Git: check_mk: Reserved 10 bug IDS

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: d5773ce160469c58f5455138e83129c7c6bee329 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d5773ce160469c… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Oct 23 10:15:11 2012 +0200 Reserved 10 bug IDS --- .bugs/first_free | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/.bugs/first_free b/.bugs/first_free index ae645ab..9ebf09b 100644 --- a/.bugs/first_free +++ b/.bugs/first_free @@ -1 +1 @@ -817 +827

11 years, 10 months

← Newer
1
2
3
4
5
6
7
8
...
26
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits October 2012