Checkmk git commits January 2012

checkmk-commits@lists.checkmk.com

2 participants
334 discussions

Check_MK Git: check_mk: Updated bug entries #0593

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: 50a4276cbe71ae433fa9fc049d4de1aca557d3ba URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=50a4276cbe71ae… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jan 20 15:58:34 2012 +0100 Updated bug entries #0593 --- .bugs/593 | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.bugs/593 b/.bugs/593 index cb5172f..3fed623 100644 --- a/.bugs/593 +++ b/.bugs/593 @@ -1,9 +1,12 @@ Title: Permissions of snapshot dir are wrong after switch form OMD own to shared Component: wato -State: open +Class: nastiness +State: done Date: 2012-01-13 18:51:03 Targetversion: 1.2.0 -Class: nastiness a chmod 775 is missing for the snapshot directory. Maybe same for the auth directory and others. + +2012-01-20 15:58:06: changed state open -> done +Müsste erledigt sein. Permissions File in unseren Builds ist angepasst und mkdir Befehl im wato auch.

12 years, 5 months

Check_MK Git: check_mk: Updated bug entries #0624

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: 23720075ae40e8481d52ad441764188a4abe5cd2 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=23720075ae40e8… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jan 20 15:55:04 2012 +0100 Updated bug entries #0624 --- .bugs/624 | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/.bugs/624 b/.bugs/624 new file mode 100644 index 0000000..485d598 --- /dev/null +++ b/.bugs/624 @@ -0,0 +1,8 @@ +Title: WATO Folder Filter wird auch bei single host views angezeigt +Component: multisite +State: open +Date: 2012-01-20 15:54:20 +Targetversion: 1.2.0 +Class: nastiness + +Der Filter ist in solchen Ansichten eigentlich sinnlos.

12 years, 5 months

Check_MK Git: check_mk: Merge branch 'master' of ssh://git.mathias-kettner. de/var/www/80/git.mathias-kettner.de/check_mk

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: 70a8bf50f1f41b285c211dcdc45da3f281263a95 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=70a8bf50f1f41b… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jan 20 15:58:37 2012 +0100 Merge branch 'master' of ssh://git.mathias-kettner.de/var/www/80/git.mathias-kettner.de/check_mk ---

12 years, 5 months

Check_MK Git: check_mk: Simplify hook implementation in WATO

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: e51767c611ae447fd204929f97c1f23663afc604 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e51767c611ae44… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Jan 20 14:39:03 2012 +0100 Simplify hook implementation in WATO --- web/htdocs/wato.py | 15 ++------------- 1 files changed, 2 insertions(+), 13 deletions(-) diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index a0df5b0..a202235 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -6997,7 +6997,7 @@ def save_users(profiles): os.remove(auth_file) # Call the users_saved hook - call_hook(call_hook_users_saved, users) + call_hook_users_saved(users) # Dropdown for choosing a multisite user class UserSelection(ElementSelection): @@ -7337,7 +7337,7 @@ def save_roles(roles): out.write("# Written by WATO\n# encoding: utf-8\n\n") out.write("roles.update(\n%s)\n" % pprint.pformat(roles)) - call_hook(call_hook_roles_saved, roles) + call_hook_roles_saved(roles) # Adapt references in users. Builtin rules cannot @@ -9400,17 +9400,6 @@ def call_hooks(name, *args): traceback.print_exception(t, v, tb, None, txt) html.show_error("<h3>" + _("Error executing hook") + " %s #%d: %s</h3><pre>%s</pre>" % (name, n, e, txt.getvalue())) -# Call the hooks. This is executed at the places where to run the hooks -# This includes exception handling with raising user errors on exceptions -def call_hook(handler, *args): - try: - handler(*args) - except Exception, e: - if config.debug: - raise - else: - raise MKUserError(None, "Error executing hooks: %s" % str(e)) - def call_hook_hosts_changed(folder): if "hosts-changed" in g_hooks: hosts = collect_hosts(folder)

12 years, 5 months

Check_MK Git: check_mk: Updated bug entries #0602, #0575

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: da82ab8d57cfcb6e89787dcde19529962bf56c43 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=da82ab8d57cfcb… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Jan 20 14:29:09 2012 +0100 Updated bug entries #0602, #0575 --- .bugs/575 | 15 +++++++++++++-- .bugs/602 | 9 +++++++++ 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/.bugs/575 b/.bugs/575 index 4539889..09ee9b0 100644 --- a/.bugs/575 +++ b/.bugs/575 @@ -6,5 +6,16 @@ Targetversion: 1.2.0 Class: nastiness This will be an unloved request... -We will need an option to undo a change that has been "clicked" but is still waiting for activation. -In a larger setup there could be 20 pending changes because the admin(s) will try to match nagios downtimes for activation or some other se. on the other hand right now you need to COMMIT a change into the live configuration to UNDO it - even if you already noticed it was erronoeous. (Ja, ich kann heute nicht tippen) + +We will need an option to undo a change that has been "clicked" but is still +waiting for activation. In a larger setup there could be 20 pending changes +because the admin(s) will try to match nagios downtimes for activation +or some other se. on the other hand right now you need to COMMIT a change +into the live configuration to UNDO it - even if you already noticed it was +erronoeous. (Ja, ich kann heute nicht tippen) + +WONTFIX: This is impossible to implement. Changes are not stored as files +ore transactions but are direct modifications to the config files. Also +changes build are built on previous changes. The only possible thing is +to make a snapshot and get back to the snapshot later. + diff --git a/.bugs/602 b/.bugs/602 new file mode 100644 index 0000000..68a036a --- /dev/null +++ b/.bugs/602 @@ -0,0 +1,9 @@ +Title: Restoring snapshots does not restore htpasswd +Component: wato +State: open +Date: 2012-01-20 14:28:22 +Targetversion: 1.2.0 +Class: bug + +When restoring a snapshot, the etc/htpasswd file should also be restored. +Or is this already implemented?

12 years, 5 months

Check_MK Git: check_mk: REmoved debug output - ooops

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: 289fff63da4f79c15980927224758a19aa4562d8 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=289fff63da4f79… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jan 20 12:42:17 2012 +0100 REmoved debug output - ooops --- web/htdocs/login.py | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/web/htdocs/login.py b/web/htdocs/login.py index 774418a..0f74f53 100644 --- a/web/htdocs/login.py +++ b/web/htdocs/login.py @@ -146,7 +146,6 @@ def do_login(): # handle the sent login form err = None if html.var('_login'): - html.write('xxxxx') try: username = html.var('_username', '') if username == '':

12 years, 5 months

Check_MK Git: check_mk: wato: adding debug parameter to automation urls when multisite debug is enabled

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: eca6e157fc63786c31a2db8f38e00e63b5f7ffef URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=eca6e157fc6378… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jan 20 12:06:57 2012 +0100 wato: adding debug parameter to automation urls when multisite debug is enabled --- .bugs/525 | 7 +++++-- .bugs/576 | 7 +++++-- web/htdocs/wato.py | 8 ++++++-- 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/.bugs/525 b/.bugs/525 index f6c1423..5e0f075 100644 --- a/.bugs/525 +++ b/.bugs/525 @@ -1,8 +1,11 @@ Title: WATO replication over HTTPS does not work Component: wato -State: open +Class: bug +State: done Date: 2011-12-23 12:17:16 Targetversion: 1.2.0 -Class: bug Reason probable self signed certificates. + +2012-01-20 11:31:32: changed state open -> done +Has been solved. There is a new option to disable the ssl certificate check of curl. diff --git a/.bugs/576 b/.bugs/576 index 13620b7..19a9285 100644 --- a/.bugs/576 +++ b/.bugs/576 @@ -1,9 +1,9 @@ Title: Host tags are lost in WATO display Component: wato -State: open +Class: bug +State: done Date: 2012-01-11 09:59:37 Targetversion: 1.1.13i1 -Class: bug siehe mail: Re: [Check_mk (english)] display problem in WATO, cmk 1.1.13i2 from scott @@ -11,3 +11,6 @@ from scott 2.: Even worse, if I were to save here without reselecting “Test” it will set the host back to Production! So, by just viewing and saving this host, like you might do to get to services, I set all the tags back to defaults fh saw the same issue + +2012-01-20 11:32:09: changed state open -> done +Has already been fixed days ago. diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index 86f835b..4d6117c 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -5842,8 +5842,11 @@ def do_remote_automation(site, command, vars): raise MKAutomationException(_("You are not logged into the remote site.")) url = base_url + "automation.py?" + \ - htmllib.urlencode_vars( - [("command", command), ("secret", secret)] + vars) + htmllib.urlencode_vars([ + ("command", command), + ("secret", secret), + ("debug", config.debug and '1' or '') + ] + vars) connection = open_url(url) response_code = connection.read().strip() if not response_code: @@ -6089,6 +6092,7 @@ def push_snapshot_to_site(site, do_restart): ("siteid", site["id"]), # This site must know it's ID ("mode", mode), ("restart", do_restart and "yes" or "on"), + ("debug", config.debug and "1" or ""), ]) url = url_base + var_string # urllib2 does not seem to support file uploads. Please tell me, if

12 years, 5 months

Check_MK Git: check_mk: Updated bug entries #0592

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: c2e33ea6fcb8656fb3b460339f0a407a3818feb1 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c2e33ea6fcb865… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jan 20 12:09:18 2012 +0100 Updated bug entries #0592 --- .bugs/592 | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.bugs/592 b/.bugs/592 index 1f6cfd7..8d0607b 100644 --- a/.bugs/592 +++ b/.bugs/592 @@ -1,8 +1,11 @@ Title: Multisite Debug Parameter an check_mk automation commands übergeben (z.b. wato restart) Component: wato -State: open +Class: feature +State: done Date: 2012-01-13 10:01:05 Targetversion: 1.2.0 -Class: feature Aktuell muss man den Befehl dann manuell aufrufen um die Exception zu bekommen + +2012-01-20 12:09:15: changed state open -> done +Has been implemented.

12 years, 5 months

Check_MK Git: check_mk: WATO: Fixed permissions of snapshot/ folder directories

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: 352b3b7ccd0b741b7306fa53b45b5c496d6d9565 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=352b3b7ccd0b74… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jan 20 12:22:14 2012 +0100 WATO: Fixed permissions of snapshot/folder directories --- web/htdocs/wato.py | 3 +-- web/plugins/wato/auth.py | 4 +--- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index 4d6117c..a0df5b0 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -4246,8 +4246,7 @@ def mode_snapshot(phase): def create_snapshot(): - if not os.path.exists(snapshot_dir): - os.mkdir(snapshot_dir) + make_nagios_directory(snapshot_dir) snapshot_name = "wato-snapshot-%s.tar.gz" % \ time.strftime("%Y-%m-%d-%H-%M-%S", time.localtime(time.time())) diff --git a/web/plugins/wato/auth.py b/web/plugins/wato/auth.py index 1139600..343d9cb 100644 --- a/web/plugins/wato/auth.py +++ b/web/plugins/wato/auth.py @@ -184,9 +184,7 @@ function may($username, $need_permission) { ''' % (parse_php(users), parse_php(role_permissions), parse_php(folder_permissions))) def create_auth_file(users): - if not os.path.exists(g_auth_base_dir): - os.mkdir(g_auth_base_dir) - + make_nagios_directory(g_auth_base_dir) create_php_file(users, config.get_role_permissions(), get_folder_permissions_of_users(users)) api.register_hook('users-saved', create_auth_file)

12 years, 5 months

Check_MK Git: check_mk: Updated bug entries #0426

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: ff19e6c02e103f4aaa40e8aab44f34409974872f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ff19e6c02e103f… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jan 20 10:29:23 2012 +0100 Updated bug entries #0426 --- .bugs/426 | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.bugs/426 b/.bugs/426 index 4eec219..b43007d 100644 --- a/.bugs/426 +++ b/.bugs/426 @@ -1,11 +1,11 @@ Title: hpux_cpu problem parsing uptime info Component: checks +State: done +Class: bug Benefit: 1 -State: open Cost: 4 Date: 2011-10-21 12:55:23 Targetversion: 1.2.0 -Class: bug The check seems to trip while parsing the uptime output. uptime returns a variable string that is calculated to print out human- @@ -26,3 +26,6 @@ check_hpux_cpu_load '0.14,', '0.13']] + +2012-01-20 10:29:14: changed state open -> done +The check now handles the missing second line in agent output. Assuming 1 cpu in this case.

12 years, 5 months

← Newer
1
...
11
12
13
14
15
16
17
...
34
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits January 2012