Module: check_mk
Branch: master
Commit: 36cb67e8d33d257ab37d17ca21313a38515bfdc9
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=36cb67e8d33d25…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Sat Aug 13 17:52:44 2011 +0200
snmp_info, snmp_uptime: added scan functions
Please use ignored_checktypes or ignored_checks, if
not wantet. Wenn really need a scan function in order
for WATO to work.
---
.bugs/174 | 33 ++++++++++++++++++++++++++++-----
ChangeLog | 2 ++
checks/snmp_info | 4 ++--
checks/snmp_uptime | 4 ++--
4 files changed, 34 insertions(+), 9 deletions(-)
diff --git a/.bugs/174 b/.bugs/174
index 1d552aa..4cef006 100644
--- a/.bugs/174
+++ b/.bugs/174
@@ -1,9 +1,32 @@
-Title: Reinventory removes e.g. snmp_uptime check when not given via cmdline
+Title: Reinventory removes e.g. snmp_info check when not given via cmdline
Component: core
+State: done
+Class: bug
+Date: 2011-03-03 09:56:23
Benefit: 3
-State: open
Cost: 2
-Date: 2011-03-03 09:56:23
-Class: bug
+Fun: 0
+
+When a service has been added with --checks info -I <hostname> and one executes
+a re-inventory for all checks then snmp_info check is lost and needs to be re-added with
+--checks snmp_info -I or --checks snmp_info -II.
+
+What could be a solution? Possible are:
+
+- Do not remove checks without a a scan function on -II.
+ But how do we know that there is no scan function? Or just
+ remove checks with a positive result of the scan function?
+ Sound complicated to implement.
+ Maybe add an option -III which then removes all? Or depend
+ on --flush for removing all autochecks.
+
+ Problem is anyway: Check without a scan function do not
+ work well (at all) in WATO.
+
+- Make a scan function for snmp_info and friends and
+ propose ignored_checktypes in the Migration notes.
+
-When a service has been added with --checks snmp_uptime -I <hostname> and one executes a re-inventory for all checks the snmp_uptime check is lost and needs to be re-added with --checks snmp_uptime -I or --checks snmp_uptime -II.
+2011-08-13 17:49:57: changed state discuss -> done
+Added scan functions. Will add a note to the migration notes
+of how to disable the check.
diff --git a/ChangeLog b/ChangeLog
index 0e5acd1..317afe2 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -25,6 +25,8 @@
* FIX: cisco_temp_perf: add critical level to performance data
* FIX: windows agent: hopefully fix case with quotes in directory name
* FIX: printer_supply: fixed logic of Perf-O-Meter (mixed up crit with ok)
+ * snmp_uptime, snmp_info: added scan functions. These checks will now
+ always be added. Please use ingored_checktypes to disable, if non needed.
* brocade_port: check for Brocade FC ports has been rewritten with
lots of new features.
* AIX agent now simulates <<<netctr>>> output (by Jörg Linge)
diff --git a/checks/snmp_info b/checks/snmp_info
index 635d241..a0b9f54 100644
--- a/checks/snmp_info
+++ b/checks/snmp_info
@@ -37,5 +37,5 @@ def check_snmp_info(checktype, params, info):
check_info['snmp_info'] = (check_snmp_info, "SNMP Info", 0, inventory_snmp_info)
snmp_info['snmp_info'] = ( ".1.3.6.1.2.1.1", [ '1.0', '4.0', '5.0', '6.0', ] )
-# Do not use this check per default
-snmp_scan_functions['snmp_info'] = lambda oid: False
+# This check works on all SNMP hosts
+snmp_scan_functions['snmp_info'] = lambda oid: oid(".1.3.6.1.2.1.1.1.0") != None
diff --git a/checks/snmp_uptime b/checks/snmp_uptime
index 70e7aea..b0131ff 100644
--- a/checks/snmp_uptime
+++ b/checks/snmp_uptime
@@ -47,5 +47,5 @@ def check_snmp_uptime(checktype, params, info):
check_info['snmp_uptime'] = (check_snmp_uptime, "Uptime", 1, inventory_snmp_uptime)
snmp_info['snmp_uptime'] = ( ".1.3.6.1.2.1.1", [ '3.0' ] ) # DISMAN-EVENT-MIB::sysUpTime
-# Do not use this check per default
-snmp_scan_functions['snmp_uptime'] = lambda oid: False
+# This check works on all SNMP hosts
+snmp_scan_functions['snmp_uptime'] = lambda oid: oid(".1.3.6.1.2.1.1.1.0") != None
Module: check_mk
Branch: master
Commit: 22ba41fd291fda7ec025f995ee04c84f793fddcd
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=22ba41fd291fda…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Sat Aug 13 17:53:22 2011 +0200
Updated bugs
---
.bugs/160 | 10 +++++++---
.bugs/232 | 14 +++++++++++---
.bugs/config | 9 +++++----
3 files changed, 23 insertions(+), 10 deletions(-)
diff --git a/.bugs/160 b/.bugs/160
index 4aaa475..e5a0ef7 100644
--- a/.bugs/160
+++ b/.bugs/160
@@ -1,9 +1,13 @@
Title: Uptime-Check for SNMP hosts
Component: checks
+State: done
+Class: feature
+Date: 2011-02-27 13:18:21
Benefit: 1
-State: open
Cost: 1
-Date: 2011-02-27 13:18:21
-Class: feature
+Fun: 0
Like the agent based one but retrieved via SNMP.
+
+2011-08-13 17:46:18: changed state open -> done
+Such a check exists now (snmp_uptime).
diff --git a/.bugs/232 b/.bugs/232
index efe65a4..914ea49 100644
--- a/.bugs/232
+++ b/.bugs/232
@@ -1,12 +1,20 @@
Title: lnx_if greift auch bei nicht-linux agents
Component: checks
+State: wontfix
+Class: bug
+Date: 2011-04-11 16:41:52
Benefit: 5
-State: open
Cost: 2
-Date: 2011-04-11 16:41:52
-Class: bug
+Fun: 0
offenbar greift der lnx_if auch wenn ein agent-OS != linux vom agent gemeldet wird.
das fuehrt dazu, dass durch das umstellen des linux if-checks andere OS auch betroffen sind und ihre interfaces nicht mehr inventorisierbar sind.
beim reinventorisieren muss man also mindestens mit tag "linux" arbeiten oder so.
waere aber schoener, wenn agent OS - und auch die agent version - angescden
+
+2011-08-13 16:55:51: changed state open -> wontfix
+Der Free-BSD agent sollte nicht versuchen, die Ausgabe von Linux
+nachzubauen. Besser man macht hier einen eigenen Check, der seinerseits
+auch auf if.include aufsetzt.
+
+Die alten Linux-Checks fliegen zur 1.1.13i raus.
diff --git a/.bugs/config b/.bugs/config
index bc9ba69..291e284 100644
--- a/.bugs/config
+++ b/.bugs/config
@@ -1,8 +1,9 @@
states = {
- "open" : tty_blue,
- "done" : tty_green,
- "closed" : tty_normal,
- "wontfix" : tty_magenta,
+ "open" : tty_blue,
+ "done" : tty_green,
+ "closed" : tty_normal,
+ "wontfix" : tty_magenta,
+ "discuss" : tty_red,
}
components = [
Module: check_mk
Branch: master
Commit: 92c9614bd82b6b9f6ccad63f984251313fdeaa02
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=92c9614bd82b6b…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Sun Aug 14 11:09:04 2011 +0200
Updated bug entries
---
.bugs/243 | 11 ++++++++---
.bugs/264 | 11 ++++++++---
2 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/.bugs/243 b/.bugs/243
index f42eddb..28359dc 100644
--- a/.bugs/243
+++ b/.bugs/243
@@ -1,10 +1,11 @@
Title: Removal of brackets from regular expression is broken
Component: bi
+State: wontfix
+Class: bug
+Date: 2011-04-07 17:52:29
Benefit: 1
-State: open
Cost: 2
-Date: 2011-04-07 17:52:29
-Class: bug
+Fun: 0
Invalid regular expression '(zbghora12)):((zbghora13)$': unbalanced parenthesis.
@@ -33,3 +34,7 @@ aggregation_rules["database_cluster"] = (
Problem here: from ((.*))((.*)) we must not remove the leftmost
and rightmost brackets!
+
+2011-08-13 18:02:07: changed state open -> wontfix
+This does not apply anymore. The whole regular expression
+matching has been removed from BI meanwhile.
diff --git a/.bugs/264 b/.bugs/264
index d236250..820ffc8 100644
--- a/.bugs/264
+++ b/.bugs/264
@@ -1,10 +1,11 @@
Title: Windows agent: handle quotes in directory names
Component: checks
+State: done
+Class: bug
+Date: 2011-05-04 13:05:20
Benefit: 2
-State: open
Cost: 2
-Date: 2011-05-04 13:05:20
-Class: bug
+Fun: 0
The Windows agent has Problems in W2008 64 Bit since there
are appearing nasty quotes in the directory names. Here is
@@ -90,3 +91,7 @@ die ich beim Programmierer abzwacken konnte…
Ein Feature Request wäre die Übernahme der Änderungen in den nächsten
Innovations build und die Anführungszeichen automatisch beim Installieren
des Services.
+
+2011-08-13 18:01:06: changed state open -> done
+Das sollte jetzt funktionieren. Ein erfolgreicher
+Test steht noch aus.
Module: check_mk
Branch: master
Commit: 35dc41428f2dd5c04a347ee4dffb78b35064ab6c
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=35dc41428f2dd5…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Sat Aug 13 10:39:57 2011 +0200
ntp.time: make CRIT, if peers are present but not used
---
checkman/ntp.time | 4 ++++
checks/ntp | 2 +-
2 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/checkman/ntp.time b/checkman/ntp.time
index 72086a7..4de01e9 100644
--- a/checkman/ntp.time
+++ b/checkman/ntp.time
@@ -15,6 +15,10 @@ description:
is UNKNOWN if no system peer is present or the system peer is
unreachable.
+ The check is CRIT, when there are NTP peers reachable but non
+ of those is used by the NTP daemon. That is the case if the time
+ provided by those peers is too bad.
+
Note: If you want to check the health of the peers, you might
want to use {ntp}, which creates one individual check per NTP peer.
diff --git a/checks/ntp b/checks/ntp
index b108b44..6c988a5 100644
--- a/checks/ntp
+++ b/checks/ntp
@@ -144,7 +144,7 @@ def check_ntp_summary(item, params, info):
state, text, perfdata = check_ntp(line[1], params, [line])
text += " (synchronized on %s)" % line[1]
return (state, text, perfdata)
- return (3, "UNKNOWN - no system peer found")
+ return (2, "CRIT - found %d peers, but none is suitable" % len(info))
check_info['ntp'] = (check_ntp, "NTP Peer %s", 1, inventory_ntp)
check_info['ntp.time'] = (check_ntp_summary, "NTP Time", 1, inventory_ntp_summary)
Module: check_mk
Branch: master
Commit: 46e0f8f02f5f6ee2a502c3d3f63318f8061aeff1
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=46e0f8f02f5f6e…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Sat Aug 13 10:36:36 2011 +0200
ntp.time: handle case where ntpq has empty output
---
checks/ntp | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/checks/ntp b/checks/ntp
index 62708d1..b108b44 100644
--- a/checks/ntp
+++ b/checks/ntp
@@ -134,6 +134,10 @@ def check_ntp(item, params, info):
return (3, "UNKNOWN - peer not found")
def check_ntp_summary(item, params, info):
+ # No information at all? NTP daemon not running or timeout in ntpq -p
+ if len(info) == 0:
+ return (3, "UNKNOWN - no information from NTP: timeout in ntpq -p or NTP daemon not running")
+
# We only are interested in our system peer or pulse per second source (pps)
for line in info:
if line[0] in [ "*", "o" ]: